[PATCH] Fixup quote parsing of kernel arguments

2015-04-02 Thread Arthur Gautier
When starting kernel with arguments like: init=/bin/sh -c "echo arguments" the trailing double quote is not removed which results in following command being executed: /bin/sh -c 'echo arguments"' This commit removes the trailing double quote. Signed-off-by: Ar

[PATCH] param: fixup quote parsing of kernel arguments

2015-04-07 Thread Arthur Gautier
When starting kernel with arguments like: init=/bin/sh -c "echo arguments" the trailing double quote is not removed which results in following command being executed: /bin/sh -c 'echo arguments"' This commit removes the trailing double quote. Signed-off-by: Ar

Re: [PATCH] param: fixup quote parsing of kernel arguments

2015-04-08 Thread Arthur Gautier
On Wed, Apr 08, 2015 at 03:29:43PM +0930, Rusty Russell wrote: > Arthur Gautier writes: > > When starting kernel with arguments like: > > init=/bin/sh -c "echo arguments" > > the trailing double quote is not removed which results in following command > > b

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-10-10 Thread Arthur Gautier
On Thu, Sep 26, 2019 at 04:09:39PM +0200, Borislav Petkov wrote: > On Thu, Sep 26, 2019 at 09:58:25AM +0000, Arthur Gautier wrote: > > I think Andy submitted a patch Feb 25 2019, but I was not copied on it > > (I believe it was sent to x...@kernel.org) and I don't know w

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-09-26 Thread Arthur Gautier
On Mon, Feb 18, 2019 at 09:51:50PM +, Arthur Gautier wrote: > On Mon, Feb 18, 2019 at 11:15:44AM -0800, Andy Lutomirski wrote: > > This seems like it's just papering over the underlying problem: with > > Jann's new checks in place, strncpy_from_user() is simply buggy.

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-18 Thread Arthur Gautier
On Mon, Feb 18, 2019 at 11:15:44AM -0800, Andy Lutomirski wrote: > This seems like it's just papering over the underlying problem: with > Jann's new checks in place, strncpy_from_user() is simply buggy. Does > the patch below look decent? It's only compile-tested, but it's > conceptually straight

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-16 Thread Arthur Gautier
On Sat, Feb 16, 2019 at 11:47:02PM +, Al Viro wrote: > On Sat, Feb 16, 2019 at 02:50:15PM -0800, Andy Lutomirski wrote: > > > What is the actual problem? We’re not actually demand-faulting this data, > > are we? Are we just overrunning the buffer because the from_user helpers > > are too c