Pass the exact length of the string to is_printable_array instead of the
entire field size.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
tools/perf/util/scripting-engines/trace-event-python.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tool
Pass the exact length of the string to is_printable_array instead of the
entire field size.
Signed-off-by: Arun Kalyanasundaram
---
tools/perf/util/scripting-engines/trace-event-python.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/scripting
that represent the
string.
This change calls is_printable_array with the correct length of the string
instead of the entire field size.
Bug report: lkml/2017/7/18/228
Arun Kalyanasundaram (1):
perf script python: Garbled text in tracepoint fields
tools/perf/util/scripting-engines/trace-event
that represent the
string.
This change calls is_printable_array with the correct length of the string
instead of the entire field size.
Bug report: lkml/2017/7/18/228
Arun Kalyanasundaram (1):
perf script python: Garbled text in tracepoint fields
tools/perf/util/scripting-engines/trace-event
Commit-ID: f38d281663b011d1d8a1b0119bb8357706d134a8
Gitweb: http://git.kernel.org/tip/f38d281663b011d1d8a1b0119bb8357706d134a8
Author: Arun Kalyanasundaram <arunk...@google.com>
AuthorDate: Fri, 21 Jul 2017 15:04:21 -0700
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit-ID: f38d281663b011d1d8a1b0119bb8357706d134a8
Gitweb: http://git.kernel.org/tip/f38d281663b011d1d8a1b0119bb8357706d134a8
Author: Arun Kalyanasundaram
AuthorDate: Fri, 21 Jul 2017 15:04:21 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 25 Jul 2017 22:43:20 -0300
perf
Commit-ID: a641860550f05a4b8889dca61aab73c84b2d5e16
Gitweb: http://git.kernel.org/tip/a641860550f05a4b8889dca61aab73c84b2d5e16
Author: Arun Kalyanasundaram <arunk...@google.com>
AuthorDate: Fri, 21 Jul 2017 15:04:22 -0700
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit-ID: a641860550f05a4b8889dca61aab73c84b2d5e16
Gitweb: http://git.kernel.org/tip/a641860550f05a4b8889dca61aab73c84b2d5e16
Author: Arun Kalyanasundaram
AuthorDate: Fri, 21 Jul 2017 15:04:22 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 25 Jul 2017 22:43:21 -0300
perf
Commit-ID: 74ec14f3893c3065053b91cec850cffa2d565e0a
Gitweb: http://git.kernel.org/tip/74ec14f3893c3065053b91cec850cffa2d565e0a
Author: Arun Kalyanasundaram <arunk...@google.com>
AuthorDate: Fri, 21 Jul 2017 15:04:20 -0700
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit-ID: 74ec14f3893c3065053b91cec850cffa2d565e0a
Gitweb: http://git.kernel.org/tip/74ec14f3893c3065053b91cec850cffa2d565e0a
Author: Arun Kalyanasundaram
AuthorDate: Fri, 21 Jul 2017 15:04:20 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 25 Jul 2017 22:43:19 -0300
perf
Commit-ID: 892e76b2e8c5e85e69514478e3319575a68b9770
Gitweb: http://git.kernel.org/tip/892e76b2e8c5e85e69514478e3319575a68b9770
Author: Arun Kalyanasundaram <arunk...@google.com>
AuthorDate: Fri, 21 Jul 2017 15:04:19 -0700
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit-ID: 892e76b2e8c5e85e69514478e3319575a68b9770
Gitweb: http://git.kernel.org/tip/892e76b2e8c5e85e69514478e3319575a68b9770
Author: Arun Kalyanasundaram
AuthorDate: Fri, 21 Jul 2017 15:04:19 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 25 Jul 2017 22:43:19 -0300
perf
Commit-ID: e9f9a9ca8588e58dc0800b44adc41d32f6fc813a
Gitweb: http://git.kernel.org/tip/e9f9a9ca8588e58dc0800b44adc41d32f6fc813a
Author: Arun Kalyanasundaram <arunk...@google.com>
AuthorDate: Fri, 21 Jul 2017 15:04:18 -0700
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit-ID: e9f9a9ca8588e58dc0800b44adc41d32f6fc813a
Gitweb: http://git.kernel.org/tip/e9f9a9ca8588e58dc0800b44adc41d32f6fc813a
Author: Arun Kalyanasundaram
AuthorDate: Fri, 21 Jul 2017 15:04:18 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 25 Jul 2017 22:43:18 -0300
perf
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 94 --
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 94 --
1 file changed, 53 insertions
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tool
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tools/perf/util/scripting-engines
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
Changes in v2:
- Make an explicit call to Py_INCREF on callchain in p
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram
---
Changes in v2:
- Make an explicit call to Py_INCREF on callchain in process
tracepoint to keep
Provide time_enabled, time_running and counter value in the perf_sample
dict.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 51 ++
1 file changed, 51 insertions(+)
diff --git a/tools/perf/util/scr
Provide time_enabled, time_running and counter value in the perf_sample
dict.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 51 ++
1 file changed, 51 insertions(+)
diff --git a/tools/perf/util/scripting-engines/trace-event
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c
unnecessary work), do not pass the
aforementioned dict if the number of arguments signals that handler version
predates this change.
In addition, provide time_enabled, time_running and counter value in the
perf_sample dict.
Initial Discussion: https://lkml.org/lkml/2017/7/1/108
Arun Kalyanasundaram (5
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 22 ++
1
unnecessary work), do not pass the
aforementioned dict if the number of arguments signals that handler version
predates this change.
In addition, provide time_enabled, time_running and counter value in the
perf_sample dict.
Initial Discussion: https://lkml.org/lkml/2017/7/1/108
Arun Kalyanasundaram (5
org> wrote:
> Em Fri, Jul 21, 2017 at 09:46:39AM +0200, Jiri Olsa escreveu:
>> On Thu, Jul 20, 2017 at 07:01:13PM -0700, Arun Kalyanasundaram wrote:
>> > The process_event python hook receives a dict with most perf_sample
>> > entries.
>>
>> hi,
&
Fri, Jul 21, 2017 at 09:46:39AM +0200, Jiri Olsa escreveu:
>> On Thu, Jul 20, 2017 at 07:01:13PM -0700, Arun Kalyanasundaram wrote:
>> > The process_event python hook receives a dict with most perf_sample
>> > entries.
>>
>> hi,
>> was there any change to t
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tool
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 94 --
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tools/perf/util/scripting-engines
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 94 --
1 file changed, 53 insertions
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 41 +-
1 file chang
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 41 +-
1 file changed, 40 insertions(+), 1
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 22 ++
1
and counter value in the
perf_sample dict.
Initial Discussion: https://lkml.org/lkml/2017/7/1/108
Arun Kalyanasundaram (5):
perf script python: Allocate memory only if handler exists
perf script python: Refactor creation of perf sample dict
perf script python: Add sample_read to dict
perf
Provide time_enabled, time_running and counter value in the perf_sample
dict.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 51 ++
1 file changed, 51 insertions(+)
diff --git a/tools/perf/util/scr
and counter value in the
perf_sample dict.
Initial Discussion: https://lkml.org/lkml/2017/7/1/108
Arun Kalyanasundaram (5):
perf script python: Allocate memory only if handler exists
perf script python: Refactor creation of perf sample dict
perf script python: Add sample_read to dict
perf
Provide time_enabled, time_running and counter value in the perf_sample
dict.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 51 ++
1 file changed, 51 insertions(+)
diff --git a/tools/perf/util/scripting-engines/trace-event
Thank you for taking a look into it. I don't see the garbled output.
Can you please send me the perf.data file or a way to reproduce it?
On Tue, Jul 18, 2017 at 1:35 AM, Jiri Olsa <jo...@redhat.com> wrote:
> On Mon, Jul 17, 2017 at 03:10:36PM -0700, Arun Kalyanasunda
Thank you for taking a look into it. I don't see the garbled output.
Can you please send me the perf.data file or a way to reproduce it?
On Tue, Jul 18, 2017 at 1:35 AM, Jiri Olsa wrote:
> On Mon, Jul 17, 2017 at 03:10:36PM -0700, Arun Kalyanasundaram wrote:
>> The process_event py
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 94 --
Move the creation of the dict containing perf_sample entries into a
helper function to enable its reuse in other sample processing routines.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 94 --
1 file changed, 53 insertions
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 37 +-
1 file chang
compatibility (and avoid unnecessary work),
do not pass the dict if the number of arguments signals that handler
version predates this change.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 37 +-
1 file changed, 36 insertions(+), 1
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tool
label in python_process_general_event and return when no
handler is available.
Signed-off-by: Arun Kalyanasundaram
---
.../util/scripting-engines/trace-event-python.c| 38 +-
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/tools/perf/util/scripting-engines
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram <arunk...@google.com>
---
.../perf/util/scripting-engines/trace-event-python.
/1/108
Arun Kalyanasundaram (4):
perf script python: Allocate memory only if handler exists
perf script python: Refactor creation of perf sample dict
perf script python: Add perf_sample dict to tracepoint handlers
perf script python: Generate hooks with additional argument
.../util
Modify the signature of tracepoint specific and trace_unhandled hooks to
add the perf_sample dict as a new argument.
Create a python helper function to print a dictionary.
Signed-off-by: Arun Kalyanasundaram
---
.../perf/util/scripting-engines/trace-event-python.c | 20 +---
1
/1/108
Arun Kalyanasundaram (4):
perf script python: Allocate memory only if handler exists
perf script python: Refactor creation of perf sample dict
perf script python: Add perf_sample dict to tracepoint handlers
perf script python: Generate hooks with additional argument
.../util
that
mean this is an expected behavior in this case?
I am running this on a haswell x86 architecture with 72 cores.
Thank you,
- Arun
On Sun, Jul 9, 2017 at 5:18 PM, Masami Hiramatsu <mhira...@kernel.org> wrote:
> Hello Arun,
>
> On Fri, 7 Jul 2017 16:06:40 -0700
> Arun Kalyanasundaram
that
mean this is an expected behavior in this case?
I am running this on a haswell x86 architecture with 72 cores.
Thank you,
- Arun
On Sun, Jul 9, 2017 at 5:18 PM, Masami Hiramatsu wrote:
> Hello Arun,
>
> On Fri, 7 Jul 2017 16:06:40 -0700
> Arun Kalyanasundaram wrote:
>
>> Hi St
7 Jul 2017 10:34:48 -0700
> Arun Kalyanasundaram <arunk...@google.com> wrote:
>
>> Hi,
>>
>> I am trying to use kprobes to time a few kernel functions. However, when I
>> add two kprobes on a function that are a few instructions apart, I
>> sometimes get the s
there are a lot
of samples, and so "my_program" generates a few hundred threads. Any
pointers on debugging this would be very helpful, or please let me
know if you want me to collect any log messages.
On Fri, Jul 7, 2017 at 12:01 PM, Steven Rostedt wrote:
> On Fri, 7 Jul 2017 10:34:48
Hi,
I am trying to use kprobes to time a few kernel functions. However,
when I add two kprobes on a function that are a few instructions
apart, I sometimes get the same timestamp (measured in nano seconds)
on the two probes.
For example, if I add the two probes as follows,
1) perf probe -a
Hi,
I am trying to use kprobes to time a few kernel functions. However,
when I add two kprobes on a function that are a few instructions
apart, I sometimes get the same timestamp (measured in nano seconds)
on the two probes.
For example, if I add the two probes as follows,
1) perf probe -a
_dict");
if (custom_dict)
//Add dict to PyTuple
Do you think this would be a better approach?
Thank you,
- Arun
On Wed, Jul 5, 2017 at 1:41 PM, Arun Kalyanasundaram
<arunk...@google.com> wrote:
> I wasn't entirely sure if we should modify the signature of the python
> hooks_ as this would
_dict");
if (custom_dict)
//Add dict to PyTuple
Do you think this would be a better approach?
Thank you,
- Arun
On Wed, Jul 5, 2017 at 1:41 PM, Arun Kalyanasundaram
wrote:
> I wasn't entirely sure if we should modify the signature of the python
> hooks_ as this would make existing scripts
el.org> wrote:
> Em Wed, Jul 05, 2017 at 04:25:45PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Jul 05, 2017 at 09:22:07AM -0700, Arun Kalyanasundaram escreveu:
>> > Hi Arnaldo,
>> >
>> > Thank you for your reply.
>> > I actually meant tracepoi
d, Jul 05, 2017 at 04:25:45PM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Wed, Jul 05, 2017 at 09:22:07AM -0700, Arun Kalyanasundaram escreveu:
>> > Hi Arnaldo,
>> >
>> > Thank you for your reply.
>> > I actually meant tracepoint event handle
ntain the actual pid of the process. So, I was wondering if this is
something intentional? If not I can share a patch to fix this.
Best,
- Arun
On Sat, Jul 1, 2017 at 7:47 AM, Arnaldo Carvalho de Melo
<a...@redhat.com> wrote:
> Em Fri, Jun 30, 2017 at 03:40:57PM -0700, Arun Kalyanasunda
ntain the actual pid of the process. So, I was wondering if this is
something intentional? If not I can share a patch to fix this.
Best,
- Arun
On Sat, Jul 1, 2017 at 7:47 AM, Arnaldo Carvalho de Melo
wrote:
> Em Fri, Jun 30, 2017 at 03:40:57PM -0700, Arun Kalyanasundaram escreveu:
>&g
Hi Alexey,
I am interested in validating this fix. Can you please share some of
your testcases or let me know if you use any standard OpenMP
benchmarks?
- Arun
Hi Alexey,
I am interested in validating this fix. Can you please share some of
your testcases or let me know if you use any standard OpenMP
benchmarks?
- Arun
66 matches
Mail list logo
