There is a difference between error messages in iptables and
iptables-compat:
#sudo iptables-compat -D INPUT 4
iptables: No chain/target/match by that name.
#sudo iptables -D INPUT 4
iptables: Index of deletion too big.
Now, will show same error message.
Signed-off-by: Arushi Singhal
Merge assignment with return statement to directly return the value.
Signed-off-by: Arushi Singhal
---
net/netfilter/nf_conntrack_netlink.c | 5 ++---
net/netfilter/xt_hashlimit.c | 3 +--
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/net/netfilter
t; which helps in refactoring
the code and also "cstate" variable is more commonly used in the other
functions.
Signed-off-by: Arushi Singhal
---
changes in v2:
"start" variable is removed, before "cstate" variable was removed
but "cstate" is more common so
It's better to use "list_for_each_entry_from_reverse" for iterating list
than "for loop" as it makes the code more clear to read.
This patch replace "for loop" with "list_for_each_entry_from_reverse"
and remove "cstate" variable as it i
It's better to use list_entry instead of list_{next/prev}_entry
as it makes the code more clear to read.
This patch replace list_entry with list_{next/prev}_entry.
Signed-off-by: Arushi Singhal
---
drivers/gpu/drm/drm_lease.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
It's better to use list_entry instead of list_{next/prev}_entry
as it makes the code more clear to read.
This patch replace list_entry with list_{next/prev}_entry.
Signed-off-by: Arushi Singhal
---
drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +-
1 file changed, 1 insertion(+), 1 del
Replace list_entry with list_{next/prev}_entry.
Arushi Singhal (2):
gpu: drm/lease:: Use list_{next/prev}_entry instead of list_entry
gpu: drm: nouveau: Use list_{next/prev}_entry instead of list_entry
drivers/gpu/drm/drm_lease.c| 2 +-
drivers/gpu/drm/nouveau/nvkm
The kernel.h macro DIV_ROUND_UP performs the computation
(((n) + (d) - 1) / (d)) but is perhaps more readable.
Signed-off-by: Arushi Singhal
---
drivers/mtd/ftl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
index a048429..61d5cf8
Using pr_() is more concise than printk(KERN_).
This patch:
* Replace printks having a log level with the appropriate
pr_*() macros.
* Indent the code where possible.
* Remove periods from messages.
Signed-off-by: Arushi Singhal
---
changes:
Before printk() is changes to dev_*macro(), but it was
stfsm_probe() misses error handling of mtd_device_register().
Signed-off-by: Arushi Singhal
---
drivers/mtd/devices/st_spi_fsm.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index 7bc29d7..4a99a6a
This patch fixes the checkpatch.pl error to ams-delta.c.
ERROR: do not initialise statics to 0 or NULL
Signed-off-by: Arushi Singhal
---
drivers/mtd/nand/ams-delta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/ams-delta.c b/drivers/mtd/nand/ams-delta.c
Use mtd_device_register() instead of mtd_device_parse_register() to
eliminate two unused parameters.
Signed-off-by: Arushi Singhal
---
drivers/mtd/devices/sst25l.c| 5 ++---
drivers/mtd/lpddr/lpddr2_nvm.c | 2 +-
drivers/mtd/maps/impa7.c| 5 ++---
drivers/mtd/maps
stfsm_probe() misses error handling of mtd_device_register().
Signed-off-by: Arushi Singhal
---
drivers/mtd/devices/st_spi_fsm.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index 7bc29d7..e1aa4f8
The prints after [k|v][m|z|c]alloc() functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
changes in v2
* Prefered
if (!map) {
map = kmalloc();
if (!map)
err;
}
than
if
The prints after [k|v][m|z|c]alloc() etc. functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
Reviewed-by: Miquel Raynal
---
drivers/mtd/nand/ams-delta.c | 1 -
drivers/mtd/nand/atmel/nand
patch Replace printk having a log level with the appropriate output
format according to the order of preference.
Change string explicitly mentioning function name to "%s...", __func__.
Signed-off-by: Arushi Singhal
---
changes in v2
*if "struct device object" is defined prefered
patch Replace printk having a log level with the appropriate output
format according to the order of preference.
Change string explicitly mentioning function name to "%s...", __func__.
Signed-off-by: Arushi Singhal
---
changes in v2
*Change string explicitly mentioning function name to &q
ed-off-by: Arushi Singhal
---
drivers/gpu/drm/drm_lease.c| 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c
index 1402c0e..4dcfb5f 100644
--- a/d
This patch replaces list_entry with list_first_entry as it makes the
code more clear.
Done using coccinelle:
@@
expression e;
@@
(
- list_entry(e->next,
+ list_first_entry(e,
...)
|
- list_entry(e->prev,
+ list_last_entry(e,
...)
)
Signed-off-by: Arushi Singhal
---
drivers/gpu/d
Using typedef for a structure type is not suggested in Linux kernel
coding style guidelines. Hence, occurrence of typedefs has been
removed.
Signed-off-by: Arushi Singhal
---
drivers/mtd/ssfdc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/ssfdc.c b
The prints after [k|v][m|z|c]alloc() functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
changes in v2
* done changes in all the other files.
drivers/mtd/maps/amd76xrom.c | 6 ++
drivers/mtd/maps
The prints after [k|v][m|z|c]alloc() etc. functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
changes in v2
*done the similar changes in other files.
drivers/mtd/nand/ams-delta.c | 1
The prints after [k|v][m|z|c]alloc() functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
drivers/mtd/inftlmount.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mtd
The prints after [k|v][m|z|c]alloc() functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
drivers/mtd/nand/ams-delta.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mtd/nand/ams-delta.c b
The prints after [k|v][m|z|c]alloc() functions are not needed, because
in case of failure, allocator will print their internal error prints
anyway.
Signed-off-by: Arushi Singhal
---
drivers/mtd/maps/sun_uflash.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd
Using pr_() is more concise than printk(KERN_).
This patch:
* Replace printks having a log level with the appropriate pr_*() macros.
* Define pr_fmt() to include relevant name.
* Remove redundant prefixes from pr_*() calls.
* Indent the code where possible.
Signed-off-by: Arushi Singhal
Using pr_() is more concise than
printk(KERN_).
Replace printks having a log level with the appropriate
pr_*() macros.
Signed-off-by: Arushi Singhal
---
changes in v2
*in v1 printk() were replaced with netdev_*()
net/netfilter/nf_conntrack_acct.c | 2 +-
net/netfilter
quot;struct device object" is defined prefer pr_*macro() over
printk().
This patch Replace printk having a log level with the appropriate output
format according to the order of preference.
Code is indented where possible.
Signed-off-by: Arushi Singhal
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/adc/ad7816.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
quot;struct device object" is defined prefer pr_*macro() over printk().
This patch Replace printk having a log level with the appropriate output
format according to the order of preference.
Signed-off-by: Arushi Singhal
---
Changes in v3
*In version2 net_*macro_ratelimited was used which i
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue if line is not
exceding 80 characters.
Signed-off-by: Arushi Singhal
---
changes
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
changes in v2
*Commit log is rewrite in the imperative.
drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
drivers/staging
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Signed-off-by: Arushi Singhal
---
changes in v2
*In v1 printk was changed to pr_*macro(), which is used
in kernel instead of calling p
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue if line is not
exceding 80 characters.
Signed-off-by: Arushi Singhal
---
.../rtl
Replace printk having a log level with the appropriate
net_*macro_ratelimited.
It's better to use actual device name as a prefix in error messages.
Indentation is also changed, to fix the checkpatch issue.
Signed-off-by: Arushi Singhal
---
changes in v2
*In previous version printk was ch
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/mmu/isp_mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Replace "cant" with "can't".
"cant" is not same as "Can not" or "Can't".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
This patch replace "be be" with "be".
Signed-off-by: Arushi Singhal
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe_public.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2/css2400/ia_css_pipe
Spellcheck the comments.
Remove the repeated, consecutive words with single word.
Arushi Singhal (3):
staging: media: Replace "be be" with "be"
staging: media: Replace "cant" with "can't"
staging: media: Replace "dont" with "
Spellcheck the comments.
Remove the repeated, consecutive words with single word.
Arushi Singhal (3):
staging: lustre: Replace "be be" with "be"
staging: lustre: Replace "to to" with "to"
staging: lustre: Replace "dont" with &q
This patch replace "be be" with "be".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lnet/libcfs/debug.c | 2 +-
drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagin
This patch replace "to to" with "to".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/cl_object.h
b/drivers/staging/lustre/lustre
Replace "dont" with "don't".
"Dont" is not same as "Do not" or "Don't".
Signed-off-by: Arushi Singhal
---
drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/sta
"dont" is changed to "don't" in messages, "dont" is not correct
english.
Signed-off-by: Arushi Singhal
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +-
drivers/staging/comedi/drivers/das16.c | 2 +-
drivers/staging/comedi/drivers/das16m1.c |
Using pr_() is more concise than printk(KERN_).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers
change is as follows:
@header@
@@
#include
@r1@
expression e;
@@
-memset(e,0x00,ETH_ALEN);
+eth_zero_addr(e);
@includeheader depends on r1 && !header@
@@
+ #include
#include <...>
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 ++-
d
Remove unnecessary semicolon found using semicolon.cocci Coccinelle
script.
Signed-off-by: Arushi Singhal
---
.../media/atomisp/pci/atomisp2/css2400/runtime/frame/src/frame.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/staging/media/atomisp/pci/atomisp2
Remove unnecessary semicolon using semicolon.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
Remove non-essential semicolon after 'else' and 'switch' statements. Issue
found using semicolon.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtlwifi/base.c | 6 +++---
drivers/staging/rtlwifi/phydm/phydm_rainfo.c | 1 -
2 files c
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
Changes in v2:
- Braces is dropped from if with single statement.
drivers/infiniband/hw/qib/qib_init.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
Changes in v2:
- Braces is dropped from if with single statement.
drivers/net/ethernet/amd/ni65.c | 4 +---
drivers/net/ethernet/neterion
Add spaces around ('=' and '<'), to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/mtd/nand/ams-delta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/ams-delta.c
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/net/ethernet/amd/ni65.c | 1 -
drivers/net/ethernet/neterion/s2io.c | 1 -
drivers/net/ethernet/netronome/nfp
Continue at the bottom of a loop are removed.
Issue found using drop_continue.cocci Coccinelle script.
Signed-off-by: Arushi Singhal
---
drivers/infiniband/hw/qib/qib_init.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/qib/qib_init.c
b/drivers/infiniband/hw/qib
Remove extra blank line(s) to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712
Delete/Add tabs and spaces to align the code to fix the
checkpatch issue: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2
Add spaces around '|' to conform to the Linux
kernel coding style. Issue found using checkpatch.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
Fix issues found with checkpatch.pl to conform to the Linux
kernel coding style.
Changes in v2:
* From and Signed-off emails were not same in v1.
* Added detailed commit message
Arushi Singhal (6):
staging: rtl8712: Fixed 'tabstop' coding style warning
staging: rtl8712: match alig
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagi
Add spaces around arithmetic operator '+', to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
Fix issues found with checkpatch.pl for rtl8712 driver.
Arushi Singhal (4):
staging: rtl8712: Remove multiple blank line(s)
staging: rtl8712: Added spaces around '+'.
staging: rtl8712: Add spaces around '|'
staging: rtl8712: remove unnecessary parentheses
dri
From: Arushi Singhal
Remove extra blank line(s) that were causing checkpatch issues.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/os_intfs.c | 1 -
drivers/staging/rtl8712/rtl8712_bitdef.h | 1 -
drivers/staging/rtl8712/rtl8712_cmdctrl_regdef.h | 2
Remove unnecessary parentheses around variables to conform to the Linux
kernel coding style. Issue found using checkpatch.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/recv_linux.c | 4 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 8 ++--
drivers/staging/rtl8712/rtl8712_led.c | 70
From: Arushi Singhal
Add spaces around '|' to fix the checkpatch issue.
CHECK: spaces preferred around that '|'.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmdctrl_bitdef.h | 2 +-
drivers/staging/rtl8712/rtl8712_gp_bitdef.h | 2 +-
2 files c
From: Arushi Singhal
Add spaces around arithmetic operator '+', to fix the checkpatch
issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/rtl8712_cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl8712_cmd.h
b/drive
This patch fixes the checks reported by checkpatch.pl for alignment
should match open parenthesis.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c | 2 +-
drivers/staging/rtl8712/os_intfs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
Replace a mix of tabs and spaces indentation by tabs only.
Fixed checkpatch warning "Statements should start on a tabstop" in
rtl8712 module.
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/drv_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal
---
drivers/staging/rtl8712/mlme_linux.c| 4 ++--
drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
drivers/staging/rtl8712/rtl8712_efuse.c | 2 +-
3 files changed, 4 insert
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal
---
net/netfilter/nf_conntrack_broadcast.c | 2 +-
net/netfilter/nf_conntrack_core.c | 2 +-
net/netfilter/nf_conntrack_ecache.c| 4 +--
net/netfilter/nf_conntrack_helper.c| 4
Replace explicit NULL comparison to simplify code.
Signed-off-by: Arushi Singhal
---
net/netfilter/ipvs/ip_vs_ctl.c | 40
net/netfilter/ipvs/ip_vs_proto.c | 22 +++---
2 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/net
This comments are obsolete and should go, as there are no set of rules per
CPU anymore.
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/ip6_tables.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
iptables/nft-arp.c | 4 ++--
iptables/xtables-arp.c | 12 ++--
2 fi
The following Coccinelle script was used to detect this:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T*)x)->f
|
- (T*)
e
)
Signed-off-by: Arushi Singhal
---
extensions/libarpt_mangle.c | 2 +-
extensions/libip6t_rt.c | 2 +-
extensi
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
iptables/ip6tables-save.c | 2 +-
iptables/iptable
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/netfilter/ipset/ip_set_core.c | 2 +-
net/n
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/nft_fib_ipv6.c | 2 +-
1 file
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/bridge/netfilter/nft_meta_bridge.c | 2 +-
Remove & from function pointers to conform to the style found elsewhere
in the file. Done using the following semantic patch
//
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
//
Signed-off-by: Arushi Singhal
---
net/ipv4/netfilter/nft_fib_ipv4.c | 2 +-
1 file
Remove instances of explicit NULL comparisons for code compaction.
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/ip6t_SYNPROXY.c | 16
net/ipv6/netfilter/ip6t_ipv6header.c | 2 +-
net/ipv6/netfilter/ip6table_filter.c | 2 +-
net/ipv6
Remove instances of explicit NULL comparisons for code compaction.
Signed-off-by: Arushi Singhal
---
net/ipv4/netfilter/arp_tables.c| 3 +--
net/ipv4/netfilter/arptable_filter.c | 2 +-
net/ipv4/netfilter/ipt_CLUSTERIP.c | 2 +-
net/ipv4/netfilter
Simplify NULL comparisons to follow kernel coding style.
Arushi Singhal (2):
ipv4: netfilter: Simplify NULL comparisons
ipv6: netfilter: Simplify NULL comparisons
net/ipv4/netfilter/arp_tables.c| 3 +--
net/ipv4/netfilter/arptable_filter.c | 2 +-
net/ipv4
Fixed coding style for null comparisons to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
net/ipv4/netfilter/arp_tables.c| 2 +-
net/ipv4/netfilter/arptable_filter.c | 2 +-
net/ipv4/netfilter/ipt_CLUSTERIP.c
The driver needs to insure atomicity during frequency
changes of bus and device. The iiodev->mlock as used
was not doing that. Replace it with the drivers existing
buffer lock and execute spi_write directly.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/meter/ade7759.c | 9 ++---
;
@@
e1
-,
+;
e2;
//
Signed-off-by: Arushi Singhal
---
drivers/iio/adc/max11100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
index 23c060e1b663..1180bcc22ff1 100644
--- a/drivers/iio/adc/max11100.c
+++ b
;
@@
e1
-,
+;
e2;
//
Signed-off-by: Arushi Singhal
---
drivers/iio/chemical/ams-iaq-core.c | 2 +-
drivers/iio/chemical/vz89x.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/chemical/ams-iaq-core.c
b/drivers/iio/chemical/ams-iaq-core.c
index
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal
---
changes in v2
-done the changes according to the current tree
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
d
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal
---
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss_ipipe.c | 2 +-
drivers/staging
This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:
@@
identifier len,f;
@@
-int len;
... when != len
when strict
-len =
+return
f(...);
-return len;
Signed-off-by: Arushi
This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:
@@
identifier len,f;
@@
-int len;
... when != len
when strict
-len =
+return
f(...);
-return len;
Signed-off-by: Arushi
Removed parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++--
1 file
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal
---
net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
net/netfilter/nf_conntrack_broadcast.c | 2 +-
net/netfilter/nf_conntrack_core.c | 2
fix the line over 80 characters as reported by checkpatch.pl
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/ip6_tables.c| 6 --
net/ipv6/netfilter/ip6t_SYNPROXY.c | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6
Removed parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++--
1 file
Fix checkpatch warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/ip6_tables.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/ipv6
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal
---
net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
net/netfilter/nf_conntrack_broadcast.c | 2 +-
net/netfilter/nf_conntrack_core.c | 2
Fixed coding style for null comparisons to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal
---
net/bridge/netfilter/ebt_among.c | 12 ++--
net/bridge/netfilter/ebt_arp.c | 10 +-
net/bridge/netfilter/ebt_arpreply.c
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal
---
net/ipv6/netfilter/ip6_tables.c| 4 ++--
net/ipv6/netfilter/ip6t_SYNPROXY.c | 16
net/ipv6/netfilter/ip6t_ah.c | 2 +-
net/ipv6
1 - 100 of 389 matches
Mail list logo
