[PATCH net-next 1/3] net: l2tp: export debug flags to UAPI

2016-12-10 Thread Asbjoern Sloth Toennesen
Move the L2TP_MSG_* definitions to UAPI, as it is part of the netlink API. Signed-off-by: Asbjoern Sloth Toennesen --- include/uapi/linux/l2tp.h | 17 - net/l2tp/l2tp_core.h | 10 -- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/include/uapi/linux

[PATCH net-next 3/3] net: l2tp: ppp: change PPPOL2TP_MSG_* => L2TP_MSG_*

2016-12-10 Thread Asbjoern Sloth Toennesen
Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_ppp.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/net/l2tp/l2tp_ppp.c b/net/l2tp/l2tp_ppp.c index 2ddfec1..36cc56f 100644 --- a/net/l2tp/l2tp_ppp.c +++ b/net

[PATCH net-next 2/3] net: l2tp: deprecate PPPOL2TP_MSG_* in favour of L2TP_MSG_*

2016-12-10 Thread Asbjoern Sloth Toennesen
PPPOL2TP_MSG_* and L2TP_MSG_* are duplicates, and are being used interchangeably in the kernel, so let's standardize on L2TP_MSG_* internally, and keep PPPOL2TP_MSG_* defined in UAPI for compatibility. Signed-off-by: Asbjoern Sloth Toennesen --- Documentation/networking/l2tp.txt

[PATCH net-next v2 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-07 Thread Asbjoern Sloth Toennesen
the macro, foo = nla_get_flag(nla); Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index 494910d..3620fba 100644 --- a/net/l

[PATCH net-next v2 1/5] net: l2tp: change L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-07 Thread Asbjoern Sloth Toennesen
The attributes L2TP_ATTR_UDP_ZERO_CSUM6_RX and L2TP_ATTR_UDP_ZERO_CSUM6_TX are used as flags, but is defined as a u8 in a comment. This patch redocuments them as flags. Adding nla_policy entries would break API, so not doing that. CC: Tom Herbert Signed-off-by: Asbjoern Sloth Toennesen

[PATCH net-next v2 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-07 Thread Asbjoern Sloth Toennesen
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_core.c | 2 +- net/l2tp/l2tp_ppp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index

[PATCH net-next v2 2/5] net: l2tp: only set L2TP_ATTR_UDP_CSUM if AF_INET

2016-11-07 Thread Asbjoern Sloth Toennesen
Only set L2TP_ATTR_UDP_CSUM in l2tp_nl_tunnel_send() when it's running over IPv4. This prepares the code to also have IPv6 specific attributes. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH net-next v2 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-07 Thread Asbjoern Sloth Toennesen
This patch causes the proper attribute flags to be set, in the case that IPv6 UDP checksums are disabled, so that userspace ie. `ip l2tp show tunnel` knows about it. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH net-next 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-04 Thread Asbjoern Sloth Toennesen
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_core.c | 2 +- net/l2tp/l2tp_ppp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index

[PATCH net-next 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-04 Thread Asbjoern Sloth Toennesen
the macro, foo = nla_get_flag(nla); Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index 1b3fcde..abf6bf1 100644 --- a/net/l

[PATCH net-next 1/5] net: l2tp: fix L2TP_ATTR_UDP_CSUM attribute type

2016-11-04 Thread Asbjoern Sloth Toennesen
a NLA_U8 is in l2tp_nl_tunnel_send(), but iproute2 again reads that as a flag, it's therefore always set. Fortunately it is never used for anything, just read. CC: Miao Wang Signed-off-by: Asbjoern Sloth Toennesen --- include/uapi/linux/l2tp.h | 2 +- net/l2tp/l2tp_netlink.c | 12 +

[PATCH net-next 2/5] net: l2tp: fix L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-04 Thread Asbjoern Sloth Toennesen
flags. CC: Miao Wang Signed-off-by: Asbjoern Sloth Toennesen --- include/uapi/linux/l2tp.h | 4 ++-- net/l2tp/l2tp_netlink.c | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp.h index 73e3a23..345e49f 100644 --- a/include

[PATCH net-next 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-04 Thread Asbjoern Sloth Toennesen
This patch causes the proper attribute flags to be set, in the case that IPv6 UDP checksums are disabled, so that userspace ie. `ip l2tp show tunnel` knows about it. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH] net: l2tp_eth: fix max_mtu

2016-10-20 Thread Asbjoern Sloth Toennesen
On Thu, 20 Oct 2016 20:08:26 + (UTC), a...@asbjorn.biz wrote: > diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c > index 965f7e3..ba82dcc 100644 > --- a/net/l2tp/l2tp_eth.c > +++ b/net/l2tp/l2tp_eth.c > @@ -259,6 +259,7 @@ static int l2tp_eth_create(struct net *net, u32 > tunnel_id, u32

[PATCH] net: l2tp_eth: fix max_mtu

2016-10-20 Thread Asbjoern Sloth Toennesen
Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking") CC: net...@vger.kernel.org CC: Jarod Wilson Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c ind

[PATCH] staging: octeon: use defines instead of magic numbers

2016-09-13 Thread Asbjoern Sloth Toennesen
The ugly magic number 65392 is waiting for CVMX_IPD_MAX_MTU to appear in the mips tree. Signed-off-by: Asbjoern Sloth Toennesen --- drivers/staging/octeon/ethernet.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b

[PATCH] MIPS: Octeon: Use defines instead of magic numbers

2016-09-12 Thread Asbjoern Sloth Toennesen
The patch will be followed by a similar patch to drivers/staging/octeon/ethernet.c Signed-off-by: Asbjoern Sloth Toennesen --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 15 ++- arch/mips/include/asm/octeon/cvmx-ipd-defs.h| 2 ++ 2 files changed, 12 insertions(+), 5

[PATCH v2] nftables: nft_flush_table: handle chain dependencies

2014-12-26 Thread Asbjoern Sloth Toennesen
estroy+0x58/0x60 [ 353.376368] RSP [ 353.388988] ---[ end trace e51c442af1fdea42 ]--- Cc: sta...@vger.kernel.org Signed-off-by: Asbjoern Sloth Toennesen --- net/netfilter/nf_tables_api.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter

[PATCH] nftables: nft_flush_table: handle chain dependencies

2014-12-26 Thread Asbjoern Sloth Toennesen
f 80 00 00 00 00 <0f> 0b 66 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 41 55 41 54 53 [ 353.376307] RIP [] nf_tables_chain_destroy+0x58/0x60 [ 353.376368] RSP [ 353.388988] ---[ end trace e51c442af1fdea42 ]--- Cc: sta...@vger.kernel.org Signed-off-by: Asbjoern Sloth Toennesen --

[PATCH] deb-pkg: remove obsolete -isp option to dpkg-gencontrol

2014-10-05 Thread Asbjoern Sloth Toennesen
The -isp option has been deprecated, after it became the default behaviour back in 2006. Since dpkg 1.17.11, dpkg-gencontrol emits a warning on -isp usage. References: https://bugs.debian.org/215233 Signed-off-by: Asbjoern Sloth Toennesen --- scripts/package/builddeb | 2 +- 1 file changed, 1

[PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header

2013-08-12 Thread Asbjoern Sloth Toennesen
Fix the iproute2 command `bridge vlan show`, after switching from rtgenmsg to ifinfomsg. Signed-off-by: Asbjoern Sloth Toennesen --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 3de7408..a043171 100644