RE: [PATCH v1 1/1] gpio: Support interrupts in gpio-mlxbf2.c

Hi Linus, Did you have a chance to take a look at my reply below? I would greatly appreciate your feedback to decide how I should restructure this code moving forward. Thank you. Asmaa -Original Message- From: Asmaa Mnebhi Sent: Wednesday, March 10, 2021 3:38 PM To: Asmaa Mnebhi

RE: [PATCH v1 1/1] gpio: Support interrupts in gpio-mlxbf2.c

d copied from https://www.spinics.net/lists/linux-gpio/msg58692.html) Please send GPIO related patches to linux-gpio@xxx! I will. On Tue, Feb 23, 2021 at 11:51 PM Asmaa Mnebhi wrote: > > From: Asmaa Mnebhi > > There are 3 possible GPIO interrupts which can be > supported on

RE: [PATCH v2 1/1] gpio: Support interrupts in gpio-mlxbf2.c

Hi everyone, I apologize for sending my second patch without addressing your comments. I didn't receive any email about them because the email used was "as...@mellanox.com" which is no longer valid. It is now "as...@nvidia.com". I don't know how that happened since I submitted my patches with

[PATCH v2 1/1] gpio: Support interrupts in gpio-mlxbf2.c

From: Asmaa Mnebhi There are 3 possible GPIO interrupts which can be supported on BlueField-2 boards. Some BlueField boards support: 1) PHY interrupt only 2) PHY interrupt and Reset interrupt 3) Low power interrupt only There is one hardware line shared among all GPIOs, I2C and MDIO. So

ipmi_msghandler.c question

Hi Corey, I have a question for you related to the following function in ipmi_msghandler.c static void __get_guid(struct ipmi_smi *intf) { int rv; struct bmc_device *bmc = intf->bmc; bmc->dyn_guid_set = 2; intf->null_user_handler = guid_handler; rv =

RE: [PATCH 10/10] gpio: gpio-mlxbf2.c: Provide __releases() annotation to stop confusing Sparse

Reviewed-by: Asmaa Mnebhi Thank you. -Original Message- From: Lee Jones Sent: Tuesday, June 30, 2020 9:34 AM To: linus.wall...@linaro.org; bgolaszew...@baylibre.com Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; Lee Jones ; Asmaa

RE: [PATCH 09/10] gpio: gpio-mlxbf2: Tell the compiler that ACPI functions may not be use

Reviewed-by: Asmaa Mnebhi Thank you. -Original Message- From: Lee Jones Sent: Tuesday, June 30, 2020 9:34 AM To: linus.wall...@linaro.org; bgolaszew...@baylibre.com Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; linux-g...@vger.kernel.org; Lee Jones ; Asmaa

[PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

river") Signed-off-by: Asmaa Mnebhi --- drivers/char/ipmi/ipmb_dev_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c index 5720433..285e0b8 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers

[PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c

ret at line 112 of ipmb_dev_int.c is uninitialized which results in a warning during build regressions. This warning was reported during regression/improvement testing led by Geert Uytterhoeven for v5.3-rc1. Asmaa Mnebhi (1): Fix uninitialized variable in ipmb_dev_int.c drivers/char/ipmi

RE: [PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

Ah ok! I put that message on the cover letter. Thanks! I will make an update shortly. -Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Wednesday, July 24, 2019 3:07 PM To: Asmaa Mnebhi Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] Fix uninitialized

[PATCH v1 1/1] Fix uninitialized variable in ipmb_dev_int.c

Signed-off-by: Asmaa Mnebhi --- drivers/char/ipmi/ipmb_dev_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c index 5720433..285e0b8 100644 --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi

[PATCH v1 0/1] Fix uninitialized variable in ipmb_dev_int.c

ret at line 112 of ipmb_dev_int.c is uninitialized which results in a warning during build regressions. Asmaa Mnebhi (1): Fix uninitialized variable in ipmb_dev_int.c drivers/char/ipmi/ipmb_dev_int.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.2

RE: [PATCH] ipmi: ipmb: don't allocate i2c_client on stack

Hi Arnd, LGTM. -Original Message- From: Arnd Bergmann Sent: Wednesday, June 19, 2019 8:51 AM To: Corey Minyard ; Greg Kroah-Hartman Cc: Arnd Bergmann ; Asmaa Mnebhi ; Vadim Pasternak ; Corey Minyard ; openipmi-develo...@lists.sourceforge.net; linux-kernel@vger.kernel.org Subject

RE: [PATCH v12 1/1] Add support for IPMB driver

Hello Randy, Please refer to the slave-interface linux documentation: https://www.kernel.org/doc/Documentation/i2c/slave-interface Thanks. Asmaa -Original Message- From: Randy Dunlap Sent: Monday, June 10, 2019 5:56 PM To: Asmaa Mnebhi ; miny...@acm.org; w...@the-dreams.de; Vadim

RE: [PATCH v12 1/1] Add support for IPMB driver

Thank you Corey! -Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Monday, June 10, 2019 3:51 PM To: Asmaa Mnebhi Cc: w...@the-dreams.de; Vadim Pasternak ; Michael Shych ; rdun...@infradead.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re

[PATCH v12 0/1] Add support for IPMB driver

Addressed Corey's comment: Instead of having reference_rq_sa, check the response bit in the ipmb_write function to provide additional protection against arbitrary commands. Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

[PATCH v12 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi Acked-by: vad...@mellanox.com --- Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

RE: [PATCH v11 1/1] Add support for IPMB driver

-Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Monday, June 10, 2019 1:39 PM To: Asmaa Mnebhi Cc: w...@the-dreams.de; Vadim Pasternak ; Michael Shych ; rdun...@infradead.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v11 1/1

[PATCH v11 0/1] Add support for IPMB driver

Addressed Corey's comments. 1) simplified the ipmb_read function 2) fixed some nits and mutex/spin lock uses Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 +++ drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1

[PATCH v11 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi Acked-by: vad...@mellanox.com --- Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

RE: [PATCH v10 1/1] Add support for IPMB driver

Hi Corey, Thank you for your comments. Please see inline response. I will be posting a new patch shortly. -Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Wednesday, June 5, 2019 7:53 PM To: Asmaa Mnebhi Cc: w...@the-dreams.de; Vadim Pasternak ; Michael Shych

[PATCH v10 0/1] Add support for IPMB driver

Addressed Wolfram's comments: 1) Removed unnecessary lock 2) added check for rq_sa Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 ++ drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi

[PATCH v10 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi Acked-by: vad...@mellanox.com --- Documentation/IPMB.txt | 103 ++ drivers/char/ipmi

RE: [PATCH v9 1/1] Add support for IPMB driver

Hi Wolfram, Thank you for your response. Please see my inline response. -Original Message- From: Wolfram Sang Sent: Monday, June 3, 2019 4:13 PM To: Asmaa Mnebhi Cc: miny...@acm.org; Vadim Pasternak ; Michael Shych ; rdun...@infradead.org; linux-kernel@vger.kernel.org; linux

RE: [PATCH v9 1/1] Add support for IPMB driver

-Original Message- From: Wolfram Sang Sent: Sunday, May 19, 2019 10:03 AM To: Asmaa Mnebhi Cc: miny...@acm.org; Vadim Pasternak ; Michael Shych ; rdun...@infradead.org; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v9 1/1] Add support for IPMB driver

[PATCH v9 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi Acked-by: vad...@mellanox.com --- Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

[PATCH v9 0/1] Add support for IPMB driver

Addressed Randy's comments about the documentation. Those instructions are for any software engineer who wants to build this driver and load it onto their system. Thank you. Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

[PATCH v8 0/1] Add support for IPMB driver

Thank you Wolfram, I have addressed your comments. Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 +++ drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi/ipmb_dev_int.c | 382

[PATCH v8 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi Acked-by: vad...@mellanox.com --- Documentation/IPMB.txt | 103 +++ drivers/char/ipmi

[PATCH v7 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- Documentation/IPMB.txt | 103 ++ drivers/char/ipmi/Kconfig| 8 + drivers

[PATCH v7 0/1] Add support for IPMB driver

Hi Vadim, I have addressed your comments: 1) removed typecasting and replaced it with a macro to get the 8 bit address. I think it is more readable this way. 2) added space Thank you for your feedback! Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103

[PATCH v6 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- Documentation/IPMB.txt | 103 ++ drivers/char/ipmi/Kconfig| 8 + drivers

[PATCH v6 0/1] Add support for IPMB driver

for one more advocate against typecasting! Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 103 ++ drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi/ipmb_dev_int.c | 397

RE: [PATCH v4 0/1] Add support for IPMB driver

Hi Corey, Please see inline response. -Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Thursday, May 2, 2019 3:50 PM To: Asmaa Mnebhi Cc: Vadim Pasternak ; w...@the-dreams.de; Michael Shych ; linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re

[PATCH v5 0/1] Add support for IPMB driver

from the Satellite MC, it will pass it to the ipmitool program which will display the output to the user. ipmb-dev-int does not need the msghandler not the devintf to be loaded. Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 64 +++ drivers/char/ipmi

[PATCH v5 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- Documentation/IPMB.txt | 64 +++ drivers/char/ipmi/Kconfig| 8 + drivers/char

RE: [PATCH v4 0/1] Add support for IPMB driver

Hi Vadim, Hi Corey, Please find inline comments answering your questions. -Original Message- From: Vadim Pasternak Sent: Tuesday, April 30, 2019 5:24 PM To: Asmaa Mnebhi ; miny...@acm.org; w...@the-dreams.de; Michael Shych Cc: Asmaa Mnebhi ; linux-kernel@vger.kernel.org; linux

[PATCH v4 0/1] Add support for IPMB driver

driver only works as a slave so it will only be instantiated once on the Satellite MC under one slave address. Asmaa Mnebhi (1): Add support for IPMB driver Documentation/IPMB.txt | 53 ++ drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile |

[PATCH v4 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- Documentation/IPMB.txt | 53 ++ drivers/char/ipmi/Kconfig| 8 + drivers/char

[PATCH v3 0/1] Add support for IPMB driver

" I am open for discussion. My reasoning was that we need to interact with user space so I used misc strictly to enable read/write. Maybe we could do something similar to the i2c-slave-eeprom.c where the eeprom_data struct uses bin_attributes? Asmaa Mnebhi (1): Add support for IPM

[PATCH v3 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi

RE: [PATCH v1 1/1] Add support for IPMB driver

-Original Message- From: Corey Minyard On Behalf Of Corey Minyard Sent: Tuesday, April 16, 2019 12:16 PM To: Asmaa Mnebhi Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH v1 1/1] Add support for IPMB driver On Fri, Apr 12, 2019 at 05:59:16PM -0400

[PATCH v2 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi

[PATCH v2 0/1] *** Add support for IPMB driver ***

SMBus, so it needs the total length of the message. So we need to document that this driver requires that the user program (it is attached) passes the msg length as the first byte in the message. Asmaa Mnebhi (1): Add support for IPMB driver drivers/char/ipmi/Kconfig| 8 + drivers

[PATCH v1 1/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Signed-off-by: Asmaa Mnebhi --- drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1 + drivers/char/ipmi

[PATCH v1 0/1] Add support for IPMB driver

Support receiving IPMB requests on a Satellite MC from the BMC. Once a response is ready, this driver will send back a response to the BMC via the IPMB channel. Asmaa Mnebhi (1): Add support for IPMB driver drivers/char/ipmi/Kconfig| 8 + drivers/char/ipmi/Makefile | 1