[PATCH 2/2] drivers: staging: media: atomisp: fix coding style warnings

2017-05-07 Thread Avraham Shukron
Fix for warnings reported by checkpatch.pl: - Multiline comment style - Bare "unsigned" - Missing blank line after declarations - Un-needed braces around single-statement branch Signed-off-by: Avraham Shukron --- .../platform/intel-mid/atomisp_gmin_platform.

[PATCH 1/2] drivers: staging: media: atomisp: fixed coding style errors

2017-05-07 Thread Avraham Shukron
Fix for error (not warnings) reported by checkpatch.pl Specifically: - missing whitespace around "=" and after "," - indentation with spaces instead of tabs - lines starting with a whitespace This patch does not affect the compiled code in any way. Signed-off

[PATCH] staging: media: atomisp: fixed sparse warnings

2017-05-05 Thread Avraham Shukron
Added "static" storage class to 4 not-declared functions Signed-off-by: Avraham Shukron --- .../media/atomisp/platform/intel-mid/atomisp_gmin_platform.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/platform

Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

2017-03-01 Thread Avraham Shukron
On 01/03/17 22:46, Joe Perches wrote: > On Wed, 2017-03-01 at 21:59 +0200, Avraham Shukron wrote: >>> >>> This kind of change is definitely not helpful. The original table was >>> Nx16, you converted it to Nx14. Why do you think original table used 16 >>> c

Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

2017-03-01 Thread Avraham Shukron
> > This kind of change is definitely not helpful. The original table was > Nx16, you converted it to Nx14. Why do you think original table used 16 > columns? > > Regardless, it's a very old driver, just let it be. > > Thanks. > I can make it Nx8 :) Seriously now - I don't understand what is

[PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-26 Thread Avraham Shukron
- Extracted assignments out of 'if' statements - Removed unnecessary spaces - Broke long lines - Added empty lines after declarations Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/hiddev.c | 51 ++--- 1 file changed, 34 insertions(+), 17

[PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues

2017-02-21 Thread Avraham Shukron
- Broke long lines - Added spaces where needed - Removed unnecessary / trailing whitespaces - Extracted assignments outside of 'if' statements Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/usbkbd.c | 121 ++-- 1 file changed, 72 inserti

[PATCH] usbhid: usbmouse: Fix checkpatch.pl issues

2017-02-21 Thread Avraham Shukron
Removed trailing and unneeded white-spaces, broke long lines where appropriate. Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/usbmouse.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/hid/usbhid/usbmouse.c b/drivers/hid/usbhid

[PATCH v4 2/2] staging: omap4iss: fix coding style issue

2017-02-09 Thread Avraham Shukron
Broke argument list so that it won't exceed 80 characters Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_vi

[PATCH v4 1/2] staging: omap4iss: fix multiline comment style

2017-02-09 Thread Avraham Shukron
Fixed multi-line comments to their preferred style (First line empty) Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 38 -- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b

[PATCH v2] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Avraham Shukron
Aligned asterisks in multi-line comment. Signed-off-by: Avraham Shukron --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe

[PATCH] staging: davinci_vpfe: fix multiline comment style

2017-02-08 Thread Avraham Shukron
Signed-off-by: Avraham Shukron --- drivers/staging/media/davinci_vpfe/dm365_resizer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/davinci_vpfe/dm365_resizer.c b/drivers/staging/media/davinci_vpfe/dm365_resizer.c index 5fbc2d4..857b0e8 100644

[PATCH v3 2/2] staging: omap4iss: fix coding style issue

2017-02-07 Thread Avraham Shukron
Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index e21811a..0bac582 100644 --- a/drivers/staging/media

[PATCH v3 1/2] staging: omap4iss: fix multiline comment style

2017-02-07 Thread Avraham Shukron
Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 38 -- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index bb0e3b4..e21811a

[PATCH v2] Staging: omap4iss: Fix coding style issues

2017-02-06 Thread Avraham Shukron
Fixes line-over-80-characters issues as well as multiline comments style. Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 41 -- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/drivers/staging/media/omap4iss

Re: [PATCH] Staging: omap4iss: fix coding style issues

2017-01-29 Thread Avraham Shukron
On 29/01/2017 9:31, Ozgur Karatas wrote: > > > 28.01.2017, 20:11, "Avraham Shukron" : >> This is a patch that fixes issues in omap4iss/iss_video.c >> Specifically, it fixes "line over 80 characters" issues > > Hello, > > are you have a sent

[PATCH] Staging: omap4iss: fix coding style issues

2017-01-28 Thread Avraham Shukron
This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues Signed-off-by: Avraham Shukron --- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH] Staging: omap4iss: fix coding style issues. This is a patch that fixes checkpatch.pl issues in omap4iss/iss_video.c Specifically, it fixes "line over 80 characters" issues.

2017-01-28 Thread Avraham Shukron
--- drivers/staging/media/omap4iss/iss_video.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c16927a..cdab053 100644 --- a/drivers/staging/media/omap4iss/iss_video.c +++ b/dr