RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb->ops

2013-06-26 Thread B, Ravi
Hi Felipe > > > > @@ -213,6 +213,8 @@ struct musb_platform_ops { > > > > int (*adjust_channel_params)(struct dma_channel *channel, > > > > u16 packet_sz, u8 *mode, > > > > dma_addr_t *dma_addr, u32 *len); > > > > + > > > >

RE: [PATCH v1 2/3] usb: musb: core: added babble recovery func-ptr to musb->ops

2013-06-26 Thread B, Ravi
Felipe > > On Wed, May 29, 2013 at 06:37:03PM +0530, Ravi Babu wrote: > > Adding babble_recovery operation as part of musb->ops, used to recover > > from babble condition during babble interrupt. > > > > Signed-off-by: Ravi Babu > > --- > > drivers/usb/musb/musb_core.c |6 ++ > > driver

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
Typo.. corrected "The /proc/iomem does not show this common register" -Original Message- From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of B, Ravi Sent: Wednesday, June 12, 2013 12:51 PM To: Sergei Shtylyov Cc: ABRAHAM, KISHON VI

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-12 Thread B, Ravi
+ + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); + phy->phy_wkup = ioremap(res->start, resource_size(res)); >>> devm_ioremap? >> The phy_wakeup register is common across two instances of phy, >> devm_ioremap_resource() will fail to map for twice for same

RE: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx platform

2013-06-11 Thread B, Ravi
Kishon > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Balbi, Felipe > Subject: Re: [PATCH v2 2/7] usb: phy: dsps: adding usbphy driver for am33xx > platform >> + >> +res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy_wkup"); >> +phy->phy_wkup = ioremap(res->sta

RE: [PATCH v1 0/9] adding dual instance and usb-phy support for am335x platform

2013-05-28 Thread B, Ravi
Felipe > Subject: Re: [PATCH v1 0/9] adding dual instance and usb-phy support for > am335x platform > Hi, >On Thu, May 23, 2013 at 11:31:19AM +0530, Ravi Babu wrote: >> This patch set series >> - adds dual musb instances support for am335x platform >> - adds phy-dsps-usb driver

RE: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue Hello. On 05/23/2013 09:07 PM, B, Ravi wrote: >>> removed unused nop xceiv (un_)register API's from all musb platform >>> drivers >> Since when are they unused

RE: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx Hello. On 05/23/2013 09:13 PM, B, Ravi wrote: > >>> + phy1: usbphy-gs70@44e10620 { >>> + compatible = "ti,dsps-usbphy"; >>> +

RE: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread B, Ravi
Sergei >> >> +phy1: usbphy-gs70@44e10620 { >> +compatible = "ti,dsps-usbphy"; >> +reg = <0x44e10620 0x8 >> + 0x44e10648 0x4>; >> +reg-names = "phy_ctrl","phy_wkup"; >> +id = <0>; >

RE: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for multi instance

2013-05-23 Thread B, Ravi
> Subject: Re: [PATCH v1 7/9] usb: musb: dsps: use get-usb-phy by phandle for > multi instance > On 23-05-2013 10:01, Ravi Babu wrote: >> In case of mutli instance support, use get-phy object using phandle to >> return to repsective phy xceiv object for each instance > Only "respective" and

RE: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread B, Ravi
Sergei > Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused > nop_xceiv_(un)register APIs from glue > Hello. > On 23-05-2013 10:01, Ravi Babu wrote: >> removed unused nop xceiv (un_)register API's from all musb >> platform drivers >Since when are they unused? Please refer to commit

RE: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-17 Thread B, Ravi
Ruslan > >> Subject: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded > >> systems > >> > >> From musb point of view, the Address Assignment sequence during > >> device enumeration is next: > >> - first ep0 interrupt: > >> * read the address from USB_REQ_SET_ADDRESS request > >>

RE: [PATCH] usb: musb: gadget: fix enumeration on heavy-loaded systems

2013-04-16 Thread B, Ravi
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Bilovol, Ruslan > Sent: Tuesday, April 16, 2013 9:12 PM > To: Balbi, Felipe; gre...@linuxfoundation.org; linux-...@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject:

RE: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread B, Ravi
> Hi, > > On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > > Hi Arnd, > > > > On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > > >On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: > > >>Added a new driver for the usb part of control module. > This has an > > >>API to