Re: [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2)

2007-07-10 Thread Balbir Singh
d out. try_to_free_pages() has been extended to become >> container aware. >> >> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> > > it seems that the number of pages to scan (nr_active/nr_inactive > in shrink_zone) is calculated from NR_ACTIVE and NR_INACTIVE of t

Re: [-mm PATCH 4/8] Memory controller memory accounting (v2)

2007-07-10 Thread Balbir Singh
On 7/10/07, YAMAMOTO Takashi <[EMAIL PROTECTED]> wrote: hi, > diff -puN mm/memory.c~mem-control-accounting mm/memory.c > --- linux-2.6.22-rc6/mm/memory.c~mem-control-accounting 2007-07-05 13:45:18.0 -0700 > +++ linux-2.6.22-rc6-balbir/mm/memory.c 2007-07-05 13:45:18.

Re: [patch -rss] Make RSS accounting display more user friendly

2007-07-09 Thread Balbir Singh
Peter Zijlstra wrote: > On Sun, 2028-02-27 at 02:39 -0500, Balbir Singh wrote: > >> I am not a CLUI expert, but rounding off bytes will something that >> the administrators will probably complain about. Since we manage >> the controller memory in pages, it might be the eas

Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Balbir Singh
Dave Hansen wrote: > On Fri, 2007-07-06 at 14:03 -0700, Balbir Singh wrote: >>>> +ssize_t res_counter_read(struct res_counter *cnt, int member, >>>> +const char __user *userbuf, size_t nbytes, loff_t >> *pos) >>>> +{ >>>

Re: [-mm PATCH 2/8] Memory controller containers setup (v2)

2007-07-06 Thread Balbir Singh
Dave Hansen wrote: > On Thu, 2007-07-05 at 22:21 -0700, Balbir Singh wrote: >> +struct mem_container { >> +struct container_subsys_state css; >> +/* >> + * the counter to account for memory usage >> + */ >> +struct res_counter res; >>

Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Balbir Singh
Dave Hansen wrote: > On Thu, 2007-07-05 at 22:20 -0700, Balbir Singh wrote: >> +/* >> + * the core object. the container that wishes to account for some >> + * resource may include this counter into its structures and use >> + * the helpers described beyond >> + *

Re: [-mm PATCH 0/7] Memory controller introduction

2007-07-06 Thread Balbir Singh
separate page cache control, what we can have is control for either mapped pages or control for a combination of mapped and unmapped pages together. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line &q

Re: [-mm PATCH 0/8] Memory controller introduction (v2)

2007-07-06 Thread Balbir Singh
Balbir Singh wrote: In mem_container_move_lists() > + /* > + * Check if the meta page went away from under us > + */ > + if (!list_empty(&mp->list) You'll need an extra brace here to get it compile. I forgot to refpat

Re: [-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2)

2007-07-06 Thread Balbir Singh
Balbir Singh wrote: > +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan, > + struct list_head *dst, > + unsigned long *scanned, int order, > + int mode, st

Re: [-mm PATCH 0/8] Memory controller introduction (v2)

2007-07-05 Thread Balbir Singh
Balbir Singh wrote: > Changelog since version 1 > > 1. Fixed some compile time errors (in mm/migrate.c from Vaidyanathan S) > 2. Fixed a panic seen when LIST_DEBUG is enabled > 3. Added a mechanism to control whether we track page cache or both >page cache and mapped page

[-mm PATCH 2/8] Memory controller containers setup (v2)

2007-07-05 Thread Balbir Singh
Setup the memory container and add basic hooks and controls to integrate and work with the container. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/memcontrol.h | 19 + init/Kconfig |8

[-mm PATCH 8/8] Add switch to control what type of pages to limit (v2)

2007-07-05 Thread Balbir Singh
current->mm); + error = mem_container_cache_charge(page, current->mm); if (error) goto out; _ -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[-mm PATCH 7/8] Memory controller OOM handling (v2)

2007-07-05 Thread Balbir Singh
Out of memory handling for containers over their limit. A task from the container over limit is chosen using the existing OOM logic and killed. TODO: 1. As discussed in the OLS BOF session, consider implementing a user space policy for OOM handling. Signed-off-by: Balbir Singh <[EMAIL PROTEC

[-mm PATCH 3/8] Memory controller accounting setup (v2)

2007-07-05 Thread Balbir Singh
Basic setup routines, the mm_struct has a pointer to the container that it belongs to and the the page has a meta_page associated with it. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/memcontrol.h | 32 ++ include/linux/mm_types.h

[-mm PATCH 4/8] Memory controller memory accounting (v2)

2007-07-05 Thread Balbir Singh
m the RSS of all tasks, but still lives in the page cache. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- fs/exec.c |1 include/linux/memcontrol.h | 11 +++ include/linux/page-flags.h |3 + mm/filemap.c |8 ++ mm/memcontrol.c

[-mm PATCH 6/8] Memory controller add per container LRU and reclaim (v2)

2007-07-05 Thread Balbir Singh
container aware. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/memcontrol.h | 11 +++ include/linux/res_counter.h | 23 include/linux/swap.h|3 + mm/memcontrol.c | 121 ++ mm/

[-mm PATCH 5/8] Memory controller task migration (v2)

2007-07-05 Thread Balbir Singh
Allow tasks to migrate from one container to the other. We migrate mm_struct's mem_container only when the thread group id migrates. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- mm/memcontrol.c | 35 +++ 1 file changed, 35 insertions(+) d

[-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-05 Thread Balbir Singh
PROTECTED]> Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/res_counter.h | 102 + init/Kconfig|4 + kernel/Makefile |1 kernel/res_counter.c| 121 +++

[-mm PATCH 0/8] Memory controller introduction (v2)

2007-07-05 Thread Balbir Singh
ers_infra.patch mem-control-setup.patch mem-control-accounting-setup.patch mem-control-accounting.patch mem-control-task-migration.patch mem-control-lru-and-reclaim.patch mem-control-out-of-memory.patch -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -

Re: [-mm PATCH 4/7] Memory controller memory accounting

2007-07-05 Thread Balbir Singh
ch incorporated. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [-mm PATCH 0/7] Memory controller introduction

2007-07-05 Thread Balbir Singh
Hi, Pavel, Pavel Emelianov wrote: > Balbir Singh wrote: > > As far as I remember at OLS we decided to implement per-zone RLU > lists and reuse the lru lock as well. This will remove all the > problems with per-container lists inconsistency. > It's there in the T

[-mm PATCH 6/7] Memory controller add per container LRU and reclaim

2007-07-04 Thread Balbir Singh
container aware. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/memcontrol.h | 11 +++ include/linux/res_counter.h | 23 +++ include/linux/swap.h|3 + mm/memcontrol.c | 88 +- mm/swap.c |

[-mm PATCH 7/7] Memory controller OOM handling

2007-07-04 Thread Balbir Singh
Out of memory handling for containers over their limit. A task from the container over limit is chosen using the existing OOM logic and killed. TODO: 1. As discussed in the OLS BOF session, consider implementing a user space policy for OOM handling. Signed-off-by: Balbir Singh <[EMAIL PROTEC

[-mm PATCH 5/7] Memory controller task migration

2007-07-04 Thread Balbir Singh
Allow tasks to migrate from one container to the other. We migrate mm_struct's mem_container only when the thread group id migrates. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- mm/memcontrol.c | 35 +++ 1 file changed, 35 insertions(+) d

[-mm PATCH 3/7] Memory controller accounting setup

2007-07-04 Thread Balbir Singh
Basic setup routines, the mm_struct has a pointer to the container that it belongs to and the the page has a meta_page associated with it. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/memcontrol.h | 32 ++ include/linux/mm_types.h

[-mm PATCH 4/7] Memory controller memory accounting

2007-07-04 Thread Balbir Singh
m the RSS of all tasks, but still lives in the page cache. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- fs/exec.c |1 include/linux/memcontrol.h | 11 +++ include/linux/page-flags.h |3 + mm/filemap.c |8 ++ mm/memcontrol.c

[-mm PATCH 2/7] Memory controller containers setup

2007-07-04 Thread Balbir Singh
Setup the memory container and add basic hooks and controls to integrate and work with the container. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/memcontrol.h | 19 + init/Kconfig |8

[-mm PATCH 0/7] Memory controller introduction

2007-07-04 Thread Balbir Singh
- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

[-mm PATCH 1/7] Memory controller resource counters

2007-07-04 Thread Balbir Singh
Introduce generic structures and routines for resource accounting. Each resource accounting container is supposed to aggregate it, container_subsystem_state and its resource-specific members within. Signed-off-by: Pavel Emelianov <[EMAIL PROTECTED]> Signed-off-by: Balbir Singh <[EMAIL

Re: [patch -rss] Make RSS accounting display more user friendly

2007-06-26 Thread Balbir Singh
Kirill Korotaev wrote: > Paul Menage wrote: >> On 6/22/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >>> The problem with input in bytes is that the user will have to ensure >>> that the input is >>> a multiple of page size, which implies that she

Re: [RFC] mm-controller

2007-06-25 Thread Balbir Singh
better than simply extending the vm_swappiness to per container? > If we're going to do this, get it in the kernel proper first. > I'm open to this. There were several patches to do this. We can do this by splitting the LRU list to mapped and unmapped pages or by trying to b

Re: [patch -rss] Make RSS accounting display more user friendly

2007-06-25 Thread Balbir Singh
Paul Menage wrote: > On 6/22/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> The problem with input in bytes is that the user will have to ensure >> that the input is >> a multiple of page size, which implies that she would need to use the >> calculator ev

Re: [patch -rss] Make RSS accounting display more user friendly

2007-06-22 Thread Balbir Singh
On 6/22/07, Paul Menage <[EMAIL PROTECTED]> wrote: On 6/21/07, Pavel Emelianov <[EMAIL PROTECTED]> wrote: > > Nothing wrong, but currently they are shown in "natural" points, i.e. in > those that the controller accounts them in. For RSS controller the natural > point is "page", but auto-convertin

Re: [RFC] mm-controller

2007-06-21 Thread Balbir Singh
Peter Zijlstra wrote: > On Thu, 2007-06-21 at 16:33 +0530, Balbir Singh wrote: >> Peter Zijlstra wrote: >>> Having read the RSS and Pagecache controllers some things bothered me. >>> >>> - the duplication of much of the reclaim data (not code) >>>

Re: [RFC] mm-controller

2007-06-21 Thread Balbir Singh
(unsigned long)w * nr_scanned; > } else > > > > Considerations: > ~~ > > > Advantages: > - each page is on a single list > - no distinction between container vs global reclaim > - no increase of sizeof(struct page) > - pages are bu

Re: [ANNOUNCE] Linux Kernel Tester’s Guide v0.3-rc1

2007-06-21 Thread Balbir Singh
Michal Piotrowski wrote: > Hi Balbir, > > On 21/06/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> Wonderful! Are there any plans to start using the fault injection >> framework >> to catch more defects? > > There are plans for the second part called "

[patch -rss] Make RSS accounting display more user friendly

2007-06-20 Thread Balbir Singh
), 9223372036854775807 pages :~ # cat /container/rss_usage 36 (MB), 9220 pages :~ # Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/res_counter.h |6 ++ kernel/res_counter.c| 27 +++ 2 files changed, 29 insertions(+), 4 del

Re: [patch] sched: accurate user accounting

2007-06-16 Thread Balbir Singh
malc wrote: > On Fri, 15 Jun 2007, Balbir Singh wrote: > >> malc wrote: >>> On Thu, 14 Jun 2007, Ingo Molnar wrote: >>> > > [..snip..] > >>> >>> Now integral load matches the one obtained via the "accurate" method. >&

Re: [patch] sched: accurate user accounting

2007-06-14 Thread Balbir Singh
ches the one obtained via the "accurate" method. > However the report for individual cores are of by around 20% percent. > I think I missed some of the context, is the accounting of individual tasks or cpustat values off by 20%? I'll try and reproduce this problem. Could you

Add documentation for the RSS controller

2007-06-12 Thread Balbir Singh
d-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/controller/rss.txt | 177 +++ 1 file changed, 177 insertions(+) diff -puN /dev/null Documentation/controller/rss.txt --- /dev/null 2007-06-01 20:42:04.0 +0530 +++ linux-2.6.22-rc24

Re: [RFC][PATCH 3/6] core changes in CFS

2007-06-11 Thread Balbir Singh
> + struct rq *rq = lrq_rq(lrq); > + struct task_struct *curtask = rq->curr; > > - if (curr->sched_class != &fair_sched_class || curr == rq->idle || !load) > + if (!curr || curtask == rq->idle || !load) Can !curr ever be true? shoudn't we look int

Re: [ckrm-tech] [RFC][PATCH 2/6] task's cpu information needs to be always correct

2007-06-11 Thread Balbir Singh
correct is broken. This patch fixes that piece of > code. > > (Thanks to Balbir Singh for pointing this out to me) > > Signed-off-by : Srivatsa Vaddagiri <[EMAIL PROTECTED]> > Acked-by: Balbir Singh <[EMAIL PROTECTED]> > --- > kernel/sched.c |8 +++

Re: [ckrm-tech] [RFC][PATCH 1/6] Introduce struct sched_entity and struct lrq

2007-06-11 Thread Balbir Singh
4 fair_clock, delta_fair_clock; > + u64 exec_clock, delta_exec_clock; > + s64 wait_runtime; > + unsigned long wait_runtime_overruns, wait_runtime_underruns; > + > + struct rb_root tasks_timeline; > + struct rb_node *rb_leftmost; > + struct rb_node *rb_load_bala

Re: [0/1] [patch -mm] Add containerstats (v3)

2007-06-08 Thread Balbir Singh
Andrew Morton wrote: > On Fri, 08 Jun 2007 23:43:46 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >> This patch implements per container statistics infrastructure and re-uses >> code from the taskstats interface. > > boggle. > > Symbol: CONTAINER

[1/1] [PATCH -mm] Update getdelays to become containerstats aware

2007-06-08 Thread Balbir Singh
Update the getdelays utility to become containerstats aware. A new -C option has been added. It takes in a container path and prints out a summary of task states in the container. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/accounting/getdelays.c

[0/1] [patch -mm] Add containerstats (v3)

2007-06-08 Thread Balbir Singh
ng 1, stopped 0, uninterruptible 0 # ./containerstats -C /container/ sleeping 154, blocked 0, running 0, stopped 0, uninterruptible 0 If the approach looks good, I'll enhance and post the user space utility for the same Feedback, comments, test results are always welcome! Signed-off-by:

Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Balbir Singh
ng the reclaim mechanisms > though ... but I doubt that this is what you have > in mind? > Patches are always welcome! >>> best, >>> Herbert >> Thanks for your attention, >> Pavel > > just to make it clear, I don't want any limits > in mainline wh

Re: [ckrm-tech] Per container statistics (containerstats)

2007-06-08 Thread Balbir Singh
Balbir Singh wrote: > Balbir Singh wrote: >>>>return *(pid_t *)a - *(pid_t *)b; >>>> diff -puN kernel/sched.c~containers-taskstats kernel/sched.c >>>> --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats >>>> 2007-06-05 17:

Re: [ckrm-tech] Per container statistics (containerstats)

2007-06-08 Thread Balbir Singh
Balbir Singh wrote: >>> return *(pid_t *)a - *(pid_t *)b; >>> diff -puN kernel/sched.c~containers-taskstats kernel/sched.c >>> --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats >>> 2007-06-05 17:21:57.0 +0530 >>> +

Re: Per container statistics (containerstats)

2007-06-07 Thread Balbir Singh
Andrew Morton wrote: > On Fri, 08 Jun 2007 07:51:12 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >>> I'd have hoped to see containerstats.c in here. >>> >> The current statistics code is really small, so it fit into ta

Re: Per container statistics (containerstats)

2007-06-07 Thread Balbir Singh
return *(pid_t *)a - *(pid_t *)b; >> diff -puN kernel/sched.c~containers-taskstats kernel/sched.c >> --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats 2007-06-05 >> 17:21:57.0 +0530 >> +++ linux-2.6.22-rc2-mm1-balbir/kernel/sched.c 2007-06-05 >> 17

Per container statistics (containerstats)

2007-06-06 Thread Balbir Singh
tainer/ sleeping 154, blocked 0, running 0, stopped 0, uninterruptible 0 If the approach looks good, I'll enhance and post the user space utility for the same Feedback, comments, test results are always welcome! Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/accou

Re: [patch] CFS scheduler, -v15

2007-06-06 Thread Balbir Singh
to deactivate_task() > sched_setscheduler() > { > ... >on_rq = p->on_rq; >if (on_rq) >deactivate_task(rq, p, 0); >oldprio = p->prio; >__setscheduler(rq, p, policy, param->sched_priority); >if (on_rq) { >

Re: [PATCH -RSS] Add documentation for the RSS controller

2007-06-05 Thread Balbir Singh
n.net/Articles/222762/ >> +3. Emelianov, Pavel. Resource controllers based on process containers >> + http://lkml.org/lkml/2007/3/6/198 >> +4. Emelianov, Pavel. RSS controller based on process containers (v2) >> + http://lkml.org/lkml/2007/4/9/74 >> +5. Emelianov, Pavel. RSS controller based on process containers (v3) >> + http://lkml.org/lkml/2007/5/30/244 >> +6. Menage, Paul. Containers v10, http://lwn.net/Articles/236032/ >> +7. Vaidyanathan, Srinivasan, Containers: Pagecache accounting and control >> + subsystem (v3), http://lwn.net/Articles/235534/ > > This (7) is excess. > I am not sure I get this comment. >> +8. Singh, Balbir. RSS controller V2 test results (lmbench), >> + http://lkml.org/lkml/2007/5/17/232 >> +9. Singh, Balbir. RSS controller V2 AIM9 results >> + http://lkml.org/lkml/2007/5/18/1 >> _ >> > -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Performance Stats: Kernel patch

2007-06-04 Thread Balbir Singh
lly > provides, and it should be something which we expect won't suddenly > become unsupportable if people make internal kernel changes. > Yes, agreed. The interface must also be open for changes to accounting information that might be useful as a result of new features, like cont

[PATCH -RSS] Add documentation for the RSS controller

2007-06-04 Thread Balbir Singh
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/controller/rss.txt | 165 +++ 1 file changed, 165 insertions(+) diff -puN /dev/null Documentation/controller/rss.txt --- /dev/null 2007-06-01 20:42:04.0 +0530 +++ linux-2.6.

[PATCH -RSS 2/2] Fix limit check after reclaim

2007-06-04 Thread Balbir Singh
Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/res_counter.h | 23 +++ mm/rss_container.c | 11 +++ 2 files changed, 34 insertions(+) diff -puN mm/rss_container.c~rss-fix-limit-check-after-reclaim mm/rss_container.c --- linux-2.6.22-r

[PATCH -RSS 1/1] Fix reclaim failure

2007-06-04 Thread Balbir Singh
to the application being killed. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- mm/rss_container.c | 31 +++ 1 file changed, 23 insertions(+), 8 deletions(-) diff -puN mm/rss_container.c~rss-fix-free-of-active-pages mm/rss_container.c --- linux-2.6.22-r

Re: [PATCH 8/8] Per-container pages reclamation

2007-06-01 Thread Balbir Singh
Pavel Emelianov wrote: > Balbir Singh wrote: > > [snip] > >>>>> + for_each_online_node(node) { >>>>> +#ifdef CONFIG_HIGHMEM >>>>> + zones = NODE_DATA(node)->node_zonelists[ZONE_HIGHMEM].zones; >

Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner

2007-06-01 Thread Balbir Singh
Pavel Emelianov wrote: > Balbir Singh wrote: >> Andrew Morton wrote: >>>> + nr_reclaimed += shrink_zones(priority, zones, sc); >>>> + if (sc->cnt == NULL) >>>> + shrink_slab(sc->nr_scanned, gfp_mask, lru_pages)

Re: [PATCH 8/8] Per-container pages reclamation

2007-06-01 Thread Balbir Singh
rol->isolate_pages() function is set to >> isolate_pages_in_container() that isolates the container >> pages only. The exported __isolate_lru_page() call >> makes things look simpler than in the previous version. >> >> Includes fix from Balbir Singh <[EMAIL PROTECTED]>

Re: [PATCH 7/8] Scanner changes needed to implement per-container scanner

2007-05-31 Thread Balbir Singh
we do not account for slab usage right now. We account only for memory allocated to user space. A good fat comment will help here. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 5/8] RSS accounting hooks over the code

2007-05-31 Thread Balbir Singh
is done in an atomic >>code that handles races between multiple touchers. > > I suppose we need to think about what to do about higher-order pages, and > compound pages, and hugetlb memory. Yes, that needs to be done eventually. I feel that support can be added incrementa

Re: [PATCH 8/8] Per-container pages reclamation

2007-05-31 Thread Balbir Singh
NE_DMA32 and ZONE_DMA (some architectures put >> all memory into ZONE_DMA (or they used to)) > Won't the node_zonelists[ZONE_NORMAL].zones contain all lower zones (including ZONE_DMA and ZONE_DMA32) from various nodes organized by cost? I need to go lookup the node_zonelists creation. --

Re: [PATCH 00/10] Containers(V10): Generic Process Containers

2007-05-30 Thread Balbir Singh
ready till tomorrow. > By ready, I meant ready for inclusion as a concept/approach. >> and commented on widely. > > Yup :) Balbir, thanks for testing, your patches are already in. > Thanks for including them. -- Warm Regards, Balbir Singh Linux

Re: [PATCH 00/10] Containers(V10): Generic Process Containers

2007-05-30 Thread Balbir Singh
eakier - for example, create a new container on each setuid(), toss the > task into that. Or something along those lines? Please, lets get the RSS controller in. It's ready, been tested and commented on widely. I'll also start porting my containerstats patches on top of -v10. --

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Balbir Singh
On Mon, May 28, 2007 at 01:07:48PM +0200, Ingo Molnar wrote: > > * Balbir Singh <[EMAIL PROTECTED]> wrote: > > > Ingo Molnar wrote: > > > i found an accounting bug in this: it didnt sum up threads correctly. > > > The patch below fixes this. The stime ==

Re: [patch] CFS scheduler, -v14

2007-05-29 Thread Balbir Singh
o_clock_t(p->utime); > +} > + -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] CFS scheduler, -v14

2007-05-25 Thread Balbir Singh
functionality, so I do not understand its impact on accounting. I'll take a look more closely -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [RFC][PATCH] Per container statistics

2007-05-24 Thread Balbir Singh
Paul Menage wrote: > Hi Balbir, > > On 5/14/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> This patch implements per container statistics infrastructure and re-uses >> code from the taskstats interface. A new set of container operations are >> registered

Re: [patch] CFS scheduler, -v14

2007-05-24 Thread Balbir Singh
ve to add precise > accounting to syscall entry/exit points (that would be quite expensive), > but still the sum of utime+stime would be very precise. (and that's what > matters most anyway) > > Ingo I'll start looking into splitting sum_exec_time into utime and st

Re: [PATCH 8/8] Per-container pages reclamation

2007-05-24 Thread Balbir Singh
> Good catch, I'll move the initialization to free_hot_cold_page(). I'm attaching a new patch. I've also gotten rid of the unused variable page in container_rss_del(). I've compile and boot tested the fix -- Thanks, Balbir Singh Linux

Re: RSS controller v2 Test results (lmbench )

2007-05-24 Thread Balbir Singh
Paul Menage wrote: > On 5/24/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> Kirill Korotaev wrote: >> >> Where do we stand on all of this now anyway? I was thinking of >> getting Paul's >> >> changes into -mm soon, see what sort of calamities t

Re: RSS controller v2 Test results (lmbench )

2007-05-24 Thread Balbir Singh
oping/reviewing/commiting resource subsytems. > RSS control had good feedback so far from a number of people > and is a first candidate imho. > Yes, I completely agree! > Thanks, > Kirill > -- Warm Regards, Balbir Singh Linux Technology Center

Re: [patch] CFS scheduler, -v14

2007-05-23 Thread Balbir Singh
rate. The patch below uses sched_clock() for sched_info accounting. Comments, suggestions, feedback is more than welcome! Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/sched.h | 10 +- kernel/delayacct.c| 10 +- kernel/sched_stats.h | 28 +

[PATCH] Fix a simple issue w.r.t mounting of containers

2007-05-18 Thread Balbir Singh
is due to the fact that when we unmount, in container_put_super(), we need to delete the current root from the roots list. The patch below fixes the issue Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- kernel/container.c |1 + 1 file changed, 1 insertion(+) diff -puN

Re: RSS controller v2 Test results (lmbench )

2007-05-17 Thread Balbir Singh
Rik van Riel wrote: > Balbir Singh wrote: > >> A meaningful container size does not hamper performance. I am in the >> process >> of getting more results (with varying container sizes). Please let me >> know >> what you think of the results? Would you like to s

Re: RSS controller v2 Test results (lmbench )

2007-05-17 Thread Balbir Singh
Andrew Morton wrote: > On Thu, 17 May 2007 23:20:12 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >> A meaningful container size does not hamper performance. I am in the process >> of getting more results (with varying container sizes). Please let me know >&

RSS controller v2 Test results (lmbench )

2007-05-17 Thread Balbir Singh
see different benchmarks/ tests/configuration results? Any feedback, suggestions to move this work forward towards identifying and correcting bottlenecks or to help improve it is highly appreciated. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -

Re: [PATCH 8/8] Per-container pages reclamation

2007-05-17 Thread Balbir Singh
nmapped) -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL Index: linux-2.6.20/mm/rss_container.c === --- linux-2.6.20.orig/mm/rss_container.c 2007-05-15 05:13:46.0 -0700 +++ linux-2.

Re: [RFC][PATCH] Per container statistics

2007-05-15 Thread Balbir Singh
ame. Do you agree in general with containerstats? How we build (walk the task list or at the time of task state change) is flexible with containerstats. Thanks for your comments! -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list

[RFC][PATCH] Per container statistics

2007-05-14 Thread Balbir Singh
st results are always welcome! Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/accounting/containerstats.txt | 27 include/linux/Kbuild|1 include/linux/container.h | 10 + include/linux/containerstats.h

Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-10 Thread Balbir Singh
Paul Menage wrote: > On 5/8/07, Balbir Singh <[EMAIL PROTECTED]> wrote: >> >> I now have a use case for maintaining a per-container task list. >> I am trying to build a per-container stats similar to taskstats. >> I intend to support container accounting of &

Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-09 Thread Balbir Singh
e setup environment, I'll try and get this into LTP with a GPL license. -- Thanks, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-09 Thread Balbir Singh
; It assumes that there are not other cpusets currently setup in > the system that happen to conflict with the ones it creates. > > See further comments within the test script itself. > Thanks for the script. Would you like to contribute this script to LTP for wider avail

Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-08 Thread Balbir Singh
for the container (which gets quite ugly with all the string manipulation) Adding a container id, will make it easier to find a container and return statistics belonging to the container. If we get these two features added to the current patches, it will make the infrastructure mor

[PATCH -mm] Add taskstats.h to kbuild

2007-05-02 Thread Balbir Singh
From: David Woodhouse <[EMAIL PROTECTED]> Add taskstats.h to include/linux/Kbuild, make headers_install would then pickup taskstats.h. This needs to be done as taskstats.h is a user interface header. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- include/linux/Kbuild |

Re: [patch] CFS scheduler, -v8

2007-05-02 Thread Balbir Singh
Ingo Molnar wrote: * Balbir Singh <[EMAIL PROTECTED]> wrote: With -v7 I would run the n/n+1 test. Basically on a system with n cpus, I would run n+1 tasks and see how their load is distributed. I usually find that the last two tasks would get stuck on one CPU on the system and would ge

Re: [PATCH 8/8] Per-container pages reclamation

2007-05-02 Thread Balbir Singh
a bug in the RSS controller, where we walk through all nodes during reclaim in try_to_free_pages_in_container(). Instead of for_each_node(), we now use for_each_online_node() so that we do not end up with invalid zones from nodes that are not online. Signed-off-by: Balbir Singh <[EMAIL PROTE

Re: [patch] CFS scheduler, -v8

2007-05-02 Thread Balbir Singh
Ingo Molnar wrote: Changes since -v7: - powerpc debug output and build warning fixes (Balbir Singh) - documentation fixes (Zach Carter) - interactivity: precise load calculation and load smoothing As usual, any sort of feedback, bugreport, fix and suggestion is more than welcome

Re: per-thread rusage

2007-05-01 Thread Balbir Singh
dback to help us move the work forward and make the code ready for acceptance -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Balbir Singh
Paul Menage wrote: On 5/1/07, Balbir Singh <[EMAIL PROTECTED]> wrote: > + if (container_is_removed(cont)) { > + retval = -ENODEV; > + goto out2; > + } Can't we make this check prior to kmalloc() and copy_from_user()? We could but I'

Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Balbir Singh
Paul Jackson wrote: [[ I have bcc'd one or more batch scheduler experts on this post. They will know who they are, and should be aware that they are not listed in the public cc list of this message. - pj ]] Balbir Singh, responding to Paul Menage's Container patch s

Re: [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Balbir Singh
It will help subsystem writers as well. Alternatively, subsystems could use the attach_task() callback to track all tasks, but a per-container list will avoid duplication. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: sen

Re: [PATCH 2/9] Containers (V9): Example CPU accounting subsystem

2007-05-01 Thread Balbir Singh
erval_check > now, which implies we return and never enter the else part. It's been quite sometime since I looked at this code, so I might have gotten it wrong. I see a load of 0% on my powerpc box. I think it is because last_interval_time is always 0, I'll debug further

Re: [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Balbir Singh
ype *cft, + struct file *file, + const char __user *buf, size_t nbytes, loff_t *ppos); + int (*release) (struct inode *inode, struct file *file); +}; + [snip] -- Warm Regards, Balbir Singh Linux Technology Center

[PATCH CFS V7] Fix warnings in sched and sched_debug

2007-04-30 Thread Balbir Singh
cfs v7 Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- kernel/sched.c | 34 +- kernel/sched_debug.c | 16 2 files changed, 25 insertions(+), 25 deletions(-) diff -puN kernel/sched.c~cfs-v7-fix-sched-debug-warnings kernel/s

Re: [patch] CFS scheduler, -v7

2007-04-30 Thread Balbir Singh
8568 -6238568 1617 120 -69832977910 66377151352 27173793 I've started on cfs late (with -v7), hopefully I'll catch up. More questions, feedback will follow. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL Index

Re: [PATCH] RSS container, fix freeing of active pages

2007-04-27 Thread Balbir Singh
inactive list? I am not sure if that was your question in the first place :-) -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

Re: [PATCH] RSS Container, make page_referenced() container aware

2007-04-27 Thread Balbir Singh
Pavel Emelianov wrote: Balbir Singh wrote: Hi, Pavel, This patch should help with the shared page issue of one container holding shared pages in a another container (the container that brought in the page -- by first touch) hostage. The shared pages accounting is tricky. Actually we planned

<    5   6   7   8   9   10   11   >