From: Pierre-Louis Bossart
They were missed in previous contributions.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
also modified to be unique and
self-explanatory. Errors in sdw_slave_clk_stop_callback() were
removed, they are now handled in the caller.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c
From: Pierre-Louis Bossart
For some reason we never added a description for the clk_stop
callback.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
include/linux/soundwire/sdw.h | 1 +
1 file changed, 1 insertion
specification so it's rather unlikely that we need to re-add
this mode later.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 100 ++
include/linux/soundwire/
Existing devices and implementations only support the required
CLOCK_STOP_MODE0. All the code related to CLOCK_STOP_MODE1 has not
been tested and is highly questionable, with a clear confusion between
CLOCK_STOP_MODE1 and the simple clock stop state machine.
This patch removes all usages of CLOCK_
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 21 ++---
1 file changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/dr
) and auxiliary_device_uninit() for the
current iteration before jumping to the common label which releases
everything allocated in prior iterations.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Ranjani Sridharan
Signed-off-by: Bard Liao
---
v2:
- add link_dev_register fo
ouis Bossart
Reviewed-by: Daniel Baluta
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/dmi-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/dmi-quirks.c b/drivers/soundwire/dmi-quirks.c
index 82061c1d9835..5db0a244
intel_link_probe() could return error and dev_get_drvdata() will return
null in such case. So we have to test link->cdns after
link->cdns = dev_get_drvdata(&ldev->auxdev.dev);
Otherwise, we will meet the "kernel NULL pointer dereference" error.
Signed-off-by: Bard Lia
) and auxiliary_device_uninit() for the
current iteration before jumping to the common label which releases
everything allocated in prior iterations.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Ranjani Sridharan
Signed-off-by: Bard Liao
---
v2:
- add link_dev_register fo
Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 70 +++--
1 file changed, 32 insertions(+), 38 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 9bd83c91a873..ea54a1f02252 100644
From: Pierre-Louis Bossart
We sometimes discard -ENODATA when reporting errors and lose all
traces of issues in the console log, add a macro to add use dev_dbg()
in such cases.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard
If a device lost sync and can no longer ACK a command, it may not be
able to enter a lower-power state but it will still be able to resync
when the clock restarts. In those cases, we want to continue with the
clock stop sequence.
This patch modifies the behavior when -ENODATA is received, with the
intel_link_probe() could return error and dev_get_drvdata() will return
null in such case. So we have to test link->cdns after
link->cdns = dev_get_drvdata(&ldev->auxdev.dev);
Otherwise, we will meet the "kernel NULL pointer dereference" error.
Signed-off-by: Bard Lia
: Add support for SoundWire stream management")
Signed-off-by: Rander Wang
Reviewed-by: Keyon Jie
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/stream.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
di
From: Pierre-Louis Bossart
There is no need to assign a pointer to NULL if it's only used in a
loop and assigned within that loop.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Kai Vehmanen
Signed-off-by: Bard Liao
---
dr
cases, not sure why it was
missed here.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/qcom.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundw
: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/stream.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 4915676c4ac2..6a682179cd05 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/str
ned-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/intel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index e2
: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/generic_bandwidth_allocation.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/generic_bandwidth_allocation.c
b/drivers/soundwire/generic_bandwidth_allocation.c
index a9abb9722fde..805f5b6
: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index a38b017f7a54..1a9e307e6a4c 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -593,7 +
e any
purpose. This patch only suggests using the proper indirection.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Bard Liao
---
drivers/soundwire/bus_type.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 1c01cc192cbd..d39e5baa3e64 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/so
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 8b6d8fe934ae..a38b017f7a54 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers
From: Pierre-Louis Bossart
There is no real reason to provide this information except for debug
sessions, hence dev_dbg() is a better fit.
Reported-by: Guennadi Liakhovetski
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard
-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 04eb879de145..1c01cc192cbd 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -875,8 +875,12
To make soundwire driver more decent and less Cppcheck complaint.
Pierre-Louis Bossart (11):
soundwire: bus: use correct driver name in error messages
soundwire: bus: test read status
soundwire: bus: use consistent tests for return values
soundwire: bus: demote clock stop prepare log to de
Keyon Jie
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/slave.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index 112b219
linux/issues/2621
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/cadence_master
From: Pierre-Louis Bossart
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1
From: Pierre-Louis Bossart
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/stream.c | 10 +-
1 file
From: Pierre-Louis Bossart
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 2 +-
1 file
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Pierre-Louis Bossart (5):
soundwire: intel: add missing \n in dev_err()
soundwire: bandwidth_allocation: add missing \n in dev_err()
soundwire: cadence: add missing \n in dev_err()
soundwire: stream: ad
From: Pierre-Louis Bossart
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/generic_bandwidth_allocation.c
From: Pierre-Louis Bossart
We fixed a lot of warnings in 2019 but the magic of copy-paste keeps
adding new ones...
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/intel.c | 18
) and auxiliary_device_uninit() for the
current iteration before jumping to the common label which releases
everything allocated in prior iterations.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Ranjani Sridharan
Signed-off-by: Bard Liao
---
drivers/soundwire/Kc
developed-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
Reviewed-by: Guennadi Liakhovetski
---
include/linux/soundwire/sdw.h | 22 ++
1 file changed, 22 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/s
Add optional interrupt status read/clear if the master quirks are set.
In the case of the parity, the master quirk is only applied if the
Slave doesn't already have a parity-related quirk.
Co-developed-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard
Now that we have declarations and bus support, add quirks for Intel
platforms.
Co-developed-by: Pierre-Louis Bossart
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
Reviewed-by: Guennadi Liakhovetski
---
drivers/soundwire/intel.c | 3 +++
1 file changed, 3 insertions(+)
diff
- Reorder the patches sequence.
- Add comments about each quirk.
- Use u64 quirks.
Bard Liao (3):
soundwire: add master quirks for bus clash and parity
soundwire: bus: handle master quirks for bus clash and parity
soundwire: intel: add master quirks for bus clash and parity
drivers/sound
f the BIOS, with or
without updates.
Co-developed-by: Bard Liao
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
---
drivers/soundwire/dmi-quirks.c | 30 ++
1 file changed, 30 insertions(+)
di
p the existing
invalid ADR information into valid ones.
BugLink: https://github.com/thesofproject/linux/issues/2700
Co-developed-by: Bard Liao
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
---
drivers/soundwire/Makefile
From: Vinod Koul
Platform firmware may have incorrect _ADR values causing the driver
probes to fail. Add the override_ops, which when configured will allow
for quirks based on DMI etc to override the addr values.
Co-developed-by: Bard Liao
Signed-off-by: Bard Liao
Signed-off-by: Vinod Koul
Platform firmware may have incorrect _ADR values causing the driver
probes to fail. Adding the override_ops allows people to override the
addr values.
v2:
- Add the override_adr ops
- Move DMI quirks to a new file
Pierre-Louis Bossart (2):
soundwire: Intel: introduce DMI quirks for HP Spectre
From: Pierre-Louis Bossart
Add a dev_dbg() log for both enumeration and initialization completion
to better track suspend-resume issues.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Reviewed-by: Chao Song
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 11
Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 82df088c9333..d9deafdcf495 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire
b.com/thesofproject/linux/issues/2533
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 9 +
drivers/soundwire/intel.c | 3 ++-
include/linux/soundwire/sdw.h | 1 +
3 files changed, 12 insertions(+), 1 deletion(-)
such
interrupts. The quirk should in theory have been added at the Slave level,
but since the problem was detected with different generations of Slave
devices it's hard to point to a specific IP. The problem might also be
board-dependent and hence dealing with a Master quirk is simpler.
Ba
There is nothing we can do to handle the bus clash interrupt before
interrupt mask is enabled.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soundwire/intel.c b
ific IP. The problem might also be
board-dependent and hence dealing with a Master quirk is simpler.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 10 ++
include/linux/soundwire/sdw.h | 4
2 files changed, 14
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
1 file changed, 2 insert
sions of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bar
e device number is not zero, we
should use &slave->dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
"GPL v2" is the same as "GPL". It exists for historic reasons.
See Documentation/process/license-rules.rst
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw-mbq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
sdw_write_no_pm and sdw_read_no_pm are useful when we want to do IO
without touching PM.
Fixes: 0231453bc08f ('soundwire: bus: add clock stop helpers')
Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
read/write functions')
Signed-off-by: Bard Liao
---
dri
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
25571 ('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/
same problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
dr
rding to maintainer's comments.
Bard Liao (4):
soundwire: export sdw_write/read_no_pm functions
regmap: sdw: use _no_pm functions in regmap_read/write
regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
regmap: sdw-mbq: use MODULE_LICENSE("GPL")
Pierre-Louis Bossart (5)
Signed-off-by: Bard Liao
---
sound/soc/codecs/max98373-sdw.c | 4 +++-
sound/soc/codecs/rt1308-sdw.c | 2 +-
sound/soc/codecs/rt5682.h | 2 +-
sound/soc/codecs/rt700-sdw.c| 2 +-
sound/soc/codecs/rt711-sdw.c| 2 +-
sound/soc/codecs/rt715-sdw.c| 2 +-
6 files changed, 8
than generous.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 9fa55164354a..f0b0ec173f8b 100644
The timeout for an individual transaction w/ the Cadence IP is the same as
the entire resume operation for codecs.
This doesn't make sense, we need to have at least one order of magnitude
between individual transactions and the entire resume operation.
Set the timeout on the Cadence side to 500ms
devices to enumerate
We can skip the 'Msg Ack not received' since it's typical of the
enumeration end, and conversely add the information on which command
fails.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 4 ++--
1 file change
wire: cdns: Add sdw_master_ops and IO transfer
support')
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundwire/cadence_master.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/ca
-by: Bard Liao
---
drivers/soundwire/bus.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 3cc006bfae71..6e1c988f3845 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -267,8 +267,10 @@ static int
92013] soundwire sdw-master-0: No more devices to enumerate
[ 121.892200] intel-sdw intel-sdw.0: Slave status change: 0x21
<< this shows the device now Attached as Device1 and Unattached as
Device0, i.e. a successful enumeration.
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
ff-by: Bard Liao
---
drivers/soundwire/bus.c | 5 ++---
drivers/soundwire/slave.c | 10 --
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index d1e8c3a54976..3cc006bfae71 100644
--- a/drivers/soundwire/bus.c
+++ b/dr
debugging.
Bard Liao (1):
soundwire: bus: add more details to track failed transfers
Pierre-Louis Bossart (4):
soundwire: use consistent format for Slave devID logs
soundwire: cadence: add status in dev_dbg 'State change' log
soundwire: cadence: fix ACK/NAK handling
soundwire: caden
e-initiated interrupts may be lost, but at least audio function can
still work after resume.
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
Reviewed-by: Kai Vehmanen
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
it in the code so people will keep it in mind.
Signed-off-by: Bard Liao
---
drivers/base/core.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 51b9545a050b..17eb14607074 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -
_fwnode()") was fully
correct. Thus, revert the former one here and improve documentation.
Bard Liao (2):
Revert "device property: Keep secondary firmware node secondary by
type"
device property: add description of fwnode cases
drivers/base/core.c | 9 -
1 fi
ode handling in set_primary_fwnode()") was fully
correct. Thus, revert the former one here and improve documentation in
the next patch.
Fixes: d5dcce0c414f ("device property: Keep secondary firmware node secondary
by type")
Signed-off-by: Bard Liao
---
drivers/base/core.c | 2 +-
1 file chang
e device number is not zero, we
should use &slave->dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
"GPL v2" is the same as "GPL". It exists for historic reasons.
See Documentation/process/license-rules.rst
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw-mbq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
sions of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bar
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
1 file changed, 2 insert
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
sdw_write_no_pm and sdw_read_no_pm are useful when we want to do IO
without touching PM.
Fixes: 0231453bc08f ('soundwire: bus: add clock stop helpers')
Fixes: 60ee9be25571 ('soundwire: bus: add PM/no-PM versions of
read/write functions')
Signed-off-by: Bard Liao
---
dri
same problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
dr
25571 ('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/
rding to maintainer's comments.
Bard Liao (4):
soundwire: export sdw_write/read_no_pm functions
regmap: sdw: use _no_pm functions in regmap_read/write
regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
regmap: sdw-mbq: use MODULE_LICENSE("GPL")
Pierre-Louis Bossart (5)
sions of read/write
functions')
Fixes: aa79293517b39 ('soundwire: bus: fix io error when processing alert
event')
Fixes: 9d715fa005ebc ('soundwire: Add IO transfer')
Reported-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bar
e device number is not zero, we
should use &slave->dev to provide more precisions to the
user/integrator.
Reported-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 63 +
Use no_pm versions for write and read.
Signed-off-by: Bard Liao
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw-mbq.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/base/regmap/regmap-sdw-mbq.c
b/drivers
initialization is to use _no_pm
routines. The duty of making sure the bus is operational needs to be
handled above the regmap level.
Fixes: 7c22ce6e21840 ('regmap: Add SoundWire bus support')
Signed-off-by: Bard Liao
Reviewed-by: Rander Wang
---
drivers/base/regmap/regmap-sdw.c | 4 ++--
drivers
From: Pierre-Louis Bossart
There is no need to play with pm_runtime reference counts, if needed
the codec drivers are already explicitly resumed.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 26
is needed for soundwire tree to complie.
On the other hands,
commit 6e06a85556f9 ("soundwire: bus: add comments to explain interrupt loop
filter")
to
commit 47b8520997a8 ("soundwire: bus: only clear valid DPN interrupts")
are needed for regmap tree.
Bard Liao (2):
soundwire/r
same problem as the previous one, but is split to
make the life of linux-stable maintainers less painful.
Fixes: 29d158f90690 ('soundwire: bus: initialize bus clock base and scale
registers')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
dr
25571 ('soundwire: bus: add PM/no-PM versions of read/write
functions')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/
From: Shuming Fan
This is the initial codec driver for rt711 SDCA version.
Signed-off-by: Shuming Fan
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig |7 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/rt711-sdca-sdw.c
From: Shuming Fan
This is the initial amplifier driver for rt1316 SDCA version.
Signed-off-by: Shuming Fan
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig | 6 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/rt1316-sdw.c | 756
From: Jack Yu
First version of rt715 sdw sdca codec driver.
Signed-off-by: Jack Yu
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
sound/soc/codecs/Kconfig | 7 +
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/rt715-sdca-sdw.c | 278 +
sound
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
include/linux/soundwire/sdw_registers.h | 32 +
1 file changed, 32 insertions(+)
diff --git a/include/linux/soundwire/sdw_registers.h
b/include/linux/soundwire/sdw_registers.h
ind
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base/regmap/Kconfig | 6 +-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/regmap-sdw-mbq.c | 101 +++
The MIPI SoundWire Device Class standard will define audio functionality
beyond the scope of the existing SoundWire 1.2 standard, which is limited
to the bus and interface.
The description is inspired by the USB Audio Class, with "functions",
"entities", "control selectors", "audio clusters". The
From: Pierre-Louis Bossart
Explicitly add header files used by regmap SoundWire support.
Suggested-by: Guennadi Liakhovetski
Reviewed-by: Rander Wang
Reviewed-by: Guennadi Liakhovetski
Reviewed-by: Kai Vehmanen
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/base
In practice, the
master device will suspend when all its children are no longer active.
Fixes: bd84256e86ecf ('soundwire: master: enable pm runtime')
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Rander Wang
Signed-off-by: Bard Liao
---
drivers/soundwire/master.c | 14 +
From: Pierre-Louis Bossart
We should only access the fields that are relevant for DP0, and never
write to reserved or read-only SDCA_CASCADE fields.
Signed-off-by: Pierre-Louis Bossart
Reviewed-by: Guennadi Liakhovetski
Signed-off-by: Bard Liao
---
drivers/soundwire/bus.c | 8 +---
1
1 - 100 of 313 matches
Mail list logo