Re: [RESEND PATCH v8 net-next 03/15] net: mvpp2: add CM3 SRAM memory map

2021-02-07 Thread Baruch Siach
Hi Stefan, On Sun, Feb 07 2021, stef...@marvell.com wrote: > From: Stefan Chulski > > This patch adds CM3 memory map and CM3 read/write callbacks. > No functionality changes. > > Signed-off-by: Stefan Chulski > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 +++ > drivers/net/ethern

Re: [PATCH 03/11] dts: mvebu: Add pin control definitions for SDIO interafce

2021-02-03 Thread Baruch Siach
Hi Konstantin, On Wed, Feb 03 2021, kos...@marvell.com wrote: > From: Konstantin Porotchkin > > Add SDIO mode pin control configration for CP0 on A8K DB. This patch does not touch the A8K DB device-tree file. baruch > > Signed-off-by: Konstantin Porotchkin > --- > arch/arm64/boot/dts/marvell

Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings

2021-02-03 Thread Baruch Siach
Hi Konstantin, On Wed, Feb 03 2021, kos...@marvell.com wrote: > From: Konstantin Porotchkin > > Update the settings for AP806 SDHCI interface according to > latest Xenon drivers changes. > - no need to select the PHY slow mode anymore Why? Has anything changed since the introduction of marvell,x

Re: [PATCH 05/21] rtc: digicolor: quiet maybe-unused variable warning

2021-02-02 Thread Baruch Siach
Hi Alex, On Tue, Feb 02 2021, Alexandre Belloni wrote: > When CONFIG_OF is disabled then the matching table is not referenced. > > Signed-off-by: Alexandre Belloni Acked-by: Baruch Siach Thanks, baruch > --- > drivers/rtc/rtc-digicolor.c | 2 +- > 1 file changed, 1 insert

Re: Old platforms: bring out your dead

2021-01-09 Thread Baruch Siach
Hi Arnd, On Sat, Jan 09 2021, Arnd Bergmann wrote: > * digicolor -- added in 2014, no notable changes after 2015 I have access to the hardware and I'm still interested in maintaining mainline kernel support for it. baruch -- ~. .~ Tk Open

Re: [PATCH] ARM: dts: mvebu: Add device tree for ATL-x530 Board

2020-11-29 Thread Baruch Siach
Hi Aryan, [ Dropped Jason's bouncing address from Cc ] On Mon, Nov 30 2020, Aryan Srivastava wrote: > Add device tree file for x530 board. This has an Armada 385 SoC. Has > NAND-flash for user storage and SPI for booting. Covers majority of x530 > and GS980MX variants. > > Signed-off-by: Aryan Sr

Re: Reusing DTS from arm64 to arm

2020-11-23 Thread Baruch Siach
Hi Vinod, On Tue, Nov 24 2020, Vinod Koul wrote: > We have Qualcomm arm platform which uses PMIC PM8150B. This PMIC was > also used in SM8150 board and is already upstream [1] but in arm64. > > So, what is the guidance to share DTS files between 32 and 64 variants? > Does a solution already exist

Re: [PATCH 2/2] ARM: dts: imx6qdl-cubox-i: enable DSM for the RTC

2020-07-19 Thread Baruch Siach
Hi Miguel, On Sun, Jul 19 2020, miguelborgesdefrei...@gmail.com wrote: > From: Miguel Borges de Freitas > > Signed-off-by: Miguel Borges de Freitas > --- The commit log should explain why you enable this for Cubox-i. The information is in your cover letter. But the cover letter is not preserved

Re: [PATCH][next] i2c: digicolor: Use fallthrough pseudo-keyword

2020-07-16 Thread Baruch Siach
ght=fallthrough#implicit-switch-case-fall-through This URL is likely to break at some point as documentation contest changes. Just refer to in kernel Documentation/process/deprecated.rst file. Other than that: Acked-by: Baruch Siach Thanks, baruch > Signed-off-by: Gustavo A. R. Silva &g

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-14 Thread Baruch Siach
Hi Andrew, On Tue, Sep 10 2019, Andrew Lunn wrote: > On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: >> Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the >> Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. >> >> Since commit 5502b218e001 ("net: p

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Baruch Siach
Hi tinywrkb, On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. According to the hardware designer, Rabeeh Khoury, there is not such limitation

Re: [PATCH] watchdog: digicolor_wdt: remove unused variable 'ret'

2019-07-11 Thread Baruch Siach
Hi YueHaibing, On Thu, Jul 11 2019, YueHaibing wrote: > commit cdad26977e3f ("watchdog: digicolor_wdt: drop > warning after registering device") left this unused > variable, it can be removed. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Third time's a charm: https://patchwork.kerne

Re: [PATCH] watchdog: digicolor_wdt: drop unused variable

2019-07-10 Thread Baruch Siach
used-variable] > > Fixes: cdad26977e3f ("watchdog: digicolor_wdt: drop warning after registering > device") > Signed-off-by: Arnd Bergmann Acked-by: Baruch Siach Thanks, baruch > drivers/watchdog/digicolor_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --g

Re: [PATCH] tty/serial: digicolor: Fix digicolor-usart already registered warning

2019-06-01 Thread Baruch Siach
proc_register+0x19d/0x270 > > Fix this by adding uart_unregister_driver() when platform_driver_register() > fails. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang Acked-by: Baruch Siach Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 6

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > On 30/04/2019 15:20:08+0300, Baruch Siach wrote: >> On Tue, Apr 30 2019, Alexandre Belloni wrote: >> > On 30/04/2019 14:36:24+0300, Baruch Siach wrote: >> >> Hi Alexandre, >> >> >>

Re: [PATCH 4/4] rtc: digicolor: convert to SPDX identifier

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > Use SPDX-License-Identifier instead of a verbose license text. > > Signed-off-by: Alexandre Belloni Acked-by: Baruch Siach baruch > --- > drivers/rtc/rtc-digicolor.c | 6 +- > 1 file changed, 1 inserti

Re: [PATCH 3/4] rtc: digicolor: use .set_time

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > Use .set_time instead of the deprecated .set_mmss. > > Signed-off-by: Alexandre Belloni Acked-by: Baruch Siach baruch > --- > drivers/rtc/rtc-digicolor.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 del

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > On 30/04/2019 14:36:24+0300, Baruch Siach wrote: >> Hi Alexandre, >> >> On Tue, Apr 30 2019, Alexandre Belloni wrote: >> >> > While the range of REFERENCE + TIME is actually 33 bits, the counter >

Re: [PATCH 2/4] rtc: digicolor: set range

2019-04-30 Thread Baruch Siach
Hi Alexandre, On Tue, Apr 30 2019, Alexandre Belloni wrote: > While the range of REFERENCE + TIME is actually 33 bits, the counter > itself (TIME) is a 32-bits seconds counter. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-digicolor.c | 1 + > 1 file changed, 1 insertion(+) > > d

Re: [PATCH 1/4] rtc: digicolor: fix possible race condition

2019-04-30 Thread Baruch Siach
ice to allocate the rtc > struct before requesting the IRQ. > > Signed-off-by: Alexandre Belloni Acked-by: Baruch Siach baruch > --- > drivers/rtc/rtc-digicolor.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/rtc/rtc-di

Re: [PATCH v3] ARM: debug-ll: add default address for digicolor

2019-04-17 Thread Baruch Siach
stuck in a loop > waiting for the user to input the number. As we already know > the physical address, this patch provides that number as > default, along with a reasonable default value for the virtual > address. > > Cc: Baruch Siach > Signed-off-by: Arnd Bergmann Review

Re: [PATCH v2] ARM: debug-ll: add default address for digicolor

2019-04-17 Thread Baruch Siach
stuck in a loop > waiting for the user to input the number. As we already know > the physical address, this patch provides that number as > default, along with a reasonable default value for the virtual > address. > > Cc: Baruch Siach > Signed-off-by: Arnd Bergmann > --- &

Re: [PATCH] ARM: debug-ll: add default address for digicolor

2019-04-16 Thread Baruch Siach
ated randconfig build stuck in a loop > waiting for the user to input the number. As we already know > the physical address, this patch provides that number as > default, along with a reasonable default value for the virtual > address. > > Cc: Baruch Siach > Signed-off-

Re: [PATCH v1 2/3] dt-bindings: mailbox: Document armada-37xx-rwtm-mailbox binding

2018-12-20 Thread Baruch Siach
Hi Marek, Marek Behun writes: >> > +- compatible :must be "marvell,armada-37xx-rwtm-mailbox" >> >> Don't use wildcards in compatible strings. > > You mean that "mailbox" shouldn't be there? You should use '3700' instead of '37xx'. baruch -- http://baruch.siach.name/blog/

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-17 Thread Baruch Siach
Hi Miquel, Miquel Raynal writes: > Marek Behun wrote on Fri, 14 Dec 2018 01:57:12 > +0100: > >> On Fri, 14 Dec 2018 01:47:01 +0100 >> Marek Behun wrote: >> >> > are there already patches for the A37xx comphy driver? > > Please try the latest patches on top of phy -next (with PHY interface > m

Re: [PATCH v3 2/3] dt-bindings: reset: imx7: Document usage on i.MX8MQ SoCs

2018-12-16 Thread Baruch Siach
Hi Andrey, Andrey Smirnov writes: > The driver now supports i.MX8MQ, so update bindings accordingly. > > Cc: p.za...@pengutronix.de > Cc: Fabio Estevam > Cc: cphe...@gmail.com > Cc: l.st...@pengutronix.de > Cc: Leonard Crestez > Cc: "A.s. Dong" > Cc: Richard Zhu > Cc: Rob Herring > Cc: device

Re: [v2] PCI: imx: make msi work without pcieportbus

2018-12-13 Thread Baruch Siach
Hi Richard, Richard Zhu writes: >> -Original Message- >> From: Baruch Siach [mailto:bar...@tkos.co.il] >> Sent: 2018年12月13日 16:13 >> To: Richard Zhu >> Cc: bhelg...@google.com; lorenzo.pieral...@arm.com; >> l.st...@pengutronix.de; andrew.smir...@gma

Re: [v2] PCI: imx: make msi work without pcieportbus

2018-12-13 Thread Baruch Siach
Hi Richard, One more comment that occurred to me only now. Richard Zhu writes: > MSI_EN of iMX PCIe RC would be asserted when > PCIEPORTBUS driver is selected. > Thus, the MSI works fine on iMX PCIe before. > Assert it unconditionally when MSI is supported. > Otherwise, the MSI wouldn't be trigge

Re: [PATCH] PCI: imx: make msi work without pcieportbus

2018-12-12 Thread Baruch Siach
Hi Richard, Thanks for debugging this issue. One question below. Richard Zhu writes: > MSI_EN of iMX PCIe RC would be asserted when > PCIEPORTBUS driver is selected. > Thus, the MSI works fine on iMX PCIe before. > Make a double check on this bit, and assert it > when it is not set and MSI is sup

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Baruch Siach
Hi Antoine, On Wed, Dec 12, 2018 at 03:14:51PM +0100, Antoine Tenart wrote: > On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > > On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > > > On Tue, Dec 11, 2018 at 07:53:42PM +0200,

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Baruch Siach
support 10G modes in certain cases. This is not true, >> as only the port #0 can do so. This patch fixes it. >> >> Fixes: 01b3fd5ac97c ("net: mvpp2: fix detection of 10G SFP modules") >> Cc: Baruch Siach >> Signed-off-by: Antoine Tenart >> --- >>

Re: [PATCH] PCI: controller: dwc: Make PCI_IMX6 depend on PCIEPORTBUS

2018-12-06 Thread Baruch Siach
Hi Andrey, Adding Robert Hancock who reported[1] on a PCIe MSI issue with i.MX6. Andrey Smirnov writes: > Building a kernel with CONFIG_PCI_IMX6=y, but CONFIG_PCIEPORTBUS=n > produces a system where built-in PCIE bridge (16c3:abcd) isn't bound > to pcieport driver. This, in turn, results in a PC

[PATCH] psi: fix reference to kernel commandline enable

2018-12-02 Thread Baruch Siach
The kernel commandline parameter named in CONFIG_PSI_DEFAULT_DISABLED help text contradicts the documentation in kernel-parameters.txt, and the code. Fix that. Fixes: e0c274472d ("psi: make disabling/enabling easier for vendor kernels") Signed-off-by: Baruch Siach --- init/Kconfig |

Re: [bug report] armada-8040-mcbin: 4.20-rc1 boot failure

2018-11-11 Thread Baruch Siach
Hi Sergey, Gregory, Sergey Matyukevich writes: > MacchiatoBin board fails to boot v4.20-rc1 kernel built using arm64 > defconfig. According to quick bisection of the board dts file, the > root cause is in dts patch enabling CPU deep idle states: > see 8ed46368776b3bc. Is there any pending fix othe

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Baruch Siach
Hi Russell, Russell King - ARM Linux writes: > On Wed, Sep 12, 2018 at 09:49:41PM +0300, Baruch Siach wrote: >> I reproduced the same Oops on Clearfog Base without any taint: >> >> [1.476401] Internal error: Oops - undefined instruction: 0 [#1] SMP ARM > ... >>

Re: [BISECTED] Regression: Solidrun Clearfog Base won't boot since "PCI: mvebu: Only remap I/O space if configured"

2018-09-12 Thread Baruch Siach
Hi Jan, Jan Kundrát writes: > since commit ee1604381a371b3ea6aec7d5e43b6e3f5e153854 ("PCI: mvebu: Only > remap I/O space if configured"), my board (Solidrun Clearfog Base) won't > finish booting with 4.18-rc3 won't boot: You mean '4.19-rc3', right? >> [1.741458] Internal error: Oops - undefi

[PATCH] MAINTAINERS: libata pata: fix Jens Axboe's email address

2018-08-26 Thread Baruch Siach
Commit 7634ccd2da (libata: maintainership update) added an invalid email address. Fix that. Signed-off-by: Baruch Siach --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a5b256b25905..9ae5cdef37a1 100644 --- a/MAINTAINERS +++ b

Re: [PATCH 2/2] rtc:rtc-ds1347: Use PTR_ERR_OR_ZERO to replace the open code

2018-08-13 Thread Baruch Siach
Hi zhong, On Mon, Aug 13, 2018 at 07:31:25PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Baruch Siach Thanks, baruch > --- >

Re: [PATCH 1/2] rtc:rtc-digicolor: Use PTR_ERR_OR_ZERO to replace the open code

2018-08-13 Thread Baruch Siach
Hi zhong, On Mon, Aug 13, 2018 at 07:31:24PM +0800, zhong jiang wrote: > PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So > just replace them rather than duplicating its implement. > > Signed-off-by: zhong jiang Acked-by: Baruch Siach Thanks, baruch > --- >

Re: [PATCH] ARM: dts: armada388-helios4

2018-06-04 Thread Baruch Siach
Hi Dennis, On Mon, Jun 04, 2018 at 08:13:43PM -0500, Dennis Gilmore wrote: > The helios4 is a Armada388 based nas board designed by SolidRun and > based on their SOM. It is sold by kobol.io the dts file came from > https://raw.githubusercontent.com/armbian/build/master/patch/kernel/mvebu-default/9

Re: [PATCH] ARM: debug: Add Iproc UART3 debug addresses

2018-05-30 Thread Baruch Siach
Hi Clément, On Wed, May 30, 2018 at 02:55:28PM +0200, Clément Péron wrote: > On Wed, 30 May 2018 at 14:47, Baruch Siach wrote: > > On Wed, May 30, 2018 at 02:29:22PM +0200, Clément Péron wrote: > > > From: Clément Peron > > > > > > Broadcom Iproc SoCs typ

Re: [PATCH] ARM: debug: Add Iproc UART3 debug addresses

2018-05-30 Thread Baruch Siach
Hi Clément, On Wed, May 30, 2018 at 02:29:22PM +0200, Clément Péron wrote: > From: Clément Peron > > Broadcom Iproc SoCs typically use the UART3 for > debug/console, provide a known good location for that. > > Signed-off-by: Clément Peron > --- > arch/arm/Kconfig.debug | 12 +++- > 1

Re: uImage target support on arm64

2018-05-24 Thread Baruch Siach
Hi Ramon, On Thu, May 24, 2018 at 10:05:15PM +0300, Ramon Fried wrote: > I've noticed that it's not supported. > Is it on purpose ? Yes. The 32bit load address in the uImage header in pretty limited when applied to 64bit ARM64. Even for ARM zImage is the preferred kernel format for quite some t

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-24 Thread Baruch Siach
Hi Tomasz, On Mon, May 07, 2018 at 06:41:50AM +, Tomasz Figa wrote: > On Mon, May 7, 2018 at 3:38 PM Baruch Siach wrote: > > On Mon, May 07, 2018 at 06:13:27AM +, Tomasz Figa wrote: > > > On Thu, May 3, 2018 at 6:09 PM Baruch Siach wrote: > > > > On Thu, Ma

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-06 Thread Baruch Siach
Hi Tomasz, On Mon, May 07, 2018 at 06:13:27AM +, Tomasz Figa wrote: > On Thu, May 3, 2018 at 6:09 PM Baruch Siach wrote: > > On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > > > +static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on) > >

Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver

2018-05-03 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > +static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on) > +{ > + struct rkisp1_device *isp_dev = sd_to_isp_dev(sd); > + int ret; > + > + v4l2_dbg(1, rkisp1_debug, &isp_dev->v4l2_dev, "s_power: %d\n", on);

Re: [PATCH V4] ZBOOT: fix stack protector in compressed boot phase

2018-03-28 Thread Baruch Siach
Hi Huacai, On Wed, Mar 28, 2018 at 04:38:16PM +0800, Huacai Chen wrote: > Call __stack_chk_guard_setup() in decompress_kernel() is too late that > stack checking always fails for decompress_kernel() itself. So remove > __stack_chk_guard_setup() and initialize __stack_chk_guard before we > call dec

Re: [PATCH] arm64: avoid race condition issue in dump_backtrace

2018-03-21 Thread Baruch Siach
Hi Ji Zhang, On Thu, Mar 22, 2018 at 11:06:00AM +0800, Ji Zhang wrote: > When we dump the backtrace of some specific task, there is a potential race > condition due to the task may be running on other cores if SMP enabled. > That is because for current implementation, if the task is not the curren

Re: [PATCH net-next 05/10] phy: cp110-comphy: 2.5G SGMII mode

2018-03-17 Thread Baruch Siach
Hi Antoine, On Fri, Mar 16, 2018 at 11:33:46AM +0100, Antoine Tenart wrote: > This patch allow the CP100 comphy to configure some lanes in the Should be 'CP110'. > 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the > same code path. > > Signed-off-by: Antoine Tenart baruch

Re: [PATCH v6 09/17] media: rkisp1: add rockchip isp1 core driver

2018-03-10 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:59PM +0800, Jacob Chen wrote: > +config VIDEO_ROCKCHIP_ISP1 > + tristate "Rockchip Image Signal Processing v1 Unit driver" > + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on ARCH_ROCKCHIP || COMPILE_TEST > + select VIDEOBUF2_DM

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Fri, Mar 09, 2018 at 01:05:28PM +0800, Jacob Chen wrote: > 2018-03-09 12:09 GMT+08:00 Baruch Siach : > > On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > >> 2018-03-08 20:02 GMT+08:00 Baruch Siach : > >> > On Thu, Mar 08, 2018 at 05:4

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Fri, Mar 09, 2018 at 08:53:57AM +0800, Jacob Chen wrote: > 2018-03-08 20:02 GMT+08:00 Baruch Siach : > > On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > >> This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > >>

Re: [PATCH v6 00/17] Rockchip ISP1 Driver

2018-03-08 Thread Baruch Siach
Hi Jacob, On Thu, Mar 08, 2018 at 05:47:50PM +0800, Jacob Chen wrote: > This patch series add a ISP(Camera) v4l2 driver for rockchip rk3288/rk3399 > SoC. > > Wiki Pages: > http://opensource.rock-chips.com/wiki_Rockchip-isp1 > > The deprecated g_mbus_config op is not dropped in V6 because i am

[PATCH] gpio: raspberrypi-exp: explain Kconfig dependency

2018-03-02 Thread Baruch Siach
Signed-off-by: Baruch Siach --- drivers/gpio/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 52a8b0a6f4e1..1bb25c1ff2d8 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -126,6 +126,8 @@ config GPIO_RASPBERRYPI_EXP

Re: [PATCH] gpio: raspberrypi-ext: fix firmware dependency

2018-03-01 Thread Baruch Siach
Hi Linus, On Thu, Mar 01, 2018 at 10:28:52AM +0100, Linus Walleij wrote: > On Wed, Feb 28, 2018 at 2:48 PM, Arnd Bergmann wrote: > > When the firmware driver is a loadable module, the gpio driver cannot be > > built-in: > > > > drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set':

Re: [PATCH] gpio: raspberrypi-ext: fix firmware dependency

2018-03-01 Thread Baruch Siach
Hi Arnd, On Wed, Feb 28, 2018 at 11:08:54PM +0100, Arnd Bergmann wrote: > On Wed, Feb 28, 2018 at 10:47 PM, Baruch Siach wrote: > > Thanks for the fix. > > > > On Wed, Feb 28, 2018 at 02:48:08PM +0100, Arnd Bergmann wrote: > >> When the firmware driver is a lo

Re: [PATCH] gpio: raspberrypi-ext: fix firmware dependency

2018-02-28 Thread Baruch Siach
Hi Arnd, Thanks for the fix. On Wed, Feb 28, 2018 at 02:48:08PM +0100, Arnd Bergmann wrote: > When the firmware driver is a loadable module, the gpio driver cannot be > built-in: > > drivers/gpio/gpio-raspberrypi-exp.o: In function `rpi_exp_gpio_set': > gpio-raspberrypi-exp.c:(.text+0xb4): undef

Re: [BUG] arm64: Build error with gcc 6

2018-02-24 Thread Baruch Siach
Hi Masami Hiramatsu, On Sun, Feb 25, 2018 at 11:50:37AM +0900, Masami Hiramatsu wrote: > commit e1a50de37860 ("arm64: cputype: Silence Sparse warnings") > introduces "UL" suffix to a hex number, but it causes a build error with > gcc-6 series. > I've hit below error with 6.2.1 and 6.4.1. Of cours

[PATCH] uapi: remove telephony headers

2018-02-22 Thread Baruch Siach
ixjuser.h includes the telephony.h header. Other than that no kernel code uses any of these headers. The last user of the ixjuser.h header has been removed in commit 7326446c728 (Staging: remove telephony drivers), more than 5 years ago. Signed-off-by: Baruch Siach --- include/uapi/linux

Re: [PATCH] MAINTAINERS: add Freescale pin controllers

2018-02-12 Thread Baruch Siach
Hi Lucas, On Mon, Feb 12, 2018 at 11:48:22AM +0100, Lucas Stach wrote: > Am Samstag, den 10.02.2018, 16:32 +0100 schrieb Stefan Agner: > > Add Dong Aisheng, Fabio Estevam, Shawn Guo and myself as maintainer > > and Sascha as reviewer. > > > > Signed-off-by: Stefan Agner > > --- > >  MAINTAINERS

Re: [PATCH] ARM: CPU hotplug: Delegate complete() to surviving CPU

2017-12-12 Thread Baruch Siach
Hi Paul, On Tue, Dec 12, 2017 at 09:20:59AM -0800, Paul E. McKenney wrote: > The ARM implementation of arch_cpu_idle_dead() invokes complete(), but > does so after RCU has stopped watching the outgoing CPU, which results > in lockdep complaints because complete() invokes functions containing RCU >

Re: [PATCH] ARM: dts: introduce the sama5d2 ptc ek board

2017-12-05 Thread Baruch Siach
Hi Ludovic, On Tue, Dec 05, 2017 at 03:23:12PM +0100, Ludovic Desroches wrote: > Add the official SAMA5D2 Peripheral Touch Controller Evaluation > Kit board. > > Signed-off-by: Ludovic Desroches > --- [...] > + memory { > + reg = <0x2000 0x8>; > + }; The size value

Re: [RFC] Improving udelay/ndelay on platforms where that is possible

2017-11-01 Thread Baruch Siach
Hi Marc, On Wed, Nov 01, 2017 at 08:03:20PM +0100, Marc Gonzalez wrote: > On 01/11/2017 18:53, Alan Cox wrote: > > For that matter given the bad blocks don't randomly change why not cache > > them ? > > That's a good question, I'll ask the NAND framework maintainer. > Store them where, by the wa

[PATCH] dt-binding: phy: don't confuse with Ethernet phy properties

2017-09-03 Thread Baruch Siach
The generic PHY 'phys' property sometime appears in the same node with the Ethernet PHY 'phy' or 'phy-handle' properties. Add a warning in phy-bindings.txt to reduce confusion. Signed-off-by: Baruch Siach --- Documentation/devicetree/bindings/phy/phy-bindings.t

Re: [RESEND PATCH 1/1] arm64: dts: Add Variscite DART-SD410 Evaluation board dts

2017-08-25 Thread Baruch Siach
Hi Leonid, On Wed, Aug 23, 2017 at 08:44:56PM +0300, Leonid Segal wrote: > Thank you very much for the tips. > I have updated the documentation and schematics of our web site. > I also tried to implement all other fixes, but seems that I cannot file the > git > you are talking about. > The patche

Re: [PATCH 07/17] pinctrl: digicolor: constify pinconf_ops, pinctrl_ops, and pinmux_ops structures

2017-08-10 Thread Baruch Siach
-off-by: Julia Lawall Acked-by: Baruch Siach Thanks, baruch > --- > drivers/pinctrl/pinctrl-digicolor.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c > b/drivers/pinctrl/pinctrl-digicolor.c > index 639a5

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-30 Thread Baruch Siach
Hi Yong, On Mon, Jul 31, 2017 at 09:48:06AM +0800, Yong wrote: > On Sun, 30 Jul 2017 09:08:01 +0300 > Baruch Siach wrote: > > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > >

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-29 Thread Baruch Siach
Hi Maxime, Yong, On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-27 Thread Baruch Siach
Hi Yong, I managed to get the Frame Done interrupt with the previous version of this driver on the A33 OLinuXino. No data yet (all zeros). I'm still working on it. One comment below. On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > Allwinner V3s SoC have two CSI module. CSI0 is used

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-18 Thread Baruch Siach
Hi Yong, On Wed, Jul 19, 2017 at 02:21:20PM +0800, Yong wrote: > On Wed, 19 Jul 2017 07:49:23 +0300 > Baruch Siach wrote: > > On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > > > I am waiting for more comments for the sunxi-csi.h. It's pleasure if > > >

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-18 Thread Baruch Siach
Hi Yong, On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote: > On Tue, 18 Jul 2017 14:55:30 +0300 > Baruch Siach wrote: > > I am trying to get this driver working on the Olimex A33 OLinuXino. I > > didn't get it working yet, but I had some progress. See the comment be

Re: [PATCH] irqchip: Convert to using %pOF instead of full_name

2017-07-18 Thread Baruch Siach
g > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Lee Jones > Cc: Eric Anholt > Cc: Stefan Wahren > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: Baruch Siach > Cc: Vladim

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-18 Thread Baruch Siach
Hi Yong, I am trying to get this driver working on the Olimex A33 OLinuXino. I didn't get it working yet, but I had some progress. See the comment below on one issue I encountered. On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > Add binding documentation for Allwinner CSI. > > Sig

Re: [PATCH 10/11] irqchip: digicolor: Drop unnecessary static

2017-07-15 Thread Baruch Siach
x > when strict > ?x = e; > // > > Signed-off-by: Julia Lawall Acked-by: Baruch Siach Thanks, baruch > --- > These patches are all independent of each other. > > drivers/irqchip/irq-digicolor.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] trace-cmd: use the standard PATH_MAX macro

2017-06-29 Thread Baruch Siach
Having both local MAX_PATH and standard PATH_MAX macros in the code is confusing. The fact that the MAX_PATH value varies doesn't help. Use the POSIX standard PATH_MAX everywhere. Signed-off-by: Baruch Siach --- trace-listen.c | 6 ++ trace-record.c | 8 trace-util.c

Re: [PATCH] trace-listen: add missing header

2017-06-29 Thread Baruch Siach
Hi Steven, On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote: > On Thu, 29 Jun 2017 14:46:21 +0300 > Baruch Siach wrote: > > > The PATH_MAX macro requires the limits.h header. This fixes build with musl > > libc: > > > > .../trace-cmd-trace-cmd-v

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

2017-06-29 Thread Baruch Siach
Hi Claudiu, On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: > Add specifig DTS files and bindings for sama5d27 SoM1 EK board. Is there any publicly available information on this SoM? One more comment below. > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > ---

[PATCH] trace-listen: add missing header

2017-06-29 Thread Baruch Siach
, VAR_RUN_DIR "/trace-cmd-net.pid"); ^~~~ Signed-off-by: Baruch Siach --- trace-listen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trace-listen.c b/trace-listen.c index 17ff9d8c160c..838d6bcf3649 100644 --- a/trace-listen.c +++ b/trace-listen.c @@ -

Re: [PATCH] clocksource: timer-digicolor: Fix resource leaks in error paths.

2017-06-28 Thread Baruch Siach
Hi Arvind, On Wed, Jun 28, 2017 at 02:15:23PM +0530, Arvind Yadav wrote: > Handle return value of clk_prepare_enable. In case of error at init time, > rollback iomapping and unprepare clk. A failure in digicolor_timer_init() means that the system doesn't boot. I'm not sure how useful the cleanup

Re: [PATCH] radio: wl1273: add check on core->write() return value

2017-06-21 Thread Baruch Siach
Hi Gustavi, On Wed, Jun 21, 2017 at 11:01:22PM -0500, Gustavo A. R. Silva wrote: > Check return value from call to core->write(), so in case of > error print error message, jump to goto label fail and eventually > return. > > Addresses-Coverity-ID: 1226943 > Signed-off-by: Gustavo A. R. Silva >

Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

2017-05-15 Thread Baruch Siach
Hi Greg, On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote: > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote: > > The third argument of devm_request_threaded_irq() is the primary > > handler. It is called in hardirq context and checks whether the > > interrupt is releva

Re: [PATCH v2] soc: brcmstb: enable drivers for ARM64 and BMIPS

2017-04-19 Thread Baruch Siach
Hi Markus, On Wed, Apr 19, 2017 at 03:50:40PM -0700, Markus Mayer wrote: > From: Markus Mayer > > We enable the BRCMSTB SoC drivers not only for ARM, but also ARM64 and > BMIPS. > > Signed-off-by: Markus Mayer > --- > > I used (COMPILE_TEST & OF) as condition like Raspberry Pi, since we > hav

Re: [GIT PULL] bcm2835-dt-next-2017-03-30

2017-04-18 Thread Baruch Siach
add index to the ethernet alias (2017-03-27 10:10:39 > -0700) > > -------- > This pull request brings back bcm2835 DT fixups from Baruch Siach that > got misplaced after a PR for 4.11 got rejected. > > >

Re: [PATCH 0/3] minitty: a minimal TTY layer alternative for embedded systems

2017-03-23 Thread Baruch Siach
Hi Nicolas, On Thu, Mar 23, 2017 at 05:03:01PM -0400, Nicolas Pitre wrote: > Here's some numbers using a minimal ARM config. > > When CONFIG_TTY=y, the following files are linked into the kernel: > >textdata bss dec hex filename >8796 128 0892422dc drive

Re: [PATCH] doc: ABI: vdso: update parse_vdso.c reference

2017-03-14 Thread Baruch Siach
Hi Jonathan, On Mon, Mar 13, 2017 at 05:13:38PM -0600, Jonathan Corbet wrote: > On Wed, 8 Mar 2017 21:50:31 +0200 > Baruch Siach wrote: > > Since commit f9b6b0ef603 ("selftests: move vDSO tests from > > Documentation/vDSO") > > parse_vdso.c moved under selfte

[PATCH] doc: ABI: vdso: update parse_vdso.c reference

2017-03-08 Thread Baruch Siach
Since commit f9b6b0ef603 ("selftests: move vDSO tests from Documentation/vDSO") parse_vdso.c moved under selftests. Update the reference to match. Cc: Jonathan Corbet Signed-off-by: Baruch Siach --- Documentation/ABI/stable/vdso | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

linux-kernel@vger.kernel.org

2017-02-21 Thread Baruch Siach
Hi Gerd, On Tue, Feb 21, 2017 at 10:07:06AM +0100, Gerd Hoffmann wrote: > For the raspberry pi 3 we'll need both sdhci (handles sdio wifi) and > sdhost (handles sdcard). > > Signed-off-by: Gerd Hoffmann > Acked-by: Eric Anholt > --- > arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts | 17 +

Re: [PATCH v3] [media] coda: add Freescale firmware compatibility location

2017-01-19 Thread Baruch Siach
Hi Philipp, (Adding firmware loader maintainers to Cc). On Thu, Jan 19, 2017 at 10:44:54AM +0100, Philipp Zabel wrote: > On Wed, 2017-01-18 at 21:33 +0200, Baruch Siach wrote: > > > - if (dev->firmware == 1) { > > > + if (dev->firmware > 0) { > > > >

Re: [PATCH 16/62] watchdog: digicolor_wdt: Convert to use device managed functions and other improvements

2017-01-12 Thread Baruch Siach
) followed by > devm_ioremap_resource() > - Drop platform_set_drvdata() > - Replace &pdev->dev with dev if 'struct device *dev' is a declared > variable > - Use devm_watchdog_register_driver() to register watchdog device > - Replace shutdown function wi

Re: [PATCH v2] watchdog: constify watchdog_info structures

2016-12-26 Thread Baruch Siach
@@ > obj.info=&i@p; > > @bad@ > position p!={r1.p,ok.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct watchdog_info i; > > Signed-off-by: Bhumika Goyal F

Re: [RFC PATCH 04/23] arm: use kconfig fragments for ARCH_ASPEED defconfigs

2016-12-06 Thread Baruch Siach
Hi Bartlomiej, On Tue, Dec 06, 2016 at 01:38:39PM +0100, Bartlomiej Zolnierkiewicz wrote: > Replace [acs5k,acs5k_tiny,ks8695]_defconfig-s with a Makefile target > using merge_config. > > The patch was verified with doing: > > $ make [acs5k,acs5k_tiny,ks8695]_defconfig > $ make savedefcon

Re: [PATCH v2] mfd: twl-core: make driver DT only

2016-11-22 Thread Baruch Siach
Hi Nicolae, On Tue, Nov 22, 2016 at 12:21:30PM +0200, Nicolae Rosia wrote: > All users are DT-only and it makes no sense to keep > unused code which also prevents further cleanups. > > Signed-off-by: Nicolae Rosia > --- > Changes in v2: > Increased audience in CC list > > drivers/mfd/Kconfig

Re: [PATCH 4/4] i2c: digicolor: Fix module autoload

2016-10-18 Thread Baruch Siach
| grep alias > alias: of:N*T*Ccnxt,cx92755-i2cC* > alias: of:N*T*Ccnxt,cx92755-i2c > > Signed-off-by: Javier Martinez Canillas Acked-by: Baruch Siach Thanks, baruch > drivers/i2c/busses/i2c-digicolor.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH] clocksource: timer-digicolor: Unmap region obtained by of_iomap

2016-09-22 Thread Baruch Siach
Hi Arvind Yadav, On Thu, Sep 22, 2016 at 07:51:13PM +0530, Arvind Yadav wrote: > Free memory mapping, if digicolor_timer_init is not successful. Thanks for looking into that. Why not add a devm_of_iomap() variant of of_iomap() that calls devm_ioremap() instead of ioremap()? I'm not sure that c

Re: [PATCH v2 2/3] clk: mvebu: dynamically allocate resources in Armada CP110 system controller

2016-09-06 Thread Baruch Siach
Hi Marcin, On Tue, Sep 06, 2016 at 07:31:56PM +0200, Marcin Wojtas wrote: > + cp110_clks = devm_kcalloc(&pdev->dev, sizeof(struct clk *), > + CP110_CLK_NUM, GFP_KERNEL); > + if (!cp110_clks) > + return PTR_ERR(cp110_clks); PTR_ERR(NULL) translates

Re: [PATCH] rtc: constify rtc_class_ops structures

2016-08-31 Thread Baruch Siach
st. Declare rtc_class_ops structures that have these > properties as const. [...] > Signed-off-by: Julia Lawall For rtc-digicolor.c: Acked-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}-

Re: [PATCH 1/9] mm: Hardened usercopy

2016-07-07 Thread Baruch Siach
Hi Kees, On Thu, Jul 07, 2016 at 01:25:21PM -0400, Kees Cook wrote: > On Thu, Jul 7, 2016 at 1:37 AM, Baruch Siach wrote: > > On Wed, Jul 06, 2016 at 03:25:20PM -0700, Kees Cook wrote: > >> +#ifdef CONFIG_HAVE_HARDENED_USERCOPY_ALLOCATOR > > > > Should be CONFIG_

Re: [PATCH 1/9] mm: Hardened usercopy

2016-07-06 Thread Baruch Siach
Hi Kees, On Wed, Jul 06, 2016 at 03:25:20PM -0700, Kees Cook wrote: > +#ifdef CONFIG_HAVE_HARDENED_USERCOPY_ALLOCATOR Should be CONFIG_HARDENED_USERCOPY to match the slab/slub implementation condition. > +const char *__check_heap_object(const void *ptr, unsigned long n, > +

Re: [PATCH] ARM: oxnas: Change OX810SE default driver config

2016-06-28 Thread Baruch Siach
Hi Neil, On Tue, Jun 28, 2016 at 10:40:20AM +0200, Neil Armstrong wrote: > On 06/15/2016 12:45 PM, Neil Armstrong wrote: > > Since the SP804 timer changes will not been merged upstream, switch the > > default OX810SE config to the OXNAS RPS Timer driver configuration. > > > > Signed-off-by: Neil

Re: [PATCH V2 11/63] clocksource/drivers/digitcolor: Convert init function to return error

2016-06-16 Thread Baruch Siach
kernel/2246137. But anyway, for this and the final patch: Acked-by: Baruch Siach Thanks, baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}ooO--U--Ooo{= - bar...@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  1   2   3   >