[no subject]

[no subject]

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 01:28 PM, James Bottomley wrote: > On Wed, 2016-04-06 at 13:23 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 01:14 PM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 01:28 PM, James Bottomley wrote: > On Wed, 2016-04-06 at 13:23 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 01:14 PM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 01:14 PM, James Bottomley wrote: > On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 10:24 AM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 01:14 PM, James Bottomley wrote: > On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 10:24 AM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-

Re: [PATCH] btrfs:Change BUG_ON to new error path in __clear_extent_bit

On 2016-04-06 12:10 PM, Filipe Manana wrote: > On Wed, Apr 6, 2016 at 4:56 PM, Bastien Philbert > <bastienphilb...@gmail.com> wrote: >> This remove the unnessary BUG_ON if the allocation with >> alloc_extent_state_atomic fails due to this function >> failure not b

Re: [PATCH] btrfs:Change BUG_ON to new error path in __clear_extent_bit

On 2016-04-06 12:10 PM, Filipe Manana wrote: > On Wed, Apr 6, 2016 at 4:56 PM, Bastien Philbert > wrote: >> This remove the unnessary BUG_ON if the allocation with >> alloc_extent_state_atomic fails due to this function >> failure not being unrecoverable. Instead we n

[PATCH] btrfs:Change BUG_ON to new error path in __clear_extent_bit

the error code -ENOMEM to signal callers that the call to __clear_extent_bit failed due to a memory allocation failure. Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- fs/btrfs/extent_io.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.

[PATCH] btrfs:Change BUG_ON to new error path in __clear_extent_bit

the error code -ENOMEM to signal callers that the call to __clear_extent_bit failed due to a memory allocation failure. Signed-off-by: Bastien Philbert --- fs/btrfs/extent_io.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 10:24 AM, James Bottomley wrote: > On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 09:38 AM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-06

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 10:24 AM, James Bottomley wrote: > On Wed, 2016-04-06 at 10:11 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 09:38 AM, James Bottomley wrote: >>> On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: >>>> >>>> On 2016-04-06

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 09:38 AM, James Bottomley wrote: > On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 03:48 AM, Julian Calaby wrote: >>> Hi Bastien, >>> >>> On Wed, Apr 6, 2016 at 7:19 AM, Bastien Philbert >>> <basti

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 09:38 AM, James Bottomley wrote: > On Wed, 2016-04-06 at 09:21 -0400, Bastien Philbert wrote: >> >> On 2016-04-06 03:48 AM, Julian Calaby wrote: >>> Hi Bastien, >>> >>> On Wed, Apr 6, 2016 at 7:19 AM, Bastien Philbert >>> wrote

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 03:48 AM, Julian Calaby wrote: > Hi Bastien, > > On Wed, Apr 6, 2016 at 7:19 AM, Bastien Philbert > <bastienphilb...@gmail.com> wrote: >> This fixes backwards locking in the function __csio_unreg_rnode to >> properly lock before the call to

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

On 2016-04-06 03:48 AM, Julian Calaby wrote: > Hi Bastien, > > On Wed, Apr 6, 2016 at 7:19 AM, Bastien Philbert > wrote: >> This fixes backwards locking in the function __csio_unreg_rnode to >> properly lock before the call to the function csio_unreg

[PATCH] mpt3sas:Make sure mpt3sas adapter has been reset in scsih_resume

This fixes the issue in the function scih_resume that we assume that the mpt3sas adapter has been reset properly with a call to mpt3sas_base_hard_reset_handler by checking if this function call returns a error code and exit adpater resume prematurely Signed-off-by: Bastien Philbert <bastienph

[PATCH] mpt3sas:Make sure mpt3sas adapter has been reset in scsih_resume

This fixes the issue in the function scih_resume that we assume that the mpt3sas adapter has been reset properly with a call to mpt3sas_base_hard_reset_handler by checking if this function call returns a error code and exit adpater resume prematurely Signed-off-by: Bastien Philbert --- drivers

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 07:29 PM, David Miller wrote: > From: Daniel Borkmann <dan...@iogearbox.net> > Date: Tue, 05 Apr 2016 23:53:52 +0200 > >> On 04/05/2016 11:36 PM, Bastien Philbert wrote: >>> This fixes error handling for the switch statement case >>> SCTP

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 07:29 PM, David Miller wrote: > From: Daniel Borkmann > Date: Tue, 05 Apr 2016 23:53:52 +0200 > >> On 04/05/2016 11:36 PM, Bastien Philbert wrote: >>> This fixes error handling for the switch statement case >>> SCTP_CMD_SEND_PKT by m

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 06:12 PM, Marcelo Ricardo Leitner wrote: > On Tue, Apr 05, 2016 at 05:36:41PM -0400, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal t

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 06:12 PM, Marcelo Ricardo Leitner wrote: > On Tue, Apr 05, 2016 at 05:36:41PM -0400, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal t

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 05:53 PM, Daniel Borkmann wrote: > On 04/05/2016 11:36 PM, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal the variable error due to &

Re: [PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

On 2016-04-05 05:53 PM, Daniel Borkmann wrote: > On 04/05/2016 11:36 PM, Bastien Philbert wrote: >> This fixes error handling for the switch statement case >> SCTP_CMD_SEND_PKT by making the error value of the call >> to sctp_packet_transmit equal the variable error due to &

[PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

the no longer in use sctp packet even if the call to the function sctp_packet_transmit fails in order to avoid a memory leak here for not freeing the sctp Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] sctp: Fix error handling for switch statement case in the function sctp_cmd_interprete

the no longer in use sctp packet even if the call to the function sctp_packet_transmit fails in order to avoid a memory leak here for not freeing the sctp Signed-off-by: Bastien Philbert --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp

[PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply

in icmpv6_echo_reply as stated in the comments for locking requirements for the function, __in6_dev_get. Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- net/ipv6/icmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 0a37ddc..798434f 100644 --- a/ne

[PATCH] ipv6: icmp: Add protection from concurrent users in the function icmpv6_echo_reply

in icmpv6_echo_reply as stated in the comments for locking requirements for the function, __in6_dev_get. Signed-off-by: Bastien Philbert --- net/ipv6/icmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c index 0a37ddc..798434f 100644 --- a/net/ipv6/icmp.c +++ b/net/ipv6

[PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

the locking after the critical region function call to properly unlock instead with spin_unlock_irq on Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- drivers/scsi/csiostor/csio_rnode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/cs

[PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

the locking after the critical region function call to properly unlock instead with spin_unlock_irq on Signed-off-by: Bastien Philbert --- drivers/scsi/csiostor/csio_rnode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/csiostor/csio_rnode.c b/drivers/scsi

Re: [PATCH RFC] select_idle_sibling experiments

On 2016-04-05 04:03 PM, Matt Fleming wrote: > On Tue, 05 Apr, at 02:08:22PM, Chris Mason wrote: >> >> I started with a small-ish program to benchmark wakeup latencies. The >> basic idea is a bunch of worker threads who sit around and burn CPU. >> Every once and a while they send a message to a

Re: [PATCH RFC] select_idle_sibling experiments

On 2016-04-05 04:03 PM, Matt Fleming wrote: > On Tue, 05 Apr, at 02:08:22PM, Chris Mason wrote: >> >> I started with a small-ish program to benchmark wakeup latencies. The >> basic idea is a bunch of worker threads who sit around and burn CPU. >> Every once and a while they send a message to a

Re: [PATCH RFC] select_idle_sibling experiments

On Tue, Apr 5, 2016 at 2:08 PM, Chris Mason wrote: > Hi everyone, > > We're porting the fb kernel up to 4.5, and one of our last few out-of-tree > patches is a hack to try harder to find idle cpus when waking up tasks. > This helps in pretty much every workload we run, mostly because

Re: [PATCH RFC] select_idle_sibling experiments

On Tue, Apr 5, 2016 at 2:08 PM, Chris Mason wrote: > Hi everyone, > > We're porting the fb kernel up to 4.5, and one of our last few out-of-tree > patches is a hack to try harder to find idle cpus when waking up tasks. > This helps in pretty much every workload we run, mostly because they all >

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis <chad.dup...@qlogic.com> wrote: > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > >> This fixes the locking around the call to bnx2fc_alloc_id to comply >> with the comments about this particular function's definiti

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

On Tue, Apr 5, 2016 at 1:43 PM, Chad Dupuis wrote: > > > On Tue, 5 Apr 2016, Bastien Philbert wrote: > >> This fixes the locking around the call to bnx2fc_alloc_id to comply >> with the comments about this particular function's definition about >> requiring the nee

[PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- drivers/scsi/

[PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert --- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 6 +- 1 file

[PATCH] ipsec: Fix error handling in the function xfrm6_get_addr

structure pointer in use by this Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- net/ipv6/xfrm6_policy.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index c074771..759473e 100644 --- a/net/ipv6/xfrm6_po

[PATCH] ipsec: Fix error handling in the function xfrm6_get_addr

structure pointer in use by this Signed-off-by: Bastien Philbert --- net/ipv6/xfrm6_policy.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c index c074771..759473e 100644 --- a/net/ipv6/xfrm6_policy.c +++ b/net/ipv6/xfrm6_policy.c

[PATCH 2/2] gma500: Add new error checking for the function, psb_driver_load

to the function, psb_mmu_inset_pfn_sequence for the function, psb_driver_load. If a error code is returned we must jump to a new label, unlock_err in order to deallocate our usage count by one for the usage of the semaphore, sem before unloading Signed-off-by: Bastien Philbert <bastienphilb...@gmail.

[PATCH 2/2] gma500: Add new error checking for the function, psb_driver_load

to the function, psb_mmu_inset_pfn_sequence for the function, psb_driver_load. If a error code is returned we must jump to a new label, unlock_err in order to deallocate our usage count by one for the usage of the semaphore, sem before unloading Signed-off-by: Bastien Philbert --- drivers/gpu/drm/gma500

[PATCH 1/2] gma500: Add proper use of the variable ret for the function, psb_mmu_inset_pfn_sequence

-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- drivers/gpu/drm/gma500/mmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 0eaf11c..b832397 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/d

[PATCH 1/2] gma500: Add proper use of the variable ret for the function, psb_mmu_inset_pfn_sequence

-off-by: Bastien Philbert --- drivers/gpu/drm/gma500/mmu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c index 0eaf11c..b832397 100644 --- a/drivers/gpu/drm/gma500/mmu.c +++ b/drivers/gpu/drm/gma500/mmu.c

[PATCH] bluetooth: Fix locking issues in the function l2cap_connect_cfm

concurrent users or race conditions arising Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- net/bluetooth/l2cap_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index eb4f5f2..2ab103e 100644 --- a/net/blu

[PATCH] bluetooth: Fix locking issues in the function l2cap_connect_cfm

concurrent users or race conditions arising Signed-off-by: Bastien Philbert --- net/bluetooth/l2cap_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index eb4f5f2..2ab103e 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth

Re: [PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

On 2016-04-04 04:14 PM, David Miller wrote: > From: Bastien Philbert <bastienphilb...@gmail.com> > Date: Sun, 3 Apr 2016 19:04:26 -0400 > >> This fixes the incorrect variable assignment on error path in >> br_sysfs_addbr for when the call to kobject_create_and_add &

Re: [PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

On 2016-04-04 04:14 PM, David Miller wrote: > From: Bastien Philbert > Date: Sun, 3 Apr 2016 19:04:26 -0400 > >> This fixes the incorrect variable assignment on error path in >> br_sysfs_addbr for when the call to kobject_create_and_add >> fails to assign the value

[PATCH] ext4:Remove unneeded function definition and prototype for ext4_ext_calc_metadata_amount

-by: Bastien Philbert <bastienphilb...@gmail.com> --- fs/ext4/ext4.h| 2 -- fs/ext4/extents.c | 47 --- 2 files changed, 49 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index c047435..557cc35 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext

[PATCH] ext4:Remove unneeded function definition and prototype for ext4_ext_calc_metadata_amount

-by: Bastien Philbert --- fs/ext4/ext4.h| 2 -- fs/ext4/extents.c | 47 --- 2 files changed, 49 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index c047435..557cc35 100644 --- a/fs/ext4/ext4.h +++ b/fs/ext4/ext4.h @@ -3180,8 +3180,6

[PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

assignment being assigned zero when assigning it the successful return value of the call to sysfs_create_group which is zero. Signed-off-by: Bastien Philbert <bastienphilb...@gmail.com> --- net/bridge/br_sysfs_br.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bridge/br_sysfs_br.c

[PATCH] bridge:Fix incorrect variable assignment on error path in br_sysfs_addbr

assignment being assigned zero when assigning it the successful return value of the call to sysfs_create_group which is zero. Signed-off-by: Bastien Philbert --- net/bridge/br_sysfs_br.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index