Re: [PATCH v3 18/18] keyctl_pkey: Add pkey parameters saltlen and mgfhash for PSS

2021-04-20 Thread Ben Boeckel
eed in salt length of a PSS signature. > - 'mgfhash' to feed in the hash function used for MGF. > > Signed-off-by: Varad Gautam > CC: Jarkko Sakkinen > CC: Ben Boeckel > --- > v3: Rename slen to saltlen, update Documentation/security/keys/core.rst. > >

Re: [PATCH v2 18/18] keyctl_pkey: Add pkey parameters slen and mgfhash for PSS

2021-04-09 Thread Ben Boeckel
On Thu, Apr 08, 2021 at 16:15:16 +0200, Varad Gautam wrote: > keyctl pkey_* operations accept enc and hash parameters at present. > RSASSA-PSS signatures also require passing in the signature salt > length and the mgf hash function. > > Add parameters: > - 'slen' to feed in salt length of a PSS

Re: [PATCH 5/9] security: keys: trusted: Allow storage of PCR values in creation data

2021-02-21 Thread Ben Boeckel
On Sat, Feb 20, 2021 at 05:09:07 +0200, Jarkko Sakkinen wrote: > Something popped into mind: could we make PCR 23 reservation dynamic > instead of a config option. > > E.g. if the user space uses it, then it's dirty and hibernate will > fail. I really dislike the static compilation time firewall

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-13 Thread Ben Boeckel
On Wed, Jan 13, 2021 at 10:57:58 -0500, Ben Boeckel wrote: > > Cc: sta...@vger.kernel.org # 5.6.x > > Note that keyutils is not in the kernel, so I don't know how useful this > is. Scratch that; I remember a similar patch for keyutils; this is for the kernel. --Ben

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-13 Thread Ben Boeckel
On Wed, Jan 13, 2021 at 13:49:12 +0100, Rolf Eike Beer wrote: > Otherwise build fails if the headers are not in the default location. While at > it also ask pkg-config for the libs, with fallback to the existing value. > > Signed-off-by: Rolf Eike Beer Reviewed-by: Ben Boeckel

Re: [PATCH 00/18] keys: Miscellaneous fixes

2020-12-09 Thread Ben Boeckel
://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-fixes 1-16 LGTM (modulo the typo in patch 7's commit message). 17 and 18 are outside my knowledge right now. Reviewed-by: Ben Boeckel --Ben

Re: [PATCH 07/18] KEYS: remove redundant memset

2020-12-09 Thread Ben Boeckel
On Wed, Dec 09, 2020 at 12:15:19 +, David Howells wrote: > From: Tom Rix > > Reviewing use of memset in keyctrl_pkey.c Typo: `keyctl_pkey.c` --Ben

Re: [RESEND PATCH] KEYS: asymmetric: Fix kerneldoc

2020-10-29 Thread Ben Boeckel
_keys/asymmetric_type.c:160: warning: Excess function > parameter 'kid_2' description in 'asymmetric_key_id_same' > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Randy Dunlap Reviewed-by: Ben Boeckel --Ben

Re: [RFC PATCH 2/2] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification

2020-10-20 Thread Ben Boeckel
On Tue, Oct 20, 2020 at 14:50:01 +0800, Lee, Chun-Yi wrote: > +config CHECK_CODESIGN_EKU > + bool "Check codeSigning extended key usage" > + depends on PKCS7_MESSAGE_PARSER=y > + depends on SYSTEM_DATA_VERIFICATION > + help > + This option provides support for checking the

Re: [PATCH 1/2] Add a manpage for watch_queue(7)

2020-08-24 Thread Ben Boeckel
On Mon, Aug 24, 2020 at 16:27:32 +0100, David Howells wrote: > Ben Boeckel wrote: > > > > +In the case of message loss, > > > +.BR read (2) > > > +will fabricate a loss message and pass that to userspace immediately > > > after the > > > +poi

Re: [PATCH 1/2] Add a manpage for watch_queue(7)

2020-08-07 Thread Ben Boeckel
On Fri, Aug 07, 2020 at 16:06:16 +0100, David Howells wrote: > Add a manual page for the notifications/watch_queue facility. > > Signed-off-by: David Howells > --- > > man7/watch_queue.7 | 285 > > 1 file changed, 285 insertions(+) >

Re: [PATCH] dns: Apply a default TTL to records obtained from getaddrinfo()

2020-05-19 Thread Ben Boeckel
s! Looks good to me. Reviewed-by: Ben Boeckel --Ben

Re: [PATCH] dns: Apply a default TTL to records obtained from getaddrinfo()

2020-05-19 Thread Ben Boeckel
On Tue, May 19, 2020 at 14:39:40 +0100, David Howells wrote: > Ben Boeckel wrote: > > Is there precedent for this config file format? > > Okay, I can change it to: > > default_ttl = > > and strip spaces all over the place. Thanks. This is at least a subset

Re: [PATCH] dns: Apply a default TTL to records obtained from getaddrinfo()

2020-05-18 Thread Ben Boeckel
On Mon, May 18, 2020 at 15:22:45 +0100, David Howells wrote: > Address records obtained from getaddrinfo() don't come with any TTL > information, even if they're obtained from the DNS, with the result that > key.dns_resolver upcall program doesn't set an expiry time on dns_resolver > records

[PATCH 1/1] Documentation: security: core.rst: add missing argument

2020-05-15 Thread Ben Boeckel
From: Ben Boeckel This argument was just never documented in the first place. Signed-off-by: Ben Boeckel --- Documentation/security/keys/core.rst | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/security/keys/core.rst b/Documentation/security/keys

[PATCH 0/1] Document keyctl(KEYCTL_PKEY_QUERY) arguments correctly

2020-05-15 Thread Ben Boeckel
From: Ben Boeckel This is the way the code parses the arguments and libkeyutils calls the syscall. Note on the email split: I'm still in the process of migrating emails for various usages hence the email From mismatch here (I've migrated my list subscription, but not my general contribution

Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

2019-08-13 Thread Ben Boeckel
quot;, options_NOENCRYPT, > strlen(options_NOENCRYPT), KEY_SPEC_THREAD_KEYRING); Thanks. Looks good to me. Reviewed-by: Ben Boeckel --Ben

Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-13 Thread Ben Boeckel
On Mon, Aug 05, 2019 at 13:31:02 -0700, Alison Schofield wrote: > It's not currently checked, but should be. > I'll add it as shown above. > Thanks for the review, Thanks. Seeing how this works elsewhere now, feel free to add my review with the proposed check to the new patch. Reviewe

Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-05 Thread Ben Boeckel
On Wed, Jul 31, 2019 at 18:07:39 +0300, Kirill A. Shutemov wrote: > From: Alison Schofield > +/* Make sure arguments are correct for the TYPE of key requested */ > +static int mktme_check_options(u32 *payload, unsigned long token_mask, > +enum mktme_type type, enum

Re: [PATCHv2 57/59] x86/mktme: Document the MKTME Key Service API

2019-08-05 Thread Ben Boeckel
On Wed, Jul 31, 2019 at 18:08:11 +0300, Kirill A. Shutemov wrote: > + key = add_key("mktme", "name", "no-encrypt", strlen(options_CPU), > + KEY_SPEC_THREAD_KEYRING); Should this be `type=no-encrypt` here? Also, seems like copy/paste from the `type=cpu` case for the `strlen`