Re: [RFC] freeing unlinked file indefinitely delayed

2015-07-13 Thread Ben Myers
Hey Al, On Mon, Jul 13, 2015 at 08:56:46PM +0100, Al Viro wrote: > On Mon, Jul 13, 2015 at 01:17:51PM -0500, Ben Myers wrote: > > > For one thing, this patch does *not* check for i_nlink at all. > > > > I agree that no checking of i_nlink has the advantage of brevity.

Re: [RFC] freeing unlinked file indefinitely delayed

2015-07-13 Thread Ben Myers
Hey Al, On Sun, Jul 12, 2015 at 04:00:35PM +0100, Al Viro wrote: > On Wed, Jul 08, 2015 at 10:41:43AM -0500, Ben Myers wrote: > > > The bug rings a bell for me so I will stick my neck out instead of > > lurking. Don't you need to sample that link count under the filesystems

Re: [RFC] freeing unlinked file indefinitely delayed

2015-07-13 Thread Ben Myers
Hey Al, On Sun, Jul 12, 2015 at 04:00:35PM +0100, Al Viro wrote: On Wed, Jul 08, 2015 at 10:41:43AM -0500, Ben Myers wrote: The bug rings a bell for me so I will stick my neck out instead of lurking. Don't you need to sample that link count under the filesystems internal lock in order

Re: [RFC] freeing unlinked file indefinitely delayed

2015-07-13 Thread Ben Myers
Hey Al, On Mon, Jul 13, 2015 at 08:56:46PM +0100, Al Viro wrote: On Mon, Jul 13, 2015 at 01:17:51PM -0500, Ben Myers wrote: For one thing, this patch does *not* check for i_nlink at all. I agree that no checking of i_nlink has the advantage of brevity. Anyone who is using

Re: [RFC] freeing unliked file indefinitely delayed

2015-07-08 Thread Ben Myers
Hey Al, On Wed, Jul 08, 2015 at 02:42:38AM +0100, Al Viro wrote: > Normally opening a file, unlinking it and then closing will have > the inode freed upon close() (provided that it's not otherwise busy and > has no remaining links, of course). However, there's one case where that > does

Re: [RFC] freeing unliked file indefinitely delayed

2015-07-08 Thread Ben Myers
Hey Al, On Wed, Jul 08, 2015 at 02:42:38AM +0100, Al Viro wrote: Normally opening a file, unlinking it and then closing will have the inode freed upon close() (provided that it's not otherwise busy and has no remaining links, of course). However, there's one case where that does *not*

Re: [GIT PULL] XFS fix for 3.14-rc2

2014-02-06 Thread Ben Myers
On Thu, Feb 06, 2014 at 01:34:53PM -0800, Linus Torvalds wrote: > I have no idea why you keep re-sending this. > > It got merged a week ago. See commit f1499382f114. Ok, there it is. Sorry for the noise. Thanks, Ben > On Thu, Feb 6, 2014 at 9:31 AM, Ben Myers wrote:

[GIT PULL] XFS fix for 3.14-rc2

2014-02-06 Thread Ben Myers
Hi Linus, Please pull this xfs update for 3.14. This is to allow logical sector sized direct io on advanced format disks. Eric expressed a desire to get this fix in 3.14 because this bug affects some virtualization packages. Thanks, Ben The following changes since commit

[GIT PULL] XFS fix for 3.14-rc2

2014-02-06 Thread Ben Myers
Hi Linus, Please pull this xfs update for 3.14. This is to allow logical sector sized direct io on advanced format disks. Eric expressed a desire to get this fix in 3.14 because this bug affects some virtualization packages. Thanks, Ben The following changes since commit

Re: [GIT PULL] XFS fix for 3.14-rc2

2014-02-06 Thread Ben Myers
On Thu, Feb 06, 2014 at 01:34:53PM -0800, Linus Torvalds wrote: I have no idea why you keep re-sending this. It got merged a week ago. See commit f1499382f114. Ok, there it is. Sorry for the noise. Thanks, Ben On Thu, Feb 6, 2014 at 9:31 AM, Ben Myers b...@sgi.com wrote: Hi

Re: [GIT PULL] XFS update #2 for 3.14-rc1

2014-02-03 Thread Ben Myers
Hey Linus, On Tue, Jan 28, 2014 at 07:12:09PM -0600, Ben Myers wrote: >Please pull this xfs update for 3.14. This is to allow logical sector > sized >direct io on advanced format disks. Could you pick this up for -rc2? Thanks, Ben > The following changes

Re: [GIT PULL] XFS update #2 for 3.14-rc1

2014-02-03 Thread Ben Myers
Hey Linus, On Tue, Jan 28, 2014 at 07:12:09PM -0600, Ben Myers wrote: Please pull this xfs update for 3.14. This is to allow logical sector sized direct io on advanced format disks. Could you pick this up for -rc2? Thanks, Ben The following changes since commit

[GIT PULL] XFS update #2 for 3.14-rc1

2014-01-28 Thread Ben Myers
Hi Linus, Please pull this xfs update for 3.14. This is to allow logical sector sized direct io on advanced format disks. Thanks, Ben The following changes since commit bf3964c188d686424ff7b69a45941851b9f437f0: Merge branch 'xfs-extent-list-locking-fixes' into for-next

[GIT PULL] XFS update #2 for 3.14-rc1

2014-01-28 Thread Ben Myers
Hi Linus, Please pull this xfs update for 3.14. This is to allow logical sector sized direct io on advanced format disks. Thanks, Ben The following changes since commit bf3964c188d686424ff7b69a45941851b9f437f0: Merge branch 'xfs-extent-list-locking-fixes' into for-next

[GIT PULL] XFS updates for 3.14-rc1

2014-01-22 Thread Ben Myers
- introduce a common helper to calculate the number of filesystem blocks in an inode cluster - fixes for extent list locking - fix for off-by-one in xfs_attr3_rmt_verify - fix for missing destroy_work_on_stack in xfs_bmapi_allocate Ben

[GIT PULL] XFS updates for 3.14-rc1

2014-01-22 Thread Ben Myers
- introduce a common helper to calculate the number of filesystem blocks in an inode cluster - fixes for extent list locking - fix for off-by-one in xfs_attr3_rmt_verify - fix for missing destroy_work_on_stack in xfs_bmapi_allocate Ben

[GIT PULL] XFS bugfixes for 3.13-rc8

2014-01-10 Thread Ben Myers
Hi Linus, Please pull these fixes for XFS. Here we have a bugfix for an off-by-one in the remote attribute verifier that results in a forced shutdown which you can hit with v5 superblock by creating a 64k xattr, and a fix for a missing destroy_work_on_stack() in the allocation worker. It's a

Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission()

2014-01-10 Thread Ben Myers
Christoph, On Fri, Jan 10, 2014 at 01:31:48AM -0800, Christoph Hellwig wrote: > On Fri, Jan 10, 2014 at 12:06:42AM +, Al Viro wrote: > > Check what XFS is doing ;-/ That's where those call_rcu() have come from. > > Sure, we can separate the simple "just do call_rcu(...->free_inode)" case > >

Re: [PATCH] vfs: Fix possible NULL pointer dereference in inode_permission()

2014-01-10 Thread Ben Myers
Christoph, On Fri, Jan 10, 2014 at 01:31:48AM -0800, Christoph Hellwig wrote: On Fri, Jan 10, 2014 at 12:06:42AM +, Al Viro wrote: Check what XFS is doing ;-/ That's where those call_rcu() have come from. Sure, we can separate the simple just do call_rcu(...-free_inode) case and hit

[GIT PULL] XFS bugfixes for 3.13-rc8

2014-01-10 Thread Ben Myers
Hi Linus, Please pull these fixes for XFS. Here we have a bugfix for an off-by-one in the remote attribute verifier that results in a forced shutdown which you can hit with v5 superblock by creating a 64k xattr, and a fix for a missing destroy_work_on_stack() in the allocation worker. It's a

Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()

2014-01-07 Thread Ben Myers
+ destroy_work_on_stack(>work); > > return args->result; > > } > > Thanks for your patch and it work fine for my testing. I missed this in an > old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Looks good to me too. Reviewed-by: Ben

Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK()

2014-01-07 Thread Ben Myers
missed this in an old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Looks good to me too. Reviewed-by: Ben Myers b...@sgi.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

[GIT PULL] XFS bugfixes for 3.13-rc5

2013-12-19 Thread Ben Myers
Hi Linus, Please pull these fixes for XFS. This contains fixes for some asserts related to project quotas, a memory leak, a hang when disabling group or project quotas before disabling user quotas, Dave's email address, several fixes for the alignment of file allocation to stripe

[GIT PULL] XFS bugfixes for 3.13-rc5

2013-12-19 Thread Ben Myers
Hi Linus, Please pull these fixes for XFS. This contains fixes for some asserts related to project quotas, a memory leak, a hang when disabling group or project quotas before disabling user quotas, Dave's email address, several fixes for the alignment of file allocation to stripe

[GIT PULL] XFS bugfixes for 3.13-rc4

2013-12-10 Thread Ben Myers
Hi Linus, Please pull these bugfixes for xfs. There is a security fix for memory corruption in xfs_attrlist_by_handle, a fix for trim, and a fix for buffer overrun in the agfl when growing filesystems with a v4 superblock. Thanks, Ben The following changes since commit

Re: XFS security fix never sent to -stable?

2013-12-10 Thread Ben Myers
Hi, On Tue, Dec 10, 2013 at 08:31:23AM -0600, Eric Sandeen wrote: > On 12/10/13, 7:15 AM, Josh Boyer wrote: > > On Tue, Dec 10, 2013 at 2:56 AM, Greg KH wrote: > >> On Tue, Dec 10, 2013 at 10:55:23AM +1100, Dave Chinner wrote: > >>> [cc xfs list, cc sta...@vger.kernel.org] > >>> > >>> On Mon,

[GIT PULL] XFS bugfixes for 3.13-rc4

2013-12-10 Thread Ben Myers
Hi Linus, Please pull these bugfixes for xfs. There is a security fix for memory corruption in xfs_attrlist_by_handle, a fix for trim, and a fix for buffer overrun in the agfl when growing filesystems with a v4 superblock. Thanks, Ben The following changes since commit

Re: XFS security fix never sent to -stable?

2013-12-10 Thread Ben Myers
Hi, On Tue, Dec 10, 2013 at 08:31:23AM -0600, Eric Sandeen wrote: On 12/10/13, 7:15 AM, Josh Boyer wrote: On Tue, Dec 10, 2013 at 2:56 AM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Dec 10, 2013 at 10:55:23AM +1100, Dave Chinner wrote: [cc xfs list, cc sta...@vger.kernel.org] On

Re: [PATCH] update xfs maintainers

2013-11-14 Thread Ben Myers
On Thu, Nov 14, 2013 at 05:22:26PM +1100, Dave Chinner wrote: > On Fri, Nov 08, 2013 at 04:03:10PM -0600, Ben Myers wrote: > > From: Ben Myers > > > > xfs: update maintainers > > > > Add Dave as maintainer of XFS. > > > > Signed-off-by: Ben Mye

Re: [PATCH] update xfs maintainers

2013-11-14 Thread Ben Myers
On Thu, Nov 14, 2013 at 05:22:26PM +1100, Dave Chinner wrote: On Fri, Nov 08, 2013 at 04:03:10PM -0600, Ben Myers wrote: From: Ben Myers b...@sgi.com xfs: update maintainers Add Dave as maintainer of XFS. Signed-off-by: Ben Myers b...@sgi.com --- MAINTAINERS |2 +- 1

[GIT PULL] XFS update for 3.13-rc1

2013-11-13 Thread Ben Myers
definition - remove invalid assert in xfs_inode_free - fix for AIL lock regression Ben Myers (1): xfs: remove usage of is_bad_inode Brian Foster (4): xfs: push down inactive transaction mgmt for remote symlinks xfs

[GIT PULL] XFS update for 3.13-rc1

2013-11-13 Thread Ben Myers
definition - remove invalid assert in xfs_inode_free - fix for AIL lock regression Ben Myers (1): xfs: remove usage of is_bad_inode Brian Foster (4): xfs: push down inactive transaction mgmt for remote symlinks xfs

Re: XFS leadership and a new co-maintainer candidate

2013-11-12 Thread Ben Myers
Hey, On Tue, Nov 12, 2013 at 09:32:53AM -0800, Christoph Hellwig wrote: > On Fri, Nov 08, 2013 at 02:46:06PM -0600, Ben Myers wrote: > > That really didn't happen Christoph. It's not in my tree or in a pull > > request. > > I'll take my back room complain back th

Re: XFS leadership and a new co-maintainer candidate

2013-11-12 Thread Ben Myers
Hey, On Tue, Nov 12, 2013 at 09:32:53AM -0800, Christoph Hellwig wrote: On Fri, Nov 08, 2013 at 02:46:06PM -0600, Ben Myers wrote: That really didn't happen Christoph. It's not in my tree or in a pull request. I'll take my back room complain back then, but I still think

Re: [PATCH] update xfs maintainers

2013-11-10 Thread Ben Myers
Hey Dave, On Mon, Nov 11, 2013 at 10:12:41AM +1100, Dave Chinner wrote: > On Sat, Nov 09, 2013 at 06:30:49PM -0600, Ben Myers wrote: > > On Sat, Nov 09, 2013 at 05:51:30PM -0600, Ben Myers wrote: > > > On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: > > > &g

Re: [PATCH] update xfs maintainers

2013-11-10 Thread Ben Myers
Hey Dave, On Mon, Nov 11, 2013 at 10:12:41AM +1100, Dave Chinner wrote: On Sat, Nov 09, 2013 at 06:30:49PM -0600, Ben Myers wrote: On Sat, Nov 09, 2013 at 05:51:30PM -0600, Ben Myers wrote: On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: On Sat, 9 Nov 2013 06:59:00 +0800 Zhi

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
Dave, On Sat, Nov 09, 2013 at 05:51:30PM -0600, Ben Myers wrote: > Hey Neil, > > On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: > > On Sat, 9 Nov 2013 06:59:00 +0800 Zhi Yong Wu wrote: > > > > > On Sat, Nov 9, 2013 at 6:03 AM, Ben

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
Hey Neil, On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: > On Sat, 9 Nov 2013 06:59:00 +0800 Zhi Yong Wu wrote: > > > On Sat, Nov 9, 2013 at 6:03 AM, Ben Myers wrote: > > > Hey Ric, > > > > > > On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wh

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
On Fri, Nov 08, 2013 at 06:32:33PM -0500, Ric Wheeler wrote: > On 11/08/2013 05:17 PM, Ben Myers wrote: > >Hey Ric, > > > >On Fri, Nov 08, 2013 at 05:07:45PM -0500, Ric Wheeler wrote: > >>On 11/08/2013 05:03 PM, Ben Myers wrote: > >>>Hey Ric, > >

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
On Fri, Nov 08, 2013 at 06:32:33PM -0500, Ric Wheeler wrote: On 11/08/2013 05:17 PM, Ben Myers wrote: Hey Ric, On Fri, Nov 08, 2013 at 05:07:45PM -0500, Ric Wheeler wrote: On 11/08/2013 05:03 PM, Ben Myers wrote: Hey Ric, On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
Hey Neil, On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: On Sat, 9 Nov 2013 06:59:00 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: On Sat, Nov 9, 2013 at 6:03 AM, Ben Myers b...@sgi.com wrote: Hey Ric, On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote: On 11

Re: [PATCH] update xfs maintainers

2013-11-09 Thread Ben Myers
Dave, On Sat, Nov 09, 2013 at 05:51:30PM -0600, Ben Myers wrote: Hey Neil, On Sat, Nov 09, 2013 at 10:44:24AM +1100, NeilBrown wrote: On Sat, 9 Nov 2013 06:59:00 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: On Sat, Nov 9, 2013 at 6:03 AM, Ben Myers b...@sgi.com wrote: Hey Ric

Re: [PATCH] update xfs maintainers

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 05:07:45PM -0500, Ric Wheeler wrote: > On 11/08/2013 05:03 PM, Ben Myers wrote: > >Hey Ric, > > > >On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote: > >>On 11/08/2013 03:46 PM, Ben Myers wrote: > >>>Hey Christ

[PATCH] update xfs maintainers

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote: > On 11/08/2013 03:46 PM, Ben Myers wrote: > >Hey Christoph, > > > >On Fri, Nov 08, 2013 at 11:34:24AM -0800, Christoph Hellwig wrote: > >>On Fri, Nov 08, 2013 at 12:03:37PM -0600, Ben Myers wrot

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Christoph, On Fri, Nov 08, 2013 at 11:34:24AM -0800, Christoph Hellwig wrote: > On Fri, Nov 08, 2013 at 12:03:37PM -0600, Ben Myers wrote: > > Mark is replacing Alex as my backup because Alex is really busy at > > Linaro and asked to be taken off awhile ago. The holiday seaso

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 01:09:32PM -0500, Ric Wheeler wrote: > On 11/08/2013 01:03 PM, Ben Myers wrote: > >Hey Ric, > > > >On Fri, Nov 08, 2013 at 06:03:41AM -0500, Ric Wheeler wrote: > >>In the XFS community, we have 2 clear leaders in terms of > >&

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 06:03:41AM -0500, Ric Wheeler wrote: > In the XFS community, we have 2 clear leaders in terms of > contributions of significant feaures and depth of knowledge - > Christoph and Dave. > > If you look at the number of patches submitted by developers since > 3.0 who

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 06:03:41AM -0500, Ric Wheeler wrote: In the XFS community, we have 2 clear leaders in terms of contributions of significant feaures and depth of knowledge - Christoph and Dave. If you look at the number of patches submitted by developers since 3.0 who have

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 01:09:32PM -0500, Ric Wheeler wrote: On 11/08/2013 01:03 PM, Ben Myers wrote: Hey Ric, On Fri, Nov 08, 2013 at 06:03:41AM -0500, Ric Wheeler wrote: In the XFS community, we have 2 clear leaders in terms of contributions of significant feaures and depth

Re: XFS leadership and a new co-maintainer candidate

2013-11-08 Thread Ben Myers
Hey Christoph, On Fri, Nov 08, 2013 at 11:34:24AM -0800, Christoph Hellwig wrote: On Fri, Nov 08, 2013 at 12:03:37PM -0600, Ben Myers wrote: Mark is replacing Alex as my backup because Alex is really busy at Linaro and asked to be taken off awhile ago. The holiday season is coming up

[PATCH] update xfs maintainers

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote: On 11/08/2013 03:46 PM, Ben Myers wrote: Hey Christoph, On Fri, Nov 08, 2013 at 11:34:24AM -0800, Christoph Hellwig wrote: On Fri, Nov 08, 2013 at 12:03:37PM -0600, Ben Myers wrote: Mark is replacing Alex as my backup

Re: [PATCH] update xfs maintainers

2013-11-08 Thread Ben Myers
Hey Ric, On Fri, Nov 08, 2013 at 05:07:45PM -0500, Ric Wheeler wrote: On 11/08/2013 05:03 PM, Ben Myers wrote: Hey Ric, On Fri, Nov 08, 2013 at 03:50:21PM -0500, Ric Wheeler wrote: On 11/08/2013 03:46 PM, Ben Myers wrote: Hey Christoph, On Fri, Nov 08, 2013 at 11:34:24AM -0800

Re: [PATCH V2] xfs: simplify kmem_{zone_}zalloc

2013-11-06 Thread Ben Myers
On Mon, Nov 04, 2013 at 06:21:05PM +0800, Gu Zheng wrote: > Introduce flag KM_ZERO which is used to alloc zeroed entry, and convert > kmem_{zone_}zalloc to call kmem_{zone_}alloc() with KM_ZERO directly, > in order to avoid the setting to zero step. > And following Dave's suggestion, make

Re: [PATCH V2] xfs: simplify kmem_{zone_}zalloc

2013-11-06 Thread Ben Myers
On Mon, Nov 04, 2013 at 06:21:05PM +0800, Gu Zheng wrote: Introduce flag KM_ZERO which is used to alloc zeroed entry, and convert kmem_{zone_}zalloc to call kmem_{zone_}alloc() with KM_ZERO directly, in order to avoid the setting to zero step. And following Dave's suggestion, make

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-31 Thread Ben Myers
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote: > On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote: > > ASSERT on args takes place after args dereference. > > This assertion is redundant since we are going to panic anyway. > > > > Found by Linux

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-31 Thread Ben Myers
Hey Geyslan, On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote: > On 10/23/13 3:34 PM, Ben Myers wrote: > > > xfs: fix possible NULL dereference in xlog_verify_iclog > > > > In xlog_verify_iclog a debug check of the incore log buffers prints an &g

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-31 Thread Ben Myers
Hey Geyslan, On Wed, Oct 30, 2013 at 03:08:12PM -0500, Eric Sandeen wrote: On 10/23/13 3:34 PM, Ben Myers wrote: xfs: fix possible NULL dereference in xlog_verify_iclog In xlog_verify_iclog a debug check of the incore log buffers prints an error if icptr is null and then goes

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-31 Thread Ben Myers
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote: On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote: ASSERT on args takes place after args dereference. This assertion is redundant since we are going to panic anyway. Found by Linux Driver Verification project

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-25 Thread Ben Myers
> > Signed-off-by: Denis Efremov Looks good. Reviewed-by: Ben Myers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-25 Thread Ben Myers
Efremov yefremov.de...@gmail.com Looks good. Reviewed-by: Ben Myers b...@sgi.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-23 Thread Ben Myers
egardless. Convert this to an assert so that the intention is clear. This was reported by Coverty. Reported-by: Geyslan G. Bem Signed-off-by: Ben Myers --- fs/xfs/xfs_log.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index:

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-23 Thread Ben Myers
that the intention is clear. This was reported by Coverty. Reported-by: Geyslan G. Bem geys...@gmail.com Signed-off-by: Ben Myers b...@sgi.com --- fs/xfs/xfs_log.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index: b/fs/xfs/xfs_log.c

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-22 Thread Ben Myers
13 3:39 PM, Dave Chinner wrote: > > >>> On Tue, Oct 22, 2013 at 08:12:51AM -0200, Geyslan Gregório Bem wrote: > > >>>> 2013/10/21 Dave Chinner : > > >>>>> On Mon, Oct 21, 2013 at 07:00:59PM -0500, Eric Sandeen wrote: > > >>>>

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-22 Thread Ben Myers
, Oct 22, 2013 at 08:12:51AM -0200, Geyslan Gregório Bem wrote: 2013/10/21 Dave Chinner da...@fromorbit.com: On Mon, Oct 21, 2013 at 07:00:59PM -0500, Eric Sandeen wrote: On 10/21/13 6:56 PM, Dave Chinner wrote: On Mon, Oct 21, 2013 at 06:18:49PM -0500, Ben Myers wrote: Yes

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-21 Thread Ben Myers
Hey, On Mon, Oct 21, 2013 at 06:12:18PM -0500, Eric Sandeen wrote: > On 10/21/13 5:44 PM, Dave Chinner wrote: > > On Mon, Oct 21, 2013 at 03:58:23PM -0500, Eric Sandeen wrote: > >> On 10/21/13 1:32 PM, Geyslan G. Bem wrote: > >>> This patch puts a 'break' in the true branch, avoiding the > >>>

Re: [PATCH] xfs: fix possible NULL dereference

2013-10-21 Thread Ben Myers
Hey, On Mon, Oct 21, 2013 at 06:12:18PM -0500, Eric Sandeen wrote: On 10/21/13 5:44 PM, Dave Chinner wrote: On Mon, Oct 21, 2013 at 03:58:23PM -0500, Eric Sandeen wrote: On 10/21/13 1:32 PM, Geyslan G. Bem wrote: This patch puts a 'break' in the true branch, avoiding the 'icptr-ic_next'

[GIT PULL] XFS fixes for 3.12-rc4

2013-10-04 Thread Ben Myers
Hi Linus, Please pull in these bugfixes for xfs. There are lockdep annotations for project quotas, a fix for dirent dtype support on v4 filesystems, a fix for a memory leak in recovery, and a fix for the build error that resulted from it. D'oh. Thanks, Ben The following

[GIT PULL] XFS fixes for 3.12-rc4

2013-10-04 Thread Ben Myers
Hi Linus, Please pull in these bugfixes for xfs. There are lockdep annotations for project quotas, a fix for dirent dtype support on v4 filesystems, a fix for a memory leak in recovery, and a fix for the build error that resulted from it. D'oh. Thanks, Ben The following

Re: [PATCH] xfs: Use kmem_free() instead of free()

2013-10-01 Thread Ben Myers
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote: > On 10/01/13 09:47, Thierry Reding wrote: > >This fixes a build failure caused by calling the free() function which > >does not exist in the Linux kernel. > > > >Signed-off-by: Thierry Reding > >--- > > fs/xfs/xfs_log_recover.c | 2

Re: [PATCH] xfs: Use kmem_free() instead of free()

2013-10-01 Thread Ben Myers
On Tue, Oct 01, 2013 at 10:00:43AM -0500, Mark Tinguely wrote: On 10/01/13 09:47, Thierry Reding wrote: This fixes a build failure caused by calling the free() function which does not exist in the Linux kernel. Signed-off-by: Thierry Redingtred...@nvidia.com --- fs/xfs/xfs_log_recover.c

[GIT PULL] XFS fixes for 3.12-rc3

2013-09-28 Thread Ben Myers
Hi Linus, Please pull these bugfixes for xfs. There is a fix for an assert caused by a spurious directory block collapse, a fix for recovery of a block over stale metadata from a previous mkfs, a cleanup for the eofblocks ioctl, and fixes for locking issues in

[GIT PULL] XFS fixes for 3.12-rc3

2013-09-28 Thread Ben Myers
Hi Linus, Please pull these bugfixes for xfs. There is a fix for an assert caused by a spurious directory block collapse, a fix for recovery of a block over stale metadata from a previous mkfs, a cleanup for the eofblocks ioctl, and fixes for locking issues in

Re: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Variables Uninitialized

2013-09-27 Thread Ben Myers
Hi Geyslan, On Fri, Sep 27, 2013 at 02:59:12PM -0300, Geyslan Gregório Bem wrote: > Hi Maintainers, > > I suppose the variables "highstale" and "lowstale" are being used despite > not having been initialized. > > File: fs/xfs/xfs_dir2_node.c > Function: xfs_dir2_leafn_add > > L491: > > /* > >

Re: [XFS MAINTAINERS] fs/xfs/xfs_dir2_node.c: xfs: xfs_dir2_leafn_add: Variables Uninitialized

2013-09-27 Thread Ben Myers
Hi Geyslan, On Fri, Sep 27, 2013 at 02:59:12PM -0300, Geyslan Gregório Bem wrote: Hi Maintainers, I suppose the variables highstale and lowstale are being used despite not having been initialized. File: fs/xfs/xfs_dir2_node.c Function: xfs_dir2_leafn_add L491: /* * Insert the new

[GIT PULL] XFS updates #2 for 3.12-rc1

2013-09-12 Thread Ben Myers
Hi Linus, Please pull these XFS updates for 3.12-rc1. There is a feature to support defrag on CRC enabled filesystems, some bugfixes, and cleanups. Thanks, Ben The following changes since commit 1d03c6fa88af35e55047a1f2ab116f0fdf2f55aa: xfs: XFS_MOUNT_QUOTA_ALL needed by

[GIT PULL] XFS updates #2 for 3.12-rc1

2013-09-12 Thread Ben Myers
Hi Linus, Please pull these XFS updates for 3.12-rc1. There is a feature to support defrag on CRC enabled filesystems, some bugfixes, and cleanups. Thanks, Ben The following changes since commit 1d03c6fa88af35e55047a1f2ab116f0fdf2f55aa: xfs: XFS_MOUNT_QUOTA_ALL needed by

[GIT PULL] XFS updates for 3.12-rc1

2013-09-09 Thread Ben Myers
Hi Linus, Please pull these XFS updates for 3.12-rc1. Most of this is related to the libxfs kernel/userspace sync, there is also project quota work, performance work in the log, recovery, and the CIL. User namespace support has been added, directory entries now have file type

[GIT PULL] XFS updates for 3.12-rc1

2013-09-09 Thread Ben Myers
Hi Linus, Please pull these XFS updates for 3.12-rc1. Most of this is related to the libxfs kernel/userspace sync, there is also project quota work, performance work in the log, recovery, and the CIL. User namespace support has been added, directory entries now have file type

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-26 Thread Ben Myers
Hey Dan, On Mon, Aug 26, 2013 at 05:37:15PM +0300, Dan Carpenter wrote: > On Fri, Aug 23, 2013 at 12:36:13PM -0500, Ben Myers wrote: > > Dan, > > > > On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: > > > On Thu, Aug 15, 2013 at 09:37:06AM -0500, Be

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-26 Thread Ben Myers
Hey Dan, On Mon, Aug 26, 2013 at 05:37:15PM +0300, Dan Carpenter wrote: On Fri, Aug 23, 2013 at 12:36:13PM -0500, Ben Myers wrote: Dan, On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: Hey Dan Jeff

Re: [PATCH v4] xfs: introduce object readahead to log recovery

2013-08-23 Thread Ben Myers
0m0.001s 0m0.001s > sys: 0m0.246s 0m0.107s > > Signed-off-by: Zhi Yong Wu Looks good. Reviewed-by: Ben Myers Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-23 Thread Ben Myers
Dan, On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: > On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: > > Hey Dan & Jeff, > > > > On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: > > > On 08/15/2013 01:53 PM, Dan Carpenter

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-23 Thread Ben Myers
Dan, On Fri, Aug 16, 2013 at 08:26:50AM +1000, Dave Chinner wrote: On Thu, Aug 15, 2013 at 09:37:06AM -0500, Ben Myers wrote: Hey Dan Jeff, On Thu, Aug 15, 2013 at 06:10:43PM +0800, Jeff Liu wrote: On 08/15/2013 01:53 PM, Dan Carpenter wrote: The di_size variable comes from

Re: [PATCH v4] xfs: introduce object readahead to log recovery

2013-08-23 Thread Ben Myers
: 0m0.246s 0m0.107s Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Looks good. Reviewed-by: Ben Myers b...@sgi.com Applied. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] xfs: Register hotcpu notifier after initialization

2013-08-22 Thread Ben Myers
On Mon, Aug 19, 2013 at 05:21:29PM -0500, Ben Myers wrote: > On Mon, Aug 19, 2013 at 10:56:44PM +0200, Richard Weinberger wrote: > > Currently the code initializizes mp->m_icsb_mutex and other things > > _after_ register_hotcpu_notifier(). > > As the notifier takes mp->

Re: [PATCH] xfs: Register hotcpu notifier after initialization

2013-08-22 Thread Ben Myers
On Mon, Aug 19, 2013 at 05:21:29PM -0500, Ben Myers wrote: On Mon, Aug 19, 2013 at 10:56:44PM +0200, Richard Weinberger wrote: Currently the code initializizes mp-m_icsb_mutex and other things _after_ register_hotcpu_notifier(). As the notifier takes mp-m_icsb_mutex it can happen

Re: [PATCH] powerpc/spufs: convert userns uid/gid mount options to kuid/kgid

2013-08-21 Thread Ben Myers
On Wed, Aug 21, 2013 at 10:05:27PM +0200, Arnd Bergmann wrote: > On Wednesday 21 August 2013, Dwight Engen wrote: > > > > Acked-by: Jeremy Kerr > > Tested-by: Jeremy Kerr > > Signed-off-by: Dwight Engen > > Reviewed-by: Arnd Bergmann Applied. Thanks, -Ben -- To unsubscribe from

Re: linux-next: build failure after merge of the final tree

2013-08-21 Thread Ben Myers
Hey Dwight, On Wed, Aug 21, 2013 at 02:30:04PM +0800, Jeremy Kerr wrote: > > Yes, I agree. The other filesystems that take an Opt_uid as well do use > > current_user_ns() and not init_user_ns. They also do a uid_valid() > > check and fail the mount (or fallback to GLOBAL_ROOT_UID). So I think > >

Re: linux-next: build failure after merge of the final tree

2013-08-21 Thread Ben Myers
Hey Stephen, On Wed, Aug 21, 2013 at 10:22:46AM +1000, Stephen Rothwell wrote: > On Tue, 20 Aug 2013 14:28:44 -0500 Ben Myers wrote: > > I'd prefer not to break Stephen's tree two days in a row. We could just > > revert > > d6970d4b726c in the xfs tree for the time bein

Re: linux-next: build failure after merge of the final tree

2013-08-21 Thread Ben Myers
Hey Stephen, On Wed, Aug 21, 2013 at 10:22:46AM +1000, Stephen Rothwell wrote: On Tue, 20 Aug 2013 14:28:44 -0500 Ben Myers b...@sgi.com wrote: I'd prefer not to break Stephen's tree two days in a row. We could just revert d6970d4b726c in the xfs tree for the time being as Stephen has

Re: linux-next: build failure after merge of the final tree

2013-08-21 Thread Ben Myers
Hey Dwight, On Wed, Aug 21, 2013 at 02:30:04PM +0800, Jeremy Kerr wrote: Yes, I agree. The other filesystems that take an Opt_uid as well do use current_user_ns() and not init_user_ns. They also do a uid_valid() check and fail the mount (or fallback to GLOBAL_ROOT_UID). So I think that

Re: [PATCH] powerpc/spufs: convert userns uid/gid mount options to kuid/kgid

2013-08-21 Thread Ben Myers
On Wed, Aug 21, 2013 at 10:05:27PM +0200, Arnd Bergmann wrote: On Wednesday 21 August 2013, Dwight Engen wrote: Acked-by: Jeremy Kerr j...@ozlabs.org Tested-by: Jeremy Kerr j...@ozlabs.org Signed-off-by: Dwight Engen dwight.en...@oracle.com Reviewed-by: Arnd Bergmann a...@arndb.de

Re: linux-next: build failure after merge of the final tree

2013-08-20 Thread Ben Myers
Hi Jeremy, Apologies for breaking your build... On Tue, Aug 20, 2013 at 12:07:02PM -0400, Dwight Engen wrote: > On Tue, 20 Aug 2013 17:20:52 +1000 > Stephen Rothwell wrote: > > After merging the final tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > >

Re: linux-next: build failure after merge of the final tree

2013-08-20 Thread Ben Myers
Hi Jeremy, Apologies for breaking your build... On Tue, Aug 20, 2013 at 12:07:02PM -0400, Dwight Engen wrote: On Tue, 20 Aug 2013 17:20:52 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: After merging the final tree, today's linux-next build (powerpc allyesconfig) failed like this:

Re: [PATCH] xfs: Register hotcpu notifier after initialization

2013-08-19 Thread Ben Myers
n. > > Signed-off-by: Richard Weinberger Looks good. Thanks Richard. Reviewed-by: Ben Myers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH] xfs: Register hotcpu notifier after initialization

2013-08-19 Thread Ben Myers
-by: Richard Weinberger rich...@nod.at Looks good. Thanks Richard. Reviewed-by: Ben Myers b...@sgi.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Ben Myers
od to me. In this case I'd say the forced shutdown is more appropriate than an assert, because here we're reading the inode from disk, as opposed to looking at a structure that is already incore which we think we've initialized. We want to handle unexpected inputs from disk without crashing even if

Re: [patch] xfs: check for underflow in xfs_iformat_fork()

2013-08-15 Thread Ben Myers
that is already incore which we think we've initialized. We want to handle unexpected inputs from disk without crashing even if we are CONFIG_XFS_DEBUG. How did you come across this one? Reviewed-by: Ben Myers b...@sgi.com Regards, Ben -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/3] xfs: Implement FALLOC_FL_COLLAPSE_RANGE

2013-07-31 Thread Ben Myers
Hey Namjae, On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote: > From: Namjae Jeon > > New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS. > > Signed-off-by: Namjae Jeon > Signed-off-by: Ashish Sangwan Very cool feature! ;) I have a couple initial

Re: [PATCH v2] xfs: introduce object readahead to log recovery

2013-07-31 Thread Ben Myers
Hey Zhi, On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote: > On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner wrote: > > On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote: > >> From: Zhi Yong Wu > >> > >> It can take a long time to run log recovery operation because

  1   2   3   >