the
click button in some area of the touchpad.
Fixes 7f81c8db5489
Link: https://bugzilla.kernel.org/show_bug.cgi?id=200899
Cc: sta...@vger.kernel.org # v4.18+
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-multitouch.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletion
Now that the application is simply stored in struct hid_input, we can
overwrite it in mt_input_mapping() for the faulty egalax and have a
simpler suffix processing in mt_input_configured()
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-multitouch.c | 72
Benjamin Tissoires (4):
HID: multitouch: fix Elan panels with 2 input modes declaration
HID: input: do not append a suffix if the name already has it
HID: core: fix grouping by application
HID: multitouch: simplify the application retrieval
drivers/hid/hid-input.c | 18 ++---
drivers
Benjamin Tissoires (4):
HID: multitouch: fix Elan panels with 2 input modes declaration
HID: input: do not append a suffix if the name already has it
HID: core: fix grouping by application
HID: multitouch: simplify the application retrieval
drivers/hid/hid-input.c | 18 ++---
drivers
On Fri, Aug 31, 2018 at 11:36 AM Benjamin Tissoires
wrote:
>
> This partially reverts commit f07b3c1da92db108662f99417a212fc1eddc44d1.
>
> It looks like some mice are not correctly treated by
> HID_QUIRK_INPUT_PER_APP. Those mice have the following
> report descript
On Fri, Aug 31, 2018 at 11:36 AM Benjamin Tissoires
wrote:
>
> This partially reverts commit f07b3c1da92db108662f99417a212fc1eddc44d1.
>
> It looks like some mice are not correctly treated by
> HID_QUIRK_INPUT_PER_APP. Those mice have the following
> report descript
ailto:linux-input-
> >ow...@vger.kernel.org] On Behalf Of Benjamin Tissoires
> >Sent: Friday, August 31, 2018 2:36 AM
> >To: Jiri Kosina ; Dmitry Torokhov
> >
> >Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; Benjamin
> >Tissoires ; sta...@vger.kernel.or
ailto:linux-input-
> >ow...@vger.kernel.org] On Behalf Of Benjamin Tissoires
> >Sent: Friday, August 31, 2018 2:36 AM
> >To: Jiri Kosina ; Dmitry Torokhov
> >
> >Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; Benjamin
> >Tissoires ; sta...@vger.kernel.or
On Fri, Aug 31, 2018 at 12:04 PM Hans de Goede wrote:
>
> Hi,
>
> On 31-08-18 11:54, Benjamin Tissoires wrote:
> > The spec states that the HID devices should allow
> > the host to query the HID descriptor at any time.
> >
> > Some devices require the HI
On Fri, Aug 31, 2018 at 12:04 PM Hans de Goede wrote:
>
> Hi,
>
> On 31-08-18 11:54, Benjamin Tissoires wrote:
> > The spec states that the HID devices should allow
> > the host to query the HID descriptor at any time.
> >
> > Some devices require the HI
ink: https://bugzilla.kernel.org/show_bug.cgi?id=106231
Signed-off-by: Benjamin Tissoires
Signed-off-by: Stephen Just
---
changes in v2:
- moved to drivers/acpi/ instead of power
- use uuid_le
- fix uper/lower case
- print_hex_dump() used in mshw0011_dump_registers() instead of custom dump
ink: https://bugzilla.kernel.org/show_bug.cgi?id=106231
Signed-off-by: Benjamin Tissoires
Signed-off-by: Stephen Just
---
changes in v2:
- moved to drivers/acpi/ instead of power
- use uuid_le
- fix uper/lower case
- print_hex_dump() used in mshw0011_dump_registers() instead of custom dump
now we can hope to upstream this
driver.
On Fri, Jun 30, 2017 at 6:37 PM Andy Shevchenko
wrote:
>
> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires
> wrote:
> > On Jun 29 2017 or thereabouts, Andy Shevchenko wrote:
> >> On Thu, Jun 29, 2017 at 3:10 PM, Benjam
now we can hope to upstream this
driver.
On Fri, Jun 30, 2017 at 6:37 PM Andy Shevchenko
wrote:
>
> On Fri, Jun 30, 2017 at 6:57 PM, Benjamin Tissoires
> wrote:
> > On Jun 29 2017 or thereabouts, Andy Shevchenko wrote:
> >> On Thu, Jun 29, 2017 at 3:10 PM, Benjam
remove this list.
Tested on a Dell XPS 9360 and a Surface 3.
link: https://bugzilla.redhat.com/show_bug.cgi?id=1622695
Signed-off-by: Benjamin Tissoires
---
drivers/hid/i2c-hid/i2c-hid.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c
remove this list.
Tested on a Dell XPS 9360 and a Surface 3.
link: https://bugzilla.redhat.com/show_bug.cgi?id=1622695
Signed-off-by: Benjamin Tissoires
---
drivers/hid/i2c-hid/i2c-hid.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c
/NixOS/nixpkgs/issues/45165
Cc: sta...@vger.kernel.org # v4.18+
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-generic.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/hid/hid-generic.c b/drivers/hid/hid-generic.c
index 3b6eccbc2519..c25b4718de44 100644
/NixOS/nixpkgs/issues/45165
Cc: sta...@vger.kernel.org # v4.18+
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-generic.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/hid/hid-generic.c b/drivers/hid/hid-generic.c
index 3b6eccbc2519..c25b4718de44 100644
On Thu, Aug 30, 2018 at 9:12 AM Mylène Josserand
wrote:
>
> Hello Dmitry,
>
> On Mon, 13 Aug 2018 08:36:32 -0700
> Dmitry Torokhov wrote:
>
> > Hi Mylène,
> >
> > On Mon, Aug 13, 2018 at 8:24 AM Mylène Josserand
> > wrote:
> > >
> > > Hi Dmitry,
> > >
> > > On Tue, 24 Jul 2018 10:40:53 -0700
>
On Thu, Aug 30, 2018 at 9:12 AM Mylène Josserand
wrote:
>
> Hello Dmitry,
>
> On Mon, 13 Aug 2018 08:36:32 -0700
> Dmitry Torokhov wrote:
>
> > Hi Mylène,
> >
> > On Mon, Aug 13, 2018 at 8:24 AM Mylène Josserand
> > wrote:
> > >
> > > Hi Dmitry,
> > >
> > > On Tue, 24 Jul 2018 10:40:53 -0700
>
Hi Harry,
On Thu, Aug 30, 2018 at 1:06 AM Harry Cutts wrote:
>
> Hi Benjamin,
>
> On Tue, 28 Aug 2018 at 01:47, Benjamin Tissoires
> wrote:
> > On Thu, Aug 23, 2018 at 8:31 PM Harry Cutts wrote:
> > > [snip]
> > > @@ -400,32 +409,53 @@ static
Hi Harry,
On Thu, Aug 30, 2018 at 1:06 AM Harry Cutts wrote:
>
> Hi Benjamin,
>
> On Tue, 28 Aug 2018 at 01:47, Benjamin Tissoires
> wrote:
> > On Thu, Aug 23, 2018 at 8:31 PM Harry Cutts wrote:
> > > [snip]
> > > @@ -400,32 +409,53 @@ static
On Tue, Aug 28, 2018 at 1:46 PM Jiri Kosina wrote:
>
> On Tue, 21 Aug 2018, AceLan Kao wrote:
>
> > The incomplete report flooded after S3 and touchscreen becomes
> > malfunctioned.
> > [ 1367.646244] i2c_hid i2c-CUST:00: i2c_hid_get_input: incomplete
> > report (58/18785)
> > [ 1367.649471]
On Tue, Aug 28, 2018 at 1:46 PM Jiri Kosina wrote:
>
> On Tue, 21 Aug 2018, AceLan Kao wrote:
>
> > The incomplete report flooded after S3 and touchscreen becomes
> > malfunctioned.
> > [ 1367.646244] i2c_hid i2c-CUST:00: i2c_hid_get_input: incomplete
> > report (58/18785)
> > [ 1367.649471]
Hi Harry,
On Thu, Aug 23, 2018 at 8:31 PM Harry Cutts wrote:
>
> There are three features used by various Logitech mice for
> high-resolution scrolling: the fast scrolling bit in HID++ 1.0, and the
> x2120 and x2121 features in HID++ 2.0 and above. This patch supports
> all three, and uses the
Hi Harry,
On Thu, Aug 23, 2018 at 8:31 PM Harry Cutts wrote:
>
> There are three features used by various Logitech mice for
> high-resolution scrolling: the fast scrolling bit in HID++ 1.0, and the
> x2120 and x2121 features in HID++ 2.0 and above. This patch supports
> all three, and uses the
Hi Sean,
On Tue, Aug 28, 2018 at 3:29 AM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 0265 (Magic Trackpad 2)
> Bluetooth device
> Vendor 004c (Apple)
> Device 0265 (Magic Trackpad 2)
>
> Add support for Apple Magic Trackpad 2 over USB and
Hi Sean,
On Tue, Aug 28, 2018 at 3:29 AM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 0265 (Magic Trackpad 2)
> Bluetooth device
> Vendor 004c (Apple)
> Device 0265 (Magic Trackpad 2)
>
> Add support for Apple Magic Trackpad 2 over USB and
y: Sean O'Brien
> ---
Looks good now.
Reviewed-by: Benjamin Tissoires
However, now that I read it, I believe the quirk APPLE_HAS_FN could be
autodetected or at least renamed to something better (or inverted to
not have 80% of the devices that need it). Anyway, that's for someone
who will wa
y: Sean O'Brien
> ---
Looks good now.
Reviewed-by: Benjamin Tissoires
However, now that I read it, I believe the quirk APPLE_HAS_FN could be
autodetected or at least renamed to something better (or inverted to
not have 80% of the devices that need it). Anyway, that's for someone
who will wa
On Fri, Aug 24, 2018 at 5:45 PM Dmitry Torokhov
wrote:
>
> Hi Benjamin, Jiri,
>
> On Tue, Apr 24, 2018 at 1:04 AM Benjamin Tissoires
> wrote:
> >
> > It is not a good idea to try to fit all types of applications in the
> > same input report. There are
On Fri, Aug 24, 2018 at 5:45 PM Dmitry Torokhov
wrote:
>
> Hi Benjamin, Jiri,
>
> On Tue, Apr 24, 2018 at 1:04 AM Benjamin Tissoires
> wrote:
> >
> > It is not a good idea to try to fit all types of applications in the
> > same input report. There are
_get_input: incomplete report
> (58/56059)
>
> Adding device ID, 04F3:30CC, to the quirk to re-send report description
> after resume.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: AceLan Kao
Looks good:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> drive
_get_input: incomplete report
> (58/56059)
>
> Adding device ID, 04F3:30CC, to the quirk to re-send report description
> after resume.
>
> Cc: sta...@vger.kernel.org
> Signed-off-by: AceLan Kao
Looks good:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> drive
Hi Sean,
On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 026c (Magic Keyboard with Numeric Keypad)
>
> Bluetooth devices
> Vendor 004c (Apple)
> Device 0267 (Magic Keyboard)
> Device 026c (Magic Keyboard
Hi Sean,
On Thu, Aug 23, 2018 at 6:40 PM Sean O'Brien wrote:
>
> USB device
> Vendor 05ac (Apple)
> Device 026c (Magic Keyboard with Numeric Keypad)
>
> Bluetooth devices
> Vendor 004c (Apple)
> Device 0267 (Magic Keyboard)
> Device 026c (Magic Keyboard
t; Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: linux-in...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Pierre-Loup A. Griffais
> Signed-off-by: Juha Kuikka
> Signed-off-by: Andrey Smirnov
> ---
> drivers/hid/Kconfig | 8 ++
> drivers/hid/hid
t; Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: linux-in...@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Pierre-Loup A. Griffais
> Signed-off-by: Juha Kuikka
> Signed-off-by: Andrey Smirnov
> ---
> drivers/hid/Kconfig | 8 ++
> drivers/hid/hid
On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov
wrote:
>
> On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote:
> > From: Nick Dyer
> >
> > input_mt_report_slot_state() ignores the tool when the slot is closed.
> > Remove the tool type from these function calls, which has caused a bit of
On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov
wrote:
>
> On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote:
> > From: Nick Dyer
> >
> > input_mt_report_slot_state() ignores the tool when the slot is closed.
> > Remove the tool type from these function calls, which has caused a bit of
> Signed-off-by: Srinivas Pandruvada
> ---
> v2
> Replaced pci_get_device with pci_dev_present to check in a loop as
> suggested by Benjamin.
That's even better than what I suggested :)
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
>
> drivers/hid/intel-ish-hid/ipc/pci-ish.c
> Signed-off-by: Srinivas Pandruvada
> ---
> v2
> Replaced pci_get_device with pci_dev_present to check in a loop as
> suggested by Benjamin.
That's even better than what I suggested :)
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
>
> drivers/hid/intel-ish-hid/ipc/pci-ish.c
On Tue, Jul 17, 2018 at 10:06 PM Srinivas Pandruvada
wrote:
>
> On Mehlow Xeon-E workstation, ISH PCI device is enabled but without ISH
> firmware. Here the ISH device PCI device id was reused for some non Linux
> storage drivers. So this was not done for enabling ISH. But this has a
>
On Tue, Jul 17, 2018 at 10:06 PM Srinivas Pandruvada
wrote:
>
> On Mehlow Xeon-E workstation, ISH PCI device is enabled but without ISH
> firmware. Here the ISH device PCI device id was reused for some non Linux
> storage drivers. So this was not done for enabling ISH. But this has a
>
const is a magic keyword here :)
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-multitouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers
const is a magic keyword here :)
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-multitouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers
Now that the driver can handle more than one multitouch collection in
a single HID device, ditch the last bit that contains us to use only
one mt collection.
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid
Now that the driver can handle more than one multitouch collection in
a single HID device, ditch the last bit that contains us to use only
one mt collection.
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid
-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2:
- manually declare ABS_MT_TOOL_TYPE and set its min/max to MT_TOOL_DIAL
to explain which tool it will set
---
drivers/hid/hid-input.c | 3 +++
drivers/hid/hid-multitouch.c | 48
-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2:
- manually declare ABS_MT_TOOL_TYPE and set its min/max to MT_TOOL_DIAL
to explain which tool it will set
---
drivers/hid/hid-input.c | 3 +++
drivers/hid/hid-multitouch.c | 48
and POWER Key, not sure how one can trigger
those events though.
Filtering the ABS_X and ABS_Y axes also prevents udev to detect this as
a touchscreen.
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-microsoft.c
hid_parser
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-core.c | 17 ++---
include/linux/hid.h| 9 +
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hid
-guidelines/touchpad-windows-precision-touchpad-collection
Signed-off-by: Dmitry Torokhov
[splitted and rebased]
Signed-off-by: Benjamin Tissoires
---
changes in v4:
- dropped the touch major/minor modifications for palm events
no changes in v3
changes in v2:
- dropped the delayed release in ca
the release event in a separate frame.
frame
Acked-by: Peter Hutterer
Signed-off-by: Dmitry Torokhov
[rebased and new commit message]
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2 (compared to Dmitry's initial submission):
- extracted from the initial submission
field in a slot, we then use this data to emit
the input data
A more streamlined way is to first get all of the address in the report
of all fields, and then just pick the fields we are interested in in
mt_report()
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes
-by: Dmitry Torokhov
[rebased]
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2 (compared to Dmitry's initial submission)
---
drivers/hid/hid-multitouch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers
and POWER Key, not sure how one can trigger
those events though.
Filtering the ABS_X and ABS_Y axes also prevents udev to detect this as
a touchscreen.
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-microsoft.c
hid_parser
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-core.c | 17 ++---
include/linux/hid.h| 9 +
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/hid/hid
-guidelines/touchpad-windows-precision-touchpad-collection
Signed-off-by: Dmitry Torokhov
[splitted and rebased]
Signed-off-by: Benjamin Tissoires
---
changes in v4:
- dropped the touch major/minor modifications for palm events
no changes in v3
changes in v2:
- dropped the delayed release in ca
the release event in a separate frame.
frame
Acked-by: Peter Hutterer
Signed-off-by: Dmitry Torokhov
[rebased and new commit message]
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2 (compared to Dmitry's initial submission):
- extracted from the initial submission
field in a slot, we then use this data to emit
the input data
A more streamlined way is to first get all of the address in the report
of all fields, and then just pick the fields we are interested in in
mt_report()
Acked-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes
-by: Dmitry Torokhov
[rebased]
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2 (compared to Dmitry's initial submission)
---
drivers/hid/hid-multitouch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers
-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2:
- changed the url of hid-tools
---
drivers/hid/hid-multitouch.c | 380 ++-
1 file changed, 230 insertions(+), 150 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid
-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
changes in v2:
- changed the url of hid-tools
---
drivers/hid/hid-multitouch.c | 380 ++-
1 file changed, 230 insertions(+), 150 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid
Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-multitouch.c | 64 ++--
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid
Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v4
no changes in v3
no changes in v2
---
drivers/hid/hid-multitouch.c | 64 ++--
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid
give some extra space to account for other types of fingers if we need
(MT_TOOL_THUMB)
Slightly change the documentation to not make it mandatory to update each
MT_TOOL we add.
Reviewed-by: Peter Hutterer
Acked-by: Dmitry Torokhov
Signed-off-by: Benjamin Tissoires
---
changes in v4:
- re
Hi,
this is the v4 of my hid-multitouch rewrite series.
Changes are:
- added Peter's rev-by / acked-by
- changed MT_TOOL_MAX value to be 0x0f
- dropped the touch major/minor modifications
Cheers,
Benjamin
Benjamin Tissoires (12):
input: add MT_TOOL_DIAL
HID: multitouch: make sure
give some extra space to account for other types of fingers if we need
(MT_TOOL_THUMB)
Slightly change the documentation to not make it mandatory to update each
MT_TOOL we add.
Reviewed-by: Peter Hutterer
Acked-by: Dmitry Torokhov
Signed-off-by: Benjamin Tissoires
---
changes in v4:
- re
Hi,
this is the v4 of my hid-multitouch rewrite series.
Changes are:
- added Peter's rev-by / acked-by
- changed MT_TOOL_MAX value to be 0x0f
- dropped the touch major/minor modifications
Cheers,
Benjamin
Benjamin Tissoires (12):
input: add MT_TOOL_DIAL
HID: multitouch: make sure
Hi,
On Mon, Jun 25, 2018 at 9:51 AM, Benjamin Tissoires
wrote:
> If a device gets removed right after having registered a power_supply node,
> we might enter in a deadlock between the remove call (that has a lock on
> the parent device) and the deferred register work.
>
> All
Hi,
On Mon, Jun 25, 2018 at 9:51 AM, Benjamin Tissoires
wrote:
> If a device gets removed right after having registered a power_supply node,
> we might enter in a deadlock between the remove call (that has a lock on
> the parent device) and the deferred register work.
>
> All
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> Elide lone `else` cases and replace `else if` clauses
> with plain `if` conditionals when they occur immediately
> after return statements.
>
> Signed-off-by: Joey Pabalinas
>
This one looks good.
Reviewed-by: Benjamin Ti
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> Elide lone `else` cases and replace `else if` clauses
> with plain `if` conditionals when they occur immediately
> after return statements.
>
> Signed-off-by: Joey Pabalinas
>
This one looks good.
Reviewed-by: Benjamin Ti
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial
> protocol, so avoid setting `td->serial_maybe = true;` in order to avoid
> an unnecessary mt_post_parse_default_settings() call
>
> Signed-off-by: Joey Pabalinas
>
>
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial
> protocol, so avoid setting `td->serial_maybe = true;` in order to avoid
> an unnecessary mt_post_parse_default_settings() call
>
> Signed-off-by: Joey Pabalinas
>
>
Hi Joey,
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> Avoid processing reports containing invalid values to reduce
> multitouch input stutter.
>
> Signed-off-by: Joey Pabalinas
>
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c
Hi Joey,
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> Avoid processing reports containing invalid values to reduce
> multitouch input stutter.
>
> Signed-off-by: Joey Pabalinas
>
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> The firmware found in the touch screen of the Surface Pro 3 is slightly
> buggy and occasionally doesn't send lift off reports for contacts; add
> MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed
> reports.
>
>
On Sun, Jul 1, 2018 at 2:19 AM, Joey Pabalinas wrote:
> The firmware found in the touch screen of the Surface Pro 3 is slightly
> buggy and occasionally doesn't send lift off reports for contacts; add
> MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed
> reports.
>
>
On Tue, Jul 3, 2018 at 1:59 AM, Daniel Rosenberg wrote:
> If our length is greater than the size of the buffer, we
> overflow the buffer
>
> Signed-off-by: Daniel Rosenberg
> Cc: sta...@vger.kernel.org
> ---
Looks good:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
On Tue, Jul 3, 2018 at 1:59 AM, Daniel Rosenberg wrote:
> If our length is greater than the size of the buffer, we
> overflow the buffer
>
> Signed-off-by: Daniel Rosenberg
> Cc: sta...@vger.kernel.org
> ---
Looks good:
Reviewed-by: Benjamin Tissoires
Cheers,
Benjamin
[16072.109359] R13: 010b8560 R14: 7ffc422ae2e0 R15:
Reported-and-tested-by: Richard Hughes
Tested-by: Aaron Skomra
Signed-off-by: Benjamin Tissoires
---
drivers/power/supply/power_supply_core.c | 11 +--
include/linux/power_supply.h |
[16072.109359] R13: 010b8560 R14: 7ffc422ae2e0 R15:
Reported-and-tested-by: Richard Hughes
Tested-by: Aaron Skomra
Signed-off-by: Benjamin Tissoires
---
drivers/power/supply/power_supply_core.c | 11 +--
include/linux/power_supply.h |
mory.
>
> Cc: Benjamin Tissoires
> Cc: Hans de Goede
> Cc: Andy Shevchenko
> Cc: Dmitry Torokhov
> Cc: Doug Anderson
> Signed-off-by: Stephen Boyd
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff
mory.
>
> Cc: Benjamin Tissoires
> Cc: Hans de Goede
> Cc: Andy Shevchenko
> Cc: Dmitry Torokhov
> Cc: Doug Anderson
> Signed-off-by: Stephen Boyd
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff
This is a small v3 of my previous series.
I dropped the first patch as requested by Dmitry and added his acked-by
in the new 1/12.
Cheers,
Benjamin
Benjamin Tissoires (12):
input: add MT_TOOL_DIAL
HID: multitouch: make sure the static list of class is not changed
HID: multitouch: Store
This is a small v3 of my previous series.
I dropped the first patch as requested by Dmitry and added his acked-by
in the new 1/12.
Cheers,
Benjamin
Benjamin Tissoires (12):
input: add MT_TOOL_DIAL
HID: multitouch: make sure the static list of class is not changed
HID: multitouch: Store
const is a magic keyword here :)
Signed-off-by: Benjamin Tissoires
---
no changes in v2
no changes in v3
---
drivers/hid/hid-multitouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 45968f7970f8
const is a magic keyword here :)
Signed-off-by: Benjamin Tissoires
---
no changes in v2
no changes in v3
---
drivers/hid/hid-multitouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 45968f7970f8
give some extra space to account for other types of fingers if we need
(MT_TOOL_THUMB)
Slightly change the documentation to not make it mandatory to update each
MT_TOOL we add.
Acked-by: Dmitry Torokhov
Signed-off-by: Benjamin Tissoires
---
new in v2 (extracted from previous series in its own
give some extra space to account for other types of fingers if we need
(MT_TOOL_THUMB)
Slightly change the documentation to not make it mandatory to update each
MT_TOOL we add.
Acked-by: Dmitry Torokhov
Signed-off-by: Benjamin Tissoires
---
new in v2 (extracted from previous series in its own
Currently, hid-multitouch can only handle one multitouch collection at
a time. This is an issue for the Dell Canvas, as the Totem (a dial tool)
is also using a multitouch-like collection.
Factor out the multitouch collection data in their own struct.
Signed-off-by: Benjamin Tissoires
Currently, hid-multitouch can only handle one multitouch collection at
a time. This is an issue for the Dell Canvas, as the Totem (a dial tool)
is also using a multitouch-like collection.
Factor out the multitouch collection data in their own struct.
Signed-off-by: Benjamin Tissoires
touch
inputs.
We set INPUT_PROP_DIRECT which applies ID_INPUT_TOUCHSCREEN to this new
type of devices, but we will counter this for the time being with the
special udev hwdb entry mentioned above.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1511846
Signed-off-by: Benjamin Tissoires
touch
inputs.
We set INPUT_PROP_DIRECT which applies ID_INPUT_TOUCHSCREEN to this new
type of devices, but we will counter this for the time being with the
special udev hwdb entry mentioned above.
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1511846
Signed-off-by: Benjamin Tissoires
Now that the driver can handle more than one multitouch collection in
a single HID device, ditch the last bit that contains us to use only
one mt collection.
Signed-off-by: Benjamin Tissoires
---
no changes in v2
no changes in v3
---
drivers/hid/hid-multitouch.c | 126
Now that the driver can handle more than one multitouch collection in
a single HID device, ditch the last bit that contains us to use only
one mt collection.
Signed-off-by: Benjamin Tissoires
---
no changes in v2
no changes in v3
---
drivers/hid/hid-multitouch.c | 126
the release event in a separate frame.
frame
Signed-off-by: Dmitry Torokhov
[rebased and new commit message]
Signed-off-by: Benjamin Tissoires
---
changes in v2 (compared to Dmitry's initial submission):
- extracted from the initial submission in a separate patch
- rebased on top of my current series
and POWER Key, not sure how one can trigger
those events though.
Filtering the ABS_X and ABS_Y axes also prevents udev to detect this as
a touchscreen.
Signed-off-by: Benjamin Tissoires
---
no changes in v2
no changes in v3
---
drivers/hid/hid-microsoft.c | 49
401 - 500 of 4109 matches
Mail list logo
