Re: [alsa-devel] [PATCH v4] ASoC: tlv320aic3x: Add support for high power analog output

2019-05-11 Thread Benoît Thébaudeau
quot;Mono Playback Switch", MONOLOPM_CTRL, 3, 0x01, 0), > + SOC_SINGLE_TLV("Mono Playback Volume", MONOLOPM_CTRL, 4, 9, 0, > + out_tlv), > + > }; > > /* > -- > 2.17.1 > > ___ > Alsa-devel mailing list > alsa-de...@alsa-project.org > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel Reviewed-by: Benoît Thébaudeau Best regards, Benoît

Re: [alsa-devel] [PATCH v3] ASoC: tlv320aic3x: Add support for high power analog output

2019-05-02 Thread Benoît Thébaudeau
Dear Saravanan Sekar, On Thu, May 2, 2019 at 8:14 PM Saravanan Sekar wrote: > > Add support to output level control for the analog high power output > drivers HPOUT and HPCOM. > > Signed-off-by: Saravanan Sekar > --- > > Notes: > Changes in V3: > -Fixed compilation error > > Changes

[PATCH v3 2/2] ARM: dts: imx25-pinfunc: Always set SION for eSDHC CMD

2018-01-31 Thread Benoît Thébaudeau
all boards. This had already been done for eSDHC1, but not for eSDHC2. Also, define MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered from now on. Cc: Uwe Kleine-König Signed-off-by: Benoît Thébaudeau Reviewed-by: Fabio Estevam --- Changes v2 -> v3: - Quickly mention S

[PATCH v3 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC

2018-01-31 Thread Benoît Thébaudeau
, - keeps definitions using the legacy naming in order not to break compatibility for out-of-tree users (they can be removed later), - updates the in-tree files that were using the legacy naming. Cc: Uwe Kleine-König Signed-off-by: Benoît Thébaudeau Acked-by: Uwe Kleine-König --- Changes v2

[PATCH v2 2/2] ARM: dts: imx25-pinfunc: Always set SION for eSDHC CMD

2018-01-30 Thread Benoît Thébaudeau
all boards. This had already been done for eSDHC1, but not for eSDHC2. Also, define MX25_PAD_FEC_MDC__ESDHC2_CMD so that all the possible cases are covered from now on. Cc: Uwe Kleine-König Signed-off-by: Benoît Thébaudeau Reviewed-by: Fabio Estevam --- Changes v1 -> v2: - Update eS

[PATCH v2 1/2] ARM: dts: imx25-pinfunc: Use consistent naming for eSDHC

2018-01-30 Thread Benoît Thébaudeau
, - keeps definitions using the legacy naming in order not to break compatibility for out-of-tree users (they can be removed later), - updates the in-tree files that were using the legacy naming. Cc: Uwe Kleine-König Signed-off-by: Benoît Thébaudeau --- Changes v1 -> v2: - New pa

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-27 Thread Benoît Thébaudeau
On Sat, Jan 27, 2018 at 4:37 PM, Uwe Kleine-König wrote: > On Sat, Jan 27, 2018 at 01:07:52AM +0100, Benoît Thébaudeau wrote: >> The eSDHC does not work properly if the SION bit is not set for the >> bidirectional CMD signal, whatever the eSDHC instance and the selected >> pa

[PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-26 Thread Benoît Thébaudeau
boards. This had already been done for eSDHC1, but not for eSDHC2. Also, define MX25_PAD_FEC_MDC__SDHC2_CMD so that all the possible cases are covered from now on. Signed-off-by: Benoît Thébaudeau --- arch/arm/boot/dts/imx25-pinfunc.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions

[PATCH] mmc: sdhci-esdhc-imx: Fix i.MX53 eSDHCv3 clock

2018-01-14 Thread Benoît Thébaudeau
LOCK_COUNT command, card status 0x900 Signed-off-by: Benoît Thébaudeau Reported-by: Wladimir J. van der Laan Tested-by: Wladimir J. van der Laan --- drivers/mmc/host/sdhci-esdhc-imx.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/driver

Re: [alsa-devel] [PATCH 2/9] ASoC: tlv320aic3x: Fix typo in DT binding documentation

2017-11-09 Thread Benoît Thébaudeau
Dear Andrew F. Davis, On Wed, Nov 8, 2017 at 10:24 PM, Andrew F. Davis wrote: > The property used to specify a GPIO intended for reset is "reset-gpio", > this binding uses "gpio-reset", as almost all other bindings use the > former name this use of the latter is certainly not intended and > was a

[PATCH v3 4/5] mmc: sdhci-esdhc-imx: Allow all supported prescaler values

2017-05-30 Thread Benoît Thébaudeau
(133 MHz / 2 / 2). Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter Reviewed-by: Fabio Estevam --- Changes v1 -> v2: none. Changes v2 -> v3: none. --- drivers/mmc/host/sdhci-esdhc-imx.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drive

[PATCH v3 2/5] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR

2017-05-30 Thread Benoît Thébaudeau
The eSDHC can only DMA from 32-bit-aligned addresses. This fixes the following test cases of mmc_test: 11: Badly aligned write 12: Badly aligned read 13: Badly aligned multi-block write 14: Badly aligned multi-block read Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter

[PATCH v3 3/5] mmc: sdhci-esdhc-imx: Fix DAT line software reset

2017-05-30 Thread Benoît Thébaudeau
in case of errors caused unrecoverable errors. Fix this by making sure that the DAT line software reset does not alter the Host Control register. This behavior being undocumented, it may also be present on other i.MX SoCs, so apply this fix for the whole i.MX family. Signed-off-by: Benoît

[PATCH v3 5/5] mmc: sdhci-esdhc-imx: Remove the ENGcm07207 workaround

2017-05-30 Thread Benoît Thébaudeau
. Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter Reviewed-by: Fabio Estevam --- Changes v1 -> v2: - Spelling fixes moved to a separate patch (suggested by Adrian Hunter). - Comments added about SDHCI_QUIRK_BROKEN_ADMA. Changes v2 -> v3: none. --- drivers/mmc/host/sdhci-esdhc

[PATCH v3 1/5] mmc: sdhci-esdhc-imx: Fix some English mistakes and typos

2017-05-30 Thread Benoît Thébaudeau
Fix various English mistakes and typos in comments and in printed strings. Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter Reviewed-by: Fabio Estevam --- Changes v1 -> v2: new patch. Changes v2 -> v3: - Two more typos fixed (suggested by Adrian Hunter). --- drivers/mmc/host

Re: [PATCH 4/4] mmc: sdhci-esdhc-imx: Remove the ENGcm07207 workaround

2017-05-29 Thread Benoît Thébaudeau
On 2017/05/29 at 16:42, Ulf Hansson wrote: > On 29 May 2017 at 10:07, Adrian Hunter wrote: >> On 03/05/17 13:05, Benoît Thébaudeau wrote: >>> The SDHCI_QUIRK_NO_MULTIBLOCK quirk was used as a workaround for the >>> ENGcm07207 erratum. However, it caused excruciatingly

[PATCH v2 5/5] mmc: sdhci-esdhc-imx: Remove the ENGcm07207 workaround

2017-05-29 Thread Benoît Thébaudeau
. Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter Reviewed-by: Fabio Estevam --- Changes v1 -> v2: - Spelling fixes moved to a separate patch (suggested by Adrian Hunter). - Comments added about SDHCI_QUIRK_BROKEN_ADMA. --- drivers/mmc/host/sdhci-esdhc-imx.c | 16

[PATCH v2 4/5] mmc: sdhci-esdhc-imx: Allow all supported prescaler values

2017-05-29 Thread Benoît Thébaudeau
(133 MHz / 2 / 2). Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter Reviewed-by: Fabio Estevam --- Changes v1 -> v2: none. --- drivers/mmc/host/sdhci-esdhc-imx.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c

[PATCH v2 2/5] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR

2017-05-29 Thread Benoît Thébaudeau
The eSDHC can only DMA from 32-bit-aligned addresses. This fixes the following test cases of mmc_test: 11: Badly aligned write 12: Badly aligned read 13: Badly aligned multi-block write 14: Badly aligned multi-block read Signed-off-by: Benoît Thébaudeau Acked-by: Adrian Hunter

[PATCH v2 1/5] mmc: sdhci-esdhc-imx: Fix some English mistakes and typos

2017-05-29 Thread Benoît Thébaudeau
Fix various English mistakes and typos in comments and in printed strings. Signed-off-by: Benoît Thébaudeau --- Changes v1 -> v2: new patch. --- drivers/mmc/host/sdhci-esdhc-imx.c | 47 +++--- 1 file changed, 24 insertions(+), 23 deletions(-) diff --gi

[PATCH v2 3/5] mmc: sdhci-esdhc-imx: Fix DAT line software reset

2017-05-29 Thread Benoît Thébaudeau
in case of errors caused unrecoverable errors. Fix this by making sure that the DAT line software reset does not alter the Host Control register. This behavior being undocumented, it may also be present on other i.MX SoCs, so apply this fix for the whole i.MX family. Signed-off-by: Benoît

Re: [PATCH 1/4] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR

2017-05-04 Thread Benoît Thébaudeau
On 04/05/2017 10:47, Arnd Bergmann wrote: > On Wed, May 3, 2017 at 12:05 PM, Benoît Thébaudeau wrote: >> The eSDHC can only DMA from 32-bit-aligned addresses. >> >> This fixes the following test cases of mmc_test: >> 11: Badly aligned write >> 12: Ba

[PATCH 1/4] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR

2017-05-03 Thread Benoît Thébaudeau
The eSDHC can only DMA from 32-bit-aligned addresses. This fixes the following test cases of mmc_test: 11: Badly aligned write 12: Badly aligned read 13: Badly aligned multi-block write 14: Badly aligned multi-block read Signed-off-by: Benoît Thébaudeau --- drivers/mmc/host

[PATCH 2/4] mmc: sdhci-esdhc-imx: Fix DAT line software reset

2017-05-03 Thread Benoît Thébaudeau
in case of errors caused unrecoverable errors. Fix this by making sure that the DAT line software reset does not alter the Host Control register. This behavior being undocumented, it may also be present on other i.MX SoCs, so apply this fix for the whole i.MX family. Signed-off-by: Benoît

[PATCH 4/4] mmc: sdhci-esdhc-imx: Remove the ENGcm07207 workaround

2017-05-03 Thread Benoît Thébaudeau
expected. Moreover, after intensive stress tests on i.MX25, removing SDHCI_QUIRK_NO_MULTIBLOCK seems to be safe. Signed-off-by: Benoît Thébaudeau --- drivers/mmc/host/sdhci-esdhc-imx.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc

[PATCH 3/4] mmc: sdhci-esdhc-imx: Allow all supported prescaler values

2017-05-03 Thread Benoît Thébaudeau
(133 MHz / 2 / 2). Signed-off-by: Benoît Thébaudeau --- drivers/mmc/host/sdhci-esdhc-imx.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 4ee82e1..fa60d13 100644 --- a/drivers

Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround

2016-07-21 Thread Benoît Thébaudeau
On 21/07/2016 at 14:34, Benoît Thébaudeau wrote: > On 21/07/2016 at 13:10, Alexandre Belloni wrote: >> On 21/07/2016 at 12:41:30 +0200, Benoît Thébaudeau wrote : >>> The I²C NACK issue of the RV-8803 may occur after any I²C START >>> condition, depending on the

Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround

2016-07-21 Thread Benoît Thébaudeau
On 21/07/2016 at 13:10, Alexandre Belloni wrote: > On 21/07/2016 at 12:41:30 +0200, Benoît Thébaudeau wrote : >> The I²C NACK issue of the RV-8803 may occur after any I²C START >> condition, depending on the timings. Consequently, the workaround must >> be applied for

[PATCH 6/6] rtc: rv8803: Clear V1F when setting the time

2016-07-21 Thread Benoît Thébaudeau
next temperature compensation loss. This is the same principle as for V2F, which is cleared when the time is set to indicate that the time is no longer invalid and to be able to detect the next data loss. Signed-off-by: Benoît Thébaudeau --- drivers/rtc/rtc-rv8803.c | 2 +- 1 file changed, 1

[PATCH 5/6] rtc: rv8803: Stop the clock while setting the time

2016-07-21 Thread Benoît Thébaudeau
VLOW2 (triggering V2F), but not low enough to trigger a POR. Signed-off-by: Benoît Thébaudeau --- drivers/rtc/rtc-rv8803.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 09ab5cb..24c688e 100644 --- a

[PATCH 3/6] rtc: rv8803: Fix read day of week

2016-07-21 Thread Benoît Thébaudeau
. Signed-off-by: Benoît Thébaudeau --- drivers/rtc/rtc-rv8803.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index e740c83..aa1d6b6 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers/rtc/rtc-rv8803.c @@ -13,6 +13,7

[PATCH 4/6] rtc: rv8803: Always apply the I²C workaround

2016-07-21 Thread Benoît Thébaudeau
: Benoît Thébaudeau --- drivers/rtc/rtc-rv8803.c | 179 ++- 1 file changed, 113 insertions(+), 66 deletions(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index aa1d6b6..09ab5cb 100644 --- a/drivers/rtc/rtc-rv8803.c +++ b/drivers

[PATCH 1/6] rtc: rv8803: Kconfig: Indicate rx8900 support

2016-07-21 Thread Benoît Thébaudeau
This driver supports the Epson RX8900, but this was not indicated in Kconfig. Signed-off-by: Benoît Thébaudeau --- drivers/rtc/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 8526f1c..e215f50 100644 --- a/drivers

[PATCH 2/6] rtc: rv8803: Remove the check for valid time

2016-07-21 Thread Benoît Thébaudeau
The RTC core always calls rtc_valid_tm() after ->read_time() in case of success (in __rtc_read_time()), so do not call it twice. Signed-off-by: Benoît Thébaudeau --- drivers/rtc/rtc-rv8803.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/driv

Re: Differences between tlv320aic3x and tlv320aic31xx

2014-10-01 Thread Benoît Thébaudeau
Hi Alexandre, Jyri, On Wed, Oct 1, 2014 at 9:47 AM, Jyri Sarha wrote: > On 09/30/2014 09:37 PM, Alexandre Belloni wrote: >> >> Hi, >> >> I'm trying to add support for the tlv320aic3104a present on a >> custom board using an am335x. >> >> I see that Benoit seemed to have been successful when using

Re: [PATCH 7/9] pwm i.MX: fix clock lookup

2012-09-07 Thread Benoît Thébaudeau
On Friday, September 7, 2012 9:41:38 AM, Sascha Hauer wrote: > On Thu, Sep 06, 2012 at 09:09:42PM +0200, Benoît Thébaudeau wrote: > > On Thursday, September 6, 2012 8:42:56 PM, Sascha Hauer wrote: > > > On Thu, Sep 06, 2012 at 08:31:58PM +0200, Benoît Thébaudeau > > >

Re: [PATCH 7/9] pwm i.MX: fix clock lookup

2012-09-06 Thread Benoît Thébaudeau
On Thursday, September 6, 2012 8:42:56 PM, Sascha Hauer wrote: > On Thu, Sep 06, 2012 at 08:31:58PM +0200, Benoît Thébaudeau wrote: > > On Thursday, September 6, 2012 2:48:13 PM, Sascha Hauer wrote: > > > > > > + int ret; > > > + > > > + ret = clk_

Re: [PATCH 7/9] pwm i.MX: fix clock lookup

2012-09-06 Thread Benoît Thébaudeau
> > Signed-off-by: Philipp Zabel > Signed-off-by: Sascha Hauer > Reviewed-by: Shawn Guo > Reviewed-by: Benoît Thébaudeau > --- > drivers/pwm/pwm-imx.c | 35 +++ > 1 file changed, 27 insertions(+), 8 deletions(-) > > diff --git

Re: [PATCH 7/8] pwm i.MX: fix clock lookup

2012-09-05 Thread Benoît Thébaudeau
On Wednesday, September 5, 2012 3:35:26 PM, Sascha Hauer wrote: > > From: Philipp Zabel > > The i.MX pwm core has two clocks: The ipg clock and the ipg highfreq > (peripheral) clock. The ipg clock has to be enabled for this hardware > to work. The actual pwm output can either be driven by the ip

Re: [PATCH 5/8] pwm i.MX: add devicetree support

2012-09-05 Thread Benoît Thébaudeau
On Wednesday, September 5, 2012 3:35:24 PM, Sascha Hauer wrote: > > From: Philipp Zabel > > At the same time remove platform based support. No user for > this driver has made it into mainline so far, so all we break > is out of tree stuff. > > Signed-off-by: Philipp Zabel > Signed-off-by: Sasc

[PATCH] pwm-imx: Fix config / enable / disable

2012-08-23 Thread Benoît Thébaudeau
first setting of brightness through sysfs that had no effect with leds-pwm. Cc: Thierry Reding Cc: Cc: Sascha Hauer Cc: Cc: Benoît Thébaudeau Signed-off-by: Benoît Thébaudeau --- .../drivers/pwm/pwm-imx.c | 55 +++- 1 file changed, 43 insertions

Re: [PATCH] pwm: Call pwm_enable() before pwm_config()

2012-08-23 Thread Benoît Thébaudeau
On Thursday, August 23, 2012 5:43:32 PM, Lars-Peter Clausen wrote: > On 08/23/2012 04:19 PM, Benoît Thébaudeau wrote: > > Some PWM drivers enable the clock of the PWM peripheral in > > pwm_enable(). Hence, > > for these drivers, a call to pwm_config() does not have

[PATCH] pwm: Call pwm_enable() before pwm_config()

2012-08-23 Thread Benoît Thébaudeau
first setting of brightness through sysfs that had no effect with leds-pwm and the i.MX PWM driver. Cc: Thierry Reding Cc: Cc: Sascha Hauer Cc: Cc: Dmitry Torokhov Cc: Cc: Bryan Wu Cc: Richard Purdie Cc: Cc: Florian Tobias Schandinat Cc: Cc: Benoît Thébaudeau Signed-off-by: Benoît