):
platform/chrome: cros_ec_lightbar - hide unused PM functions
Benson Leung (1):
platform/chrome : Add myself as Maintainer
Eric Caruso (4):
mfd: cros_ec: add debugfs, console log file
platform/chrome: cros_ec_lightbar - Add lightbar program feature to sysfs
platform
Hi Lee,
On Mon, Jul 03, 2017 at 12:46:41PM +0100, Lee Jones wrote:
> On Tue, 27 Jun 2017, Benson Leung wrote:
>
> > Hi Thierry,
> >
> > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > > From: Shawn Nematbakhsh <sha...@chromium.org>
Hi Lee,
On Mon, Jul 03, 2017 at 12:46:41PM +0100, Lee Jones wrote:
> On Tue, 27 Jun 2017, Benson Leung wrote:
>
> > Hi Thierry,
> >
> > On Tue, Feb 14, 2017 at 08:58:02PM +0100, Thierry Escande wrote:
> > > From: Shawn Nematbakhsh
> > >
> > >
("platform/chrome: cros_ec_lightbar - Control of
> suspend/resume lightbar sequence")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Good catch. Applied. Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
("platform/chrome: cros_ec_lightbar - Control of
> suspend/resume lightbar sequence")
> Signed-off-by: Arnd Bergmann
Good catch. Applied. Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
event was introduced in cros_ec_lpc.c since
this patch was posted, so I went ahead and modified that too.
Applied. Thanks.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
rs/platform/chrome/cros_ec_proto.c | 76
> ++---
> include/linux/mfd/cros_ec.h | 5 ++-
> 3 files changed, 85 insertions(+), 9 deletions(-)
>
Another use of cros_ec_get_next_event was introduced in cros_ec_lpc.c since
this patch was posted, so I went ahead and modi
gnou <gwen...@chromium.org>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Applied. Thanks again!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
Thierry Escande
Applied. Thanks again!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
supported
> field) and cros_ec_query_all() returns 0.
>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Applied. Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.
supported
> field) and cros_ec_query_all() returns 0.
>
> Signed-off-by: Thierry Escande
Applied. Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
> Signed-off-by: Jeffery Yu <jeffe...@nvidia.com>
> Signed-off-by: Guenter Roeck <gro...@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied.
> ---
> drivers/platform/
fery Yu
> Signed-off-by: Guenter Roeck
> Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Benson Leung
Applied.
> ---
> drivers/platform/chrome/cros_ec_dev.c | 12
> drivers/platform/chrome/cros_ec_lightbar.c | 13 +
> 2 files changed, 13 inserti
ng through its normal suspend/resume pathways.
>
> Signed-off-by: Eric Caruso <ejcar...@chromium.org>
> Signed-off-by: Guenter Roeck <gro...@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
Signed-off-by: Benson Leung <ble...@chr
resume pathways.
>
> Signed-off-by: Eric Caruso
> Signed-off-by: Guenter Roeck
> Signed-off-by: Enric Balletbo i Serra
Signed-off-by: Benson Leung
Applied.
> ---
> drivers/platform/chrome/cros_ec_lightbar.c | 38
> ++
> 1 file changed, 38
r Roeck <gro...@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied. Thanks.
> ---
> drivers/platform/chrome/cros_ec_de
gt; Acked-by: Lee Jones
Signed-off-by: Benson Leung
Applied. Thanks.
> ---
> drivers/platform/chrome/cros_ec_dev.c | 37 +
> drivers/platform/chrome/cros_ec_dev.h | 6 +++
> drivers/platform/chrome/cros_ec_lightbar.c | 85
> --
> inc
Hi Thierry,
On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote:
> Hi Benson,
>
> On 22/06/2017 21:35, Benson Leung wrote:
>
>
>
> >>+ adev = ACPI_COMPANION(dev);
> >>+ if (adev) {
> >>+ stat
Hi Thierry,
On Fri, Jun 23, 2017 at 09:35:06AM +0200, Thierry Escande wrote:
> Hi Benson,
>
> On 22/06/2017 21:35, Benson Leung wrote:
>
>
>
> >>+ adev = ACPI_COMPANION(dev);
> >>+ if (adev) {
> >>+ stat
nric Balletbo i Serra <enric.balle...@collabora.com>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied.
> ---
> drivers/platform/chrome/cros_ec_lightbar.c | 69
> +-
> include/lin
> $ cat > /sys/devices/.../cros_ec/program
> $ echo program > /sys/devices/.../cros_ec/sequence
>
> Signed-off-by: Eric Caruso
> Signed-off-by: Guenter Roeck
> Signed-off-by: Enric Balletbo i Serra
> Acked-by: Lee Jones
Signed-off-by: Benson Leun
t we do not bother doing any parsing (we should write a small
> offline tool for that).
>
> Signed-off-by: Nicolas Boichat <drink...@chromium.org>
> Reviewed-by: Guenter Roeck <gro...@chromium.org>
> Tested-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
parsing (we should write a small
> offline tool for that).
>
> Signed-off-by: Nicolas Boichat
> Reviewed-by: Guenter Roeck
> Tested-by: Enric Balletbo i Serra
Signed-off-by: Benson Leung
Applied. Thanks.
> ---
> drivers/platform/chrome/cros_ec_debugfs.c | 54
> +++
s.
>
> Signed-off-by: Archana Patni <archana.pa...@intel.com>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied. Thanks.
> ---
> drivers/platform/chrome/cros_ec_lpc.c | 21 +
na Patni
> Signed-off-by: Thierry Escande
Signed-off-by: Benson Leung
Applied. Thanks.
> ---
> drivers/platform/chrome/cros_ec_lpc.c | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c
> b/drivers/platfor
probed for devices
> with a GOOG0004 ACPI entry.
>
> Signed-off-by: Gwendal Grignou <gwen...@chromium.org>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied to what will become the immutable branch.
>
0004 ACPI entry.
>
> Signed-off-by: Gwendal Grignou
> Signed-off-by: Thierry Escande
Signed-off-by: Benson Leung
Applied to what will become the immutable branch.
> ---
> drivers/platform/chrome/Kconfig | 2 +-
> drivers/platform/chrome/cros_ec_lpc.c | 23 +
(struct platform_device *pdev)
> {
> struct cros_ec_device *ec_dev;
> + struct acpi_device *adev;
> +
> + adev = ACPI_COMPANION(>dev);
> + if (adev)
> + acpi_remove_notify_handler(adev->handle, ACPI_ALL_NOTIFY,
> +
ice *adev;
> +
> + adev = ACPI_COMPANION(>dev);
> + if (adev)
> + acpi_remove_notify_handler(adev->handle, ACPI_ALL_NOTIFY,
> +cros_ec_lpc_acpi_notify);
>
> ec_dev = platform_get_drvdata(pdev);
> cros_ec_remove(ec_dev);
> --
> 2.9.3
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: Digital signature
gt; Signed-off-by: Shawn Nematbakhsh <sha...@chromium.org>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Signed-off-by: Benson Leung <ble...@chromium.org>
Applied to my upcoming immutable branch.
> ---
> drivers/platform/chrome/Makefile | 3 +
khsh
> Signed-off-by: Thierry Escande
Signed-off-by: Benson Leung
Applied to my upcoming immutable branch.
> ---
> drivers/platform/chrome/Makefile | 3 +-
> drivers/platform/chrome/cros_ec_lpc.c | 88
> +--
> drivers/pl
gt; mec1322 accesses I/O region [800h, 9ffh] through embedded memory
> interface (EMI) rather than LPC.
>
> Signed-off-by: Shawn Nematbakhsh <sha...@chromium.org>
> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com>
Signed-off-by: Benson Leung <ble...@chr
region [800h, 9ffh] through embedded memory
> interface (EMI) rather than LPC.
>
> Signed-off-by: Shawn Nematbakhsh
> Signed-off-by: Thierry Escande
Signed-off-by: Benson Leung
Applied to my upcoming immutable branch.
> ---
> drivers/platform/chrome/Kconfig | 12 +++
mand.
>
> Signed-off-by: Nicolas Boichat <drink...@chromium.org>
> Reviewed-by: Guenter Roeck <gro...@chromium.org>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
> Tested-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
Thanks. Applied.
--
Benson Le
s Boichat
> Reviewed-by: Guenter Roeck
> Acked-by: Lee Jones
> Tested-by: Enric Balletbo i Serra
Thanks. Applied.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
org>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Acked-by: Lee Jones <lee.jo...@linaro.org>
Applied to my branch. I'll let you know when the whole thing is ready.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@go
> Acked-by: Lee Jones
Applied to my branch. I'll let you know when the whole thing is ready.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
esponse);
By my diff, the above two lines were changed from the original CHROMIUM
commit, based on Doug's comment here: https://lkml.org/lkml/2017/2/22/630
However, this is an incomplete fix. Instead, we should pick this:
https://chromium-review.googlesource.com/#/c/444085/
I'll go ahead and do tha
esponse);
By my diff, the above two lines were changed from the original CHROMIUM
commit, based on Doug's comment here: https://lkml.org/lkml/2017/2/22/630
However, this is an incomplete fix. Instead, we should pick this:
https://chromium-review.googlesource.com/#/c/444085/
I'll go ahead and do tha
em.
>
I'll create an immutable branch with this this week. Thank you!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
mmutable branch with this this week. Thank you!
Benson
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
or Apple's proprietary
"Brick ID" charging method.
Signed-off-by: Benson Leung <ble...@chromium.org>
---
drivers/power/supply/power_supply_sysfs.c | 2 +-
include/linux/power_supply.h | 15 ---
2 files changed, 9 insertions(+), 8 deletions(-)
diff --
or Apple's proprietary
"Brick ID" charging method.
Signed-off-by: Benson Leung
---
drivers/power/supply/power_supply_sysfs.c | 2 +-
include/linux/power_supply.h | 15 ---
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/power/supply/pow
uspend time.
>
> Signed-off-by: Gwendal Grignou <gwen...@chromium.org>
Acked-by: Benson Leung <ble...@chromium.org>
New driver looks good to me.
I'll add this to my tree, once I get it up and running.
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.
pend time.
>
> Signed-off-by: Gwendal Grignou
Acked-by: Benson Leung
New driver looks good to me.
I'll add this to my tree, once I get it up and running.
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
signature.asc
Description: OpenPGP digital signature
ume time when different from suspend time.
>
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2
Strip off the gerrit Change-Id: as it is meaningless upstream.
Thanks!
Benson
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble..
ume time when different from suspend time.
>
> Change-Id: Ie51d426de68770fad8eeb83aaab9abe8d69e84a2
Strip off the gerrit Change-Id: as it is meaningless upstream.
Thanks!
Benson
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble..
off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
Acked-by: Benson Leung <ble...@chromium.org>
Sorry for the delay on this Enric. This looks good to go.
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromiu
Hi Enric,
On Thu, Jan 19, 2017 at 01:30:32PM +0100, Enric Balletbo i Serra wrote:
> From: Stephen Barber
>
> If the EC supports RTC host commands, expose an RTC device.
>
> Signed-off-by: Stephen Barber
> Signed-off-by: Enric Balletbo i Serra
Acked-by: Benson Leung
S
ABLET_MODE);
> + ret = input_register_device(idev);
> + if (ret) {
> + dev_err(dev, "cannot register input device\n");
> + return ret;
> + }
> + return 0;
> +}
> +
> +static const struct acpi_device_id chromeos_tbm
ret = input_register_device(idev);
> + if (ret) {
> + dev_err(dev, "cannot register input device\n");
> + return ret;
> + }
> + return 0;
> +}
> +
> +static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] =
mode 100644 drivers/platform/chrome/cros_ec_lpc_mec.c
> create mode 100644 drivers/platform/chrome/cros_ec_lpc_reg.c
> create mode 100644 include/linux/mfd/cros_ec_lpc_mec.h
> create mode 100644 include/linux/mfd/cros_ec_lpc_reg.h
>
> --
> 2.7.4
>
--
Benson Leung
hrome/cros_ec_lpc_mec.c
> create mode 100644 drivers/platform/chrome/cros_ec_lpc_reg.c
> create mode 100644 include/linux/mfd/cros_ec_lpc_mec.h
> create mode 100644 include/linux/mfd/cros_ec_lpc_reg.h
>
> --
> 2.7.4
>
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
Google Inc.
ble...@google.com
Chromium OS Project
ble...@chromium.org
[PATCH] platform/chrome : Add myself as Maintainer
>
> but it's not merged anywhere AFAICT.
>
> I can resend if that helps.
I'll be happy to accept these once I get my chrome-platform maintainer
workflow going. I'm hoping to hear back from Olof as well.
--
Benson Leung
Senior Softw
self as Maintainer
>
> but it's not merged anywhere AFAICT.
>
> I can resend if that helps.
I'll be happy to accept these once I get my chrome-platform maintainer
workflow going. I'm hoping to hear back from Olof as well.
--
Benson Leung
Senior Software Engineer
Chrome OS Kernel
I'll be taking over maintainership of platform/chrome from Olof,
so let's add me to the list of maintainers.
Signed-off-by: Benson Leung <ble...@chromium.org>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2a58eea..5e77b1e
I'll be taking over maintainership of platform/chrome from Olof,
so let's add me to the list of maintainers.
Signed-off-by: Benson Leung
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2a58eea..5e77b1e 100644
--- a/MAINTAINERS
+++ b
t;robert.f...@collabora.com>
> Signed-off-by: Robert Foss <robert.f...@collabora.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
Thanks Robert!
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
Since the
> tuning command is expected to complete quickly (<50ms) and we've set a
> timeout, use wait_event_timeout() instead.
>
> Signed-off-by: Christopher Freeman
> Tested-by: Robert Foss
> Signed-off-by: Robert Foss
Reviewed-by: Benson Leung
Thanks Robert!
--
Benso
by Daniel, don't do this for submissions to linux-kernel or
linux-iio. Base this on the linux-iio tree.
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
4 100644
> --- a/chromeos/config/x86_64/chromiumos-x86_64.flavour.config
> +++ b/chromeos/config/x86_64/chromiumos-x86_64.flavour.config
This looks like this patch was based on a chromeos-kernel. As was
mentioned by Daniel, don't do this for submissions to linux-kernel or
linux-iio. Base
plicate.
Signed-off-by: Benson Leung <ble...@chromium.org>
---
drivers/platform/chrome/chromeos_laptop.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index 8398a7d..e8a44a9 100644
---
plicate.
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index 8398a7d..e8a44a9 100644
--- a/drivers/platform/chrome/chr
ned-off-by: Olof Johansson <ol...@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balle...@collabora.com>
> Reviewed-by: Sameer Nanda <sna...@chromium.org>
Reviewed-by: Benson Leung <ble...@chromium.org>
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
o i Serra
> Reviewed-by: Sameer Nanda
Reviewed-by: Benson Leung
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
int-LP I2C via
> the i2c-designware-pci driver.
>
> Based on the following patch:
> https://chromium-review.googlesource.com/#/c/168351/
>
> Signed-off-by: Gene Chen <gene.c...@intel.com>
> Reviewed-by: Benson Leung <ble...@chromium.org>
> Signed-off-by: Enric Ballet
n the following patch:
> https://chromium-review.googlesource.com/#/c/168351/
>
> Signed-off-by: Gene Chen
> Reviewed-by: Benson Leung
> Signed-off-by: Enric Balletbo i Serra
I'll have to nack this patch. This actually already landed here :
963cb6f platform/chrome: chromeos_lapto
Add the elan trackpad to the Acer C720 (peppy) list, as it is an alternate
trackpad option. It may exist at i2c address 0x15.
Based on this change from the chromeos kernel :
https://chromium-review.googlesource.com/186253
Signed-off-by: Benson Leung <ble...@chromium.org>
---
drivers/pl
ed-off-by: Charlie Mooney <charliemoo...@chromium.org>
Signed-off-by: Benson Leung <ble...@chromium.org>
---
drivers/platform/chrome/chromeos_laptop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
inde
The chromeos-3.8 kernel has support for a second-sourced elan device for
two Haswell based systems, Peppy and Wolf.
Benson Leung (1):
platform/chrome: chromeos_laptop - Add elan trackpad option for C720
Charlie Mooney (1):
platform/chrome: chromeos_laptop - Add Elan touchpad for Wolf
Add the elan trackpad to the Acer C720 (peppy) list, as it is an alternate
trackpad option. It may exist at i2c address 0x15.
Based on this change from the chromeos kernel :
https://chromium-review.googlesource.com/186253
Signed-off-by: Benson Leung
---
drivers/platform/chrome
-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index 2a510b8..e8a44a9 100644
--- a/drivers/platform/chrome/chromeos_laptop.c
+++ b/drivers
The chromeos-3.8 kernel has support for a second-sourced elan device for
two Haswell based systems, Peppy and Wolf.
Benson Leung (1):
platform/chrome: chromeos_laptop - Add elan trackpad option for C720
Charlie Mooney (1):
platform/chrome: chromeos_laptop - Add Elan touchpad for Wolf
ot number after mt_reset_resume().
>
> Signed-off-by: Gabriele Mazzotta <gabriele@gmail.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.
gt;
> Signed-off-by: Gabriele Mazzotta
Reviewed-by: Benson Leung
> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/
ing built with the wrong git tree. The new
types for these three errors landed in sre's linux-power-supply here :
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/commit/?h=next=6659b55dae09b2042d8cdd0f4576502c3e81957c
It should be in most recent linux-nexts, but it wouldn't be in v4.5-rc7.
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
wrong git tree. The new
types for these three errors landed in sre's linux-power-supply here :
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/commit/?h=next=6659b55dae09b2042d8cdd0f4576502c3e81957c
It should be in most recent linux-nexts, but it wouldn't be in v4.5-rc7.
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
t mask, 0 on error
> + */
> +uint32_t cros_ec_get_host_event(struct cros_ec_device *ec_dev);
> +
> /* sysfs stuff */
> extern struct attribute_group cros_ec_attr_group;
> extern struct attribute_group cros_ec_lightbar_attr_group;
> --
> 2.5.0
>
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
cros_ec_get_host_event - Return a mask of event set by the EC.
> + *
> + * Returns the mask of the event that caused the last interrupt to be raised.
> + *
> + * @ec_dev: Device to fetch event from
> + * @return event mask, 0 on error
> + */
> +uint32_t cros_ec_get_host_event
gt;
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
>
> Changes in v5:
> - Check explicitly for !EC_RES_SUCCESS as suggested by Benson Leung.
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
Thanks!
On Mon, Mar 14, 2016 at 8:44 AM, Tomeu Vizoso
wrote:
> So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate
> code when checking for errors from the EC side.
>
> Signed-off-by: Tomeu Vizoso
Reviewed-by: Benson Leung
> ---
>
> Changes in v5:
gt; + * using this function.
> + *
> + * @ec_dev: EC device
> + * @msg: Message to write
> + * @return: Num. of bytes transferred on success, <0 on failure
> + */
> +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev,
> + struct cros_ec_command *msg);
> +
> +/**
> * cros_ec_remove - Remove a ChromeOS EC
> *
> * Call this to deregister a ChromeOS EC, then clean up any private data.
> --
> 2.5.0
>
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
* @return: Num. of bytes transferred on success, <0 on failure
> + */
> +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev,
> + struct cros_ec_command *msg);
> +
> +/**
> * cros_ec_remove - Remove a ChromeOS EC
> *
> * Call this to deregister a ChromeOS EC, then clean up any private data.
> --
> 2.5.0
>
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
rk the device as running at full
> power (since that is what resetting will do to it).
>
> Signed-off-by: Doug Anderson <diand...@chromium.org>
> Signed-off-by: Dmitry Torokhov <d...@chromium.org>
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
>
> This
at full
> power (since that is what resetting will do to it).
>
> Signed-off-by: Doug Anderson
> Signed-off-by: Dmitry Torokhov
Reviewed-by: Benson Leung
> ---
>
> This is an uprev of a patch that Doug sent a year ago (see
> https://patchwork.kernel.org/patch/5970731/), adjusted to
hat?
Sounds good to me!
Thanks,
Benson
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
sting entries, do you agree with that?
Sounds good to me!
Thanks,
Benson
--
Benson Leung
Senior Software Engineer, Chrom* OS
ble...@chromium.org
On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso wrote:
> s/cros_ec_register/cros_ec_query_all
>
> Signed-off-by: Tomeu Vizoso
Reviewed-by: Benson Leung
> ---
>
> include/linux/mfd/cros_ec.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/in
Thanks for putting this up Tomeu!
On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso wrote:
> From: Benson Leung
>
> This adds power supply types for USB chargers defined in
> the USB Type-C Specification 1.1 and in the
> USB Power Delivery Specification Revision 2.0 V1.1.
&g
Thanks for putting this up Tomeu!
On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote:
> From: Benson Leung <ble...@chromium.org>
>
> This adds power supply types for USB chargers defined in
> the USB Type-C Specification 1.1 and in
On Fri, Feb 5, 2016 at 5:32 AM, Tomeu Vizoso <tomeu.viz...@collabora.com> wrote:
> s/cros_ec_register/cros_ec_query_all
>
> Signed-off-by: Tomeu Vizoso <tomeu.viz...@collabora.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
> ---
>
> include/linux/mfd/c
ned-off-by: Dudley Du
Reviewed-by: Benson Leung
Thanks!
--
Benson Leung
Senior Software Engineer, Chrome OS
Google Inc.
ble...@google.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
..@gmail.com>
> Reviewed-by: Sudip Mukherjee <sudipm.mukher...@gmail.com>
> Signed-off-by: Dudley Du <d...@cypress.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
Thanks!
--
Benson Leung
Senior Software Engineer, Chrome OS
Google Inc.
ble...@google.com
--
To unsubscri
rivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be
> simplified
>
> Signed-off-by: Javier Martinez Canillas
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-
coccicheck warning:
>
> drivers/input/mouse/elan_i2c_smbus.c:402:1-6: WARNING: end returns can be
> simplified
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Reviewed-by: Benson Leung <ble...@chromium.org>
--
Benson Leung
Software Engineer, Chrom* OS
ble...@
Search for "vaildpage_count" and replace with "validpage_count".
Signed-off-by: Benson Leung
---
drivers/input/mouse/elan_i2c_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/m
Search for vaildpage_count and replace with validpage_count.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/input/mouse/elan_i2c_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse
onnect, freeze), so maybe
change the commit message to reflect that?
Otherwise, LGTM.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Mor
input_dev_suspend (reset, disconnect, freeze), so maybe
change the commit message to reflect that?
Otherwise, LGTM.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
le, since
> acpi_bind_one uses's the companion ACPI device's wakeup flags to set the
> device as wake capable. Which results in power/wakeup files in sysfs for
> the HID device which do not do anything.
>
> Signed-off-by: Andrew Duggan
Reviewed-by: Benson Leung
Tested-by: Benson Leung
>
301 - 400 of 755 matches
Mail list logo
