usbhid->intf->needs_remote_wakeup = 0;
> + usb_kill_urb(usbhid->urbin);
>
> Have you tried this?
Yes, I tried that as well, and that does work.
I used the get/put because that's the way it was done in other
drivers, for example in synusb_close() in
drivers/inp
keup flag, and
usb_autopm_put_interface is called after hid_start_in.
However, when the device is closed in usbhid_close, the same
protection isn't there when clearing needs_remote_wakeup. This will
add that to usbhid_close as well as usbhid_stop.
Signed-off-by: Benson Leung
---
drivers/hid/usbhid/hid-co
, and
usb_autopm_put_interface is called after hid_start_in.
However, when the device is closed in usbhid_close, the same
protection isn't there when clearing needs_remote_wakeup. This will
add that to usbhid_close as well as usbhid_stop.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/hid/usbhid/hid-core.c | 17
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
is cleared as a result of usb_kill_urb(usbhid-urbin);
The result is that a device that may otherwise autosuspend will
fail to enter suspend again after all handles to it are closed.
Clear the flag first before usb_kill_urb, which may result in a
autosuspend_check().
Signed-off-by: Benson Leung ble
.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
the problem, but I saw other
places in the kernel where it was done with a get/put.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Mon, Nov 3, 2014 at 8:43 AM, Anton Staaf wrote:
> Add support for Google devices that export simple serial
> interfaces using the vendor specific SubClass/Protocol pair
> 0x50/0x01.
>
> Signed-off-by: Anton Staaf
Reviewed-by: Benson Leung
--
Benson Leung
Software Engi
On Mon, Nov 3, 2014 at 8:43 AM, Anton Staaf robot...@chromium.org wrote:
Add support for Google devices that export simple serial
interfaces using the vendor specific SubClass/Protocol pair
0x50/0x01.
Signed-off-by: Anton Staaf robot...@chromium.org
Reviewed-by: Benson Leung ble
When using the device tree binding of compatible = "hid-over-i2c"
the i2c id table also needs to have that name in order to
auto load this driver.
Signed-off-by: Benson Leung
---
drivers/hid/i2c-hid/i2c-hid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/i2c-hid/i
When using the device tree binding of compatible = hid-over-i2c
the i2c id table also needs to have that name in order to
auto load this driver.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/hid/i2c-hid/i2c-hid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/i2c
> Signed-off-by: Dmitry Torokhov
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:
-by: Duson Lin duson...@emc.com.tw
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
rignou
> Reviewed-by: Rhyland Klein
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at h
-by: Gwendal Grignou gwen...@chromium.org
Reviewed-by: Rhyland Klein rkl...@nvidia.com
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
of generating stray events.
> TEST=test on Chromebooks.
>
> Signed-off-by: Dudley Du
So, I think for the chromeos-kernel, we are moving away from this hack
lid filter solution. Very soon we'll remove this in favor of something
else, so my suggestion would be to drop this from your patch series.
on Chromebooks.
Signed-off-by: Dudley Du d...@cyrpess.com
So, I think for the chromeos-kernel, we are moving away from this hack
lid filter solution. Very soon we'll remove this in favor of something
else, so my suggestion would be to drop this from your patch series.
--
Benson Leung
Software
On Thu, Aug 7, 2014 at 7:07 AM, wrote:
>
> From: Nick Dyer
>
> Signed-off-by: Nick Dyer
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
On Thu, Aug 7, 2014 at 7:07 AM, nick.d...@itdev.co.uk wrote:
From: Nick Dyer nick.d...@itdev.co.uk
Signed-off-by: Nick Dyer nick.d...@itdev.co.uk
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list
On Sat, Jul 19, 2014 at 7:51 AM, Alan Stern wrote:
> On Fri, 18 Jul 2014, Dmitry Torokhov wrote:
>
>> > The area where it must interact with power management is wakeup, both
>> > remote
>> > wakeup at run time and wakeup from system suspend. In particular, there's
>> > the question whether or
On Sat, Jul 19, 2014 at 7:51 AM, Alan Stern st...@rowland.harvard.edu wrote:
On Fri, 18 Jul 2014, Dmitry Torokhov wrote:
The area where it must interact with power management is wakeup, both
remote
wakeup at run time and wakeup from system suspend. In particular, there's
the question
ld be
helpful would be for transforming form-factors such as Yoga style
laptops where the screen can fold back into tablet mode, and the C
panel touchpad and keyboard should be disabled.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list:
be for transforming form-factors such as Yoga style
laptops where the screen can fold back into tablet mode, and the C
panel touchpad and keyboard should be disabled.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
/168130
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 45 ---
1 file changed, 41 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index a53fe76..cc76426
Dave Parker :
> https://chromium-review.googlesource.com/#/c/167136/
>
> Signed-off-by: Michael Mullin
Reviewed-by: Benson Leung
> ---
> drivers/platform/chrome/chromeos_laptop.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/chrome/chromeos_l
by Dave Parker dpar...@chromium.org:
https://chromium-review.googlesource.com/#/c/167136/
Signed-off-by: Michael Mullin masmul...@gmail.com
Reviewed-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
/168130
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 45 ---
1 file changed, 41 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index
move to
> using an ACPI device to configure this instead of a DMI table (yay!),
> so longer-term that will sort itself out.
>
> Signed-off-by: Olof Johansson
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this lis
to configure this instead of a DMI table (yay!),
so longer-term that will sort itself out.
Signed-off-by: Olof Johansson o...@lixom.net
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line
tches can go upstream?
>
> Benson promised to send out the whole series once 3.16-rc1 is released.
> So any minute now ;-)
Here's the new patchwork bundle. Patches are on lkml now.
https://patchwork.kernel.org/bundle/bleung/platform-chrome-haswell-chromebooks-v2/
--
Benson Leung
So
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index a241e5f
-review.googlesource.com/173445
Signed-off-by: Gene Chen
Signed-off-by: Benson Leung
Tested-by: Scot Doyle
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
This patch series will add support for the cypress touchpads on the
HP Chromebook 14, Dell Chromebook 11, and Toshiba CB35.
Based on the work here by Mika Westerberg, which this series incorporates :
https://patchwork.kernel.org/patch/4288591/
[PATCHv2 1/4] platform/chrome: chromeos_laptop -
and light sensor.
This code is based on following patch from Benson Leung:
https://patchwork.kernel.org/patch/3074411/
Signed-off-by: Mika Westerberg
Tested-by: Kirill A. Shutemov
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 45 ++-
1
/
https://chromium-review.googlesource.com/#/c/174664/
Signed-off-by: Mohammed Habibulla
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
Looks like -rc1 is here, so I'll respin these and send them out again.
On Tue, Jun 3, 2014 at 3:59 PM, Olof Johansson wrote:
> Hi,
>
> On Tue, Jun 3, 2014 at 3:44 PM, Benson Leung wrote:
>> This patch series should be applied after Mika Westerberg's patch here:
>> https:/
Looks like -rc1 is here, so I'll respin these and send them out again.
On Tue, Jun 3, 2014 at 3:59 PM, Olof Johansson o...@lixom.net wrote:
Hi,
On Tue, Jun 3, 2014 at 3:44 PM, Benson Leung ble...@chromium.org wrote:
This patch series should be applied after Mika Westerberg's patch here
-review.googlesource.com/#/c/65320/
https://chromium-review.googlesource.com/#/c/174664/
Signed-off-by: Mohammed Habibulla m...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform
for this and then register both C720 touchpad and light sensor.
This code is based on following patch from Benson Leung:
https://patchwork.kernel.org/patch/3074411/
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Tested-by: Kirill A. Shutemov kirill.shute...@linux.intel.com
Signed-off-by: Benson
This patch series will add support for the cypress touchpads on the
HP Chromebook 14, Dell Chromebook 11, and Toshiba CB35.
Based on the work here by Mika Westerberg, which this series incorporates :
https://patchwork.kernel.org/patch/4288591/
[PATCHv2 1/4] platform/chrome: chromeos_laptop -
://chromium-review.googlesource.com/173445
Signed-off-by: Gene Chen gene.c...@intel.com
Signed-off-by: Benson Leung ble...@chromium.org
Tested-by: Scot Doyle lkm...@scotdoyle.com
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
can go upstream?
Benson promised to send out the whole series once 3.16-rc1 is released.
So any minute now ;-)
Here's the new patchwork bundle. Patches are on lkml now.
https://patchwork.kernel.org/bundle/bleung/platform-chrome-haswell-chromebooks-v2/
--
Benson Leung
Software Engineer, Chrom
.
We know that bus 0 is going to have the touchpad, and we know that bus
1 is going to have the touchscreen and light sensor. I'd prefer not to
send extra probes for all of the combination of devices that don't
exist.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe
that bus 0 is going to have the touchpad, and we know that bus
1 is going to have the touchscreen and light sensor. I'd prefer not to
send extra probes for all of the combination of devices that don't
exist.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from
your Acer C720 patch along with the rest of my patches
when v3.16-rc1 is released.
Thanks!
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
myself.
I'll include your Acer C720 patch along with the rest of my patches
when v3.16-rc1 is released.
Thanks!
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
This patch series should be applied after Mika Westerberg's patch here:
https://patchwork.kernel.org/patch/4288591/
It will add support for the cypress touchpads on the HP Chromebook 14,
Dell Chromebook 11, and Toshiba CB35.
[PATCH 1/3] platform/chrome: chromeos_laptop - Add HP Chromebook 14
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index 44806c5
-review.googlesource.com/173445
Signed-off-by: Gene Chen
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome/chromeos_laptop.c
index c4d89ae
/
https://chromium-review.googlesource.com/#/c/174664/
Signed-off-by: Mohammed Habibulla
Signed-off-by: Benson Leung
---
drivers/platform/chrome/chromeos_laptop.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
C host controller driver has two instances on this
> particular machine we need a way to match the correct instance. Add support
> for this and then register both C720 touchpad and light sensor.
>
> This code is based on following patch from Benson Leung:
>
> https://patchwork.
.
Since the designware I2C host controller driver has two instances on this
particular machine we need a way to match the correct instance. Add support
for this and then register both C720 touchpad and light sensor.
This code is based on following patch from Benson Leung:
https
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b/drivers/platform/chrome
://chromium-review.googlesource.com/173445
Signed-off-by: Gene Chen gene.c...@intel.com
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/platform/chrome/chromeos_laptop.c
b
-review.googlesource.com/#/c/65320/
https://chromium-review.googlesource.com/#/c/174664/
Signed-off-by: Mohammed Habibulla m...@chromium.org
Signed-off-by: Benson Leung ble...@chromium.org
---
drivers/platform/chrome/chromeos_laptop.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/platform
This patch series should be applied after Mika Westerberg's patch here:
https://patchwork.kernel.org/patch/4288591/
It will add support for the cypress touchpads on the HP Chromebook 14,
Dell Chromebook 11, and Toshiba CB35.
[PATCH 1/3] platform/chrome: chromeos_laptop - Add HP Chromebook 14
ntly depending
on the state of the lid, rather than leaving it to user space to
manage the power management of these devices in real time and open up
the possibility of race conditions there if user space is too slow.
Thanks!
--
Benson Leung
Software Engineer, Chrome OS
Google Inc.
ble...@google.c
between
the lid and devices that must be power managed differently depending
on the state of the lid, rather than leaving it to user space to
manage the power management of these devices in real time and open up
the possibility of race conditions there if user space is too slow.
Thanks!
--
Benson
On Thu, Feb 6, 2014 at 4:21 PM, Benson Leung wrote:
> On Fri, Jan 10, 2014 at 12:30 PM, Benson Leung wrote:
>> On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin wrote:
>>> This driver adds support for elan i2c/smbus touchpad found on some laptops
>>> PC
>>>
>>
On Thu, Feb 6, 2014 at 4:21 PM, Benson Leung ble...@chromium.org wrote:
On Fri, Jan 10, 2014 at 12:30 PM, Benson Leung ble...@chromium.org wrote:
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops
PC
On Fri, Jan 10, 2014 at 12:30 PM, Benson Leung wrote:
> On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin wrote:
>> This driver adds support for elan i2c/smbus touchpad found on some laptops PC
>>
>> Signed-off-by: Duson Lin
>
> Reviewed-by: Benson Leung
>
Hi Dmit
On Tue, Dec 17, 2013 at 7:46 PM, Duson Lin wrote:
> This driver adds support for elan i2c/smbus touchpad found on some laptops PC
>
> Signed-off-by: Duson Lin
Reviewed-by: Benson Leung
Hi Dmitry,
This driver has been posted for a little while now. I've reviewed it,
and it is c
On Tue, Dec 17, 2013 at 7:46 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops PC
Signed-off-by: Duson Lin duson...@emc.com.tw
Reviewed-by: Benson Leung ble...@chromium.org
Hi Dmitry,
This driver has been posted for a little
On Fri, Jan 10, 2014 at 12:30 PM, Benson Leung ble...@chromium.org wrote:
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops PC
Signed-off-by: Duson Lin duson...@emc.com.tw
Reviewed-by: Benson Leung
I am not able to use
i2c_register_board_info for these devices because of the requirement
to use "probe."
Currently, I am doing explicit instantiation of devices using
i2c_new_probed_device.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the
i2c_register_board_info for these devices because of the requirement
to use probe.
Currently, I am doing explicit instantiation of devices using
i2c_new_probed_device.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin wrote:
> This driver adds support for elan i2c/smbus touchpad found on some laptops PC
>
> Signed-off-by: Duson Lin
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this l
On Mon, Jan 6, 2014 at 7:08 PM, Duson Lin duson...@emc.com.tw wrote:
This driver adds support for elan i2c/smbus touchpad found on some laptops PC
Signed-off-by: Duson Lin duson...@emc.com.tw
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble
h a list of possible addresses when dealing with the atmel touch
device.
You can see the driver here :
drivers/platform/chrome/chromeos_laptop.c
Is there some way of getting the "probe" behavior while using
i2c_register_board_info?
--
Benson Leung
Software Engineer, Chrom* OS
bl
addresses when dealing with the atmel touch
device.
You can see the driver here :
drivers/platform/chrome/chromeos_laptop.c
Is there some way of getting the probe behavior while using
i2c_register_board_info?
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from
se on the other patches in the same directory.
Sounds good to me. Thanks for applying the patches.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
>
> Signed-off-by: Olof Johansson
> Cc: Benson Leung
Reviewed-by: Benson Leung
Thanks,
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
-off-by: Olof Johansson o...@lixom.net
Cc: Benson Leung ble...@chromium.org
Reviewed-by: Benson Leung ble...@chromium.org
Thanks,
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
on the other patches in the same directory.
Sounds good to me. Thanks for applying the patches.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
to make sure that the names of each of
the adapters correspond to how they are referred to on various
schematics and datasheets.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mess
that the names of each of
the adapters correspond to how they are referred to on various
schematics and datasheets.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
ut making
> any other changes, and adds appropriate Kconfig entries for the new
> directory. It also adds a MAINTAINERS entry for the new subdir.
>
> Signed-off-by: Olof Johansson
Reviewed-by: Benson Leung
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsub
making
any other changes, and adds appropriate Kconfig entries for the new
directory. It also adds a MAINTAINERS entry for the new subdir.
Signed-off-by: Olof Johansson o...@lixom.net
Reviewed-by: Benson Leung ble...@chromium.org
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
From: Duncan Laurie
Add the necessary PCI Device IDs to use the Haswell ULT
I2C controller in PCI mode.
Set the bus numbers to -1 so it will use dynamic assignment
rather than hardcoded.
Signed-off-by: Duncan Laurie
Signed-off-by: Benson Leung
---
v2: Changed Haswell bus_clk to 100Mhz
The adapter number will still be dynamically assigned.
Signed-off-by: Benson Leung
---
v2: Fixed warning.
v1: Initial
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
b/drivers/i2c/
Fixed 25Mhz clock instead of 100Mhz clock in 1/2 and a warning in 2/2.
[PATCH v2 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH v2 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
32,
>> + .clk_khz = 25000,
>
> The input clock for I2C in Haswell is 100MHz, not 25MHz.
Thanks for catching that. I will fix it.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe l
e to name them 0 and 1 since that's how they are referred
to on schematics.
In the chromeos_laptop driver, I do by-name matching of i2c busses to
find busses and instantiate devices, so there is value to have each
named something predictable.
--
Benson Leung
Software Engineer, Chrom* OS
ble
sensible to name them 0 and 1 since that's how they are referred
to on schematics.
In the chromeos_laptop driver, I do by-name matching of i2c busses to
find busses and instantiate devices, so there is value to have each
named something predictable.
--
Benson Leung
Software Engineer, Chrom* OS
,
+ .clk_khz = 25000,
The input clock for I2C in Haswell is 100MHz, not 25MHz.
Thanks for catching that. I will fix it.
--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Fixed 25Mhz clock instead of 100Mhz clock in 1/2 and a warning in 2/2.
[PATCH v2 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH v2 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
assigned.
Signed-off-by: Benson Leung ble...@chromium.org
---
v2: Fixed warning.
v1: Initial
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
b/drivers/i2c/busses/i2c
From: Duncan Laurie dlau...@chromium.org
Add the necessary PCI Device IDs to use the Haswell ULT
I2C controller in PCI mode.
Set the bus numbers to -1 so it will use dynamic assignment
rather than hardcoded.
Signed-off-by: Duncan Laurie dlau...@chromium.org
Signed-off-by: Benson Leung ble
The following patch series refactors the dmi check system and
returns -EPROBE_DEFER when an expected i2c adapter is not present
at probe time.
This will allow the touchpad, touchscreen, and light sensors on
Pixel to load even if the i915 DDC and PANEL buses are instantiated
after chromeos_laptop.
inits, the deferred
probe will instantiate the peripherals when the bus appears.
Signed-off-by: Benson Leung
Reviewed-by: Aaron Durbin
---
drivers/platform/x86/chromeos_laptop.c | 144 +++--
1 file changed, 101 insertions(+), 43 deletions(-)
diff --git a/drivers/platform
making it easier to add new boards.
Signed-off-by: Aaron Durbin
Signed-off-by: Benson Leung
---
drivers/platform/x86/chromeos_laptop.c | 197 +
1 file changed, 126 insertions(+), 71 deletions(-)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers
Add support for the trackpad on HP Chromebook 14.
Signed-off-by: Benson Leung
---
drivers/platform/x86/chromeos_laptop.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers/platform/x86/chromeos_laptop.c
index 57ded03..a9ab335
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
Signed-off-by: Benson Leung
---
drivers/platform/x86/chromeos_laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform
The designware-pci i2c busses will be named "i2c-designware-pci-0"
and "i2c-designware-pci-1" accordingly.
Signed-off-by: Benson Leung
---
drivers/platform/x86/chromeos_laptop.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
Add the Acer C720 entries for trackpad and light sensor.
Signed-off-by: Benson Leung
---
drivers/platform/x86/chromeos_laptop.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/platform/x86/chromeos_laptop.c
b/drivers/platform/x86/chromeos_laptop.c
index a9ab335
From: Duncan Laurie
Add the necessary PCI Device IDs to use the Haswell ULT
I2C controller in PCI mode.
Set the bus numbers to -1 so it will use dynamic assignment
rather than hardcoded.
Signed-off-by: Duncan Laurie
Signed-off-by: Benson Leung
---
drivers/i2c/busses/i2c-designware-pcidrv.c
Add the Haswell ULT device IDs for i2c-designware-pci. These are used,
for example, in Haswell generation Chromebooks, the HP Chromebook 14
and the Acer C720.
[PATCH 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To
The adapter number will still be dynamically assigned.
Signed-off-by: Benson Leung
---
drivers/i2c/busses/i2c-designware-pcidrv.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
b/drivers/i2c/busses/i2c-designware-pcidrv.c
Add the Haswell ULT device IDs for i2c-designware-pci. These are used,
for example, in Haswell generation Chromebooks, the HP Chromebook 14
and the Acer C720.
[PATCH 1/2] i2c-designware-pci: Add Haswell ULT device IDs
[PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0
--
To
501 - 600 of 755 matches
Mail list logo
