[PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0

2013-10-20 Thread Benson Leung
assigned. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/i2c/busses/i2c-designware-pcidrv.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c index e4cbbdf

[PATCH 1/2] i2c-designware-pci: Add Haswell ULT device IDs

2013-10-20 Thread Benson Leung
From: Duncan Laurie dlau...@chromium.org Add the necessary PCI Device IDs to use the Haswell ULT I2C controller in PCI mode. Set the bus numbers to -1 so it will use dynamic assignment rather than hardcoded. Signed-off-by: Duncan Laurie dlau...@chromium.org Signed-off-by: Benson Leung ble

[PATCH 4/6] Platform: x86: chromeos_laptop - Add names of Haswell ULT i2c busses

2013-10-20 Thread Benson Leung
The designware-pci i2c busses will be named i2c-designware-pci-0 and i2c-designware-pci-1 accordingly. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b

[PATCH 6/6] Platform: x86: chromeos_laptop - Add Acer C720

2013-10-20 Thread Benson Leung
Add the Acer C720 entries for trackpad and light sensor. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86

[PATCH 5/6] Platform: x86: chromeos_laptop - Add HP Chromebook 14

2013-10-20 Thread Benson Leung
Add support for the trackpad on HP Chromebook 14. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86/chromeos_laptop.c index

[PATCH 3/6] Platform: x86: chromeos_laptop - fix incorrect placement of __initdata tag

2013-10-20 Thread Benson Leung
__initdata tag should be placed between the variable name and equal sign for the variable to be placed in the intended .init.data section. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/6] Platform: x86: chromeos_laptop - Use deferred probing

2013-10-20 Thread Benson Leung
inits, the deferred probe will instantiate the peripherals when the bus appears. Signed-off-by: Benson Leung ble...@chromium.org Reviewed-by: Aaron Durbin adur...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 144 +++-- 1 file changed, 101 insertions(+), 43

[PATCH 1/6] Platform: x86: chromeos_laptop - Restructure device associations

2013-10-20 Thread Benson Leung
matching sequences as well making it easier to add new boards. Signed-off-by: Aaron Durbin adur...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 197 + 1 file changed, 126 insertions(+), 71 deletions(-) diff

[PATCH 0/6] Platform: x86: chromeos_laptop - Deferring and Haswell

2013-10-20 Thread Benson Leung
The following patch series refactors the dmi check system and returns -EPROBE_DEFER when an expected i2c adapter is not present at probe time. This will allow the touchpad, touchscreen, and light sensors on Pixel to load even if the i915 DDC and PANEL buses are instantiated after chromeos_laptop.

Re: [PATCH v2] usb: hub: Clear Port Reset Change during init/resume

2013-10-16 Thread Benson Leung
for > stable), or if this is just a precaution. We ran into this on HP Chromebook 14 (Falco). The port reset flag would be set after a suspend/resume cycle with nothing attached. -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsu

Re: [PATCH v2] usb: hub: Clear Port Reset Change during init/resume

2013-10-16 Thread Benson Leung
for stable), or if this is just a precaution. We ran into this on HP Chromebook 14 (Falco). The port reset flag would be set after a suspend/resume cycle with nothing attached. -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line

Re: [PATCH] driver core : Fix use after free of dev->parent in device_shutdown

2013-09-24 Thread Benson Leung
On Tue, Sep 24, 2013 at 6:14 PM, Ming Lei wrote: > It is better to save one line by below: > > parent = get_device(dev->parent); > Done. > > Reviewed-by: Ming Lei Thank you! -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsub

[PATCH v2] driver core : Fix use after free of dev->parent in device_shutdown

2013-09-24 Thread Benson Leung
d9bb6c632a3ebe62e28440b Cc: sta...@vger.kernel.org Signed-off-by: Benson Leung Reviewed-by: Ming Lei --- v2 : Saved a few lines as suggested by Ming Lei. v1 : Initial --- drivers/base/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/base/core.c b/d

[PATCH] driver core : Fix use after free of dev->parent in device_shutdown

2013-09-24 Thread Benson Leung
d9bb6c632a3ebe62e28440b Cc: sta...@vger.kernel.org Signed-off-by: Benson Leung --- drivers/base/core.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index c7cfadc..34bd546 100644 --- a/drivers/base/core.c +++ b/driver

[PATCH] driver core : Fix use after free of dev-parent in device_shutdown

2013-09-24 Thread Benson Leung
...@vger.kernel.org Signed-off-by: Benson Leung ble...@chromium.org --- drivers/base/core.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index c7cfadc..34bd546 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2026,6

[PATCH v2] driver core : Fix use after free of dev-parent in device_shutdown

2013-09-24 Thread Benson Leung
...@vger.kernel.org Signed-off-by: Benson Leung ble...@chromium.org Reviewed-by: Ming Lei ming@canonical.com --- v2 : Saved a few lines as suggested by Ming Lei. v1 : Initial --- drivers/base/core.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/base/core.c b

Re: [PATCH] driver core : Fix use after free of dev-parent in device_shutdown

2013-09-24 Thread Benson Leung
On Tue, Sep 24, 2013 at 6:14 PM, Ming Lei ming@canonical.com wrote: It is better to save one line by below: parent = get_device(dev-parent); Done. Reviewed-by: Ming Lei ming@canonical.com Thank you! -- Benson Leung Software Engineer, Chrom* OS ble

Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-19 Thread Benson Leung
ther allow three settings here (through a sysfs knob) - > key down, key up, key down or up. Thanks for your feedback. I agree with your suggestions. I will move this from platform data and DT to a sysfs property with three settings : rising, falling, both. -- Benson Leung Software Engine

Re: [PATCH] Input: gpio_keys - wakeup_trigger

2013-09-19 Thread Benson Leung
here (through a sysfs knob) - key down, key up, key down or up. Thanks for your feedback. I agree with your suggestions. I will move this from platform data and DT to a sysfs property with three settings : rising, falling, both. -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org

[PATCH] Input: gpio_keys - wakeup_trigger

2013-09-13 Thread Benson Leung
Allow wakeup_trigger to be defined per gpio button. Currently, all gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. It may be more appropriate to only wake the system on one edge, for example if the gpio is for a Lid Switch. Signed-off-by: Benson Leung --- .../devicetree

[PATCH] Input: gpio_keys - wakeup_trigger

2013-09-13 Thread Benson Leung
Allow wakeup_trigger to be defined per gpio button. Currently, all gpio buttons are set up as IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING. It may be more appropriate to only wake the system on one edge, for example if the gpio is for a Lid Switch. Signed-off-by: Benson Leung ble...@chromium.org

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-11 Thread Benson Leung
orks > as designed. I would prefer to have priority lowered to 'notice' on > those. Sounds good to me. I'll make this change. Thanks again! Benson -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-11 Thread Benson Leung
to have priority lowered to 'notice' on those. Sounds good to me. I'll make this change. Thanks again! Benson -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-07 Thread Benson Leung
ocumentation. > > Thank you again for reviewing the patch and for providing feedback. No problem at all. Thank you for your interest in our project, actually! If you get a chance, could you let me know if my deferred probe changes work well in your configuration? -- Benson Leung

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-07 Thread Benson Leung
. Thank you again for reviewing the patch and for providing feedback. No problem at all. Thank you for your interest in our project, actually! If you get a chance, could you let me know if my deferred probe changes work well in your configuration? -- Benson Leung Software Engineer, Chrom* OS ble

Re: [PATCH 0/2] Platform: x86: chromeos_laptop - Deferred Probing

2013-08-04 Thread Benson Leung
pproach for all supported i2c adapters. The approach may work for Pixel, but as I mentioned in my other email, it causes failed probes on other systems. It would be my preference to continue to use i2c_new_probed_device, and explicitly describe each Chromebook system -- Benson Leung Software Engineer

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-04 Thread Benson Leung
> Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 > race > > drivers/platform/x86/chromeos_laptop.c | 426 > +++- > 1 file changed, 194 insertions(+), 232 deletions(-) > > -- > 1.7.10.4 > -- Benson Leung

Re: [PATCH 0/1] Platform: x86: chromeos_laptop - convert to i2c_driver to handle i915 race

2013-08-04 Thread Benson Leung
+++- 1 file changed, 194 insertions(+), 232 deletions(-) -- 1.7.10.4 -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/2] Platform: x86: chromeos_laptop - Deferred Probing

2013-08-04 Thread Benson Leung
for all supported i2c adapters. The approach may work for Pixel, but as I mentioned in my other email, it causes failed probes on other systems. It would be my preference to continue to use i2c_new_probed_device, and explicitly describe each Chromebook system -- Benson Leung Software Engineer

[PATCH 2/2] Platform: x86: chromeos_laptop - Use deferred probing

2013-07-17 Thread Benson Leung
inits, the deferred probe will instantiate the peripherals when the bus appears. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 139 +++-- 1 file changed, 98 insertions(+), 41 deletions(-) diff --git a/drivers/platform/x86/chromeos_laptop.c b

[PATCH 1/2] Platform: x86: chromeos_laptop - Restructure device associations

2013-07-17 Thread Benson Leung
making it easier to add new boards. Signed-off-by: Aaron Durbin Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 197 + 1 file changed, 126 insertions(+), 71 deletions(-) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 0/2] Platform: x86: chromeos_laptop - Deferred Probing

2013-07-17 Thread Benson Leung
The following patch series refactors the dmi check system and returns -EPROBE_DEFER when an expected i2c adapter is not present at probe time. This will allow the touchpad, touchscreen, and light sensors on Pixel to load even if the i915 DDC and PANEL buses are instantiated after chromeos_laptop.

[PATCH 0/2] Platform: x86: chromeos_laptop - Deferred Probing

2013-07-17 Thread Benson Leung
The following patch series refactors the dmi check system and returns -EPROBE_DEFER when an expected i2c adapter is not present at probe time. This will allow the touchpad, touchscreen, and light sensors on Pixel to load even if the i915 DDC and PANEL buses are instantiated after chromeos_laptop.

[PATCH 2/2] Platform: x86: chromeos_laptop - Use deferred probing

2013-07-17 Thread Benson Leung
inits, the deferred probe will instantiate the peripherals when the bus appears. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 139 +++-- 1 file changed, 98 insertions(+), 41 deletions(-) diff --git a/drivers/platform/x86

[PATCH 1/2] Platform: x86: chromeos_laptop - Restructure device associations

2013-07-17 Thread Benson Leung
matching sequences as well making it easier to add new boards. Signed-off-by: Aaron Durbin adur...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 197 + 1 file changed, 126 insertions(+), 71 deletions(-) diff

Re: [PATCH] Platform: x86: chromeos_laptop: defer probing if no i2c busses found

2013-04-18 Thread Benson Leung
Acked-by: Benson Leung On Thu, Apr 18, 2013 at 2:55 PM, Olof Johansson wrote: > If chromeos_laptop is loaded before the DRM driver, the i2c busses will > not yet be available. Defer probe for that case and try again later. > > Trickling the error up to the module init function is u

Re: [PATCH] Platform: x86: chromeos_laptop: defer probing if no i2c busses found

2013-04-18 Thread Benson Leung
Acked-by: Benson Leung ble...@chromium.org On Thu, Apr 18, 2013 at 2:55 PM, Olof Johansson o...@lixom.net wrote: If chromeos_laptop is loaded before the DRM driver, the i2c busses will not yet be available. Defer probe for that case and try again later. Trickling the error up to the module

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-18 Thread Benson Leung
driver in input does it the same way. atmel_mxt_ts.c, which our team is actively working on as well, also has an update_fw sysfs for a lot of the same reasons. Thanks, -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-18 Thread Benson Leung
, which our team is actively working on as well, also has an update_fw sysfs for a lot of the same reasons. Thanks, -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Benson Leung
d filename, and sends the file to the driver using its sysfs entries. Userspace can initiate the firmware update procedure by copying cyapa.bin to /lib/firmware, and then writing anything to the device sysfs attribute: /sys/bus/i2c/devices/7-0067/update_fw Signed-off-by: Daniel Kurtz Signed-off-

[PATCH 4/4] Input: cyapa - Add sysfs attrs for product_id and fw version

2013-03-13 Thread Benson Leung
Add attributes to expose the product_id and firmware_version read from the device firmware. Signed-off-by: Dudley Du Signed-off-by: Benson Leung --- drivers/input/mouse/cyapa.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/input/mouse/cyapa.c b/drivers

[PATCH 3/4] Input: cyapa - Allow filename to be changed in update_fw

2013-03-13 Thread Benson Leung
Allow the name of the designated firmware to be passed as the argument to update_fw from user space. This will allow user space to specify which firmware to load. Signed-off-by: Benson Leung --- drivers/input/mouse/cyapa.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff

[PATCH 0/4] Input: cyapa - Add firmware update feature

2013-03-13 Thread Benson Leung
Add a feature to update trackpad firmware via request_firmware to cyapa. The last patch in the series adds sysfs attributses useful for version and product identification that a user mode utility will need to keep track of the current firmware on the device. This is used today on Chromebook

[PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-13 Thread Benson Leung
cyapa_check_is_operational and cyapa_create_input_dev are common to the probe and firmware update paths. Pull those out into cyapa_detect. Signed-off-by: Benson Leung --- drivers/input/mouse/cyapa.c | 57 +++-- 1 file changed, 39 insertions(+), 18

[PATCH 0/4] Input: cyapa - Add firmware update feature

2013-03-13 Thread Benson Leung
Add a feature to update trackpad firmware via request_firmware to cyapa. The last patch in the series adds sysfs attributses useful for version and product identification that a user mode utility will need to keep track of the current firmware on the device. This is used today on Chromebook

[PATCH 1/4] Input: cyapa - Move common initialization to cyapa_detect

2013-03-13 Thread Benson Leung
cyapa_check_is_operational and cyapa_create_input_dev are common to the probe and firmware update paths. Pull those out into cyapa_detect. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 57 +++-- 1 file changed, 39

[PATCH 3/4] Input: cyapa - Allow filename to be changed in update_fw

2013-03-13 Thread Benson Leung
Allow the name of the designated firmware to be passed as the argument to update_fw from user space. This will allow user space to specify which firmware to load. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 9 - 1 file changed, 8 insertions(+), 1

[PATCH 4/4] Input: cyapa - Add sysfs attrs for product_id and fw version

2013-03-13 Thread Benson Leung
Add attributes to expose the product_id and firmware_version read from the device firmware. Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 24 1 file changed, 24 insertions(+) diff --git

[PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Benson Leung
...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/cyapa.c | 351 1 file changed, 351 insertions(+) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index a631aca..e622c25 100644 --- a/drivers

Re: [PATCH v3 1/2] Input: atmel_mxt_ts - Support for touchpad variant

2013-03-07 Thread Benson Leung
On Thu, Mar 7, 2013 at 7:43 PM, Benson Leung wrote: > +static void mxt_input_button(struct mxt_data *data, struct mxt_message > *message) > +{ > + struct device *dev = >client->dev; Oops. I missed a warning: unused variable 'dev' here. > + struct input_dev *in

[PATCH v3 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-07 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung Tested-by: Olof Johansson --- v3: Add key map for the mXT224SL used

[PATCH v3 1/2] Input: atmel_mxt_ts - Support for touchpad variant

2013-03-07 Thread Benson Leung
m data key_map array. key_map[x] should contain the KEY or BTN code to send when processing GPIOx from T19. To specify a GPIO as not an input source, populate with KEY_RESERVED, or 0. Signed-off-by: Daniel Kurtz Signed-off-by: Benson Leung Signed-off-by: Nick Dyer Tested-by: Olof Johansson --- v

[PATCH v3 0/2] Add platform data and touchpad functionality for Pixel

2013-03-07 Thread Benson Leung
Add support for a touchpad variant in the atmel_mxt_ts driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. v3 : Add platform data for is_tp and key_map. Remove dependence

[PATCH v3 0/2] Add platform data and touchpad functionality for Pixel

2013-03-07 Thread Benson Leung
Add support for a touchpad variant in the atmel_mxt_ts driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. v3 : Add platform data for is_tp and key_map. Remove dependence

[PATCH v3 1/2] Input: atmel_mxt_ts - Support for touchpad variant

2013-03-07 Thread Benson Leung
data key_map array. key_map[x] should contain the KEY or BTN code to send when processing GPIOx from T19. To specify a GPIO as not an input source, populate with KEY_RESERVED, or 0. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org Signed-off

[PATCH v3 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-07 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung ble...@chromium.org Tested-by: Olof Johansson o...@lixom.net --- v3: Add

Re: [PATCH v3 1/2] Input: atmel_mxt_ts - Support for touchpad variant

2013-03-07 Thread Benson Leung
On Thu, Mar 7, 2013 at 7:43 PM, Benson Leung ble...@chromium.org wrote: +static void mxt_input_button(struct mxt_data *data, struct mxt_message *message) +{ + struct device *dev = data-client-dev; Oops. I missed a warning: unused variable 'dev' here. + struct input_dev *input

Re: v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-06 Thread Benson Leung
Hi Daniel, I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's looking good. No suspicious timeouts. Thanks for the quick response! Benson On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter wrote: > On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung wrote: >> I'm working

Re: v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-06 Thread Benson Leung
Hi Daniel, I've just tried drm-intel-fixes merged into v3.9-rc1, and so far it's looking good. No suspicious timeouts. Thanks for the quick response! Benson On Wed, Mar 6, 2013 at 12:14 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Wed, Mar 6, 2013 at 3:35 AM, Benson Leung ble

[PATCH v2 1/2] Input: atmel_mxt_ts - add device id for touchpad variant

2013-03-05 Thread Benson Leung
g forward, platform data should specify the configuration of the buttons. They can be configured via a future platform data change to specify optional middle and right buttons, as well as other possible uses for the GPIO object T19. Signed-off-by: Daniel Kurtz Signed-off-by: Benson Leung Signed-o

[PATCH v2 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-05 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung Tested-by: Olof Johansson --- v2: Patches cleanly with v3.9-rc1 v1

[PATCH v2 0/2] Add platform data and touchpad functionality for Pixel

2013-03-05 Thread Benson Leung
Add support for an "atmel_mxt_tp" variant in the atmel_mxt_ts.c driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. v2 : Minor bugfix in patch 1. Cleanup client_id from

v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-05 Thread Benson Leung
driven gmbus is now as fast as with busy-looping gmbus at 28 ms here (with negligible cpu overhead). Reviewed-by: Imre Deak Signed-off-by: Daniel Vetter Is there anything I can do to help debug this some more? -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org --

v3.9-rc1 instability on Chromebook Pixel with gmbus irq

2013-03-05 Thread Benson Leung
gmbus is now as fast as with busy-looping gmbus at 28 ms here (with negligible cpu overhead). Reviewed-by: Imre Deak imre.d...@intel.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Is there anything I can do to help debug this some more? -- Benson Leung Software Engineer

[PATCH v2 0/2] Add platform data and touchpad functionality for Pixel

2013-03-05 Thread Benson Leung
Add support for an atmel_mxt_tp variant in the atmel_mxt_ts.c driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. v2 : Minor bugfix in patch 1. Cleanup client_id from

[PATCH v2 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-05 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung ble...@chromium.org Tested-by: Olof Johansson o...@lixom.net --- v2

[PATCH v2 1/2] Input: atmel_mxt_ts - add device id for touchpad variant

2013-03-05 Thread Benson Leung
, platform data should specify the configuration of the buttons. They can be configured via a future platform data change to specify optional middle and right buttons, as well as other possible uses for the GPIO object T19. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Benson Leung ble

[PATCH 1/2] Input: atmel_mxt_ts - add device id for touchpad variant

2013-03-01 Thread Benson Leung
g forward, platform data should specify the configuration of the buttons. They can be configured via a future platform data change to specify optional middle and right buttons, as well as other possible uses for the GPIO object T19. Signed-off-by: Daniel Kurtz Signed-off-by:

[PATCH 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-01 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung Change-Id: I712bf4726fb4b194fbde44ad200c54d13dc3bdb9 --- drivers

[PATCH 0/2] Add platform data and touchpad functionality for Pixel

2013-03-01 Thread Benson Leung
Add support for an "atmel_mxt_tp" variant in the atmel_mxt_ts.c driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. [PATCH 1/2] Input: atmel_mxt_ts - add device id for

[PATCH 0/2] Add platform data and touchpad functionality for Pixel

2013-03-01 Thread Benson Leung
Add support for an atmel_mxt_tp variant in the atmel_mxt_ts.c driver. Then, add platform data for the 224s trackpad and the 1664s touchscreen in chromeos_laptop so that the existing version of the driver will probe these devices correctly. [PATCH 1/2] Input: atmel_mxt_ts - add device id for

[PATCH 2/2] Platform: x86: chromeos_laptop : Add basic platform data for atmel devices

2013-03-01 Thread Benson Leung
Add basic platform data to get the current upstream driver working with the 224s touchpad and 1664s touchscreen. We will be using NULL config so we will use the settings from the devices' NVRAMs. Signed-off-by: Benson Leung ble...@chromium.org Change-Id: I712bf4726fb4b194fbde44ad200c54d13dc3bdb9

[PATCH 1/2] Input: atmel_mxt_ts - add device id for touchpad variant

2013-03-01 Thread Benson Leung
, platform data should specify the configuration of the buttons. They can be configured via a future platform data change to specify optional middle and right buttons, as well as other possible uses for the GPIO object T19. Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Benson Leung ble

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
+ while ((timeout_counter++ <= count) && data->pdata->read_chg()) > + udelay(20); > + > + if (timeout_counter > count) { > + dev_err(>client->dev, "mxt_wait_for_chg() timeout!\n"); > + return -EIO; >

Re: [PATCH 01/40] Input: atmel_mxt_ts - Make wait-after-reset period compatible with all chips

2013-02-22 Thread Benson Leung
ode */ > - mxt_write_object(data, MXT_GEN_COMMAND_T6, > - MXT_COMMAND_RESET, MXT_BOOT_VALUE); > - msleep(MXT_RESET_TIME); > + ret = mxt_soft_reset(data, MXT_BOOT_VALUE); > + if (ret) > + return ret; > >

Re: [PATCH 11/40] Input: atmel_mxt_ts - Bootloader addresses for mXT1664/mXT1188S

2013-02-22 Thread Benson Leung
the atmel touch device, and it doesn't and shouldn't know about how atmel_mxt_ts's platform data is structured. All it does is i2c_new_device on the right adapter, at the right address, and optionally pass in an irq #. On Fri, Feb 22, 2013 at 11:51 AM, Nick Dyer wrote: > Benson Leung wr

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
@ -1818,6 +1842,7 @@ static int mxt_load_fw(struct device *dev, const char > *fn) > goto release_firmware; > } > > + mxt_wait_for_chg(data); > ret = mxt_check_bootloader(data, MXT_FRAME_CRC_PASS); > if

Re: [PATCH 11/40] Input: atmel_mxt_ts - Bootloader addresses for mXT1664/mXT1188S

2013-02-22 Thread Benson Leung
> +#else > { 0x24, 0x4a }, > { 0x25, 0x4b }, > { 0x26, 0x4c }, > { 0x27, 0x4d }, > { 0x34, 0x5a }, > { 0x35, 0x5b }, > +#endif > }; > > static bool mxt_object_readable(unsigned int type) > -- > 1.7.10.4 > -- B

Re: [PATCH 11/40] Input: atmel_mxt_ts - Bootloader addresses for mXT1664/mXT1188S

2013-02-22 Thread Benson Leung
}, { 0x25, 0x4b }, { 0x26, 0x4c }, { 0x27, 0x4d }, { 0x34, 0x5a }, { 0x35, 0x5b }, +#endif }; static bool mxt_object_readable(unsigned int type) -- 1.7.10.4 -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
device *dev, const char *fn) goto release_firmware; } + mxt_wait_for_chg(data); ret = mxt_check_bootloader(data, MXT_FRAME_CRC_PASS); if (ret) { retry++; -- 1.7.10.4 -- Benson

Re: [PATCH 11/40] Input: atmel_mxt_ts - Bootloader addresses for mXT1664/mXT1188S

2013-02-22 Thread Benson Leung
, we use the same atmel_mxt_ts driver for a 1664S device and a 224SL. The 1664S has the pair 0x26 and 0x4a, while the 224SL has 0x25 and 0x4b. If I put a bootloader address override in the platform data will that meet your requirements? -- Benson Leung Software Engineer, Chrom* OS ble

Re: [PATCH 01/40] Input: atmel_mxt_ts - Make wait-after-reset period compatible with all chips

2013-02-22 Thread Benson Leung
; unsigned long irqflags; + u8(*read_chg) (void); }; #endif /* __LINUX_ATMEL_MXT_TS_H */ -- 1.7.10.4 -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 28/40] Input: atmel_mxt_ts - Add CHG line handling in bootloader code

2013-02-22 Thread Benson Leung
); + + if (timeout_counter count) { + dev_err(data-client-dev, mxt_wait_for_chg() timeout!\n); + return -EIO; + } + + return 0; +} + -- 1.7.10.4 -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list

[PATCH 1/6] Platform: x86: chromeos_laptop - add i915 gmbuses to adapter names

2013-02-21 Thread Benson Leung
Add the two other i2c buses (vga and panel) from i915. Chromebook Pixel has input and light sensor devices on these busses. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b

[PATCH 3/6] Platform: x86: chromeos_laptop - Add isl light sensor for Pixel

2013-02-21 Thread Benson Leung
The Chromebook Pixel uses an isl29023 ambient light sensor on the PANEL GMBus. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86

[PATCH 0/6] Platform: x86: chromeos_laptop - Add support for Chromebook Pixel

2013-02-21 Thread Benson Leung
The following patch series will add support for the isl light sensor, atmel mxt touchpad, and atmel mxt touchscreen on the Chromebook Pixel. [PATCH 1/6] Platform: x86: chromeos_laptop - add i915 gmbuses to [PATCH 2/6] Platform: x86: chromeos_laptop - Add a more general [PATCH 3/6] Platform: x86:

[PATCH 6/6] Platform: x86: chromeos_laptop - Add Pixel Touchscreen

2013-02-21 Thread Benson Leung
From: Yufeng Shen Instantiate the atmel mxt1664s touchscreen on this system. The touchscreen may appear at two possible addresses: 0x4a in operational mode. 0x26 in bootloader mode. Signed-off-by: Yufeng Shen Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 31

[PATCH 4/6] Platform: x86: chromeos_laptop - Add support for probing devices

2013-02-21 Thread Benson Leung
This will allow support for devices that may appear at more than one i2c address at boot time. The specific example is the atmel_mxt touch devices, which may appear at a different address if it comes up in bootloader mode. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c

[PATCH 5/6] Platform: x86: chromeos_laptop - Add Pixel Trackpad

2013-02-21 Thread Benson Leung
Instantiate the atmel mxt224s trackpad on this system. The trackpad may appear at two possible addresses: 0x4b in operational mode. 0x25 in bootloader mode. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 29 + 1 file changed, 29 insertions

[PATCH 2/6] Platform: x86: chromeos_laptop - Add a more general add_i2c_device

2013-02-21 Thread Benson Leung
This will allow us to assign devices to buses by the type enum. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86

[PATCH 2/6] Platform: x86: chromeos_laptop - Add a more general add_i2c_device

2013-02-21 Thread Benson Leung
This will allow us to assign devices to buses by the type enum. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 5/6] Platform: x86: chromeos_laptop - Add Pixel Trackpad

2013-02-21 Thread Benson Leung
Instantiate the atmel mxt224s trackpad on this system. The trackpad may appear at two possible addresses: 0x4b in operational mode. 0x25 in bootloader mode. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 29 + 1 file

[PATCH 4/6] Platform: x86: chromeos_laptop - Add support for probing devices

2013-02-21 Thread Benson Leung
This will allow support for devices that may appear at more than one i2c address at boot time. The specific example is the atmel_mxt touch devices, which may appear at a different address if it comes up in bootloader mode. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86

[PATCH 6/6] Platform: x86: chromeos_laptop - Add Pixel Touchscreen

2013-02-21 Thread Benson Leung
From: Yufeng Shen mile...@chromium.org Instantiate the atmel mxt1664s touchscreen on this system. The touchscreen may appear at two possible addresses: 0x4a in operational mode. 0x26 in bootloader mode. Signed-off-by: Yufeng Shen mile...@chromium.org Signed-off-by: Benson Leung ble

[PATCH 0/6] Platform: x86: chromeos_laptop - Add support for Chromebook Pixel

2013-02-21 Thread Benson Leung
The following patch series will add support for the isl light sensor, atmel mxt touchpad, and atmel mxt touchscreen on the Chromebook Pixel. [PATCH 1/6] Platform: x86: chromeos_laptop - add i915 gmbuses to [PATCH 2/6] Platform: x86: chromeos_laptop - Add a more general [PATCH 3/6] Platform: x86:

[PATCH 3/6] Platform: x86: chromeos_laptop - Add isl light sensor for Pixel

2013-02-21 Thread Benson Leung
The Chromebook Pixel uses an isl29023 ambient light sensor on the PANEL GMBus. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 1/6] Platform: x86: chromeos_laptop - add i915 gmbuses to adapter names

2013-02-21 Thread Benson Leung
Add the two other i2c buses (vga and panel) from i915. Chromebook Pixel has input and light sensor devices on these busses. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86

[PATCH v4 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-19 Thread Benson Leung
-by: Benson Leung Signed-off-by: Mike Frysinger --- v4 : Cleaned up checkpatch.pl style errors. Used vapier's newer better cpuid. v3 : No changes. v2 : make cpuid static inline. Remove unused eax from validate_cpuid and clean up return variables from cpuid(). --- .../x86_energy_perf_policy.c

[PATCH v4 0/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-19 Thread Benson Leung
Thanks Len and Mike for your comments. I've fixed the style problems so this is now checkpatch clean. I've also moved to Mike's better cpuid from ltp. Thanks, Benson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

[PATCH v4 0/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-19 Thread Benson Leung
Thanks Len and Mike for your comments. I've fixed the style problems so this is now checkpatch clean. I've also moved to Mike's better cpuid from ltp. Thanks, Benson -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

<    2   3   4   5   6   7   8   >