[PATCH v4 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-19 Thread Benson Leung
-by: Benson Leung ble...@chromium.org Signed-off-by: Mike Frysinger vap...@gentoo.org --- v4 : Cleaned up checkpatch.pl style errors. Used vapier's newer better cpuid. v3 : No changes. v2 : make cpuid static inline. Remove unused eax from validate_cpuid and clean up return variables from cpuid

[PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-14 Thread Benson Leung
x86_energy_perf_policy reads cpuid using the cpuid instruction. On i686, when building with PIC, this clobbers ebx, the PIC register. Fixed using the same cpuid accessor function that vap...@gentoo.org created for i7z: http://code.google.com/p/i7z/issues/detail?id=31 Signed-off-by: Benson Leung

[PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-14 Thread Benson Leung
Hi Len, Please take a look at this patch to the x86_energy_perf_policy that allows the tool to work when built for i686 with PIC enabled. Thanks, Benson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-02-14 Thread Benson Leung
Thanks again, Dmitry and Henrik! On Thu, Feb 14, 2013 at 9:19 AM, Henrik Rydberg wrote: > On Wed, Feb 13, 2013 at 08:26:35PM -0800, Dmitry Torokhov wrote: >> On Sun, Feb 10, 2013 at 12:15:40PM -0800, Benson Leung wrote: >> > This patch adds support for the Cypress APA S

Re: [PATCH v2 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-02-14 Thread Benson Leung
Thanks again, Dmitry and Henrik! On Thu, Feb 14, 2013 at 9:19 AM, Henrik Rydberg rydb...@euromail.se wrote: On Wed, Feb 13, 2013 at 08:26:35PM -0800, Dmitry Torokhov wrote: On Sun, Feb 10, 2013 at 12:15:40PM -0800, Benson Leung wrote: This patch adds support for the Cypress APA Smbus

[PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-14 Thread Benson Leung
Hi Len, Please take a look at this patch to the x86_energy_perf_policy that allows the tool to work when built for i686 with PIC enabled. Thanks, Benson -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid for i686

2013-02-14 Thread Benson Leung
x86_energy_perf_policy reads cpuid using the cpuid instruction. On i686, when building with PIC, this clobbers ebx, the PIC register. Fixed using the same cpuid accessor function that vap...@gentoo.org created for i7z: http://code.google.com/p/i7z/issues/detail?id=31 Signed-off-by: Benson Leung

Re: [PATCH 04/10] Input: atmel_mxt_ts - handle bootloader mode at probe

2013-02-13 Thread Benson Leung
e paths that would try >> to access the as-yet uninitialized object table or input device. >> In particular: >> 1) mxt_remove calls input_unregister_device on input_dev. >> 2) mxt_suspend/resume reads and writes from the object table. >> 3) Spurious or bootl

Re: [PATCH 04/10] Input: atmel_mxt_ts - handle bootloader mode at probe

2013-02-13 Thread Benson Leung
object table or input device. In particular: 1) mxt_remove calls input_unregister_device on input_dev. 2) mxt_suspend/resume reads and writes from the object table. 3) Spurious or bootloader induced interrupts Signed-off-by: Benson Leung ble...@chromium.org Signed-off-by: Daniel Kurtz djku

[PATCH 1/1] Platform: x86: chromeos_laptop - Add HP Pavilion 14

2013-02-10 Thread Benson Leung
Add support for the HP Pavilion 14 Chromebook's trackpad, which is a reuse of the Samsung Series 5 550 trackpad. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 0/1] Platform: x86: chromeos_laptop - Add HP Pavilion 14

2013-02-10 Thread Benson Leung
This patch will add an entry for one more Chromebook that was released last week: HP's Pavilion 14 Chromebook. This will instatiate that system's Cypress APA trackpad, very similar to the one in the Samsung 550 and Acer C7. This should be merged after the previous patch series of 4: Platform:

[PATCH v2 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-02-10 Thread Benson Leung
trackpad CYTRA-101003-00 - HP Pavilion 14 Chromebook trackpad Signed-off-by: Dudley Du Signed-off-by: Benson Leung Reviewed-by: Daniel Kurtz --- v2 : Minor style cleanup. Removed unused struct device *dev declarations. --- drivers/input/mouse/cyapa.c | 180

[PATCH v2 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-02-10 Thread Benson Leung
trackpad CYTRA-101003-00 - HP Pavilion 14 Chromebook trackpad Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Benson Leung ble...@chromium.org Reviewed-by: Daniel Kurtz djku...@chromium.org --- v2 : Minor style cleanup. Removed unused struct device *dev declarations. --- drivers/input/mouse

[PATCH 0/1] Platform: x86: chromeos_laptop - Add HP Pavilion 14

2013-02-10 Thread Benson Leung
This patch will add an entry for one more Chromebook that was released last week: HP's Pavilion 14 Chromebook. This will instatiate that system's Cypress APA trackpad, very similar to the one in the Samsung 550 and Acer C7. This should be merged after the previous patch series of 4: Platform:

[PATCH 1/1] Platform: x86: chromeos_laptop - Add HP Pavilion 14

2013-02-10 Thread Benson Leung
Add support for the HP Pavilion 14 Chromebook's trackpad, which is a reuse of the Samsung Series 5 550 trackpad. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86

[PATCH 2/4] Platform: x86: chromeos_laptop - Add Acer C7 trackpad

2013-02-01 Thread Benson Leung
Add support for the Acer C7's trackpad, which is a reuse of the Samsung Series 5 550 trackpad. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers/platform/x86

[PATCH 4/4] Platform: x86: chromeos_laptop - Add Taos tsl2583 device

2013-02-01 Thread Benson Leung
The Samsung Series 5 Chromebook is equipped with a Taos tsl2583 light sensor. Instatiate it here. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 1/4] Platform: x86: chromeos_laptop - Rename setup_lumpy_tp to setup_cyapa_smbus_tp

2013-02-01 Thread Benson Leung
The Cypress trackpad on smbus is used on other systems as well. Lets make the name more generic. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 3/4] Platform: x86: chromeos_laptop - Add Taos tsl2563 device

2013-02-01 Thread Benson Leung
Two legacy Chromebooks, the Cr-48, and the Acer AC700, are equipped with a Taos tsl2563 light sensor. This will instantiate the sensor on those laptops. Signed-off-by: Benson Leung --- drivers/platform/x86/chromeos_laptop.c | 26 ++ 1 file changed, 26 insertions(+) diff

[PATCH 0/4] Platform: x86: chromeos_laptop - Add more x86 Chromebooks

2013-02-01 Thread Benson Leung
This patch series will add support for the following devices on the following laptops: Acer C7 Chromebook - Cypress APA Smbus Trackpad Acer AC700 - Taos tsl2563 light sensor Samsung Series 5 Chromebook - Taos tsl2583 light sensor Cr-48 - Taos tsl2563 light sensor Cheers, Benson -- To

[PATCH 0/4] Platform: x86: chromeos_laptop - Add more x86 Chromebooks

2013-02-01 Thread Benson Leung
This patch series will add support for the following devices on the following laptops: Acer C7 Chromebook - Cypress APA Smbus Trackpad Acer AC700 - Taos tsl2563 light sensor Samsung Series 5 Chromebook - Taos tsl2583 light sensor Cr-48 - Taos tsl2563 light sensor Cheers, Benson -- To

[PATCH 1/4] Platform: x86: chromeos_laptop - Rename setup_lumpy_tp to setup_cyapa_smbus_tp

2013-02-01 Thread Benson Leung
The Cypress trackpad on smbus is used on other systems as well. Lets make the name more generic. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86

[PATCH 3/4] Platform: x86: chromeos_laptop - Add Taos tsl2563 device

2013-02-01 Thread Benson Leung
Two legacy Chromebooks, the Cr-48, and the Acer AC700, are equipped with a Taos tsl2563 light sensor. This will instantiate the sensor on those laptops. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 26 ++ 1 file changed, 26

[PATCH 4/4] Platform: x86: chromeos_laptop - Add Taos tsl2583 device

2013-02-01 Thread Benson Leung
The Samsung Series 5 Chromebook is equipped with a Taos tsl2583 light sensor. Instatiate it here. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/platform/x86

[PATCH 2/4] Platform: x86: chromeos_laptop - Add Acer C7 trackpad

2013-02-01 Thread Benson Leung
Add support for the Acer C7's trackpad, which is a reuse of the Samsung Series 5 550 trackpad. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/chromeos_laptop.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/chromeos_laptop.c b/drivers

[PATCH 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-01-31 Thread Benson Leung
trackpad Signed-off-by: Dudley Du Signed-off-by: Benson Leung Reviewed-by: Daniel Kurtz --- drivers/input/mouse/cyapa.c | 184 ++-- 1 file changed, 179 insertions(+), 5 deletions(-) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index

[PATCH 1/1] Input: mouse: cyapa - Add support for cyapa smbus protocol

2013-01-31 Thread Benson Leung
trackpad Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Benson Leung ble...@chromium.org Reviewed-by: Daniel Kurtz djku...@chromium.org --- drivers/input/mouse/cyapa.c | 184 ++-- 1 file changed, 179 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH v3 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-13 Thread Benson Leung
Thanks Henrik. Hello Dmitry, do you have any comments on V3? On Sat, Dec 8, 2012 at 4:42 AM, Henrik Rydberg wrote: > On Fri, Dec 07, 2012 at 03:24:16PM -0800, Benson Leung wrote: >> This patch introduces a driver for Cypress All Points Addressable >> I2C Trackpad, including t

Re: [PATCH v3 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-13 Thread Benson Leung
Thanks Henrik. Hello Dmitry, do you have any comments on V3? On Sat, Dec 8, 2012 at 4:42 AM, Henrik Rydberg rydb...@euromail.se wrote: On Fri, Dec 07, 2012 at 03:24:16PM -0800, Benson Leung wrote: This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including

[PATCH v3 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du Signed-off-by: Daniel Kurtz Signed-off-by: Benson Leung

[PATCH v3 0/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
Thanks Dmitry, Jean, and Henrik. Here's V3, which I have confirms compiles on input-next, and works well on my Chromebook. v3 : * Handle pointer emulation and unused slots in core * Fix compile fail on 3.7 for input_mt_init_slots (Thanks Rydberg) * Set BUTTONPAD property only if is a

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
This device is compatible with MT protocol type B, providing identifiable >> contacts. >> >> Signed-off-by: Dudley Du >> Signed-off-by: Daniel Kurtz >> Signed-off-by: Benson Leung >> --- >> Version history : >> v2 : * Removed firmware upd

Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Daniel Kurtz djku...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- Version history : v2 : * Removed firmware update. * Removed sysfs properties related

[PATCH v3 0/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
Thanks Dmitry, Jean, and Henrik. Here's V3, which I have confirms compiles on input-next, and works well on my Chromebook. v3 : * Handle pointer emulation and unused slots in core * Fix compile fail on 3.7 for input_mt_init_slots (Thanks Rydberg) * Set BUTTONPAD property only if is a

[PATCH v3 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-07 Thread Benson Leung
...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- Version history : v3 : * Handle pointer emulation and unused slots in core * Fix compile fail on 3.7 for input_mt_init_slots (Thanks Rydberg) * Set BUTTONPAD property only if is a buttonpad based on capabilities. * Removed

[PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
This patch introduces a driver for Cypress All Points Addressable I2C Trackpad, including the ones in 2012 Samsung Chromebooks. This device is compatible with MT protocol type B, providing identifiable contacts. Signed-off-by: Dudley Du Signed-off-by: Daniel Kurtz Signed-off-by: Benson Leung

[PATCH v2 0/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
Thanks for the patience on this driver. I have stripped out firmware update, the sysfs properties around firmware version, hardware version, update_fw, and power state. I have incorporated rydberg's suggestions for cleanup. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH v2 0/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
Thanks for the patience on this driver. I have stripped out firmware update, the sysfs properties around firmware version, hardware version, update_fw, and power state. I have incorporated rydberg's suggestions for cleanup. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

[PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad

2012-12-05 Thread Benson Leung
...@chromium.org Signed-off-by: Benson Leung ble...@chromium.org --- Version history : v2 : * Removed firmware update. * Removed sysfs properties related to firmware update and power mode. * Folded cyapa_detect into cyapa_probe. * Added support for middle and right mechanical buttons

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-04 Thread Benson Leung
sary. >> >> Maybe I'm dense but I don't see how that could possibly be better than >> what the code does today. It would just add more overhead and clutter >> by creating a unnecessary dummy device/driver setup just to, in the >> end, register the same i2c device

Re: [PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-11-04 Thread Benson Leung
devices, it doesn't really matter. -- Corentin Chary http://xf.iksaif.net -- Benson Leung Software Engineer, Chrom* OS ble...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH v2 0/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-25 Thread Benson Leung
Spun another version of this patch. Thanks Coretin for your feedback. I've incorporated your suggestions. v2 : * Added MODULE_DEVICE_TABLE for the dmi table. * Made __init and __initdata position consistent across this file. * Made prefix static const char * * Made strncmp

[PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-25 Thread Benson Leung
This adds the chromeos_laptop driver. It supports the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient light sensor on the Samsung Series 5 550 Chromebook. Signed-off-by: Benson Leung Reviewed-by: Olof Johansson --- Version history : v2 : * Added MODULE_DEVICE_TABLE for the dmi

[PATCH v2 1/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-25 Thread Benson Leung
This adds the chromeos_laptop driver. It supports the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient light sensor on the Samsung Series 5 550 Chromebook. Signed-off-by: Benson Leung ble...@chromium.org Reviewed-by: Olof Johansson o...@lixom.net --- Version history : v2 : * Added

[PATCH v2 0/1] Platform: x86: Add Chrome OS Laptop driver

2012-10-25 Thread Benson Leung
Spun another version of this patch. Thanks Coretin for your feedback. I've incorporated your suggestions. v2 : * Added MODULE_DEVICE_TABLE for the dmi table. * Made __init and __initdata position consistent across this file. * Made prefix static const char * * Made strncmp

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
Actually, I take it back. It doesn't look like it's necessary. Benson On Mon, Jul 30, 2012 at 12:28 PM, Benson Leung wrote: > Hi Dmitry, > > Yes I see Neil's changes. Thank you for letting me know. > > By the way, looking at Neil's changes, would it make sense to check > for

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
at 10:50 PM, Dmitry Torokhov wrote: > Hi Benson, > > On Wed, Jul 25, 2012 at 11:11:53PM -0700, Benson Leung wrote: >> If a button is configured to wake the system, report a pm wakeup event. >> > > Thank you for your patch, however I applied more complete patch sent by &

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
at 10:50 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Hi Benson, On Wed, Jul 25, 2012 at 11:11:53PM -0700, Benson Leung wrote: If a button is configured to wake the system, report a pm wakeup event. Thank you for your patch, however I applied more complete patch sent by NeilBrown

Re: [PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-30 Thread Benson Leung
Actually, I take it back. It doesn't look like it's necessary. Benson On Mon, Jul 30, 2012 at 12:28 PM, Benson Leung ble...@chromium.org wrote: Hi Dmitry, Yes I see Neil's changes. Thank you for letting me know. By the way, looking at Neil's changes, would it make sense to check

[PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-26 Thread Benson Leung
If a button is configured to wake the system, report a pm wakeup event. Signed-off-by: Benson Leung --- drivers/input/keyboard/gpio_keys.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index

[PATCH] Input: gpio_keys - Report wakeup events if device may wakeup

2012-07-26 Thread Benson Leung
If a button is configured to wake the system, report a pm wakeup event. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/keyboard/gpio_keys.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard

[PATCH] Platform: x86: Add Chrome OS Laptop driver

2012-07-10 Thread Benson Leung
This adds the chromeos_laptop driver. It supports the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient light sensor on the Samsung Series 5 550 Chromebook. Signed-off-by: Benson Leung --- drivers/platform/x86/Kconfig | 11 ++ drivers/platform/x86/Makefile

[PATCH] Input: add driver for Cypress APA I2C Trackpad

2012-07-10 Thread Benson Leung
request_firmware. Signed-off-by: Dudley Du Signed-off-by: Benson Leung --- drivers/input/mouse/Kconfig | 13 + drivers/input/mouse/Makefile |1 + drivers/input/mouse/cyapa.c | 1493 ++ 3 files changed, 1507 insertions(+), 0 deletions(-) create mode 100644

[PATCH] Input: add driver for Cypress APA I2C Trackpad

2012-07-10 Thread Benson Leung
request_firmware. Signed-off-by: Dudley Du d...@cypress.com Signed-off-by: Benson Leung ble...@chromium.org --- drivers/input/mouse/Kconfig | 13 + drivers/input/mouse/Makefile |1 + drivers/input/mouse/cyapa.c | 1493 ++ 3 files changed, 1507 insertions(+), 0

[PATCH] Platform: x86: Add Chrome OS Laptop driver

2012-07-10 Thread Benson Leung
This adds the chromeos_laptop driver. It supports the Cypress APA SMBUS touchpad as well as the isl29018 i2c ambient light sensor on the Samsung Series 5 550 Chromebook. Signed-off-by: Benson Leung ble...@chromium.org --- drivers/platform/x86/Kconfig | 11 ++ drivers/platform/x86

<    3   4   5   6   7   8