RE: [init_mac80211_hwsim] BUG: unable to handle kernel paging request at cd1aa02c

2013-11-11 Thread Berg, Johannes
> [5.543416] ieee80211 phy0: Failed to select rate control algorithm > [5.543993] ieee80211 phy0: Failed to initialize rate control algorithm > [5.556937] mac80211_hwsim: ieee80211_register_hw failed (-2) > [5.557669] BUG: unable to handle kernel paging request at cd1aa02c > [

RE: [init_mac80211_hwsim] BUG: unable to handle kernel paging request at cd1aa02c

2013-11-11 Thread Berg, Johannes
[5.543416] ieee80211 phy0: Failed to select rate control algorithm [5.543993] ieee80211 phy0: Failed to initialize rate control algorithm [5.556937] mac80211_hwsim: ieee80211_register_hw failed (-2) [5.557669] BUG: unable to handle kernel paging request at cd1aa02c [

RE: [199/251] genetlink: fix family dump race

2013-09-11 Thread Berg, Johannes
> 3.6.11.9-rc1 stable review patch. > If anyone has any objections, please let me know. Yes, this patch is broken and we reverted it upstream. johannes -- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer:

RE: [199/251] genetlink: fix family dump race

2013-09-11 Thread Berg, Johannes
3.6.11.9-rc1 stable review patch. If anyone has any objections, please let me know. Yes, this patch is broken and we reverted it upstream. johannes -- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer:

RE: [ 00/34] 3.4.59-stable review

2013-08-20 Thread Berg, Johannes
> > Yeah, I'm trying to get that, but it's not clear to me how to fix it. > > Where did you apply it? It was going to need some fixes but when the > > first objection was raised I figured you were going to drop it for now > > completely? Sorry for the mess :-( > > You're right, I'll drop this for

RE: [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()

2013-08-20 Thread Berg, Johannes
> + if (need_locking) { > + /* genl_mutex could be already locked in genl_rcv_msg() */ > + rt = genl_family_find_byid(cb->nlh->nlmsg_type); > + need_locking = need_locking && rt->parallel_ops; > + } This is equivalent to reverting the patch because

RE: [ 00/34] 3.4.59-stable review

2013-08-20 Thread Berg, Johannes
> > [ 26/34] genetlink: fix family dump race > > Johannes, another strike against this patch :( > > Any chance on fixing it upstream and me sucking that fix in? Yeah, I'm trying to get that, but it's not clear to me how to fix it. Where did you apply it? It was going to need some fixes but

RE: [ 00/34] 3.4.59-stable review

2013-08-20 Thread Berg, Johannes
[ 26/34] genetlink: fix family dump race Johannes, another strike against this patch :( Any chance on fixing it upstream and me sucking that fix in? Yeah, I'm trying to get that, but it's not clear to me how to fix it. Where did you apply it? It was going to need some fixes but when the

RE: [PATCH next] netlink: prevent deadlock in ctrl_dumpfamily()

2013-08-20 Thread Berg, Johannes
+ if (need_locking) { + /* genl_mutex could be already locked in genl_rcv_msg() */ + rt = genl_family_find_byid(cb-nlh-nlmsg_type); + need_locking = need_locking rt-parallel_ops; + } This is equivalent to reverting the patch because parallel_ops

RE: [ 00/34] 3.4.59-stable review

2013-08-20 Thread Berg, Johannes
Yeah, I'm trying to get that, but it's not clear to me how to fix it. Where did you apply it? It was going to need some fixes but when the first objection was raised I figured you were going to drop it for now completely? Sorry for the mess :-( You're right, I'll drop this for 3.4, it

RE: linux-next: manual merge of the wireless-next tree with the wireless tree

2013-08-12 Thread Berg, Johannes
> I think I have this slightly different in wireless-testing. Johannes, please > review and advise... > > Today's linux-next merge of the wireless-next tree got a conflict in > > drivers/net/wireless/iwlwifi/pcie/trans.c between commit eabc4ac5d760 > > ("iwlwifi: pcie: disable L1 Active after

RE: [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes

2013-08-12 Thread Berg, Johannes
> Some debugfs write() operations of the MVM Firmware will ignore the count > argument, and will copy more bytes than what was specified. > Fix this by getting the right count of bytes. > > This will also honor restrictions put on the number of bytes to write. That makes some sense. > To be

RE: [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes

2013-08-12 Thread Berg, Johannes
Some debugfs write() operations of the MVM Firmware will ignore the count argument, and will copy more bytes than what was specified. Fix this by getting the right count of bytes. This will also honor restrictions put on the number of bytes to write. That makes some sense. To be consitant

RE: linux-next: manual merge of the wireless-next tree with the wireless tree

2013-08-12 Thread Berg, Johannes
I think I have this slightly different in wireless-testing. Johannes, please review and advise... Today's linux-next merge of the wireless-next tree got a conflict in drivers/net/wireless/iwlwifi/pcie/trans.c between commit eabc4ac5d760 (iwlwifi: pcie: disable L1 Active after

RE: linux-next: manual merge of the wireless-next tree with the net-next tree

2013-06-27 Thread Berg, Johannes
Hi Stephen, > Today's linux-next merge of the wireless-next tree got a conflict in > net/wireless/nl80211.c between merge commits from the net-next tree and > commit 86e8cf98de3e ("nl80211: use small state buffer for wiphy_dump") > from the wireless-next tree. Looks good, yes. > I think I fixed

RE: linux-next: manual merge of the wireless-next tree with the net-next tree

2013-06-27 Thread Berg, Johannes
Hi Stephen, Today's linux-next merge of the wireless-next tree got a conflict in net/wireless/nl80211.c between merge commits from the net-next tree and commit 86e8cf98de3e (nl80211: use small state buffer for wiphy_dump) from the wireless-next tree. Looks good, yes. I think I fixed it up

RE: [ 031/100] iwlwifi: always copy first 16 bytes of commands

2013-03-14 Thread Berg, Johannes
> > > /* and copy the data that needs to be copied */ > > > cmd_pos = offsetof(struct iwl_device_cmd, payload); > > > + copy_size = sizeof(out_cmd->hdr); > > > for (i = 0; i < IWL_MAX_CMD_TFDS; i++) { > > > - if (!cmd->len[i]) > > > + int copy = 0; > > > + > > > + if

RE: [ 031/100] iwlwifi: always copy first 16 bytes of commands

2013-03-14 Thread Berg, Johannes
/* and copy the data that needs to be copied */ cmd_pos = offsetof(struct iwl_device_cmd, payload); + copy_size = sizeof(out_cmd-hdr); for (i = 0; i IWL_MAX_CMD_TFDS; i++) { - if (!cmd-len[i]) + int copy = 0; + + if (!cmd-len)

RE: [sysfs_write_file] net/wireless/reg.c:144 suspicious rcu_dereference_protected() usage!

2013-01-15 Thread Berg, Johannes
> commit c492db370c17c428a0a58d3673294d4e99634b7d > Author: Johannes Berg > Date: Thu Dec 6 16:29:25 2012 +0100 > > regulatory: use RCU to protect last_request > > This will allow making freq_reg_info() lock-free. > > Acked-by: Luis R. Rodriguez > Signed-off-by: Johannes

RE: [sysfs_write_file] net/wireless/reg.c:144 suspicious rcu_dereference_protected() usage!

2013-01-15 Thread Berg, Johannes
commit c492db370c17c428a0a58d3673294d4e99634b7d Author: Johannes Berg johannes.b...@intel.com Date: Thu Dec 6 16:29:25 2012 +0100 regulatory: use RCU to protect last_request This will allow making freq_reg_info() lock-free. Acked-by: Luis R. Rodriguez

RE: 3.5.0 iwlagn AP crash...

2012-07-23 Thread Berg, Johannes
> > > BUG: unable to handle kernel NULL pointer dereference at (null) > > > IP: [] ieee80211_ave_rssi+0xd/0x50 [mac80211] > > > > From my debug kernel, sdata is clearly NULL: > > > > (gdb) list *0x815b74f8 > > 0x815b74f8 is in ieee80211_ave_rssi (net/mac80211/util.c:1801). > >

RE: 3.5.0 iwlagn AP crash...

2012-07-23 Thread Berg, Johannes
> > When running my Centrino Wireless-N 130 BGN (rev 0xb0) card in nl80211 > > AP mode with hostapd on linux 3.5.0, I immediately hit this fatal > > pagefault [1]. > > > > I can cook a debug kernel, reproduce, disassemble the code and do some > > quick analysis, if that helps get the ball rolling?

RE: 3.5.0 iwlagn AP crash...

2012-07-23 Thread Berg, Johannes
When running my Centrino Wireless-N 130 BGN (rev 0xb0) card in nl80211 AP mode with hostapd on linux 3.5.0, I immediately hit this fatal pagefault [1]. I can cook a debug kernel, reproduce, disassemble the code and do some quick analysis, if that helps get the ball rolling? BUG:

RE: 3.5.0 iwlagn AP crash...

2012-07-23 Thread Berg, Johannes
BUG: unable to handle kernel NULL pointer dereference at (null) IP: [a02e869d] ieee80211_ave_rssi+0xd/0x50 [mac80211] From my debug kernel, sdata is clearly NULL: (gdb) list *0x815b74f8 0x815b74f8 is in ieee80211_ave_rssi (net/mac80211/util.c:1801).