Cleaning up two existing checkpatch errors (and 2 warnings) in
device_sysfs.c since the file is being changed.
The change in acpi_device_setup_files() is changing spaces to a tab.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 16 +---
1 file changed, 9 insertions
exists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/drivers/acpi/devic
2->v3
Left some of the checkpatch warnings in place.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
ACPI/device_sysfs: Change _SUN and _STA show functions error return to EIO
ACPI/device_sysfs: Clean up checkpatch errors
drivers/acp
sysfs 'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sysfs.c
On 04/29/2016 02:19 PM, Rafael J. Wysocki wrote:
> On Fri, Apr 29, 2016 at 9:21 PM, Betty Dall wrote:
>> Cleaning up five existing checkpatch errors in device_sysfs.c since the
>> file is being changed.
>>
>> Signed-off-by: Betty Dall
>> ---
>
exists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/drivers/acpi/devic
Cleaning up five existing checkpatch errors in device_sysfs.c since the
file is being changed.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi
sysfs 'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sysfs.c
sysfs 'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
Change _SUN and _STA show functions error return to EIO
Clean up checkpatch errors
On 04/27/2016 03:19 PM, Rafael J. Wysocki wrote:
> On Wednesday, April 27, 2016 04:19:45 PM Dall, Betty wrote:
>> On 04/26/2016 02:39 PM, Rafael J. Wysocki wrote:
>>> On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote:
>>>> The ACPI _HRV object on the devic
On 04/26/2016 02:39 PM, Rafael J. Wysocki wrote:
> On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote:
>> The ACPI _HRV object on the device is used to supply Linux with
>> the device's hardware revision. This is an optional object. Add
>> sysfs support for the _
On 04/26/2016 02:33 PM, Rafael J. Wysocki wrote:
> On Wednesday, April 13, 2016 08:48:14 AM Betty Dall wrote:
>> The ACPI _HRV object on the device is used to supply Linux with
>> the device's hardware revision. This is an optional object. Add
>> sysfs support for the _
The ACPI _HRV object on the device is used to supply Linux with
the device's hardware revision. This is an optional object. Add
sysfs support for the _HRV object if it exists on the device.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file ch
The function atl1c_reset_pcie() does not check the return from
pci_find_ext_cabability() where it is getting the postion of the
PCI_EXT_CAP_ID_ERR. It is possible for the return to be 0.
Signed-off-by: Betty Dall
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c |8 +---
1 files
On Mon, 2013-12-16 at 12:51 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 4:16 PM, Betty Dall wrote:
> > On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
> >> On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall wrote:
> >> > There are three functions exported
irst is separate
from MCE/CMC firmware first. So, this patch looks good.
-Betty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall wrote:
> > There are three functions exported from aerdrv_core.c that could be
> > called when the system is in firmware first mode:
> > pci_enable
On Fri, 2013-12-13 at 15:16 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote:
> > aer_hest_parse() could pass a non-AER HEST error source to the function
> > hest_match_pci(). hest_match_pci() assumes that the HEST error sou
pdev->dev,
"pci_cleanup_aer_uncorrect_error_status failed 0x%0x\n",
err); /* non-fatal, continue */
}
That error message is how I found this problem, and it is not applicable
for the firmware first recovery path.
Signed-off-by: Betty Dall
---
dri
error sources where hest_match_pci() was trying to
access the structure as if it had the acpi_hest_aer_common fields.
aer_hest_parse() is only ever interested in the AER type HEST error
sources. Add a check on the type of the error souce at the beginning of
aer_hest_parse().
Signed-off-by: Betty Dall
Hi
I see that you offer VOIP serviceI have a network of requests (leads) that are
fresh daily, who request these services.
Would you be open to receiving them?
Best regards,
Michelle
Business Development
We respect your privacy and want to make sure you are aware of a few things. By
verity of "Informational" indicates that the record
could be safely ignored by error handling software."
The ghes code uses the CPER record's severity and always calls the
function ghes_severity() to convert to the GHES_SEV value. Since the
ACPI spec defines the GHES severity, it makes
se
multiple PCI segment groups, bits 8-31 must be zero. If the
GLOBAL flag is specified, this field is ignored."
This patch makes use of the new definition in the only place in the kernel
that uses the acpi_hest_aer_common's bus field.
Signed-off-by: Betty Dall
---
drivers/pci/pcie
nk function for
both Downstream Ports and Root Ports.
Signed-off-by: Betty Dall
---
Betty Dall (6):
PCI/AER: Don't parse HEST table for non-PCIe devices
PCI/AER: Factor out HEST device type matching
PCI/AER: Set dev->__aer_firmware_first only for matching devices
PCI/ACPI: Move AER seve
evice.
Signed-off-by: Bjorn Helgaas
Tested-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_acpi.c
b/drivers/pci/pcie/aer/aerdrv_acpi.c
index 5194a7d..4f798ab 100644
--- a/drivers/pci
Previously, we always updated info->firmware_first, even for HEST entries
that didn't match the device. Therefore, if the last HEST descriptor was
a PCIe structure that didn't match the device, we always cleared
dev->__aer_firmware_first.
Signed-off-by: Bjorn Helgaas
Teste
overy to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Changes since v2:
Set the aer_severity to AER_FATAL rather than using cper_severity_to_aer().
Simplified the comment.
Signed-off-by: Betty Dall
---
drivers/acpi
The function aer_recover_queue() is a public interface and the
severity argument uses #defines that are in the private header
pci/pcie/aer/aerdrv.h.
This patch moves the #defines from pci/pcie/aer/aerdrv.h to
include/linux/aer.h.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv.h
Downstream Link.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
b/drivers/pci/pcie/aer/aerdrv_core.c
index 8ec8b4f..cb29c04 100644
--- a/drivers/pci/pcie/aer
This factors out the matching of HEST structure type and PCIe device type
to improve readability. No functional change.
Signed-off-by: Bjorn Helgaas
Tested-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c | 35 +--
1 files changed, 17 insertions
On Tue, 2013-06-04 at 16:15 -0600, Bjorn Helgaas wrote:
> On Tue, Jun 4, 2013 at 3:38 PM, Betty Dall wrote:
> > On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
> >> On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
> >> > Date: Thu, 30 May 2
On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
> On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
> > Date: Thu, 30 May 2013 08:39:29 -0600
> > From: Betty Dall
> > To: r...@sisk.pl, bhelg...@google.com
> > Cc: ying.hu...@intel.com, linux-a...@
On Tue, 2013-06-04 at 03:53 -0400, Chen Gong wrote:
> On Thu, May 30, 2013 at 08:39:28AM -0600, Betty Dall wrote:
> > Date: Thu, 30 May 2013 08:39:28 -0600
> > From: Betty Dall
> > To: r...@sisk.pl, bhelg...@google.com
> > Cc: ying.hu...@intel.com, linux-a...@
On Sat, 2013-06-01 at 18:38 -0600, Bjorn Helgaas wrote:
> [+cc Bob for ACPI HEST spec questions]
>
> On Thu, May 30, 2013 at 8:39 AM, Betty Dall wrote:
> > The function aer_hest_parse() is called to determine if the given
> > PCI device is firmware first or not. The co
overy to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Signed-off-by: Betty Dall
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi
default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Changes since v1:
Removed incorrect setting of p2p_ctrl after the read.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 36
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer
over.
The changes have been tested on systems with firmware first that set the
"reset" bit by injecting various hardware errors. The errors successfully
recover.
Changes since v1:
Fixed a typo in the comment of patch 2.
Removed incorrect setting of reset bit in patch 3.
Signed-off-by: Betty
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
> On 05/28/2013 12:48 PM, Betty Dall wrote:
> > The CPER error record has a reset bit that indicates that the platform
> > has reset the bus. The reset bit can be set for any severity error
> > including recoverable. Fro
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
> On 05/28/2013 12:48 PM, Betty Dall wrote:
> > The firmware first path does not install the aerdrv root port
> > service driver, so the firmware first root port does not have
> > a reset_link callback. When a firmware
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer
over.
The changes have been tested on systems with firmware first that set the
"reset" bit by injecting various hardware errors. The errors successfully
recover.
---
Betty Dall (3):
PCI/AER: Fix incorrect return from aer_hest_parse()
ACPI/APEI: Force fatal AER severity when bus has
default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 37
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a
overy to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Signed-off-by: Betty Dall
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
The function aer_recover_queue() makes a call to pci_get_domain_bus_and_slot().
That function is documented to require that the caller decrement the
reference count by calling pci_dev_put(). This patch adds the missing
call to pci_dev_put().
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer
n Upstream Port must
report the same value in this field for all Functions."
Signed-off-by: Betty Dall
---
include/uapi/linux/pci_regs.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 20ae747..0cf8a
lookbusy -c 50 and saw the Watts increase. Is there
anything else to do to validate the numbers? In one case I saw that the
Pkg_W for the system was off by .01, e.g. socket 0 was 28.33 and socket
1 was 29.74 and the system total was 58.08 instead of 58.07. That is
probably fine and just rounding up.
-Be
turbostat/turbostat.c
+++ tools/power/x86/turbostat/turbostat.c
@@ -1967,7 +2290,7 @@
cmdline(argc, argv);
if (verbose > 1)
- fprintf(stderr, "turbostat v2.1 October 6, 2012"
+ fprintf(stderr, "turbostat v3.0 November 14, 2012"
On Sat, 2012-08-11 at 03:43 -0700, Andi Kleen wrote:
> On Fri, Aug 10, 2012 at 04:57:02PM -0700, H. Peter Anvin wrote:
> > On 08/09/2012 03:34 PM, Betty Dall wrote:
> > >
> > > I thought this should be a break instead of a continue since the code
> > > does a
PCI_CLASS_REVISION);
> if (class == 0x)
It is interesting that these last two functions are doing basically the
same pci discovery as the code in search_agp_bridge(), except that they
uses continue instead of br
; US_DEBUGP("MS_INIT_PATTERN\n");
> - fw_name = "ene-ub6250/ms_init.bin";
> + fw_name = MS_INIT_FIRMWARE;
> break;
> case MSP_RW_PATTERN:
> US_DEBUGP("MSP_RW_PATTERN\n");
> - fw_n
Hi Aaron,
On Tue, 2012-07-24 at 07:52 +0800, Aaron Lu wrote:
> On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote:
> > Hi Aaron,
>
> Hi,
>
> >
> > On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote:
> > > Set the ODD's in kernel poll interval
@@ -418,6 +418,7 @@ extern void disk_block_events(struct gendisk *disk);
> extern void disk_unblock_events(struct gendisk *disk);
> extern void disk_flush_events(struct gendisk *disk, unsigned int mask);
> extern unsigned int disk_clear_events(struct gendisk *disk, unsigned int
> mask);
> +extern int
anted, it is a contrived test
case. Your change will catch the real problems.
-Betty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Joe,
Thanks for the comment Joe. It looks like Roland already accepted the
trivial change.
On Thu, 2012-07-19 at 11:03 -0700, Joe Perches wrote:
> On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote:
> > There is a cut and paste typo in the function qib_pci_slot_reset() where
>
There is a cut and paste typo in the function qib_pci_slot_reset() where
it prints that the "link_reset" function is called rather than the
"slot_reset" function. This makes the message misleading.
Signed-off-by: Betty Dall
---
drivers/infiniband/hw/qib/qib_pcie.c |2 +-
56 matches
Mail list logo
