[PATCH] xen-blkfront: move negotiate_mq to cover all cases of new VBDs

2017-12-22 Thread Bhavesh Davda
negotiate_mq should happen in all cases of a new VBD being discovered by xen-blkfront, whether called through _probe() or a hot-attached new VBD from dom-0 via xenstore. Otherwise, hot-attached new VBDs are left configured without multi-queue. Signed-off-by: Bhavesh Davda Reviewed-by: Konrad

[PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev

2013-03-06 Thread Bhavesh Davda
Linux is free to call ethtool ops as soon as a netdev exists when probe finishes. However, we only allocate vmxnet3 tx/rx queues and initialize the rx_buf_per_pkt field in struct vmxnet3_adapter when the interface is opened (UP). Signed-off-by: Bhavesh Davda Signed-off-by: Shreyas N Bhatewara

Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev

2013-03-06 Thread Bhavesh Davda
> > --- > > drivers/net/vmxnet3/vmxnet3_drv.c |3 ++- > > drivers/net/vmxnet3/vmxnet3_ethtool.c |6 ++ > > drivers/net/vmxnet3/vmxnet3_int.h |4 ++-- > > 3 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c > > b/drivers/

[PATCH net-next] vmxnet3: prevent div-by-zero panic when ring resizing uninitialized dev

2013-03-06 Thread Bhavesh Davda
Linux is free to call ethtool ops as soon as a netdev exists when probe finishes. However, we only allocate vmxnet3 tx/rx queues and initialize the rx_buf_per_pkt field in struct vmxnet3_adapter when the interface is opened (UP). Signed-off-by: Bhavesh Davda Signed-off-by: Shreyas N Bhatewara

Re: [Pv-drivers] [PATCH] vmxnet3: must split too big fragments

2012-10-29 Thread Bhavesh Davda
LGTM. Thanks for doing this! Did you do any performance testing with this patch? Reviewed-by: Bhavesh Davda -- Bhavesh Davda - Original Message - > From: "Eric Dumazet" > To: "Shreyas Bhatewara" , "David Miller" > > Cc: "VMware,

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
> For many many years, you shipped closed source Linux kernel drivers > for > your products. Only recently has this changed. and > > all our Linux drivers, even if not all are upstream [yet], are GPL. > > That's nice to hear, although without proof of that, we have to take > your word :) The f

Re: [Pv-drivers] [PATCH 04/10] VMCI: device driver implementaton.

2012-10-25 Thread Bhavesh Davda
Hi Greg, > You can't just say "general GPL issues aside". Honestly, given your > company's prior actions in regards to Linux kernel drivers and the > licenses of them, I don't trust them at all. To help gain that trust > back, marking the exports in this manner will be a great improvement. > Yo