Re: [PATCH v2 0/3] Misc bug fixes in mtk power domain driver

2021-02-16 Thread Bilal Wasim
ping - can this series be merged ? On Mon, 1 Feb 2021 17:14:13 +0500 Bilal Wasim wrote: > Incorrect mask for the "bus_prot_clr" field meant that imgtec > gpu power domain (mfg_async) was not powered up correctly, causing > failure in driver booting. Fixing this and also ad

[PATCH v2 3/3] arm64: dts: mediatek: mt8173: Add domain supply for mfg_async

2021-02-01 Thread Bilal Wasim
da9211 regulator needs to be enabled before enabling the mfg_async power domain. Otherwise the subdomain is not enabled and causes failure in imgtec gpu driver boot. Add the "domain-supply" property to the "mfg_async" node in DT. Signed-off-by: Bilal Wasim --- arch/arm

[PATCH v2 2/3] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD

2021-02-01 Thread Bilal Wasim
The mfg_async power domain in mt8173 is used to power up imgtec gpu. This domain requires the da9211 regulator to be enabled before the power domain can be enabled successfully. Signed-off-by: Bilal Wasim Reviewed-by: Hsin-Yi Wang --- drivers/soc/mediatek/mt8173-pm-domains.h | 1 + 1 file

[PATCH v2 0/3] Misc bug fixes in mtk power domain driver

2021-02-01 Thread Bilal Wasim
tec gpu needs da9211 regulator to be enabled before enabling this subdomain. Tested with mt8173 elm chromebook. Bilal Wasim (3): soc: mediatek: pm-domains: Use correct mask for bus_prot_clr soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD arm64: dts: mediatek: mt8173: Add domain sup

[PATCH v2 1/3] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr

2021-02-01 Thread Bilal Wasim
chromebook. Signed-off-by: Bilal Wasim Reviewed-by: Hsin-Yi Wang --- drivers/soc/mediatek/mtk-pm-domains.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h index 141dc76054e6..7454c0b4f768 100644 ---

Re: [PATCH 1/2] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr

2021-02-01 Thread Bilal Wasim
On Mon, 1 Feb 2021 09:59:47 +0100 Matthias Brugger wrote: > On 01/02/2021 06:45, Bilal Wasim wrote: > > When "bus_prot_reg_update" is false, the driver should use > > INFRA_TOPAXI_PROTECTEN for both setting and clearing the bus > > protection. However, th

[PATCH 0/2] Misc bug fixes in mtk power domain driver

2021-01-31 Thread Bilal Wasim
tec gpu needs da9211 regulator to be enabled before enabling this subdomain. Tested with mt8173 elm chromebook. Bilal Wasim (2): soc: mediatek: pm-domains: Use correct mask for bus_prot_clr soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD drivers/soc/mediatek/mt8173-pm-domains.h | 1

[PATCH 2/2] soc: mediatek: pm-domains: Add domain_supply cap for mfg_async PD

2021-01-31 Thread Bilal Wasim
The mfg_async power domain in mt8173 is used to power up imgtec gpu. This domain requires the da9211 regulator to be enabled before the power domain can be enabled successfully. Signed-off-by: Bilal Wasim --- drivers/soc/mediatek/mt8173-pm-domains.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/2] soc: mediatek: pm-domains: Use correct mask for bus_prot_clr

2021-01-31 Thread Bilal Wasim
chromebook. Signed-off-by: Bilal Wasim --- drivers/soc/mediatek/mtk-pm-domains.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-pm-domains.h b/drivers/soc/mediatek/mtk-pm-domains.h index 141dc76054e6..7454c0b4f768 100644 --- a/drivers/soc/media

Re: [PATCH] drm/mediatek: dsi: Modify horizontal front/back porch byte formula

2020-11-19 Thread Bilal Wasim
hback_porch); > - horizontal_backporch_byte = > horizontal_backporch_byte - > - (data_phy_cycles * dsi->lanes + 12) * > - vm->hback_porch / > - (vm->hfront_porch + vm-&

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-17 Thread Bilal Wasim
On Tue, 17 Nov 2020 16:58:48 +0500 Bilal Wasim wrote: > Hi CK, > > On Tue, 17 Nov 2020 00:43:44 +0800 > Chun-Kuang Hu wrote: > > > Hi, Bilal: > > > > Bilal Wasim 於 2020年11月16日 週一 > > 下午7:53寫道: > > > > > > Hi CK, > > > &

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-17 Thread Bilal Wasim
Hi CK, On Tue, 17 Nov 2020 00:43:44 +0800 Chun-Kuang Hu wrote: > Hi, Bilal: > > Bilal Wasim 於 2020年11月16日 週一 > 下午7:53寫道: > > > > Hi CK, > > > > On Mon, 16 Nov 2020 07:12:55 +0800 > > Chun-Kuang Hu wrote: > > > > > Hi, Bilal:

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-16 Thread Bilal Wasim
Hi CK, On Mon, 16 Nov 2020 07:12:55 +0800 Chun-Kuang Hu wrote: > Hi, Bilal: > > Bilal Wasim 於 2020年11月16日 週一 > 上午3:25寫道: > > > > Hi CK, > > > > On Sun, 15 Nov 2020 08:53:24 +0800 > > Chun-Kuang Hu wrote: > > > > > Hi, Bilal: >

Re: [PATCH] drm/mediatek: dsi: Calculate horizontal_backporch_byte by itself

2020-11-15 Thread Bilal Wasim
Hi CK, On Sun, 15 Nov 2020 08:53:24 +0800 Chun-Kuang Hu wrote: > Hi, Bilal: > > Please help to test this patch on your Chromebook elm, thanks. > > Regards, > Chun-Kuang Hu Just tried this patch on the Chromebook Elm, and it doesn't work. The HDMI screen remains black, though the rest of the

Re: [PATCH v4 1/2] Revert "drm/mediatek: dsi: Fix scrolling of panel with small hfp or hbp"

2020-10-12 Thread Bilal Wasim
ro + timing->da_hs_exit + > 3; > if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) { > if ((vm->hfront_porch + vm->hback_porch) * > dsi_tmp_buf_bpp > Reviewed-by: Bilal Wasim Tested-by: Bilal Wasim Thanks, Bilal

Re: [v3 PATCH] drm/mediatek: dsi: fix scrolling of panel with small hfp or hbp

2020-09-28 Thread Bilal Wasim
Hi Jitao, On Thu, 17 Sep 2020 11:30:09 +0800 Jitao Shi wrote: > Replace horizontal_backporch_byte with vm->hback_porch * bpp to aovid > flowing judgement negative number. > > if ((vm->hfront_porch * dsi_tmp_buf_bpp + horizontal_backporch_byte) > > data_phy_cycles * dsi->lanes + delta) >

Re: [PATCH] arm64: dts: mt8173-elm: Remove ddc property from panel

2020-09-25 Thread Bilal Wasim
t8173-elm.dtsi +++ > b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -86,7 +86,6 @@ > volume_up { panel: panel { > compatible = "lg,lp120up1"; > power-supply = <_fixed_3v3>; > - ddc-i2c-bus = <>; > backlight = <>; > > port { Tested-by: Bilal Wasim Thanks, Bilal

Re: [PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-09-01 Thread Bilal Wasim
function without having enabled > the chip > + * before, return the chip to its original power state. > + */ > + if (poweroff) > + drm_bridge_chain_post_disable(bridge); > + > + return edid; > } > > static const struct drm_bridge_funcs ps8640_bridge_funcs = { I was able to apply this patch successfully to drm-misc-next / master - For Master, I had to apply your patches which have already made it to drm-misc-next. I was able to build / test successfully with Elm Chromebook. It seems that the kernel bot has reported a false positive. Tested-by: Bilal Wasim -Bilal

Re: [PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-08-31 Thread Bilal Wasim
Hi Enric, On Thu, 27 Aug 2020 10:59:11 +0200 Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

Re: [PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

2020-08-26 Thread Bilal Wasim
Hi All, On Mon, 24 Aug 2020 19:51:55 +0500 Bilal Wasim wrote: > fbcon doc mentions FRAMEBUFFER_CONSOLE option to be under > Device Drivers->Graphics Support->Frame buffer Devices-> > Console display driver support->Framebuffer Console Support, > while its under Device D

Re: [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-26 Thread Bilal Wasim
On Wed, 26 Aug 2020 10:15:26 +0200 Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

Re: [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-26 Thread Bilal Wasim
n_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1); > if (!in_ep) Reviewed-by: Bilal Wasim Tested-by: Bilal Wasim -Bilal

Re: [PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-26 Thread Bilal Wasim
uct ps8640 *ps_bridge = bridge_to_ps8640(bridge); > int ret; > > - ret = ps8640_bridge_vdo_control(ps_bridge, DISABLE); > - if (ret < 0) > - DRM_ERROR("failed to disable VDO: %d\n", ret); > + ps8640_bridge_vdo_control(ps_bridge, DISABLE); > > gpiod_set_value(ps_bridge->gpio_reset, 1); > gpiod_set_value(ps_bridge->gpio_powerdown, 1); Reviewed-by: Bilal Wasim Tested-by: Bilal Wasim -Bilal

Re: [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors

2020-08-26 Thread Bilal Wasim
status = connector_status_connected; > break; > default: Reviewed-by: Bilal Wasim Tested-by: Bilal Wasim -Bilal

Re: [PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-08-24 Thread Bilal Wasim
Hi Chun-Kuan, Enric, Is there any plan to merge the following commits in this series to the mainline? drm/bridge: ps8640: Get the EDID from eDP control drm/bridge_connector: Set default status connected for eDP connectors I see that rest of the patchset is already merged and available in

[PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

2020-08-24 Thread Bilal Wasim
uffer Console Support. Correcting it in the docs. Signed-off-by: Bilal Wasim --- Documentation/fb/fbcon.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/fb/fbcon.rst b/Documentation/fb/fbcon.rst index e57a3d1d085a..a7b487cba307 100644 --- a/Documentation/fb/fbcon.rs