Re: [PATCH 5/7] pinctrl: qcom: Add IPQ5018 pinctrl driver

2020-09-28 Thread Bjorn Andersson
On Mon 28 Sep 00:15 CDT 2020, Varadarajan Narayanan wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c > b/drivers/pinctrl/qcom/pinctrl-ipq5018.c [..] > +static const struct msm_function ipq5018_functions[] = { [..] > + FUNCTION(qspi_clk), > + FUNCTION(qspi_cs), > +

Re: [PATCH v5 3/3] remoteproc: qcom: Add minidump id for sm8150 modem remoteproc

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 16:51 PDT 2020, Siddharth Gupta wrote: > Add minidump id for modem in sm8150 chipset. "...so that the regions to be included in the coredump generated upon a crash is based on the minidump tables in SMEM instead of those in the ELF header." Regards, Bjorn > > Signed-off-by:

Re: [PATCH v5 2/3] remoteproc: qcom: Add capability to collect minidumps

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 16:51 PDT 2020, Siddharth Gupta wrote: > This patch adds support for collecting minidump in the event of remoteproc > crash. Parse the minidump table based on remoteproc's unique minidump-id, > read all memory regions from the remoteproc's minidump table entry and > expose the

Re: [PATCH v5 1/2] remoteproc: Move coredump configuration to sysfs

2020-09-25 Thread Bjorn Andersson
On Fri 18 Sep 10:22 PDT 2020, Rishabh Bhatnagar wrote: > diff --git a/drivers/remoteproc/remoteproc_debugfs.c > b/drivers/remoteproc/remoteproc_debugfs.c [..] > +static ssize_t coredump_store(struct device *dev, > + struct device_attribute *attr, > +

Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs

2020-09-25 Thread Bjorn Andersson
On Tue 15 Sep 02:51 PDT 2020, Arnaud POULIQUEN wrote: > Hi Rishabh, > > On 8/27/20 9:48 PM, Rishabh Bhatnagar wrote: > > From Android R onwards Google has restricted access to debugfs in user > > and user-debug builds. This restricts access to most of the features > > exposed through debugfs.

Re: [PATCH] ath10k: Introduce a devicetree quirk to skip host cap QMI requests

2020-09-25 Thread Bjorn Andersson
QMI request for the firmware versions which do not support this > feature. > > Suggested-by: Bjorn Andersson > Signed-off-by: Amit Pundir > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt| 5 + > drivers/net/wireless/ath/ath10k/qmi.c

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Thu 24 Sep 11:31 CDT 2020, Kalle Valo wrote: > Amit Pundir writes: > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > > message in ath10k_qmi_host_cap_send_sync(), but we can still > > bring up WiFi services

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-25 Thread Bjorn Andersson
On Mon 21 Sep 05:38 CDT 2020, Amit Pundir wrote: > On Thu, 17 Sep 2020 at 21:35, Bjorn Andersson > wrote: > > > > On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > > > > > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > > > phone. We get a

Re: [PATCH -next] media: venus: simplify the return expression of session_process_buf()

2020-09-25 Thread Bjorn Andersson
On Mon 21 Sep 08:10 CDT 2020, Qinglang Miao wrote: > Simplify the return expression. > Reviewed-by: Bjorn Andersson > Signed-off-by: Qinglang Miao > --- > drivers/media/platform/qcom/venus/helpers.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > &

Re: [PATCH -next] media: venus: simplify the return expression of venus_sys_set_* function

2020-09-25 Thread Bjorn Andersson
On Mon 21 Sep 03:24 CDT 2020, Liu Shixin wrote: > Simplify the return expression. > Reviewed-by: Bjorn Andersson > Signed-off-by: Liu Shixin > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 28 +++ > 1 file changed, 4 insertions(+), 24 deletions(

Re: [PATCH v3 6/8] iommu/arm-smmu: Add impl hook for inherit boot mappings

2020-09-24 Thread Bjorn Andersson
On Mon 21 Sep 16:08 CDT 2020, Will Deacon wrote: > On Sat, Sep 12, 2020 at 10:25:59PM -0500, Bjorn Andersson wrote: > > On Fri 11 Sep 12:13 CDT 2020, Robin Murphy wrote: > > > On 2020-09-04 16:55, Bjorn Andersson wrote: > > > > Add a new operation to allow platform

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-21 Thread Bjorn Andersson
On Mon 21 Sep 19:22 CDT 2020, nguy...@codeaurora.org wrote: > On 2020-09-18 12:01, Rob Herring wrote: > > On Tue, Sep 15, 2020 at 2:10 AM wrote: > > > > > > On 2020-09-14 11:35, Rob Herring wrote: > > > > On Mon, Aug 31, 2020 at 11:00:47PM -0700, Bao D. Nguyen wrote: > > > >> UFS's

Re: [PATCH v3] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver

2020-09-18 Thread Bjorn Andersson
On Fri 18 Sep 08:17 CDT 2020, Srinivasa Rao Mandadapu wrote: > From: Ajit Pandey > > Add the I2S controller node to sc7180 dtsi. > Add pinmux for primary and secondary I2S. > > Signed-off-by: Ajit Pandey > Signed-off-by: Cheng-Yi Chiang > Signed-off-by: Srinivasa Rao Mandadapu >

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

2020-09-17 Thread Bjorn Andersson
On Thu 17 Sep 07:13 CDT 2020, Mauro Carvalho Chehab wrote: > Em Tue, 15 Sep 2020 12:43:26 +0900 > Alexandre Courbot escreveu: > > > On Tue, Sep 15, 2020 at 12:25 PM Bjorn Andersson > > wrote: > > > > > > On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot w

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Bjorn Andersson
On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH 1/5] dt-bindings: phy: qcom,qmp: Document SM8250 PCIe PHY bindings

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 23:32 CDT 2020, Vinod Koul wrote: > On 16-09-20, 17:45, Bjorn Andersson wrote: > > On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote: > > > > > Document the DT bindings of below PCIe PHY versions used on SM8250: > > > > > > QMP GE

Re: [PATCH -next] soc: use devm_platform_ioremap_resource_byname

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 11:15 UTC 2020, Qilong Zhang wrote: > Use the devm_platform_ioremap_resource_byname() helper instead of > calling platform_get_resource_byname() and devm_ioremap_resource() > separately. > > Signed-off-by: Zhang Qilong I fixed up the subject line to match the previous commits in

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 19:53 CDT 2020, nguy...@codeaurora.org wrote: > On 2020-09-15 06:37, Bjorn Andersson wrote: > > On Tue 15 Sep 03:49 CDT 2020, nguy...@codeaurora.org wrote: > > > > > On 2020-09-14 19:54, Bjorn Andersson wrote: > > > > On Tue 01 Sep

Re: [PATCH 5/5] pci: controller: dwc: qcom: Harcode PCIe config SID

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 08:20 CDT 2020, Manivannan Sadhasivam wrote: > Hardcode the PCIe config SID table value. This is needed to avoid random > MHI failure observed during reboot on SM8250. > > Signed-off-by: Jonathan Marek > [mani: stripped out unnecessary settings and ported for upstream] >

Re: [PATCH leds v1 06/10] leds: pm8058: use struct led_init_data when registering

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 18:16 CDT 2020, Marek Beh?n wrote: > By using struct led_init_data when registering we do not need to parse > `label` DT property nor `linux,default-trigger` property. > > Signed-off-by: Marek BehĂșn > Cc: Linus Walleij > Cc: Bjorn Andersson > --- > dr

Re: [PATCH 3/5] dt-bindings: pci: qcom: Document PCIe bindings for SM8250 SoC

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote: > Document the PCIe DT bindings for SM8250 SoC. The PCIe IP is similar to > the one used on SDM845, hence just add the compatible. > > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/pci/qcom,pcie.txt | 5

Re: [PATCH 2/5] phy: qualcomm: phy-qcom-qmp: Add PCIe PHY support for SM8250 SoC

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote: As with the controller patches, it's desirable for $subject to be succinct and have the prefix match other commits. So I suggest you go with "phy: qcom-qmp: Add SM8250 PCIe QMP PHYs" Apart from that I think this change looks good.

Re: [PATCH 1/5] dt-bindings: phy: qcom,qmp: Document SM8250 PCIe PHY bindings

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote: > Document the DT bindings of below PCIe PHY versions used on SM8250: > > QMP GEN3x1 PHY - 1 lane > QMP GEN3x2 PHY - 2 lanes > QMP Modem PHY - 2 lanes How about something like "Add the three PCIe PHYs found in SM8250 to the QMP

Re: [PATCH v7 2/2] drm: panel: Add novatek nt36672a panel driver

2020-09-15 Thread Bjorn Andersson
a > safe high value to avoid a white screen occasionally. > > Signed-off-by: Sumit Semwal > Cc: Benni Steini Reviewed-by: Bjorn Andersson Regards, Bjorn > > --- > v2: increase reset sequence timing to a safe 200ms > v4: Since "0425662fdf05: drm: Nuke mode-

Re: [PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-09-15 Thread Bjorn Andersson
co F1 phones. > > This patch adds the display driver for the IC, with support added for > this tianma fhd video mode panel. > > Signed-off-by: Sumit Semwal > Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson Regards, Bjorn > > --- > v2: remove ports node, making p

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 03:14 CDT 2020, nguy...@codeaurora.org wrote: > On 2020-09-14 21:41, Bjorn Andersson wrote: > > On Tue 01 Sep 01:00 CDT 2020, Bao D. Nguyen wrote: > > > > > UFS's specifications supports a range of Vcc operating > > > voltage levels. Add docume

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 03:49 CDT 2020, nguy...@codeaurora.org wrote: > On 2020-09-14 19:54, Bjorn Andersson wrote: > > On Tue 01 Sep 01:19 UTC 2020, Bao D. Nguyen wrote: > > > > > UFS version 3.0 and later devices require Vcc and Vccq power supplies > > > with Vccq2

Re: [PATCH] usb: dwc3: qcom: Honor wakeup enabled/disabled state

2020-09-15 Thread Bjorn Andersson
errupts when device_may_wakeup() returns true. > > Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") > Signed-off-by: Matthias Kaehlcke Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > > drivers/usb/dwc3/dwc3-qcom.c | 7 +-- > 1 file changed, 5 in

Re: [PATCH] arm64: dts: qcom: sdm845: Add interconnects property for display

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 21:45 UTC 2020, Georgi Djakov wrote: > Add the interconnect paths that are used by the display (MDSS). This > will allow the driver to request the needed bandwidth and prevent > display flickering. > > Signed-off-by: Georgi Djakov > --- > This patch depends on: >

Re: [PATCH v2 4/5] cpufreq: qcom-hw: Use of_device_get_match_data for offsets and row size

2020-09-15 Thread Bjorn Andersson
nnan Sadhasivam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/cpufreq/qcom-cpufreq-hw.c | 89 --- > 1 file changed, 59 insertions(+), 30 deletions(-) > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c > b/drivers/cpufreq/qcom-

Re: [PATCH v1] arm64: dts: qcom: msm8996: Add VFE1_GDSC power domain to camss node

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 14:23 UTC 2020, Robert Foss wrote: > As the MSM8996 has two VFE IP-blocks, and each has a power domain, > both of them have to be enabled. Previously only the power domain > of VFE0 was enabled, but not the domain for VFE1. > > This patch adds the VFE1_GDSC power domain to the

Re: [PATCH] irqchip/qcom-pdc: Allow QCOM_PDC to be loadable as a permanent module

2020-09-15 Thread Bjorn Andersson
ovided a better solution in his > Hybrid probing patch set, I wanted to re-submit this change. > Reviewed-by: Bjorn Andersson > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Joerg Roedel > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: Marc Zyngier > Cc: Linus Walleij

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 16:47 UTC 2020, nguy...@codeaurora.org wrote: > On 2020-09-15 06:43, Bjorn Andersson wrote: > > On Tue 15 Sep 03:14 CDT 2020, nguy...@codeaurora.org wrote: > > > > > On 2020-09-14 21:41, Bjorn Andersson wrote: > > > > On Tue 01 Sep

Re: [PATCH] remoteproc: qcom_q6v5: Assign mpss region to Q6 before MBA cold boot

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 17:37 UTC 2020, Sibi Sankar wrote: > On secure devices which support warm reset, the modem subsystem requires > access to the mpss region to clear them out. Hence assign the mpss region > to Q6 before MBA cold boot. This will be a nop during a modem SSR. > > Signed-off-by: Sibi

Re: [PATCHv5 1/2] soc: qcom: llcc: Move llcc configuration to its own function

2020-09-15 Thread Bjorn Andersson
Ranjan Reviewed-by: Bjorn Andersson > --- > drivers/soc/qcom/llcc-qcom.c | 89 > 1 file changed, 50 insertions(+), 39 deletions(-) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index 429b5a60a1ba..14311060

Re: [PATCH] remoteproc: Fixup coredump debugfs disable request

2020-09-15 Thread Bjorn Andersson
On Tue 15 Sep 07:34 UTC 2020, Sibi Sankar wrote: > Currently the coredump debugfs entry takes in "disable" to set the > coredump state to "disabled". Let's just accept the expected state > instead. > I like this patch, but rather than arguing that it should match the name of the internal state

Re: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from device tree

2020-09-15 Thread Bjorn Andersson
On Tue 01 Sep 01:00 CDT 2020, Bao D. Nguyen wrote: > The UFS specifications supports a range of Vcc operating voltage > from 2.4-3.6V depending on the device and manufacturers. > Allows selecting the UFS Vcc voltage level by setting the > UFS's entry vcc-voltage-level in the device tree. If UFS's

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-14 Thread Bjorn Andersson
On Tue 01 Sep 01:00 CDT 2020, Bao D. Nguyen wrote: > UFS's specifications supports a range of Vcc operating > voltage levels. Add documentation for the UFS's Vcc voltage > levels setting. > > Signed-off-by: Can Guo > Signed-off-by: Asutosh Das > Signed-off-by: Bao D. Nguyen > --- >

Re: [PATCH RESEND RESEND] remoteproc: scp: add COMPILE_TEST dependency

2020-09-14 Thread Bjorn Andersson
On Tue 15 Sep 01:29 UTC 2020, Alexandre Courbot wrote: > This will improve this driver's build coverage. > > Reported-by: Ezequiel Garcia > Signed-off-by: Alexandre Courbot > --- > Hi remoteproc maintainers, > > Second resend as I got no reaction for almost 1 month on this one-liner. Sorry

Re: [PATCH -next] power: avs: qcom-cpr: simplify the return expression of cpr_disable()

2020-09-14 Thread Bjorn Andersson
On Mon 14 Sep 22:26 CDT 2020, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Reviewed-by: Bjorn Andersson > --- > drivers/power/avs/qcom-cpr.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/driver

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-14 Thread Bjorn Andersson
On Tue 01 Sep 01:19 UTC 2020, Bao D. Nguyen wrote: > UFS version 3.0 and later devices require Vcc and Vccq power supplies > with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 > devices, the Vcc and Vccq2 are required with Vccq being optional. > Check the required power supplies

Re: [PATCH] drm/msm/a6xx: fix a potential overflow issue

2020-09-14 Thread Bjorn Andersson
On Sat 12 Sep 10:25 UTC 2020, Zhenzhong Duan wrote: > It's allocating an array of a6xx_gpu_state_obj structure rathor than > its pointers. > > This patch fix it. > Reviewed-by: Bjorn Andersson > Signed-off-by: Zhenzhong Duan > --- > drivers/gpu/drm/msm/adreno/a6xx

Re: [PATCH V6 0/4] Add wakeup support over UART RX

2020-09-14 Thread Bjorn Andersson
On Mon 14 Sep 13:58 UTC 2020, satya priya wrote: > Changes in V2: > - As per Matthias's comment added wakeup support for all the UARTs >of SC7180. > - Added sleep state in sc7180-idp.dts file. > - Modify the if check in set_mctrl API in serial driver to avoid >making RFR high during

Re: [PATCH] tty: serial: qcom_geni_serial: 115.2 is a better console default than 9600

2020-09-14 Thread Bjorn Andersson
nsole delays can wreck havoc). > > This has already bit at least two people that I'm aware of that tried > to enable serial console by just adding "console=ttyMSM0" (instead of > "console=ttyMSM0,115200n8") to the command line, so it seems like it'd > be nice to fi

Re: [RESEND v1] arm64: dts: qcom: sc7180: Remove clock for bluetooth on SC7180 IDP board

2020-09-13 Thread Bjorn Andersson
On Fri 11 Sep 07:11 UTC 2020, Marcel Holtmann wrote: > Hi, > Hi Marcel, > > Removed voting for RPMH_RF_CLK2 which is not required as it is > > getting managed by BT SoC through SW_CTRL line. > > > > Signed-off-by: Venkata Lakshmi Narayana Gubba > > --- > >

Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables

2020-09-12 Thread Bjorn Andersson
struct parent_map gcc_xo_gpll6_gpll0_map[] = { > ^~~~~~ > Reviewed-by: Bjorn Andersson > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/clk/qcom/gcc-msm8939.c | 12 > 1 file changed, 12 deletions(-) > > diff --git a/drivers/clk/qcom/

Re: [PATCH v2 1/2] PM / Domains: Add GENPD_FLAG_NO_SUSPEND/RESUME flags

2020-09-12 Thread Bjorn Andersson
On Thu 10 Sep 03:18 CDT 2020, Ulf Hansson wrote: > On Thu, 10 Sep 2020 at 09:23, Sibi Sankar wrote: > > > > On 2020-08-25 23:23, Bjorn Andersson wrote: > > > On Tue 25 Aug 02:20 CDT 2020, Stephen Boyd wrote: > > >> Quoting Bjorn Andersson (2020-08-24 09:42:

Re: [PATCH v3 6/8] iommu/arm-smmu: Add impl hook for inherit boot mappings

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 12:13 CDT 2020, Robin Murphy wrote: > On 2020-09-04 16:55, Bjorn Andersson wrote: > > Add a new operation to allow platform implementations to inherit any > > stream mappings from the boot loader. > > Is there a reason we need an explicit step for this? The a

Re: [PATCH] drm/msm/adreno: fix probe without iommu

2020-09-12 Thread Bjorn Andersson
"drm/msm: Refactor address space initialization") > Signed-off-by: Luca Weiss Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adren

Re: [PATCH 1/3] spi: spi-geni-qcom: Use the FIFO even more

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 20:11 CDT 2020, Doug Anderson wrote: > Hi, > > On Sat, Sep 12, 2020 at 3:53 PM Bjorn Andersson > wrote: > > > > On Sat 12 Sep 16:07 CDT 2020, Douglas Anderson wrote: > > > > > In commit 902481a78ee4 ("spi: spi-geni-qcom: Actually use o

Re: [PATCH net-next v2 7/7] net: ipa: do not enable GSI interrupt for wakeup

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > We now trigger a system resume when we receive an IPA SUSPEND > interrupt. We should *not* wake up on GSI interrupts. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > drivers/net/ipa/gsi.c | 17 --

Re: [PATCH net-next v2 6/7] net: ipa: enable wakeup on IPA interrupt

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > Now that we handle wakeup interrupts properly, arrange for the IPA > interrupt to be treated as a wakeup interrupt. > Reviewed-by: Bjorn Andersson > Signed-off-by: Alex Elder > --- > drivers/net/ipa/ipa_interrupt.c | 14 +

Re: [PATCH 1/6] of: Add basic infrastructure to create early probe arrays

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > We currently probe interrupt controller and timers that need > to be available very early using an infratstructure that creates s/infratstructure/infrastructure/ > struct of_device_id instances in a special section. These are > individual

Re: [PATCH net-next v2 4/7] net: ipa: manage endpoints separate from clock

2020-09-12 Thread Bjorn Andersson
system resume. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > drivers/net/ipa/ipa_clock.c | 14 -- > drivers/net/ipa/ipa_main.c | 8 > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ip

Re: [PATCH net-next v2 5/7] net: ipa: use device_init_wakeup()

2020-09-12 Thread Bjorn Andersson
> > When we receive a SUSPEND interrupt, call pm_wakeup_dev_event() > with a zero processing time, to simply call for a resume without > any other processing. The ipa_resume() call will take care of > waking things up again, and will handle receiving the packet. > Reviewed-by: Bj

Re: [PATCH net-next v2 3/7] net: ipa: verify reference flag values

2020-09-12 Thread Bjorn Andersson
On Fri 11 Sep 19:45 CDT 2020, Alex Elder wrote: > We take a single IPA clock reference to keep the clock running until > we get a system suspend operation, and maintain a flag indicating > whether that reference has been taken. When a suspend request > arrives, we drop that reference and clear

Re: [PATCH 6/6] irqchip/qcom-pdc: Allow modular build

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Si

Re: [PATCH 5/6] irqchip/mtk-sysirq: Allow modular build

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Si

Re: [PATCH 4/6] irqchip/mtk-cirq: Allow modular build

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Si

Re: [PATCH 3/6] irqchip: Introduce IRQCHIP_HYBRID_DRIVER_{BEGIN,END} macros

2020-09-12 Thread Bjorn Andersson
a platform driver, and we can > fallback to the existing code. > > Hopefully we'll one day be able to drop this code altogether, > but that's not for tomorrow. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > include/linux/irqchip.h | 12 ++

Re: [PATCH 2/6] irqchip: Make IRQCHIP_MATCH() type safe

2020-09-12 Thread Bjorn Andersson
OF_DECLARE_ELMT() restore > the missing type safety. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > include/linux/irqchip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/irqchip.h b/include/linux/irqch

Re: [PATCH 1/6] of: Add basic infrastructure to create early probe arrays

2020-09-12 Thread Bjorn Andersson
; > _OF_DECLARE_ARRAY_START(table, name) > _OF_DECLARE_ELMT("compat-1", probe, type) > _OF_DECLARE_ELMT("compat-2", probe, type) > _OF_DECLARE_ELMT("compat-3", other_probe, type) > _OF_DECLARE_ARRAY_END > Reviewed-by: Bjorn Andersson Regards, Bjorn &

Re: [PATCH] spi: spi-geni-qcom: Don't wait to start 1st transfer if transmitting

2020-09-12 Thread Bjorn Andersson
t; rather than adding a forward declaration. The only actual change to > geni_spi_handle_tx() was to make it return a bool indicating if there > is more to tx. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Douglas Anderson > --- > > drivers/spi/spi-geni-qco

Re: [PATCH 2/3] spi: spi-geni-qcom: Don't program CS_TOGGLE again and again

2020-09-12 Thread Bjorn Andersson
> be done with it. > > This saves some part of a microsecond of overhead on each transfer. > While not really noticeable on any real world benchmarks, we might as > well save the time. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Douglas Anderson > --- >

Re: [PATCH 3/3] spi: spi-geni-qcom: Slightly optimize setup of bidirectional xfters

2020-09-12 Thread Bjorn Andersson
; > + > + /* > + * Factor out the __iowmb() so that we can use writel_relaxed() for > + * both writes below and thus only incur the overhead once even if > + * we execute both of them. > + */ How many passes through this function do we have to take before sav

Re: [PATCH 1/3] spi: spi-geni-qcom: Use the FIFO even more

2020-09-12 Thread Bjorn Andersson
On Sat 12 Sep 16:07 CDT 2020, Douglas Anderson wrote: > In commit 902481a78ee4 ("spi: spi-geni-qcom: Actually use our FIFO") I > explained that the maximum size we could program the FIFO was > "mas->tx_fifo_depth - 3" but that I chose "mas->tx_fifo_depth()" > because I was worried about decreased

Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

2020-09-11 Thread Bjorn Andersson
On Fri 11 Sep 05:15 CDT 2020, ska...@codeaurora.org wrote: > On 2020-09-10 20:10, Doug Anderson wrote: > > Hi, > > > > On Thu, Sep 10, 2020 at 5:55 AM satya priya > > wrote: > > > > > > Add a suitable sleep configuration for uart3 to support Bluetooth > > > wakeup. > > > > > > If QUP function

Re: [PATCH V5 2/4] arm64: dts: qcom: sc7180: Add necessary pinctrl and interrupt config for BT UART

2020-09-10 Thread Bjorn Andersson
On Thu 10 Sep 12:53 UTC 2020, satya priya wrote: > Add a suitable sleep configuration for uart3 to support Bluetooth wakeup. > > If QUP function is selected in sleep state, UART RTS/RFR is pulled high > during suspend and BT SoC not able to send wakeup bytes. So, configure > GPIO mode in sleep

Re: [PATCH V5 4/4] tty: serial: qcom_geni_serial: Fix the UART wakeup issue

2020-09-10 Thread Bjorn Andersson
to UART during > suspend. Include if check for non-suspend case to keep RFR low > during suspend. > Seems reasonable. Reviewed-by: Bjorn Andersson > Signed-off-by: satya priya > Acked-by: Greg Kroah-Hartman Greg, I don't see this depending on anything else, will you pick t

Re: [PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-09-10 Thread Bjorn Andersson
On Thu 16 Jul 11:35 UTC 2020, Kalyan Thota wrote: > From: Krishna Manikandan > > Move the bus clock to mdp device node,in order > to facilitate bus band width scaling on sc7180 > target. > > The parent device MDSS will not vote for bus bw, > instead the vote will be triggered by mdp device >

Re: [PATCH v3 2/2] venus: firmware: Set virtual address ranges

2020-09-10 Thread Bjorn Andersson
the firmware on remote processor. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/core.c | 4 > drivers/media/platform/qcom/venus/core.h | 4 > drivers/media/platform/qcom/venus/firmware.c

Re: [PATCH 1/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Document SM8250 compatible

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > Document the SM8250 SoC specific compatible for Qualcomm Cpufreq HW. The > hardware block which carries out CPUFreq operations on SM8250 SoC is > called EPSS. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by:

Re: [PATCH 7/7] cpufreq: qcom-hw: Use devm_platform_ioremap_resource() to simplify code

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > devm_platform_ioremap_resource() is the combination of > platform_get_resource() and devm_ioremap_resource(). Hence, use it to > simplify the code a bit. > Reviewed-by: Bjorn Andersson > Signed-off-by: Maniva

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > Use regmap for accessing cpufreq registers in hardware. > The content of the patch looks good, but in itself I don't see the reason for migrating to regmap. If you have subsequent patches, that would benefit from describing the

Re: [PATCH 4/7] cpufreq: qcom-hw: Make use of of_match data for offsets and row size

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > For preparing the driver to handle further SoC revisions, let's use the > of_match data for getting the device specific offsets and row size instead > of defining them globally. > > Signed-off-by: Manivannan Sadhasivam > --- >

Re: [PATCH 6/7] cpufreq: qcom-hw: Add cpufreq support for SM8250 SoC

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 02:57 CDT 2020, Manivannan Sadhasivam wrote: > SM8250 SoC uses EPSS block for carrying out the cpufreq duties. Hence, add > support for it in the driver with relevant of_match data. > > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Bjorn Andersson > --- >

Re: [PATCH v2 2/2] venus: firmware: Set virtual address ranges

2020-09-08 Thread Bjorn Andersson
On Mon 17 Aug 03:27 CDT 2020, Stanimir Varbanov wrote: > In order to boot some of the new Venus firmware versions TZ call to set > virtual address ranges is needed. Add virtual address ranges for CP and > CP_NONPIX in resource structure and use them when loading and booting > the firmware on

Re: [PATCH v2 1/2] firmware: qcom_scm: Add memory protect virtual address ranges

2020-09-08 Thread Bjorn Andersson
On Mon 17 Aug 03:27 CDT 2020, Stanimir Varbanov wrote: > This adds a new SCM memprotect command to set virtual address ranges. > Acked-by: Bjorn Andersson Please feel free to pick this through linux-media. Regards, Bjorn > Signed-off-by: Stanimir Varbanov > --- > d

Re: [PATCH] soundwire: qcom: fix SLIBMUS/SLIMBUS typo

2020-09-08 Thread Bjorn Andersson
On Tue 08 Sep 09:08 CDT 2020, Jonathan Marek wrote: > Fix slimbus case being broken thanks to a typo. > > Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS") > Reviewed-by: Bjorn Andersson > Signed-off-by: Jonathan Marek > -

Re: [PATCH v16 20/20] arm: dts: qcom: sc7180: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Rob Clark > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > Reviewed-by: Bjorn Andersson > Signed-off-by: Rob Clark > --- >

Re: [PATCH v16 19/20] arm: dts: qcom: sm845: Set the compatible string for the GPU SMMU

2020-09-04 Thread Bjorn Andersson
On Tue 01 Sep 11:46 CDT 2020, Rob Clark wrote: > From: Jordan Crouse > > Set the qcom,adreno-smmu compatible string for the GPU SMMU to enable > split pagetables and per-instance pagetables for drm/msm. > > Signed-off-by: Jordan Crouse > Signed-off-by: Rob Clark Reviewe

Re: [PATCH v16 14/20] iommu/arm-smmu: Prepare for the adreno-smmu implementation

2020-09-04 Thread Bjorn Andersson
ittle bit cleaner. So perhaps you would be interested in squashing https://lore.kernel.org/linux-arm-msm/20200904155513.282067-2-bjorn.anders...@linaro.org/ into this patch? Otherwise, feel free to add my: Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm/arm-smmu/arm-

[PATCH v3 4/8] iommu/arm-smmu-qcom: Emulate bypass by using context banks

2020-09-04 Thread Bjorn Andersson
SMMU. This adds a Qualcomm specific cfg_probe function, which probes for the broken behavior of the S2CR registers and implements a custom alloc_context_bank() that when necessary allocates a context bank (without translation) for these domains as well. Signed-off-by: Bjorn Andersson --- Changes

[PATCH v3 3/8] iommu/arm-smmu: Consult context bank allocator for identify domains

2020-09-04 Thread Bjorn Andersson
consulted and if it decides to use a context bank for the identity map, don't enable translation (i.e. omit ARM_SMMU_SCTLR_M). Signed-off-by: Bjorn Andersson --- Changes since v2: - Tie this to alloc_context_bank rather than carrying a Qualcomm specific quirk in the generic code. drivers/iommu

[PATCH v3 5/8] iommu/arm-smmu-qcom: Consistently initialize stream mappings

2020-09-04 Thread Bjorn Andersson
ings might linger and reference context banks that Linux is reconfiguring. Use the fact that BYPASS writes result in FAULT type to force all stream mappings to FAULT. Signed-off-by: Bjorn Andersson --- Changes since v2: - None drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 18

[PATCH v3 2/8] iommu/arm-smmu: Delay modifying domain during init

2020-09-04 Thread Bjorn Andersson
Delay modifications to the domain during arm_smmu_init_domain_context() until we've allocated a context bank. This will allow us to postpone the special handling of identity domains until the platform specific context bank allocator has been executed, in a later patch. Signed-off-by: Bjorn

[PATCH v3 1/8] iommu/arm-smmu: Refactor context bank allocation

2020-09-04 Thread Bjorn Andersson
passed object. This allows us to not assign smmu_domain->smmu before attempting to allocate the context bank and as such we don't need to roll back this assignment on failure. Signed-off-by: Bjorn Andersson --- Note that this series applies ontop of: https://lore.kernel.org/linux-arm-

[PATCH v3 0/8] iommu/arm-smmu: Support maintaining bootloader mappings

2020-09-04 Thread Bjorn Andersson
, which can be found at https://lore.kernel.org/linux-arm-msm/20200901164707.2645413-1-robdcl...@gmail.com/ Bjorn Andersson (8): iommu/arm-smmu: Refactor context bank allocation iommu/arm-smmu: Delay modifying domain during init iommu/arm-smmu: Consult context bank allocator for identify domains

[PATCH v3 6/8] iommu/arm-smmu: Add impl hook for inherit boot mappings

2020-09-04 Thread Bjorn Andersson
Add a new operation to allow platform implementations to inherit any stream mappings from the boot loader. Signed-off-by: Bjorn Andersson --- Changes since v2: - New patch/interface drivers/iommu/arm/arm-smmu/arm-smmu.c | 11 ++- drivers/iommu/arm/arm-smmu/arm-smmu.h | 6 ++ 2

[PATCH v3 7/8] iommu/arm-smmu: Provide helper for allocating identity domain

2020-09-04 Thread Bjorn Andersson
Some platform implementations needs to be able to allocate a domain for emulating identity mappings using a context bank without translation. Provide a helper function to allocate such a domain. Signed-off-by: Bjorn Andersson --- Changes since v2: - Extracted from previous

[PATCH v3 8/8] iommu/arm-smmu-qcom: Setup identity domain for boot mappings

2020-09-04 Thread Bjorn Andersson
context bank is used and streams are diverted here during initialization. This also performs the readback of SMR registers for the Qualcomm platform, to trigger the mechanism. This is based on prior work by Thierry Reding and Laurentiu Tudor. Signed-off-by: Bjorn Andersson --- Changes since v2

Re: [PATCH 1/3] iommu: amd: Fix kerneldoc

2020-09-04 Thread Bjorn Andersson
c:1938: warning: Function parameter or member > 'iommu' not described in 'iommu_update_intcapxt' > Reviewed-by: Bjorn Andersson > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iommu/amd/init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/d

Re: [PATCH 2/3] iommu: intel: Drop kerneldoc marker from regular comment

2020-09-04 Thread Bjorn Andersson
On Tue 28 Jul 12:08 CDT 2020, Krzysztof Kozlowski wrote: > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/iommu/intel/dmar.c:389: warning: Function parameter or member > 'header' not described in 'dmar_parse_one_drhd' > Reviewed-by: Bjorn Andersson > Signed

Re: [PATCH 3/3] iommu: qcom: Drop of_match_ptr to fix -Wunused-const-variable

2020-09-04 Thread Bjorn Andersson
910:34: warning: 'qcom_iommu_of_match' defined > but not used [-Wunused-const-variable=] > 910 | static const struct of_device_id qcom_iommu_of_match[] = { > Reviewed-by: Bjorn Andersson > Signed-off-by: Krzysztof Kozlowski > --- > drivers/iommu/qcom_iommu.c | 4 ++-- > 1 file c

Re: [PATCH v3 1/3] remoteproc: Expose remoteproc configuration through sysfs

2020-09-03 Thread Bjorn Andersson
On Thu 03 Sep 18:03 CDT 2020, Rishabh Bhatnagar wrote: > Add a feature flag to expose some of the remoteproc configuration > through sysfs. This feature is helpful in systems where debugfs is > not available/mounted. Currently the recovery and coredump > configuration is exposed through sysfs

Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs

2020-09-03 Thread Bjorn Andersson
On Tue 01 Sep 17:05 CDT 2020, Mathieu Poirier wrote: > Hi Rishabh, > > On Thu, Aug 27, 2020 at 12:48:48PM -0700, Rishabh Bhatnagar wrote: > > From Android R onwards Google has restricted access to debugfs in user > > and user-debug builds. This restricts access to most of the features > >

Re: [PATCH] PCI: qcom: Make sure PCIe is reset before init for rev 2.1.0

2020-09-01 Thread Bjorn Andersson
s U-Boot bug. > Looks sensible. Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Ansuel Smith > Fixes: 82a823833f4e ("PCI: qcom: Add Qualcomm PCIe controller driver") > Cc: sta...@vger.kernel.org # v4.19+ > --- > drivers/pci/controller/dwc/pcie-qcom.c

Re: [PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-31 Thread Bjorn Andersson
On Tue 01 Sep 03:42 UTC 2020, Rob Clark wrote: > On Mon, Aug 31, 2020 at 7:35 PM Bjorn Andersson > wrote: > > > > On Fri 14 Aug 02:40 UTC 2020, Rob Clark wrote: > > > > > From: Rob Clark > > > > > > Currently it doesn't matter, since we

Re: [PATCH 01/19] drm/msm: remove dangling submitqueue references

2020-08-31 Thread Bjorn Andersson
On Fri 14 Aug 02:40 UTC 2020, Rob Clark wrote: > From: Rob Clark > > Currently it doesn't matter, since we free the ctx immediately. But > when we start refcnt'ing the ctx, we don't want old dangling list > entries to hang around. > > Signed-off-by: Rob Clark Reviewe

Re: [PATCH 19/19] drm/msm: show process names in gem_describe

2020-08-31 Thread Bjorn Andersson
On Thu 13 Aug 21:41 CDT 2020, Rob Clark wrote: > From: Rob Clark > > In $debugfs/gem we already show any vma(s) associated with an object. > Also show process names if the vma's address space is a per-process > address space. > Reviewed-by: Bjorn Andersson > Sig

<    4   5   6   7   8   9   10   11   12   13   >