Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Bob Liu
On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > [...] >> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t >> count) >> +{ >> +/* >> + * Prevent new req

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Bob Liu
On 07/27/2016 06:59 PM, Roger Pau Monné wrote: > On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote: > [...] >> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t >> count) >> +{ >> +/* >> + * Prevent new req

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Bob Liu
On 07/27/2016 04:07 PM, Roger Pau Monné wrote: ..[snip].. >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info >> *info) >> return; >> } >> >> +err = device_create_file(>xbdev->dev, >> _attr_max_ring_page_order); >> +if (err) >> +

Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-27 Thread Bob Liu
On 07/27/2016 04:07 PM, Roger Pau Monné wrote: ..[snip].. >> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info >> *info) >> return; >> } >> >> +err = device_create_file(>xbdev->dev, >> _attr_max_ring_page_order); >> +if (err) >> +

[PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v3: * Remove new_max_indirect_segments. * Fix BUG_ON(). v2: * Rename to max_ring_page_order. * Remove the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 277 -- 1 fi

[PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu -- v3: * Remove new_max_indirect_segments. * Fix BUG_ON(). v2: * Rename to max_ring_page_order. * Remove the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 277 -- 1 file changed, 269 inserti

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Bob Liu
On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-26 Thread Bob Liu
On 07/26/2016 04:44 PM, Roger Pau Monné wrote: > On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

[PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v2: Rename to max_ring_page_order and rm the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 275 +- 1 file changed, 269 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-25 Thread Bob Liu
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Move blkif_set_queue_limits()

[PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-25 Thread Bob Liu
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu --- v2: Move blkif_set_queue_limits() after blkfront_gather_backend_features

[PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu -- v2: Rename to max_ring_page_order and rm the waiting code suggested by Roger. --- drivers/block/xen-blkfront.c | 275 +- 1 file changed, 269 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c

[PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

2016-07-25 Thread Bob Liu
Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu <bob@oracle.com> Acked-by: Roger Pau Monné <roger@citrix.com> --- drivers/block/xen-blkfront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

2016-07-25 Thread Bob Liu
Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu Acked-by: Roger Pau Monné --- drivers/block/xen-blkfront.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 08:11 PM, Roger Pau Monné wrote: > On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: >> >> On 07/25/2016 06:53 PM, Roger Pau Monné wrote: >> ..[snip..] >>>>>> * We get the device lock and blk_mq_freeze_queue() in >>>>&g

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 08:11 PM, Roger Pau Monné wrote: > On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: >> >> On 07/25/2016 06:53 PM, Roger Pau Monné wrote: >> ..[snip..] >>>>>> * We get the device lock and blk_mq_freeze_queue() in >>>>&g

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 06:53 PM, Roger Pau Monné wrote: ..[snip..] * We get the device lock and blk_mq_freeze_queue() in dynamic_reconfig_device(), and then have to release in blkif_recover() asynchronously which makes the code more difficult to readable. >>> >>> I'm not sure I'm

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 06:53 PM, Roger Pau Monné wrote: ..[snip..] * We get the device lock and blk_mq_freeze_queue() in dynamic_reconfig_device(), and then have to release in blkif_recover() asynchronously which makes the code more difficult to readable. >>> >>> I'm not sure I'm

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: >> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 05:34

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: >> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 05:34

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 03:45

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >>>> >>>> On 07/22/2016 03:45

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >>>> >>>> On 07/21/

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >>>> >>>> On 07/21/

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: ..[snip].. >>>> + >>>> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, >&

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: ..[snip].. >>>> + >>>> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, >&

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Bob Liu
On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Bob Liu
On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect

Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-21 Thread Bob Liu
On 07/21/2016 04:29 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: >> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not >> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset >> limits &g

Re: [PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-21 Thread Bob Liu
On 07/21/2016 04:29 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote: >> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not >> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset >> limits &g

[PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

2016-07-15 Thread Bob Liu
Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/blo

[PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity

2016-07-15 Thread Bob Liu
Two places didn't get updated when 64KB page granularity was introduced, this patch fix them. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index fcc5b4e

[PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-15 Thread Bob Liu
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.

[PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-15 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu <bob@oracle.com> -- v2: Add device lock and other comments from Konrad. --- drivers/block/xen-blkfront.c | 285 ++- 1 file changed, 283 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/dr

[PATCH 2/3] xen-blkfront: introduce blkif_set_queue_limits()

2016-07-15 Thread Bob Liu
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits with initial correct values. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 91 1

[PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-15 Thread Bob Liu
s/vbd-xxx/max_queues Signed-off-by: Bob Liu -- v2: Add device lock and other comments from Konrad. --- drivers/block/xen-blkfront.c | 285 ++- 1 file changed, 283 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfron

Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
On 06/27/2016 04:33 PM, Bob Liu wrote: > Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() > during > migration, but that's too later after multi-queue introduced. > > After a migrate to another host (which may not have multiqueue support), the > numb

Re: [PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
On 06/27/2016 04:33 PM, Bob Liu wrote: > Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover() > during > migration, but that's too later after multi-queue introduced. > > After a migrate to another host (which may not have multiqueue support), the > numb

[PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
(). Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 91 +++- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2e6d1e9..fcc5b4e 100644 --- a/drivers

[PATCH] xen-blkfront: save uncompleted reqs in blkfront_resume()

2016-06-27 Thread Bob Liu
(). Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 91 +++- 1 file changed, 40 insertions(+), 51 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2e6d1e9..fcc5b4e 100644 --- a/drivers/block/xen-blkfront.c +++ b

[PATCH] drivers: virtio_blk: notify blk-core when hw-queue number changes

2016-06-13 Thread Bob Liu
A guest might be migrated to other hosts with different num_queues, the blk-core should aware of that else the reference of >vqs[qid] may be wrong. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/virtio_blk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/driv

[PATCH] drivers: virtio_blk: notify blk-core when hw-queue number changes

2016-06-13 Thread Bob Liu
A guest might be migrated to other hosts with different num_queues, the blk-core should aware of that else the reference of >vqs[qid] may be wrong. Signed-off-by: Bob Liu --- drivers/block/virtio_blk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/block/virtio_blk.c b/driv

Re: [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-06-08 Thread Bob Liu
On 06/07/2016 11:25 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 01, 2016 at 01:49:23PM +0800, Bob Liu wrote: >> >> On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: >>> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >>>> Sometimes blkfo

Re: [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-06-08 Thread Bob Liu
On 06/07/2016 11:25 PM, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 01, 2016 at 01:49:23PM +0800, Bob Liu wrote: >> >> On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: >>> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >>>> Sometimes blkfo

Re: [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-05-31 Thread Bob Liu
On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: > On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >> Sometimes blkfont may receive twice blkback_changed() notification after >> migration, then talk_to_blkback() will be called twice too and confused >> xen-bl

Re: [PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-05-31 Thread Bob Liu
On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote: > On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote: >> Sometimes blkfont may receive twice blkback_changed() notification after >> migration, then talk_to_blkback() will be called twice too and confused >> xen-bl

[PATCH 2/2] xen-blkfront: fix resume issues

2016-05-31 Thread Bob Liu
store rinfo pointer to hctx->driver_data, because rinfo may be * reallocated so using hctx->queue_num to get the rinfo structure instead. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 20 1 file changed, 8 insertions(+), 12 deleti

[PATCH 2/2] xen-blkfront: fix resume issues

2016-05-31 Thread Bob Liu
store rinfo pointer to hctx->driver_data, because rinfo may be * reallocated so using hctx->queue_num to get the rinfo structure instead. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-05-31 Thread Bob Liu
Sometimes blkfont may receive twice blkback_changed() notification after migration, then talk_to_blkback() will be called twice too and confused xen-blkback. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 1/2] xen-blkfront: don't call talk_to_blkback when already connected to blkback

2016-05-31 Thread Bob Liu
Sometimes blkfont may receive twice blkback_changed() notification after migration, then talk_to_blkback() will be called twice too and confused xen-blkback. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH] dm: drop unnecessary assignment of md->queue

2016-02-24 Thread Bob Liu
md->queue and q are the same thing in dm_init_request_based_queue() and dm_init_request_based_blk_mq_queue(). Also drop the temporary struct request_queue *q. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/md/dm.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions

[PATCH] dm: drop unnecessary assignment of md->queue

2016-02-24 Thread Bob Liu
md->queue and q are the same thing in dm_init_request_based_queue() and dm_init_request_based_blk_mq_queue(). Also drop the temporary struct request_queue *q. Signed-off-by: Bob Liu --- drivers/md/dm.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/md/d

Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree

2015-12-30 Thread Bob Liu
On 12/31/2015 04:39 AM, Dan Williams wrote: > On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu wrote: >> Hi Ross, >> >> On 12/24/2015 03:39 AM, Ross Zwisler wrote: >>> Add support for tracking dirty DAX entries in the struct address_space >>> radix tree. T

Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree

2015-12-30 Thread Bob Liu
Hi Ross, On 12/24/2015 03:39 AM, Ross Zwisler wrote: > Add support for tracking dirty DAX entries in the struct address_space > radix tree. This tree is already used for dirty page writeback, and it > already supports the use of exceptional (non struct page*) entries. > > In order to properly

Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree

2015-12-30 Thread Bob Liu
On 12/31/2015 04:39 AM, Dan Williams wrote: > On Wed, Dec 30, 2015 at 12:02 AM, Bob Liu <bob@oracle.com> wrote: >> Hi Ross, >> >> On 12/24/2015 03:39 AM, Ross Zwisler wrote: >>> Add support for tracking dirty DAX entries in the struct address_space >&g

Re: [PATCH v6 2/7] dax: support dirty DAX entries in radix tree

2015-12-30 Thread Bob Liu
Hi Ross, On 12/24/2015 03:39 AM, Ross Zwisler wrote: > Add support for tracking dirty DAX entries in the struct address_space > radix tree. This tree is already used for dirty page writeback, and it > already supports the use of exceptional (non struct page*) entries. > > In order to properly

[PATCH] xen-blkback: fix two memleaks

2015-12-09 Thread Bob Liu
ed-off-by: Bob Liu --- drivers/block/xen-blkback/xenbus.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 44396b8..dabdb18 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers

[PATCH] xen-blkback: fix two memleaks

2015-12-09 Thread Bob Liu
ed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/xenbus.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 44396b8..dabdb18 100644 --- a/drivers/block/xen-blkb

[PATCH] xen-blkback: make st_ statistics per ring

2015-12-08 Thread Bob Liu
Make st_* statistics per ring and the VBD sysfs would iterate over all the rings. Note: xenvbd_sysfs_delif() is called in xen_blkbk_remove() before all rings are torn down, so it's safe. This patch was based on konrad/xen.git/for-jens-4.5. Signed-off-by: Bob Liu --- drivers/block/xen-blkback

[PATCH] xen-blkback: make st_ statistics per ring

2015-12-08 Thread Bob Liu
Make st_* statistics per ring and the VBD sysfs would iterate over all the rings. Note: xenvbd_sysfs_delif() is called in xen_blkbk_remove() before all rings are torn down, so it's safe. This patch was based on konrad/xen.git/for-jens-4.5. Signed-off-by: Bob Liu <bob@oracle.

Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-25 Thread Bob Liu
On 11/26/2015 10:57 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 10:28:10AM +0800, Bob Liu wrote: >> >> On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: >>> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >>>> On W

Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-25 Thread Bob Liu
On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk wrote: xen/blkback: separate ring information out of struct xen_blkif xen/blkback: pseudo

Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-25 Thread Bob Liu
On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk wrote: xen/blkback: separate ring information out of struct xen_blkif xen/blkback: pseudo

Re: [PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-25 Thread Bob Liu
On 11/26/2015 10:57 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Nov 26, 2015 at 10:28:10AM +0800, Bob Liu wrote: >> >> On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote: >>> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote: >>>> On W

Re: [PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-16 Thread Bob Liu
On 11/17/2015 05:27 AM, Konrad Rzeszutek Wilk wrote: >> /* Common code used when first setting up, and when resuming. */ >> static int talk_to_blkback(struct xenbus_device *dev, >> @@ -1527,10 +1582,9 @@ static int talk_to_blkback(struct xenbus_device *dev, >> { >> const char *message =

Re: [PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-16 Thread Bob Liu
On 11/17/2015 05:27 AM, Konrad Rzeszutek Wilk wrote: >> /* Common code used when first setting up, and when resuming. */ >> static int talk_to_blkback(struct xenbus_device *dev, >> @@ -1527,10 +1582,9 @@ static int talk_to_blkback(struct xenbus_device *dev, >> { >> const char *message =

[PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-13 Thread Bob Liu
/agrcy2pbzbsvmwv/iops.png?dl=0 --- v5: * Rebase to xen/tip.git tags/for-linus-4.4-rc0-tag. * Comments from Konrad. v4: * Rebase to v4.3-rc7. * Comments from Roger. v3: * Rebased to v4.2-rc8. Bob Liu (10): xen/blkif: document blkif multi-queue/ring extension xen/blkfront: separate per ring

[PATCH v5 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

2015-11-13 Thread Bob Liu
Preparatory patch for multiple hardware queues (rings). The number of rings is unconditionally set to 1, larger number will be enabled in next patch("xen/blkfront: negotiate number of queues/rings to be used with backend") so as to make every single patch small and readable. Signed-o

[PATCH v5 06/10] xen/blkback: separate ring information out of struct xen_blkif

2015-11-13 Thread Bob Liu
reparation for supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- v2: * Have an BUG_ON on the holding of the pers_gnts_lock. --- drivers/block/xen-blkback/blkback.c | 235 --- drivers/block/xen-blkback/common.h | 54 ---

[PATCH v5 02/10] xen/blkfront: separate per ring information out of device info

2015-11-13 Thread Bob Liu
i hardware queues/rings. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- v2: Fix build error. --- drivers/block/xen-blkfront.c | 359 +++--- 1 file changed, 197 insertions(+), 162 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers

[PATCH v5 08/10] xen/blkback: get the number of hardware queues/rings from blkfront

2015-11-13 Thread Bob Liu
Backend advertises "multi-queue-max-queues" to front, also get the negotiated number from "multi-queue-num-queues" written by blkfront. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h |1 + drive

[PATCH v5 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

2015-11-13 Thread Bob Liu
't drop if incresing queue numbers. Please find the respective chart in this link: https://www.dropbox.com/s/agrcy2pbzbsvmwv/iops.png?dl=0 Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 202 --- drivers/block/xen-blkback/common.h | 32 +++--

[PATCH v5 04/10] xen/blkfront: split per device io_lock

2015-11-13 Thread Bob Liu
h protects the ->grants list and persistent_gnts_c shared by all rings. Signed-off-by: Bob Liu --- v2: * Introduce kick_pending_request_queues_locked(). * Add comment for 'ring_lock'. * Move locks to more suitable place. --- drivers/block/xen-blkf

[PATCH v5 09/10] xen/blkfront: make persistent grants pool per-queue

2015-11-13 Thread Bob Liu
1230(~20%) 1024(~20%) 850(~20%) Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 110 +- 1 file changed, 43 insertions(+), 67 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 84496be..451f852 100644 ---

[PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-13 Thread Bob Liu
as "multi-queue-num-queues", blkback needs to read this negotiated number. Signed-off-by: Bob Liu --- v2: * Make 'i' be an unsigned int. * Other comments from Konrad. --- drivers/block/xen-blkfront.c | 160 +++--- 1 file changed, 119 insertions(+), 41

[PATCH v5 07/10] xen/blkback: pseudo support for multi hardware queues/rings

2015-11-13 Thread Bob Liu
y: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkback/common.h |3 +- drivers/block/xen-blkback/xenbus.c | 277 ++-- 2 files changed, 175 insertions(+), 105 deletions(-) diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/x

[PATCH v5 01/10] xen/blkif: document blkif multi-queue/ring extension

2015-11-13 Thread Bob Liu
Document the multi-queue/ring feature in terms of XenStore keys to be written by the backend and by the frontend. Signed-off-by: Bob Liu --- v2: Add descriptions together with multi-page ring buffer. --- include/xen/interface/io/blkif.h | 48 ++ 1 file

[PATCH v5 01/10] xen/blkif: document blkif multi-queue/ring extension

2015-11-13 Thread Bob Liu
Document the multi-queue/ring feature in terms of XenStore keys to be written by the backend and by the frontend. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Add descriptions together with multi-page ring buffer. --- include/xen/interface/io/blkif.h

[PATCH v5 07/10] xen/blkback: pseudo support for multi hardware queues/rings

2015-11-13 Thread Bob Liu
y: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/common.h |3 +- drivers/block/xen-blkback/xenbus.c | 277 ++-- 2 files changed, 175 insertions(+), 105 deletions(-) diff --g

[PATCH v5 04/10] xen/blkfront: split per device io_lock

2015-11-13 Thread Bob Liu
h protects the ->grants list and persistent_gnts_c shared by all rings. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Introduce kick_pending_request_queues_locked(). * Add comment for 'ring_lock'. * Move locks to more suitable place. --- drivers/block/xe

[PATCH v5 09/10] xen/blkfront: make persistent grants pool per-queue

2015-11-13 Thread Bob Liu
1230(~20%) 1024(~20%) 850(~20%) Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 110 +- 1 file changed, 43 insertions(+), 67 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index

[PATCH v5 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-13 Thread Bob Liu
as "multi-queue-num-queues", blkback needs to read this negotiated number. Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Make 'i' be an unsigned int. * Other comments from Konrad. --- drivers/block/xen-blkfront.c | 160 +++--- 1 f

[PATCH v5 06/10] xen/blkback: separate ring information out of struct xen_blkif

2015-11-13 Thread Bob Liu
reparation for supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- v2: * Have an BUG_ON on the holding of the pers_gnts_lock. --- drivers/block/xen-blkback/blkback.c | 235

[PATCH v5 02/10] xen/blkfront: separate per ring information out of device info

2015-11-13 Thread Bob Liu
i hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- v2: Fix build error. --- drivers/block/xen-blkfront.c | 359 +++--- 1 file changed, 197 insertions(+), 162 deletions(-)

[PATCH v5 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

2015-11-13 Thread Bob Liu
't drop if incresing queue numbers. Please find the respective chart in this link: https://www.dropbox.com/s/agrcy2pbzbsvmwv/iops.png?dl=0 Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 202 --- drivers/block/xe

[PATCH v5 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

2015-11-13 Thread Bob Liu
Preparatory patch for multiple hardware queues (rings). The number of rings is unconditionally set to 1, larger number will be enabled in next patch("xen/blkfront: negotiate number of queues/rings to be used with backend") so as to make every single patch small and readable. Signed-o

[PATCH v5 00/10] xen-block: multi hardware-queues/rings support

2015-11-13 Thread Bob Liu
/agrcy2pbzbsvmwv/iops.png?dl=0 --- v5: * Rebase to xen/tip.git tags/for-linus-4.4-rc0-tag. * Comments from Konrad. v4: * Rebase to v4.3-rc7. * Comments from Roger. v3: * Rebased to v4.2-rc8. Bob Liu (10): xen/blkif: document blkif multi-queue/ring extension xen/blkfront: separate per ring

[PATCH v5 08/10] xen/blkback: get the number of hardware queues/rings from blkfront

2015-11-13 Thread Bob Liu
Backend advertises "multi-queue-max-queues" to front, also get the negotiated number from "multi-queue-num-queues" written by blkfront. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/c

Re: [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings

2015-11-04 Thread Bob Liu
On 11/05/2015 10:30 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:43PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [PATCH v4 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

2015-11-04 Thread Bob Liu
On 11/05/2015 10:43 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:46PM +0800, Bob Liu wrote: >> Make pool of persistent grants and free pages per-queue/ring instead of >> per-device to get better scalability. > > How much better scalability do we get? >

Re: [PATCH v4 07/10] xen/blkback: pseudo support for multi hardware queues/rings

2015-11-04 Thread Bob Liu
On 11/05/2015 10:30 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:43PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [PATCH v4 10/10] xen/blkback: make pool of persistent grants and free pages per-queue

2015-11-04 Thread Bob Liu
On 11/05/2015 10:43 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:46PM +0800, Bob Liu wrote: >> Make pool of persistent grants and free pages per-queue/ring instead of >> per-device to get better scalability. > > How much better scalability do we get? >

Re: [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-03 Thread Bob Liu
On 11/04/2015 04:40 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:41PM +0800, Bob Liu wrote: >> The number of hardware queues for xen/blkfront is set by parameter >> 'max_queues'(default 4), while the max value xen/blkback supported is >> notified >&

Re: [PATCH v4 04/10] xen/blkfront: split per device io_lock

2015-11-03 Thread Bob Liu
On 11/04/2015 04:09 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:40PM +0800, Bob Liu wrote: >> The per device io_lock became a coarser grained lock after multi-queues/rings >> was introduced, this patch introduced a fine-grained ring_lock for each ring. >

Re: [PATCH v4 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

2015-11-03 Thread Bob Liu
On 11/04/2015 03:44 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:39PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [PATCH v4 03/10] xen/blkfront: pseudo support for multi hardware queues/rings

2015-11-03 Thread Bob Liu
On 11/04/2015 03:44 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:39PM +0800, Bob Liu wrote: >> Preparatory patch for multiple hardware queues (rings). The number of >> rings is unconditionally set to 1, larger number will be enabled in next >> patch so as

Re: [PATCH v4 04/10] xen/blkfront: split per device io_lock

2015-11-03 Thread Bob Liu
On 11/04/2015 04:09 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:40PM +0800, Bob Liu wrote: >> The per device io_lock became a coarser grained lock after multi-queues/rings >> was introduced, this patch introduced a fine-grained ring_lock for each ring. >

Re: [PATCH v4 05/10] xen/blkfront: negotiate number of queues/rings to be used with backend

2015-11-03 Thread Bob Liu
On 11/04/2015 04:40 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Nov 02, 2015 at 12:21:41PM +0800, Bob Liu wrote: >> The number of hardware queues for xen/blkfront is set by parameter >> 'max_queues'(default 4), while the max value xen/blkback supported is >> notified >&

Re: [PATCH v4 02/10] xen/blkfront: separate per ring information out of device info

2015-11-01 Thread Bob Liu
On 11/02/2015 12:49 PM, kbuild test robot wrote: > Hi Bob, > > [auto build test ERROR on v4.3-rc7 -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/commits/Bob-Liu/xen-block-multi-

[PATCH v4 00/10] xen-block: multi hardware-queues/rings support

2015-11-01 Thread Bob Liu
e and real SSD storage. --- v4: * Rebase to v4.3-rc7 * Comments from Roger v3: * Rebased to v4.2-rc8 Bob Liu (10): xen/blkif: document blkif multi-queue/ring extension xen/blkfront: separate per ring information out of device info xen/blkfront: pseudo support for multi hardware queues/r

<    1   2   3   4   5   6   7   8   9   >