[PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-20 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 118 +++--- 1 file changed, 66 insertions(+), 52 deletions(-) diff --git a/drivers/block

[PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-20 Thread Bob Liu
This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-20 Thread Bob Liu
This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info->indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |1 - 1 file changed, 1 deletion(-) diff --git a/driv

[PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-20 Thread Bob Liu
This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-20 Thread Bob Liu
This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c |1 - 1 file changed, 1 deletion(-) diff

[PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-20 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 118 +++--- 1 file changed, 66 insertions(+), 52 deletions(-) diff --git

[PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-07-13 Thread Bob Liu
dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Change in v3: - Rename blk_mq_queue_rq to blkif_queue_rq Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu Revie

[PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-07-13 Thread Bob Liu
-by: Bob Liu bob@oracle.com Reviewed-by: Christoph Hellwig h...@lst.de Acked-by: Jens Axboe ax...@fb.com --- drivers/block/xen-blkfront.c | 146 +- 1 file changed, 60 insertions(+), 86 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block

Re: [PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/12/2015 02:14 AM, Jens Axboe wrote: > On 07/11/2015 07:30 AM, Bob Liu wrote: >> Note: This patch is based on original work of Arianna's internship for >> GNOME's Outreach Program for Women. > > Great to see this finally get prepped to go in! > >> Only one

[PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: >> From: Arianna Avanzini >> >> This patch converts xen-blkfront driver to use the block multiqueue APIs. >> Only one hardware queue is used now, so the

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: From: Arianna Avanzini avanzini.aria...@gmail.com This patch converts xen-blkfront driver to use the block multiqueue APIs. Only one hardware queue is used now, so

[PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
dropped one unnecessary holding of info-io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Signed-off-by: Arianna Avanzini avanzini.aria...@gmail.com Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen

Re: [PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/12/2015 02:14 AM, Jens Axboe wrote: On 07/11/2015 07:30 AM, Bob Liu wrote: Note: This patch is based on original work of Arianna's internship for GNOME's Outreach Program for Women. Great to see this finally get prepped to go in! Only one hardware queue is used now, so

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
t; Signed-off-by: Julien Grall Also hit the same issue, thank you for the fix. Tested-by: Bob Liu > Cc: Bernhard Thaler > Cc: Pablo Neira Ayuso > Cc: f...@strlen.de > Cc: ian.campb...@citrix.com > Cc: wei.l...@citrix.com > > --- > Note that it's impossible to crea

[RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-06 Thread Bob Liu
unnecessary holding of info->io_lock when calling into blk-mq APIs. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 173 ++ 1 file changed, 73 insertions(+), 100 deletions(-) diff --git a/drivers/block/

[RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-06 Thread Bob Liu
, and nvme. Also dropped unnecessary holding of info-io_lock when calling into blk-mq APIs. Signed-off-by: Arianna Avanzini avanzini.aria...@gmail.com Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 173 ++ 1 file changed, 73

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
issue, thank you for the fix. Tested-by: Bob Liu bob@oracle.com Cc: Bernhard Thaler bernhard.tha...@wvnet.at Cc: Pablo Neira Ayuso pa...@netfilter.org Cc: f...@strlen.de Cc: ian.campb...@citrix.com Cc: wei.l...@citrix.com --- Note that it's impossible to create new guest after

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-06-30 Thread Bob Liu
On 06/30/2015 10:21 PM, Marcus Granado wrote: > On 13/05/15 11:29, Bob Liu wrote: >> >> On 04/28/2015 03:46 PM, Arianna Avanzini wrote: >>> Hello Christoph, >>> >>> Il 28/04/2015 09:36, Christoph Hellwig ha scritto: >>>> What happened to t

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-06-30 Thread Bob Liu
On 06/30/2015 10:21 PM, Marcus Granado wrote: On 13/05/15 11:29, Bob Liu wrote: On 04/28/2015 03:46 PM, Arianna Avanzini wrote: Hello Christoph, Il 28/04/2015 09:36, Christoph Hellwig ha scritto: What happened to this patchset? It was passed on to Bob Liu, who published a follow-up

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-21 Thread Bob Liu
On 06/09/2015 10:07 PM, Roger Pau Monné wrote: > El 09/06/15 a les 15.39, Konrad Rzeszutek Wilk ha escrit: ... >> Roger, I put them (patches) on devel/for-jens-4.2 on >> >> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git >> >> I think these two patches: >> drivers: xen-blkback: delay

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-21 Thread Bob Liu
On 06/09/2015 10:07 PM, Roger Pau Monné wrote: El 09/06/15 a les 15.39, Konrad Rzeszutek Wilk ha escrit: ... Roger, I put them (patches) on devel/for-jens-4.2 on git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git I think these two patches: drivers: xen-blkback: delay pending_req

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/09/2015 09:39 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Jun 09, 2015 at 08:52:53AM +, Paul Durrant wrote: >>> -Original Message- >>> From: Bob Liu [mailto:bob@oracle.com] >>> Sent: 09 June 2015 09:50 >>> To: Bob Liu >>>

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/03/2015 01:40 PM, Bob Liu wrote: > Extend xen/block to support multi-page ring, so that more requests can be > issued by using more than one pages as the request ring between blkfront > and backend. > As a result, the performance can get improved significantly. > > We g

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/03/2015 01:40 PM, Bob Liu wrote: Extend xen/block to support multi-page ring, so that more requests can be issued by using more than one pages as the request ring between blkfront and backend. As a result, the performance can get improved significantly. We got some impressive

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/09/2015 09:39 PM, Konrad Rzeszutek Wilk wrote: On Tue, Jun 09, 2015 at 08:52:53AM +, Paul Durrant wrote: -Original Message- From: Bob Liu [mailto:bob@oracle.com] Sent: 09 June 2015 09:50 To: Bob Liu Cc: xen-de...@lists.xen.org; David Vrabel; just...@spectralogic.com

[PATCH 3/3] xen/block: add multi-page ring support

2015-06-02 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify with 4k granularity to comment - Address more comments from Roger Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 13 drivers/block/xen-blkback

[PATCH 1/3] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-02 Thread Bob Liu
This is a pre-patch for multi-page ring feature. In connect_ring, we can know exactly how many pages are used for the shared ring, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/common.h |2 +- drivers/block/xen

[PATCH 2/3] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-06-02 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu Acked-by: Roger Pau Monné --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8

[PATCH 2/3] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-06-02 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu bob@oracle.com Acked-by: Roger Pau Monné roger@citrix.com --- drivers/block/xen-blkfront.c | 14

[PATCH 3/3] xen/block: add multi-page ring support

2015-06-02 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify with 4k granularity to comment - Address more comments from Roger Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 13 drivers

[PATCH 1/3] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-02 Thread Bob Liu
This is a pre-patch for multi-page ring feature. In connect_ring, we can know exactly how many pages are used for the shared ring, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/common.h |2

Re: [PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-01 Thread Bob Liu
On 06/01/2015 04:36 PM, Roger Pau Monné wrote: > El 26/05/15 a les 2.06, Bob Liu ha escrit: >> In connect_ring, we can know exactly how many pages are used for the shared >> ring and also whether feature-persistent is enabled, delay pending_req >> allocation here so that we

Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-06-01 Thread Bob Liu
On 06/01/2015 03:50 PM, Roger Pau Monné wrote: > El 26/05/15 a les 2.11, Bob Liu ha escrit: >> When migrate from !feature-persistent host to feature-persistent host, domU >> still think new host/backend don't support persistent. >> Dmesg like: >> backed has not unmapp

Re: [PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-01 Thread Bob Liu
On 06/01/2015 04:36 PM, Roger Pau Monné wrote: El 26/05/15 a les 2.06, Bob Liu ha escrit: In connect_ring, we can know exactly how many pages are used for the shared ring and also whether feature-persistent is enabled, delay pending_req allocation here so that we won't waste too much memory

Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-06-01 Thread Bob Liu
On 06/01/2015 03:50 PM, Roger Pau Monné wrote: El 26/05/15 a les 2.11, Bob Liu ha escrit: When migrate from !feature-persistent host to feature-persistent host, domU still think new host/backend don't support persistent. Dmesg like: backed has not unmapped grant: 839 backed has not unmapped

[PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-05-25 Thread Bob Liu
not unmapped grant: 839 We should recheck whether the new backend support feature-persistent during blkif_recover(). Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen

[PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-05-25 Thread Bob Liu
In connect_ring, we can know exactly how many pages are used for the shared ring and also whether feature-persistent is enabled, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen

[PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-05-25 Thread Bob Liu
not unmapped grant: 839 We should recheck whether the new backend support feature-persistent during blkif_recover(). Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b

[PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-05-25 Thread Bob Liu
In connect_ring, we can know exactly how many pages are used for the shared ring and also whether feature-persistent is enabled, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/common.h | 3

Re: [PATCH v5 2/2] xen/block: add multi-page ring support

2015-05-22 Thread Bob Liu
On 05/22/2015 04:31 PM, Paul Durrant wrote: >> -Original Message- >> From: Bob Liu [mailto:bob@oracle.com] >> Sent: 22 May 2015 01:00 >> To: xen-de...@lists.xen.org >> Cc: David Vrabel; just...@spectralogic.com; konrad.w...@oracle.com; Roger >> P

Re: [PATCH v5 2/2] xen/block: add multi-page ring support

2015-05-22 Thread Bob Liu
On 05/22/2015 04:31 PM, Paul Durrant wrote: -Original Message- From: Bob Liu [mailto:bob@oracle.com] Sent: 22 May 2015 01:00 To: xen-de...@lists.xen.org Cc: David Vrabel; just...@spectralogic.com; konrad.w...@oracle.com; Roger Pau Monne; Paul Durrant; Julien Grall; boris.ostrov

[PATCH v5 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify 4k granularity to comment. - Address more comments from Roger. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 13 drivers/block/xen-blkback

[PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-05-21 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu Acked-by: Roger Pau Monné --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8

Re: [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Bob Liu
On 05/21/2015 07:22 PM, Roger Pau Monné wrote: > El 20/05/15 a les 15.10, Bob Liu ha escrit: ... >> +} else { >> +unsigned int i; >> + >> +if (ring_page_order > xen_blkif_max_ring_order) { >> +err = -EINVAL; >

Re: [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Bob Liu
On 05/21/2015 07:22 PM, Roger Pau Monné wrote: El 20/05/15 a les 15.10, Bob Liu ha escrit: ... +} else { +unsigned int i; + +if (ring_page_order xen_blkif_max_ring_order) { +err = -EINVAL; +xenbus_dev_fatal(dev, err, %s

[PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-05-21 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu bob@oracle.com Acked-by: Roger Pau Monné roger@citrix.com --- drivers/block/xen-blkfront.c | 14

[PATCH v5 2/2] xen/block: add multi-page ring support

2015-05-21 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify 4k granularity to comment. - Address more comments from Roger. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 13 drivers/block

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
On 05/20/2015 11:00 PM, Julien Grall wrote: > On 20/05/15 15:56, Roger Pau Monné wrote: >> El 20/05/15 a les 15.21, Julien Grall ha escrit: >>> Hi, >>> >>> On 20/05/15 14:10, Bob Liu wrote: >>>> --- >>>> drivers/block/xen-blkback/b

[PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-05-20 Thread Bob Liu
it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
Changes in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen-blkback/xenbus.c | 85

[PATCH v2 1/2] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-05-20 Thread Bob Liu
it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions

[PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
Changes in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen-blkback/xenbus.c | 85

Re: [Xen-devel] [PATCH v4 2/2] xen/block: add multi-page ring support

2015-05-20 Thread Bob Liu
On 05/20/2015 11:00 PM, Julien Grall wrote: On 20/05/15 15:56, Roger Pau Monné wrote: El 20/05/15 a les 15.21, Julien Grall ha escrit: Hi, On 20/05/15 14:10, Bob Liu wrote: --- drivers/block/xen-blkback/blkback.c | 12 drivers/block/xen-blkback/common.h | 3 +- drivers/block

Re: [PATCH v3 2/2] xen/block: add multi-page ring support

2015-05-15 Thread Bob Liu
On 05/15/2015 07:13 PM, Roger Pau Monné wrote: > El 12/05/15 a les 13.01, Bob Liu ha escrit: >> Extend xen/block to support multi-page ring, so that more requests can be >> issued >> by using more than one pages as the request ring between blkfront and >&

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 07:14 PM, Roger Pau Monné wrote: > El 15/05/15 a les 13.03, Bob Liu ha escrit: >> >> On 05/15/2015 06:01 PM, Roger Pau Monné wrote: >>> El 12/05/15 a les 13.01, Bob Liu ha escrit: >>>> The right place for talk_to_blkback() to query

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 06:01 PM, Roger Pau Monné wrote: > El 12/05/15 a les 13.01, Bob Liu ha escrit: >> The right place for talk_to_blkback() to query backend features and transport >> parameters is after backend entered XenbusStateInitWait. There is no problem > > talk_to_blkba

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 06:01 PM, Roger Pau Monné wrote: El 12/05/15 a les 13.01, Bob Liu ha escrit: The right place for talk_to_blkback() to query backend features and transport parameters is after backend entered XenbusStateInitWait. There is no problem talk_to_blkback doesn't gather any backend

Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-15 Thread Bob Liu
On 05/15/2015 07:14 PM, Roger Pau Monné wrote: El 15/05/15 a les 13.03, Bob Liu ha escrit: On 05/15/2015 06:01 PM, Roger Pau Monné wrote: El 12/05/15 a les 13.01, Bob Liu ha escrit: The right place for talk_to_blkback() to query backend features and transport parameters is after backend

Re: [PATCH v3 2/2] xen/block: add multi-page ring support

2015-05-15 Thread Bob Liu
On 05/15/2015 07:13 PM, Roger Pau Monné wrote: El 12/05/15 a les 13.01, Bob Liu ha escrit: Extend xen/block to support multi-page ring, so that more requests can be issued by using more than one pages as the request ring between blkfront and backend. As a result, the performance can get

Re: [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-05-13 Thread Bob Liu
On 04/28/2015 03:46 PM, Arianna Avanzini wrote: > Hello Christoph, > > Il 28/04/2015 09:36, Christoph Hellwig ha scritto: >> What happened to this patchset? >> > > It was passed on to Bob Liu, who published a follow-up patchset here: > https://lkml.org/lkml/2015

Re: [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-05-13 Thread Bob Liu
On 04/28/2015 03:46 PM, Arianna Avanzini wrote: Hello Christoph, Il 28/04/2015 09:36, Christoph Hellwig ha scritto: What happened to this patchset? It was passed on to Bob Liu, who published a follow-up patchset here: https://lkml.org/lkml/2015/2/15/46 Right, and then I

[PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-12 Thread Bob Liu
XenbusStateConnected Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2c61cf8..88e23fd 100644 --- a/drivers/block/xen-blkfront.c +++ b

[PATCH v3 2/2] xen/block: add multi-page ring support

2015-05-12 Thread Bob Liu
, 32 was really not enough to keep them busy. Changes in v2: - Rebased to 4.0-rc6 - Added description on how this protocol works into io/blkif.h Changes in v3: - Follow the protocol defined in io/blkif.h on XEN tree Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 14

[PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place

2015-05-12 Thread Bob Liu
XenbusStateConnected Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 2c61cf8..88e23fd 100644 --- a/drivers/block/xen

[PATCH v3 2/2] xen/block: add multi-page ring support

2015-05-12 Thread Bob Liu
, 32 was really not enough to keep them busy. Changes in v2: - Rebased to 4.0-rc6 - Added description on how this protocol works into io/blkif.h Changes in v3: - Follow the protocol defined in io/blkif.h on XEN tree Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback

Re: linux-next: build failure after merge of the xen-tip tree

2015-04-13 Thread Bob Liu
issue, I missed the xentpm-front.c file in that patch. (Original patch from Wei Liu already included the right modification which didn't exist in Paul's.) Attached patch should fix this build failure. -- Regards, -Bob >From 973eacee793595b9790957186ffd27f192f5dd4f Mon Sep 17 00:00:00 2001 From: Bob

Re: linux-next: build failure after merge of the xen-tip tree

2015-04-13 Thread Bob Liu
-front.c file in that patch. (Original patch from Wei Liu already included the right modification which didn't exist in Paul's.) Attached patch should fix this build failure. -- Regards, -Bob From 973eacee793595b9790957186ffd27f192f5dd4f Mon Sep 17 00:00:00 2001 From: Bob Liu bob@oracle.com

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread Bob Liu
On 04/01/2015 06:18 PM, David Vrabel wrote: > On 26/03/15 12:16, Bob Liu wrote: >> There are several place using gnttab async unmap and wait for >> completion, so move the common code to a function >> gnttab_unmap_refs_async_wait_completion(). &g

Re: [PATCH v2 2/2] xen/block: add multi-page ring support

2015-04-01 Thread Bob Liu
On 03/31/2015 08:15 PM, Bob Liu wrote: > Extend xen/block to support multi-page ring, so that more requests can be > issued > by using more than one pages as the request ring between blkfront and backend. > As a result, the performance can get improved significantly. > > We g

Re: [PATCH v2 2/2] xen/block: add multi-page ring support

2015-04-01 Thread Bob Liu
On 03/31/2015 08:15 PM, Bob Liu wrote: Extend xen/block to support multi-page ring, so that more requests can be issued by using more than one pages as the request ring between blkfront and backend. As a result, the performance can get improved significantly. We got some impressive

Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-04-01 Thread Bob Liu
On 04/01/2015 06:18 PM, David Vrabel wrote: On 26/03/15 12:16, Bob Liu wrote: There are several place using gnttab async unmap and wait for completion, so move the common code to a function gnttab_unmap_refs_async_wait_completion(). [...] + +int gnttab_unmap_refs_async_wait_completion

Re: [PATCH RESEND 1/2] xenbus_client: Extend interface to support multi-page ring

2015-03-31 Thread Bob Liu
Hi Juergen, On 03/31/2015 08:36 PM, Juergen Gross wrote: > On 03/31/2015 02:15 PM, Bob Liu wrote: >> From: Wei Liu >> >> Originally Xen PV drivers only use single-page ring to pass along >> information. This might limit the throughput between frontend and >>

[PATCH v2 2/2] xen/block: add multi-page ring support

2015-03-31 Thread Bob Liu
, 32 was really not enough to keep them busy. Change in V2: * Rebased to 4.0-rc6 * Add description on how this protocol works into io/blkif.h Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 2 +- drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen-blkback/xenbus.c

[PATCH RESEND 1/2] xenbus_client: Extend interface to support multi-page ring

2015-03-31 Thread Bob Liu
aul Durrant Signed-off-by: Bob Liu Cc: Konrad Wilk Cc: David Vrabel Cc: Boris Ostrovsky --- drivers/block/xen-blkback/xenbus.c | 5 +- drivers/block/xen-blkfront.c | 5 +- drivers/net/xen-netback/netback.c | 4 +- drivers/net/xen-netfront.c | 9 +- drivers/pci/xen-pcifron

[PATCH RESEND 1/2] xenbus_client: Extend interface to support multi-page ring

2015-03-31 Thread Bob Liu
wei.l...@citrix.com Signed-off-by: Paul Durrant paul.durr...@citrix.com Signed-off-by: Bob Liu bob@oracle.com Cc: Konrad Wilk konrad.w...@oracle.com Cc: David Vrabel david.vra...@citrix.com Cc: Boris Ostrovsky boris.ostrov...@oracle.com --- drivers/block/xen-blkback/xenbus.c | 5 +- drivers/block

[PATCH v2 2/2] xen/block: add multi-page ring support

2015-03-31 Thread Bob Liu
, 32 was really not enough to keep them busy. Change in V2: * Rebased to 4.0-rc6 * Add description on how this protocol works into io/blkif.h Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 2 +- drivers/block/xen-blkback/common.h | 3 +- drivers/block/xen

Re: [PATCH RESEND 1/2] xenbus_client: Extend interface to support multi-page ring

2015-03-31 Thread Bob Liu
Hi Juergen, On 03/31/2015 08:36 PM, Juergen Gross wrote: On 03/31/2015 02:15 PM, Bob Liu wrote: From: Wei Liu wei.l...@citrix.com Originally Xen PV drivers only use single-page ring to pass along information. This might limit the throughput between frontend and backend. The patch extends

Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-03-29 Thread Bob Liu
On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: > On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: >> El 26/03/15 a les 13.16, Bob Liu ha escrit: >>> There are several place using gnttab async unmap and wait for >>> completion, so move th

Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-03-29 Thread Bob Liu
On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote: El 26/03/15 a les 13.16, Bob Liu ha escrit: There are several place using gnttab async unmap and wait for completion, so move the common code to a function

[PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-03-26 Thread Bob Liu
There are several place using gnttab async unmap and wait for completion, so move the common code to a function gnttab_unmap_refs_async_wait_completion(). Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 31 +++ drivers/xen/gntdev.c

[PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
her unless no longer in use. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 2a04d34..f59d7c3 100644 --- a/drivers

Re: [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
On 03/26/2015 07:15 PM, Roger Pau Monné wrote: > Hello, > > El 25/03/15 a les 11.02, Bob Liu ha escrit: >> +gnttab_unmap_refs_async(_data); >> +wait_for_completion(_completion); > > I think David had a comment about putting this into some ki

[PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
in use. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 2a04d34..f59d7c3 100644

[PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

2015-03-26 Thread Bob Liu
There are several place using gnttab async unmap and wait for completion, so move the common code to a function gnttab_unmap_refs_async_wait_completion(). Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 31 +++ drivers/xen/gntdev.c

Re: [PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-26 Thread Bob Liu
On 03/26/2015 07:15 PM, Roger Pau Monné wrote: Hello, El 25/03/15 a les 11.02, Bob Liu ha escrit: +gnttab_unmap_refs_async(unmap_data); +wait_for_completion(unmap_completion); I think David had a comment about putting this into some kind of common helper since

[PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-25 Thread Bob Liu
her unless no longer in use. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 2a04d34..f59d7c3 100644 --- a/drivers

[PATCH] xen/blkback: safely unmap purge persistent grants

2015-03-25 Thread Bob Liu
in use. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 2a04d34..f59d7c3 100644

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-17 Thread Bob Liu
On 03/17/2015 10:52 PM, Felipe Franciosi wrote: > Hi Bob, > > I've put the hardware back together and am sorting out the software for > testing. Things are not moving as fast as I wanted due to other commitments. > I'll keep this thread updated as I progress. Malcolm is OOO and I'm trying to

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-17 Thread Bob Liu
Hi Felipe, On 03/06/2015 06:30 PM, Felipe Franciosi wrote: >> -Original Message- >> From: Bob Liu [mailto:bob@oracle.com] >> Sent: 05 March 2015 00:47 >> To: Konrad Rzeszutek Wilk >> Cc: Roger Pau Monne; Felipe Franciosi; David Vrabel; xen-de...@

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-17 Thread Bob Liu
Hi Felipe, On 03/06/2015 06:30 PM, Felipe Franciosi wrote: -Original Message- From: Bob Liu [mailto:bob@oracle.com] Sent: 05 March 2015 00:47 To: Konrad Rzeszutek Wilk Cc: Roger Pau Monne; Felipe Franciosi; David Vrabel; xen-de...@lists.xen.org; linux-kernel@vger.kernel.org; ax

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-17 Thread Bob Liu
On 03/17/2015 10:52 PM, Felipe Franciosi wrote: Hi Bob, I've put the hardware back together and am sorting out the software for testing. Things are not moving as fast as I wanted due to other commitments. I'll keep this thread updated as I progress. Malcolm is OOO and I'm trying to get

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-04 Thread Bob Liu
On 03/05/2015 05:21 AM, Konrad Rzeszutek Wilk wrote: >>> David assertion that better performance and scalbility can be gained >>> with grant table locking and TLB flush avoidance is interesting - as >>> 1). The grant locking is going in Xen 4.6 but not earlier - so when running >>> on older

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-03-04 Thread Bob Liu
On 03/05/2015 05:21 AM, Konrad Rzeszutek Wilk wrote: David assertion that better performance and scalbility can be gained with grant table locking and TLB flush avoidance is interesting - as 1). The grant locking is going in Xen 4.6 but not earlier - so when running on older hypervisors

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-02-27 Thread Bob Liu
On 02/21/2015 02:59 AM, Konrad Rzeszutek Wilk wrote: >> >> Agree, Life would be easier if we can remove the persistent feature. > > ..snip.. > > If Konrad/Bob agree I would like to send a patch to remove persistent > grants and then have the multiqueue series rebased on top

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-02-27 Thread Bob Liu
On 02/21/2015 02:59 AM, Konrad Rzeszutek Wilk wrote: Agree, Life would be easier if we can remove the persistent feature. ..snip.. If Konrad/Bob agree I would like to send a patch to remove persistent grants and then have the multiqueue series rebased on top of that. ..snip.. I agree

Re: [PATCH 03/10] xen/blkfront: reorg info->io_lock after using blk-mq API

2015-02-18 Thread Bob Liu
On 02/19/2015 01:05 AM, Christoph Hellwig wrote: > On Sun, Feb 15, 2015 at 04:18:58PM +0800, Bob Liu wrote: >> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c >> index 3589436..5a90a51 100644 >> --- a/drivers/block/xen-blkfront.c >> +++ b/d

Re: [RFC PATCH 00/10] Multi-queue support for xen-block driver

2015-02-18 Thread Bob Liu
On 02/19/2015 02:22 AM, Felipe Franciosi wrote: > > >> -Original Message----- >> From: Bob Liu [mailto:bob@oracle.com] >> Sent: 15 February 2015 08:19 >> To: xen-de...@lists.xen.org >> Cc: David Vrabel; linux-kernel@vger.kernel.org; Roger Pau Monn

Re: [PATCH 04/10] xen/blkfront: separate ring information to an new struct

2015-02-18 Thread Bob Liu
On 02/19/2015 02:08 AM, Felipe Franciosi wrote: >> -Original Message- >> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] >> Sent: 18 February 2015 17:38 >> To: Roger Pau Monne >> Cc: Bob Liu; xen-de...@lists.xen.org; David Vrabel; linux- >

Re: [PATCH 03/10] xen/blkfront: reorg info-io_lock after using blk-mq API

2015-02-18 Thread Bob Liu
On 02/19/2015 01:05 AM, Christoph Hellwig wrote: On Sun, Feb 15, 2015 at 04:18:58PM +0800, Bob Liu wrote: diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 3589436..5a90a51 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -614,25

<    1   2   3   4   5   6   7   8   9   >