to update it only when user
want to see it by debugfs and zswap_is_full is called.
So could we optimize it out?
Signed-off-by: Cai Liu cai@samsung.com
Reviewed-by: Bob Liu bob@oracle.com
---
mm/zswap.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff
On 01/14/2014 01:05 PM, Minchan Kim wrote:
On Tue, Jan 14, 2014 at 01:50:22PM +0900, Minchan Kim wrote:
Hello Bob,
On Tue, Jan 14, 2014 at 09:19:23AM +0800, Bob Liu wrote:
On 01/14/2014 07:35 AM, Minchan Kim wrote:
Hello,
On Sat, Jan 11, 2014 at 03:43:07PM +0800, Cai Liu wrote:
zswap
On Wed, Jan 8, 2014 at 8:42 PM, Michal Hocko wrote:
> On Wed 08-01-14 20:09:30, Bob Liu wrote:
>> On Wed, Jan 8, 2014 at 6:08 PM, Michal Hocko wrote:
>>
>> >
>> > If I was debugging this I would simply add printk into page_address_in_vma
>> > error path
On Wed, Jan 8, 2014 at 6:08 PM, Michal Hocko wrote:
>
> If I was debugging this I would simply add printk into page_address_in_vma
> error paths.
>
> Anyway, I think that at least hugetlbfs part should be reverted because
> it might paper over real bugs. Although the migration would fail for
>
On Wed, Jan 8, 2014 at 6:08 PM, Michal Hocko mho...@suse.cz wrote:
If I was debugging this I would simply add printk into page_address_in_vma
error paths.
Anyway, I think that at least hugetlbfs part should be reverted because
it might paper over real bugs. Although the migration would fail
On Wed, Jan 8, 2014 at 8:42 PM, Michal Hocko mho...@suse.cz wrote:
On Wed 08-01-14 20:09:30, Bob Liu wrote:
On Wed, Jan 8, 2014 at 6:08 PM, Michal Hocko mho...@suse.cz wrote:
If I was debugging this I would simply add printk into page_address_in_vma
error paths.
Anyway, I think
ary 03, 2014 7:18 PM
>>> To: Vlastimil Babka
>>> Cc: Sasha Levin; Andrew Morton; Wanpeng Li; Michel Lespinasse; Bob Liu;
>>> Nick Piggin; Motohiro Kosaki JP; Rik van Riel; David Rientjes; Mel Gorman;
>>> Minchan Kim; Hugh Dickins; Johannes Weiner; linux-mm; Li
On Wed, Jan 8, 2014 at 1:30 AM, Michal Hocko wrote:
> On Tue 07-01-14 11:22:12, Michal Hocko wrote:
>> On Tue 07-01-14 13:29:31, Bob Liu wrote:
>> > On Mon, Jan 6, 2014 at 10:18 PM, Michal Hocko wrote:
>> > > On Mon 06-01-14 20:45:54, Bob Liu wrote:
>> > &g
On Wed, Jan 8, 2014 at 1:30 AM, Michal Hocko mho...@suse.cz wrote:
On Tue 07-01-14 11:22:12, Michal Hocko wrote:
On Tue 07-01-14 13:29:31, Bob Liu wrote:
On Mon, Jan 6, 2014 at 10:18 PM, Michal Hocko mho...@suse.cz wrote:
On Mon 06-01-14 20:45:54, Bob Liu wrote:
[...]
544
Morton; Wanpeng Li; Michel Lespinasse; Bob Liu;
Nick Piggin; Motohiro Kosaki JP; Rik van Riel; David Rientjes; Mel Gorman;
Minchan Kim; Hugh Dickins; Johannes Weiner; linux-mm; Linux Kernel Mailing
List
Subject: Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear
VMAs
On Fri, Jan 3, 2014
On Mon, Jan 6, 2014 at 10:18 PM, Michal Hocko wrote:
> On Mon 06-01-14 20:45:54, Bob Liu wrote:
> [...]
>> 544 if (PageAnon(page)) {
>> 545 struct anon_vma *page__anon_vma = page_anon_vma(page);
>> 546 /*
>> 547
Hi Michal,
On Mon, Jan 6, 2014 at 7:24 PM, Michal Hocko wrote:
> Hi Wanpeng Li,
> I have just noticed 11c731e81bb0 (mm/mempolicy: fix !vma in
> new_vma_page()) and I am not sure I understand it. Your changelog claims
> "
> page_address_in_vma() may still return -EFAULT because of many other
Hi Michal,
On Mon, Jan 6, 2014 at 7:24 PM, Michal Hocko mho...@suse.cz wrote:
Hi Wanpeng Li,
I have just noticed 11c731e81bb0 (mm/mempolicy: fix !vma in
new_vma_page()) and I am not sure I understand it. Your changelog claims
page_address_in_vma() may still return -EFAULT because of
On Mon, Jan 6, 2014 at 10:18 PM, Michal Hocko mho...@suse.cz wrote:
On Mon 06-01-14 20:45:54, Bob Liu wrote:
[...]
544 if (PageAnon(page)) {
545 struct anon_vma *page__anon_vma = page_anon_vma(page);
546 /*
547 * Note: swapoff's
On 01/04/2014 04:52 AM, Linus Torvalds wrote:
> On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin wrote:
>>
>> Ping? This BUG() is triggerable in 3.13-rc6 right now.
>
> So Andrew suggested just removing the BUG_ON(), but it's been there
> for a *long* time.
>
> And I detest the patch that was sent
On 01/04/2014 04:52 AM, Linus Torvalds wrote:
On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin sasha.le...@oracle.com wrote:
Ping? This BUG() is triggerable in 3.13-rc6 right now.
So Andrew suggested just removing the BUG_ON(), but it's been there
for a *long* time.
And I detest the patch
On 12/24/2013 01:24 AM, Sasha Levin wrote:
> Ping?
>
> I've also Cc'ed the "this page shouldn't be locked at all" team.
>
I have no idea why this BUG_ON was triggered.
And it looks like 'mm: kernel BUG at mm/huge_memory.c:1440!' have the
same call trace with this one. Perhaps they were
On 12/24/2013 01:24 AM, Sasha Levin wrote:
Ping?
I've also Cc'ed the this page shouldn't be locked at all team.
I have no idea why this BUG_ON was triggered.
And it looks like 'mm: kernel BUG at mm/huge_memory.c:1440!' have the
same call trace with this one. Perhaps they were introduced by
On 12/24/2013 03:45 PM, Joonsoo Kim wrote:
> On Tue, Dec 24, 2013 at 03:07:05PM +0900, Joonsoo Kim wrote:
>> On Mon, Dec 23, 2013 at 10:01:10PM -0500, Sasha Levin wrote:
>>> On 12/23/2013 09:51 PM, Joonsoo Kim wrote:
On Mon, Dec 23, 2013 at 12:24:02PM -0500, Sasha Levin wrote:
>> Ping?
On 12/24/2013 03:45 PM, Joonsoo Kim wrote:
On Tue, Dec 24, 2013 at 03:07:05PM +0900, Joonsoo Kim wrote:
On Mon, Dec 23, 2013 at 10:01:10PM -0500, Sasha Levin wrote:
On 12/23/2013 09:51 PM, Joonsoo Kim wrote:
On Mon, Dec 23, 2013 at 12:24:02PM -0500, Sasha Levin wrote:
Ping?
I've also Cc'ed
On Thu, Dec 19, 2013 at 11:45 AM, Wanpeng Li wrote:
> page_get_anon_vma() called in page_referenced_anon() will lock and increase
> the refcount of anon_vma, page won't be locked for anonymous page if the page
> is not locked by the caller. This patch fix the BUG_ON by reuse referenced
> field in
On Thu, Dec 19, 2013 at 11:45 AM, Wanpeng Li liw...@linux.vnet.ibm.com wrote:
page_get_anon_vma() called in page_referenced_anon() will lock and increase
the refcount of anon_vma, page won't be locked for anonymous page if the page
is not locked by the caller. This patch fix the BUG_ON by reuse
many pages to skip.
> The race might result in former tail pages not being skipped, which is however
> no longer a bug, as during the skip the PageTail flags are cleared.
>
> However this race also affects correctness of NR_MLOCK accounting, which is to
> be fixed in a separate patch.
&g
Reviewed-by: Bob Liu bob@oracle.com
---
mm/mlock.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/mm/mlock.c b/mm/mlock.c
index d480cd6..c59c420 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -133,7 +133,10 @@ static void
> [] ia32_do_call+0x13/0x13
> Code: 85 c0 75 2f 4c 89 e1 48 89 da 31 f6 bf da 00 02 00 65 44 8b 04 25 08 f7
> 1c 00 e8 ec fd ff ff 5b 41 5c 41 5d 5d c3 0f 1f 44 00 00 <0f> 0b 66 0f 1f 44
> 00
> +00 4c 89 e6 48 89 df ba 01 00 00 00 e8 48
> RIP [] new_vma_page+0x70/0
On 12/16/2013 06:14 PM, Vlastimil Babka wrote:
> Since commit ff6a6da60 ("mm: accelerate munlock() treatment of THP pages")
> munlock skips tail pages of a munlocked THP page. However, when the head page
> already has PageMlocked unset, it will not skip the tail pages.
>
> Commit 7225522bb ("mm:
On 12/16/2013 06:14 PM, Vlastimil Babka wrote:
Since commit ff6a6da60 (mm: accelerate munlock() treatment of THP pages)
munlock skips tail pages of a munlocked THP page. However, when the head page
already has PageMlocked unset, it will not skip the tail pages.
Commit 7225522bb (mm: munlock:
...@redhat.com
Reported-by: Sasha Levin sasha.le...@oracle.com
Signed-off-by: Wanpeng Li liw...@linux.vnet.ibm.com
Reviewed-by: Bob Liu bob@oracle.com
---
mm/mempolicy.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index
On 12/13/2013 05:05 AM, Sasha Levin wrote:
> On 12/12/2013 07:41 AM, Vlastimil Babka wrote:
>> On 12/12/2013 06:03 AM, Bob Liu wrote:
>>>
>>> On 12/12/2013 11:16 AM, Sasha Levin wrote:
>>>> On 12/11/2013 05:59 PM, Vlastimil Babka wrote:
>>>>> O
On 12/13/2013 05:05 AM, Sasha Levin wrote:
On 12/12/2013 07:41 AM, Vlastimil Babka wrote:
On 12/12/2013 06:03 AM, Bob Liu wrote:
On 12/12/2013 11:16 AM, Sasha Levin wrote:
On 12/11/2013 05:59 PM, Vlastimil Babka wrote:
On 12/09/2013 09:26 PM, Sasha Levin wrote:
On 12/09/2013 12:12 PM
On 12/12/2013 11:16 AM, Sasha Levin wrote:
> On 12/11/2013 05:59 PM, Vlastimil Babka wrote:
>> On 12/09/2013 09:26 PM, Sasha Levin wrote:
>>> On 12/09/2013 12:12 PM, Vlastimil Babka wrote:
On 12/09/2013 06:05 PM, Sasha Levin wrote:
> On 12/09/2013 04:34 AM, Vlastimil Babka wrote:
>>
Hi Dan & Seth,
On Wed, Nov 27, 2013 at 9:28 AM, Dan Streetman wrote:
> On Mon, Nov 25, 2013 at 1:00 PM, Seth Jennings
> wrote:
>> On Fri, Nov 22, 2013 at 11:29:16AM -0600, Seth Jennings wrote:
>>> On Wed, Nov 20, 2013 at 02:49:33PM -0500, Dan Streetman wrote:
>>> > Currently, zswap is
Hi Dan Seth,
On Wed, Nov 27, 2013 at 9:28 AM, Dan Streetman ddstr...@ieee.org wrote:
On Mon, Nov 25, 2013 at 1:00 PM, Seth Jennings sjenni...@variantweb.net
wrote:
On Fri, Nov 22, 2013 at 11:29:16AM -0600, Seth Jennings wrote:
On Wed, Nov 20, 2013 at 02:49:33PM -0500, Dan Streetman wrote:
On 12/12/2013 11:16 AM, Sasha Levin wrote:
On 12/11/2013 05:59 PM, Vlastimil Babka wrote:
On 12/09/2013 09:26 PM, Sasha Levin wrote:
On 12/09/2013 12:12 PM, Vlastimil Babka wrote:
On 12/09/2013 06:05 PM, Sasha Levin wrote:
On 12/09/2013 04:34 AM, Vlastimil Babka wrote:
Hello, I will look at
Hi Dan,
On 11/21/2013 03:49 AM, Dan Streetman wrote:
> Currently, zswap is writeback cache; stored pages are not sent
> to swap disk, and when zswap wants to evict old pages it must
> first write them back to swap cache/disk manually. This avoids
> swap out disk I/O up front, but only moves that
On 11/20/2013 05:10 PM, Jan Beulich wrote:
>>>> On 20.11.13 at 09:52, Bob Liu wrote:
>> @@ -100,9 +100,6 @@ static inline int xen_tmem_op(u32 tmem_cmd, u32
>> tmem_pool, struct tmem_oid oid,
>> op.u.gen.oid[1] = oid.oid[1];
>> op.u.gen.oid[2]
tmem only takes a page as unit, so parameters tmem_offset, pfn_offset and len
are meanless, this patch remove those always 0 parameters.
Signed-off-by: Bob Liu
---
drivers/xen/tmem.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/xen/tmem.c b
tmem only takes a page as unit, so parameters tmem_offset, pfn_offset and len
are meanless, this patch remove those always 0 parameters.
Signed-off-by: Bob Liu bob@oracle.com
---
drivers/xen/tmem.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git
On 11/20/2013 05:10 PM, Jan Beulich wrote:
On 20.11.13 at 09:52, Bob Liu lliu...@gmail.com wrote:
@@ -100,9 +100,6 @@ static inline int xen_tmem_op(u32 tmem_cmd, u32
tmem_pool, struct tmem_oid oid,
op.u.gen.oid[1] = oid.oid[1];
op.u.gen.oid[2] = oid.oid[2];
op.u.gen.index
Hi Dan,
On 11/21/2013 03:49 AM, Dan Streetman wrote:
Currently, zswap is writeback cache; stored pages are not sent
to swap disk, and when zswap wants to evict old pages it must
first write them back to swap cache/disk manually. This avoids
swap out disk I/O up front, but only moves that
On 11/15/2013 12:21 AM, Seth Jennings wrote:
> On Wed, Nov 13, 2013 at 08:00:34PM -0800, Hugh Dickins wrote:
>> On Wed, 13 Nov 2013, Minchan Kim wrote:
>> ...
>>>
>>> Hello Andrew,
>>>
>>> I'd like to listen your opinion.
>>>
>>> The zram promotion trial started since Aug 2012 and I already have
On 11/15/2013 12:21 AM, Seth Jennings wrote:
On Wed, Nov 13, 2013 at 08:00:34PM -0800, Hugh Dickins wrote:
On Wed, 13 Nov 2013, Minchan Kim wrote:
...
Hello Andrew,
I'd like to listen your opinion.
The zram promotion trial started since Aug 2012 and I already have get many
Hi Johannes,
On Fri, Oct 11, 2013 at 5:46 AM, Johannes Weiner wrote:
> Future
>
> Right now we have a fixed ratio (50:50) between inactive and active
> list but we already have complaints about working sets exceeding half
> of memory being pushed out of the cache by simple used-once
On 11/12/2013 03:12 AM, Dan Streetman wrote:
> Seth, have you (or anyone else) considered making zswap a writethrough
> cache instead of writeback? I think that it would significantly help
> the case where zswap fills up and starts writing back its oldest pages
> to disc - all the decompression
On 11/12/2013 03:12 AM, Dan Streetman wrote:
Seth, have you (or anyone else) considered making zswap a writethrough
cache instead of writeback? I think that it would significantly help
the case where zswap fills up and starts writing back its oldest pages
to disc - all the decompression work
Hi Johannes,
On Fri, Oct 11, 2013 at 5:46 AM, Johannes Weiner han...@cmpxchg.org wrote:
Future
Right now we have a fixed ratio (50:50) between inactive and active
list but we already have complaints about working sets exceeding half
of memory being pushed out of the cache by simple
On 11/07/2013 03:04 PM, Minchan Kim wrote:
> On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote:
>> On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote:
>> > I'm getting really tired of them hanging around in here for many years
now...
>>>
>>> Minchan has tried many times
On 11/08/2013 05:50 PM, changkun.li wrote:
> In zswap, store page A to zbud if the compression ratio is high, insert
> its entry into rbtree. if there is a entry B which has the same offset
> in the rbtree.Remove and free B before insert the entry of A.
>
> case:
> if the compression ratio of
On 11/08/2013 05:50 PM, changkun.li wrote:
In zswap, store page A to zbud if the compression ratio is high, insert
its entry into rbtree. if there is a entry B which has the same offset
in the rbtree.Remove and free B before insert the entry of A.
case:
if the compression ratio of page A is
On 11/07/2013 03:04 PM, Minchan Kim wrote:
On Wed, Nov 06, 2013 at 07:05:11PM -0800, Greg KH wrote:
On Wed, Nov 06, 2013 at 03:46:19PM -0800, Nitin Gupta wrote:
I'm getting really tired of them hanging around in here for many years
now...
Minchan has tried many times to promote zram out
On 11/07/2013 04:37 AM, Boris Ostrovsky wrote:
> Currently balloon's initial value is set to max_pfn which includes
> non-RAM ranges such as MMIO hole. As result, initial memory target
> (specified by guest's configuration file) will appear smaller than
> what balloon driver perceives to be the
On 11/07/2013 04:37 AM, Boris Ostrovsky wrote:
Currently balloon's initial value is set to max_pfn which includes
non-RAM ranges such as MMIO hole. As result, initial memory target
(specified by guest's configuration file) will appear smaller than
what balloon driver perceives to be the
On 11/05/2013 01:22 AM, David Vrabel wrote:
> On 04/11/13 12:39, Bob Liu wrote:
>> Currently the goal_page in xen-selfballon doesn't consider much about pages
>> used
>> in kernel space.
>> A typical usage is slab pages, without consider slab pages the goal_page
&g
Currently the goal_page in xen-selfballon doesn't consider much about pages used
in kernel space.
A typical usage is slab pages, without consider slab pages the goal_page result
may be too rough and lead extra memory pressure to guest os.
Signed-off-by: Bob Liu
---
drivers/xen/xen-selfballoon.c
On 11/05/2013 01:22 AM, David Vrabel wrote:
On 04/11/13 12:39, Bob Liu wrote:
Currently the goal_page in xen-selfballon doesn't consider much about pages
used
in kernel space.
A typical usage is slab pages, without consider slab pages the goal_page
result
may be too rough and lead extra
Currently the goal_page in xen-selfballon doesn't consider much about pages used
in kernel space.
A typical usage is slab pages, without consider slab pages the goal_page result
may be too rough and lead extra memory pressure to guest os.
Signed-off-by: Bob Liu bob@oracle.com
---
drivers/xen
Hi Olav,
On 11/02/2013 08:59 AM, Olav Haugan wrote:
>
> I tried the above suggestion but it does not seem to have any noticeable
> impact. The system is still trying to swap out at a very high rate after
> zram reported failure to swap out. The error logging is actually so much
> that my system
Hi Olav,
On 11/02/2013 08:59 AM, Olav Haugan wrote:
I tried the above suggestion but it does not seem to have any noticeable
impact. The system is still trying to swap out at a very high rate after
zram reported failure to swap out. The error logging is actually so much
that my system
Hi Olav,
On 11/01/2013 07:34 AM, Olav Haugan wrote:
> Hi Luigi,
>
> On 10/24/2013 6:12 PM, Luigi Semenzato wrote:
>> On Thu, Oct 24, 2013 at 5:35 PM, Olav Haugan wrote:
>>> Hi Bob, Luigi,
>>>
>>> On 10/23/2013 5:55 PM, Bob Liu wrote:
>>&
Hi Olav,
On 11/01/2013 07:34 AM, Olav Haugan wrote:
Hi Luigi,
On 10/24/2013 6:12 PM, Luigi Semenzato wrote:
On Thu, Oct 24, 2013 at 5:35 PM, Olav Haugan ohau...@codeaurora.org wrote:
Hi Bob, Luigi,
On 10/23/2013 5:55 PM, Bob Liu wrote:
On 10/24/2013 05:51 AM, Olav Haugan wrote
On 10/25/2013 08:35 AM, Olav Haugan wrote:
> Hi Bob, Luigi,
>
> On 10/23/2013 5:55 PM, Bob Liu wrote:
>>
>> On 10/24/2013 05:51 AM, Olav Haugan wrote:
>>> I am trying to use zram in very low memory conditions and I am having
>>> some issues. zram is in the
On 10/25/2013 08:35 AM, Olav Haugan wrote:
Hi Bob, Luigi,
On 10/23/2013 5:55 PM, Bob Liu wrote:
On 10/24/2013 05:51 AM, Olav Haugan wrote:
I am trying to use zram in very low memory conditions and I am having
some issues. zram is in the reclaim path. So if the system is very low
on memory
On 10/24/2013 05:51 AM, Olav Haugan wrote:
> I am trying to use zram in very low memory conditions and I am having
> some issues. zram is in the reclaim path. So if the system is very low
> on memory the system is trying to reclaim pages by swapping out (in this
> case to zram). However, since we
On 10/24/2013 05:51 AM, Olav Haugan wrote:
I am trying to use zram in very low memory conditions and I am having
some issues. zram is in the reclaim path. So if the system is very low
on memory the system is trying to reclaim pages by swapping out (in this
case to zram). However, since we are
Hi Alex,
On Wed, Oct 16, 2013 at 11:54 PM, Alex Thorlton wrote:
> Hi guys,
>
> I ran into a bug a week or so ago, that I believe has something to do
> with NUMA balancing, but I'm having a tough time tracking down exactly
> what is causing it. When running with the following configuration
>
Hi Alex,
On Wed, Oct 16, 2013 at 11:54 PM, Alex Thorlton athorl...@sgi.com wrote:
Hi guys,
I ran into a bug a week or so ago, that I believe has something to do
with NUMA balancing, but I'm having a tough time tracking down exactly
what is causing it. When running with the following
On Sat, Oct 12, 2013 at 5:14 PM, Weijie Yang wrote:
> On Sat, Oct 12, 2013 at 10:50 AM, Bob Liu wrote:
>> On Fri, Oct 11, 2013 at 3:13 PM, Minchan Kim wrote:
>>> On Thu, Sep 26, 2013 at 11:42:17AM +0800, Weijie Yang wrote:
>>>> On Tue, Sep 24, 2013 at 9:03 AM, Min
On Sat, Oct 12, 2013 at 5:14 PM, Weijie Yang weijie.yang...@gmail.com wrote:
On Sat, Oct 12, 2013 at 10:50 AM, Bob Liu lliu...@gmail.com wrote:
On Fri, Oct 11, 2013 at 3:13 PM, Minchan Kim minc...@kernel.org wrote:
On Thu, Sep 26, 2013 at 11:42:17AM +0800, Weijie Yang wrote:
On Tue, Sep 24
On Fri, Oct 11, 2013 at 3:13 PM, Minchan Kim wrote:
> On Thu, Sep 26, 2013 at 11:42:17AM +0800, Weijie Yang wrote:
>> On Tue, Sep 24, 2013 at 9:03 AM, Minchan Kim wrote:
>> > On Mon, Sep 23, 2013 at 04:21:49PM +0800, Weijie Yang wrote:
>> > >
>> > > Modify:
>> > > - check the refcount in fail
On Thu, Sep 26, 2013 at 11:42 AM, Weijie Yang wrote:
> On Tue, Sep 24, 2013 at 9:03 AM, Minchan Kim wrote:
>> On Mon, Sep 23, 2013 at 04:21:49PM +0800, Weijie Yang wrote:
>> >
>> > Modify:
>> > - check the refcount in fail path, free memory if it is not referenced.
>>
>> Hmm, I don't like this
On Thu, Sep 26, 2013 at 11:42 AM, Weijie Yang weijie.y...@samsung.com wrote:
On Tue, Sep 24, 2013 at 9:03 AM, Minchan Kim minc...@kernel.org wrote:
On Mon, Sep 23, 2013 at 04:21:49PM +0800, Weijie Yang wrote:
Modify:
- check the refcount in fail path, free memory if it is not referenced.
On Fri, Oct 11, 2013 at 3:13 PM, Minchan Kim minc...@kernel.org wrote:
On Thu, Sep 26, 2013 at 11:42:17AM +0800, Weijie Yang wrote:
On Tue, Sep 24, 2013 at 9:03 AM, Minchan Kim minc...@kernel.org wrote:
On Mon, Sep 23, 2013 at 04:21:49PM +0800, Weijie Yang wrote:
Modify:
- check the
On 10/09/2013 10:40 PM, Seth Jennings wrote:
> On Tue, Oct 08, 2013 at 01:08:53PM -0700, Andrew Morton wrote:
>> On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski
>> wrote:
>>
>>> On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote:
On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof
On 10/09/2013 04:08 AM, Andrew Morton wrote:
> On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski
> wrote:
>
>> On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote:
>>> On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski
>>> wrote:
>>>
During swapoff the frontswap_map was
On 10/09/2013 04:08 AM, Andrew Morton wrote:
On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote:
On Mon, 07 Oct 2013 17:25:41 +0200 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
During
On 10/09/2013 10:40 PM, Seth Jennings wrote:
On Tue, Oct 08, 2013 at 01:08:53PM -0700, Andrew Morton wrote:
On Tue, 08 Oct 2013 10:13:20 +0200 Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
On pon, 2013-10-07 at 15:03 -0700, Andrew Morton wrote:
On Mon, 07 Oct 2013 17:25:41 +0200
Nobody uses the pvec->cold argument of pagevec and it's also unreasonable for
pages in pagevec released as cold page, so drop the cold argument from pagevec.
Signed-off-by: Bob Liu
---
fs/9p/cache.c |2 +-
fs/afs/cache.c |2 +-
fs/afs/write.c |4 ++--
Nobody uses the pvec-cold argument of pagevec and it's also unreasonable for
pages in pagevec released as cold page, so drop the cold argument from pagevec.
Signed-off-by: Bob Liu bob@oracle.com
---
fs/9p/cache.c |2 +-
fs/afs/cache.c |2 +-
fs/afs/write.c
On 09/28/2013 06:00 AM, Seth Jennings wrote:
> On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote:
>> On 09/25/2013 11:57 PM, Seth Jennings wrote:
>>> On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote:
> I just had an idea this afternoon to potentially kill
On 09/28/2013 06:00 AM, Seth Jennings wrote:
On Fri, Sep 27, 2013 at 12:16:37PM +0200, Tomasz Stanislawski wrote:
On 09/25/2013 11:57 PM, Seth Jennings wrote:
On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote:
I just had an idea this afternoon to potentially kill both these
;
>>> > On Wed, Sep 25, 2013 at 05:33:43PM +0800, Weijie Yang wrote:
>>> >> On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu wrote:
>>> >> > On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang
>>> >> > wrote:
>>> >> >> I think
On Thu, Sep 26, 2013 at 2:49 PM, Vlastimil Babka wrote:
> On 09/26/2013 02:40 AM, Fengguang Wu wrote:
>> Hi Vlastimil,
>>
>> FYI, this bug seems still not fixed in linux-next 20130925.
>
> Hi,
>
> I sent (including you) a RFC patch and later reviewed patch about week
> ago. I assumed you would
On Thu, Sep 26, 2013 at 2:49 PM, Vlastimil Babka vba...@suse.cz wrote:
On 09/26/2013 02:40 AM, Fengguang Wu wrote:
Hi Vlastimil,
FYI, this bug seems still not fixed in linux-next 20130925.
Hi,
I sent (including you) a RFC patch and later reviewed patch about week
ago. I assumed you would
,
On Wed, Sep 25, 2013 at 05:33:43PM +0800, Weijie Yang wrote:
On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu lliu...@gmail.com wrote:
On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang
weijie.yang...@gmail.com wrote:
I think I find a new issue, for integrity of this mail thread, I reply
On Thu, Sep 26, 2013 at 9:59 AM, Fengguang Wu wrote:
> Hi Bob,
>
> On Thu, Sep 26, 2013 at 09:48:08AM +0800, Bob Liu wrote:
>> Hi Fengguang,
>>
>> Would you please have a try with the attached patch?
>> It added a small fix based on Vlastimil's patch.
>
>
ot;mm: munlock: manual pte walk in fast path instead of
> follow_page_mask()"
> git bisect bad 22356f447ceb8d97a4885792e7d9e4607f712e1b # 04:40 48-
> mm: Place preemption point in do_mlockall() loop
> git bisect bad 050f4da86e9bdbcc9e11789e0f291aafa57b8a
On Wed, Sep 25, 2013 at 5:33 PM, Weijie Yang wrote:
> On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu wrote:
>> On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang
>> wrote:
>>> I think I find a new issue, for integrity of this mail thread, I reply
>>> to this mail.
>>
On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang wrote:
> I think I find a new issue, for integrity of this mail thread, I reply
> to this mail.
>
> It is a concurrence issue either, when duplicate store and reclaim
> concurrentlly.
>
> zswap entry x with offset A is already stored in zswap backend.
On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang weijie.yang...@gmail.com wrote:
I think I find a new issue, for integrity of this mail thread, I reply
to this mail.
It is a concurrence issue either, when duplicate store and reclaim
concurrentlly.
zswap entry x with offset A is already stored
On Wed, Sep 25, 2013 at 5:33 PM, Weijie Yang weijie.yang...@gmail.com wrote:
On Wed, Sep 25, 2013 at 4:31 PM, Bob Liu lliu...@gmail.com wrote:
On Wed, Sep 25, 2013 at 4:09 PM, Weijie Yang weijie.yang...@gmail.com
wrote:
I think I find a new issue, for integrity of this mail thread, I reply
00:00:00 2001
From: Bob Liu bob@oracle.com
Date: Thu, 26 Sep 2013 09:41:27 +0800
Subject: [PATCH v2] mm: munlock: Prevent walking off the end of a pagetable in
no-pmd configuration
The function __munlock_pagevec_fill() introduced in commit 7a8010cd3
(mm: munlock: manual pte walk in fast path
On Thu, Sep 26, 2013 at 9:59 AM, Fengguang Wu fengguang...@intel.com wrote:
Hi Bob,
On Thu, Sep 26, 2013 at 09:48:08AM +0800, Bob Liu wrote:
Hi Fengguang,
Would you please have a try with the attached patch?
It added a small fix based on Vlastimil's patch.
Thanks for the quick response! I
On Tue, Sep 24, 2013 at 5:20 PM, Krzysztof Kozlowski
wrote:
> Hi,
>
> On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote:
>> On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote:
>> > Mel mentioned several problems about zswap/zbud in thread "[PATCH v6
>
On Tue, Sep 24, 2013 at 5:20 PM, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
Hi,
On pon, 2013-09-23 at 17:07 -0500, Seth Jennings wrote:
On Tue, Sep 17, 2013 at 02:59:24PM +0800, Bob Liu wrote:
Mel mentioned several problems about zswap/zbud in thread [PATCH v6
0/5] zram/zsmalloc
On 09/10/2013 12:29 AM, Seth Jennings wrote:
> On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote:
>> add SetPageReclaim before __swap_writepage so that page can be moved to the
>> tail of the inactive list, which can avoid unnecessary page scanning as this
>> page was reclaimed by swap
On 09/10/2013 12:29 AM, Seth Jennings wrote:
On Fri, Sep 06, 2013 at 01:16:45PM +0800, Weijie Yang wrote:
add SetPageReclaim before __swap_writepage so that page can be moved to the
tail of the inactive list, which can avoid unnecessary page scanning as this
page was reclaimed by swap
MD_SIZE) & PMD_MASK;
+ end = (pmd_end - 1 < end - 1) ? pmd_end : end;
/*
* Initialize pte walk starting at the already pinned page where we
* are sure that there is a pte.
*/
pte = get_locked_pte(vma->vm_mm, start, );
- end =
Hi Krzysztof,
On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote:
> Hi,
>
> Currently zbud pages are not movable and they cannot be allocated from CMA
> (Contiguous Memory Allocator) region. These patches add migration of zbud
> pages.
>
I agree that the migration of zbud pages is important so
Hi Krzysztof,
On 09/11/2013 04:58 PM, Krzysztof Kozlowski wrote:
Hi,
Currently zbud pages are not movable and they cannot be allocated from CMA
(Contiguous Memory Allocator) region. These patches add migration of zbud
pages.
I agree that the migration of zbud pages is important so that
to the pinned page is the first we will try to
get */
start += PAGE_SIZE;
Anyway,
Reviewed-by: Bob Liu bob@oracle.com
--
Regards,
-Bob
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
501 - 600 of 824 matches
Mail list logo
