Re: [PATCH 0/50] Basic scheduler support for automatic NUMA balancing V7

2013-09-13 Thread Bob Liu
Hi Mel, On 09/10/2013 05:31 PM, Mel Gorman wrote: > It has been a long time since V6 of this series and time for an update. Much > of this is now stabilised with the most important addition being the inclusion > of Peter and Rik's work on grouping tasks that share pages together. > > This series

Re: [PATCH 0/50] Basic scheduler support for automatic NUMA balancing V7

2013-09-13 Thread Bob Liu
Hi Mel, On 09/10/2013 05:31 PM, Mel Gorman wrote: It has been a long time since V6 of this series and time for an update. Much of this is now stabilised with the most important addition being the inclusion of Peter and Rik's work on grouping tasks that share pages together. This series has

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Bob Liu
; additional reclaim paths. > > The page count is incremented when: > - a handle is created and passed to zswap (in zbud_alloc()), > - user-supplied eviction callback is called (in zbud_reclaim_page()). > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Tomasz Sta

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Bob Liu
...@samsung.com Reviewed-by: Bob Liu bob@oracle.com AFAIR, the previous version you sent out has a function called rebalance_lists() which I think is a good clean up. But I didn't see that function any more in this version. Thanks, -Bob --- mm/zbud.c | 97

Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-06 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > To avoid zswap store and reclaim functions called recursively, > use GFP_NOIO instead of GFP_KERNEL > The reason of using GFP_KERNEL in write back path is we want to try our best to move those pages from zswap to real swap device. I think it would

Re: [PATCH v2 2/4] mm/zswap: bugfix: memory leak when invalidate and reclaim occur concurrently

2013-09-06 Thread Bob Liu
t also by invalidate. > > Signed-off-by: Weijie Yang Reviewed-by: Bob Liu > --- > mm/zswap.c | 21 + > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index cbd9578..1be7b90 100644 > --- a/mm/zswap.c &

Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning

2013-09-06 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > add SetPageReclaim before __swap_writepage so that page can be moved to the > tail of the inactive list, which can avoid unnecessary page scanning as this > page was reclaimed by swap subsystem before. > > Signed-off-by: Weijie Yang R

Re: [PATCH v2 1/4] mm/zswap: bugfix: memory leak when re-swapon

2013-09-06 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: > zswap_tree is not freed when swapoff, and it got re-kmalloc in swapon, > so memory-leak occurs. > > Modify: free memory of zswap_tree in zswap_frontswap_invalidate_area(). > > Signed-off-by: Weijie Yang Reviewed-by: Bob Liu &

Re: [PATCH v2 1/4] mm/zswap: bugfix: memory leak when re-swapon

2013-09-06 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: zswap_tree is not freed when swapoff, and it got re-kmalloc in swapon, so memory-leak occurs. Modify: free memory of zswap_tree in zswap_frontswap_invalidate_area(). Signed-off-by: Weijie Yang weijie.y...@samsung.com Reviewed-by: Bob Liu bob

Re: [PATCH v2 3/4] mm/zswap: avoid unnecessary page scanning

2013-09-06 Thread Bob Liu
Reviewed-by: Bob Liu bob@oracle.com --- mm/zswap.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/zswap.c b/mm/zswap.c index 1be7b90..cc40e6a 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -556,6 +556,9 @@ static int zswap_writeback_entry(struct zbud_pool *pool

Re: [PATCH v2 2/4] mm/zswap: bugfix: memory leak when invalidate and reclaim occur concurrently

2013-09-06 Thread Bob Liu
...@samsung.com Reviewed-by: Bob Liu bob@oracle.com --- mm/zswap.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index cbd9578..1be7b90 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -387,7 +387,7 @@ static void

Re: [PATCH v2 4/4] mm/zswap: use GFP_NOIO instead of GFP_KERNEL

2013-09-06 Thread Bob Liu
On 09/06/2013 01:16 PM, Weijie Yang wrote: To avoid zswap store and reclaim functions called recursively, use GFP_NOIO instead of GFP_KERNEL The reason of using GFP_KERNEL in write back path is we want to try our best to move those pages from zswap to real swap device. I think it would be

Re: [PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-30 Thread Bob Liu
On Fri, Aug 30, 2013 at 2:14 PM, Dan Aloni wrote: > On Fri, Aug 30, 2013 at 01:47:53PM +0800, Bob Liu wrote: >>[..] >> Machine2: bootcmdline in grub.cfg "memmap=0x77ff$0x88000", the >> result of >> "cat /proc/cmdline" changed to "memmap

Re: [PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-30 Thread Bob Liu
On Fri, Aug 30, 2013 at 2:14 PM, Dan Aloni alo...@stratoscale.com wrote: On Fri, Aug 30, 2013 at 01:47:53PM +0800, Bob Liu wrote: [..] Machine2: bootcmdline in grub.cfg memmap=0x77ff$0x88000, the result of cat /proc/cmdline changed to memmap=0x77ffx88000. I didn't find

[PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-29 Thread Bob Liu
didn't find the root cause, I think maybe grub reserved "$0" as something special. Replace '$' with '%' in kernel boot parameter can fix this issue. Signed-off-by: Bob Liu --- Documentation/kernel-parameters.txt |6 +++--- arch/x86/kernel/e820.c |2 +- 2 files chang

[PATCH] x86: e820: fix memmap kernel boot parameter

2013-08-29 Thread Bob Liu
special. Replace '$' with '%' in kernel boot parameter can fix this issue. Signed-off-by: Bob Liu bob@oracle.com --- Documentation/kernel-parameters.txt |6 +++--- arch/x86/kernel/e820.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-23 Thread Bob Liu
Hi Minchan, On Thu, Aug 22, 2013 at 8:42 AM, Minchan Kim wrote: > Hi Bob, > > On Wed, Aug 21, 2013 at 05:24:00PM +0800, Bob Liu wrote: >> Hi Minchan, >> >> On 08/21/2013 02:16 PM, Minchan Kim wrote: >> > It's 7th trial of zram/zsmalloc promotion. >&

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-23 Thread Bob Liu
Hi Minchan, On Thu, Aug 22, 2013 at 8:42 AM, Minchan Kim minc...@kernel.org wrote: Hi Bob, On Wed, Aug 21, 2013 at 05:24:00PM +0800, Bob Liu wrote: Hi Minchan, On 08/21/2013 02:16 PM, Minchan Kim wrote: It's 7th trial of zram/zsmalloc promotion. I rewrote cover-letter totally based

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
On 08/21/2013 05:24 PM, Bob Liu wrote: > Hi Minchan, > > On 08/21/2013 02:16 PM, Minchan Kim wrote: >> It's 7th trial of zram/zsmalloc promotion. >> I rewrote cover-letter totally based on previous discussion. >> >> The main reason to prevent zram promotion was no

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
Hi Minchan, On 08/21/2013 02:16 PM, Minchan Kim wrote: > It's 7th trial of zram/zsmalloc promotion. > I rewrote cover-letter totally based on previous discussion. > > The main reason to prevent zram promotion was no review of > zsmalloc part while Jens, block maintainer, already acked > zram

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
Hi Minchan, On 08/21/2013 02:16 PM, Minchan Kim wrote: It's 7th trial of zram/zsmalloc promotion. I rewrote cover-letter totally based on previous discussion. The main reason to prevent zram promotion was no review of zsmalloc part while Jens, block maintainer, already acked zram part.

Re: [PATCH v7 0/5] zram/zsmalloc promotion

2013-08-21 Thread Bob Liu
On 08/21/2013 05:24 PM, Bob Liu wrote: Hi Minchan, On 08/21/2013 02:16 PM, Minchan Kim wrote: It's 7th trial of zram/zsmalloc promotion. I rewrote cover-letter totally based on previous discussion. The main reason to prevent zram promotion was no review of zsmalloc part while Jens, block

Re: [PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-19 Thread Bob Liu
On 08/20/2013 01:46 AM, Seth Jennings wrote: > On Sun, Aug 18, 2013 at 04:40:49PM +0800, Bob Liu wrote: >> This is used to replace previous zram. >> zram users can enable this feature, then a pseudo device will be created >> automaticlly after kernel boot. >> Just usin

Re: [PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-19 Thread Bob Liu
On 08/20/2013 12:59 AM, Seth Jennings wrote: > On Sun, Aug 18, 2013 at 04:40:48PM +0800, Bob Liu wrote: >> Make zswap can use zsmalloc as its allocater. >> But note that zsmalloc don't reclaim any zswap pool pages mandatory, if zswap >> pool gets full, frontswap_store w

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-19 Thread Bob Liu
Hi Luigi, On 08/19/2013 01:29 PM, Luigi Semenzato wrote: > > We are gearing up to evaluate zswap, but we have only ported kernels > up to 3.8 to our hardware, so we may be missing important patches. > > In our experience, and with all due respect, the linux MM is a complex > beast, and it's

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-19 Thread Bob Liu
Hi Luigi, On 08/19/2013 01:29 PM, Luigi Semenzato wrote: We are gearing up to evaluate zswap, but we have only ported kernels up to 3.8 to our hardware, so we may be missing important patches. In our experience, and with all due respect, the linux MM is a complex beast, and it's difficult

Re: [PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-19 Thread Bob Liu
On 08/20/2013 12:59 AM, Seth Jennings wrote: On Sun, Aug 18, 2013 at 04:40:48PM +0800, Bob Liu wrote: Make zswap can use zsmalloc as its allocater. But note that zsmalloc don't reclaim any zswap pool pages mandatory, if zswap pool gets full, frontswap_store will be refused unless

Re: [PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-19 Thread Bob Liu
On 08/20/2013 01:46 AM, Seth Jennings wrote: On Sun, Aug 18, 2013 at 04:40:49PM +0800, Bob Liu wrote: This is used to replace previous zram. zram users can enable this feature, then a pseudo device will be created automaticlly after kernel boot. Just using mkswp /dev/zram0; swapon /dev/zram0

Re: [PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 12:10 PM, Minchan Kim wrote: > On Sun, Aug 18, 2013 at 04:40:45PM +0800, Bob Liu wrote: >> Both zswap and zram are used to compress anon pages in memory so as to reduce >> swap io operation. The main different is that zswap uses zbud as its >> al

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 11:18 AM, Minchan Kim wrote: > Hello Mel, > > On Fri, Aug 16, 2013 at 09:33:47AM +0100, Mel Gorman wrote: >> On Fri, Aug 16, 2013 at 01:26:41PM +0900, Minchan Kim wrote: >> >> If it's used for something like tmpfs then it becomes much worse. Normal >> tmpfs

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-08-18 Thread Bob Liu
Hi Weijie, On 08/19/2013 12:14 AM, Weijie Yang wrote: > I found a few bugs in zswap when I review Linux-3.11-rc5, and I have > also some questions about it, described as following: > > BUG: > 1. A race condition when reclaim a page > when a handle alloced from zbud, zbud considers this handle is

[PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-18 Thread Bob Liu
parameter zswap.max_pool_percent. disksize = (totalram_pages * zswap.max_pool_percent/100)*PAGE_SIZE. Signed-off-by: Bob Liu --- mm/Kconfig | 12 mm/zswap.c | 196 2 files changed, 208 insertions(+) diff --git a/mm/Kconfig b/mm/Kconfig ind

[PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-18 Thread Bob Liu
, zsmalloc has unpredictable performance characteristics when reclaiming a single page, then CONFIG_ZBUD are suggested. Signed-off-by: Bob Liu --- include/linux/zsmalloc.h |1 + mm/Kconfig |4 +++ mm/zsmalloc.c|9 -- mm/zswap.c | 73

[PATCH 2/4] mm: promote zsmalloc to mm/

2013-08-18 Thread Bob Liu
sponse to an allocation request. That handle must be mapped, using zs_map_object(), which returns a pointer to the mapped region that can be used. The mapping is necessary since the object data may reside in two different noncontigious pages. Signed-off-by: Bob Liu --- include/linux/zsmalloc.

[PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
: Improve the writeback of zswap pool pages! Bob Liu (4): drivers: staging: drop zram and zsmalloc mm: promote zsmalloc to mm/ mm: zswap: add supporting for zsmalloc mm: zswap: create a pseudo device /dev/zram0 drivers/staging/Kconfig |4 - drivers/staging/Makefile

Re: [BUG REPORT] ZSWAP: theoretical race condition issues

2013-08-18 Thread Bob Liu
Hi Weijie, On 08/19/2013 12:14 AM, Weijie Yang wrote: I found a few bugs in zswap when I review Linux-3.11-rc5, and I have also some questions about it, described as following: BUG: 1. A race condition when reclaim a page when a handle alloced from zbud, zbud considers this handle is used

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 11:18 AM, Minchan Kim wrote: Hello Mel, On Fri, Aug 16, 2013 at 09:33:47AM +0100, Mel Gorman wrote: On Fri, Aug 16, 2013 at 01:26:41PM +0900, Minchan Kim wrote: SNIP If it's used for something like tmpfs then it becomes much worse. Normal tmpfs without swap can

Re: [PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
Hi Minchan, On 08/19/2013 12:10 PM, Minchan Kim wrote: On Sun, Aug 18, 2013 at 04:40:45PM +0800, Bob Liu wrote: Both zswap and zram are used to compress anon pages in memory so as to reduce swap io operation. The main different is that zswap uses zbud as its allocator while zram uses

[PATCH 0/4] mm: merge zram into zswap

2013-08-18 Thread Bob Liu
: Improve the writeback of zswap pool pages! Bob Liu (4): drivers: staging: drop zram and zsmalloc mm: promote zsmalloc to mm/ mm: zswap: add supporting for zsmalloc mm: zswap: create a pseudo device /dev/zram0 drivers/staging/Kconfig |4 - drivers/staging/Makefile

[PATCH 2/4] mm: promote zsmalloc to mm/

2013-08-18 Thread Bob Liu
request. That handle must be mapped, using zs_map_object(), which returns a pointer to the mapped region that can be used. The mapping is necessary since the object data may reside in two different noncontigious pages. Signed-off-by: Bob Liu bob@oracle.com --- include/linux/zsmalloc.h | 43

[PATCH 4/4] mm: zswap: create a pseudo device /dev/zram0

2013-08-18 Thread Bob Liu
zswap.max_pool_percent. disksize = (totalram_pages * zswap.max_pool_percent/100)*PAGE_SIZE. Signed-off-by: Bob Liu bob@oracle.com --- mm/Kconfig | 12 mm/zswap.c | 196 2 files changed, 208 insertions(+) diff --git a/mm/Kconfig b/mm/Kconfig

[PATCH 3/4] mm: zswap: add supporting for zsmalloc

2013-08-18 Thread Bob Liu
, zsmalloc has unpredictable performance characteristics when reclaiming a single page, then CONFIG_ZBUD are suggested. Signed-off-by: Bob Liu bob@oracle.com --- include/linux/zsmalloc.h |1 + mm/Kconfig |4 +++ mm/zsmalloc.c|9 -- mm/zswap.c

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
lthough since Dan left I do not believe anyone is >> planning to try. > > I should mention that Bob Liu did some work with zcache recently but is > now looking like it'll be dropped from staging. I did not look at the > details and I have no idea if anything else is planned with

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
Hi Mel, On 08/16/2013 04:33 PM, Mel Gorman wrote: > > I already said I recognise it has a large number of users in the field > and users count a lot more than me complaining. If it gets promoted then > I expect it will be on those grounds. > > My position is that I think it's a bad idea because

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
Hi Mel, On 08/16/2013 04:33 PM, Mel Gorman wrote: I already said I recognise it has a large number of users in the field and users count a lot more than me complaining. If it gets promoted then I expect it will be on those grounds. My position is that I think it's a bad idea because it is

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-16 Thread Bob Liu
not believe anyone is planning to try. I should mention that Bob Liu did some work with zcache recently but is now looking like it'll be dropped from staging. I did not look at the details and I have no idea if anything else is planned with it. The plan is like this: Zcache dropped from staging

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Minchan, On Fri, Aug 16, 2013 at 12:26 PM, Minchan Kim wrote: > Hi Mel, > > On Thu, Aug 15, 2013 at 06:12:50PM +0100, Mel Gorman wrote: >> On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >> > > >> > > >> > > I do not believe this is a problem for zram as such because I do not >>

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: > On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >>> >>> >>> I do not believe this is a problem for zram as such because I do not >>> think it ever writes back to disk and is immune from the unpredictable >>> performance

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: > On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: >>> >>> >>> I do not believe this is a problem for zram as such because I do not >>> think it ever writes back to disk and is immune from the unpredictable >>> performance

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: SNIP I do not believe this is a problem for zram as such because I do not think it ever writes back to disk and is immune from the unpredictable performance characteristics

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Mel, On 08/16/2013 01:12 AM, Mel Gorman wrote: On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: SNIP I do not believe this is a problem for zram as such because I do not think it ever writes back to disk and is immune from the unpredictable performance characteristics

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-15 Thread Bob Liu
Hi Minchan, On Fri, Aug 16, 2013 at 12:26 PM, Minchan Kim minc...@kernel.org wrote: Hi Mel, On Thu, Aug 15, 2013 at 06:12:50PM +0100, Mel Gorman wrote: On Thu, Aug 15, 2013 at 03:58:20AM +0900, Minchan Kim wrote: SNIP I do not believe this is a problem for zram as such because I do

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-14 Thread Bob Liu
On Thu, Aug 15, 2013 at 12:17 AM, Minchan Kim wrote: > Hi Luigi, > > On Wed, Aug 14, 2013 at 08:53:31AM -0700, Luigi Semenzato wrote: >> During earlier discussions of zswap there was a plan to make it work >> with zsmalloc as an option instead of zbud. Does zbud work for > > AFAIR, it was not an

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-14 Thread Bob Liu
On Thu, Aug 15, 2013 at 12:17 AM, Minchan Kim minc...@kernel.org wrote: Hi Luigi, On Wed, Aug 14, 2013 at 08:53:31AM -0700, Luigi Semenzato wrote: During earlier discussions of zswap there was a plan to make it work with zsmalloc as an option instead of zbud. Does zbud work for AFAIR, it

Re: [PATCH v2 0/4] zcache: a compressed file page cache

2013-08-09 Thread Bob Liu
other file memory hungry applications and it do no harm for other users! Looking forward any feedback! On Tue, Aug 6, 2013 at 7:36 PM, Bob Liu wrote: > Overview: > Zcache is a in kernel compressed cache for file pages. > It takes active file pages that are in the process of being

Re: [PATCH v2 0/4] zcache: a compressed file page cache

2013-08-09 Thread Bob Liu
other file memory hungry applications and it do no harm for other users! Looking forward any feedback! On Tue, Aug 6, 2013 at 7:36 PM, Bob Liu lliu...@gmail.com wrote: Overview: Zcache is a in kernel compressed cache for file pages. It takes active file pages that are in the process of being

Re: [PATCH] mm: zcache: zcache_cleancache_flush_fs fix

2013-08-06 Thread Bob Liu
Hi Piotr, On 08/06/2013 05:36 PM, Piotr Sarna wrote: > This patch fixes "mm: zcache: core functions added" patch, > available at https://lkml.org/lkml/2013/7/20/90. > It regards incorrect implementation of zcache_cleancache_flush_fs(). > > Function above should be effective only if cleancache

Re: [RFC PATCH 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-06 Thread Bob Liu
On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: > Hi, > > Currently zbud pages are not movable and they cannot be allocated from CMA > region. These patches try to address the problem by: > 1. Adding a new form of reclaim of zbud pages. > 2. Reclaiming zbud pages during migration and

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Bob Liu
wski Looks good to me. Reviewed-by: Bob Liu > --- > mm/zbud.c | 150 > +++-- > 1 file changed, 86 insertions(+), 64 deletions(-) > > diff --git a/mm/zbud.c b/mm/zbud.c > index ad1e781..a8e986f 100644 > --- a

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Bob Liu
...@samsung.com Looks good to me. Reviewed-by: Bob Liu bob@oracle.com --- mm/zbud.c | 150 +++-- 1 file changed, 86 insertions(+), 64 deletions(-) diff --git a/mm/zbud.c b/mm/zbud.c index ad1e781..a8e986f 100644 --- a/mm/zbud.c +++ b

Re: [RFC PATCH 0/4] mm: reclaim zbud pages on migration and compaction

2013-08-06 Thread Bob Liu
On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: Hi, Currently zbud pages are not movable and they cannot be allocated from CMA region. These patches try to address the problem by: 1. Adding a new form of reclaim of zbud pages. 2. Reclaiming zbud pages during migration and compaction. 3.

Re: [PATCH] mm: zcache: zcache_cleancache_flush_fs fix

2013-08-06 Thread Bob Liu
Hi Piotr, On 08/06/2013 05:36 PM, Piotr Sarna wrote: This patch fixes mm: zcache: core functions added patch, available at https://lkml.org/lkml/2013/7/20/90. It regards incorrect implementation of zcache_cleancache_flush_fs(). Function above should be effective only if cleancache pool

Re: [PATCH 0/2] zcache: a new start for upstream

2013-07-24 Thread Bob Liu
Hi Seth, On Mon, Jul 22, 2013 at 11:07 PM, Seth Jennings wrote: > Sorry for the dup Bob, last reply only went to linux-mm > > On Sat, Jul 20, 2013 at 10:36:56PM +0800, Bob Liu wrote: >> We already have zswap helps reducing the swap out/in IO operations by >> compressing

Re: [PATCH 0/2] zcache: a new start for upstream

2013-07-24 Thread Bob Liu
Hi Seth, On Mon, Jul 22, 2013 at 11:07 PM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: Sorry for the dup Bob, last reply only went to linux-mm On Sat, Jul 20, 2013 at 10:36:56PM +0800, Bob Liu wrote: We already have zswap helps reducing the swap out/in IO operations by compressing anon

Re: [PATCH] mm: zswap: add runtime enable/disable

2013-07-23 Thread Bob Liu
On 07/23/2013 03:34 AM, Seth Jennings wrote: > Right now, zswap can only be enabled at boot time. This patch > modifies zswap so that it can be dynamically enabled or disabled > at runtime. > > In order to allow this ability, zswap unconditionally registers as a > frontswap backend regardless of

Re: [PATCH] mm: zswap: add runtime enable/disable

2013-07-23 Thread Bob Liu
On 07/23/2013 03:34 AM, Seth Jennings wrote: Right now, zswap can only be enabled at boot time. This patch modifies zswap so that it can be dynamically enabled or disabled at runtime. In order to allow this ability, zswap unconditionally registers as a frontswap backend regardless of

[PATCH 0/2] zcache: a new start for upstream

2013-07-20 Thread Bob Liu
backend at first, which is based on the zbud allocation same as zswap. At the end, I hope we can combine the new cleancache backend with zswap(frontswap backend), in order to have a generic in-kernel memory compression solution in upstream. Bob Liu (2): zcache: staging: %s/ZCACHE/ZCACHE_OLD mm

[PATCH 1/2] zcache: staging: %s/ZCACHE/ZCACHE_OLD

2013-07-20 Thread Bob Liu
Signed-off-by: Bob Liu --- drivers/staging/zcache/Kconfig | 12 ++-- drivers/staging/zcache/Makefile |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig index 2d7b2da..f96fb12 100644 --- a/drivers

[PATCH 2/2] mm: zcache: core functions added

2013-07-20 Thread Bob Liu
1% 1% 105% 94% 65% 6% 29% -3% 50% You can see that reading side performance get improved a lot after using zcache. Because pages are cached by zcache, we only need to decompress them instead of reading from disk. Signed-off-by: Bob Liu --- mm/Kconfig

[PATCH 1/2] zcache: staging: %s/ZCACHE/ZCACHE_OLD

2013-07-20 Thread Bob Liu
Signed-off-by: Bob Liu bob@oracle.com --- drivers/staging/zcache/Kconfig | 12 ++-- drivers/staging/zcache/Makefile |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig index 2d7b2da..f96fb12

[PATCH 2/2] mm: zcache: core functions added

2013-07-20 Thread Bob Liu
% 1% 105% 94% 65% 6% 29% -3% 50% You can see that reading side performance get improved a lot after using zcache. Because pages are cached by zcache, we only need to decompress them instead of reading from disk. Signed-off-by: Bob Liu bob@oracle.com --- mm

[PATCH 0/2] zcache: a new start for upstream

2013-07-20 Thread Bob Liu
backend at first, which is based on the zbud allocation same as zswap. At the end, I hope we can combine the new cleancache backend with zswap(frontswap backend), in order to have a generic in-kernel memory compression solution in upstream. Bob Liu (2): zcache: staging: %s/ZCACHE/ZCACHE_OLD mm

Re: [PATCH] mm: zbud: fix condition check on allocation size

2013-07-18 Thread Bob Liu
On 07/17/2013 10:30 PM, Heesub Shin wrote: > zbud_alloc() incorrectly verifies the size of allocation limit. It > should deny the allocation request greater than (PAGE_SIZE - > ZHDR_SIZE_ALIGNED - CHUNK_SIZE), not (PAGE_SIZE - ZHDR_SIZE_ALIGNED) > which has no remaining spaces for its buddy. There

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-18 Thread Bob Liu
Hi Martin, On 07/18/2013 03:38 AM, Martin Steigerwald wrote: > Am Mittwoch, 17. Juli 2013, 09:38:34 schrieb Seth Jennings: >> On Wed, Jul 17, 2013 at 01:41:44PM +0200, Martin Steigerwald wrote: >>> Is there any way to run zcache concurrently with zswap? I.e. use zcache only >>> for read caches

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-18 Thread Bob Liu
Hi Martin, On 07/18/2013 03:38 AM, Martin Steigerwald wrote: Am Mittwoch, 17. Juli 2013, 09:38:34 schrieb Seth Jennings: On Wed, Jul 17, 2013 at 01:41:44PM +0200, Martin Steigerwald wrote: Is there any way to run zcache concurrently with zswap? I.e. use zcache only for read caches for

Re: [PATCH] mm: zbud: fix condition check on allocation size

2013-07-18 Thread Bob Liu
On 07/17/2013 10:30 PM, Heesub Shin wrote: zbud_alloc() incorrectly verifies the size of allocation limit. It should deny the allocation request greater than (PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE), not (PAGE_SIZE - ZHDR_SIZE_ALIGNED) which has no remaining spaces for its buddy. There is

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-17 Thread Bob Liu
Hi Martin, On 07/17/2013 06:04 PM, Martin Steigerwald wrote: Hi Seth, hi everyone, Yesterday I build 3.11-rc1 with CONFIG_ZSWAP and wanted to test it. I added zswap.enabled=1 and get: martin@merkaba:~> dmesg | grep zswap [0.00] Command line: BOOT_IMAGE=/vmlinuz-3.11.0-rc1-tp520+

Re: zswap: How to determine whether it is compressing swap pages?

2013-07-17 Thread Bob Liu
Hi Martin, On 07/17/2013 06:04 PM, Martin Steigerwald wrote: Hi Seth, hi everyone, Yesterday I build 3.11-rc1 with CONFIG_ZSWAP and wanted to test it. I added zswap.enabled=1 and get: martin@merkaba:~ dmesg | grep zswap [0.00] Command line: BOOT_IMAGE=/vmlinuz-3.11.0-rc1-tp520+

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:23 PM, Seth Jennings wrote: > On Thu, Jun 20, 2013 at 05:42:04PM +0800, Bob Liu wrote: >> > Just made a mmtests run of my own and got very different results: >> > >> >> It's strange, I'll update to rc6 and try again. >> By the way

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:37 AM, Seth Jennings wrote: > On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: >> Hi Seth, >> >> On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings >> wrote: >> > zswap is a thin backend for frontswap that takes pages that ar

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:37 AM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: Hi Seth, On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: zswap is a thin backend for frontswap that takes pages

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-20 Thread Bob Liu
On Thu, Jun 20, 2013 at 10:23 PM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On Thu, Jun 20, 2013 at 05:42:04PM +0800, Bob Liu wrote: Just made a mmtests run of my own and got very different results: It's strange, I'll update to rc6 and try again. By the way, are you using 824

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-19 Thread Bob Liu
On Wed, Jun 19, 2013 at 10:09 PM, Seth Jennings wrote: > On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: >> Hi Seth, >> >> On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings >> wrote: >> > zswap is a thin backend for frontswap that takes pages that ar

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-19 Thread Bob Liu
On Wed, Jun 19, 2013 at 10:09 PM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: On Mon, Jun 17, 2013 at 02:20:05PM +0800, Bob Liu wrote: Hi Seth, On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: zswap is a thin backend for frontswap that takes pages

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
> > I'm not sure how representative this is of real workloads, but it does > look rather fatal for zswap. The differences are so large, I wonder if > it's just some silly bug or config issue. > In my observation, zswap_pool_pages always close to zswap_stored_pages in this testing. I think it

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
> > So the minor fault rate improved and everything else got worse? I did the test again, in a new clean environment. I'm sure the config files are the same except enabled zswap. v3.10-rc4 v3.10-rc4

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
So the minor fault rate improved and everything else got worse? I did the test again, in a new clean environment. I'm sure the config files are the same except enabled zswap. v3.10-rc4 v3.10-rc4

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-18 Thread Bob Liu
I'm not sure how representative this is of real workloads, but it does look rather fatal for zswap. The differences are so large, I wonder if it's just some silly bug or config issue. In my observation, zswap_pool_pages always close to zswap_stored_pages in this testing. I think it means

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-17 Thread Bob Liu
Hi Seth, On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings wrote: > zswap is a thin backend for frontswap that takes pages that are in the process > of being swapped out and attempts to compress them and store them in a > RAM-based memory pool. This can result in a significant I/O reduction on the

Re: [PATCHv13 3/4] zswap: add to mm/

2013-06-17 Thread Bob Liu
Hi Seth, On Tue, Jun 4, 2013 at 4:33 AM, Seth Jennings sjenn...@linux.vnet.ibm.com wrote: zswap is a thin backend for frontswap that takes pages that are in the process of being swapped out and attempts to compress them and store them in a RAM-based memory pool. This can result in a

Re: [PATCHv13 0/4] zswap: compressed swap caching

2013-06-13 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: > This is the latest version of the zswap patchset for compressed swap caching. > This is submitted for merging into linux-next and inclusion in v3.11. > Have you noticed that pool_pages >> stored_pages, like this: [root@ca-dev32 zswap]# cat

Re: [PATCHv13 0/4] zswap: compressed swap caching

2013-06-13 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: This is the latest version of the zswap patchset for compressed swap caching. This is submitted for merging into linux-next and inclusion in v3.11. Have you noticed that pool_pages stored_pages, like this: [root@ca-dev32 zswap]# cat * 0

Re: [PATCH] xen/tmem: Don't over-write tmem_frontswap_poolid after tmem_frontswap_init set it.

2013-06-07 Thread Bob Liu
tswap_poolid=-1] >> >> Which meant that in the failing case we would not call the hypercall >> to initialize the pool and never be able to make any frontswap >> backend calls. >> >> Moving the frontswap_register_ops after setting the tmem_frontswap_poolid >> fi

Re: [PATCH] xen/tmem: Don't over-write tmem_frontswap_poolid after tmem_frontswap_init set it.

2013-06-07 Thread Bob Liu
it. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Nice catch! Reviewed-by: Bob Liu bob@oracle.com --- drivers/xen/tmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/xen/tmem.c b/drivers/xen/tmem.c index cc072c6..0f0493c 100644 --- a/drivers

Re: [PATCHv13 2/4] zbud: add to mm/

2013-06-05 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: > zbud is an special purpose allocator for storing compressed pages. It is > designed to store up to two compressed pages per physical page. While this > design limits storage density, it has simple and deterministic reclaim > properties that

Re: [PATCHv13 2/4] zbud: add to mm/

2013-06-05 Thread Bob Liu
Hi Seth, On 06/04/2013 04:33 AM, Seth Jennings wrote: zbud is an special purpose allocator for storing compressed pages. It is designed to store up to two compressed pages per physical page. While this design limits storage density, it has simple and deterministic reclaim properties that

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-30 Thread Bob Liu
Hi Seth, On 05/31/2013 05:20 AM, Seth Jennings wrote: > Andrew, Mel, > > This struct page stuffing is taking a lot of time to work out and _might_ be > fraught with peril when memmap peekers are considered. > > What do you think about just storing the zbud page metadata inline in the > memory

Re: [PATCHv12 2/4] zbud: add to mm/

2013-05-30 Thread Bob Liu
Hi Seth, On 05/31/2013 05:20 AM, Seth Jennings wrote: Andrew, Mel, This struct page stuffing is taking a lot of time to work out and _might_ be fraught with peril when memmap peekers are considered. What do you think about just storing the zbud page metadata inline in the memory page in

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-22 Thread Bob Liu
Hi Mel & Seth, On 05/21/2013 04:10 PM, Mel Gorman wrote: > On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: >> On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: >>> On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: My first guess is that the external

Re: [PATCHv11 2/4] zbud: add to mm/

2013-05-22 Thread Bob Liu
Hi Mel Seth, On 05/21/2013 04:10 PM, Mel Gorman wrote: On Mon, May 20, 2013 at 10:42:25AM -0500, Seth Jennings wrote: On Mon, May 20, 2013 at 02:54:39PM +0100, Mel Gorman wrote: On Sun, May 19, 2013 at 03:52:19PM -0500, Seth Jennings wrote: My first guess is that the external fragmentation

<    2   3   4   5   6   7   8   9   >