a slight disagreement about them.
I wanted to merge them, but Andreas is concerned that there may be some
cases in which we should get rid of parameter descriptions altogether.
So I've been waiting for Andreas to review them all before we push them.
Also, the dir.c patch might be out of date because of a patch I recently did
that
was recently added to for-next. I'll work with Andreas to expedite them so
they can go into the next merge window.
Regards,
Bob Peterson
ger
needed the variable "error" so I removed it to avoid warnings.
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=0e787a0bfabb8be323f575d5cdda48e607840eb5
Regards,
Bob Peterson
ng your patch. I like it. However, since gfs2_make_fs_ro
always returns 0, we should also be able to make it a void function instead
of int, and change its callers to not act on any return code.
Regards,
Bob Peterson
Red Hat File Systems
ll, it seems like we should do
> something about it, like refuse to mount a frozen device. Perhaps it already
> does that; I'll need to do some research.
After some experiments, I've determined that my fears about the count are
unfounded.
Consider my patch withdrawn. Sorry for the noise.
Bob Peterson
number of thaws should match your
freezes, and if they don't: user error. Still, it seems like we should do
something about it, like refuse to mount a frozen device. Perhaps it already
does that; I'll need to do some research.
Like I said, I don't know this code. I'm just trying to fix a problem
I observed. I'll defer to the experts.
Regards,
Bob Peterson
ike: "unable to handle page fault
for address."
This patch adds the necessary decrement of bd_fsfreeze_count for that
error path. It also adds code to set the bd_fsfreeze_sb to NULL when the
last reference is reached in thaw_bdev.
Signed-off-by: Bob Peterson
---
fs/block_dev.c | 5
- Original Message -
> Can someone pick this up? Maybe through Jens' block tree as that is
> where my commit this is fixing up came from.
Christoph and Al,
Here is my version:
Bob Peterson
fs: fix freeze count problem in freeze_bdev
Before this patch, if you tried to free
bdev->bd_fsfreeze_count++;
> > + else
> > + bdev->bd_fsfreeze_sb = NULL;
> > out:
> > mutex_unlock(&bdev->bd_fsfreeze_mutex);
> > return error;
> > --
> > 2.29.2.729.g45daf8777d-goog
> ---end quoted text---
>
>
Funny you should ask. I came across this bug in my testing of gfs2
and my patch is slightly different. I was wondering who to send it to.
Perhaps Viro?
Regards,
Bob Peterson
; v2: add gfs2_glock_cachep for same operation
> ---
Hi,
Thanks. Your patch is now pushed to the linux-gfs2/for-next branch.
I cleaned up the description a bit. For example, I changed "fs:" to
"gfs2:" to conform to other gfs2 patches.
Regards,
Bob Peterson
_quotad_cachep)
> goto fail_cachep6;
>
> --
> 1.9.1
>
>
Hi,
Thanks for the patch.
We should also do this for gfs2_glock_cachep. Can you add that to your patch?
Regards,
Bob Peterson
withdraw to replay journals and wait for it to
> finish
>
> Andy
Hi Andy. Thanks for your analysis.
I suspect you're right.
It's probably another exception to the rule. We knew there would be a few of
those with 601ef0d52e96, such as the one we made for "withdrawing during
withdraw".
We should probably just add a check for NULL and make it do the right thing.
Regards,
Bob Peterson
- Original Message -
> Hi Bob, hi Greg,
>
> On Fri, Sep 11, 2020 at 08:49:14AM -0400, Bob Peterson wrote:
> > - Original Message -
> > > On Fri, Sep 11, 2020 at 08:08:35AM -0400, Bob Peterson wrote:
> > > > - Original Message -
> >
- Original Message -
> On Fri, Sep 11, 2020 at 08:08:35AM -0400, Bob Peterson wrote:
> > - Original Message -
> > > On Thu, Sep 10, 2020 at 09:43:19PM +0200, Salvatore Bonaccorso wrote:
> > > > Hi,
> > > >
> > > > On Tue, Jun
- Original Message -
> On Thu, Sep 10, 2020 at 09:43:19PM +0200, Salvatore Bonaccorso wrote:
> > Hi,
> >
> > On Tue, Jun 23, 2020 at 09:57:50PM +0200, Greg Kroah-Hartman wrote:
> > > From: Bob Peterson
> > >
> > > [ Upstream
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 49a57857aeea06ca831043acbb0fa5e0f50602fd:
Linux 5.0-rc3 (2019-01-21 13:14:44 +1300)
are
This reverts commit 2a5f14f279f59143139bcd1606903f2f80a34241.
This patch causes xfstests generic/311 to fail. Reverting this for
now until we have a proper fix.
Signed-off-by: Abhi Das
Signed-off-by: Bob Peterson
---
fs/gfs2/glops.c | 1 -
fs/gfs2/log.c| 4 +-
fs/gfs2/lops.c
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 40e020c129cfc991e8ab4736d2665351ffd1468d:
Linux 4.20-rc6 (2018-12-09 15:31:00 -0800
Hi Linus,
Welcome back.
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 050cdc6c9501abcd64720b8cc3e7941efee9547d:
Merge git://git.kernel.org/pub
- Original Message -
> Hi all,
>
> Commit
>
> b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
> kernel threads")
>
> is missing a Signed-off-by from its committer.
>
> --
> Cheers,
> Stephen Rothwell
Fixed now. Sorry about that.
Regards,
Bob Peterson
Hi Linus,
Please consider pulling the following additional 3 patches for the GFS2
file system.
Regards,
Bob Peterson
The following changes since commit e241e3f2bf975788a1b70dff2eb5180ca395b28e:
Merge tag 'for_linus
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=450b1f6f56350c630e795f240dc5a77aa8aa2419
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=3fd5d3ad35dc44aaf0f28d60cc0eb75887bff54d
Regards,
Bob Peterson
Red Hat File Systems
---
> include/linux/lockref.h | 1 +
> lib/lockref.c | 28
> 3 files changed, 57 insertions(+), 19 deletions(-)
>
> --
> 2.14.3
Hi,
The patches look good. The big question is whether to add them to this
merge window while it's still open. Opinions?
Acked-by: Bob Peterson
Regards,
Bob Peterson
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 1b88accf6a659c46d5c8e68912896f112bf882bb:
Merge tag 'for_linus' of
git://git.
Hi Linus,
Would you please pull this additional patch from Andreas Gruenbacher
that fixes another unfortunate GFS2 regression? Thanks.
Bob Peterson
---
The following changes since commit 86f84779d8e92a690b2f281175ea06b884cb6fa4:
Merge branch 'siginfo-linus' of
git://git.kernel.o
Hi Linus,
Would you please pull this one-off patch from Andreas Gruenbacher
that fixes a GFS2 regression? Thanks.
Bob Peterson
---
The following changes since commit 35277995e17919ab838beae765f440674e8576eb:
Merge branch 'x86-pti-for-linus' of
git://git.kernel.org/pub/scm/linux/
Hi Linus,
Sorry to bother you with a second merge request for GFS2, but we found
a couple regressions and want to get them fixed in this merge window.
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 1291a0d5049dbc06baaaf66a9ff3f53db493b19b:
Linux 4.15-rc4 (2017-12-17 18:59:59 -0800
- Original Message -
|
|
| On 16/01/18 20:51, Stephen Rothwell wrote:
| > Hi all,
| >
| > Commit
| >
| >7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
| >
| > is missing a Signed-off-by from its author.
| >
| Bob, can you add that?
|
| Steve.
This should be
t the accepted Linux coding style document. See:
|
|
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
|
| Regards,
|
| Bob Peterson
|
|
Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as print
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings
Regards,
Bob Peterson
-next&id=8b0d7f56b97b95a442b6785027a0f80ad1ea54af
Regards,
Bob Peterson
Red Hat File Systems
following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff:
Linux 4.14-rc3 (2017-10-01 14:54:54 -0700)
are available in the git repository
- Original Message -
| Hi Linus,
|
| Please consider pulling the following changes for the GFS2 file system.
|
| Regards,
|
| Bob Peterson
|
| The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff:
Linux 4.14-rc3 (2017-10-01 14:54:54 -0700
Hi Linus,
Would you please pull this one-off patch from Andreas Gruenbacher
that fixes a GFS2 regression? Thanks.
Bob Peterson
---
The following changes since commit 46c1e79fee417f151547aa46fae04ab06cb666f4:
Merge branch 'perf-urgent-for-linus' of
git://git.kernel.org/pub/scm/li
Hi Linus,
Sorry this is a bit rushed, but I wanted to get this out this week, and
I'll be traveling for the next ten days with unknown Internet access.
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Pet
-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=d296b15ed58231bd991c0fb0f3592d595539bcd1
Regards,
Bob Peterson
Red Hat File Systems
* ...Note that we take the RCU lock in all
* cases including when we return an error. So you must always call
* rhashtable_walk_stop to clean up.
This patch replaces the continue with a goto and label to ensure a
matching call to rhashtable_walk_stop().
Signed-off-by: Bob Peterson
---
diff -
s a case in which we
can have blocks in writeback that are beyond i_size. See the commit
message on Ben's patch here:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=fd4c5748b8d3f7420e8932ed0bde3d53cc8acc9d
Regards,
Bob Peterson
Red Hat File Systems
hat happens in that case, but the same thing
would happen in the existing -EIO case a few lines above.
On the other hand, we probably don't want to start a new transaction
and start adding revokes to it, and such, due to the error.
Perhaps Steve Whitehouse can weigh in?
Regards,
Bob Peterson
Red Hat File Systems
i_size - 1);
| + }
| + }
| + err2 = file_check_and_advance_wb_err(file);
| + if (!err)
| + err = err2;
| + return err;
In the past, I've seen more elegant constructs like:
return (err ? err : err2);
but I don't know what's considered more ugly or
now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=e7cb550d79fba5876616ed33ccafafc4e2bd7e2e
Regards,
Bob Peterson
Red Hat File Systems
pulling the following additional patch for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 9b51f04424e17051a89ab32d892ca66b2a104825:
Merge branch 'parisc-4.13-2' of
git://git.kernel.org/pub
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit 3ef2bc099d1cce09e2844467e2ced98e1a44609d:
Merge tag 'devicetree-for-4.12
to the for-next branch of the linux-gfs2 tree:
1fc2e87 GFS2: constify attribute_group structures.
Regards,
Bob Peterson
Red Hat File Systems
that occur during the write
| phase.
|
| Signed-off-by: Jeff Layton
| ---
Hi Jeff,
This version looks better. ACK.
Regards,
Bob Peterson
Red Hat File Systems
unch of similar cleanups myself, but I don't think
there's any overlap.
Regards,
Bob Peterson
Red Hat File Systems
next time. (Next time we hopefully won't have any merge commits).
Regards,
Bob Peterson
The following changes since commit f9fe1c12d126f9887441fa5bb165046f30ddd4b5:
rhashtable: Add rhashtable_lookup_get_insert_fast (2017-03-21
can't unmount a gfs2 file system after withdraw due to errors).
My question is: How would you like me to handle it?
Push the new patch, tag it, and do a second pull request?
Wait until you've processed the first pull request, then do so?
Or is there a better way?
Regards,
Bob Peterson
- Original Message -
| There's no need to update flags in gfs2_rename2()
| This will ease whiteout addition.
|
| Signed-off-by: Fabian Frederick
| ---
Hi Fabian,
Your patches look good. I'll push them to the for-next branch of our
repo after the merge window is closed.
Reg
ully won't have any merge commits).
Regards,
Bob Peterson
The following changes since commit f9fe1c12d126f9887441fa5bb165046f30ddd4b5:
rhashtable: Add rhashtable_lookup_get_insert_fast (2017-03-21 17:52:45 -0700)
are avail
Hi,
- Original Message -
| On Mon, 2017-04-24 at 10:12 -0400, Bob Peterson wrote:
| > > + filemap_write_and_wait_range(mapping, gl->gl_vm.start, gl->gl_vm.end);
| >
| > This should probably have "error = ", no?
| >
|
| This error is discarded in the c
metamapping);
| - mapping_set_error(metamapping, error);
This part doesn't look right at all. There's a big difference in gfs2 between
mapping and metamapping. We need to wait for metamapping regardless.
(snip)
Regards,
Bob Peterson
Red Hat File Systems
t;nearly infinite amount of time" having
passed, and then various watchdogs nuking nodes.
I remember a long time ago someone was up in arms because of weird
effects they were seeing, and it boiled down to not using any time sync
and one of their cluster nodes had the wrong month, or some such.
Regards,
Bob Peterson
Red Hat File Systems
- Original Message -
| On Wed, Mar 15, 2017 at 7:32 AM, Bob Peterson wrote:
| >
| > Andreas Gruenbacher (1):
| > gfs2: Avoid alignment hole in struct lm_lockname
|
| So I've pulled this because I think it fixes a real bug, but honestly
| I think it's the wron
Hi Linus,
Please consider pulling the following additional patch for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit ae50dfd61665086e617cc9e554a1285d52765670:
Merge git://git.kernel.org/pub/scm
Hi Linus,
Please consider pulling the following additional patch for the GFS2 file system.
Sorry for the lack of bake time on this one, but it is high priority, simple,
and has been well tested.
Bob Peterson
The following
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Bob Peterson
The following changes since commit a3443cda5588985a2724d6d0f4a5f04e625be6eb:
Merge branch 'next' of
git://git.kernel.o
about 15 times each,
and no failures. Not sure why I got it the first time. Must have been a one-off.
Bob Peterson
ocode: CPU14: patch_level=0x01d9
[5.452724] microcode: CPU15: patch_level=0x01d9
[5.457756] microcode: Microcode Update Driver: v2.01
, Peter Oruba
# uname -a
Linux intec2 4.9.0-rc2+ #2 SMP Thu Oct 27 14:29:32 EDT 2016 x86_64 x86_64
x86_64 GNU/Linux
Regards,
Bob Peterson
- Original Message -
| On Wed, Oct 26, 2016 at 11:04 AM, Bob Peterson wrote:
| >
| > I can test it for you, if you give me about an hour.
|
| I can definitely wait an hour, it would be lovely to see more testing.
| Especially if you have a NUMA machine and an interesting wo
- Original Message -
| On Wed, Oct 26, 2016 at 11:04 AM, Bob Peterson wrote:
| >
| > I can test it for you, if you give me about an hour.
Sorry. I guess I underestimated the time it takes to build a kernel
on my test box. It will take a little longer, but it's compiling now
about page locking (if
| they ever even notice), PeterZ will stand up like the hero he is, and
| say "look here, I can solve this for you".
|
| Linus
|
I can test it for you, if you give me about an hour.
Bob Peterson
(Resending to lkml (only) because my cc was malformed)
Hi Linus,
Please consider pulling the following changes for the GFS2 file system.
Bob Peterson
The following changes since commit 731c7d3a205ba89b475b2aa71b5f13dd6ae3de56
or-next&id=e0d735c1cc2749598f2d29f60f9a16658fd96ae9
Regards,
Bob Peterson
Red Hat File Systems
2 +-
| 8 files changed, 23 insertions(+), 23 deletions(-)
|
Hi Fabian,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=47a9a527946842dd8d83d4c8c8be22b2615b65f5
Regards,
Bob Peterson
Red Hat File Systems
ted with a reliable recreation
scenario. Since the bug prevents users from mounting their GFS2 file
system, I wanted to get it in as soon as possible. I felt that the need
outweighed other concerns.
Since I'll be on vacation next week, Andreas Gruenbacher can make changes
to the linux-
blocked on memory allocation
that caused the slab shrinker to be called in the first place.
Signed-off-by: Bob Peterson
---
fs/gfs2/incore.h | 2 ++
fs/gfs2/ops_fstype.c | 1 +
fs/gfs2/quota.c | 25 +
fs/gfs2/super.c | 13 +
4 files changed, 41
thout blocking on GFS2. The process that caused the shrink (in the
example above, the fence daemon) may then proceed without blocking.
The daemon can then safely evict the inodes, calling the DLM without
the risk of deadlock.
Signed-off-by: Bob Peterson
---
Bob Peterson (2):
vfs: Add hook
This patch adds filesystem-specific callbacks for shrinking the
inode cache, prune_icache_sb. This is provided for filesystems in
which the default VFS prune_icache_sb needs to be delayed due to
filesystem locking requirements not met by vfs.
Signed-off-by: Bob Peterson
---
Documentation
Hi,
Please consider pulling the following changes for the GFS2 file system.
Bob Peterson
The following changes since commit 9dffdb38d864ae89e16ff7b3a09451270736e35b:
Merge tag 'staging-4.6-rc1' of
git://git.kernel.o
- Original Message -
> This function compiles to 522 bytes of machine code.
>
> Error paths are not very time critical.
>
> Signed-off-by: Denys Vlasenko
> CC: Steven Whitehouse
> CC: Bob Peterson
> CC: cluster-de...@redhat.com
> CC: linux-kernel@vger.
- Original Message -
> This function compiles to 522 bytes of machine code.
>
> Error paths are not very time critical.
>
> Signed-off-by: Denys Vlasenko
> CC: Steven Whitehouse
> CC: Bob Peterson
> CC: cluster-de...@redhat.com
> CC: linux-kernel@vger.
Hi,
Please consider pulling the following changes for the GFS2 file system.
Bob Peterson
The following changes since commit 67990608c8b95d2b8ccc29932376ae73d5818727:
Merge tag 'pm+acpi-4.5-rc1-1' of
git://git.kern
error;
>
> /* Get the old leaf block */
> --
> 2.7.0
>
>
Hi,
Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=07cfdc3071432a07713e4d007c2811e0224490b0
Regards,
Bob Peterson
Red Hat File Systems
Hi,
Does this look familiar to anyone?
Granted, this was seen on a recent linux-gfs2/for-next kernel, but it
doesn't seem related to any of the GFS2 patches.
Regards,
Bob Peterson
Red Hat File Systems
[ 2083.844866] PANIC: double fault, error_code: 0x0
[ 2083.845020] CPU: 0 PID: 26262
TED_PAGE, it might jump to retry_lookup, but then discover that the
page is PageUptodate(), goto fill_it with error still set to AOP_TRUNCATED_PAGE,
then end up returning that to the caller.
Regards,
Bob Peterson
Red Hat File Systems
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Original Message -
> Function gfs2_xattr_acl_chmod is unused since commit e01580bf.
>
> Signed-off-by: Andreas Gruenbacher
> Cc: Steven Whitehouse
> Cc: Bob Peterson
> Cc: cluster-de...@redhat.com
> ---
> fs/gfs2/xattr.c | 50
to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=6fde22426be6af261816db5941744b8d3c4c7f96
Regards,
Bob Peterson
Red Hat File Systems
--
To unsubscribe from this list: send the line "uns
> +++ b/fs/gfs2/ops_fstype.c
> @@ -910,8 +910,7 @@ fail_qc_i:
> fail_ut_i:
> iput(sdp->sd_sc_inode);
> fail:
> - if (pn)
> - iput(pn);
> + iput(pn);
> return error;
> }
>
> --
> 2.6.2
>
>
Hi Markus,
ACK,
I'll sa
ss
of the problem warranted an exception. It's proven to compile and been
tested against a reliable reproducer.
Bob Peterson
The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:
Linux 4.3-rc1 (2015-0
target. It currently
> cannot corrupt the operation values.
>
> - The patchset is a little awkward. It touches so much code,
> but I wanted to maintain git bisectibility, so there is lots of compat code
> left around until the last patches where everyting is cleaned up.
Hi Mike,
The G
Hi,
Please consider pulling the following changes for the GFS2 file system.
I apologize for the late request, but as I explained in my previous email,
I wanted to make sure everything was done "the right way."
Bob Peterson
--
nesday. All of them are pretty much
confined to GFS2 (except for new calls to rhashtable functions) so
hopefully this is just a formality. Sorry for the delay.
Regards,
Bob Peterson
GFS2 Maintainer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
S2_GL_HASH_SIZE * 3 / 4,
> .key_len = sizeof(struct lm_lockname),
> .key_offset = offsetof(struct gfs2_glock, gl_name),
>
Hi,
Thanks. Now pushed to the for-next branch of the linux-gfs2 tree.
Regards,
Bob Peterson
Red Hat File Systems
--
To unsubscribe from this list: se
Hi,
Please consider pulling the following changes for the GFS2 file system.
Regards,
Bob Peterson
The following changes since commit f4a3ae9308e34bcd704325a08879b2c1cfb74686:
GFS2: Use average srttb value in congestion
- Original Message -
> Bob Peterson wrote:
> > - Original Message -
> >
> >> Hi Bob,
> >>
> >> Bob Peterson wrote:
> >>
> >>> - Original Message -
> >>>
> >>&
- Original Message -
> Hi Bob,
>
> Bob Peterson wrote:
> > - Original Message -
> >
> >> We don't need the redundant logic since send_message always returns 0.
> >>
> >> Signed-off-by: Guoqing Jiang
> >> -
oks okay, but if remove_from_waiters() always returns 0,
wouldn't it be better to change the function from int to void and
return 0 here? The advantage is that code spelunkers wouldn't need
to back-track one more level (not to mention the instruction or two
it might save).
Regards,
Bob
- Original Message -
> bi was already declared and initialized globally in gfs2_rbm_find()
>
> Suggested-by: Bob Peterson
> Signed-off-by: Fabian Frederick
> ---
> V2: use global bi instead of new call to rbm_bi()
> on local variable.
>
> fs/gfs2/rgrp.c |
&bi->bi_flags);
> + struct gfs2_bitmap *bi_full = rbm_bi(rbm);
> +
> + set_bit(GBF_FULL, &bi_full->bi_flags);
> }
>
> next_bitmap: /* Find next bitmap in the rgrp */
> --
> 2.4.0
Hi,
In this case, I think it makes more sense
Signed-off-by: Fabian Frederick
Hi,
Thanks. Now in the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=1272574bf94874a644ea82fad321034c15b157ac
Regards,
Bob Peterson
Red Hat File Systems
--
To unsubscribe fr
>
> Signed-off-by: Fabian Frederick
Hi,
Thanks. The v3 version of the patch is now in the for-next branch of the
linux-gfs2 tree:
https://git.kernel.org/cgit/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=e50ead480fac63ede9e0b656cd29c1820f7af9de
Regards,
Bob Peterson
;
> if (val == 1)
> set_bit(DFL_BLOCK_LOCKS, &ls->ls_recover_flags);
> @@ -335,10 +361,9 @@ static ssize_t block_store(struct gfs2_sbd *sdp, const
> char *buf, size_t len)
> clear_bit(DFL_BLOCK_LOCKS, &ls->ls_recover_flags);
>
t; on i386:
>
> ERROR: "__divdi3" [fs/gfs2/gfs2.ko] undefined!
>
>
>
> --
> ~Randy
Hi,
My apologies. I've pushed an addendum patch that fixes the problem to
the for-next branch of the linux-gfs2.git git tree.
Regards,
Bob Peterson
--
To unsubscribe from
- Original Message -
> On Tue, Apr 14, 2015 at 10:47 AM, Bob Peterson wrote:
> >
> > 12 files changed, 184 insertions(+), 95 deletions(-)
>
> Oh, and this was incorrect. You had apparently limited the statistics
> to the fs/gfs2 directory, and thus m
Hi,
Please consider pulling the following changes,
Bob Peterson
GFS2: merge window
Here is a list of patches we've accumulated for GFS2 for the current upstream
merge window. Most of the patches fix GFS2 quotas, which wer
age values that result in miscalculations.
This patch fixes this race by moving the check for the QDF_REFRESH
flag check further out into the gfs2_quota_lock() process, i.e, in
do_glock(), under the protection of the quota glock.
Signed-off-by: Abhi Das
Signed-off-by: Bob Peterson
Acked-
e are atleast 'min_target' blocks allowable/available. The
assumption is that the caller is ok with just 'min_target' blocks
and will likely proceed with allocating them.
Signed-off-by: Abhi Das
Signed-off-by: Bob Peterson
Acked-by: Steven Whitehouse
we allocate a bunch of blocks
at once) the quota excess is non-trivial and is addressed by this
patch.
Signed-off-by: Abhi Das
Signed-off-by: Bob Peterson
Acked-by: Steven Whitehouse
---
fs/gfs2/aops.c | 6 +++---
fs/gfs2/bmap.c | 2 +-
fs/gfs2/file.c | 15 ---
fs/gfs2/incor
1 - 100 of 120 matches
Mail list logo
