Re: [PATCH] mtd: dataflash: replace msleep with usleep_range

2018-04-26 Thread Boris Brezillon
On Wed, 18 Apr 2018 11:26:26 +0200 Luca Ellero wrote: > Since msleep is based on jiffies, this 3 ms sleep becomes actually 20 ms. > Worst of all, since this sleep is used in a loop when writing, a single page > write (256 to 1024 bytes) causes 17 ms extra time. > When writing large files (for exa

Re: [PATCH] mtd: nand: davinci: don't acquire and enable clock

2018-04-26 Thread Boris Brezillon
Hi Sekhar, On Fri, 30 Mar 2018 20:00:51 +0530 Sekhar Nori wrote: > NAND itself is an asynchronous interface, it does not have any > clock input. DaVinci NAND driver acquires clock for AEMIF > (asynchronous external memory interface) which is an on-chip > IP to which NAND is connected. > > The s

Re: [PATCH] mtd: partitions: Handle add_mtd_device() failures gracefully

2018-04-26 Thread Boris Brezillon
Hi Geert, Sorry for the late reply. On Tue, 10 Apr 2018 15:26:20 +0200 Geert Uytterhoeven wrote: > Hi Marek, > > On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote: > > On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote: > >> Currently add_mtd_device() failures are plainly ignored, which may

Re: [PATCH] drm/core: Remove drm_dev_unref() and it's uses

2018-04-26 Thread Boris Brezillon
| 4 ++-- > drivers/gpu/drm/armada/armada_drv.c| 6 +++--- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- For atmel-hlcdc: Acked-by: Boris Brezillon

Re: [PATCH v4 2/8] dt-bindings: display: atmel: optional video-interface of endpoints

2018-04-23 Thread Boris Brezillon
ding on the selected output mode. For > devices that do not have the "conflicting output formats" issue > (SAMA5D2, SAMA5D4), this is completely irrelevant. > > Signed-off-by: Peter Rosin Acked-by: Boris Brezillon > --- > .../devicetree/bindings/display/atmel/

Re: [PATCH v4 3/8] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-23 Thread Boris Brezillon
d output mode. For > devices that do not have the "conflicting output formats" issue > (SAMA5D2, SAMA5D4), this is completely irrelevant. > > Signed-off-by: Peter Rosin Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 70 > +

Re: [PATCH v4 00/10] Add the I3C subsystem

2018-04-23 Thread Boris Brezillon
Hi, On Fri, 30 Mar 2018 09:47:41 +0200 Boris Brezillon wrote: > This patch series is a proposal for a new I3C subsystem. This v4 has been sent almost a month ago and I didn't get any feedback so far apart from Rob's R-b. Greg, is there any chance we can get these patches merged in

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-23 Thread Boris Brezillon
On Mon, 23 Apr 2018 11:40:09 +0200 Quentin Schulz wrote: > Hi Boris, > > On Fri, Apr 20, 2018 at 07:19:24PM +0200, Boris Brezillon wrote: > > On Fri, 20 Apr 2018 10:52:41 +0200 > > Quentin Schulz wrote: > > > > > There's already ECC on NAND

Re: [PATCH 30/61] mtd: nand: onenand: simplify getting .drvdata

2018-04-22 Thread Boris Brezillon
On Thu, 19 Apr 2018 16:06:00 +0200 Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Applied to nand/next. Thanks, Boris > --- > > Build tested only. buildbot is happy. Pl

Re: [PATCH] mtd: nand: mtk: use of_device_get_match_data()

2018-04-22 Thread Boris Brezillon
On Mon, 16 Apr 2018 10:33:54 +0800 Ryder Lee wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call .probe() is to match an entry in > .of_match_table[], so of_device_id cannot be NULL. > > Signed-off-by: Ryder Lee > --- > drivers/mtd/nand/

Re: [PATCH] mtd: nand: diskonchip: Replace mdelay with usleep_range in doc_probe

2018-04-22 Thread Boris Brezillon
On Wed, 11 Apr 2018 10:57:57 +0800 Jia-Ju Bai wrote: > doc_probe() is never called in atomic context. > > doc_probe() is only called by init_nanddoc(), which is only set as > a parameter of module_init(). > This function is not called in atomic context. > > Despite never getting called from at

Re: [PATCH v2 1/2] mtd: rawnand: gpmi: add support for specific ECC strength

2018-04-22 Thread Boris Brezillon
On Sun, 4 Mar 2018 21:06:01 +0100 Stefan Agner wrote: > Add support for specified ECC strength/size using device tree > properties nand-ecc-strength/nand-ecc-step-size. > > Signed-off-by: Stefan Agner Applied to nand/next. Thanks, Boris > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 30

Re: [PATCH v4] mtd: spi-nor: clear Winbond Extended Address Reg on switch to 3-byte addressing.

2018-04-22 Thread Boris Brezillon
On Sat, 21 Apr 2018 08:54:40 +1000 NeilBrown wrote: > Winbond spi-nor flash 32MB and larger have an 'Extended Address > Register' as one option for addressing beyond 16MB (Macronix > has the same concept, Spansion has EXTADD bits in the Bank Address > Register). > > According to section >8.2

Re: [PATCH] mtd: spi-nor: cadence-quadspi: Add DMA support for direct mode reads

2018-04-22 Thread Boris Brezillon
On Tue, 10 Apr 2018 13:49:10 +0530 Vignesh R wrote: > Add support to use DMA over memory mapped reads in direct mode. This > helps in reducing CPU usage from ~100% to ~10% when reading data from > flash. For non-DMA'able/vmalloc'd buffers, driver just falls back to CPU > based memcpy. > > Signed

Re: [PATCH 29/61] mtd: devices: simplify getting .drvdata

2018-04-22 Thread Boris Brezillon
On Thu, 19 Apr 2018 16:05:59 +0200 Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Applied to mtd/next. Thanks, Boris > --- > > Build tested only. buildbot is happy. Ple

Re: [PATCH v3 4/7] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-21 Thread Boris Brezillon
On Thu, 19 Apr 2018 18:27:48 +0200 Peter Rosin wrote: > This beats the heuristic that the connector is involved in what format > should be output for cases where this fails. > > E.g. if there is a bridge that changes format between the encoder and the > connector, or if some of the RGB pins betw

Re: [patch V2 6/8] mtd/diskonchip: Allocate rs control per instance

2018-04-21 Thread Boris Brezillon
and can operate in parallel. At > least in theory > > Instantiate a rs control instance per DoC device to avoid that. The per > instance buffer is fine as the operation on a single DoC instance is > serialized by the MTD/NAND core. > > Signed-off-by: Thomas Gleixner >

Re: [patch V2 5/8] rslib: Split rs control struct

2018-04-21 Thread Boris Brezillon
r buffers to the control structure > later on. > > Signed-off-by: Thomas Gleixner > Cc: Boris Brezillon > Cc: Tony Luck > Cc: Kees Cook > Cc: Segher Boessenkool > Cc: Kernel Hardening > Cc: Richard Weinberger > Cc: Mike Snitzer > Cc: Anton Vorontsov > C

Re: [PATCH v2] mtd: spi-nor: clear Winbond Extended Address Reg on switch to 3-byte addressing.

2018-04-20 Thread Boris Brezillon
On Sat, 21 Apr 2018 07:28:19 +1000 NeilBrown wrote: > On Fri, Apr 20 2018, Boris Brezillon wrote: > > > Hi Neil, > > > > On Mon, 16 Apr 2018 09:42:30 +1000 > > NeilBrown wrote: > > > >> Winbond spi-nor flash 32MB and larger have an '

Re: [PATCHv2] mtd: spi-nor: Fix Cadence QSPI page fault kernel panic

2018-04-20 Thread Boris Brezillon
On Mon, 26 Mar 2018 09:12:17 -0500 thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > The current Cadence QSPI driver caused a kernel panic when loading > a Root Filesystem from QSPI. The problem was caused by reading more > bytes than needed because the QSPI operated on 4 bytes at a tim

Re: [PATCH v2] mtd: onenand: omap2: Disable DMA for HIGHMEM buffers

2018-04-20 Thread Boris Brezillon
Hi Ladislav, On Mon, 16 Apr 2018 08:52:59 +0200 Ladislav Michl wrote: > dma_map_single doesn't get the proper DMA address for vmalloced area, That's not true, it returns the right DMA (physical) address, it's just that: 1/ the memory location is not necessarily physically contiguous 2/ in case

Re: [PATCH v2] mtd: spi-nor: clear Winbond Extended Address Reg on switch to 3-byte addressing.

2018-04-20 Thread Boris Brezillon
Hi Neil, On Mon, 16 Apr 2018 09:42:30 +1000 NeilBrown wrote: > Winbond spi-nor flash 32MB and larger have an 'Extended Address > Register' as one option for addressing beyond 16MB (Macronix > has the same concept, Spansion has EXTADD bits in the Bank Address > Register). > > According to sectio

Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

2018-04-20 Thread Boris Brezillon
On Fri, 20 Apr 2018 10:52:41 +0200 Quentin Schulz wrote: > There's already ECC on NAND pages so there may be no need for one to > check the CRC of a UBI volume. That's true that ECC can help detecting corruptions, but I don't think this is the actual reason for disabling CRC check at volume open

Re: [PATCH v2 5/6] drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder

2018-04-18 Thread Boris Brezillon
On Wed, 18 Apr 2018 10:02:12 +0200 Peter Rosin wrote: > On 2018-04-18 09:36, Boris Brezillon wrote: > > On Tue, 17 Apr 2018 15:10:51 +0200 > > Peter Rosin wrote: > > > >> When the of-graph points to a tda998x-compatible HDMI encoder, register > >>

Re: [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints

2018-04-18 Thread Boris Brezillon
On Wed, 18 Apr 2018 09:31:53 +0200 Peter Rosin wrote: > On 2018-04-18 09:16, Boris Brezillon wrote: > > Hi Peter, > > > > On Tue, 17 Apr 2018 15:10:48 +0200 > > Peter Rosin wrote: > > > >> With bus-type/bus-width properties in the endpoint nodes, t

Re: [PATCH v2 4/6] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-18 Thread Boris Brezillon
On Wed, 18 Apr 2018 09:46:09 +0200 Peter Rosin wrote: > On 2018-04-18 09:29, Boris Brezillon wrote: > > On Tue, 17 Apr 2018 15:10:50 +0200 > > Peter Rosin wrote: > > > >> This beats the heuristic that the connector is involved in what format > >> shou

Re: [PATCH v2 6/6] drm/atmel-hlcdc: fix broken release date

2018-04-18 Thread Boris Brezillon
On Tue, 17 Apr 2018 15:10:52 +0200 Peter Rosin wrote: > Bump the minor version while at it. > > Signed-off-by: Peter Rosin > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_

Re: [PATCH v2 5/6] drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder

2018-04-18 Thread Boris Brezillon
atmel_hlcdc_crtc_create(struct drm_device *dev); > > int atmel_hlcdc_create_outputs(struct drm_device *dev); > > +struct component_match; > +int atmel_hlcdc_add_component_encoder(struct drm_device *dev); > +int atmel_hlcdc_get_external_components(struct device *dev, > +

Re: [PATCH v2 4/6] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes

2018-04-18 Thread Boris Brezillon
On Tue, 17 Apr 2018 15:10:50 +0200 Peter Rosin wrote: > This beats the heuristic that the connector is involved in what format > should be output for cases where this fails. > > E.g. if there is a bridge that changes format between the encoder and the > connector, or if some of the RGB pins betw

Re: [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints

2018-04-18 Thread Boris Brezillon
Hi Peter, On Tue, 17 Apr 2018 15:10:48 +0200 Peter Rosin wrote: > With bus-type/bus-width properties in the endpoint nodes, the video- > interface of the connection can be specified for cases where the > heuristic fails to select the correct output mode. This can happen > e.g. if not all RGB pin

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-12 Thread Boris Brezillon
On Wed, 11 Apr 2018 11:12:24 +0200 Ladislav Michl wrote: > On Wed, Apr 11, 2018 at 10:52:01AM +0200, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 10:27:46 +0200 > > Ladislav Michl wrote: > > > > > On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon w

Re: [PATCH] drm/vc4: Fix leak of the file_priv that stored the perfmon.

2018-04-12 Thread Boris Brezillon
On Mon, 9 Apr 2018 13:58:13 -0700 Eric Anholt wrote: > Signed-off-by: Eric Anholt > Fixes: 65101d8c9108 ("drm/vc4: Expose performance counters to userspace") Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_drv.c | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 17:10:43 +0200 Peter Rosin wrote: > On 2018-04-11 16:59, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 16:44:10 +0200 > > Peter Rosin wrote: > > > >> Hi Nicolas, > >> > >> Boris asked for your input on this (the datasheet d

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 16:44:10 +0200 Peter Rosin wrote: > Hi Nicolas, > > Boris asked for your input on this (the datasheet difference appears to > have no bearing on the issue) elsewhere in the tree of messages. It's > now been a week or so and I'm starting to wonder if you missed this > altogeth

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 10:27:46 +0200 Ladislav Michl wrote: > On Wed, Apr 11, 2018 at 10:08:06AM +0200, Boris Brezillon wrote: > > On Wed, 11 Apr 2018 09:36:56 +0200 > > Ladislav Michl wrote: > > > > > Hi Boris, > > > > > > On Wed, Apr 11,

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
On Wed, 11 Apr 2018 09:36:56 +0200 Ladislav Michl wrote: > Hi Boris, > > On Wed, Apr 11, 2018 at 09:15:28AM +0200, Boris Brezillon wrote: > > Hi Ladislav, > > > > On Wed, 11 Apr 2018 08:26:07 +0200 > > Ladislav Michl wrote: > > > > > Hi And

Re: [Letux-kernel] [Bug]: mtd: onenand: omap2plus: kernel panic with OneNAND on OMAP3 (DM3730) device GTA04A5

2018-04-11 Thread Boris Brezillon
Hi Ladislav, On Wed, 11 Apr 2018 08:26:07 +0200 Ladislav Michl wrote: > Hi Andreas, > > On Wed, Apr 11, 2018 at 06:59:03AM +0200, Andreas Kemnade wrote: > > Hi Ladis, > > > > On Tue, 10 Apr 2018 22:56:43 +0200 > > Ladislav Michl wrote: > > > > > Hi Nikolaus, > > > > > > On Tue, Apr 10, 20

Re: [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:49 -0400 Marcin Ziemianowicz wrote: > When a USB device is connected to the USB host port on the SAM9N12 then > you get "-62" error which seems to indicate USB replies from the device > are timing out. Looking around, I saw the USB bus was running at half > sp

Re: [PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-10 Thread Boris Brezillon
Hi Marcin, On Mon, 9 Apr 2018 20:16:21 -0400 Marcin Ziemianowicz wrote: > I noticed that when debugging some USB clocking issue that there weren't > many ways to tell what the state of the USB clocking system was. This > adds a few logging statements to see what the relevant code is trying to >

Re: [PATCH v2 0/2] clk: at91: Added more information logging

2018-04-10 Thread Boris Brezillon
Hi Marcin On Mon, 9 Apr 2018 20:15:51 -0400 Marcin Ziemianowicz wrote: > This is a series of patches which resolves set_rate() for the PLL not > having any effect and therefore the USB Host port not working. Also, a > few messages were added which may be helpful in the future when others > are w

Re: [PATCH 1/9] mtd: nand: qcom: use the ecc strength from device parameter

2018-04-10 Thread Boris Brezillon
On Tue, 10 Apr 2018 09:55:58 +0200 Miquel Raynal wrote: > > Hi Abhishek, > > > > On Tue, 10 Apr 2018 11:39:35 +0530, Abhishek Sahu > > wrote: > > > > > On 2018-04-06 18:01, Miquel Raynal wrote: > > > > Hi Abhishek, > > > > > > > > On Wed, 4 Apr 2018 18:12:17 +0530, Abhishek Sahu > > >

[GIT PULL] mtd: Changes for 4.17

2018-04-06 Thread Boris Brezillon
mtd: ftl: Use DIV_ROUND_UP() Boris Brezillon (23): mtd: Make sure the device supports erase operations in mtd_erase() mtd: nand: Get rid of comments giving the file path inside the file itself mtd: nand: Stop using full path when referring to files placed in the same dir mtd: nand

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

2018-04-04 Thread Boris Brezillon
On Wed, 04 Apr 2018 21:49:26 +0200 Robert Jarzmik wrote: > Ulf Hansson writes: > > > On 2 April 2018 at 16:26, Robert Jarzmik wrote: > >> Hi, > >> > >> This serie is aimed at removing the dmaengine slave compat use, and > >> transfer > >> knowledge of the DMA requestors into architecture co

Re: [patch 6/8] mtd: diskonchip: Allocate rs control per instance

2018-04-04 Thread Boris Brezillon
On Wed, 28 Mar 2018 22:51:44 +0200 Thomas Gleixner wrote: > The reed solomon library is moving the on stack decoder buffers into the rs > control structure. That would break the DoC driver because multiple > instances share the same control structure and can operate in parallel. At > least in the

Re: [patch 5/8] rslib: Split rs control struct

2018-04-04 Thread Boris Brezillon
conflict with my nand/for-4.17 changes (NAND code base has been moved to drivers/mtd/nand/raw). The rest looks good, Acked-by: Boris Brezillon > include/linux/rslib.h | 18 +++-- > lib/reed_solomon/decode_rs.c|1 > lib/reed_solomon/encode_rs.c|1 > lib

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-03 Thread Boris Brezillon
On Tue, 3 Apr 2018 10:14:31 +0200 Peter Rosin wrote: > On 2018-04-03 09:15, Boris Brezillon wrote: > > On Tue, 3 Apr 2018 08:51:10 +0200 > > Peter Rosin wrote: > > > >> On 2018-04-02 22:20, Boris Brezillon wrote: > >>> On Mon, 2 Apr 2018 2

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-03 Thread Boris Brezillon
On Tue, 3 Apr 2018 09:15:22 +0200 Boris Brezillon wrote: > > > > > to > > > > 0 33--3--3---- > > 1 33--3--3---- > > 2 33-- > > 3 -3333--- > > 4 33-- > > 5 3--- > >

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-03 Thread Boris Brezillon
On Tue, 3 Apr 2018 08:11:30 +0200 Peter Rosin wrote: > On 2018-04-02 22:20, Boris Brezillon wrote: > > On Mon, 2 Apr 2018 21:28:43 +0200 > > Boris Brezillon wrote: > > > >> On Mon, 2 Apr 2018 19:59:39 +0200 > >> Peter Rosin wrote: > >>

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-03 Thread Boris Brezillon
On Tue, 3 Apr 2018 08:51:10 +0200 Peter Rosin wrote: > On 2018-04-02 22:20, Boris Brezillon wrote: > > On Mon, 2 Apr 2018 21:28:43 +0200 > > Boris Brezillon wrote: > > > >> On Mon, 2 Apr 2018 19:59:39 +0200 > >> Peter Rosin wrote: > >>

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-02 Thread Boris Brezillon
ly have one plane (in this case, i.e. no cursor, no overlays etc), > would that mean that only one master is used? Yep, it's always using the first one (master 8 on a sama5d3). -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-02 Thread Boris Brezillon
On Mon, 2 Apr 2018 22:20:20 +0200 Boris Brezillon wrote: > > > > > And > > > which DDR slave is the target? 7, 8, 9 or 10? More than one? > > > > This, I don't know. I guess all of them can be used. > > Looks like I was wrong. According t

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-02 Thread Boris Brezillon
On Mon, 2 Apr 2018 21:28:43 +0200 Boris Brezillon wrote: > On Mon, 2 Apr 2018 19:59:39 +0200 > Peter Rosin wrote: > > > On 2018-04-02 14:22, Boris Brezillon wrote: > > > On Thu, 29 Mar 2018 16:27:12 +0200 > > > Peter Rosin wrote: > > > > &g

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-02 Thread Boris Brezillon
On Mon, 2 Apr 2018 19:59:39 +0200 Peter Rosin wrote: > On 2018-04-02 14:22, Boris Brezillon wrote: > > On Thu, 29 Mar 2018 16:27:12 +0200 > > Peter Rosin wrote: > > > >> On 2018-03-29 15:44, Boris Brezillon wrote: > >>> On Thu, 29 Mar 20

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-04-02 Thread Boris Brezillon
On Thu, 29 Mar 2018 16:27:12 +0200 Peter Rosin wrote: > On 2018-03-29 15:44, Boris Brezillon wrote: > > On Thu, 29 Mar 2018 15:37:43 +0200 > > Peter Rosin wrote: > > > >> On 2018-03-29 15:33, Boris Brezillon wrote: > >>> On Thu, 29 Mar 20

Re: [PATCH] mtd: nand: davinci: don't acquire and enable clock

2018-04-02 Thread Boris Brezillon
to err; > + return ret; > } > > switch (info->chip.ecc.mode) { > @@ -838,9 +820,6 @@ static int nand_davinci_probe(struct platform_device > *pdev) > nand_cleanup(&info->chip); > > err: > - clk_disable_unprepare(info-&g

Re: [PATCH] mtd: nand: davinci: don't acquire and enable clock

2018-04-02 Thread Boris Brezillon
t after v4.17-rc1 is out if nobody complains about the change. > it will nice to put this on > an immutable branch others can merge. There is potential cleanup > in drivers/clock and in DaVinci machine code that will depend > on this. Sure, I can do that. -- Boris Brezillo

Re: linux-next: Signed-off-by missing for commits in the spi-nor tree

2018-03-30 Thread Boris Brezillon
put me as the contact until someone takes over (I think Marek, the other spi-nor maintainer, does not have access to the repo yet). -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v4 04/10] dt-bindings: i3c: Document core bindings

2018-03-30 Thread Boris Brezillon
On Fri, 30 Mar 2018 09:55:22 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 30, 2018 at 9:47 AM, Boris Brezillon > wrote: > > A new I3C subsystem has been added and a generic description has been > > created to represent the I3C bus and the

[PATCH v4 01/10] i3c: Add core I3C infrastructure

2018-03-30 Thread Boris Brezillon
us, it's only about handling master requests and generating IBIs. Some of the struct, constant and enum definitions could be shared, but most of the I3C slave framework logic will be different Signed-off-by: Boris Brezillon --- Changes in v3: - Fix locking issues - Explicitly include a bu

[PATCH v4 04/10] dt-bindings: i3c: Document core bindings

2018-03-30 Thread Boris Brezillon
A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon --- Changes in v4: - Clarify the fact that static address == I3C address and dynamic

[PATCH v4 00/10] Add the I3C subsystem

2018-03-30 Thread Boris Brezillon
tchwork.ozlabs.org/project/linux-i2c/list/?series=35687 Boris Brezillon (10): i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg

[PATCH v4 03/10] i3c: Add sysfs ABI spec

2018-03-30 Thread Boris Brezillon
Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-bus-i3c | 95 + 1 file changed, 95 insertions(+) create mode 100644 Documentation/ABI

[PATCH v4 06/10] MAINTAINERS: Add myself as the I3C subsystem maintainer

2018-03-30 Thread Boris Brezillon
Create an entry for the I3C subsystem and mark it as maintained by me. There's no official git repository, patchwork instance, mailing list or website yet, but this will be added after the subsystem has been accepted. Signed-off-by: Boris Brezillon --- MAINTAINERS | 9 + 1 file ch

[PATCH v4 08/10] dt-bindings: i3c: Document Cadence I3C master bindings

2018-03-30 Thread Boris Brezillon
Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon --- Changes in v4: - Fix example to match the new representation --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 44 ++ 1 file changed, 44 insertions(+) create mode 100644 Documentation

[PATCH v4 05/10] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

2018-03-30 Thread Boris Brezillon
The reg property of devices connected to an I3C bus have 3 cells, and filling them manually is not trivial. Provides macros to help doing that. Signed-off-by: Boris Brezillon Reviewed-by: Rob Herring --- include/dt-bindings/i3c/i3c.h | 28 1 file changed, 28

[PATCH v4 07/10] i3c: master: Add driver for Cadence IP

2018-03-30 Thread Boris Brezillon
Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon --- Changes in v4: - Fix potential unsigned integer underflow - Add missing static specific on IBI related functions Changes in v3: - Adjust to match I3C framework changes - Implement support the CMD RESPONSE QUEUE and IBI

[PATCH v4 10/10] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-30 Thread Boris Brezillon
Document the Cadence I3C gpio expander bindings. Signed-off-by: Boris Brezillon --- Changes in v4: - Use GPIO_ and IRQ_TYPE_ macros instead of raw numbers - Fix the unit-address in the example --- .../devicetree/bindings/gpio/gpio-cdns-i3c.txt | 39 ++ 1 file changed, 39

[PATCH v4 02/10] docs: driver-api: Add I3C documentation

2018-03-30 Thread Boris Brezillon
Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon --- Changes in v2: - Moved out of patch "i3c: Add core I3C infrastructure" - Add link to the I3C spec - Move rst files in Documentation/driv

[PATCH v4 09/10] gpio: Add a driver for Cadence I3C GPIO expander

2018-03-30 Thread Boris Brezillon
Add a driver for Cadence I3C GPIO expander. Signed-off-by: Boris Brezillon --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-cdns-i3c.c | 380 +++ 3 files changed, 392 insertions(+) create mode 100644

Re: [PATCH] mtd: Use DIV_ROUND_UP()

2018-03-29 Thread Boris Brezillon
(part->header.BAMOffset), SECTOR_SIZE); > > offset = xfer->Offset + le32_to_cpu(part->header.BAMOffset); > ctl = cpu_to_le32(BLOCK_CONTROL); -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] MAINTAINERS: update maintainers for MTD and SPI NOR subsystems

2018-03-29 Thread Boris Brezillon
gt; mtd > > topcis, I'm off-line almost all the time :( > > > > Sorry guys and thanks for your concern, Marek! :) > That's kinda sad, I'd like to NAK this patch. Yes, it's sad. Anyway, thanks for clarifying the situation. Regards, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-03-29 Thread Boris Brezillon
s DMA or not, no whether it should be enabled on a per-board basis. > associated with a module parameter as well (use_dma,). That's true for the use_dma module param, I didn't add it back when reworking the driver. > > Is it only managed by old DT binding? It is. I'm real

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-03-29 Thread Boris Brezillon
On Thu, 29 Mar 2018 15:37:43 +0200 Peter Rosin wrote: > On 2018-03-29 15:33, Boris Brezillon wrote: > > On Thu, 29 Mar 2018 15:10:54 +0200 > > Peter Rosin wrote: > > > >> On a sama5d31 with a Full-HD dual LVDS panel (132MHz pixel clock) NAND > >>

Re: [PATCH] mtd: nand: raw: atmel: add module param to avoid using dma

2018-03-29 Thread Boris Brezillon
urn ret; > } > > - if (nc->caps->has_dma) { > + if (nc->caps->has_dma && !atmel_nand_avoid_dma) { > dma_cap_mask_t mask; > > dma_cap_zero(mask); -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-28 Thread Boris Brezillon
EV() macros in the bindings doc? > > And if I do, should I use them my example? > > Well, I don't want to see "device@I3C_DEV(...)" for unit-addresses. That wouldn't work anyway. > You can use them for reg property, but it's somewhat pointless to

Re: [PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-03-28 Thread Boris Brezillon
On Wed, 28 Mar 2018 14:22:36 +0200 Daniel Vetter wrote: > On Wed, Mar 28, 2018 at 09:34:54AM +0200, Boris Brezillon wrote: > > Hi Peter, > > > > On Mon, 26 Mar 2018 09:35:02 +0200 > > Peter Rosin wrote: > > > > > I have an sama5d31-based system with

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-28 Thread Boris Brezillon
tic address. */ > > + thermal_sensor: sensor@68,39200144004 { > > + reg = <0x68 0x392 0x144004>; > > + assigned-address = <0xa>; > > + }; > > + > > + /* > > +* I3C device without a static address but requiring resources > > +* described in the DT. > > +*/ > > + sensor@0,39200154004 { > > + reg = <0x0 0x392 0x154004>; > > + clocks = <&clock_provider 0>; > > + }; > > + }; > > + > > -- > > 2.14.1 > > [1]http://www.i2c-bus.org/addressing -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-03-28 Thread Boris Brezillon
h) { > + case 0: /* driver default */ > + case 8: > + case 16: > + case 24: > + break; > + default: > + return -EINVAL; > + } > + > ddev = drm_dev_alloc(&atmel_hlcdc_dc_driver, &pdev->dev); > if (IS_ERR(ddev)) > return PTR_ERR(ddev); -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] mtd: Replace typedef with struct

2018-03-28 Thread Boris Brezillon
in the kernel Note that I'm not saying never, but you have to accept to wait longer for this kind of patches, and more importantly, if you keep sending only coding style patches, we might decide to ignore your contributions at some point. Regards, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-26 Thread Boris Brezillon
On Mon, 26 Mar 2018 12:12:54 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Signed-off-by: Boris Brezillon > > Thanks for your p

Re: [PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-26 Thread Boris Brezillon
Hi Geert, On Mon, 26 Mar 2018 12:17:26 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > Document the Cadence I3C gpio expander bindings. > > > > Signed-off-by: Boris Brezillon > > Thanks

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-26 Thread Boris Brezillon
Hi Geert, On Mon, 26 Mar 2018 12:22:24 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Mar 23, 2018 at 12:00 PM, Boris Brezillon > wrote: > > From: Boris Brezillon > > > > A new I3C subsystem has been added and a generic description has been > >

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-25 Thread Boris Brezillon
closer look and it seems the only user of info->archdata is i2c-core-of.c, so we can even remove the info->archdata field. -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-25 Thread Boris Brezillon
ut any further modification, and leaving info->archdata to NULL has the exact same effect (see [1]). Regards, Boris [1]https://elixir.bootlin.com/linux/v4.16-rc6/source/drivers/i2c/i2c-core-base.c#L711 -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[GIT PULL] mtd: fixes for 4.16-rc7

2018-03-23 Thread Boris Brezillon
16 insertions(+), 26 deletions(-) -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

2018-03-23 Thread Boris Brezillon
On Fri, 23 Mar 2018 12:10:35 +0100 Thomas Petazzoni wrote: > Hello, > > On Fri, 23 Mar 2018 12:00:18 +0100, Boris Brezillon wrote: > > > +Optional properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > &

Re: [PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-23 Thread Boris Brezillon
ot;; > > + i2c-scl-frequency = <10>; > > Another s/frequency/hz/ instance, similar to those reported by Thomas. Will fix it in v4. Thanks, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

[PATCH v3 04/11] i3c: Add sysfs ABI spec

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Document sysfs files/directories/symlinks exposed by the I3C subsystem. Signed-off-by: Boris Brezillon --- Changes in v2: - new patch --- Documentation/ABI/testing/sysfs-bus-i3c | 95 + 1 file changed, 95 insertions(+) create mode 100644

Re: [PATCH v3 00/11] Add the I3C subsystem

2018-03-23 Thread Boris Brezillon
On Fri, 23 Mar 2018 12:00:09 +0100 Boris Brezillon wrote: > This patch series is a proposal for a new I3C [1] subsystem. > > This infrastructure is not complete yet and will be extended over > time. > > There are a few design choices that are worth mentioning because they &g

[PATCH v3 02/11] i3c: Add core I3C infrastructure

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add core infrastructure to support I3C in Linux and document it. This infrastructure is not complete yet and will be extended over time. There are a few design choices that are worth mentioning because they impact the way I3C device drivers can interact with their devices

[PATCH v3 07/11] MAINTAINERS: Add myself as the I3C subsystem maintainer

2018-03-23 Thread Boris Brezillon
Create an entry for the I3C subsystem and mark it as maintained by me. There's no official git repository, patchwork instance, mailing list or website yet, but this will be added after the subsystem has been accepted. Signed-off-by: Boris Brezillon --- MAINTAINERS | 9 + 1 file ch

[PATCH v3 05/11] dt-bindings: i3c: Document core bindings

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon A new I3C subsystem has been added and a generic description has been created to represent the I3C bus and the devices connected on it. Document this generic representation. Signed-off-by: Boris Brezillon --- Changes in v3: - Rename {i2c,i3c}-scl-frequency DT prop into

[PATCH v3 06/11] dt-bindings: i3c: Add macros to help fill I3C/I2C device's reg property

2018-03-23 Thread Boris Brezillon
The reg property of devices connected to an I3C bus have 3 cells, and filling them manually is not trivial. Provides macros to help doing that. Signed-off-by: Boris Brezillon --- include/dt-bindings/i3c/i3c.h | 28 1 file changed, 28 insertions(+) create mode

[PATCH v3 09/11] dt-bindings: i3c: Document Cadence I3C master bindings

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Document Cadence I3C master DT bindings. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/i3c/cdns,i3c-master.txt| 45 ++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/cdns,i3c-master.txt

[PATCH v3 08/11] i3c: master: Add driver for Cadence IP

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add a driver for Cadence I3C master IP. Signed-off-by: Boris Brezillon --- Changes in v3: - Adjust to match I3C framework changes - Implement support the CMD RESPONSE QUEUE and IBI QUEUE added in the latest revision of Cadence master IP - Remove support for HDR modes

[PATCH v3 01/11] i2c: Export of_i2c_get_board_info()

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon I3C busses have to know about all I2C devices connected on the I3C bus to properly initialize the I3C master, and I2C frames can't be sent on the bus until this initialization is done. We can't let the I2C core parse the DT and instantiate I2C devices as p

[PATCH v3 10/11] gpio: Add a driver for Cadence I3C GPIO expander

2018-03-23 Thread Boris Brezillon
Add a driver for Cadence I3C GPIO expander. Signed-off-by: Boris Brezillon --- drivers/gpio/Kconfig | 11 ++ drivers/gpio/Makefile| 1 + drivers/gpio/gpio-cdns-i3c.c | 380 +++ 3 files changed, 392 insertions(+) create mode 100644

[PATCH v3 11/11] dt-bindings: gpio: Add bindings for Cadence I3C gpio expander

2018-03-23 Thread Boris Brezillon
Document the Cadence I3C gpio expander bindings. Signed-off-by: Boris Brezillon --- .../devicetree/bindings/gpio/gpio-cdns-i3c.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-cdns-i3c.txt diff --git a

[PATCH v3 03/11] docs: driver-api: Add I3C documentation

2018-03-23 Thread Boris Brezillon
From: Boris Brezillon Add the I3C documentation describing the protocol, the master driver API and the device driver API. Signed-off-by: Boris Brezillon --- Changes in v2: - Moved out of patch "i3c: Add core I3C infrastructure" - Add link to the I3C spec - Move rst files in Doc

[PATCH v3 00/11] Add the I3C subsystem

2018-03-23 Thread Boris Brezillon
, this way maybe I'll have reviews on the doc itself :-). Thanks, Boris Boris Brezillon (11): i2c: Export of_i2c_get_board_info() i3c: Add core I3C infrastructure docs: driver-api: Add I3C documentation i3c: Add sysfs ABI spec dt-bindings: i3c: Document core bindings dt-bi

<    8   9   10   11   12   13   14   15   16   17   >