On Wed, 25 Jul 2018 16:56:28 +0200
Miquel Raynal wrote:
> Mails to wenyou.y...@microchip.com are not deliverable.
> Drop him as Microchip/Atmel NAND controller driver maintainer.
>
> Signed-off-by: Miquel Raynal
Acked-by: Boris Brezillon
> ---
> MAINTAINERS | 1 -
&g
On Wed, 25 Jul 2018 16:56:28 +0200
Miquel Raynal wrote:
> Mails to wenyou.y...@microchip.com are not deliverable.
> Drop him as Microchip/Atmel NAND controller driver maintainer.
>
> Signed-off-by: Miquel Raynal
Acked-by: Boris Brezillon
> ---
> MAINTAINERS | 1 -
&g
On Wed, 25 Jul 2018 18:42:44 +0900
Masahiro Yamada wrote:
>
> You need to remove kfree(denali->buf)
> from denali_remove(), right?
Absolutely.
>
> void denali_remove(struct denali_nand_info *denali)
> {
> struct mtd_info *mtd = nand_to_mtd(>nand);
>
> nand_release(mtd);
>
On Wed, 25 Jul 2018 18:42:44 +0900
Masahiro Yamada wrote:
>
> You need to remove kfree(denali->buf)
> from denali_remove(), right?
Absolutely.
>
> void denali_remove(struct denali_nand_info *denali)
> {
> struct mtd_info *mtd = nand_to_mtd(>nand);
>
> nand_release(mtd);
>
On Sat, 21 Jul 2018 18:08:13 +0200
Nicholas Mc Guire wrote:
> wait_for_completion_timeout returns an unsigned long not int. declare a
> suitably type timeout and fix up assignment and check.
>
> Signed-off-by: Nicholas Mc Guire
> Reported-by: Vignesh R
> Fixes: 140623410536 ("mtd: spi-nor:
On Sat, 21 Jul 2018 18:08:13 +0200
Nicholas Mc Guire wrote:
> wait_for_completion_timeout returns an unsigned long not int. declare a
> suitably type timeout and fix up assignment and check.
>
> Signed-off-by: Nicholas Mc Guire
> Reported-by: Vignesh R
> Fixes: 140623410536 ("mtd: spi-nor:
On Tue, 24 Jul 2018 12:52:02 -0700
Brian Norris wrote:
> > > Or even better: put this hack behind a DT flag, so that one has to
> > > admit that their board design is broken before it will even do
> > > anything. Proposal: "linux,badly-designed-flash-reset".
> >
> > I think we can remove the
On Tue, 24 Jul 2018 12:52:02 -0700
Brian Norris wrote:
> > > Or even better: put this hack behind a DT flag, so that one has to
> > > admit that their board design is broken before it will even do
> > > anything. Proposal: "linux,badly-designed-flash-reset".
> >
> > I think we can remove the
defined
> here
> printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n",
> ^
> %08x
>
> Cc: David Woodhouse
> Cc
defined
> here
> printk(KERN_NOTICE "Solution Engine: Flash at 0x%08lx, EPROM at 0x%08lx\n",
> ^
> %08x
>
> Cc: David Woodhouse
> Cc
On Tue, 24 Jul 2018 08:46:33 +1000
NeilBrown wrote:
> On Mon, Jul 23 2018, Brian Norris wrote:
>
> > Hi Boris,
> >
> > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon
> > wrote:
> >> On Mon, 23 Jul 2018 11:13:50 -0700
> >> Brian Norris wrote:
On Tue, 24 Jul 2018 08:46:33 +1000
NeilBrown wrote:
> On Mon, Jul 23 2018, Brian Norris wrote:
>
> > Hi Boris,
> >
> > On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon
> > wrote:
> >> On Mon, 23 Jul 2018 11:13:50 -0700
> >> Brian Norris wrote:
+Neil
On Mon, 23 Jul 2018 15:06:43 -0700
Brian Norris wrote:
> Hi Boris,
>
> On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon
> wrote:
> > On Mon, 23 Jul 2018 11:13:50 -0700
> > Brian Norris wrote:
> >> I noticed this got merged, but I wanted to put my 2 ce
+Neil
On Mon, 23 Jul 2018 15:06:43 -0700
Brian Norris wrote:
> Hi Boris,
>
> On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon
> wrote:
> > On Mon, 23 Jul 2018 11:13:50 -0700
> > Brian Norris wrote:
> >> I noticed this got merged, but I wanted to put my 2 ce
Hi Brian,
On Mon, 23 Jul 2018 11:13:50 -0700
Brian Norris wrote:
> Hello,
>
> I noticed this got merged, but I wanted to put my 2 cents in here:
I wish you had replied to this thread when it was posted (more than
6 months ago). Reverting the patch now implies making some people
unhappy
Hi Brian,
On Mon, 23 Jul 2018 11:13:50 -0700
Brian Norris wrote:
> Hello,
>
> I noticed this got merged, but I wanted to put my 2 cents in here:
I wish you had replied to this thread when it was posted (more than
6 months ago). Reverting the patch now implies making some people
unhappy
On Mon, 23 Jul 2018 18:04:52 +0200
Arnd Bergmann wrote:
> On Mon, Jul 23, 2018 at 5:40 PM, Arnd Bergmann wrote:
> > On Mon, Jul 23, 2018 at 11:41 AM, Boris Brezillon
> > wrote:
> >> On Mon, 23 Jul 2018 11:34:43 +0200
> >> Arnd Bergmann wrote:
> >&g
On Mon, 23 Jul 2018 18:04:52 +0200
Arnd Bergmann wrote:
> On Mon, Jul 23, 2018 at 5:40 PM, Arnd Bergmann wrote:
> > On Mon, Jul 23, 2018 at 11:41 AM, Boris Brezillon
> > wrote:
> >> On Mon, 23 Jul 2018 11:34:43 +0200
> >> Arnd Bergmann wrote:
> >&g
On Mon, 23 Jul 2018 17:40:29 +0200
Arnd Bergmann wrote:
> On Mon, Jul 23, 2018 at 11:41 AM, Boris Brezillon
> wrote:
> > On Mon, 23 Jul 2018 11:34:43 +0200
> > Arnd Bergmann wrote:
> >
> >> On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon
> >>
On Mon, 23 Jul 2018 17:40:29 +0200
Arnd Bergmann wrote:
> On Mon, Jul 23, 2018 at 11:41 AM, Boris Brezillon
> wrote:
> > On Mon, 23 Jul 2018 11:34:43 +0200
> > Arnd Bergmann wrote:
> >
> >> On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon
> >>
On Mon, 23 Jul 2018 11:34:43 +0200
Arnd Bergmann wrote:
> On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon
> wrote:
> > +Arnd, Rob and the DT ML.
> >
> > On Sat, 21 Jul 2018 14:53:47 -0700
> > Randy Dunlap wrote:
> >
> >> On 07/21/2018 01:00
On Mon, 23 Jul 2018 11:34:43 +0200
Arnd Bergmann wrote:
> On Sun, Jul 22, 2018 at 8:29 AM, Boris Brezillon
> wrote:
> > +Arnd, Rob and the DT ML.
> >
> > On Sat, 21 Jul 2018 14:53:47 -0700
> > Randy Dunlap wrote:
> >
> >> On 07/21/2018 01:00
nand/raw/nand_micron.c
> @@ -88,9 +88,9 @@ static int micron_nand_setup_read_retry(struct mtd_info
> *mtd, int retry_mode)
> static int micron_nand_onfi_init(struct nand_chip *chip)
> {
> struct nand_parameters *p = >parameters;
> - struct nand_onfi_vendor_m
nand/raw/nand_micron.c
> @@ -88,9 +88,9 @@ static int micron_nand_setup_read_retry(struct mtd_info
> *mtd, int retry_mode)
> static int micron_nand_onfi_init(struct nand_chip *chip)
> {
> struct nand_parameters *p = >parameters;
> - struct nand_onfi_vendor_m
nand_detect().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/nand_base.c | 52
> +++-
> include/linux/mtd/rawnand.h | 2 +-
> 2 files changed, 42 insertions(+), 12 deletions(-)
>
nand_detect().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/nand_base.c | 52
> +++-
> include/linux/mtd/rawnand.h | 2 +-
> 2 files changed, 42 insertions(+), 12 deletions(-)
>
On Fri, 20 Jul 2018 17:15:25 +0200
Miquel Raynal wrote:
> Both nand_scan_ident() and nand_scan_tail() helpers used to be called
> directly from controller drivers that needed to tweak some ECC-related
> parameters before nand_scan_tail(). This separation prevented dynamic
> allocations during
On Fri, 20 Jul 2018 17:15:25 +0200
Miquel Raynal wrote:
> Both nand_scan_ident() and nand_scan_tail() helpers used to be called
> directly from controller drivers that needed to tweak some ECC-related
> parameters before nand_scan_tail(). This separation prevented dynamic
> allocations during
On Fri, 20 Jul 2018 17:15:24 +0200
Miquel Raynal wrote:
> + chip = >chip;
> + chip->controller = >controller;
> + chip->controller->ops = _nand_controller_ops;
Should be moved next to the controller initialization.
On Fri, 20 Jul 2018 17:15:24 +0200
Miquel Raynal wrote:
> + chip = >chip;
> + chip->controller = >controller;
> + chip->controller->ops = _nand_controller_ops;
Should be moved next to the controller initialization.
On Fri, 20 Jul 2018 17:15:23 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:23 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
ssignment should be moved here [1].
Once fixed you can add
Reviewed-by: Boris Brezillon
[1]https://elixir.bootlin.com/linux/v4.18-rc5/source/drivers/mtd/nand/raw/qcom_nandc.c#L2574
ssignment should be moved here [1].
Once fixed you can add
Reviewed-by: Boris Brezillon
[1]https://elixir.bootlin.com/linux/v4.18-rc5/source/drivers/mtd/nand/raw/qcom_nandc.c#L2574
On Fri, 20 Jul 2018 17:15:21 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:21 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:20 +0200
Miquel Raynal wrote:
> Some driver (eg. docg4) will need to handle themselves the
> identification phase. As part of the migration to use nand_scan()
> everywhere (which will unconditionnaly call nand_scan_ident()), we add
> a condition at the start of
On Fri, 20 Jul 2018 17:15:20 +0200
Miquel Raynal wrote:
> Some driver (eg. docg4) will need to handle themselves the
> identification phase. As part of the migration to use nand_scan()
> everywhere (which will unconditionnaly call nand_scan_ident()), we add
> a condition at the start of
to nand_scan() for passing a flash IDs table) instead of
> both nand_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sm_common.c | 39 +--
> 1 file changed, 25 insertions
to nand_scan() for passing a flash IDs table) instead of
> both nand_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sm_common.c | 39 +--
> 1 file changed, 25 insertions
On Fri, 20 Jul 2018 17:15:18 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:18 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
+Arnd, Rob and the DT ML.
On Sat, 21 Jul 2018 14:53:47 -0700
Randy Dunlap wrote:
> On 07/21/2018 01:00 PM, Anders Roxell wrote:
> > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this
> > error:
> > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> >
+Arnd, Rob and the DT ML.
On Sat, 21 Jul 2018 14:53:47 -0700
Randy Dunlap wrote:
> On 07/21/2018 01:00 PM, Anders Roxell wrote:
> > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this
> > error:
> > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’:
> >
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/vf610_nfc.c | 127
> ---
> 1 file changed, 66 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/vf610_nfc.c | 127
> ---
> 1 file changed, 66 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
On Fri, 20 Jul 2018 17:15:16 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:16 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/txx9ndfmc.c | 29 +++--
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c
>
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/txx9ndfmc.c | 29 +++--
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/txx9ndfmc.c
>
On Fri, 20 Jul 2018 17:15:15 +0200
Miquel Raynal wrote:
> As already done in the core, calling a struct nand_controller
> 'hw_control' is misleading. Use the same name as in nand_base.c:
> 'controller'.
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
&
On Fri, 20 Jul 2018 17:15:15 +0200
Miquel Raynal wrote:
> As already done in the core, calling a struct nand_controller
> 'hw_control' is misleading. Use the same name as in nand_base.c:
> 'controller'.
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
&
int chip_init(struct device *dev, struct
> device_node *np)
> NAND_NO_SUBPAGE_WRITE |
> NAND_WAIT_TCCS;
> chip->controller = >hw;
> + chip->controller->ops = _controller_ops;
Move this assignment here [1]. With t
int chip_init(struct device *dev, struct
> device_node *np)
> NAND_NO_SUBPAGE_WRITE |
> NAND_WAIT_TCCS;
> chip->controller = >hw;
> + chip->controller->ops = _controller_ops;
Move this assignment here [1]. With t
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sunxi_nand.c | 43
> +--
> 1 file changed, 19 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/mtd/nand/ra
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sunxi_nand.c | 43
> +--
> 1 file changed, 19 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/mtd/nand/ra
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sh_flctl.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/sh_flctl.c b/driver
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/sh_flctl.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/sh_flctl.c b/driver
On Fri, 20 Jul 2018 17:15:11 +0200
Miquel Raynal wrote:
> @@ -1007,6 +1007,16 @@ static int flctl_chip_init_tail(struct mtd_info *mtd)
> struct sh_flctl *flctl = mtd_to_flctl(mtd);
> struct nand_chip *chip = >chip;
>
> + if (chip->options & NAND_BUSWIDTH_16) {
> +
On Fri, 20 Jul 2018 17:15:11 +0200
Miquel Raynal wrote:
> @@ -1007,6 +1007,16 @@ static int flctl_chip_init_tail(struct mtd_info *mtd)
> struct sh_flctl *flctl = mtd_to_flctl(mtd);
> struct nand_chip *chip = >chip;
>
> + if (chip->options & NAND_BUSWIDTH_16) {
> +
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/s3c2410.c | 30 +-
> 1 file changed, 13 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drive
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/s3c2410.c | 30 +-
> 1 file changed, 13 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/s3c2410.c b/drive
On Fri, 20 Jul 2018 17:15:09 +0200
Miquel Raynal wrote:
> static int omap_nand_probe(struct platform_device *pdev)
> {
> struct omap_nand_info *info;
> struct mtd_info *mtd;
> struct nand_chip*nand_chip;
> int
On Fri, 20 Jul 2018 17:15:09 +0200
Miquel Raynal wrote:
> static int omap_nand_probe(struct platform_device *pdev)
> {
> struct omap_nand_info *info;
> struct mtd_info *mtd;
> struct nand_chip*nand_chip;
> int
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/nandsim.c | 82
> +++---
> 1 file changed, 45 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/mtd/nand/
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/nandsim.c | 82
> +++---
> 1 file changed, 45 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/mtd/nand/
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/mxc_nand.c | 136
> +---
> 1 file changed, 71 insertions(+), 65 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/mxc_nand.c | 136
> +---
> 1 file changed, 71 insertions(+), 65 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
;
> int i;
> @@ -1287,6 +1328,7 @@ static int mtk_nfc_nand_chip_init(struct device *dev,
> struct mtk_nfc *nfc,
>
> nand = >nand;
> nand->controller = >controller;
> + nand->controller->ops = _nfc_controller_ops;
Just like for the marvell dr
;
> int i;
> @@ -1287,6 +1328,7 @@ static int mtk_nfc_nand_chip_init(struct device *dev,
> struct mtk_nfc *nfc,
>
> nand = >nand;
> nand->controller = >controller;
> + nand->controller->ops = _nfc_controller_ops;
Just like for the marvell dr
can add
Reviewed-by: Boris Brezillon
> + ret = nand_scan(mtd, marvell_nand->nsels);
> if (ret) {
> - dev_err(dev, "nand_scan_tail failed: %d\n", ret);
> + dev_err(dev, "could not scan the nand chip\n");
> return ret;
> }
>
can add
Reviewed-by: Boris Brezillon
> + ret = nand_scan(mtd, marvell_nand->nsels);
> if (ret) {
> - dev_err(dev, "nand_scan_tail failed: %d\n", ret);
> + dev_err(dev, "could not scan the nand chip\n");
> return ret;
> }
>
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/lpc32xx_slc.c | 77
> +-
> 1 file changed, 42 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/lpc32xx_slc.c | 77
> +-
> 1 file changed, 42 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw
On Fri, 20 Jul 2018 17:15:03 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:15:03 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
> Acked-by: Harvey Hunt
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/jz4780_nand.c | 34 --
> 1 file changed, 16 insertions(+), 18 deletions(-)
>
> diff --git a/dri
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
> Acked-by: Harvey Hunt
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/jz4780_nand.c | 34 --
> 1 file changed, 16 insertions(+), 18 deletions(-)
>
> diff --git a/dri
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/hisi504_nand.c | 78
> +
> 1 file changed, 44 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/hisi504_nand.c | 78
> +
> 1 file changed, 44 insertions(+), 34 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 56
> ++
> 1 file changed, 33 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/mtd/nand/ra
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 56
> ++
> 1 file changed, 33 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/mtd/nand/ra
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/fsmc_nand.c | 148
> +--
> 1 file changed, 78 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/fsmc_nand.c | 148
> +--
> 1 file changed, 78 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/mtd/nand/r
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/fsl_ifc_nand.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c
> b
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/fsl_ifc_nand.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/nand/raw/fsl_ifc_nand.c
> b
_mtd *priv = nand_get_controller_data(chip);
> struct fsl_lbc_ctrl *ctrl = priv->ctrl;
> struct fsl_lbc_regs __iomem *lbc = ctrl->regs;
> @@ -706,6 +706,10 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
Looks like fsl_elbc_chip_init_tail() was retur
_mtd *priv = nand_get_controller_data(chip);
> struct fsl_lbc_ctrl *ctrl = priv->ctrl;
> struct fsl_lbc_regs __iomem *lbc = ctrl->regs;
> @@ -706,6 +706,10 @@ static int fsl_elbc_chip_init_tail(struct mtd_info *mtd)
Looks like fsl_elbc_chip_init_tail() was retur
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/denali.c | 138
> +++---
> 1 file changed, 77 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/mtd/nand
d_scan_ident() and nand_scan_tail().
>
> Signed-off-by: Miquel Raynal
Reviewed-by: Boris Brezillon
> ---
> drivers/mtd/nand/raw/denali.c | 138
> +++---
> 1 file changed, 77 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/mtd/nand
use to get
a platform_device object from a device one, so this change was not
really needed. Actually, you should not even need a ->dev field here
because it can be retrieved from mtd->dev.parent. Anyway, if you
patched all places using davinci->dev to now use >pdev->dev
we should be good.
use to get
a platform_device object from a device one, so this change was not
really needed. Actually, you should not even need a ->dev field here
because it can be retrieved from mtd->dev.parent. Anyway, if you
patched all places using davinci->dev to now use >pdev->dev
we should be good.
On Fri, 20 Jul 2018 17:14:54 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:14:54 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:14:53 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
On Fri, 20 Jul 2018 17:14:53 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and
Janusz,
On Fri, 20 Jul 2018 20:38:15 +0200
Janusz Krzysztofik wrote:
> On Thursday, July 19, 2018 8:47:49 AM CEST Boris Brezillon wrote:
> > On Thu, 19 Jul 2018 01:57:10 +0200
> > Janusz Krzysztofik wrote:
> >
> > > Don't readw()/writew() data directly fr
Janusz,
On Fri, 20 Jul 2018 20:38:15 +0200
Janusz Krzysztofik wrote:
> On Thursday, July 19, 2018 8:47:49 AM CEST Boris Brezillon wrote:
> > On Thu, 19 Jul 2018 01:57:10 +0200
> > Janusz Krzysztofik wrote:
> >
> > > Don't readw()/writew() data directly fr
On Fri, 20 Jul 2018 20:14:55 +0200
Janusz Krzysztofik wrote:
> On Thursday, July 19, 2018 8:25:38 AM CEST Boris Brezillon wrote:
> > On Thu, 19 Jul 2018 01:57:06 +0200
> > Janusz Krzysztofik wrote:
> >
> > > Further optimize processing speed of
On Fri, 20 Jul 2018 20:14:55 +0200
Janusz Krzysztofik wrote:
> On Thursday, July 19, 2018 8:25:38 AM CEST Boris Brezillon wrote:
> > On Thu, 19 Jul 2018 01:57:06 +0200
> > Janusz Krzysztofik wrote:
> >
> > > Further optimize processing speed of
1201 - 1300 of 10969 matches
Mail list logo
