Re: [PATCH] Fix writing mtdoops to nand flash.

2017-10-30 Thread Brent Taylor
es, will fix. > > On Sun, 29 Oct 2017 23:23:43 -0500 > moto...@gmail.com wrote: > >> From: Brent Taylor <moto...@gmail.com> >> >> When mtdoops calls mtd_panic_write, it eventually calls >> panic_nand_write in nand_base.c. In order to properly >>

Re: [PATCH] Fix writing mtdoops to nand flash.

2017-10-30 Thread Brent Taylor
23:23:43 -0500 > moto...@gmail.com wrote: > >> From: Brent Taylor >> >> When mtdoops calls mtd_panic_write, it eventually calls >> panic_nand_write in nand_base.c. In order to properly >> wait for the nand chip to be ready in panic_nand_wait, >> the chi

Build error in timer-atmel-pit.c

2016-08-28 Thread Brent Taylor
= clk_prepare_enable(data->mck); ^~~ linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in This was introduced in commit: 699e36e5b8e9f77b2be4c23f0b309e53be4b2880 Regards, Brent Taylor

Build error in timer-atmel-pit.c

2016-08-28 Thread Brent Taylor
= clk_prepare_enable(data->mck); ^~~ linux-x.yy/drivers/clocksource/timer-atmel-pit.c:264:2: note: each undeclared identifier is reported only once for each function it appears in This was introduced in commit: 699e36e5b8e9f77b2be4c23f0b309e53be4b2880 Regards, Brent Taylor

at_xdmac: txd used outside spinlock after being released?

2016-07-19 Thread Brent Taylor
fter dma_run_dependencies(txd), but a deadlock will be introduced because dma_run_dependencies could invoke at_xdmac_issue_pending which could eventually call spin_lock_irqsave(>lock). A deadlock could also be created if the "callback" function invoked another "device_prep_*" function. If I'm miss-understanding something, I apologize for the noise. -- Brent Taylor

at_xdmac: txd used outside spinlock after being released?

2016-07-19 Thread Brent Taylor
fter dma_run_dependencies(txd), but a deadlock will be introduced because dma_run_dependencies could invoke at_xdmac_issue_pending which could eventually call spin_lock_irqsave(>lock). A deadlock could also be created if the "callback" function invoked another "device_prep_*" function. If I'm miss-understanding something, I apologize for the noise. -- Brent Taylor

[PATCH] mmc: atmel-mci: Check pdata for NULL before dereferencing it

2016-03-12 Thread Brent Taylor
607b62d4422f7087 ]--- This occurs because the "host->pdev->dev.patform_data" is NULL because I'm using a device tree to setup all the devices. This patch checks pdata before dereferencing it. Signed-off-by: Brent Taylor gmail.com> --- a/drivers/mmc/host/atmel-mci.c2016-03-13

[PATCH] mmc: atmel-mci: Check pdata for NULL before dereferencing it

2016-03-12 Thread Brent Taylor
607b62d4422f7087 ]--- This occurs because the "host->pdev->dev.patform_data" is NULL because I'm using a device tree to setup all the devices. This patch checks pdata before dereferencing it. Signed-off-by: Brent Taylor gmail.com> --- a/drivers/mmc/host/atmel-mci.c2016-03-13

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Brent Taylor
On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder wrote: > Hi Brent, > > On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor wrote: >> Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to >> be pointing to memory allocated by vmalloc.

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-21 Thread Brent Taylor
On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.li...@gmail.com> wrote: > Hi Brent, > > On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <moto...@gmail.com> wrote: >> Since commit 8437754c83351d6213c1a47ff029c1126d6042a7, ar->fw is expected to >> be poi

[v2] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-01 Thread Brent Taylor
are being loaded is the 'fw' image, then use vmalloc, otherwise use kmalloc. Signed-off-by: Brent Taylor --- v2: Fix commit message and code formatting (use tab instaed of spaces) drivers/net/wireless/ath/ath6kl/init.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/driv

[v2] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-12-01 Thread Brent Taylor
are being loaded is the 'fw' image, then use vmalloc, otherwise use kmalloc. Signed-off-by: Brent Taylor <moto...@gmail.com> --- v2: Fix commit message and code formatting (use tab instaed of spaces) drivers/net/wireless/ath/ath6kl/init.c | 7 ++- 1 file changed, 6 insertions(+), 1 d

[PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-11-30 Thread Brent Taylor
image, then use vmalloc, otherwise use kmalloc. Signed-off-by: Brent Taylor --- drivers/net/wireless/ath/ath6kl/init.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6ae0734..4f

[PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

2015-11-30 Thread Brent Taylor
image, then use vmalloc, otherwise use kmalloc. Signed-off-by: Brent Taylor <moto...@gmail.com> --- drivers/net/wireless/ath/ath6kl/init.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/

[PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-28 Thread Brent Taylor
Signed-off-by: Brent Taylor ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree ath6kl: fix kmalloc build error --- Changes v2 -> v3: - fix kmalloc build error Changes v1 -> v2: - simplify memory allocation - use kvfree drivers/net/wireless/ath/

[PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-28 Thread Brent Taylor
Signed-off-by: Brent Taylor ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree --- Changes v1 -> v2: - simplify memory allocation - use kvfree drivers/net/wireless/ath/ath6kl/core.c | 2 +- drivers/net/wireless/ath/ath6kl/init.c | 7 ++- 2 files chan

Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

2015-11-28 Thread Brent Taylor
Sorry, the first e-mail was sent via gmail and I forgot about sending it in plain text mode. Whats the status on this patch? I don't see it on patchwork anymore nor is it in any of the git trees I checked. Thanks, Brent On Fri, Oct 16, 2015 at 12:10 AM, Brent Taylor wrote: > Signed-

Re: [PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

2015-11-28 Thread Brent Taylor
Sorry, the first e-mail was sent via gmail and I forgot about sending it in plain text mode. Whats the status on this patch? I don't see it on patchwork anymore nor is it in any of the git trees I checked. Thanks, Brent On Fri, Oct 16, 2015 at 12:10 AM, Brent Taylor <moto...@gmail.com>

[PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-28 Thread Brent Taylor
Signed-off-by: Brent Taylor <moto...@gmail.com> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree --- Changes v1 -> v2: - simplify memory allocation - use kvfree drivers/net/wireless/ath/ath6kl/core.c | 2 +- drivers/net/wireless/ath/ath6kl/i

[PATCH v3] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

2015-11-28 Thread Brent Taylor
Signed-off-by: Brent Taylor <moto...@gmail.com> ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree ath6kl: fix kmalloc build error --- Changes v2 -> v3: - fix kmalloc build error Changes v1 -> v2: - simplify memory allocation - use kvfree

[PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

2015-10-15 Thread Brent Taylor
Signed-off-by: Brent Taylor --- drivers/net/wireless/ath/ath6kl/init.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6e473fa..2155739 100644 --- a/drivers/net/wireless

[PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

2015-10-15 Thread Brent Taylor
Signed-off-by: Brent Taylor <moto...@gmail.com> --- drivers/net/wireless/ath/ath6kl/init.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6e473fa..2155739

Re: lz4hc compression in UBIFS?

2013-10-23 Thread Brent Taylor
On Wed, Oct 23, 2013 at 2:40 AM, Konstantin Tokarev wrote: > > > 23.10.2013, 09:26, "Brent Taylor" : >> Konstantin, >>I did my testing with data from /dev/urandom (which I now realize >> wasn't the best choice of data source), but if I use /dev/zero (whic

Re: lz4hc compression in UBIFS?

2013-10-23 Thread Brent Taylor
On Wed, Oct 23, 2013 at 2:40 AM, Konstantin Tokarev annu...@yandex.ru wrote: 23.10.2013, 09:26, Brent Taylor moto...@gmail.com: Konstantin, I did my testing with data from /dev/urandom (which I now realize wasn't the best choice of data source), but if I use /dev/zero (which actually

Re: lz4hc compression in UBIFS?

2013-10-22 Thread Brent Taylor
13, 07:43, "Brent Taylor" : >> On Mon, Oct 21, 2013 at 10:59 AM, Konstantin Tokarev >> wrote: >> >>> 04.10.2013, 07:09, "Brent Taylor" : >>>> Here is a patch based on linux-3.12-rc3. I haven't performed any >>>> performance tes

Re: lz4hc compression in UBIFS?

2013-10-22 Thread Brent Taylor
: 22.10.2013, 07:43, Brent Taylor moto...@gmail.com: On Mon, Oct 21, 2013 at 10:59 AM, Konstantin Tokarev annu...@yandex.ru wrote: 04.10.2013, 07:09, Brent Taylor moto...@gmail.com: Here is a patch based on linux-3.12-rc3. I haven't performed any performance testing UBIFS using lz4hc, but I can