Re: [PATCH] staging: android: binder.c: binder_ioctl() cleanup

2014-06-03 Thread Brian Swetland
Arve's probably the best person to loop in on binder driver patches (considering he wrote it). Brian On Tue, Jun 3, 2014 at 12:27 PM, Tair Rzayev wrote: > binder_ioctl() is quite huge and checkpatch dirty - mostly because of > the amount of code for the BINDER_WRITE_READ and BINDER_SET_CONTEXT_M

Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-02 Thread Brian Swetland
in an Android system? > >> +module_exit(logger_exit); >> +MODULE_LICENSE("GPL"); >> +MODULE_AUTHOR("Brian Swetland, "); >> +MODULE_DESCRIPTION("Android Logger"); >> + >> + > > What's with the unneeded trailing empty lines?

Re: [PATCH v4 0/12] KGDB/KDB FIQ (NMI) debugger

2012-08-20 Thread Brian Swetland
On Mon, Aug 20, 2012 at 7:44 AM, Anton Vorontsov wrote: > > - KGDB/KDB FIQ debugger shell is synchronous. In Google's version you > could have a dedicated shell always running in the FIQ context, so > when you type something on a serial line, you won't actually cause any > debugging actions,