On Fri, Dec 22, 2017 at 09:29:15AM +, Reshetova, Elena wrote:
>
> On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote:
> > atomic_t variables are currently used to implement reference
> > counters with the following properties:
> > - counter is initialized to 1 using atomic_set()
On Wed, Nov 29, 2017 at 01:15:43PM +0200, Elena Reshetova wrote:
> atomic_t variables are currently used to implement reference
> counters with the following properties:
> - counter is initialized to 1 using atomic_set()
> - a resource is freed upon counter reaching zero
> - once counter reaches
On Tue, Dec 05, 2017 at 07:11:00AM +1100, NeilBrown wrote:
> On Mon, Dec 04 2017, Thiago Rafael Becker wrote:
>
> > On Mon, 4 Dec 2017, NeilBrown wrote:
> >
> >> I think you need to add groups_sort() in a few more places.
> >> Almost anywhere that calls groups_alloc() should be considered.
> >> ne
On Mon, Dec 18, 2017 at 12:22:20PM -0500, Jeff Layton wrote:
> On Mon, 2017-12-18 at 17:34 +0100, Jan Kara wrote:
> > On Mon 18-12-17 10:11:56, Jeff Layton wrote:
> > > static inline bool
> > > inode_maybe_inc_iversion(struct inode *inode, bool force)
> > > {
> > > - atomic64_t *ivp = (atomic64_
On Mon, Dec 18, 2017 at 06:17:36PM +0100, Mike Galbraith wrote:
> On Mon, 2017-12-18 at 18:00 +0100, Mike Galbraith wrote:
> > On Mon, 2017-12-18 at 11:35 -0500, J. Bruce Fields wrote:
> > >
> > > Like I say, I don't really understand the issues here, so it
On Mon, Dec 18, 2017 at 04:31:52PM +0100, Mike Galbraith wrote:
> On Mon, 2017-12-18 at 16:17 +0100, Mike Galbraith wrote:
> >
> >
> > kworker/-74210.N.. 82893us : nfs_release_request
> > <-nfs_commit_release_pages
> > kworker/-74210.N.. 82893us : nfs_unlock_and_release_request
> >
On Fri, Dec 15, 2017 at 10:15:29AM -0500, Jeff Layton wrote:
> On Thu, 2017-12-14 at 10:14 -0500, J. Bruce Fields wrote:
> > On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote:
> > > There is some clear peformance impact when you are running frequent
> > &g
On Thu, Dec 14, 2017 at 09:14:47AM -0500, Jeff Layton wrote:
> On Wed, 2017-12-13 at 19:02 -0500, Jeff Layton wrote:
> > On Thu, 2017-12-14 at 10:03 +1100, Dave Chinner wrote:
> > > On Wed, Dec 13, 2017 at 03:14:28PM -0500, Jeff Layton wrote:
> > > > On Wed, 2017-
This is great, thanks.
On Wed, Dec 13, 2017 at 09:19:58AM -0500, Jeff Layton wrote:
> With this, we reduce inode metadata updates across all 3 filesystems
> down to roughly the frequency of the timestamp granularity, particularly
> when it's not being queried (the vastly common case).
>
> The pes
ACK. (Assuming somebody else takes it--Andrew? Al? Or I can take it
through the nfsd tree. I'm not sure who owns the stuff under kernel/.)
--b.
On Mon, Dec 11, 2017 at 01:14:20PM -0200, Thiago Rafael Becker wrote:
> In testing, we found that nfsd threads may call set_groups in parallel for
>
On Mon, Dec 11, 2017 at 05:04:05PM +1100, NeilBrown wrote:
> 1/ Always return the mnt_id, even if some other error occurs.
>It can be useful without the file handle.
>An application can initialise the memory to, e.g. -1
>and if there is some other value after name_to_handle_at()
>re
ACK to these patches from me. I'm not sure who should pick them up
--b.
On Tue, Dec 05, 2017 at 12:05:09PM -0200, Thiago Rafael Becker wrote:
> In cases where group_info is cached (e.g. sunrpc), multiplpe
> threads may call set_groups with a freshly created group_info
> cache (e.g. nfsd), an
On Fri, Dec 01, 2017 at 07:56:38AM +1100, NeilBrown wrote:
>
> Amazon EFS provides an NFSv4.1 filesystem which appears to use
> (close to) full length (128 byte) file handles.
I wonder why?
Anyway, it seems unfortunate that systemd should need to worry about
filehandle sizes at all, given that
On Mon, Dec 04, 2017 at 01:39:37PM -0200, Thiago Rafael Becker wrote:
>
>
> On Mon, 4 Dec 2017, NeilBrown wrote:
>
> >I think you need to add groups_sort() in a few more places.
> >Almost anywhere that calls groups_alloc() should be considered.
> >net/sunrpc/svcauth_unix.c, net/sunrpc/auth_gss/s
Thanks, applying all four for 4.16.--b.
On Wed, Nov 29, 2017 at 01:15:42PM +0200, Elena Reshetova wrote:
> This series, for lockd component, replaces atomic_t reference
> counters with the new refcount_t type and API (see include/linux/refcount.h).
> By doing this we prevent intentional or acciden
Please pull nfsd fixes for 4.15 from:
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.15-1
I screwed up my merge window pull request; I only sent half of what I
meant to.
There were no new features, just bugfixes of various importance and some
very minor cleanup, so I think it's all still a
I'm sorry for this mail to disturbing you.
It's just a test mail.
Bruce
The information transmitted in this e-mail is intended only for the addressee
and may contain confidential and/or privileged material. Any review,
retransmission, dissemination or other use of this information by
On Tue, Nov 28, 2017 at 09:52:56AM +1100, Stephen Rothwell wrote:
> Hi Bruce,
>
> Commit
>
> 64ebe12494fd ("nfsd: fix panic in posix_unblock_lock called from
> nfs4_laundromat")
>
> is missing a Signed-off-by from its author.
Previously:
http://lk
On Sun, Nov 19, 2017 at 12:03:45PM -0500, Chuck Lever wrote:
>
> > On Nov 18, 2017, at 2:40 PM, Linus Torvalds
> > wrote:
> >
> > On Sat, Nov 18, 2017 at 10:40 AM, J. Bruce Fields
> > wrote:
> >> Please pull nfsd changes for 4.15 from:
> >
from atomic_t to refcount_t
J. Bruce Fields (6):
nfsd: remove unnecessary nofilehandle checks
nfsd: increase DRC cache limit
nfsd: give out fewer session slots as limit approaches
nfsd4: fix cached replies to solo SEQUENCE compounds
nfsd4: catch some false session re
On Tue, Nov 14, 2017 at 07:48:18PM +0300, Vitaly Lipatov wrote:
> for fcntl64 with F_GETLK64 we need use checking against COMPAT_LOFF_T_MAX.
>
> Fixes: 94073ad77fff2 "fs/locks: don't mess with the address limit in
> compat_fcntl64"
>
> Signed-off-by: Vitaly Lipatov
> ---
> fs/fcntl.c | 14
On Fri, Nov 10, 2017 at 03:26:27PM -0800, Patrick McLean wrote:
>
>
> On 2017-11-10 10:42 AM, Linus Torvalds wrote:
> > On Thu, Nov 9, 2017 at 5:58 PM, Patrick McLean wrote:
> >>
> >> Something must have changed since 4.13.8 to trigger this though.
> >
> > Arnd pointed to some commits that migh
On Fri, Nov 10, 2017 at 10:09:46AM -0500, Anna Schumaker wrote:
>
>
> On 11/09/2017 09:21 PM, J. Bruce Fields wrote:
> > On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote:
> >> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote:
> >>> Make t
On Tue, Oct 17, 2017 at 12:40:27PM -0400, Jeff Layton wrote:
> On Tue, 2017-10-17 at 18:14 +0200, Bhumika Goyal wrote:
> > Make the function argument as const. After thing change, make
> > the cache_detail structures as const.
> >
> > Bhumika Goyal (4):
> > sunrpc: make the function arg as const
rticular, there are *no* nfsd changes in that 4.13.8..4.13.11
> range. There is a bunch of xfs changes, though. What's the underlying
> filesystem that you are exporting?
>
> But bringing in Al Viro and Bruce Fields explicitly in case they see
> something. And Darrick, just in
On Fri, Nov 10, 2017 at 06:51:35AM +1100, Stephen Rothwell wrote:
> Hi,
>
> Commit
>
> 988e4fd55729 ("nfsd: fix panic in posix_unblock_lock called from
> nfs4_laundromat")
>
> is missing a Signed-off-by from its author.
It fixes a typo in two lines in pretty much the only way possible, so
th
On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote:
> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be
> protected by nlm_host_mutex.
I haven't looked at the NLM locking in ages. Do we know who else might
actually be accessing this list concurrently?
--b.
>
>
On Tue, Oct 24, 2017 at 02:18:52PM -0400, Jeff Layton wrote:
> On Tue, 2017-10-24 at 13:53 -0400, J. Bruce Fields wrote:
> > On Tue, Oct 24, 2017 at 01:26:49PM -0400, Weston Andros Adamson wrote:
> > > Is there a reason to BUG() in these places? Couldn't we WARN_ON_ONCE and
ly. (Except for that read_u32... return, I
wonder if we're missing a check there.)
--b.
>
> -dros
>
> > On Oct 23, 2017, at 4:31 PM, J. Bruce Fields wrote:
> >
> > In the past we've avoided BUG_ON(X) where X might have side effects, on
> > the theo
In the past we've avoided BUG_ON(X) where X might have side effects, on
the theory that it should actually be OK just to compile out BUG_ON()s.
Has that changed?
In any case, I don't find that this improves readability; dropping.
--b.
On Mon, Oct 23, 2017 at 01:16:35PM -0500, Gustavo A. R. Silva
On Thu, Oct 19, 2017 at 01:04:35PM +0200, Arnd Bergmann wrote:
> On Thu, Oct 19, 2017 at 12:54 PM, Jeff Layton wrote:
> >
> > I wonder if we'd be better off just using nfssvc_boot.tv_sec as the
> > verifier? I don't see us ever calling that ktime_get_real_ts64 more than
> > once per second for thi
On Fri, Oct 20, 2017 at 12:53:27PM +0300, Elena Reshetova wrote:
> This series, for nfs components, replaces atomic_t reference
> counters with the new refcount_t type and API (see include/linux/refcount.h).
> By doing this we prevent intentional or accidental
> underflows or overflows that can led
Thanks, applying for 3.15 with a stable cc.
--b.
On Fri, Oct 20, 2017 at 01:03:37PM -0400, Jeff Layton wrote:
> On Fri, 2017-10-20 at 17:33 +0300, Vasily Averin wrote:
> > v2: reported to stable@ because it fixes backported patch.
> >
> > lockd_up() can call lockd_unregister_notifiers twice:
> >
Thanks, applied for 4.15.--b.
On Mon, Oct 16, 2017 at 02:40:21PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The function _svc_create_xprt is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol '_svc_create_xprt' was n
On Wed, Oct 11, 2017 at 10:47:43AM +0100, David Howells wrote:
> J. Bruce Fields wrote:
>
> > Does that mean nobody's tested fcntl locking over afs since that change in
> > 2010?
>
> Quite feasibly not. I've been beating kAFS into shape and I'm aware
On Tue, Oct 10, 2017 at 11:42:01AM -0700, Linus Torvalds wrote:
> On Tue, Oct 10, 2017 at 11:24 AM, J. Bruce Fields
> wrote:
> > Please pull nfsd fixes from
> >
> > git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.14-1
>
> There's nothing there. That ta
Please pull nfsd fixes from
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.14-1
One fix for a 4.14 regression, and one minor fix to the MAINTAINERs
file. (I was weirdly flattered by the idea that lots of random people
suddenly seemed to think Jeff and I were VFS experts. Turns out it was
j
On Sat, Oct 07, 2017 at 06:36:57AM -0400, Jeff Layton wrote:
> On Sat, 2017-10-07 at 17:55 +0800, Jia-Ju Bai wrote:
> > The kernel may sleep under a spinlock, and the function call paths are:
> > afs_do_unlk (acquire the spinlock)
> > posix_lock_file
> > posix_lock_inode (fs/locks.c)
> >
On Fri, Oct 06, 2017 at 01:09:42PM +1100, Dave Chinner wrote:
> On Thu, Oct 05, 2017 at 12:16:19PM -0400, J. Bruce Fields wrote:
> > This kind of restriction sounds more like a permanent feature of the
> > filesystem--something you'd set at mkfs time.
> >
> >
On Mon, Oct 02, 2017 at 09:33:12PM -0400, Jérémy Lefaure wrote:
> On Mon, 2 Oct 2017 15:22:24 -0400
> bfie...@fieldses.org (J. Bruce Fields) wrote:
>
> > Mainly I'd just like to know which you're asking for. Do you want me to
> > apply this, or to ACK it so someo
On Tue, Oct 03, 2017 at 02:58:52PM -0400, Theodore Ts'o wrote:
> The argument for making it be configurable is that if it does break
> things in way we can't foresee, it's a lot easier to back it out. And
> like what we've done with relatime, if the distro's all run with it as
> the default for a
On Mon, Oct 02, 2017 at 07:35:54AM +0200, Greg KH wrote:
> On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote:
> > On Mon, 2 Oct 2017 09:01:31 +1100
> > "Tobin C. Harding" wrote:
> >
> > > > In order to reduce the size of the To: and Cc: lines, each patch of the
> > > > series is sent
On Tue, Sep 26, 2017 at 05:52:16PM -0400, J. Bruce Fields wrote:
> On Sun, Sep 24, 2017 at 12:59:40PM -0400, Meng Xu wrote:
> > cld_pipe_downcall() has two fetches from an overapped userspace memory.
> > The first fetch copy_from_user(&xid, &cmsg->cm_xid, sizeof(xid)) g
On Sun, Sep 24, 2017 at 12:59:40PM -0400, Meng Xu wrote:
> cld_pipe_downcall() has two fetches from an overapped userspace memory.
> The first fetch copy_from_user(&xid, &cmsg->cm_xid, sizeof(xid)) get
> the xid and use xid to lookup the parent struct cld_upcall *cup.
> The second fetch copy_from_u
On Tue, Sep 26, 2017 at 07:15:09AM -0400, Jeff Layton wrote:
> On Tue, 2017-09-26 at 09:14 +0200, Corentin Labbe wrote:
> > Hello
> >
> > The origin of this series is a build warning fix.
> > But reading the code show me two other possible patch.
> >
> > Regards
> >
> > Corentin Labbe (3):
> >
core: Add rdma_rw_mr_payload()
svcrdma: Estimate Send Queue depth properly
J. Bruce Fields (6):
nfsd4: move some nfsd4 op definitions to xdr4.h
nfsd4: opdesc will be useful outside nfs4proc.c
nfsd4: define ->op_release for compound ops
nfsd4: skip encoder in triv
On Thu, Aug 31, 2017 at 09:48:14AM +1000, Stephen Rothwell wrote:
> On Fri, 25 Aug 2017 10:24:20 +1000 Stephen Rothwell
> wrote:
...
> > fs/nfsd/nfs4proc.c:2405:17: note: (near initialization for
> > 'nfsd4_ops[50].op_release')
> > fs/nfsd/nfs4proc.c: In function 'nfsd4_layoutget_release':
> > f
On Fri, Aug 18, 2017 at 06:00:47AM -0400, Vadim Lomovtsev wrote:
> While running nfs/connectathon tests kernel NULL-pointer exception
> has been observed due to races in svcsock.c.
>
> Race is appear when kernel accepts connection by kernel_accept
> (which creates new socket) and start queuing ing
Please pull
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.13-2
Two nfsd bugfixes, neither 4.13 regressions, but both potentially
serious.
--b.
Chuck Lever (1):
nfsd: Limit end of page list when decoding NFSv4 WRITE
Vadim Lomovtsev (1):
net: sunrpc: svcsock: fix NULL-pointer
On Thu, Aug 24, 2017 at 10:21:41PM -0400, J. Bruce Fields wrote:
> On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> > Hi Bruce,
> >
> > Commit
> >
> > 1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
> >
> > i
On Fri, Aug 25, 2017 at 08:48:21AM +1000, Stephen Rothwell wrote:
> Hi Bruce,
>
> Commit
>
> 1b7f1a85c0fa ("opdesc will be useful outside nfs4proc.c")
>
> is missing a Signed-off-by from its author and committer.
Fixed, thanks.--b.
On Wed, Aug 23, 2017 at 06:33:42AM -0400, Jeff Layton wrote:
> I think this one looks fine. Bruce, do you mind picking this one up? It
> might also be reasonable for stable...
Yep, thanks to you both, I'll plan to send a pull request tonight or
tomorrow.
--b.
On Wed, Jul 12, 2017 at 01:56:50PM -0400, Mimi Zohar wrote:
> On Wed, 2017-07-12 at 10:35 -0400, Bruce Fields wrote:
> > On Wed, Jul 12, 2017 at 08:20:21AM -0400, Mimi Zohar wrote:
> > > Right, currently the only way of knowing is by looking at the IMA
> > > measurem
On Fri, Jul 14, 2017 at 04:51:31PM -0700, Kees Cook wrote:
> On Fri, Jul 14, 2017 at 2:28 PM, Daniel Micay wrote:
> > Using strscpy was wrong because FORTIFY_SOURCE is passing the maximum
> > possible size of the outermost object, but strscpy defines the count
> > parameter as the exact buffer siz
On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote:
> On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote:
> > Hi Linus,
> >
> > The following changes since commit
> 32c1431eea4881a6b17bd7c639315010aeefa452:
> >
> > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700)
> >
> >
On Thu, Jul 13, 2017 at 01:53:10PM -0400, Chuck Lever wrote:
>
> > On Jul 13, 2017, at 1:51 PM, Colin King wrote:
> >
> > From: Colin Ian King
> >
> > The current check will always be true and will always jump to
> > err1, this looks dubious to me. I believe && should be used
> > instead of ||
svcrdma: Remove frmr cache
svcrdma: Clean-up svc_rdma_unmap_dma
svcrdma: Clean up after converting svc_rdma_recvfrom to rdma_rw API
svcrdma: use offset_in_page() macro
svcrdma: Remove svc_rdma_chunk_ctxt::cc_dir field
Colin Ian King (1):
svcrdma: fix an incorrect check on -
On Wed, Jul 12, 2017 at 08:20:21AM -0400, Mimi Zohar wrote:
> Right, currently the only way of knowing is by looking at the IMA
> measurement list to see if modified files are re-measured or, as you
> said, by looking at the code.
Who's actually using this, and do they do any kind of checks, or
do
On Fri, Jul 07, 2017 at 10:05:30AM -0400, Jeff Layton wrote:
> From: Jeff Layton
>
> The IMA assessment code tries to use the i_version counter to detect
> when changes to a file have occurred. Many filesystems don't increment
> it properly (or at all) so detecting changes with that is not always
On Fri, Jul 07, 2017 at 12:13:36PM -0400, Jeff Layton wrote:
> On Fri, 2017-07-07 at 11:51 -0400, Theodore Ts'o wrote:
> > On Fri, Jul 07, 2017 at 06:51:37AM -0400, Jeff Layton wrote:
> > >
> > > Right. That's the case today if we don't remove support for old
> > > filehandles. If we were to remov
On Thu, Jul 06, 2017 at 11:08:27AM +1000, NeilBrown wrote:
> On Wed, Jul 05 2017, J. Bruce Fields wrote:
>
> > On Wed, Jul 05, 2017 at 12:19:33PM -0700, Darrick J. Wong wrote:
> >> So, what's the probability that there are clients out there that started
> >> ta
On Wed, Jul 05, 2017 at 12:19:33PM -0700, Darrick J. Wong wrote:
> On Tue, Jul 04, 2017 at 09:15:34PM -0400, J. Bruce Fields wrote:
> > On Mon, Jul 03, 2017 at 09:04:46PM -0700, Darrick J. Wong wrote:
> > > On Thu, Jun 29, 2017 at 02:50:22PM -0400, J. Bruce Fields wrote:
>
On Mon, Jul 03, 2017 at 09:04:46PM -0700, Darrick J. Wong wrote:
> On Thu, Jun 29, 2017 at 02:50:22PM -0400, J. Bruce Fields wrote:
> > On Thu, Jun 29, 2017 at 02:30:53PM -0400, J. Bruce Fields wrote:
> > > On Thu, Jun 29, 2017 at 10:25:28AM -0700, Darrick J. Wong wrote:
> &
On Thu, Jun 29, 2017 at 02:30:53PM -0400, J. Bruce Fields wrote:
> On Thu, Jun 29, 2017 at 10:25:28AM -0700, Darrick J. Wong wrote:
> > Was there ever a version of NFS (or more generally callers of the
> > exportfs code) that couldn't deal with i_generation in the file handle,
On Thu, Jun 29, 2017 at 10:25:28AM -0700, Darrick J. Wong wrote:
> Was there ever a version of NFS (or more generally callers of the
> exportfs code) that couldn't deal with i_generation in the file handle,
> and therefore we invented this generation hack to work around the loss
> of the generation
On Wed, Jun 28, 2017 at 09:59:40PM -0700, Darrick J. Wong wrote:
> AFAICT, i_generation == 0 in XFS and btrfs is just as valid as any other
> number. There is no special casing of zero in either filesystem.
>
> So now, my curiosity intrigued, I surveyed all the Linux filesystems
> that can export
On Fri, Jun 16, 2017 at 08:28:31AM +1000, NeilBrown wrote:
> It wouldn't be too hard to create that scenario. It might be harder to
> find a way to expose the corruption.
Yes. Well, in any case, I assume this Al's to take. ACK to the patch,
and it should go to stable as well.
--b.
On Thu, Jun 15, 2017 at 07:54:57AM +1000, NeilBrown wrote:
> On Wed, Jun 14 2017, J. Bruce Fields wrote:
>
> > On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote:
> >> I found this bug by reviewing places where we do ERR_PTR(0) (which is
> >> NULL).
&
On Wed, Jun 14, 2017 at 12:30:02PM +0300, Dan Carpenter wrote:
> I found this bug by reviewing places where we do ERR_PTR(0) (which is
> NULL).
>
> We used to return an error pointer if lookup_one_len() failed but we
> moved this code into a helper function and accidentally removed that.
> NULL is
On Sat, Jun 03, 2017 at 11:17:30PM +0300, Sergei Shtylyov wrote:
> On 06/02/2017 11:25 PM, J. Bruce Fields wrote:
>
> >>>commit d85b758f72b0 "virtio_net: fix support for small rings"
> >>
> >> Commit d85b758f72b0 ("virtio_net: fix support for s
before helps.
> >
> >Fixes: d85b758f72b0 "virtio_net: fix support for small rings"
>
> Fixes: d85b758f72b0 ("virtio_net: fix support for small rings")
I may be bikeshedding, but, personally I never do the parens--they're
redundant given the quotes, and
s to break some setups -
> it's not yet clear why, but increasing buffer size
> back to what it was before helps.
>
> Fixes: d85b758f72b0 "virtio_net: fix support for small rings"
> Reported-by: Mikulas Patocka
> Reported-by: "J. Bruce Fields"
> Signed
Please pull a couple nfsd bugfixes from:
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.12-1
Revert patch accidentally included in the merge window pull request, and
fix a crash that was likely a result of buggy client behavior.
--b.
J. Bruce Fields (2):
nfsd: Revert "nfsd:
7; flock. This exists to emulate
> > > Windows Share Modes.
> > > + * - %LOCK_SH -- a shared lock.
> > > + * - %LOCK_EX -- an exclusive lock.
> > > + * - %LOCK_UN -- remove an existing lock.
> > > + * - %LOCK_MAND -- a 'mandatory' flock.
> > > + * This exists to emulate Windows Share Modes.
> > > *
> > > * %LOCK_MAND can be combined with %LOCK_READ or %LOCK_WRITE to
> > > allow other
> > > * processes read and write access respectively.
> >
> > LGTM. Do you need me or Bruce to pick this one up?
>
> Feel free to pick it, if it works best for you.
>
> > Reviewed-by: Jeff Layton
I'll take it for 4.13. Thanks!
--b.
On Fri, May 12, 2017 at 08:22:23AM +1000, NeilBrown wrote:
> On Thu, May 11 2017, J. Bruce Fields wrote:
> > +static inline u64 nfsd4_change_attribute(struct inode *inode)
> > +{
> > + u64 chattr;
> > +
> > + chattr = inode->i_ctime.tv_sec << 30
On Fri, May 12, 2017 at 07:01:25AM -0400, Jeff Layton wrote:
> This looks reasonable to me (modulo Jan's comment about casting tv_sec
> to u64).
>
> To be clear, I think this is mostly orthogonal to the changes that I was
> originally proposing, right? I think we can still benefit from only
> bump
On Fri, May 12, 2017 at 10:27:54AM +0200, Jan Kara wrote:
> On Thu 11-05-17 14:59:43, J. Bruce Fields wrote:
> > On Wed, Apr 05, 2017 at 02:14:09PM -0400, J. Bruce Fields wrote:
> > > On Wed, Apr 05, 2017 at 10:05:51AM +0200, Jan Kara wrote:
> > > > 1) Keep i_version
On Wed, Apr 05, 2017 at 02:14:09PM -0400, J. Bruce Fields wrote:
> On Wed, Apr 05, 2017 at 10:05:51AM +0200, Jan Kara wrote:
> > 1) Keep i_version as is, make clients also check for i_ctime.
>
> That would be a protocol revision, which we'd definitely rather avoid.
>
&g
unused RDMA Write completion handler
svcrdma: Remove the req_map cache
svcrdma: Clean out old XDR encoders
Colin Ian King (1):
lockd: remove redundant check on block
Dmitry V. Levin (1):
uapi: fix linux/nfsd/cld.h userspace compilation errors
J. Bruce Fields (3):
nfsd
with amd64). The large value will be later used in de-referencing
nfsd4_layout_ops for function pointers.
Reported-by: Jani Tuovila
Signed-off-by: Ari Kauppi
[colin.k...@canonical.com: use LAYOUT_TYPE_MAX instead of 32]
Reviewed-by: Dan Carpenter
Signed-off-by: J. Br
Please pull knfsd bugfixes for 4.11 from
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.11-3
Thanks to Ari Kauppi and Tuomas Haanpää at Synopsis for spotting bugs in
our NFSv2/v3 xdr code that could crash the server or expose memory.
--b.
J. Bruce Fields (3):
nfsd: check for
On Sat, Apr 08, 2017 at 06:09:59PM +0100, Colin King wrote:
> From: Colin Ian King
>
> A null check followed by a return is being performed already, so block
> is always non-null at the second check on block, hence we can remove
> this redundant null-check (Detected by PVS-Studio). Also re-work
Please pull
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.11-2
Fix a 4.11 regression that triggers a BUG() on an attempt to use an
unsupported NFSv4 compound op.
(Apologies for what's probably a last-minute fix. I was hoping to have
a few more ready to roll up with it, but they'll probab
On Wed, Apr 05, 2017 at 10:05:51AM +0200, Jan Kara wrote:
> 1) Keep i_version as is, make clients also check for i_ctime.
That would be a protocol revision, which we'd definitely rather avoid.
But can't we accomplish the same by using something like
ctime * (some constant) + i_version
?
On Wed, Apr 05, 2017 at 11:43:32AM +1000, NeilBrown wrote:
> On Tue, Apr 04 2017, J. Bruce Fields wrote:
>
> > On Thu, Mar 30, 2017 at 02:35:32PM -0400, Jeff Layton wrote:
> >> On Thu, 2017-03-30 at 12:12 -0400, J. Bruce Fields wrote:
> >> > On Thu, Mar 30, 2017
On Thu, Mar 30, 2017 at 01:52:14PM -0400, Stephen Smalley wrote:
> On Thu, 2017-03-30 at 13:41 -0400, J. Bruce Fields wrote:
> > It is. I also want to keep new protocol upgrades free of user
> > regressions, which the 4.1->4.2 upgrade is in most cases if we turn
> > on
On Thu, Mar 30, 2017 at 10:41:37AM +1100, Dave Chinner wrote:
> On Wed, Mar 29, 2017 at 01:54:31PM -0400, Jeff Layton wrote:
> > On Wed, 2017-03-29 at 13:15 +0200, Jan Kara wrote:
> > > On Tue 21-03-17 14:46:53, Jeff Layton wrote:
> > > > On Tue, 2017-03-21 at 14:3
On Thu, Mar 30, 2017 at 02:35:32PM -0400, Jeff Layton wrote:
> On Thu, 2017-03-30 at 12:12 -0400, J. Bruce Fields wrote:
> > On Thu, Mar 30, 2017 at 07:11:48AM -0400, Jeff Layton wrote:
> > > On Thu, 2017-03-30 at 08:47 +0200, Jan Kara wrote:
> > > > Because if abo
On Tue, Apr 04, 2017 at 10:34:14PM +1000, Dave Chinner wrote:
> On Mon, Apr 03, 2017 at 04:00:55PM +0200, Jan Kara wrote:
> > What filesystems can or cannot easily do obviously differs. Ext4 has a
> > recovery flag set in superblock on RW mount/remount and cleared on
> > umount/RO remount.
>
> Eve
On Mon, Apr 03, 2017 at 11:09:48AM +1000, Stephen Rothwell wrote:
> Hi,
>
> After merging the nfsd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> fs/nfsd/nfs4state.c: In function 'copy_cred':
> fs/nfsd/nfs4state.c:1917:6: warning: unused variable 'ret' [-Wun
Please pull nfsd bugfixes from
git://linux-nfs.org/~bfields/linux.git tags/nfsd-4.11-1
The restriction of NFSv4 to TCP went overboard and also broke the
backchannel; fix. Also some minor refinements to the nfsd
version-setting interface that we'd like to get fixed before release.
--b.
Chuck
On Thu, Mar 30, 2017 at 01:27:07PM -0400, Stephen Smalley wrote:
> On Thu, 2017-03-30 at 09:49 +0200, Tomeu Vizoso wrote:
> > On 29 March 2017 at 23:34, J. Bruce Fields
> > wrote:
> > > On Wed, Mar 29, 2017 at 05:27:23PM +0200, Tomeu Vizoso wrote:
> > > > Label
On Thu, Mar 30, 2017 at 07:11:48AM -0400, Jeff Layton wrote:
> On Thu, 2017-03-30 at 08:47 +0200, Jan Kara wrote:
> > Hum, so are we fine if i_version just changes (increases) for all inodes
> > after a server crash? If I understand its use right, it would mean
> > invalidation of all client's cach
Fine by me, but I'm not sure why you're sending it to us.
Looks at MAINTAINERS
Oh, I see, include/linux/fs.h is under "FILE LOCKING". Hm. Anyway,
this one's probably for Al Viro.
--b.
On Fri, Mar 24, 2017 at 10:13:36PM +0800, Geliang Tang wrote:
> Drop duplicate header percpu-rwsem.h from
gned-off-by: Tomeu Vizoso
> Cc: J. Bruce Fields
>
> ---
>
> Hi,
>
> cannot remotely say that I currently understand how selinux is expected
> to work within NFS mounts, but this change allowed me to fully boot AOSP
> with its rootfs and ramdisk on a single NFS share.
On Tue, Mar 21, 2017 at 02:46:53PM -0400, Jeff Layton wrote:
> On Tue, 2017-03-21 at 14:30 -0400, J. Bruce Fields wrote:
> > On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff Layton wrote:
> > > On Tue, 2017-03-21 at 12:30 -0400, J. Bruce Fields wrote:
> > > > - It&#
On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff Layton wrote:
> On Tue, 2017-03-21 at 12:30 -0400, J. Bruce Fields wrote:
> > - It's durable; the above comparison still works if there were reboots
> > between the two i_version checks.
> > - I don't know how re
On Tue, Mar 21, 2017 at 01:37:04PM -0400, J. Bruce Fields wrote:
> On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff Layton wrote:
> > On Tue, 2017-03-21 at 12:30 -0400, J. Bruce Fields wrote:
> > > - NFS doesn't actually require that it increases, but I think it
> > &g
On Tue, Mar 21, 2017 at 05:41:22PM +0100, Jan Kara wrote:
> On Tue 21-03-17 11:38:49, J. Bruce Fields wrote:
> > On Sun, Mar 19, 2017 at 11:19:43AM +0100, Jan Kara wrote:
> > > On Tue 14-03-17 13:18:01, Amir Goldstein wrote:
> > > > On Tue, Mar 14, 2017 at 1:03 AM, Fi
On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff Layton wrote:
> On Tue, 2017-03-21 at 12:30 -0400, J. Bruce Fields wrote:
> > - NFS doesn't actually require that it increases, but I think it
> > should. I assume 64 bits means we don't need a discussion of
>
301 - 400 of 1686 matches
Mail list logo
