RE: [PATCH 1/1] cciss: fix error reporting for SG_IO

2007-08-16 Thread Cameron, Steve
Any feedback on my patch? Anybody know what the msg_byte in include/scsi/scsi.h is for? scsi.h says: * msg_byte= return status from host adapter itself. So, it's ok to use the msg_byte for device specific error codes? -- steve - To unsubscribe from this list: send the line "unsubscri

RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment

2007-04-19 Thread Cameron, Steve
Thu 4/19/2007 11:22 AM To: Miller, Mike (OS Dev) Cc: Hisashi Hifumi; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Cameron, Steve Subject: RE: [PATCH] cciss: Fix warnings during compilation under 32bitenvironment On Thu, 2007-04-19 at 16:12 +, Miller,

RE: [PATCH 1/1] cciss: include scsi/scsi.h unconditionally

2007-04-13 Thread Cameron, Steve
Andrew Morton [mailto:[EMAIL PROTECTED] wrote: > On Fri, 13 Apr 2007 09:23:12 -0500 > Stephen Cameron <[EMAIL PROTECTED]> wrote: > > > Make cciss unconditionally include scsi/scsi.h > > For what reason? Because the use of: case SCSI_IOCTL_GET_IDLUN: case SCSI_IOCTL_GET_BUS_NUMB

RE: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi for SG_IO ioctl

2007-04-13 Thread Cameron, Steve
Hmm, now that I look again, those ioctls it's complaining about are ones for which we just return ENOTTY, so I guess we don't really need them listed explicitly, and if they weren't, the Kconfig patch would be unnecessary. -- steve -Original Message- From: Cameron, St

RE: [PATCH 1/1] cciss: kconfig patch to make cciss dependent onscsi for SG_IO ioctl

2007-04-13 Thread Cameron, Steve
teve -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Thu 4/12/2007 5:07 PM To: Mike Miller (OS Dev) Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Cameron, Steve Subject: Re: [PATCH 1/1] cciss: kconfig patch to make cciss dependent ons