Re: [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

2021-03-19 Thread Campion Kang
16:07:55 + From: Lee Jones On Mon, 18 Jan 2021, Campion Kang wrote: > AHC1EC0 is the embedded controller driver for Advantech industrial It would be nice to have the model number in the subject line. [Campion] AHC1EC0 is its model name that used in Advantech device inter

[PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

2021-01-18 Thread Campion Kang
rly define the EC name - fix the code according to reviewer's suggestion - remove unnecessary header files - change the structure name to lower case, align with others naming Signed-off-by: Campion Kang --- drivers/mfd/Kconfig | 10 + drivers/mfd/Makefi

[PATCH v6 6/6] watchdog: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller

2021-01-18 Thread Campion Kang
- Kconfig: add "AHC1EC0" string to clearly define the EC name Signed-off-by: Campion Kang --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile | 1 + drivers/watchdog/ahc1ec0-wdt.c | 261 + 3 files changed, 273 insertions(+) c

[PATCH v6 3/6] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded controller - AHC1EC0

2021-01-18 Thread Campion Kang
Add DT binding schema for Advantech embedded controller AHC1EC0. Changed since V5: - rename dt-bindings/mfd/ahc1ec0.h to dt-bindings/mfd/ahc1ec0-dt.h that found errors by bot 'make dt_binding_check' Signed-off-by: Campion Kang --- .../devicetree/bindings/mfd/ah

[PATCH v6 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller

2021-01-18 Thread Campion Kang
register hwmon driver based on reviewer's suggestion Signed-off-by: Campion Kang --- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile| 1 + drivers/hwmon/ahc1ec0-hwmon.c | 660 ++ 3 files changed, 671 insertions(+) create mode 100644 dr

[PATCH v6 2/6] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings

2021-01-18 Thread Campion Kang
This files defines the sud-device types and hwmon profiles support by Advantech embedded controller. Signed-off-by: Campion Kang --- include/dt-bindings/mfd/ahc1ec0-dt.h | 25 + 1 file changed, 25 insertions(+) create mode 100644 include/dt-bindings/mfd/ahc1ec0-dt.h

[PATCH v6 1/6] MAINTAINERS: Add Advantech AHC1EC0 embedded controller entry

2021-01-18 Thread Campion Kang
Add Advantech AHC1EC0 embedded controller entry Changed since V5: - add include/linux/mfd/ahc1ec0.h Signed-off-by: Campion Kang --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 00836f6452f0..e1ccdaadb5ee 100644 --- a

[PATCH v5 1/6] MAINTAINERS: Add Advantech AHC1 embedded controller entry

2020-12-31 Thread Campion Kang
Add Advantech AHC1 embedded controller entry Signed-off-by: Campion Kang --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 546aa66428c9..20766da2e794 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -562,6 +562,16 @@ S: Maintained F

[PATCH v5 6/6] watchdog: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller

2020-12-31 Thread Campion Kang
This is one of sub-device driver for Advantech embedded controller AHC1EC0. This driver provide watchdog functionality for Advantech related applications to restart the system. Signed-off-by: Campion Kang --- drivers/watchdog/Kconfig | 11 ++ drivers/watchdog/Makefile | 1

[PATCH v5 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller

2020-12-31 Thread Campion Kang
This is one of sub-device driver for Advantech embedded controller AHC1EC0. This driver provides sysfs ABI for Advantech related applications to monitor the system status. Signed-off-by: Campion Kang --- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile| 1 + drivers/hwmon

[PATCH v5 3/6] dt-bindings: mfd: ahc1ec0.yaml: Add Advantech embedded controller - AHC1EC0

2020-12-31 Thread Campion Kang
Add DT binding schema for Advantech embedded controller AHC1EC0. Signed-off-by: Campion Kang --- .../devicetree/bindings/mfd/ahc1ec0.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ahc1ec0.yaml diff --git a

[PATCH v5 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

2020-12-31 Thread Campion Kang
AHC1EC0 is the embedded controller driver for Advantech industrial products. This provides sub-devices such as hwmon and watchdog, and also expose functions for sub-devices to read/write the value to embedded controller. Signed-off-by: Campion Kang --- drivers/mfd/Kconfig | 10

[PATCH v5 2/6] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings

2020-12-31 Thread Campion Kang
This files defines the sud-device types and hwmon profiles support by Advantech embedded controller. Signed-off-by: Campion Kang --- include/dt-bindings/mfd/ahc1ec0-dt.h | 25 + 1 file changed, 25 insertions(+) create mode 100644 include/dt-bindings/mfd/ahc1ec0-dt.h