Re: [BISECTED] Suspend / USB broken on XPS 9370 + TB16

2019-10-07 Thread Carlo Caione
. That patch fixes the issue. Thank you, -- Carlo Caione

[BISECTED] Suspend / USB broken on XPS 9370 + TB16

2019-10-07 Thread Carlo Caione
Log: https://termbin.com/icix Cheers! -- Carlo Caione

Re: [PATCH] net: phy: at803x: Use helpers to access MMD PHY registers

2019-01-25 Thread Carlo Caione
On 25/01/2019 15:00, Andrew Lunn wrote: On Fri, Jan 25, 2019 at 12:35:10PM +, Carlo Caione wrote: Libphy provides a standard set of helpers to access the MMD PHY registers. Use those instead of relying on custom driver-specific functions. Hi Carlo Hey Andrew, Maybe deja vu, but i

[PATCH] net: phy: at803x: Use helpers to access MMD PHY registers

2019-01-25 Thread Carlo Caione
Libphy provides a standard set of helpers to access the MMD PHY registers. Use those instead of relying on custom driver-specific functions. Signed-off-by: Carlo Caione --- drivers/net/phy/at803x.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/net

Re: [PATCH] MAINTAINERS: Remove myself from the list

2018-12-04 Thread Carlo Caione
On Mon, 2018-12-03 at 11:21 +0100, Neil Armstrong wrote: > On 01/12/2018 16:17, Carlo Caione wrote: > > Kevin is basically doing all the work. Remove my name as co- > > maintainer. > > Sure, but couldn't we move you as reviewer and add Martin as reviewer > aswe

Re: [PATCH] MAINTAINERS: Remove myself from the list

2018-12-04 Thread Carlo Caione
On Mon, 2018-12-03 at 11:21 +0100, Neil Armstrong wrote: > On 01/12/2018 16:17, Carlo Caione wrote: > > Kevin is basically doing all the work. Remove my name as co- > > maintainer. > > Sure, but couldn't we move you as reviewer and add Martin as reviewer > aswe

[PATCH] MAINTAINERS: Remove myself from the list

2018-12-01 Thread Carlo Caione
Kevin is basically doing all the work. Remove my name as co-maintainer. Signed-off-by: Carlo Caione --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01645edc2388..63a2ad093524 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1297,7 +1297,6 @@ F

[PATCH] MAINTAINERS: Remove myself from the list

2018-12-01 Thread Carlo Caione
Kevin is basically doing all the work. Remove my name as co-maintainer. Signed-off-by: Carlo Caione --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01645edc2388..63a2ad093524 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1297,7 +1297,6 @@ F

Re: [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed

2018-02-16 Thread Carlo Caione
sted please? Feel free to keep my Reviewed-by for the v4. No problem. Thank you both for the reviews. Cheers, -- Carlo Caione | +44.7384.69.16.04 | Endless

Re: [PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed

2018-02-16 Thread Carlo Caione
p my Reviewed-by for the v4. No problem. Thank you both for the reviews. Cheers, -- Carlo Caione | +44.7384.69.16.04 | Endless

[PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The ECS EF20EA laptop ships an AXP288 but it is actually using a different, separate FG chip for AC and battery monitoring. On this laptop we need to keep using the regular ACPI driver and disable the AXP288 FG to avoid reporting two batteries to use

[PATCH v2 3/3] power: supply: axp288_fuel_gauge: Do not register FG on ECS EF20EA

2018-02-16 Thread Carlo Caione
From: Carlo Caione The ECS EF20EA laptop ships an AXP288 but it is actually using a different, separate FG chip for AC and battery monitoring. On this laptop we need to keep using the regular ACPI driver and disable the AXP288 FG to avoid reporting two batteries to userspace. Signed-off

[PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed

2018-02-16 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumente

[PATCH v2 0/3] power: supply: Fix AXP288 fallback when not needed

2018-02-16 Thread Carlo Caione
From: Carlo Caione With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumented ACPI opregions

[PATCH v2 1/3] ACPI: AC/battery: Add quirk to avoid using PMIC

2018-02-16 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumente

[PATCH v2 1/3] ACPI: AC/battery: Add quirk to avoid using PMIC

2018-02-16 Thread Carlo Caione
From: Carlo Caione With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumented ACPI opregions

[PATCH v2 2/3] ACPI: AC/battery: Add quirks for ECS EF20EA

2018-02-16 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> On the ECS EF20EA laptop we need to move away from the AXP288 FG driver and enable again the ACPI AC/battery drivers. Add the required quirks to do that. We rely only on the product name because all the other DMI entries are dummy or not

[PATCH v2 2/3] ACPI: AC/battery: Add quirks for ECS EF20EA

2018-02-16 Thread Carlo Caione
From: Carlo Caione On the ECS EF20EA laptop we need to move away from the AXP288 FG driver and enable again the ACPI AC/battery drivers. Add the required quirks to do that. We rely only on the product name because all the other DMI entries are dummy or not filled in on this platform. Signed-off

Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-15 Thread Carlo Caione
On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione <ca...@caione.org> wrote: > From: Carlo Caione <ca...@endlessm.com> > > On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in > the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to >

Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-15 Thread Carlo Caione
On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione wrote: > From: Carlo Caione > > On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in > the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to > the rt5645 driver to enable the jack detection

[PATCH 0/2] power: supply: Fix AXP288 fallback when not needed

2018-02-14 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumente

[PATCH 0/2] power: supply: Fix AXP288 fallback when not needed

2018-02-14 Thread Carlo Caione
From: Carlo Caione With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumented ACPI opregions

[PATCH 2/2] power: supply: ACPI/AXP288: Add quirks for ECS EF20EA

2018-02-14 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> On the ECS EF20EA laptop we need to move away from the AXP288 FG driver and enable again the ACPI AC/battery drivers. Add the required quirks to do that. We rely only on the product name because all the other DMI entries are dummy or not

[PATCH 2/2] power: supply: ACPI/AXP288: Add quirks for ECS EF20EA

2018-02-14 Thread Carlo Caione
From: Carlo Caione On the ECS EF20EA laptop we need to move away from the AXP288 FG driver and enable again the ACPI AC/battery drivers. Add the required quirks to do that. We rely only on the product name because all the other DMI entries are dummy or not filled in on this platform. Signed-off

[PATCH 1/2] power: supply: ACPI/AXP288: Add quirk to avoid using PMIC

2018-02-14 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumente

[PATCH 1/2] power: supply: ACPI/AXP288: Add quirk to avoid using PMIC

2018-02-14 Thread Carlo Caione
From: Carlo Caione With commits af3ec837 and dccfae6d a blacklist was introduced to avoid using the ACPI drivers for AC and battery when a native PMIC driver was already present. While this is in general a good idea (because of broken DSDT or proprietary and undocumented ACPI opregions

[PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-09 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to the rt5645 driver to enable the jack detection also on non-DT platforms. Method (_CRS, 0, NotSeri

[PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-09 Thread Carlo Caione
From: Carlo Caione On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to the rt5645 driver to enable the jack detection also on non-DT platforms. Method (_CRS, 0, NotSerialized) { Name (SBUF

[PATCH] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-08 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to the rt5645 driver to enable the jack detection also on non-DT platforms. Method (_CRS, 0, NotSeri

[PATCH] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO

2018-02-08 Thread Carlo Caione
From: Carlo Caione On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to the rt5645 driver to enable the jack detection also on non-DT platforms. Method (_CRS, 0, NotSerialized) { Name (SBUF

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Carlo Caione
nt I'm not sure if the problem I'm seeing is actually related to the issue you are fixing with this commit (and if now, sorry to have hijacked this thread). Any idea on that? Thank you, [0] https://gist.github.com/carlocaione/82bff95ababb67dd33f52a86e94ce3ff -- Carlo Caione | +39.340.80.30.096 | Endless

Re: [PATCH] ACPI / LPSS: Add device link for CHT SD card dependency on I2C

2017-12-04 Thread Carlo Caione
e issue you are fixing with this commit (and if now, sorry to have hijacked this thread). Any idea on that? Thank you, [0] https://gist.github.com/carlocaione/82bff95ababb67dd33f52a86e94ce3ff -- Carlo Caione | +39.340.80.30.096 | Endless

Re: [PATCH 0/2] Update codec driver for dual mics configuration

2017-11-28 Thread Carlo Caione
On Tue, Nov 21, 2017 at 5:15 PM, Carlo Caione <ca...@caione.org> wrote: > From: Carlo Caione <ca...@endlessm.com> > > The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO > laptop) > have two different analog mics on two ports, leaving the headset

Re: [PATCH 0/2] Update codec driver for dual mics configuration

2017-11-28 Thread Carlo Caione
On Tue, Nov 21, 2017 at 5:15 PM, Carlo Caione wrote: > From: Carlo Caione > > The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO > laptop) > have two different analog mics on two ports, leaving the headset on the > remaining one. We need to add a new qui

[PATCH 1/2] ASoC: intel: byt: Introduce new map for dual mics

2017-11-21 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The RT5651 codec has 3 analog inputs. Some laptops have two different internal analog microphones on the external case. Add a new custom quirk mapping the two internal mics on IN1P / IN2P, leaving the headset mic on IN3P. Signed-off-by: Carlo Caio

[PATCH 1/2] ASoC: intel: byt: Introduce new map for dual mics

2017-11-21 Thread Carlo Caione
From: Carlo Caione The RT5651 codec has 3 analog inputs. Some laptops have two different internal analog microphones on the external case. Add a new custom quirk mapping the two internal mics on IN1P / IN2P, leaving the headset mic on IN3P. Signed-off-by: Carlo Caione --- sound/soc/intel

[PATCH 0/2] Update codec driver for dual mics configuration

2017-11-21 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO laptop) have two different analog mics on two ports, leaving the headset on the remaining one. We need to add a new quirk to support also this configuration. Carlo Caione (2):

[PATCH 0/2] Update codec driver for dual mics configuration

2017-11-21 Thread Carlo Caione
From: Carlo Caione The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO laptop) have two different analog mics on two ports, leaving the headset on the remaining one. We need to add a new quirk to support also this configuration. Carlo Caione (2): ASoC: intel: byt

[PATCH 2/2] ASoC: intel: byt: Fix quirk for KIANO laptop

2017-11-21 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> This laptop has actually two different analog mics, no just one. Fix the quirk to reflect the correct configuration. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- 1 file changed, 1 ins

[PATCH 2/2] ASoC: intel: byt: Fix quirk for KIANO laptop

2017-11-21 Thread Carlo Caione
From: Carlo Caione This laptop has actually two different analog mics, no just one. Fix the quirk to reflect the correct configuration. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/intel

Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-11-21 Thread Carlo Caione
On Thu, Nov 16, 2017 at 1:53 PM, Carlo Caione <ca...@caione.org> wrote: > On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart > <pierre-louis.boss...@linux.intel.com> wrote: >> On 10/18/17 11:49 AM, Carlo Caione wrote: >>> >>> From: Carlo Caione &l

Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-11-21 Thread Carlo Caione
On Thu, Nov 16, 2017 at 1:53 PM, Carlo Caione wrote: > On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart > wrote: >> On 10/18/17 11:49 AM, Carlo Caione wrote: >>> >>> From: Carlo Caione >>> >>> Introduce a new custom dapm routes map to qui

Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-11-16 Thread Carlo Caione
On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> wrote: > On 10/18/17 11:49 AM, Carlo Caione wrote: >> >> From: Carlo Caione <ca...@endlessm.com> >> >> Introduce a new custom dapm routes map to quirk platforms wit

Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-11-16 Thread Carlo Caione
On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart wrote: > On 10/18/17 11:49 AM, Carlo Caione wrote: >> >> From: Carlo Caione >> >> Introduce a new custom dapm routes map to quirk platforms with the >> internal mic connected to IN2P. > > > LGTM. If w

Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Carlo Caione
On Sat, Oct 21, 2017 at 11:09 AM, Mark Brown <broo...@kernel.org> wrote: > On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote: >> From: Carlo Caione <ca...@endlessm.com> >> >> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. > &g

Re: [PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-21 Thread Carlo Caione
On Sat, Oct 21, 2017 at 11:09 AM, Mark Brown wrote: > On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote: >> From: Carlo Caione >> >> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. > > Do we have any machine drivers using thi

[PATCH v2 3/5] ASoC: intel: byt: Enable IN2 map quirk for a KIANO laptop

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> This cherry-trails laptop has the internal mic connected to the IN2 input pins. Enable the quirk to correctly map the routes. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 8 1 fil

[PATCH v2 2/5] ASoC: intel: byt: Add headset jack

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Introduce an headset jack in the machine driver and register it to the codec driver. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 23 +++ 1 file changed, 23 insertions(+)

[PATCH v2 3/5] ASoC: intel: byt: Enable IN2 map quirk for a KIANO laptop

2017-10-20 Thread Carlo Caione
From: Carlo Caione This cherry-trails laptop has the internal mic connected to the IN2 input pins. Enable the quirk to correctly map the routes. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/intel

[PATCH v2 2/5] ASoC: intel: byt: Add headset jack

2017-10-20 Thread Carlo Caione
From: Carlo Caione Introduce an headset jack in the machine driver and register it to the codec driver. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b

[PATCH v2 4/5] ASoC: rt5651: Rework quirk logic

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Rework a bit the quirk logic in the codec driver to simplify the DMI-based quirk assignment for non-DT platforms. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/codecs/rt5651.c | 39 +++ 1

[PATCH v2 4/5] ASoC: rt5651: Rework quirk logic

2017-10-20 Thread Carlo Caione
From: Carlo Caione Rework a bit the quirk logic in the codec driver to simplify the DMI-based quirk assignment for non-DT platforms. Signed-off-by: Carlo Caione --- sound/soc/codecs/rt5651.c | 39 +++ 1 file changed, 35 insertions(+), 4 deletions(-) diff

[PATCH v2 5/5] ASoC: rt5651: Enable JD1_1 quirk for KIANO laptopt

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> The KIANO SlimNote 14.2 laptop uses the JD1_1 input pin for jack detection. Set the correct quirk in the codec driver. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/codecs/rt5651.c | 8 1 file changed, 8 insertions(+)

[PATCH v2 5/5] ASoC: rt5651: Enable JD1_1 quirk for KIANO laptopt

2017-10-20 Thread Carlo Caione
From: Carlo Caione The KIANO SlimNote 14.2 laptop uses the JD1_1 input pin for jack detection. Set the correct quirk in the codec driver. Signed-off-by: Carlo Caione --- sound/soc/codecs/rt5651.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc

[PATCH v2 1/5] ASoC: rt5651: Enable jack detection on JD* pins

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Enable jack detection for the RT5651 codec on the JD* pins. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- include/sound/rt5651.h| 8 +++ sound/soc/codecs/rt5651.c | 168 +- sound/soc/cod

[PATCH v2 0/5] rt5651: Enable jack detection

2017-10-20 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Patchset to support jack detection for the rt5651 codec on the JD* pins and enable it on the KIANO cherry-trail laptop. Changelog: v2: - Added quirks for the KIANO laptop - Extended support to JD1_2 and JD2 pins - Reworked quirk logic in the

[PATCH v2 0/5] rt5651: Enable jack detection

2017-10-20 Thread Carlo Caione
From: Carlo Caione Patchset to support jack detection for the rt5651 codec on the JD* pins and enable it on the KIANO cherry-trail laptop. Changelog: v2: - Added quirks for the KIANO laptop - Extended support to JD1_2 and JD2 pins - Reworked quirk logic in the codec driver - Codec driver

[PATCH v2 1/5] ASoC: rt5651: Enable jack detection on JD* pins

2017-10-20 Thread Carlo Caione
From: Carlo Caione Enable jack detection for the RT5651 codec on the JD* pins. Signed-off-by: Carlo Caione --- include/sound/rt5651.h| 8 +++ sound/soc/codecs/rt5651.c | 168 +- sound/soc/codecs/rt5651.h | 4 ++ 3 files changed, 178

Re: [alsa-devel] [PATCH 1/2] ASoC: rt5651: Enable jack detection on JD1_1

2017-10-19 Thread Carlo Caione
On Thu, Oct 19, 2017 at 4:47 PM, Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> wrote: > On 10/19/17 6:03 AM, Carlo Caione wrote: >> >> From: Carlo Caione <ca...@endlessm.com> >> >> Enable jack detection or the RT5651 codec on the JD1_1 pin. &g

Re: [alsa-devel] [PATCH 1/2] ASoC: rt5651: Enable jack detection on JD1_1

2017-10-19 Thread Carlo Caione
On Thu, Oct 19, 2017 at 4:47 PM, Pierre-Louis Bossart wrote: > On 10/19/17 6:03 AM, Carlo Caione wrote: >> >> From: Carlo Caione >> >> Enable jack detection or the RT5651 codec on the JD1_1 pin. > > Nice, but the codec supports a second jack detection on

[PATCH 0/2] rt5651: Enable jack detection

2017-10-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Small set of patches to enable jack detection for the rt5651 codec. Please note that: - The jack detection is restricted to the JD1_1 pin only (the only hardware I have uses this pin for jack detection) - AFAICT (reading the rt5651 dat

[PATCH 0/2] rt5651: Enable jack detection

2017-10-19 Thread Carlo Caione
From: Carlo Caione Small set of patches to enable jack detection for the rt5651 codec. Please note that: - The jack detection is restricted to the JD1_1 pin only (the only hardware I have uses this pin for jack detection) - AFAICT (reading the rt5651 datasheet) there is no way to detect

[PATCH 2/2] ASoC: intel: byt: Add headset jack

2017-10-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Introduce an headset jack in the machine driver and register it to the codec driver. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 24 1 file changed, 24 insertions(+)

[PATCH 2/2] ASoC: intel: byt: Add headset jack

2017-10-19 Thread Carlo Caione
From: Carlo Caione Introduce an headset jack in the machine driver and register it to the codec driver. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 24 1 file changed, 24 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b

[PATCH 1/2] ASoC: rt5651: Enable jack detection on JD1_1

2017-10-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Enable jack detection or the RT5651 codec on the JD1_1 pin. The codec has no means to detect the type of the jack connected so we assume that the jack is always an headset jack. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- include/so

[PATCH 1/2] ASoC: rt5651: Enable jack detection on JD1_1

2017-10-19 Thread Carlo Caione
From: Carlo Caione Enable jack detection or the RT5651 codec on the JD1_1 pin. The codec has no means to detect the type of the jack connected so we assume that the jack is always an headset jack. Signed-off-by: Carlo Caione --- include/sound/rt5651.h| 7 sound/soc/codecs/rt5651.c

[PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-18 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/codecs/rt5651.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codec

[PATCH] ASoC: rt5651: Convert rt5651 micbias1 to a supply widget

2017-10-18 Thread Carlo Caione
From: Carlo Caione MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget. Signed-off-by: Carlo Caione --- sound/soc/codecs/rt5651.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c index da60b28ba3df

[PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-10-18 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Introduce a new custom dapm routes map to quirk platforms with the internal mic connected to IN2P. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 16 +++- 1 file changed, 15 inse

[PATCH] SoC: intel: byt: Introduce new custom IN2 map

2017-10-18 Thread Carlo Caione
From: Carlo Caione Introduce a new custom dapm routes map to quirk platforms with the internal mic connected to IN2P. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel

Re: [PATCH 0/2] rt5651: Enable platforms with int mic on IN2

2017-10-18 Thread Carlo Caione
On Wed, Oct 18, 2017 at 5:19 PM, Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> wrote: > On 10/18/17 11:07 AM, Carlo Caione wrote: >> >> From: Carlo Caione <ca...@endlessm.com> >> >> While working on enabling a cherry-trail laptop

Re: [PATCH 0/2] rt5651: Enable platforms with int mic on IN2

2017-10-18 Thread Carlo Caione
On Wed, Oct 18, 2017 at 5:19 PM, Pierre-Louis Bossart wrote: > On 10/18/17 11:07 AM, Carlo Caione wrote: >> >> From: Carlo Caione >> >> While working on enabling a cherry-trail laptop shipping the rt5651 >> codec I realized that the machine driver neede

[PATCH 0/2] rt5651: Enable platforms with int mic on IN2

2017-10-18 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> While working on enabling a cherry-trail laptop shipping the rt5651 codec I realized that the machine driver needed some fixup. In particular the laptop I'm working on (KIANO SlimNote 14.2) has the internal mic connected to the IN2 port. All the

[PATCH 2/2] ASoC: intel: byt: Introduce new custom IN2 map

2017-10-18 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Introduce a new custom dapm routes map to quirk platforms with the internal mic connected to IN2P. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 15 ++- 1 file changed, 14 inse

[PATCH 2/2] ASoC: intel: byt: Introduce new custom IN2 map

2017-10-18 Thread Carlo Caione
From: Carlo Caione Introduce a new custom dapm routes map to quirk platforms with the internal mic connected to IN2P. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/sound/soc/intel

[PATCH 0/2] rt5651: Enable platforms with int mic on IN2

2017-10-18 Thread Carlo Caione
From: Carlo Caione While working on enabling a cherry-trail laptop shipping the rt5651 codec I realized that the machine driver needed some fixup. In particular the laptop I'm working on (KIANO SlimNote 14.2) has the internal mic connected to the IN2 port. All the laptop-specific work

[PATCH 1/2] ASoC: intel: byt: Enable quirk logic for custom maps

2017-10-18 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Enable again the quirk logic for the custom dapm routes. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- sound/soc/intel/boards/bytcr_rt5651.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt565

[PATCH 1/2] ASoC: intel: byt: Enable quirk logic for custom maps

2017-10-18 Thread Carlo Caione
From: Carlo Caione Enable again the quirk logic for the custom dapm routes. Signed-off-by: Carlo Caione --- sound/soc/intel/boards/bytcr_rt5651.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c index

Re: [PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-09-07 Thread Carlo Caione
On Mon, Aug 21, 2017 at 9:27 AM, Carlo Caione <ca...@caione.org> wrote: > On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione <ca...@caione.org> wrote: >> From: Carlo Caione <ca...@endlessm.com> >> >> We have found some ACER laptops shipping with certificate

Re: [PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-09-07 Thread Carlo Caione
On Mon, Aug 21, 2017 at 9:27 AM, Carlo Caione wrote: > On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote: >> From: Carlo Caione >> >> We have found some ACER laptops shipping with certificates signed using >> the 1.3.14.3.2.29 OID. This is causing

Re: [PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-21 Thread Carlo Caione
On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione <ca...@caione.org> wrote: > From: Carlo Caione <ca...@endlessm.com> > > We have found some ACER laptops shipping with certificates signed using > the 1.3.14.3.2.29 OID. This is causing the message /cut Ping on this (li

Re: [PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-21 Thread Carlo Caione
On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote: > From: Carlo Caione > > We have found some ACER laptops shipping with certificates signed using > the 1.3.14.3.2.29 OID. This is causing the message /cut Ping on this (literally) two lines patch. -- Carlo Caione

[PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-07 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> We have found some ACER laptops shipping with certificates signed using the 1.3.14.3.2.29 OID. This is causing the message EFI: Problem loading in-kernel X.509 certificate (-65) to be printed at boot. This OID is Rivest, Shamir and Adlema

[PATCH RESEND] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-07 Thread Carlo Caione
From: Carlo Caione We have found some ACER laptops shipping with certificates signed using the 1.3.14.3.2.29 OID. This is causing the message EFI: Problem loading in-kernel X.509 certificate (-65) to be printed at boot. This OID is Rivest, Shamir and Adleman (RSA) algorithm that uses

[PATCH] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-01 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> sha1WithRSASignature is a deprecated equivalent of sha1WithRSAEncryption. It originates from the NIST Open Systems Environment (OSE) Implementor's Workshop (OIW). It is supported for compatibility with Microsoft's certificate APIs and tools, partic

[PATCH] X.509: Recognize the legacy OID 1.3.14.3.2.29 (sha1WithRSASignature)

2017-08-01 Thread Carlo Caione
From: Carlo Caione sha1WithRSASignature is a deprecated equivalent of sha1WithRSAEncryption. It originates from the NIST Open Systems Environment (OSE) Implementor's Workshop (OIW). It is supported for compatibility with Microsoft's certificate APIs and tools, particularly makecert.exe, which

[PATCH] HID: asus: Stop underlying hardware on remove

2017-05-30 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> We are missing a call to hid_hw_stop() on the remove hook. Among other things this is causing an Oops when (re-)starting GNOME / upowerd / ... after the module has been already rmmod-ed. Signed-off-by: Carlo Caione <ca...@endlessm.com> --- dri

[PATCH] HID: asus: Stop underlying hardware on remove

2017-05-30 Thread Carlo Caione
From: Carlo Caione We are missing a call to hid_hw_stop() on the remove hook. Among other things this is causing an Oops when (re-)starting GNOME / upowerd / ... after the module has been already rmmod-ed. Signed-off-by: Carlo Caione --- drivers/hid/hid-asus.c | 2 ++ 1 file changed, 2

Re: [PATCH v2 00/18] ARM64: meson: DT cleanups

2017-05-25 Thread Carlo Caione
my efforts elsewhere. Neil's actions - who is neither author > nor maintainer here - of copying an opinionated personal and partially Uhm, probably we can fix at least this by making Neil maintainer instead of me given that Neil and BayLibre did much of the work on this platform. -- Carlo Caione

Re: [PATCH v2 00/18] ARM64: meson: DT cleanups

2017-05-25 Thread Carlo Caione
actions - who is neither author > nor maintainer here - of copying an opinionated personal and partially Uhm, probably we can fix at least this by making Neil maintainer instead of me given that Neil and BayLibre did much of the work on this platform. -- Carlo Caione

Re: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups

2017-04-20 Thread Carlo Caione
and cleans up the return paths. All told, the > driver > is reduced in size by 37 lines (3.6%). > > I do not have an HP laptop, so I'm hoping Carlo can help out with some > testing. > In particular we need to verify that hotkeys and sysfs continue to work as > before. On my HP

Re: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups

2017-04-20 Thread Carlo Caione
s reduced in size by 37 lines (3.6%). > > I do not have an HP laptop, so I'm hoping Carlo can help out with some > testing. > In particular we need to verify that hotkeys and sysfs continue to work as > before. On my HP 240 G5: Tested-by: Carlo Caione Cheers, -- Carlo Caione

[PATCH] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, ...) using hp_wmi_perform_query to perform an HP WMI query shadow the returned value in case of error. We return -EINVAL only when the HP WMI query returns a positive

[PATCH] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
From: Carlo Caione All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, ...) using hp_wmi_perform_query to perform an HP WMI query shadow the returned value in case of error. We return -EINVAL only when the HP WMI query returns a positive value (the specific error code

Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
On Wed, Apr 19, 2017 at 10:11 PM, Darren Hart <dvh...@infradead.org> wrote: > On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote: >> From: Carlo Caione <ca...@endlessm.com> >> >> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, &

Re: [PATCH v2 1/2] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
On Wed, Apr 19, 2017 at 10:11 PM, Darren Hart wrote: > On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote: >> From: Carlo Caione >> >> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, >> ...) using hp_wmi_perform_query to per

[PATCH v2 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> Several HP laptops cannot be put to sleep using the LID since systemd complains that the system is docked even though the laptop is not even dockable (see [1]). This is due to a bug in hp-wmi where the driver is failing to check for errors before cr

[PATCH v2 1/2] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
From: Carlo Caione <ca...@endlessm.com> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, ...) using hp_wmi_perform_query to perform an HP WMI query shadow the returned value in case of error. We return -EINVAL only when the HP WMI query returns a positive

[PATCH v2 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-19 Thread Carlo Caione
From: Carlo Caione Several HP laptops cannot be put to sleep using the LID since systemd complains that the system is docked even though the laptop is not even dockable (see [1]). This is due to a bug in hp-wmi where the driver is failing to check for errors before creating the input switches

[PATCH v2 1/2] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
From: Carlo Caione All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, ...) using hp_wmi_perform_query to perform an HP WMI query shadow the returned value in case of error. We return -EINVAL only when the HP WMI query returns a positive value (the specific error code

  1   2   3   >