Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-06-07 Thread Catalin Marinas
On Wed, Jun 07, 2017 at 04:32:28PM +0100, Punit Agrawal wrote: > Will Deacon writes: > > On Wed, Jun 07, 2017 at 03:30:37PM +0100, Catalin Marinas wrote: > >> On Wed, Jun 07, 2017 at 02:47:32PM +0100, Will Deacon wrote: > >> > On Wed, May 17, 2017 at 04:23:3

Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-06-07 Thread Catalin Marinas
> > Signed-off-by: Punit Agrawal <punit.agra...@arm.com> > Acked-by: Steve Capper <steve.cap...@arm.com> > Cc: Catalin Marinas <catalin.mari...@arm.com> > Cc: David Woods <dwo...@mellanox.com> Since the patch matches my suggestions in v1: Reviewed-by: Catalin Marinas <catalin.mari...@arm.com>

Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-06-07 Thread Catalin Marinas
> > Signed-off-by: Punit Agrawal > Acked-by: Steve Capper > Cc: Catalin Marinas > Cc: David Woods Since the patch matches my suggestions in v1: Reviewed-by: Catalin Marinas

Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-06-07 Thread Catalin Marinas
On Wed, Jun 07, 2017 at 02:47:32PM +0100, Will Deacon wrote: > On Wed, May 17, 2017 at 04:23:34PM +0100, Punit Agrawal wrote: > > --- a/arch/arm64/mm/hugetlbpage.c > > +++ b/arch/arm64/mm/hugetlbpage.c > > @@ -136,36 +136,27 @@ pte_t *huge_pte_offset(struct mm_struct *mm, unsigned > > long addr)

Re: [PATCH v2 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-06-07 Thread Catalin Marinas
On Wed, Jun 07, 2017 at 02:47:32PM +0100, Will Deacon wrote: > On Wed, May 17, 2017 at 04:23:34PM +0100, Punit Agrawal wrote: > > --- a/arch/arm64/mm/hugetlbpage.c > > +++ b/arch/arm64/mm/hugetlbpage.c > > @@ -136,36 +136,27 @@ pte_t *huge_pte_offset(struct mm_struct *mm, unsigned > > long addr)

Re: [PATCH 1/6] arm64, vdso: Define vdso_{start,end} as array

2017-06-06 Thread Catalin Marinas
Signed-off-by: Kees Cook <keesc...@chromium.org> > Cc: Catalin Marinas <catalin.mari...@arm.com> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Jisheng Zhang <jszh...@marvell.com> Acked-by: Catalin Marinas <catalin.mari...@arm.com>

Re: [PATCH 1/6] arm64, vdso: Define vdso_{start,end} as array

2017-06-06 Thread Catalin Marinas
On Mon, Jun 05, 2017 at 09:52:30PM -0700, Kees Cook wrote: > Adjust vdso_{start|end} to be char arrays to avoid compile-time analysis > that flags "too large" memcmp() calls with CONFIG_FORTIFY_SOURCE. > > Suggested-by: Mark Rutland > Signed-off-by: Kees Cook &g

[GIT PULL] arm64 fixes for 4.12-rc4

2017-06-02 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 63a1e1c95e60e798fa09ab3c536fb555aa5bbf2b: arm64/cpufeature: don't use mutex in bringup path (2017-05-17 17:00:29 +0100) are available in the git repository at:

[GIT PULL] arm64 fixes for 4.12-rc4

2017-06-02 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 63a1e1c95e60e798fa09ab3c536fb555aa5bbf2b: arm64/cpufeature: don't use mutex in bringup path (2017-05-17 17:00:29 +0100) are available in the git repository at:

Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 05:21:08PM +0100, Catalin Marinas wrote: > On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote: > > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote: > > > The scan_block() function updates the number of references (pointers

Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 05:21:08PM +0100, Catalin Marinas wrote: > On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote: > > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote: > > > The scan_block() function updates the number of references (pointers

Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote: > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote: > > The scan_block() function updates the number of references (pointers) to > > objects, adding them to the gray_list when object->min_count is reac

Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote: > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote: > > The scan_block() function updates the number of references (pointers) to > > objects, adding them to the gray_list when object->min_count is reac

Re: [PATCH] fork: fix kmemleak false positive due to thread stacks caching

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 02:49:49PM +0100, Luis Henriques wrote: > kmemleak has been reporting memory leaks since commit ac496bf48d97 ("fork: > Optimize task creation by caching two thread stacks per CPU if > CONFIG_VMAP_STACK=y"): > > unreferenced object 0xc92b (size 16384): > comm

Re: [PATCH] fork: fix kmemleak false positive due to thread stacks caching

2017-05-26 Thread Catalin Marinas
On Fri, May 26, 2017 at 02:49:49PM +0100, Luis Henriques wrote: > kmemleak has been reporting memory leaks since commit ac496bf48d97 ("fork: > Optimize task creation by caching two thread stacks per CPU if > CONFIG_VMAP_STACK=y"): > > unreferenced object 0xc92b (size 16384): > comm

[PATCH v3] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-25 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Reported-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Laura Abbott <labb...@redhat.com> Reviewed-by: Robin Murphy <robin.mur...@arm.com> Signed-off-by: Catalin

[PATCH v3] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-25 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Greg Kroah-Hartman Reported-by: Andrzej Hajda Acked-by: Laura Abbott Reviewed-by: Robin Murphy Signed-off-by: Catalin Marinas --- Changes since v2: - Rebased to 4.12-rc2 drivers/base/dma-mapping.c | 33 --

[PATCH v2 1/3] mm: kmemleak: Slightly reduce the size of some structures on 64-bit architectures

2017-05-25 Thread Catalin Marinas
t; Cc: "Luis R. Rodriguez" <mcg...@kernel.org> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- mm/kmemleak.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 20036d4f9f13..964b12eba2c1 100644 --- a

[PATCH v2 1/3] mm: kmemleak: Slightly reduce the size of some structures on 64-bit architectures

2017-05-25 Thread Catalin Marinas
This patch changes the kmemleak_object.flags type to unsigned int and moves the early_log.min_count (int) near early_log.op_type (int) to slightly reduce the size of these structures on 64-bit architectures. Cc: Michal Hocko Cc: Andy Lutomirski Cc: "Luis R. Rodriguez" Signed-off-b

[PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-25 Thread Catalin Marinas
mirski <l...@amacapital.net> Cc: "Luis R. Rodriguez" <mcg...@kernel.org> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- mm/kmemleak.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/mm/kmemleak

[PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block()

2017-05-25 Thread Catalin Marinas
quot; Signed-off-by: Catalin Marinas --- mm/kmemleak.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 964b12eba2c1..266482f460c2 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1188,6 +1188

[PATCH v2 3/3] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-25 Thread Catalin Marinas
by: "Luis R. Rodriguez" <mcg...@kernel.org> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- Documentation/dev-tools/kmemleak.rst | 1 + include/linux/kmemleak.h | 7 +++ mm/kmemleak.c| 93 ++-- mm/v

[PATCH v2 3/3] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-25 Thread Catalin Marinas
reference passing to the actual vmalloc() returned pointer. The __vmalloc_node_range() calling site has been modified accordingly. Cc: Michal Hocko Cc: Andy Lutomirski Cc: "Luis R. Rodriguez" Reported-by: "Luis R. Rodriguez" Signed-off-by: Catalin Marinas --- Documentation/de

[PATCH v2 0/3] mm: kmemleak: Improve vmalloc() false positives for thread stack allocation

2017-05-25 Thread Catalin Marinas
v1: - Split the patch into three for easier review - Only call update_refs() if !color_gray() on the found object, it avoids an unnecessary function call [1] http://lkml.kernel.org/r/1495474514-24425-1-git-send-email-catalin.mari...@arm.com Catalin Marinas (3): mm: kmemleak: Slightly reduce

[PATCH v2 0/3] mm: kmemleak: Improve vmalloc() false positives for thread stack allocation

2017-05-25 Thread Catalin Marinas
v1: - Split the patch into three for easier review - Only call update_refs() if !color_gray() on the found object, it avoids an unnecessary function call [1] http://lkml.kernel.org/r/1495474514-24425-1-git-send-email-catalin.mari...@arm.com Catalin Marinas (3): mm: kmemleak: Slightly reduce

Re: [PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-24 Thread Catalin Marinas
On Tue, May 23, 2017 at 10:37:00PM +0200, Luis R. Rodriguez wrote: > On Mon, May 22, 2017 at 06:35:14PM +0100, Catalin Marinas wrote: > > Kmemleak requires that vmalloc'ed objects have a minimum reference count > > of 2: one in the corresponding vm_struct object and

Re: [PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-24 Thread Catalin Marinas
On Tue, May 23, 2017 at 10:37:00PM +0200, Luis R. Rodriguez wrote: > On Mon, May 22, 2017 at 06:35:14PM +0100, Catalin Marinas wrote: > > Kmemleak requires that vmalloc'ed objects have a minimum reference count > > of 2: one in the corresponding vm_struct object and

Re: [PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-24 Thread Catalin Marinas
On Mon, May 22, 2017 at 11:19:08AM -0700, Andy Lutomirski wrote: > On Mon, May 22, 2017 at 10:35 AM, Catalin Marinas > <catalin.mari...@arm.com> wrote: > > Kmemleak requires that vmalloc'ed objects have a minimum reference count > > of 2: one in the corresponding vm_str

Re: [PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-24 Thread Catalin Marinas
On Mon, May 22, 2017 at 11:19:08AM -0700, Andy Lutomirski wrote: > On Mon, May 22, 2017 at 10:35 AM, Catalin Marinas > wrote: > > Kmemleak requires that vmalloc'ed objects have a minimum reference count > > of 2: one in the corresponding vm_struct object and the other owned

[PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-22 Thread Catalin Marinas
uis R. Rodriguez" <mcg...@kernel.org> Cc: Michal Hocko <mho...@kernel.org> Cc: Andy Lutomirski <l...@amacapital.net> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- Hi, As per [1], I added support to use pointers to vm_struct as an alternative way to avoid false p

[PATCH] mm: kmemleak: Treat vm_struct as alternative reference to vmalloc'ed objects

2017-05-22 Thread Catalin Marinas
uis R. Rodriguez" Cc: Michal Hocko Cc: Andy Lutomirski Signed-off-by: Catalin Marinas --- Hi, As per [1], I added support to use pointers to vm_struct as an alternative way to avoid false positives when the original vmalloc() pointer has been lost. This is slightly harder to reason about but it see

Re: next-20170515: WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:236 note_page+0x630/0x7e0

2017-05-19 Thread Catalin Marinas
On Fri, May 19, 2017 at 05:40:16PM +0200, Luis R. Rodriguez wrote: > If the following is a legit forced way to get query the kernel to ask it > who owns a page then perhaps this technique can be used in the future to > figure out who the hell caused this. Catalin, can you confirm? In this > case

Re: next-20170515: WARNING: CPU: 0 PID: 1 at arch/x86/mm/dump_pagetables.c:236 note_page+0x630/0x7e0

2017-05-19 Thread Catalin Marinas
On Fri, May 19, 2017 at 05:40:16PM +0200, Luis R. Rodriguez wrote: > If the following is a legit forced way to get query the kernel to ask it > who owns a page then perhaps this technique can be used in the future to > figure out who the hell caused this. Catalin, can you confirm? In this > case

[GIT PULL] arm64 fixes for 4.12

2017-05-19 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes

[GIT PULL] arm64 fixes for 4.12

2017-05-19 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 2ea659a9ef488125eb46da6eb571de5eae5c43f6: Linux 4.12-rc1 (2017-05-13 13:19:49 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes

Re: [PATCHv5] arm64/cpufeature: don't use mutex in bringup path

2017-05-17 Thread Catalin Marinas
hen the upcoming hotplug > locking rework is merged. > > Signed-off-by: Mark Rutland <mark.rutl...@arm.com> > Reviewed-by: Marc Zyniger <marc.zyng...@arm.com> > Reviewed-by: Suzuki Poulose <suzuki.poul...@arm.com> > Acked-by: Will Deacon <will.dea...@arm.com>

Re: [PATCHv5] arm64/cpufeature: don't use mutex in bringup path

2017-05-17 Thread Catalin Marinas
hen the upcoming hotplug > locking rework is merged. > > Signed-off-by: Mark Rutland > Reviewed-by: Marc Zyniger > Reviewed-by: Suzuki Poulose > Acked-by: Will Deacon > Cc: Catalin Marinas > Cc: Christoffer Dall > Cc: Peter Zijlstra > Cc: Sebastian Sewior > Cc

Re: [patch V2 03/17] arm64: Adjust system_state check

2017-05-17 Thread Catalin Marinas
extra states. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc: Catalin Marinas <catalin.mari...@arm.com> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Mark Rutland <mark.rutl...@arm.com> > Cc: linux-arm-ker...@lists.infradead.org Acked-by: Catalin Marinas <catalin.mari...@arm.com>

Re: [patch V2 03/17] arm64: Adjust system_state check

2017-05-17 Thread Catalin Marinas
extra states. > > Signed-off-by: Thomas Gleixner > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-ker...@lists.infradead.org Acked-by: Catalin Marinas

Re: kmemleak splat on copy_process()

2017-05-17 Thread Catalin Marinas
On Tue, May 16, 2017 at 04:55:28PM -0700, Andy Lutomirski wrote: > On Tue, May 16, 2017 at 6:39 AM, Catalin Marinas > <catalin.mari...@arm.com> wrote: > > Thanks for cc'ing me. The vmalloc allocations have always been tricky > > for kmemleak since there are 2-3 other memory

Re: kmemleak splat on copy_process()

2017-05-17 Thread Catalin Marinas
On Tue, May 16, 2017 at 04:55:28PM -0700, Andy Lutomirski wrote: > On Tue, May 16, 2017 at 6:39 AM, Catalin Marinas > wrote: > > Thanks for cc'ing me. The vmalloc allocations have always been tricky > > for kmemleak since there are 2-3 other memory locations with

Re: kmemleak splat on copy_process()

2017-05-16 Thread Catalin Marinas
Thanks for cc'ing me. The vmalloc allocations have always been tricky for kmemleak since there are 2-3 other memory locations with the same value as the vmalloc'ed object: vm_struct.addr and vmap_area.va_start; occasionally we have vmap_area.va_end pointing to the next vmap_area.va_start. To have

Re: kmemleak splat on copy_process()

2017-05-16 Thread Catalin Marinas
Thanks for cc'ing me. The vmalloc allocations have always been tricky for kmemleak since there are 2-3 other memory locations with the same value as the vmalloc'ed object: vm_struct.addr and vmap_area.va_start; occasionally we have vmap_area.va_end pointing to the next vmap_area.va_start. To have

[GIT PULL] arm64 2nd set of updates for 4.12

2017-05-11 Thread Catalin Marinas
Hi Linus, Please pull the arm64 updates below. The mm/vmalloc.c change was acked by Michal Hocko and the arch/arm one by Russell King. Thanks. The following changes since commit 92f66f84d9695d07adf9bc987bbcce4bf9b8e87c: arm64: Fix the DMA mmap and get_sgtable API with

[GIT PULL] arm64 2nd set of updates for 4.12

2017-05-11 Thread Catalin Marinas
Hi Linus, Please pull the arm64 updates below. The mm/vmalloc.c change was acked by Michal Hocko and the arch/arm one by Russell King. Thanks. The following changes since commit 92f66f84d9695d07adf9bc987bbcce4bf9b8e87c: arm64: Fix the DMA mmap and get_sgtable API with

Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

2017-05-11 Thread Catalin Marinas
On Wed, May 10, 2017 at 12:55:12PM +0100, Will Deacon wrote: > On Wed, May 10, 2017 at 09:38:03AM +0100, Catalin Marinas wrote: > > On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote: > > > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote: > > &g

Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

2017-05-11 Thread Catalin Marinas
On Wed, May 10, 2017 at 12:55:12PM +0100, Will Deacon wrote: > On Wed, May 10, 2017 at 09:38:03AM +0100, Catalin Marinas wrote: > > On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote: > > > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote: > > &g

Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

2017-05-10 Thread Catalin Marinas
On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote: > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote: > > On 05/03/2017 04:18 AM, Will Deacon wrote: > > > On Thu, Apr 27, 2017 at 11:19:02AM -0700, Florian Fainelli wrote: > > >> When CONFIG_ARM64_MODULE_PLTS is enabled,

Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

2017-05-10 Thread Catalin Marinas
On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote: > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote: > > On 05/03/2017 04:18 AM, Will Deacon wrote: > > > On Thu, Apr 27, 2017 at 11:19:02AM -0700, Florian Fainelli wrote: > > >> When CONFIG_ARM64_MODULE_PLTS is enabled,

Re: [GIT PULL] arm64 updates for 4.12

2017-05-05 Thread Catalin Marinas
On Fri, May 05, 2017 at 12:38:32PM -0700, Linus Torvalds wrote: > On Fri, May 5, 2017 at 9:13 AM, Catalin Marinas <catalin.mari...@arm.com> > wrote: > > diff --cc arch/arm64/include/asm/bug.h > > Hmm. The trivial resolution I did gets a different diff as the end >

Re: [GIT PULL] arm64 updates for 4.12

2017-05-05 Thread Catalin Marinas
On Fri, May 05, 2017 at 12:38:32PM -0700, Linus Torvalds wrote: > On Fri, May 5, 2017 at 9:13 AM, Catalin Marinas > wrote: > > diff --cc arch/arm64/include/asm/bug.h > > Hmm. The trivial resolution I did gets a different diff as the end > result, but your diff looks differ

[GIT PULL] arm64 updates for 4.12

2017-05-05 Thread Catalin Marinas
remove pointless dummy .reloc section arm64: efi: replace open coded constants with symbolic ones arm64: efi: split Image code and data into separate PE/COFF sections arm64: module: split core and init PLT sections Arnd Bergmann (1): arm64: define BUG() instruction without CON

[GIT PULL] arm64 updates for 4.12

2017-05-05 Thread Catalin Marinas
remove pointless dummy .reloc section arm64: efi: replace open coded constants with symbolic ones arm64: efi: split Image code and data into separate PE/COFF sections arm64: module: split core and init PLT sections Arnd Bergmann (1): arm64: define BUG() instruction without CON

Re: [PATCH] [v2] MAINTAINERS: arm64 defconfig changes should go to a...@kernel.org

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 11:52:26AM -0500, Timur Tabi wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 58590cf..5d15858 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2066,6 +2066,11 @@ S: Maintained > F: arch/arm64/ > F: Documentation/arm64/ > > +ARM64 DEFCONFIG > +M:

Re: [PATCH] [v2] MAINTAINERS: arm64 defconfig changes should go to a...@kernel.org

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 11:52:26AM -0500, Timur Tabi wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 58590cf..5d15858 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2066,6 +2066,11 @@ S: Maintained > F: arch/arm64/ > F: Documentation/arm64/ > > +ARM64 DEFCONFIG > +M:

Re: [PATCH] MAINTAINERS: add a...@kernel.org as the list for arm64 defconfig changes

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 12:08:21PM -0500, Timur Tabi wrote: > On 05/03/2017 12:01 PM, Catalin Marinas wrote: > > On Wed, May 03, 2017 at 11:31:25AM -0500, Timur Tabi wrote: > >> > Any changes to arch/arm64/configs/defconfig must be sent to > >> >

Re: [PATCH] MAINTAINERS: add a...@kernel.org as the list for arm64 defconfig changes

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 12:08:21PM -0500, Timur Tabi wrote: > On 05/03/2017 12:01 PM, Catalin Marinas wrote: > > On Wed, May 03, 2017 at 11:31:25AM -0500, Timur Tabi wrote: > >> > Any changes to arch/arm64/configs/defconfig must be sent to > >> >

Re: [PATCH] MAINTAINERS: add a...@kernel.org as the list for arm64 defconfig changes

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 11:31:25AM -0500, Timur Tabi wrote: > Any changes to arch/arm64/configs/defconfig must be sent to a...@kernel.org, > otherwise they will not get picked up. Add a MAINTAINERS entry to ensure > the get_maintainers includes it. There are other patches that go through

Re: [PATCH] MAINTAINERS: add a...@kernel.org as the list for arm64 defconfig changes

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 11:31:25AM -0500, Timur Tabi wrote: > Any changes to arch/arm64/configs/defconfig must be sent to a...@kernel.org, > otherwise they will not get picked up. Add a MAINTAINERS entry to ensure > the get_maintainers includes it. There are other patches that go through

[PATCH v2] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-03 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Reported-by: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Laura Abbott <labb...@redhat.com> Reviewed-by: Robin Murphy <robin.mur...@arm.com> Signed-off-by: Cata

[PATCH v2] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-03 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Greg Kroah-Hartman Reported-by: Andrzej Hajda Acked-by: Laura Abbott Reviewed-by: Robin Murphy Signed-off-by: Catalin Marinas --- Greg, Please merge this patch via your tree (and therefore I haven't added your ack). Thanks. Ch

Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 01:10:26PM +0100, Robin Murphy wrote: > On 25/04/17 19:22, Catalin Marinas wrote: > > The dma_common_pages_remap() function allocates a vm_struct object and > > initialises the pages pointer to value passed as argument. However, when > > th

Re: [PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-05-03 Thread Catalin Marinas
On Wed, May 03, 2017 at 01:10:26PM +0100, Robin Murphy wrote: > On 25/04/17 19:22, Catalin Marinas wrote: > > The dma_common_pages_remap() function allocates a vm_struct object and > > initialises the pages pointer to value passed as argument. However, when > > th

Re: [PATCH 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-05-03 Thread Catalin Marinas
> > Signed-off-by: Punit Agrawal <punit.agra...@arm.com> > Cc: Catalin Marinas <catalin.mari...@arm.com> > Cc: Steve Capper <steve.cap...@arm.com> > Cc: David Woods <dwo...@mellanox.com> > --- > arch/arm64/mm/hugetlbpage.c | 20 +++- >

Re: [PATCH 1/3] arm64: hugetlb: Fix huge_pte_offset to return poisoned page table entries

2017-05-03 Thread Catalin Marinas
> > Signed-off-by: Punit Agrawal > Cc: Catalin Marinas > Cc: Steve Capper > Cc: David Woods > --- > arch/arm64/mm/hugetlbpage.c | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/a

Re: [PATCH] Remove ARM errata Workarounds 458693 and 460075

2017-05-02 Thread Catalin Marinas
On Tue, May 02, 2017 at 01:27:54PM +0100, Robin Murphy wrote: > On 18/04/17 16:57, Catalin Marinas wrote: > > On Sun, Apr 16, 2017 at 09:04:46AM +0100, Russell King - ARM Linux wrote: > >> On Sat, Apr 15, 2017 at 07:06:06PM -0500, Nisal Menuka wrote: > >>> According t

Re: [PATCH] Remove ARM errata Workarounds 458693 and 460075

2017-05-02 Thread Catalin Marinas
On Tue, May 02, 2017 at 01:27:54PM +0100, Robin Murphy wrote: > On 18/04/17 16:57, Catalin Marinas wrote: > > On Sun, Apr 16, 2017 at 09:04:46AM +0100, Russell King - ARM Linux wrote: > >> On Sat, Apr 15, 2017 at 07:06:06PM -0500, Nisal Menuka wrote: > >>> According t

Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo

2017-05-02 Thread Catalin Marinas
On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote: > There is no need to hide the model name in processes > that are not PER_LINUX32. > > So let us always provide a model name that is easily readable. > > Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for >

Re: [PATCH 1/1] arm64: Always provide "model name" in /proc/cpuinfo

2017-05-02 Thread Catalin Marinas
On Tue, May 02, 2017 at 12:39:13AM +0200, Heinrich Schuchardt wrote: > There is no need to hide the model name in processes > that are not PER_LINUX32. > > So let us always provide a model name that is easily readable. > > Fixes: e47b020a323d ("arm64: Provide "model name" in /proc/cpuinfo for >

Re: [PATCH] arm64: Print DT machine model in setup_machine_fdt()

2017-04-28 Thread Catalin Marinas
On Thu, Apr 27, 2017 at 02:33:05PM +0200, Geert Uytterhoeven wrote: > On arm32, the machine model specified in the device tree is printed > during boot-up, courtesy of of_flat_dt_match_machine(). > > On arm64, of_flat_dt_match_machine() is not called, and the machine > model information is not

Re: [PATCH] arm64: Print DT machine model in setup_machine_fdt()

2017-04-28 Thread Catalin Marinas
On Thu, Apr 27, 2017 at 02:33:05PM +0200, Geert Uytterhoeven wrote: > On arm32, the machine model specified in the device tree is printed > during boot-up, courtesy of of_flat_dt_match_machine(). > > On arm64, of_flat_dt_match_machine() is not called, and the machine > model information is not

Re: [PATCH 2/2] arm64: pmu: Wire-up L2 cache events for ARMv8 PMUv3

2017-04-28 Thread Catalin Marinas
On Thu, Apr 27, 2017 at 06:36:42PM +0100, Will Deacon wrote: > On Tue, Apr 25, 2017 at 10:13:51AM -0700, Florian Fainelli wrote: > > On 04/25/2017 05:44 AM, Will Deacon wrote: > > > On Thu, Apr 20, 2017 at 12:05:46PM -0700, Florian Fainelli wrote: > > >> The ARMv8 PMUv3 cache map did not include

Re: [PATCH 2/2] arm64: pmu: Wire-up L2 cache events for ARMv8 PMUv3

2017-04-28 Thread Catalin Marinas
On Thu, Apr 27, 2017 at 06:36:42PM +0100, Will Deacon wrote: > On Tue, Apr 25, 2017 at 10:13:51AM -0700, Florian Fainelli wrote: > > On 04/25/2017 05:44 AM, Will Deacon wrote: > > > On Thu, Apr 20, 2017 at 12:05:46PM -0700, Florian Fainelli wrote: > > >> The ARMv8 PMUv3 cache map did not include

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Catalin Marinas
On Wed, Apr 26, 2017 at 10:00:30AM -0700, Stefano Stabellini wrote: > On Wed, 26 Apr 2017, Catalin Marinas wrote: > > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > > On Tue, 25 Apr 2017, Julien Grall wrote: > > > > On 24/04/17 2

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Catalin Marinas
On Wed, Apr 26, 2017 at 10:00:30AM -0700, Stefano Stabellini wrote: > On Wed, 26 Apr 2017, Catalin Marinas wrote: > > On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > > > On Tue, 25 Apr 2017, Julien Grall wrote: > > > > On 24/04/17 2

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > On Tue, 25 Apr 2017, Julien Grall wrote: > > On 24/04/17 20:16, Stefano Stabellini wrote: > > > Given the outstanding regression we need to fix as soon as possible, > > > I'll queue these patches on the xentip tree for 4.12. > >

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-26 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 10:22:00AM -0700, Stefano Stabellini wrote: > On Tue, 25 Apr 2017, Julien Grall wrote: > > On 24/04/17 20:16, Stefano Stabellini wrote: > > > Given the outstanding regression we need to fix as soon as possible, > > > I'll queue these patches on the xentip tree for 4.12. > >

Re: [RFC PATCH] drivers: dma-mapping: Do not attempt to create a scatterlist for from_coherent buffers

2017-04-25 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 07:05:26PM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 25, 2017 at 06:57:39PM +0100, Catalin Marinas wrote: > > Memory returned by dma_alloc_from_coherent() is not backed by struct > > page and creating a scatterlist would use invalid page pointers

Re: [RFC PATCH] drivers: dma-mapping: Do not attempt to create a scatterlist for from_coherent buffers

2017-04-25 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 07:05:26PM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 25, 2017 at 06:57:39PM +0100, Catalin Marinas wrote: > > Memory returned by dma_alloc_from_coherent() is not backed by struct > > page and creating a scatterlist would use invalid page pointers

Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-04-25 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote: > The dma_common_pages_remap() function allocates a vm_struct object and > initialises the pages pointer to value passed as argument. However, when > this function is called dma_common_contiguous_remap(), the pages array

Re: [PATCH] drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-04-25 Thread Catalin Marinas
On Tue, Apr 25, 2017 at 07:22:23PM +0100, Catalin Marinas wrote: > The dma_common_pages_remap() function allocates a vm_struct object and > initialises the pages pointer to value passed as argument. However, when > this function is called dma_common_contiguous_remap(), the pages array

[PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-04-25 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Laura Abbott <labb...@redhat.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Reported-by: Andrzej Hajda <a.ha...@samsung.com> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- This

[PATCH] arm64: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

2017-04-25 Thread Catalin Marinas
ommon: dma-mapping: introduce common remapping functions") Cc: Laura Abbott Cc: Greg Kroah-Hartman Reported-by: Andrzej Hajda Signed-off-by: Catalin Marinas --- This is for correctness since once the arm64's mmap and get_sgtable ops are fixed for DMA_ATTR_FORCE_CONTIGUOUS, we would no longe

[RFC PATCH] drivers: dma-mapping: Do not attempt to create a scatterlist for from_coherent buffers

2017-04-25 Thread Catalin Marinas
pping: introduce dma_get_sgtable() function") Cc: Marek Szyprowski <m.szyprow...@samsung.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Russell King - ARM Linux <li...@arm.linux.org.uk> Signed-off-by: Catalin Marinas <catalin.mari...@arm.com> --- In a recent d

[RFC PATCH] drivers: dma-mapping: Do not attempt to create a scatterlist for from_coherent buffers

2017-04-25 Thread Catalin Marinas
pping: introduce dma_get_sgtable() function") Cc: Marek Szyprowski Cc: Greg Kroah-Hartman Cc: Russell King - ARM Linux Signed-off-by: Catalin Marinas --- In a recent discussion around the iommu DMA ops on arm64, Russell pointed out that dma_get_sgtable is not safe since the coherent

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 04:58:41PM +0100, Catalin Marinas wrote: > On Mon, Apr 24, 2017 at 04:40:23PM +0100, Will Deacon wrote: > > On Wed, Apr 19, 2017 at 11:33:14AM +0100, Catalin Marinas wrote: > > > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: > > &g

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 04:58:41PM +0100, Catalin Marinas wrote: > On Mon, Apr 24, 2017 at 04:40:23PM +0100, Will Deacon wrote: > > On Wed, Apr 19, 2017 at 11:33:14AM +0100, Catalin Marinas wrote: > > > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: > > &g

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 04:40:23PM +0100, Will Deacon wrote: > On Wed, Apr 19, 2017 at 11:33:14AM +0100, Catalin Marinas wrote: > > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: > > > On 18 April 2017 at 18:01, Catalin Marinas <catalin.mari...@arm.com> >

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 04:40:23PM +0100, Will Deacon wrote: > On Wed, Apr 19, 2017 at 11:33:14AM +0100, Catalin Marinas wrote: > > On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: > > > On 18 April 2017 at 18:01, Catalin Marinas > > > wrote: > >

Re: [PATCH 1/2] arm64:vdso: Rewrite gettimeofday into C.

2017-04-24 Thread Catalin Marinas
On Sun, Apr 23, 2017 at 04:47:00PM -0700, Andrew Pinski wrote: > This allows the compiler to optimize the divide by 1000. > And remove the other divide. > > On ThunderX, gettimeofday improves by 32%. On ThunderX 2, > gettimeofday improves by 18%. Is this with or without the second patch

Re: [PATCH 1/2] arm64:vdso: Rewrite gettimeofday into C.

2017-04-24 Thread Catalin Marinas
On Sun, Apr 23, 2017 at 04:47:00PM -0700, Andrew Pinski wrote: > This allows the compiler to optimize the divide by 1000. > And remove the other divide. > > On ThunderX, gettimeofday improves by 32%. On ThunderX 2, > gettimeofday improves by 18%. Is this with or without the second patch

Re: [PATCH v3 15/18] arm64: arch_timer: Enable CNTVCT_EL0 trap if workaround is enabled

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 10:33:29AM +0100, Marc Zyngier wrote: > On 24/04/17 10:14, Hanjun Guo wrote: > > On 2017/4/24 16:40, Marc Zyngier wrote: > >> On 24/04/17 09:25, Lixiaoping (Timmy) wrote: > >>> Sorry about previous email's confidential info. Please forget it. > >>> > >>> +#define

Re: [PATCH v3 15/18] arm64: arch_timer: Enable CNTVCT_EL0 trap if workaround is enabled

2017-04-24 Thread Catalin Marinas
On Mon, Apr 24, 2017 at 10:33:29AM +0100, Marc Zyngier wrote: > On 24/04/17 10:14, Hanjun Guo wrote: > > On 2017/4/24 16:40, Marc Zyngier wrote: > >> On 24/04/17 09:25, Lixiaoping (Timmy) wrote: > >>> Sorry about previous email's confidential info. Please forget it. > >>> > >>> +#define

Re: [PATCH 2/3] bus: fsl-mc: dpio: enable qbman CENA portal memory access

2017-04-21 Thread Catalin Marinas
On Thu, Apr 20, 2017 at 03:34:17PM -0400, Haiying Wang wrote: > Once we enable the cacheable portal memory, we need to do > cache flush for enqueue, vdq, buffer release, and management > commands, as well as invalidate and prefetch for the valid bit > of management command response and next index

Re: [PATCH 2/3] bus: fsl-mc: dpio: enable qbman CENA portal memory access

2017-04-21 Thread Catalin Marinas
On Thu, Apr 20, 2017 at 03:34:17PM -0400, Haiying Wang wrote: > Once we enable the cacheable portal memory, we need to do > cache flush for enqueue, vdq, buffer release, and management > commands, as well as invalidate and prefetch for the valid bit > of management command response and next index

Re: [PATCH v4 03/21] ARM64: implement pci_remap_cfgspace() interface

2017-04-20 Thread Catalin Marinas
; that allows to map PCI config region with nGnRnE attributes, providing > a remap function that complies with PCI specifications and the ARMv8 > architecture reference manual recommendations. > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieral...@arm.com> > Cc: Will Deacon <wi

Re: [PATCH v4 03/21] ARM64: implement pci_remap_cfgspace() interface

2017-04-20 Thread Catalin Marinas
; that allows to map PCI config region with nGnRnE attributes, providing > a remap function that complies with PCI specifications and the ARMv8 > architecture reference manual recommendations. > > Signed-off-by: Lorenzo Pieralisi > Cc: Will Deacon > Cc: Catalin Marinas Acked-by: Catalin Marinas

Re: [PATCH] Revert "arm64: Increase the max granular size"

2017-04-19 Thread Catalin Marinas
On Tue, Apr 18, 2017 at 10:35:02PM +0530, Sunil Kovvuri wrote: > On Tue, Apr 18, 2017 at 8:18 PM, Catalin Marinas > <catalin.mari...@arm.com> wrote: > > On Mon, Apr 17, 2017 at 04:08:52PM +0530, Sunil Kovvuri wrote: > >> >> >> Do you have an explan

Re: [PATCH] Revert "arm64: Increase the max granular size"

2017-04-19 Thread Catalin Marinas
On Tue, Apr 18, 2017 at 10:35:02PM +0530, Sunil Kovvuri wrote: > On Tue, Apr 18, 2017 at 8:18 PM, Catalin Marinas > wrote: > > On Mon, Apr 17, 2017 at 04:08:52PM +0530, Sunil Kovvuri wrote: > >> >> >> Do you have an explanation on the performance variation w

Re: [PATCH] fs: Preventing READ_IMPLIES_EXEC Propagation

2017-04-19 Thread Catalin Marinas
On Tue, Apr 18, 2017 at 09:01:52PM +0100, Peter Maydell wrote: > On 18 April 2017 at 18:01, Catalin Marinas <catalin.mari...@arm.com> wrote: > > On Thu, Apr 13, 2017 at 08:33:52PM +0800, dongbo (E) wrote: > >> From: Dong Bo <dong...@huawei.com> > &

<    11   12   13   14   15   16   17   18   19   20   >