[PATCH] ARM: s3c24xx: fix usage of pr_info/pr_cont

This commit fixes the wrong usage of pr_info introduced by the commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in mach-mini2440.c"). Since the idea is to print on a single line, pr_cont has to be used. Signed-off-by: Cedric Roux --- arch/arm/mach-s3c24xx/mach-mini2440.c | 6

[PATCH] ARM: s3c24xx: fix usage of pr_info/pr_cont

This commit fixes the wrong usage of pr_info introduced by the commit e728e4f20100 ("ARM: s3c24xx: formatting cleanup in mach-mini2440.c"). Since the idea is to print on a single line, pr_cont has to be used. Signed-off-by: Cedric Roux --- arch/arm/mach-s3c24xx/mach-mini2440.c | 6

Re: [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

Hi, On 09/12/2018 09:21 PM, Joe Perches wrote: > On Fri, 2018-09-07 at 23:54 +0200, Cedric Roux wrote: >> Running: >> scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c >> revealed several errors and warnings. >> >> They were all removed, ex

Re: [PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

Hi, On 09/12/2018 09:21 PM, Joe Perches wrote: > On Fri, 2018-09-07 at 23:54 +0200, Cedric Roux wrote: >> Running: >> scripts/checkpatch.pl -f arch/arm/mach-s3c24xx/mach-mini2440.c >> revealed several errors and warnings. >> >> They were all removed, ex

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { >> - .gpio_detect = S3C2410_GPG(8), >> - .gpio_wprotect = S3C2410_GPH(8), >> - .set_power = NULL, >> - .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,

Re: [PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

On 09/10/2018 12:23 PM, Krzysztof Kozlowski wrote: >> static struct s3c24xx_mci_pdata mini2440_mmc_cfg __initdata = { >> - .gpio_detect = S3C2410_GPG(8), >> - .gpio_wprotect = S3C2410_GPH(8), >> - .set_power = NULL, >> - .ocr_avail = MMC_VDD_32_33|MMC_VDD_33_34,

[PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of t

[PATCH v3 2/2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of t

[PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

. 'printk' was replaced by 'pr_info'. Signed-off-by: Cedric Roux --- arch/arm/mach-s3c24xx/mach-mini2440.c | 80 ++- 1 file changed, 43 insertions(+), 37 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c index

[PATCH v3 1/2] ARM: s3c24xx: formatting cleanup in mach-mini2440.c

. 'printk' was replaced by 'pr_info'. Signed-off-by: Cedric Roux --- arch/arm/mach-s3c24xx/mach-mini2440.c | 80 ++- 1 file changed, 43 insertions(+), 37 deletions(-) diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c index

[PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of t

[PATCH v2] ARM: s3c24xx: Correct SD card write protect detection on Mini2440

The mini2440 computer uses "active high" to signal that the "write protect" of the inserted MMC is set. The current code uses the opposite, leading to a wrong detection of write protection. The solution is simply to use ".wprotect_invert = 1" in the description of t