Re: [PATCH 6/6] scsi: qedf: use correct strncpy() size

arndb.de> > --- > drivers/scsi/qedf/qedf_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reasonable security precaution. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH 6/6] scsi: qedf: use correct strncpy() size

> drivers/scsi/qedf/qedf_dbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reasonable security precaution. Acked-by: Chad Dupuis

Re: [PATCH 4/6] scsi: qedf: fix LTO-enabled build

/scsi/qedf/qedf_dbg.h | 17 ++--- > drivers/scsi/qedf/qedf_debugfs.c | 6 +++--- > drivers/scsi/qedf/qedf_main.c| 8 +++- > 3 files changed, 16 insertions(+), 15 deletions(-) > Thanks. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH 4/6] scsi: qedf: fix LTO-enabled build

qedf_dbg.h | 17 ++--- > drivers/scsi/qedf/qedf_debugfs.c | 6 +++--- > drivers/scsi/qedf/qedf_main.c| 8 +++----- > 3 files changed, 16 insertions(+), 15 deletions(-) > Thanks. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

struct qedf_rport *fcport; > struct qedf_ioreq *io_req; > int rc = 0; > int rval; > Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: qedf: remove redundant initialization of 'fcport'

ort_priv(lport); > struct fc_rport *rport = starget_to_rport(scsi_target(sc_cmd->device)); > struct fc_rport_libfc_priv *rp = rport->dd_data; > - struct qedf_rport *fcport = rport->dd_data; > + struct qedf_rport *fcport; > struct qedf_ioreq *io_req; > int rc = 0; > int rval; > Acked-by: Chad Dupuis

Re: [PATCH 7/9] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

t;confq_mem_size / CNIC_PAGE_SIZE; > page = tgt->confq_dma; > pbl = (u32 *)tgt->confq_pbl; > @@ -792,15 +787,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > /* Allocate and map ConnDB */ > tgt->conn_db_mem_size = sizeof(struct fcoe_conn_db); > > - tgt->conn_db = dma_alloc_coherent(>pcidev->dev, > - tgt->conn_db_mem_size, > - >conn_db_dma, GFP_KERNEL); > + tgt->conn_db = dma_zalloc_coherent(>pcidev->dev, > +tgt->conn_db_mem_size, > +>conn_db_dma, GFP_KERNEL); > if (!tgt->conn_db) { > printk(KERN_ERR PFX "unable to allocate conn_db %d\n", > tgt->conn_db_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->conn_db, 0, tgt->conn_db_mem_size); > > > /* Allocate and map LCQ */ > @@ -808,15 +802,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > tgt->lcq_mem_size = (tgt->lcq_mem_size + (CNIC_PAGE_SIZE - 1)) & >CNIC_PAGE_MASK; > > - tgt->lcq = dma_alloc_coherent(>pcidev->dev, tgt->lcq_mem_size, > - >lcq_dma, GFP_KERNEL); > + tgt->lcq = dma_zalloc_coherent(>pcidev->dev, tgt->lcq_mem_size, > +>lcq_dma, GFP_KERNEL); > > if (!tgt->lcq) { > printk(KERN_ERR PFX "unable to allocate lcq %d\n", > tgt->lcq_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->lcq, 0, tgt->lcq_mem_size); > > tgt->conn_db->rq_prod = 0x8000; > > Conversion looks sane. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH 7/9] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

q_dma; > pbl = (u32 *)tgt->confq_pbl; > @@ -792,15 +787,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > /* Allocate and map ConnDB */ > tgt->conn_db_mem_size = sizeof(struct fcoe_conn_db); > > - tgt->conn_db = dma_alloc_coherent(>pcidev->dev, > - tgt->conn_db_mem_size, > - >conn_db_dma, GFP_KERNEL); > + tgt->conn_db = dma_zalloc_coherent(>pcidev->dev, > +tgt->conn_db_mem_size, > +>conn_db_dma, GFP_KERNEL); > if (!tgt->conn_db) { > printk(KERN_ERR PFX "unable to allocate conn_db %d\n", > tgt->conn_db_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->conn_db, 0, tgt->conn_db_mem_size); > > > /* Allocate and map LCQ */ > @@ -808,15 +802,14 @@ static int bnx2fc_alloc_session_resc(struct bnx2fc_hba > *hba, > tgt->lcq_mem_size = (tgt->lcq_mem_size + (CNIC_PAGE_SIZE - 1)) & >CNIC_PAGE_MASK; > > - tgt->lcq = dma_alloc_coherent(>pcidev->dev, tgt->lcq_mem_size, > - >lcq_dma, GFP_KERNEL); > + tgt->lcq = dma_zalloc_coherent(>pcidev->dev, tgt->lcq_mem_size, > +>lcq_dma, GFP_KERNEL); > > if (!tgt->lcq) { > printk(KERN_ERR PFX "unable to allocate lcq %d\n", > tgt->lcq_mem_size); > goto mem_alloc_failure; > } > - memset(tgt->lcq, 0, tgt->lcq_mem_size); > > tgt->conn_db->rq_prod = 0x8000; > > Conversion looks sane. Acked-by: Chad Dupuis

Re: [PATCH 1/1] scsi: bnx: use setup_timer

FC_FLAG_DESTROY_CMPL, > The title of the patch should be fixed up since the driver is 'bnx2fc'. But besides that nit the patch looks good. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH 1/1] scsi: bnx: use setup_timer

e title of the patch should be fixed up since the driver is 'bnx2fc'. But besides that nit the patch looks good. Acked-by: Chad Dupuis

Re: [PATCH v2] scsi: qedf: Limit number of CQs

t the number of requested CQs.. > > Fixes: 3c5da9427802 ("qed: Share additional information with qedf") > Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse.de> > --- > > Changes in v2: > - integrated suggested change from Chad Dupuis >

Re: [PATCH v2] scsi: qedf: Limit number of CQs

CQs.. > > Fixes: 3c5da9427802 ("qed: Share additional information with qedf") > Signed-off-by: Thomas Bogendoerfer > --- > > Changes in v2: > - integrated suggested change from Chad Dupuis > > drivers/scsi/qedf/qedf.h | 3 ++- > drivers/scsi/qedf/qe

Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code

++- > drivers/scsi/bnx2i/bnx2i_init.c | 64 --- > include/linux/cpuhotplug.h|2 - > 4 files changed, 53 insertions(+), 126 deletions(-) > We tested the series and everything was fine. Ack to the series. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code

++- > drivers/scsi/bnx2i/bnx2i_init.c | 64 --- > include/linux/cpuhotplug.h|2 - > 4 files changed, 53 insertions(+), 126 deletions(-) > We tested the series and everything was fine. Ack to the series. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Limit number of CQs

On Thu, 13 Jul 2017, 12:19pm, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > FCOE offloading on qedf devices fails with: > > [qed_sp_fcoe_func_start:150(sp-0-3b:00.02)]Cannot satisfy CQ amount. CQs >requested 8, CQs available 6. Aborting

Re: [PATCH] scsi: qedf: Limit number of CQs

On Thu, 13 Jul 2017, 12:19pm, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > FCOE offloading on qedf devices fails with: > > [qed_sp_fcoe_func_start:150(sp-0-3b:00.02)]Cannot satisfy CQ amount. CQs >requested 8, CQs available 6. Aborting function start >

Re: [PATCH][V2] scsi: qedf: fix spelling mistake: "offlading" -> "offloading"

, QEDF_LOG_DISC, > - "Not offlading since since spp type isn't FCP\n"); > + "Not offloading since spp type isn't FCP\n"); > break; > } > if (!(rdata->ids.roles & FC_RPORT_ROLE_FCP_TARGET)) { > Thanks. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH][V2] scsi: qedf: fix spelling mistake: "offlading" -> "offloading"

ince since spp type isn't FCP\n"); > + "Not offloading since spp type isn't FCP\n"); > break; > } > if (!(rdata->ids.roles & FC_RPORT_ROLE_FCP_TARGET)) { > Thanks. Acked-by: Chad Dupuis

Re: [PATCH 0/3] scsi: qedf: Fix a return value + some cleanups

(-) > > All are sensible small improvements. Ack the series. series-acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH 0/3] scsi: qedf: Fix a return value + some cleanups

(-) > > All are sensible small improvements. Ack the series. series-acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Avoid reading past end of buffer

> > > > Although this patch looks fine to me, isn't strlcpy() preferred over > > strncpy()? > > strlcpy doesn't zero-pad, so I think strncpy is preferred here, > otherwise we may risk leaving portions of the destination buffer > filled with uninitialized data, maybe leaking kernel memory contents. > > -Kees > I'd agree with strncpy so we zero out the rest of the buffer. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: qedf: Avoid reading past end of buffer

s patch looks fine to me, isn't strlcpy() preferred over > > strncpy()? > > strlcpy doesn't zero-pad, so I think strncpy is preferred here, > otherwise we may risk leaving portions of the destination buffer > filled with uninitialized data, maybe leaking kernel memory contents. > > -Kees > I'd agree with strncpy so we zero out the rest of the buffer. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: properly update arguments position in function call

> FC_TYPE_ELS, FC_FC_FIRST_SEQ | FC_FC_END_SEQ | > FC_FC_SEQ_INIT, 0); > > Thanks. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: qedf: properly update arguments position in function call

ST_SEQ | FC_FC_END_SEQ | > FC_FC_SEQ_INIT, 0); > > Thanks. Acked-by: Chad Dupuis

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 2:36pm, Randy Dunlap wrote: > On 05/03/17 11:29, Chad Dupuis wrote: > > > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > > >> > >> Hello everybody, > >> > >> While looking into Coverity ID 1402011 I r

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 2:36pm, Randy Dunlap wrote: > On 05/03/17 11:29, Chad Dupuis wrote: > > > > On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > > >> > >> Hello everybody, > >> > >> While looking into Coverity ID 1402011 I r

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402011 I ran into the following piece of code > at drivers/scsi/qedf/qedf_io.c:2057: > > /* Fill FC header */ > fc_hdr = &(tm_req->req_fc_hdr); > sid = fcport->sid; > did =

Re: [scsi-qedf] question about parameter ordering

On Wed, 3 May 2017, 1:58pm, Gustavo A. R. Silva wrote: > > Hello everybody, > > While looking into Coverity ID 1402011 I ran into the following piece of code > at drivers/scsi/qedf/qedf_io.c:2057: > > /* Fill FC header */ > fc_hdr = &(tm_req->req_fc_hdr); > sid = fcport->sid; > did =

Re: [PATCH] scsi: libfc: directly call ELS request handlers

it more obvious. > > Signed-off-by: Johannes Thumshirn <jthumsh...@suse.de> > --- > drivers/scsi/libfc/fc_lport.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > A reasonable refactoring. Reviewed-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: libfc: directly call ELS request handlers

it more obvious. > > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/libfc/fc_lport.c | 20 +--- > 1 file changed, 9 insertions(+), 11 deletions(-) > A reasonable refactoring. Reviewed-by: Chad Dupuis

Re: [PATCH] qedf: fix wrong le16 conversion

> t_st_ctx->read_only.task_type = task_params->task_type; > SET_FIELD(t_st_ctx->read_write.flags, > FCOE_TSTORM_FCOE_TASK_ST_CTX_READ_WRITE_EXP_FIRST_FRAME, 1); > - t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID); > + t_st_ctx->read_write.rx_id = cpu_to_le16(FCOE_RX_ID); > > /* Init Ustorm */ > u_ag_ctx = >ustorm_ag_context; > Arnd, thanks for fixing this up. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] qedf: fix wrong le16 conversion

ead_only.task_type = task_params->task_type; > SET_FIELD(t_st_ctx->read_write.flags, > FCOE_TSTORM_FCOE_TASK_ST_CTX_READ_WRITE_EXP_FIRST_FRAME, 1); > - t_st_ctx->read_write.rx_id = cpu_to_le32(FCOE_RX_ID); > + t_st_ctx->read_write.rx_id = cpu_to_le16(FCOE_RX_ID); > > /* Init Ustorm */ > u_ag_ctx = >ustorm_ag_context; > Arnd, thanks for fixing this up. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Use vsprintf extension %pad

\n", > + qedf->bdq_pbl, >bdq_pbl_dma); > > /* >* Populate BDQ PBL with physical and virtual address of individual > Looks good. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: qedf: Use vsprintf extension %pad

qedf->bdq_pbl, >bdq_pbl_dma); > > /* > * Populate BDQ PBL with physical and virtual address of individual > Looks good. Acked-by: Chad Dupuis

Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches

p.c | 2 +- > drivers/scsi/qedf/qedf_io.c | 4 ++-- > 3 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_dbg.h b/drivers/scsi/qedf/qedf_dbg.h Thanks. Acked-by: Chad Dupuis <chad.dup...@cavium.com>

Re: [PATCH] scsi: qedf: Fix defective logging format and argument mismatches

csi/qedf/qedf_io.c | 4 ++-- > 3 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/qedf/qedf_dbg.h b/drivers/scsi/qedf/qedf_dbg.h Thanks. Acked-by: Chad Dupuis

Re: linux-next: build failure after merge of the scsi-mkp tree

On Thu, 23 Feb 2017, 2:19pm -, Martin K. Petersen wrote: > > *sigh* > > Chad: Please fix these up ASAP. > > Just submitted a patch to the list to fix this up. I tested against the mainline which has the net-next merge and the kref refcount_t conversion to verify.

Re: linux-next: build failure after merge of the scsi-mkp tree

On Thu, 23 Feb 2017, 2:19pm -, Martin K. Petersen wrote: > > *sigh* > > Chad: Please fix these up ASAP. > > Just submitted a patch to the list to fix this up. I tested against the mainline which has the net-next merge and the kref refcount_t conversion to verify.

Re: [PATCH] bnx2fc: Simplify code

>*/ > mutex_lock(_dev_lock); > - list_splice(_list, _be_deleted); > - INIT_LIST_HEAD(_list); > + list_splice_init(_list, _be_deleted); > adapter_count = 0; > mutex_unlock(_dev_lock); > > Looks ok to me. Acked-by: Chad Dupuis <chad.dup...@qlogic.com>

Re: [PATCH] bnx2fc: Simplify code

_dev_lock); > - list_splice(_list, _be_deleted); > - INIT_LIST_HEAD(_list); > + list_splice_init(_list, _be_deleted); > adapter_count = 0; > mutex_unlock(_dev_lock); > > Looks ok to me. Acked-by: Chad Dupuis

Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible

rs/scsi/bnx2fc/bnx2fc_io.c > index 8f24d60..f501095 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_io.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c > @@ -1079,7 +1079,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) > return bnx2fc_initiate_tmf(sc_cmd, FCP_TMF_LUN_RESET); > } > > -int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > +static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > { > struct bnx2fc_rport *tgt = io_req->tgt; > int rc = SUCCESS; > Looks ok. Acked-by: Chad Dupuis <chad.dup...@qlogic.com>

Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible

0..f501095 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_io.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c > @@ -1079,7 +1079,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) > return bnx2fc_initiate_tmf(sc_cmd, FCP_TMF_LUN_RESET); > } > > -int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > +static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) > { > struct bnx2fc_rport *tgt = io_req->tgt; > int rc = SUCCESS; > Looks ok. Acked-by: Chad Dupuis

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

On Tue, 5 Apr 2016, Bastien Philbert wrote: This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert

Re: [PATCH] bnx2fc: Fix locking requirements in bnx2fc_init_tgt

On Tue, 5 Apr 2016, Bastien Philbert wrote: This fixes the locking around the call to bnx2fc_alloc_id to comply with the comments about this particular function's definition about requiring the need to hold the hba mutex before and after calling it. Signed-off-by: Bastien Philbert ---

Re: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled

On Sat, 12 Dec 2015, Nicholas Krause wrote: This adds proper locking protection in bnx2fc_ctrl_enabled around the calls to the functions, _bnx2fc_enable and _bnx2fc_disable in order to avoid concurrent access on these functions accessing global referenced data structures in their internal

Re: [PATCH] bnx2fc:Add proper locking protection in bnx2fc_ctrlr_enabled

On Sat, 12 Dec 2015, Nicholas Krause wrote: This adds proper locking protection in bnx2fc_ctrl_enabled around the calls to the functions, _bnx2fc_enable and _bnx2fc_disable in order to avoid concurrent access on these functions accessing global referenced data structures in their internal

Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable

On Wed, 7 Oct 2015, Maurizio Lombardi wrote: Hi, On 10/07/2015 03:11 PM, Arnd Bergmann wrote: - memset(_tbl, 0, sizeof(npiv_tbl)); - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, _tbl)) + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); + if (!npiv_tbl)

Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable

On Wed, 7 Oct 2015, Maurizio Lombardi wrote: Hi, On 10/07/2015 03:11 PM, Arnd Bergmann wrote: - memset(_tbl, 0, sizeof(npiv_tbl)); - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, _tbl)) + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); + if (!npiv_tbl)

Re: [PATCH] bnxfc:Make the function bnx2fc_alloc_work static

Make sense. Acked-by: Chad Dupuis On Tue, 23 Jun 2015, Nicholas Krause wrote: This makes the function bnx_2fc_alloc_work static now due to this function's only caller being in this particular function's definition/declaration file of bnx2fc_hwi.c. Signed-off-by: Nicholas Krause --- drivers

Re: [PATCH] bnxfc:Make the function bnx2fc_alloc_work static

Make sense. Acked-by: Chad Dupuis chad.dup...@qlogic.com On Tue, 23 Jun 2015, Nicholas Krause wrote: This makes the function bnx_2fc_alloc_work static now due to this function's only caller being in this particular function's definition/declaration file of bnx2fc_hwi.c. Signed-off

Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc_io.c

Looks ok. Acked-by: Chad Dupuis On Sun, 12 Apr 2015, Masanari Iida wrote: The debug messages in bnx2fc_process_seq_cleanup_compl() doesn't match its function name. Signed-off-by: Masanari Iida --- drivers/scsi/bnx2fc/bnx2fc_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH] [SCSI] bnx2fc: Fix debug messasges in bnx2fc_io.c

Looks ok. Acked-by: Chad Dupuis chad.dup...@qlogic.com On Sun, 12 Apr 2015, Masanari Iida wrote: The debug messages in bnx2fc_process_seq_cleanup_compl() doesn't match its function name. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/scsi/bnx2fc/bnx2fc_io.c | 4 ++-- 1 file

Re: [PATCH 2/2] bnx2fc: bnx2fc_io.c: match wait_for_completion_timeout return type

Acked-by: Chad Dupuis On Wed, 4 Mar 2015, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int. An appropriately named variable of type unsigned long is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire --- The was only compile

Re: [PATCH 1/2] bnx2fc: bnx2fc_fcoe.c: match wait_for_completion_timeout return type

Looks ok. Acked-by: Chad Dupuis On Wed, 4 Mar 2015, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int. rc is appropriately renamed, changed to type unsigned long and the assignments fixed up. Signed-off-by: Nicholas Mc Guire --- The was only

Re: [PATCH 1/2] bnx2fc: bnx2fc_fcoe.c: match wait_for_completion_timeout return type

Looks ok. Acked-by: Chad Dupuis chad.dup...@qlogic.com On Wed, 4 Mar 2015, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int. rc is appropriately renamed, changed to type unsigned long and the assignments fixed up. Signed-off-by: Nicholas Mc Guire

Re: [PATCH 2/2] bnx2fc: bnx2fc_io.c: match wait_for_completion_timeout return type

Acked-by: Chad Dupuis chad.dup...@qlogic.com On Wed, 4 Mar 2015, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int. An appropriately named variable of type unsigned long is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof

Re: bisected regression: qla2xxx endianness on sparc64

On Sun, 2 Nov 2014, Meelis Roos wrote: Between 3.17 and 3.18-rc2, qla2xxx is broken on my sparc64 machines. It fails to boot (hangs in firmware rings init). This is the result of bisect: 98aee70d19a7e3203649fa2078464e4f402a0ad8 is the first bad commit commit

Re: bisected regression: qla2xxx endianness on sparc64

On Sun, 2 Nov 2014, Meelis Roos wrote: Between 3.17 and 3.18-rc2, qla2xxx is broken on my sparc64 machines. It fails to boot (hangs in firmware rings init). This is the result of bisect: 98aee70d19a7e3203649fa2078464e4f402a0ad8 is the first bad commit commit

Re: [PATCH v2 RESEND 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

of the error code should not notice the difference. Hello, Please, anyone (from QLogic especially) review this patch. Thanks! Looks good. Ack-by: Chad Dupuis Signed-off-by: Alexander Gordeev Cc: qla2xxx-upstr...@qlogic.com Cc: linux-s...@vger.kernel.org Cc: linux-...@vger.kernel.org

Re: [PATCH v2 RESEND 21/23] qla2xxx: Use pci_enable_msix_range() instead of pci_enable_msix()

of the error code should not notice the difference. Hello, Please, anyone (from QLogic especially) review this patch. Thanks! Looks good. Ack-by: Chad Dupuis chad.dup...@qlogic.com Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: qla2xxx-upstr...@qlogic.com Cc: linux-s

Re: [PATCH] qla2xxx: Re-sync module parameter descriptions with the code

y for DIX Type 0\n" " 2 -- Error isolation enabled for all Types\n"); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] qla2xxx: Re-sync module parameter descriptions with the code

unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Looks good. Thanks. Acked-by: Chad Dupuis chad.dup...@qlogic.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 7/7] scsi/qla2xxx: use pcie_is_pcie() to simplify code

Looks good. Acked-by: Chad Dupuis On Tue, 3 Sep 2013, Yijing Wang wrote: Use pci_is_pcie() instead of pci_find_capability to simplify code. Signed-off-by: Yijing Wang Cc: Andrew Vasquez Cc: linux-dri...@qlogic.com Cc: "James E.J. Bottomley" Cc: linux-s...@vger.kernel.org Cc: li

Re: [PATCH 7/7] scsi/qla2xxx: use pcie_is_pcie() to simplify code

Looks good. Acked-by: Chad Dupuis chad.dup...@qlogic.com On Tue, 3 Sep 2013, Yijing Wang wrote: Use pci_is_pcie() instead of pci_find_capability to simplify code. Signed-off-by: Yijing Wang wangyij...@huawei.com Cc: Andrew Vasquez andrew.vasq...@qlogic.com Cc: linux-dri...@qlogic.com Cc