Remove the bpmod_info_t typedef from bpctl_mod.c, replacing it with
struct bpmod_info.
Signed-off-by: Chad Williamson
---
v2: rebased onto latest master in linux-next
---
drivers/staging/silicom/bpctl_mod.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
Remove the dev_desc_t typedef for the dev_desc struct in bpctl_mod.c,
resolving a checkpatch.pl warning. In fact, we can use an anonymous
struct, since it's only used in the single dev_desc array of device
descriptions, whose definition follows immediately.
Signed-off-by: Chad Williamson
-
Remove the dev_desc_t typedef for the dev_desc struct in bpctl_mod.c,
resolving a checkpatch.pl warning. In fact, we can use an anonymous
struct, since it's only used in the single dev_desc array of device
descriptions, whose definition follows immediately.
Signed-off-by: Chad Willi
Remove the bpmod_info_t typedef from bpctl_mod.c, replacing it with
struct bpmod_info.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/staging
Replace the board_t enum typdef with struct board_type (_type for
consistency with media_type, above), resolving a checkpatch.pl
warning. (As far as I can tell, this isn't used anywhere.)
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 4 ++--
1 file chang
Capitalize the names of the media types in enum bp_media_type in
bpctl_mod.c, as is the preffered style.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers
More coding style cleanup on bpctl_mod.c in the form of a few typedef
exorcisms, one of which is a little long (let me know if you'd like
me to split it up into multiple patches...).
Chad Williamson (6):
Staging: silicom: remove bp_media_type enum typedef
Staging: silicom: capitalize l
Remove the typedef for enum bp_media_type from bpctl_mod.c and
change its one use accordingly, resolving a checkpatch.pl warning.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
Remove a bunch of assignments from if-statement conditions in
bpctl_mod.c, resolving checkpatch.pl errors. (This isn't all of
them, but the patch is getting rather long...)
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 54 +++--
1
Remove unnecessary braces in bpctl_mod.c, resolving checkpatch.pl
warnings.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 58 +++--
1 file changed, 23 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b
More coding style cleanup in bpctl_mod.c, resolving many checkpatch.pl
warnings and errors. I've skipped a number of issues in functions that
are going to need to be split up/rewritten anyway, etc. Tearing out the
new typedefs is next on my todo list...
Chad Williamson (4):
Staging: si
Two trivial whitespace fixes in bpctl_mod.c for the sake of
checkpatch.pl happiness, etc.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/staging
Remove more assignments from if-statement conditions in bpctl_mod.c,
resolving checkpatch.pl errors. Those that remain need more attention
than I'm presently prepared to give them.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c
Move the EXPORT_SYMBOL macros in bypass.c beneath the definitions
they refer to, resolving checkpatch.pl warnings. While we're at it, use
EXPORT_SYMBOL rather than EXPORT_SYMBOL_NOVERS.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bypasslib/bypass.c
This patchset cleans up the EXPORT_SYMBOL calls in staging/silicom by
placing the exports immediately below the definitions they refer to
(as is the convention) and removing the no-longer-useful
EXPORT_SYMBOL_NOVERS macro.
Chad Williamson (3):
Staging: silicom: move symbol exports beneath
Move the EXPORT_SYMBOL macros in bpctl_mod.c beneath the definitions
they refer to, resolving checkpatch.pl warnings. While we're at it, use
EXPORT_SYMBOL rather than EXPORT_SYMBOL_NOVERS.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bpctl_mod.c
Since all references to EXPORT_SYMBOL_NOVERS have been removed,
we can remove its definition from bp_mod.h and bypasslib/bplibk.h.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_mod.h | 2 --
drivers/staging/silicom/bypasslib/bplibk.h | 2 --
2 files changed, 4
Remove all code and associated preprocessor logic dependent on an old
LINUX_VERSION_CODE since such code is dead for an in-kernel driver.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_mod.c | 207 +
drivers/staging/silicom/bypasslib/bplibk.h
Bin,
Patches submitted to this list should appear in the body of the email,
not as attachments. Read Documentation/SubmittingPatches and check out
git-send-email.
Also, the relevant maintainers and more specific lists should be CC'd
(lest your patch go unnoticed by those directly interested). Run
Git status should be clean following make allmodconfig && make. Add
a .gitignore file to the samples/hidraw directory to ingore the
hid-example binary produced there.
Signed-off-by: Chad Williamson
---
samples/hidraw/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644
Remove explicit intialization of static procfs_dir to NULL, resolving a
checkpatch.pl error.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/silicom/bp_proc.c
b/drivers/staging/silicom
Remove unnecessary braces from single statement blocks in bp_proc.c,
resolving checkpatch.pl warnings.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_proc.c | 58 +--
1 file changed, 19 insertions(+), 39 deletions(-)
diff --git a/drivers
Remove unnecessary parentheses from return statements in bg_proc.c to
resolve checkpatch.pl errors.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_proc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/silicom/bp_proc.c
b/drivers/staging
Fix C99 // comments in bp_proc.c to resolve checkpatch.pl errors.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_proc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/silicom/bp_proc.c
b/drivers/staging/silicom/bp_proc.c
index f7b4699
Remove superfluous spaces in bp_proc.c to resolve checkpatch.pl errors.
Signed-off-by: Chad Williamson
---
drivers/staging/silicom/bp_proc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/silicom/bp_proc.c
b/drivers/staging/silicom/bp_proc.c
This patch set corrects many of the coding style issues detected by
checkpatch.pl in bp_proc.c.
Chad Williamson (5):
staging: silicom: fix whitespace in bp_proc.c
staging: silicom: fix C99 comments in bp_proc.c
staging: silicom: remove parentheses from return statements in bg_proc.c
26 matches
Mail list logo