Fixed the following warning generated by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/netlogic/xlr_net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/netlogic/xlr_net.c
b/drivers/staging/netlogic
Fixed the following error reported by running checkpatch.pl
ERROR: trailing whitespace
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u
Fixed some of the following warning generated by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u
Fixed the following warnings issued by checkpatch.pl
WARNING: please, no space before tabs
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging
Converted a C99 comment to fix the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b
Fixed open brace placement to address the following code-style errors:
ERROR: that open brace { should be on the previous line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 69 --
1 file changed, 23 insertions(+), 46 deletions
Rearranged statements around if and switch statements to address the following
error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 553 -
1 file changed, 402 insertions(+), 151
Converted some C99 warnings to fix the following error:
ERROR: trailing statements should be on next line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers
Added spaces after ',' to fix the following warning:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_core.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/driv
On Tue, Jun 3, 2014 at 2:42 PM, Greg KH wrote:
> So keep working on things,
> these aren't lost, I'll get to them in a few weeks.
>
Ok will do,
Chaitanya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordom
On Tue, Jun 3, 2014 at 11:36 AM, Dan Carpenter wrote:
> It always feels much better after the dead code is gone.
So patches are still good ? No change required for my side, right ? I
just need to wait for Greg's needle to come to this point and pick
them up.
Best,
Chaitanya
--
To unsubscribe fr
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.
Ok will be quite for till the last ones get accepted.
Sorry for the bother !
Chaitanya
On Thu, May 29, 2014 at 2:41 PM, Dan Carpenter wrote:
> On Thu, May 29, 2014 at 02:00:51PM -0700, Greg KH wrote:
>> On Thu, May 29, 2014 at 01:43:01PM -0700, Chaitanya Hazarey wrote:
>> >
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
I have 1/5 through to 5/5. Will resend rightaway with slightly changed
subjects.
Chaitanya
On Thu, May 29, 2014 at 1:43 PM, Greg KH wrote:
> On Wed, May 28, 2014 at 04:23:47PM -0700, Chaitanya Hazarey wrote:
>> Fixed a misplaced brace in a function
>>
>> Signed-off-
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..ceb06d8
Removed dead code, commented out printks and DMESG.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 675a12d..7dc2a96 100644
Fixed a misplaced brace in the r8192_wx_set_scan_type function.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index
To address the error -
ERROR: do not use C99 // comments
Removed all C99 comments.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 130 +--
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8192u
Added a space around '|' to address:
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.
Removed dead code from the file.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 09b1e81..f2c970e 100644
--- a/drivers
ok will send a new one out soon.
Thanks for looking into this and sorry about the repetition.
Chaitanya
On Wed, May 28, 2014 at 4:36 PM, Greg KH wrote:
> On Wed, May 28, 2014 at 04:23:48PM -0700, Chaitanya Hazarey wrote:
>> Removed dead code
>> Deleted stray newlines
>&g
Please ignore this patch, there seems something wrong with it, will
resend with a new subject.
Thanks,
Chaitanya
On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote:
> Fixed a misplaced brace in a function
>
> Signed-off-by: Chaitanya Hazarey
> ---
> drivers/staging/rtl81
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c5d..675a12d 100644
--- a
Removed dead code
Deleted stray newlines
Added newlines for better code readability
Addressed the following errors:
ERROR: do not use C99 // comments
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_
Please ignore this patch, there seems something wrong with it, will
resend with a new subject.
Thanks,
Chaitanya
On Wed, May 28, 2014 at 4:17 PM, Chaitanya Hazarey wrote:
> Removed dead code
> Deleted stray newlines
> Added newlines for better code readability
>
> Addresse
Removed dead code
Deleted stray newlines
Added newlines for better code readability
Addressed the following errors:
ERROR: do not use C99 // comments
ERROR: need consistent spacing around '|' (ctx:VxW)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_
Fixed a misplaced brace in a function
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
index 1af7c5d..675a12d 100644
--- a
open brace { should be on the previous line
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 84
1 file changed, 46 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_wx.c
b/drivers/staging/rtl8192u/r8192U_wx.c
ibited before that '--' (ctx:WxO)
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8192U_wx.c | 146 +--
1
ace required before the open parenthesis '('
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r
Well, it is what it is, will send the patch the right way.
Best,
Chaitanya
On Tue, May 27, 2014 at 1:39 PM, Dan Carpenter wrote:
> On Tue, May 27, 2014 at 01:09:45PM -0700, Chaitanya Hazarey wrote:
>> Fixed the following:
>>
>> ERROR: do not use C99 // comments
>>
at 11:56 PM, DaeSeok Youn wrote:
> Hi,
>
> 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey :
>> Fixed the following:
>>
>> ERROR: do not use C99 // comments
>> ERROR: else should follow close brace '}'
>> ERROR: need consistent spacing around '*
e
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: missing space after struct definition
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: suspect cod
e
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: missing space after struct definition
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: suspect cod
e
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: missing space after struct definition
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: suspect cod
e
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: missing space after struct definition
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: suspect cod
e
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
WARNING: missing space after struct definition
WARNING: Missing a blank line after declarations
WARNING: please, no spaces at the start of a line
WARNING: suspect cod
spaces required around that '<' (ctx:VxV)
ERROR: space required after that close brace '}'
ERROR: spaces required around that '==' (ctx:VxV)
ERROR: space required before the open parenthesis '('
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r
Hey there,
Thanks for looking into this,
Will be sending out the modified version soon.
Thanks,
Chaitanya
On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn wrote:
> Hi,
>
> 2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey :
>> Fixed the following:
>>
>> ERROR: do not u
(ctx:VxV)
ERROR: that open brace { should be on the previous line
ERROR: trailing statements should be on next line
WARNING: Missing a blank line after declarations
WARNING: missing space after struct definition
WARNING: please, no spaces at the start of a line
WA
Please ignore this.
Chaitanya
On Mon, May 26, 2014 at 10:32 PM, Chaitanya Hazarey wrote:
> Fixed the following:
>
> WARNING: line over 80 characters
> ERROR: do not use C99 // comments
> ERROR: else should follow close brace '}'
> ERROR: space required after that
hibited before that close parenthesis ')'
WARNING: suspect code indent for conditional statements (16, 16)
WARNING: __func__ should be used instead of gcc specific __FUNCTION__
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r8180_93cx6.c | 58 ++---
drivers/stag
Added a blank line after declarations in many places to fix
the following warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/silicom/bpctl_mod.c| 88 +++-
drivers/staging
On its way.
Chaitanya
On Sun, May 25, 2014 at 5:51 PM, Greg KH wrote:
> On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations in many places to fix the following
>> warning issued by checkpatch.pl:
>
> Always wrap you
this patch.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/silicom/bpctl_mod.c| 88 +++-
drivers/staging/silicom/bypasslib/bypass.c |2 +
2 files changed, 88 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/st
OK sure, will do Dan.
Greg, the patch has some issues, I did sync to your staging-next
branch and am having issues applying it.
Will send an update when i am able to do it.
Thanks,
Chaitanya
On Sun, May 25, 2014 at 3:30 PM, Dan Carpenter wrote:
> Since you're redoing this one anyway, please u
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
Lets see if this works now, this patch is prepared against Greg's staging tree.
Signed-off-by: Chaitanya Hazarey
---
drivers/st
Sorry Greg, this is taking so long, will make this against your tree
and send it out.
Thanks for looking into this,
Chaitanya
On Sun, May 25, 2014 at 11:03 AM, Greg KH wrote:
> On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declaration
Fixed a lot of errors of the type "ERROR: space required after that ','
(ctx:VxV)"
Added tabs at the beginning of line.
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r819xU_firmware_img.c | 1042
1 file changed, 521 insertio
Fixed a lot of errors of the type "ERROR: space required after that ','
(ctx:VxV)"
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/rtl8192u/r819xU_firmware_img.c | 1036
1 file changed, 518 insertions(+), 518 deletions(-)
diff --git a/driv
Forgot to add - what went wrong - I had deleted some whitespaces which
made the git apply mad.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 10:32 PM, Chaitanya Hazarey wrote:
> Thanks Greg for looking into it,
>
> I have resubmitted using a new email, hope that works out.
&
Thanks Greg for looking into it,
I have resubmitted using a new email, hope that works out.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 3:26 PM, Greg KH wrote:
> On Fri, May 23, 2014 at 02:47:10PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations in many places t
Hey Dan,
Thanks for your patience, I have resubmitted via a new email. Hope that works.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 3:54 PM, Dan Carpenter wrote:
> On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
>> Added a blank line after declarations to fix the
: Chaitanya Hazarey
---
drivers/staging/silicom/bpctl_mod.c| 92 +++-
drivers/staging/silicom/bypasslib/bypass.c |2 +
2 files changed, 91 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/silicom/bpctl_mod.c
b/drivers/staging/silicom/bpctl_mod.c
index
Added a blank line after declarations in many places to fix the following
warning issued by checkpatch.pl:
WARNING: Missing a blank line after declarations
---
drivers/staging/silicom/bpctl_mod.c | 90 ++-
1 file changed, 88 insertions(+), 2 deletions(-)
diff -
-off-by: Chaitanya Hazarey
---
drivers/staging/silicom/bypasslib/bypass.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/silicom/bypasslib/bypass.c
b/drivers/staging/silicom/bypasslib/bypass.c
index a58251f..8e714a8 100644
--- a/drivers/staging/silicom/bypasslib/bypass.c
Added a blank line after declarations to fix the following warning issued by
checkpatch.pl:
drivers/staging/xgifb/vb_init.c:800: WARNING: Missing a blank line after
declarations
Signed-off-by: Chaitanya Hazarey
---
drivers/staging/xgifb/vb_setmode.c |1 +
1 file changed, 1 insertion
hrown off by checkpatch.pl.
>>
>
> Put the error message here, or say what it was.
>
>> Signed-off-by: Chaitanya Hazarey
>
> Could you change your email client so it has your last in the From:
> header?
>
> This patch doesn't apply. Read this:
> ht
70 matches
Mail list logo