On 4/8/24 10:02, ni.liqiang wrote:
> In our testing of the virtio hardware accelerator, we found that
> configuring the flags of the descriptor after addr and len,
> as implemented in DPDK, seems to be more friendly to the hardware.
please describe in detail "friendly to the hardware" means ..
>
s: 9597624ef606 ('nvme: put some AMD PCIE downstream NVME device to
> simple suspend/resume path')
> Signed-off-by: Bixuan Cui
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 4/13/21 11:26, Javier González wrote:
>>> I believe there is space for extensions to simple copy. But given the
>>> experience with XCOPY, I can imagine that changes will be incremental,
>>> based on very specific use cases.
>>>
>>> I think getting support upstream and bringing deployed cases
On 4/11/21 18:33, Jens Axboe wrote:
>>> 586 | __raw_writel(page_to_phys(bio_page(req->bio)) +
>>> bio_offset(rq->bio),
>>> | ^~
>> How about adding a Fixes: tag?
> Indeed, that's definitely missing. I've added it and applied it.
' undeclared
(first use in this function)
586 | __raw_writel(page_to_phys(bio_page(req->bio)) + bio_offset(rq->bio),
| ^~
Reported-by: Naresh Kamboju
Tested-by: Naresh Kamboju
Signed-off-by: Chaitanya Kulkarni
---
drivers
On 4/9/21 17:22, Max Gurtovoy wrote:
> On 2/19/2021 2:45 PM, SelvaKumar S wrote:
>> This patchset tries to add support for TP4065a ("Simple Copy Command"),
>> v2020.05.04 ("Ratified")
>>
>> The Specification can be found in following link.
>>
On 4/8/21 23:24, Naresh Kamboju wrote:
>> bio_offset(req->bio),
>> GDROM_DMA_STARTADDR_REG);
>> __raw_writel(block_cnt * GDROM_HARD_SECTOR, GDROM_DMA_LENGTH_REG);
>> __raw_writel(1, GDROM_DMA_DIRECTION_REG);
> Thanks for your patch.
> After applying this
Naresh,
On 4/8/21 22:31, Chaitanya Kulkarni wrote:
> On 4/8/21 22:21, Naresh Kamboju wrote:
>> Linux next tag 20210408 architecture sh builds failed due to these errors.
>>
>> # to reproduce this build locally:
>>
>> make --silent --keep-going --jobs=8
>> O
On 4/8/21 22:21, Naresh Kamboju wrote:
> Linux next tag 20210408 architecture sh builds failed due to these errors.
>
> # to reproduce this build locally:
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=sh
> CROSS_COMPILE=sh4-linux-gnu- 'CC=sccache
On 4/7/21 04:10, Colin King wrote:
> From: Colin Ian King
>
> There is a spelling mistake in a pr_err error message. Fix it.
>
> Signed-off-by: Colin Ian King
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
Daniel,
On 3/31/21 06:12, Daniel Wagner wrote:
> Commit 8c4dfea97f15 ("nvme-fabrics: reject I/O to offline device")
> introduced fast_io_fail_tmo but didn't export the value to sysfs. That
> means the value is hard coded during compile time. Export the timeout
> value to user space via sysfs to
On 3/20/21 13:45, Bhaskar Chowdhury wrote:
> s/boundarys/boundaries/ . two different places
> s/assocated/associated/
> s/compeletion/completion/
> s/tranferred/transferred/
> s/subsytem/subsystem/
>
> Signed-off-by: Bhaskar Chowdhury
Patch looks fine but commit log could be better.
Ira,
On 3/4/21 00:23, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 61b205f579911a11f0b576f73275eca2aed0d108 ("mm/highmem: Convert
> memcpy_[to|from]_page() to kmap_local_page()")
>
On 3/4/21 01:58, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/nvme/host/core.c:3714:60-61: WARNING opportunity for
> kobj_to_dev().
>
> ./drivers/nvme/host/core.c:3475:60-61: WARNING opportunity for
> kobj_to_dev().
>
> Reported-by: Abaci Robot
> Signed-off-by:
On 3/2/21 22:21, Pintu Kumar wrote:
> The sysctl_compact_memory is mostly unsed in mm/compaction.c
> It just acts as a place holder for sysctl.
>
> Thus we can remove it from here and move the declaration directly
> in kernel/sysctl.c itself.
> This will also eliminate the extern declaration from
On 2/27/21 06:49, Steven Rostedt wrote:
> On Sat, 27 Feb 2021 19:44:40 +0800
> kernel test robot wrote:
>
>> [ 20.216017] WARNING: CPU: 0 PID: 1 at kernel/trace/trace.c:8370
>> create_trace_option_files (kbuild/src/consumer/kernel/trace/trace.c:8370
>> (discriminator 1))
>> [ 20.218480]
n dm-log-writes.c
>> - Use DIV_ROUND_UP in iomap/buffered-io.c
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/24/21 10:56, Christoph Hellwig wrote:
> On Wed, Feb 24, 2021 at 09:48:21AM -0700, Jens Axboe wrote:
>> Would make sense to rename blk_get_request() to blk_mq_alloc_request()
>> and then we have API symmetry. The get/put don't make sense when there
>> are no references involved.
>>
>> But it's
Randy,
On 2/24/21 13:45, Randy Dunlap wrote:
> On 2/24/21 1:41 PM, Chaitanya Kulkarni wrote:
>> On 2/24/21 02:43, Stephen Rothwell wrote:
>>>> I'll setup doc generation using sphinx on my machine, is there
>>>> a particular command line that you have used f
On 2/24/21 02:43, Stephen Rothwell wrote:
>> I'll setup doc generation using sphinx on my machine, is there
>> a particular command line that you have used for these warnings ?
> I just do a "make htmldocs"
I did that, please have a look at the test log.
On 2/23/21 21:33, Stephen Rothwell wrote:
>>> 1f83bb4b4914 ("blktrace: add blk_fill_rwbs documentation comment")
>>>
>>> -- Cheers, Stephen Rothwell
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing
On 2/23/21 21:33, Stephen Rothwell wrote:
>> I've failed to understand this warning as rwbs is present in the doc header
>> and in the function parameter :-
> I presume it is the missing ':' after @rwbs in the comment.
Thanks, I was looking at the wrong places all this time, will send a fix.
I'll
Stephen,
On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs'
> not described in 'blk_fill_rwbs'`
>
> Introduced by commit
On 2/23/21 18:31, Stephen Rothwell wrote:
> Hi all,
>
> After merging the block tree, today's linux-next build (htmldocs)
> produced this warning:
>
> kernel/trace/blktrace.c:1878: warning: Function parameter or member 'rwbs'
> not described in 'blk_fill_rwbs'`
>
> Introduced by commit
>
>
Signed-off-by: Chaitanya Kulkarni .
I'll review the patch(es) once you post again.
On 2/22/21 23:10, Christoph Hellwig wrote:
> On Tue, Feb 23, 2021 at 03:51:23AM +0000, Chaitanya Kulkarni wrote:
>> Looking at the other call sites do we need something like following ?
>> Since __blk_queue_bounce() passes the NULL for the passthru case as a
>> b
On 2/22/21 23:10, Christoph Hellwig wrote:
> Well, that is a somewhat odd calling convention. What about the patch below
> instead? That being we really need to kill this bouncing code off..
If we can kill it off soon it will be great.
>
> diff --git a/block/bounce.c b/block/bounce.c
> index
On 2/22/21 20:22, John Stultz wrote:
> On Mon, Feb 22, 2021 at 7:39 PM Chaitanya Kulkarni
> wrote:
>> On 2/22/21 19:07, John Stultz wrote:
>>> [ 34.784901] ueventd: LoadWithAliases was unable to load
>>> platform:regulatory
>>> [ 34.785313] bio_al
Christoph,
On 2/22/21 19:07, John Stultz wrote:
> [ 34.785313] bio_alloc_bioset+0x14/0x230
> [ 34.796189] bio_clone_fast+0x28/0x80
> [ 34.799848] bio_split+0x50/0xd0
> [ 34.803072] blk_crypto_fallback_encrypt_bio+0x2ec/0x5e8
> [ 34.808384] blk_crypto_fallback_bio_prep+0xfc/0x140
>
On 2/22/21 19:07, John Stultz wrote:
> [ 34.784901] ueventd: LoadWithAliases was unable to load platform:regulatory
> [ 34.785313] bio_alloc_bioset+0x14/0x230
> [ 34.796189] bio_clone_fast+0x28/0x80
> [ 34.799848] bio_split+0x50/0xd0
> [ 34.803072]
On 2/22/21 13:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 179d16007236 ("block: remove superfluous param in blk_fill_rwbs()")
>
> Fixes tag
>
> Fixes: 1b9a9ab78b0 ("blktrace: use op accessors")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be
The function blk_put_request() is just a wrapper to
blk_mq_free_request(), remove the unnecessary wrapper.
Any feedback is welcome on this RFC.
Signed-off-by: Chaitanya Kulkarni
---
block/blk-core.c | 6 --
block/blk-merge.c | 2 +-
block/bsg-lib.c
-by: Yang Li
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/17/21 14:03, Pavel Machek wrote:
> Hi!
>> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
>> index c73f2e295167..e92e36c053a6 100644
>> --- a/kernel/power/swap.c
>> +++ b/kernel/power/swap.c
>> @@ -271,13 +271,12 @@ static int hib_submit_io(int op, int op_flags, pgoff_t
>> page_off,
On 2/16/21 22:07, Hyeongseok Kim wrote:
> Add FITRIM ioctl to enable discarding unused blocks while mounted.
> As current exFAT doesn't have generic ioctl handler, add empty ioctl
> function first, and add FITRIM handler.
>
> Signed-off-by: Hyeongseok Kim
Looks good.
Reviewe
On 2/16/21 16:13, Hyeongseok Kim wrote:
> Sorry, I don't understand exactly.
> You're saying that these 2 patch should be merged to a single patch?
> Would it be better?
I think so unless there is a specific reason for this to keep it isolated.
On 2/16/21 14:36, Hyeongseok Kim wrote:
> +static int exfat_ioctl_fitrim(struct inode *inode, unsigned long arg)
> +{
> + struct super_block *sb = inode->i_sb;
Do you really need sb variable ? it is only used once if I'm not wrong.
> + struct request_queue *q = bdev_get_queue(sb->s_bdev);
On 2/16/21 14:36, Hyeongseok Kim wrote:
> Initialize empty ioctl function
>
> Signed-off-by: Hyeongseok Kim
This patch doesn't do much, but this commit log could be better.
Also from my experience there is not point in introducing an empty
function.
On 2/14/21 20:28, Hyeongseok Kim wrote:
> add FITRIM ioctl to support trimming mounted filesystem
>
> Signed-off-by: Hyeongseok Kim
> ---
> fs/exfat/balloc.c | 89 +
> fs/exfat/exfat_fs.h | 1 +
> fs/exfat/file.c | 33 +
> 3
t.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
> xfs-5.12-merge
> head: 560ab6c0d12ebccabb83638abe23a7875b946f9a
> commit: 37444fc4cc398266fe0f71a9c0925620d44fb76a [25/36] xfs: lift writable
> fs check up into log worker task
Looks good.
Reviewed-by: Chaitanya Kulkarni
uot;Unused value")
> Fixes: b63534c41e20 ("io_uring: re-issue block requests that failed because
> of resources")
> Signed-off-by: Colin Ian King
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Add VM_BUG_ON bounds checks to ensure the newly lifted and created page
> memory operations do not result in corrupted data in neighbor pages and
> to make them consistent with zero_user().[1][2]
>
I did not understand this, in my
Christoph Hellwig
> Signed-off-by: Ira Weiny
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> kmap_local_page() is more efficient and is well suited for these calls.
> Convert the kmap() to kmap_local_page()
>
> Cc: Andrew Morton
> Cc: Christoph Hellwig
> Signed-off-by: Ira Weiny
Looks good.
intel.com/
>
> Cc: Boris Pismenny
> Cc: Or Gerlitz
> Cc: Dave Hansen
> Suggested-by: Matthew Wilcox
> Suggested-by: Christoph Hellwig
> Suggested-by: Dan Williams
> Suggested-by: Al Viro
> Suggested-by: Eric Biggers
> Signed-off-by: Ira Weiny
Thanks for adding a new line in the new calls after variable declaration.
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/7/21 19:13, Ira Weiny wrote:
>>> +static inline void memcpy_from_page(char *to, struct page *page, size_t
>>> offset, size_t len)
>> How about following ?
>> static inline void memcpy_from_page(char *to, struct page *page, size_t
>> offset,
>> size_t len)
On 2/5/21 18:35, ira.we...@intel.com wrote:
> +static inline void memmove_page(struct page *dst_page, size_t dst_off,
> +struct page *src_page, size_t src_off,
> +size_t len)
> +{
> + char *dst = kmap_local_page(dst_page);
> + char
On 2/4/21 21:01, Amy Parker wrote:
>> Commit message is too long. Follow the style present in the tree.
> Are you referring to the per-line length? That was supposed to have
> been broken up, my apologies. Or is it the overall length that is the
> issue?
>
>-Amy IP
>
Per line length. I think
On 2/4/21 20:55, Amy Parker wrote:
> Many single-line statements have unnecessary braces, and some statement pairs
> have mismatched braces. This is a clear violation of the kernel style guide,
> which mandates that single line statements have no braces and that pairs with
> at least one
> Signed-off-by: John Hubbard
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/2/21 18:39, Ming Lei wrote:
> + struct bio *bio = rq->bio;
> + for_each_bio(bio)
> + nr_phys_segs++;
> + return nr_phys_segs;
> + }
Also, you need to add a new line after declaration of bio in
On 2/2/21 18:39, Ming Lei wrote:
> + /* fall through */
> case REQ_OP_WRITE_ZEROES:
> - return 0;
I don't think returning 1 for write-zeroes is right,
did you test this patch with write-zeores enabled controller with
the right fs that triggers this behavior ?
ent_fetch_work(struct work_struct
> *work)
> agent->state = AGENT_STATE_SUSPENDED;
>
> spin_unlock_bh(>lock);
> - };
> + }
> }
>
> static struct sbp_target_agent *sbp_target_agent_register(
Looks good.
Reviewed-by: Chaitanya Kulkarni
: use scnprintf or sprintf.
> ./drivers/nvme/host/core.c:3526:8-16: WARNING: use scnprintf or sprintf.
> ./drivers/nvme/host/core.c:2833:8-16: WARNING: use scnprintf or sprintf.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 2/1/21 13:27, Jianxiong Gao wrote:
>> Why is this setting being done and undone on each IO? Wouldn't it be
>> more efficient to set it once during device initialization?
>>
>> And more importantly, this isn't thread safe: one CPU may be setting the
>> device's dma alignment mask to 0 while
-by: Chaitanya Kulkarni
---
block/blk-lib.c | 6 +-
include/linux/bio.h | 25 +
2 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index fb486a0bdb58..ec29415f00dd 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -14,17
and gfp_mask by
encapsulating new bio allocation with bio alloc with initialization
at one place.
The objective of this RFC is to only start a discussion, this it not
completely tested at all.
-ck
Chaitanya Kulkarni (34):
block: move common code into blk_next_bio
Create a wrapper on the tio of the bio_new() named get_new_bio() & use
it in the dispatch_rw_block_io().
p
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/xen-blkback/blkback.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/block/xen-blk
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/zram/zram_drv.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index d7018543842e..5d744e528d4f 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers
Signed-off-by: Chaitanya Kulkarni
---
drivers/nvme/target/io-cmd-bdev.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/target/io-cmd-bdev.c
b/drivers/nvme/target/io-cmd-bdev.c
index bf6e0ac9ad28..f5fd93a796a6 100644
--- a/drivers/nvme/target/io-cmd
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index fa0ee732c6e9..5b5ed5fce2ed 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
fs/buffer.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 32647d2011df..fcbea667fa04 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -3023,12 +3023,16 @@ static int submit_bh_wbc(int op
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-log-writes.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c
index e3d35c6c9f71..7ca9af407647 100644
--- a/drivers/md/dm-log-writes.c
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_logmgr.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 9330eff210e0..4481f3e33a3f 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -1979,17 +1979,14
Signed-off-by: Chaitanya Kulkarni
---
fs/crypto/bio.c | 2 +-
fs/direct-io.c | 6 ++
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
index 20dab9bdf098..28cd62ce853e 100644
--- a/fs/crypto/bio.c
+++ b/fs/crypto/bio.c
@@ -148,7 +148,7 @@ int
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/direct-io.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index ea1e8f696076..f6c557a1bd25 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -189,15 +189,13
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/direct-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
index f6c557a1bd25..0737192f7e5c 100644
--- a/fs/iomap/direct-io.c
+++ b/fs/iomap/direct-io.c
@@ -267,9 +267,8
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_metapage.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 176580f54af9..3fa09d9a0b94 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -416,12 +416,11
Signed-off-by: Chaitanya Kulkarni
---
fs/nilfs2/segbuf.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
index 1e75417bfe6e..df352cab7a93 100644
--- a/fs/nilfs2/segbuf.c
+++ b/fs/nilfs2/segbuf.c
@@ -383,15 +383,9 @@ static
Signed-off-by: Chaitanya Kulkarni
---
fs/mpage.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index 830e6cc2a9e7..01725126e81f 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -68,25 +68,21 @@ static struct bio *mpage_bio_submit(int
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_bio_io.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/xfs/xfs_bio_io.c b/fs/xfs/xfs_bio_io.c
index e2148f2d5d6b..e4644f22ebe6 100644
--- a/fs/xfs/xfs_bio_io.c
+++ b/fs/xfs/xfs_bio_io.c
@@ -26,11 +26,8
Signed-off-by: Chaitanya Kulkarni
---
fs/xfs/xfs_buf.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
index f8400bbd6473..3ff6235e4f94 100644
--- a/fs/xfs/xfs_buf.c
+++ b/fs/xfs/xfs_buf.c
@@ -1507,12 +1507,10 @@ xfs_buf_ioapply_map
Signed-off-by: Chaitanya Kulkarni
---
fs/hfsplus/wrapper.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
index 0350dc7821bf..8341ee6c9b31 100644
--- a/fs/hfsplus/wrapper.c
+++ b/fs/hfsplus/wrapper.c
@@ -64,10 +64,7 @@ int
Signed-off-by: Chaitanya Kulkarni
---
mm/page_io.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 92f7941c6d01..25b321489703 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -342,10 +342,8 @@ int __swap_writepage(struct page *page
Signed-off-by: Chaitanya Kulkarni
---
mm/page_io.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 7579485ccb5e..cc30c9a0b0a7 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -287,6 +287,17 @@ static void
Signed-off-by: Chaitanya Kulkarni
---
mm/page_io.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 25b321489703..7579485ccb5e 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -342,7 +342,7 @@ int __swap_writepage(struct page *page
Signed-off-by: Chaitanya Kulkarni
---
fs/iomap/buffered-io.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 16a1e82e3aeb..08d119b62cf5 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
Signed-off-by: Chaitanya Kulkarni
---
kernel/power/swap.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index c73f2e295167..e92e36c053a6 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -271,13 +271,12 @@ static
Signed-off-by: Chaitanya Kulkarni
---
fs/ocfs2/cluster/heartbeat.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
index 0179a73a3fa2..b34518036446 100644
--- a/fs/ocfs2/cluster/heartbeat.c
+++ b/fs/ocfs2
Signed-off-by: Chaitanya Kulkarni
---
fs/zonefs/super.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
index ab68e27bb322..620d67965a22 100644
--- a/fs/zonefs/super.c
+++ b/fs/zonefs/super.c
@@ -661,6 +661,7 @@ static const struct
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_metapage.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c
index 3fa09d9a0b94..c7be3a2773bf 100644
--- a/fs/jfs/jfs_metapage.c
+++ b/fs/jfs/jfs_metapage.c
@@ -495,13 +495,11
Signed-off-by: Chaitanya Kulkarni
---
fs/crypto/bio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
index b048a0e38516..20dab9bdf098 100644
--- a/fs/crypto/bio.c
+++ b/fs/crypto/bio.c
@@ -148,12 +148,11 @@ int fscrypt_zeroout_range
Signed-off-by: Chaitanya Kulkarni
---
fs/jfs/jfs_logmgr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 4481f3e33a3f..bb25737d52f6 100644
--- a/fs/jfs/jfs_logmgr.c
+++ b/fs/jfs/jfs_logmgr.c
@@ -2121,16 +2121,14 @@ static
Signed-off-by: Chaitanya Kulkarni
---
drivers/target/target_core_iblock.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/target/target_core_iblock.c
b/drivers/target/target_core_iblock.c
index 8ed93fd205c7..f1264918aee1 100644
--- a/drivers/target
Signed-off-by: Chaitanya Kulkarni
---
fs/block_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 9d4b1a884d76..f3e3247894d7 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -367,6 +367,8 @@ __blkdev_direct_IO(struct kiocb
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index 039d17b28938..e6252f48a49c 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
drivers/md/dm-zoned-metadata.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
index e6252f48a49c..fa0ee732c6e9 100644
--- a/drivers/md/dm-zoned-metadata.c
+++ b
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_receiver.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index 09c86ef3f0fd..e1cd3427b28b 100644
--- a/drivers/block/drbd
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/drbd/drbd_receiver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index e1cd3427b28b..b86bbf725cbd 100644
--- a/drivers/block/drbd
to
the blk_next_bio() to reduce the duplication.
In the next patch we introduce bio_new(), this prepration patch allows
us to call it inside blk_next_bio().
Signed-off-by: Chaitanya Kulkarni
---
block/blk-lib.c | 36 +++-
block/blk-zoned.c | 4 +---
block/blk.h | 5
version.
Signed-off-by: Chaitanya Kulkarni
---
drivers/block/loop.c | 22 --
drivers/block/loop.h | 1 +
2 files changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 578fc034db3f..08bd17afbdff 100644
--- a/drivers/block/loop.c
> On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni
> wrote:
>
> On 1/26/21 14:14, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas
>>
>> Use PCI #defines for PCIe Device Control register values instead of
>> hard-coding bit positions. No functional change i
include/uapi/linux/pci_regs.h
matches open coded bit shift values. LGTM.
Reviewed-by: Chaitanya Kulkarni
Amy,
On 1/26/21 8:26 AM, Amy Parker wrote:
> Kernel development newcomer here. I've begun creating a concept for a
> new filesystem, and ideally once it's completed, rich, and stable I'd
> try to get it into the kernel.
>
> What would be the process for this? I'd assume a patch sequence, but
>
Pavel,
On 1/26/21 6:48 AM, Pavel Tatashin wrote:
> Changelog
> v4
> - Added review-by Petr Vorel
> - Addressed comments from Chaitanya Kulkarni
Thanks a lot for making these changes, detail commit log helps everyone
in the community and not just to the owner.
On 1/25/21 12:15 PM, Pavel Tatashin wrote:
> Currently, loop device has only one global lock:
> loop_ctl_mutex.
Above line can be :-
Currently, loop device has only one global lock: loop_ctl_mutex.
Also please provide a complete discretion what are the members it protects,
i.e. how big the size
On 1/20/21 7:01 PM, Julian Calaby wrote:
> Hi Chaitanya,
>
> On Tue, Jan 19, 2021 at 5:01 PM Chaitanya Kulkarni
> wrote:
>> Hi,
>>
>> This is a *compile only RFC* which adds a generic helper to initialize
>> the various fields of the bio that is repeated all
On 1/19/21 20:06, Gao Xiang wrote:
> Hi Chaitanya,
>
> (drop in-person Cc..)
>
> On Mon, Jan 18, 2021 at 09:06:25PM -0800, Chaitanya Kulkarni wrote:
>
> ...it would be nice if you could update the subject line to
> "erofs: use bio_init_fields "
Sure, if new
On 1/18/21 21:06, Chaitanya Kulkarni wrote:
> Hi,
>
> This is a *compile only RFC* which adds a generic helper to initialize
> the various fields of the bio that is repeated all the places in
> file-systems, block layer, and drivers.
>
> The new helper allows callers to initi
Signed-off-by: Chaitanya Kulkarni
---
fs/block_dev.c | 17 +
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 3e5b02f6606c..44b992976ee5 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -239,12 +239,9
1 - 100 of 221 matches
Mail list logo
