;time_in_state' because this patch
handles the memory leak of 'trans_table' and 'time_in_state'
variables.
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 0ae3de7..945f5f1 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -593,6 +593,9 @@ static void devfreq_dev_release(struct device *dev)
devfreq->profile->exit(devfreq->dev.parent);
mutex_destroy(>lock);
+ kfree(devfreq->trans_table);
+ kfree(devfreq->time_in_state);
kfree(devfreq);
}
--
Best Regards,
Chanwoo Choi
Samsung Electronics
FOR SAMSUNG EXYNOS
- new : SAMSUNG EXYNOS BUS FREQUENCY DRIVER
Also, remove the unneeded git repository information.
Signed-off-by: Chanwoo Choi
---
MAINTAINERS | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 8119141a926f
gt; +F: include/linux/iio/common/cros_ec_sensors_core.h
> +F: include/linux/mfd/cros_ec*
> +
> CIRRUS LOGIC AUDIO CODEC DRIVERS
> M: Brian Austin
> M: Paul Handrigan
>
For extcon part,
Acked-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
,
Chanwoo Choi
On 2018년 12월 08일 05:29, Saravana Kannan wrote:
>
> On 11/9/16 4:10 PM, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2016년 11월 10일 05:34, Saravana Kannan wrote:
>>> On 11/08/2016 06:38 PM, Chanwoo Choi wrote:
>>>> On 2016년 11월 09일 11:36, Chanwoo Choi wro
Dear Greg,
This is extcon-next pull request for v4.21. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:
Linux 4.20-rc1 (2018-11-04 15
Hi Lukasz,
On 2018년 12월 05일 20:05, Lukasz Luba wrote:
> This patch adds implementation for global suspend/resume for
> devfreq framework. System suspend will next use these functions.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
Hi Lukasz,
On 2018년 12월 05일 20:05, Lukasz Luba wrote:
> This patch adds implementation for global suspend/resume for
> devfreq framework. System suspend will next use these functions.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
odyfications in the drivers code. It uses atomic variables to
> make sure no race condition affects the process.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 47
>
odyfications in the drivers code. It uses atomic variables to
> make sure no race condition affects the process.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 47
>
Hi Lukasz,
On 2018년 12월 04일 18:53, Lukasz Luba wrote:
> Hi Chanwoo,
>
> On 12/4/18 7:10 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add the comment about 'suspend_count'.
>>
>> On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
>>> Hi,
>>>
Hi Lukasz,
On 2018년 12월 04일 18:53, Lukasz Luba wrote:
> Hi Chanwoo,
>
> On 12/4/18 7:10 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add the comment about 'suspend_count'.
>>
>> On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
>>> Hi,
>>>
description.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 42 ++
> include/linux/devfreq.h | 6 ++
> 2 files changed, 48 insertions(+)
>
>
description.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> drivers/devfreq/devfreq.c | 42 ++
> include/linux/devfreq.h | 6 ++
> 2 files changed, 48 insertions(+)
>
>
Hi Lukasz,
I add the comment about 'suspend_count'.
On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> Looks good to me. But, I add the some comments.
>> If you will fix it, feel free to add my
Hi Lukasz,
I add the comment about 'suspend_count'.
On 2018년 12월 04일 14:43, Chanwoo Choi wrote:
> Hi,
>
> On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> Looks good to me. But, I add the some comments.
>> If you will fix it, feel free to add my
Hi,
On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi
Sorry. Fix typo 'choi' to 'Choi' as following.
Reviewed-by: Chanwoo Choi
>
> O
Hi,
On 2018년 12월 04일 14:36, Chanwoo Choi wrote:
> Hi Lukasz,
>
> Looks good to me. But, I add the some comments.
> If you will fix it, feel free to add my tag:
> Reviewed-by: Chanwoo choi
Sorry. Fix typo 'choi' to 'Choi' as following.
Reviewed-by: Chanwoo Choi
>
> O
Hi,
On 2018년 12월 04일 13:39, Chanwoo Choi wrote:
> Hi Lukasz,
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_targe
Hi,
On 2018년 12월 04일 13:39, Chanwoo Choi wrote:
> Hi Lukasz,
>
> On 2018년 12월 03일 23:31, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_targe
Hi Lukasz,
Looks good to me. But, I add the some comments.
If you will fix it, feel free to add my tag:
Reviewed-by: Chanwoo choi
On 2018년 12월 03일 23:31, Lukasz Luba wrote:
> The patch prepares devfreq device for handling suspend/resume
> functionality. The new fields will store
Hi Lukasz,
Looks good to me. But, I add the some comments.
If you will fix it, feel free to add my tag:
Reviewed-by: Chanwoo choi
On 2018년 12월 03일 23:31, Lukasz Luba wrote:
> The patch prepares devfreq device for handling suspend/resume
> functionality. The new fields will store
mmented, Please remove it. You already mentioned it on
cover-letter.
If you want to contain the contribution history of Tobias, you might better
to add 'Signed-off-by' or others.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
>
mmented, Please remove it. You already mentioned it on
cover-letter.
If you want to contain the contribution history of Tobias, you might better
to add 'Signed-off-by' or others.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
>
> +#define CLK_ACLK_SMMU_SLIMSSS12
> +#define CLK_ACLK_SMMU_RTIC 13
> +#define CLK_ACLK_IMEMND_266 14
> +#define CLK_ACLK_ALB_IMEM15
> +#define CLK_ACLK_XIU_IMEMX 16
> +#define CLK_ACLK_AXIUS_IMEMX 17
> +#define CLK_ACLK_ASYNCAXI_IMEMX 18
> +#define CLK_ACLK_ARBG_TX 19
> +#define CLK_ACLK_BTS_ARBG_TX 20
> +#define CLK_ACLK_SMMU_ARBG_TX21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
> +#define CLK_ACLK_SMMU_SLIMSSS12
> +#define CLK_ACLK_SMMU_RTIC 13
> +#define CLK_ACLK_IMEMND_266 14
> +#define CLK_ACLK_ALB_IMEM15
> +#define CLK_ACLK_XIU_IMEMX 16
> +#define CLK_ACLK_AXIUS_IMEMX 17
> +#define CLK_ACLK_ASYNCAXI_IMEMX 18
> +#define CLK_ACLK_ARBG_TX 19
> +#define CLK_ACLK_BTS_ARBG_TX 20
> +#define CLK_ACLK_SMMU_ARBG_TX21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 2018년 11월 23일 18:44, Anand Moon wrote:
> From: Marian Mihailescu
>
> A specific clock rate table is added for VPLL so it is possible
> to set frequency of the VPLL output clock that used by the g3d clock.
>
> Cc: Andrzej Hajda
> Cc: Chanwoo Choi
> Signed-o
Hi,
On 2018년 11월 23일 18:44, Anand Moon wrote:
> From: Marian Mihailescu
>
> A specific clock rate table is added for VPLL so it is possible
> to set frequency of the VPLL output clock that used by the g3d clock.
>
> Cc: Andrzej Hajda
> Cc: Chanwoo Choi
> Signed-o
NI
> for Exynos542x SoC.
>
> - CLK_DOUT_ACLK_G3D for G3D's AXI
>
> Cc: Chanwoo Choi
> Signed-off-by: Anand Moon
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 57 +--
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 ++
> 2 files changed, 56 insertions(+
NI
> for Exynos542x SoC.
>
> - CLK_DOUT_ACLK_G3D for G3D's AXI
>
> Cc: Chanwoo Choi
> Signed-off-by: Anand Moon
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 57 +--
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 5 ++
> 2 files changed, 56 insertions(+
Hi Lukasz,
I add the one more comment for devfreq_resume_device()
On 2018년 11월 23일 19:01, Lukasz Luba wrote:
> Hi Chanwoo Choi,
>
> On 11/23/18 12:54 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add one more comment about devfreq_resume_device().
>>
>> On
Hi Lukasz,
I add the one more comment for devfreq_resume_device()
On 2018년 11월 23일 19:01, Lukasz Luba wrote:
> Hi Chanwoo Choi,
>
> On 11/23/18 12:54 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> I add one more comment about devfreq_resume_device().
>>
>> On
Hi Lukasz,
I add one more comment about devfreq_resume_device().
On 2018년 11월 22일 20:00, Lukasz Luba wrote:
>
>
> On 11/22/18 3:58 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The patch adds support for handling suspend/resume process.
>
Hi Lukasz,
I add one more comment about devfreq_resume_device().
On 2018년 11월 22일 20:00, Lukasz Luba wrote:
>
>
> On 11/22/18 3:58 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The patch adds support for handling suspend/resume process.
>
Hi Lukasz,
On 2018년 11월 22일 19:40, Lukasz Luba wrote:
> Hi Chanwoo Choi
>
> On 11/22/18 3:52 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The refactoring is needed for the new client in devfreq: suspend.
>>> To avoid code dupl
Hi Lukasz,
On 2018년 11월 22일 19:40, Lukasz Luba wrote:
> Hi Chanwoo Choi
>
> On 11/22/18 3:52 AM, Chanwoo Choi wrote:
>> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>>> The refactoring is needed for the new client in devfreq: suspend.
>>> To avoid code dupl
ago, who tried to
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate info
ago, who tried to
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate info
the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> arch/arm/boot
the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Signed-off-by: Lukasz Luba
> ---
> arch/arm/boot
evfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patch history.
>
&g
evfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patch history.
>
&g
issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patch history.
issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
Please remove the duplicate information about patch history.
On 2018년 11월 22일 11:52, Chanwoo Choi wrote:
> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_target.
>>
>> The patch dra
On 2018년 11월 22일 11:52, Chanwoo Choi wrote:
> On 2018년 11월 22일 03:01, Lukasz Luba wrote:
>> The refactoring is needed for the new client in devfreq: suspend.
>> To avoid code duplication, move it to the new local function
>> devfreq_set_target.
>>
>> The patch dra
o
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
As I commented on patch1, please remove it.
>
o
> solve issue with devfreq device's frequency during suspend/resume.
> During the discussion on LKML some corner cases and comments appeared
> related to the design. This patch address them keeping in mind suggestions
> from Chanwoo Choi.
As I commented on patch1, please remove it.
>
ddress them keeping in mind suggestions
> from Chanwoo Choi.
You already explain the patch history on cover letter. It is enough.
Please remove the duplicate history description from all patches except for
cover letter.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Si
ddress them keeping in mind suggestions
> from Chanwoo Choi.
You already explain the patch history on cover letter. It is enough.
Please remove the duplicate history description from all patches except for
cover letter.
>
> Suggested-by: Tobias Jakobi
> Suggested-by: Chanwoo Choi
> Si
21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
21
> +#define CLK_ACLK_GIC 22
> +#define CLK_ACLK_INT_MEM 23
> +#define CLK_ACLK_XIU_PIMEMX 24
> +#define CLK_ACLK_AXI2APB_IMEM0P 25
> +#define CLK_ACLK_AXI2APB_IMEM1P 26
> +#define CLK_ACLK_ASYNCAXIS_MIF_PIMEMX27
> +#define CLK_ACLK_AXIDS_PIMEMX_GIC28
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM0P 29
> +#define CLK_ACLK_AXIDS_PIMEMX_IMEM1P 30
> +#define CLK_ACLK_SROMC 31
> +#define CLK_ACLK_AXIDS_SROMC 32
> +#define CLK_ACLK_AXI2AHB_IMEMH 33
> +#define CLK_PCLK_SSS 34
> +#define CLK_PCLK_SLIMSSS 35
> +#define CLK_PCLK_RTIC36
> +#define CLK_PCLK_SYSREG_IMEM 37
> +#define CLK_PCLK_PMU_IMEM38
> +#define CLK_PCLK_ALB_IMEM39
> +#define CLK_PCLK_BTS_SSS_CCI 40
> +#define CLK_PCLK_BTS_SSS_DRAM41
> +#define CLK_PCLK_BTS_SLIMSSS 42
> +#define CLK_PCLK_SMMU_SSS_CCI43
> +#define CLK_PCLK_SMMU_SSS_DRAM 44
> +#define CLK_PCLK_SMMU_SLIMSSS45
> +#define CLK_PCLK_SMMU_RTIC 46
> +#define CLK_PCLK_ASYNCAPB_ARBG_TX47
> +#define CLK_PCLK_BTS_ARBG_TX 48
> +#define CLK_PCLK_SMMU_ARBG_TX49
> +#define CLK_PCLK_ASYNCAXI_IMEMX 50
> +#define CLK_PCLK_GPIO_IMEM 51
> +
> +#define IMEM_NR_CLK 52
> +
> /* CMU_G2D */
> #define CLK_MUX_ACLK_G2D_266_USER1
> #define CLK_MUX_ACLK_G2D_400_USER2
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
out:
> mutex_unlock(>lock);
> - return 0;
> + return ret;
> }
>
> static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
out:
> mutex_unlock(>lock);
> - return 0;
> + return ret;
> }
>
> static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
x8997_muic_set_path(info, info->path_usb, attached);
> + if (ret < 0) {
> + dev_err(info->dev, "failed to update muic register\n");
> + return ret;
> }
>
> switch (usb_type) {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
x8997_muic_set_path(info, info->path_usb, attached);
> + if (ret < 0) {
> + dev_err(info->dev, "failed to update muic register\n");
> + return ret;
> }
>
> switch (usb_type) {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
c | 18 +++---
> drivers/extcon/extcon-max8997.c | 15 +++++--
> 4 files changed, 55 insertions(+), 9 deletions(-)
>
Applied them. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
c | 18 +++---
> drivers/extcon/extcon-max8997.c | 15 +++++--
> 4 files changed, 55 insertions(+), 9 deletions(-)
>
Applied them. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
e,
> .unprepare = s2mps11_clk_unprepare,
> .is_prepared = s2mps11_clk_is_prepared,
>
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
e,
> .unprepare = s2mps11_clk_unprepare,
> .is_prepared = s2mps11_clk_is_prepared,
>
>
>
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
exynos4_mct_frc_start();
> + return 0;
> + }
> + }
>
> ret = exynos4_timer_interrupts(np, int_type);
> if (ret)
>
I tested it on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
exynos4_mct_frc_start();
> + return 0;
> + }
> + }
>
> ret = exynos4_timer_interrupts(np, int_type);
> if (ret)
>
I tested it on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Marek,
I tested it for both kernel booting and cpu hotplugging
on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
On 2018년 10월 17일 22:41, Marek Szyprowski wrote:
> Move interrupts allocation from exynos4_timer_resources() into separate
> function to
Hi Marek,
I tested it for both kernel booting and cpu hotplugging
on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
On 2018년 10월 17일 22:41, Marek Szyprowski wrote:
> Move interrupts allocation from exynos4_timer_resources() into separate
> function to
HDOG if WATCHDOG
>
I tested it on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
HDOG if WATCHDOG
>
I tested it on Exynos5433-based TM2 board.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>,
> - - (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> - };
> };
>
> #include "exynos5433-bus.dtsi"
>
I tested it on Exynos5433-based TM2 board. It is well working.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>,
> - - (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
> - };
> };
>
> #include "exynos5433-bus.dtsi"
>
I tested it on Exynos5433-based TM2 board. It is well working.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Marek,
I tested it about kernel booting and CPU hotplug through sysfs path
on ARM64 Exynos5433-based TM2 board. It is well working.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
But,
I have a minor comment for code clean-up.
On exynos4_mct_starting_cpu() function, the initialization
Hi Marek,
I tested it about kernel booting and CPU hotplug through sysfs path
on ARM64 Exynos5433-based TM2 board. It is well working.
Reviewed-by: Chanwoo Choi
Tested-by: Chanwoo Choi
But,
I have a minor comment for code clean-up.
On exynos4_mct_starting_cpu() function, the initialization
mutex_lock(_list_lock);
> if (err)
> - return NULL;
> + return ERR_PTR(err);
>
> governor = find_devfreq_governor(name);
> }
>
LGTM.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
mutex_lock(_list_lock);
> if (err)
> - return NULL;
> + return ERR_PTR(err);
>
> governor = find_devfreq_governor(name);
> }
>
LGTM.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
pcpu_mevt->evt.irq = -1;
> + }
> + }
> + }
> return err;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
pcpu_mevt->evt.irq = -1;
> + }
> + }
> + }
> return err;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
G,
>
On Exynos SoC, ARM architecture timer shares the block of Exynos MCT timer.
For using arch_timer, Exynos MCT timer should be initialized before arch_timer.
I agree about this.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
G,
>
On Exynos SoC, ARM architecture timer shares the block of Exynos MCT timer.
For using arch_timer, Exynos MCT timer should be initialized before arch_timer.
I agree about this.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
*/
> -#ifdef CONFIG_OF
> nr_irqs = of_irq_count(np);
> -#else
> - nr_irqs = 0;
> -#endif
> for (i = MCT_L0_IRQ; i < nr_irqs; i++)
> mct_irqs[i] = irq_of_parse_and_map(np, i);
>
>
I agree that Exynos MCT timer is only used by device-tree.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
*/
> -#ifdef CONFIG_OF
> nr_irqs = of_irq_count(np);
> -#else
> - nr_irqs = 0;
> -#endif
> for (i = MCT_L0_IRQ; i < nr_irqs; i++)
> mct_irqs[i] = irq_of_parse_and_map(np, i);
>
>
I agree that Exynos MCT timer is only used by device-tree.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Greg,
This is extcon-next pull request for v4.20. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3:
Linux 4.19-rc1 (2018-08-26 14
Dear Greg,
This is extcon-next pull request for v4.20. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3:
Linux 4.19-rc1 (2018-08-26 14
device_release()
devfreq_dev_release()
stop the governor for specific devfreq instance
It looks good to me. Stop the governor before calling device_unregister().
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
device_release()
devfreq_dev_release()
stop the governor for specific devfreq instance
It looks good to me. Stop the governor before calling device_unregister().
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Bartlomiej,
On 2018년 08월 29일 21:50, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Chanwoo,
>
> On Wednesday, August 29, 2018 04:34:06 PM Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed
Hi Bartlomiej,
On 2018년 08월 29일 21:50, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Chanwoo,
>
> On Wednesday, August 29, 2018 04:34:06 PM Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed
Dear Greg,
On 2018년 08월 29일 19:57, Greg KH wrote:
> On Wed, Aug 29, 2018 at 04:34:06PM +0900, Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed the node name to devfreq(x). After this commit, it
Dear Greg,
On 2018년 08월 29일 19:57, Greg KH wrote:
> On Wed, Aug 29, 2018 at 04:34:06PM +0900, Chanwoo Choi wrote:
>> commit 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
>> sysfs") changed the node name to devfreq(x). After this commit, it
.
Cc: sta...@vger.kernel.org
Fixes: 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
sysfs")
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 11 +++
include/linux/devfreq.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/devfreq/devfreq
.
Cc: sta...@vger.kernel.org
Fixes: 4585fbcb5331 ("PM / devfreq: Modify the device name as devfreq(X) for
sysfs")
Signed-off-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 11 +++
include/linux/devfreq.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/devfreq/devfreq
if (!edev)
> return -EINVAL;
>
Applied all patches of this series. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
if (!edev)
> return -EINVAL;
>
Applied all patches of this series. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Rob,
On 2018년 08월 28일 10:52, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Chanwoo Choi
> Cc: MyungJoo Ham
> Cc: Kyungmin Park
> Cc: Kukjin Kim
>
Dear Rob,
On 2018년 08월 28일 10:52, Rob Herring wrote:
> In preparation to remove the node name pointer from struct device_node,
> convert printf users to use the %pOFn format specifier.
>
> Cc: Chanwoo Choi
> Cc: MyungJoo Ham
> Cc: Kyungmin Park
> Cc: Kukjin Kim
>
on-max77693.c | 22 ++
> drivers/extcon/extcon-max77843.c | 19 +++
> drivers/extcon/extcon-max8997.c | 22 ++
> 4 files changed, 26 insertions(+), 61 deletions(-)
>
Thanks. Applied it for v4.20.
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
on-max77693.c | 22 ++
> drivers/extcon/extcon-max77843.c | 19 +++
> drivers/extcon/extcon-max8997.c | 22 ++
> 4 files changed, 26 insertions(+), 61 deletions(-)
>
Thanks. Applied it for v4.20.
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Matthias,
On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Matthias,
On 2018년 08월 07일 09:23, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Tue, Aug 07, 2018 at 07:31:16AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Mhz at this time
such as cooling.
I think that if OPP support the use of multiple device drivers,
dev_pm_opp_enable() and dev_pm_opp_disable() should support the usage count
such as regulator/clock.
I would like your opinion.
Regards,
Chanwoo Choi
On 2018년 08월 07일 07:31, Chanwoo Choi wrote:
&
Mhz at this time
such as cooling.
I think that if OPP support the use of multiple device drivers,
dev_pm_opp_enable() and dev_pm_opp_disable() should support the usage count
such as regulator/clock.
I would like your opinion.
Regards,
Chanwoo Choi
On 2018년 08월 07일 07:31, Chanwoo Choi wrote:
&
Hi Matthias,
On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
>>> On Thu, Aug 02, 2018 at 04:13:43PM -07
Hi Matthias,
On 2018년 08월 07일 04:21, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 09:14:46AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
>>> On Thu, Aug 02, 2018 at 04:13:43PM -07
Hi Matthias,
On 2018년 08월 07일 03:46, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
601 - 700 of 7212 matches
Mail list logo
