Hi Matthias,
On 2018년 08월 07일 03:46, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Fri, Aug 03, 2018 at 08:56:57AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Matthias,
On 2018년 08월 03일 09:24, Matthias Kaehlcke wrote:
> On Fri, Aug 03, 2018 at 09:03:30AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:36, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>> this patch and "PM / de
Hi Matthias,
On 2018년 08월 03일 09:24, Matthias Kaehlcke wrote:
> On Fri, Aug 03, 2018 at 09:03:30AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 03일 08:36, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>> this patch and "PM / de
Hi Matthias,
On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
> On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
Hi Matthias,
On 2018년 08월 03일 08:48, Matthias Kaehlcke wrote:
> On Thu, Aug 02, 2018 at 04:13:43PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
Hi Matthias,
On 2018년 07월 12일 17:38, Chanwoo Choi wrote:
> Hi Matthias,
>
> On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
>> Hi,
>>
>> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 2018년 07월 04일 08:46
Hi Matthias,
On 2018년 07월 12일 17:38, Chanwoo Choi wrote:
> Hi Matthias,
>
> On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
>> Hi,
>>
>> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 2018년 07월 04일 08:46
forward, do you
> want me to spin out these two patches so that they can get merged
> independently from the rest of the series?
How about resend the devfreq patches(patch1/2/3/4/6) which don't depend on
throttler core with my reviewed tag? Maybe, it is easy to merge them through
Myungjoo.
Reg
forward, do you
> want me to spin out these two patches so that they can get merged
> independently from the rest of the series?
How about resend the devfreq patches(patch1/2/3/4/6) which don't depend on
throttler core with my reviewed tag? Maybe, it is easy to merge them through
Myungjoo.
Reg
Hi Matthias,
On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Matthias,
On 2018년 08월 03일 08:13, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Thu, Aug 02, 2018 at 10:58:59AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
>>> Hi Chanwoo,
>>>
>>>
Hi Matthias,
On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote:
>> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
>>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>>
Hi Matthias,
On 2018년 08월 02일 02:08, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Aug 01, 2018 at 10:22:16AM +0900, Chanwoo Choi wrote:
>> On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
>>> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>>
struct devfreq *devfreq);
> +
> /* Helper functions for devfreq user device driver with OPP. */
> extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> unsigned long *freq, u32 flags);
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
struct devfreq *devfreq);
> +
> /* Helper functions for devfreq user device driver with OPP. */
> extern struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
> unsigned long *freq, u32 flags);
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
among set of OPP entries
of CPU0 cpufreq? or
cpu0_opp03 indicates the set of OPP entries for CPU0 cpufreq ?
--
Best Regards,
Chanwoo Choi
Samsung Electronics
among set of OPP entries
of CPU0 cpufreq? or
cpu0_opp03 indicates the set of OPP entries for CPU0 cpufreq ?
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Matthias,
On 2018년 08월 01일 04:29, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Jul 12, 2018 at 06:08:36PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
Hi Matthias,
On 2018년 08월 01일 04:29, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 12:41:14PM -0700, Matthias Kaehlcke wrote:
>> Hi Chanwoo,
>>
>> On Thu, Jul 12, 2018 at 06:08:36PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년
On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
>&
On 2018년 08월 01일 04:39, Matthias Kaehlcke wrote:
> On Mon, Jul 16, 2018 at 10:50:50AM -0700, Matthias Kaehlcke wrote:
>> On Thu, Jul 12, 2018 at 05:44:33PM +0900, Chanwoo Choi wrote:
>>> Hi Matthias,
>>>
>>> On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
>&
Dear Greg,
This is extcon-next pull request for v4.19. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40:
Linux 4.18-rc1 (2018-06-17 08
Dear Greg,
This is extcon-next pull request for v4.19. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40:
Linux 4.18-rc1 (2018-06-17 08
dt-bindings/clock/s3c2443.h | 5 +
> include/dt-bindings/clock/samsung,s2mps11.h | 5 +
> include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++-
> 13 files changed, 20 insertions(+), 59 deletions(-)
>
Looks good to me.
Acked-by: Chanwoo Choi
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
dt-bindings/clock/s3c2443.h | 5 +
> include/dt-bindings/clock/samsung,s2mps11.h | 5 +
> include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++-
> 13 files changed, 20 insertions(+), 59 deletions(-)
>
Looks good to me.
Acked-by: Chanwoo Choi
(snip)
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Matthias,
On 2018년 07월 07일 03:09, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 02:30:32PM +0900, Chanwoo Choi wrote:
>
>> I didn't see any framework which exporting the class instance.
>> It is very dangerous. Unknown device drivers is able to res
Hi Matthias,
On 2018년 07월 07일 03:09, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 02:30:32PM +0900, Chanwoo Choi wrote:
>
>> I didn't see any framework which exporting the class instance.
>> It is very dangerous. Unknown device drivers is able to res
Hi Matthias,
On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote:
>
>> Firstly,
>> I'm not sure why devfreq needs the devfreq_verify_within_limits() function.
>>
>> devfreq alrea
Hi Matthias,
On 2018년 07월 07일 02:53, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 03:41:46PM +0900, Chanwoo Choi wrote:
>
>> Firstly,
>> I'm not sure why devfreq needs the devfreq_verify_within_limits() function.
>>
>> devfreq alrea
Hi Matthias,
On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Move variables related with devfreq policy changes from
Hi Matthias,
On 2018년 07월 07일 02:07, Matthias Kaehlcke wrote:
> Hi,
>
> On Wed, Jul 04, 2018 at 11:51:30AM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Move variables related with devfreq policy changes from
Hi Matthias,
On 2018년 07월 07일 01:36, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 11:20:31AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Commit ab8f58ad72c4 ("P
Hi Matthias,
On 2018년 07월 07일 01:36, Matthias Kaehlcke wrote:
> Hi Chanwoo,
>
> On Wed, Jul 04, 2018 at 11:20:31AM +0900, Chanwoo Choi wrote:
>> Hi Matthias,
>>
>> On 2018년 07월 04일 08:46, Matthias Kaehlcke wrote:
>>> Commit ab8f58ad72c4 ("P
On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
>> Another driver turned up that is missing linux/mod_devicetable.h after
>> the device IDs are split out from linux/platform_device.h:
>>
>> drivers/extcon/extcon-max3355.c:12
On 2018년 07월 12일 10:30, Chanwoo Choi wrote:
> On 2018년 07월 12일 00:50, Arnd Bergmann wrote:
>> Another driver turned up that is missing linux/mod_devicetable.h after
>> the device IDs are split out from linux/platform_device.h:
>>
>> drivers/extcon/extcon-max3355.c:12
con-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
> #include
>
> struct max3355_data {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
con-max3355.c
> +++ b/drivers/extcon/extcon-max3355.c
> @@ -14,6 +14,7 @@
> #include
> #include
> #include
> +#include
> #include
>
> struct max3355_data {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
eq.c b/drivers/devfreq/devfreq.c
> index 0b5b3abe054e..aa92fbf9f0dd 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
(snip)
Looks good to me.
Reviewed-by: Chanwoo Choi
Best Regards,
Chanwoo Choi
eq.c b/drivers/devfreq/devfreq.c
> index 0b5b3abe054e..aa92fbf9f0dd 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
(snip)
Looks good to me.
Reviewed-by: Chanwoo Choi
Best Regards,
Chanwoo Choi
Hi Enric,
Please send this patch to stable-kernel mailing list.
Regards,
Chanwoo Choi
On 2018년 07월 04일 17:26, Chanwoo Choi wrote:
> Hi Enric,
>
> On 2018년 07월 04일 17:16, Enric Balletbo i Serra wrote:
>> Hi Chanwoo,
>>
>> On 04/07/18 03:06, Chanwoo Choi wrote:
>>
Hi Enric,
Please send this patch to stable-kernel mailing list.
Regards,
Chanwoo Choi
On 2018년 07월 04일 17:26, Chanwoo Choi wrote:
> Hi Enric,
>
> On 2018년 07월 04일 17:16, Enric Balletbo i Serra wrote:
>> Hi Chanwoo,
>>
>> On 04/07/18 03:06, Chanwoo Choi wrote:
>>
Hi Enric,
On 2018년 07월 04일 17:16, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 04/07/18 03:06, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 07월 03일 22:29, Enric Balletbo i Serra wrote:
>>> When the devfreq driver and the governor drive
Hi Enric,
On 2018년 07월 04일 17:16, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 04/07/18 03:06, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 07월 03일 22:29, Enric Balletbo i Serra wrote:
>>> When the devfreq driver and the governor drive
freq);
> +}
> +
> +struct devfreq *dev_to_devfreq(struct device *dev);
> +
> #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
> /**
> * struct devfreq_simple_ondemand_data - void *data fed to struct devfreq
> @@ -394,10 +443,26 @@ static inline struct devfreq
> *devfreq_get_devfreq_by_phandle(struct device *dev,
> return ERR_PTR(-ENODEV);
> }
>
> +static inline void devfreq_verify_within_limits(struct devfreq_policy
> *policy,
> + unsigned int min, unsigned int max)
> +{
> +}
> +
> +static inline void
> +devfreq_verify_within_dev_limits(struct devfreq_policy *policy)
> +{
> +}
> +
> static inline int devfreq_update_stats(struct devfreq *df)
> {
> return -EINVAL;
> }
> +
> +static inline struct devfreq *dev_to_devfreq(struct device *dev)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_PM_DEVFREQ */
>
> #endif /* __LINUX_DEVFREQ_H__ */
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
freq);
> +}
> +
> +struct devfreq *dev_to_devfreq(struct device *dev);
> +
> #if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
> /**
> * struct devfreq_simple_ondemand_data - void *data fed to struct devfreq
> @@ -394,10 +443,26 @@ static inline struct devfreq
> *devfreq_get_devfreq_by_phandle(struct device *dev,
> return ERR_PTR(-ENODEV);
> }
>
> +static inline void devfreq_verify_within_limits(struct devfreq_policy
> *policy,
> + unsigned int min, unsigned int max)
> +{
> +}
> +
> +static inline void
> +devfreq_verify_within_dev_limits(struct devfreq_policy *policy)
> +{
> +}
> +
> static inline int devfreq_update_stats(struct devfreq *df)
> {
> return -EINVAL;
> }
> +
> +static inline struct devfreq *dev_to_devfreq(struct device *dev)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_PM_DEVFREQ */
>
> #endif /* __LINUX_DEVFREQ_H__ */
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
I didn't see any framework which exporting the class instance.
It is very dangerous. Unknown device drivers is able to reset
the 'devfreq_class' instance. I can't agree this approach.
Regards,
Chanwoo Choi
On 2018년 07월 04일 08:47, Matthias Kaehlcke wrote:
> Exporting the device class all
Hi,
I didn't see any framework which exporting the class instance.
It is very dangerous. Unknown device drivers is able to reset
the 'devfreq_class' instance. I can't agree this approach.
Regards,
Chanwoo Choi
On 2018년 07월 04일 08:47, Matthias Kaehlcke wrote:
> Exporting the device class all
ate data for governors */
>
> - unsigned long min_freq;
> - unsigned long max_freq;
> - unsigned long scaling_min_freq;
> - unsigned long scaling_max_freq;
> + struct devfreq_policy policy;
I recommend that you better to move under 'struct devfreq_dev_profile'
as following:
struct devfreq_dev_profile *profile;
struct devfreq_policy policy;
> bool stop_polling;
>
> /* information for device frequency transition */
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
ate data for governors */
>
> - unsigned long min_freq;
> - unsigned long max_freq;
> - unsigned long scaling_min_freq;
> - unsigned long scaling_max_freq;
> + struct devfreq_policy policy;
I recommend that you better to move under 'struct devfreq_dev_profile'
as following:
struct devfreq_dev_profile *profile;
struct devfreq_policy policy;
> bool stop_polling;
>
> /* information for device frequency transition */
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
> drivers/devfreq/governor_simpleondemand.c | 12 +++-
> drivers/devfreq/governor_userspace.c | 16
> 5 files changed, 12 insertions(+), 26 deletions(-)
Actually, I preferred to use 'df->scaling_min/max_freq'
instead of DEVFREQ_MIN/MAX_FREQ. But, DEVFREQ_
> drivers/devfreq/governor_simpleondemand.c | 12 +++-
> drivers/devfreq/governor_userspace.c | 16
> 5 files changed, 12 insertions(+), 26 deletions(-)
Actually, I preferred to use 'df->scaling_min/max_freq'
instead of DEVFREQ_MIN/MAX_FREQ. But, DEVFREQ_
ret = -EINVAL;
> + goto unlock;
> + }
> + } else {
> + freq_table = df->profile->freq_table;
> + /* typical order is ascending, some drivers use descending */
ditto.
/* Get maximum frequency according to sorting way */
> + if (freq_table[0] < freq_table[df->profile->max_state - 1])
> + value = freq_table[df->profile->max_state - 1];
> + else
> + value = freq_table[0];
> }
>
> df->max_freq = value;
>
If you agree my comment and modify this patch according to my comment,
feel free to add my review tag.
- Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
ret = -EINVAL;
> + goto unlock;
> + }
> + } else {
> + freq_table = df->profile->freq_table;
> + /* typical order is ascending, some drivers use descending */
ditto.
/* Get maximum frequency according to sorting way */
> + if (freq_table[0] < freq_table[df->profile->max_state - 1])
> + value = freq_table[df->profile->max_state - 1];
> + else
> + value = freq_table[0];
> }
>
> df->max_freq = value;
>
If you agree my comment and modify this patch according to my comment,
feel free to add my review tag.
- Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
gt; -
This change is not related to this patch.
> device_unregister(>dev);
> err_dev:
> if (devfreq)
> @@ -989,7 +1029,8 @@ static ssize_t governor_store(struct device *dev, struct
> device_attribute *attr,
> return -EINVAL;
>
> mutex_lock(_list_lock);
> - governor = find_devfreq_governor(str_governor);
> +
Don't need to add the blank line. It is enough to change the function
from find_devfreq_governor to try_then_request_governor.
> + governor = try_then_request_governor(str_governor);
> if (IS_ERR(governor)) {
> ret = PTR_ERR(governor);
> goto out;
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
gt; -
This change is not related to this patch.
> device_unregister(>dev);
> err_dev:
> if (devfreq)
> @@ -989,7 +1029,8 @@ static ssize_t governor_store(struct device *dev, struct
> device_attribute *attr,
> return -EINVAL;
>
> mutex_lock(_list_lock);
> - governor = find_devfreq_governor(str_governor);
> +
Don't need to add the blank line. It is enough to change the function
from find_devfreq_governor to try_then_request_governor.
> + governor = try_then_request_governor(str_governor);
> if (IS_ERR(governor)) {
> ret = PTR_ERR(governor);
> goto out;
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Enric,
On 2018년 06월 20일 19:32, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 20/06/18 02:47, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 06월 19일 17:22, Enric Balletbo i Serra wrote:
>>> Hi Chanwoo,
>>>
>>> On 18/06/18 11:02, Enri
Hi Enric,
On 2018년 06월 20일 19:32, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 20/06/18 02:47, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 06월 19일 17:22, Enric Balletbo i Serra wrote:
>>> Hi Chanwoo,
>>>
>>> On 18/06/18 11:02, Enri
Hi Enric,
On 2018년 06월 19일 17:07, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 19/06/18 06:18, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 06월 18일 18:10, Enric Balletbo Serra wrote:
>>> Hi Chanwoo,
>>>
>>> Missatge de Cha
Hi Enric,
On 2018년 06월 19일 17:07, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 19/06/18 06:18, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2018년 06월 18일 18:10, Enric Balletbo Serra wrote:
>>> Hi Chanwoo,
>>>
>>> Missatge de Cha
Hi Enric,
On 2018년 06월 19일 17:22, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 18/06/18 11:02, Enric Balletbo Serra wrote:
>> Hi Chanwoo,
>> Missatge de Chanwoo Choi del dia dg., 17 de juny
>> 2018 a les 5:50:
>>>
>>> Hi Enric,
>>
Hi Enric,
On 2018년 06월 19일 17:22, Enric Balletbo i Serra wrote:
> Hi Chanwoo,
>
> On 18/06/18 11:02, Enric Balletbo Serra wrote:
>> Hi Chanwoo,
>> Missatge de Chanwoo Choi del dia dg., 17 de juny
>> 2018 a les 5:50:
>>>
>>> Hi Enric,
>>
Hi Enric,
On 2018년 06월 18일 18:10, Enric Balletbo Serra wrote:
> Hi Chanwoo,
>
> Missatge de Chanwoo Choi del dia dg., 17 de juny
> 2018 a les 5:23:
>>
>> Hi Enric,
>>
>> 2018-06-16 0:12 GMT+09:00 Enric Balletbo i Serra
>> :
>>> The opp table
Hi Enric,
On 2018년 06월 18일 18:10, Enric Balletbo Serra wrote:
> Hi Chanwoo,
>
> Missatge de Chanwoo Choi del dia dg., 17 de juny
> 2018 a les 5:23:
>>
>> Hi Enric,
>>
>> 2018-06-16 0:12 GMT+09:00 Enric Balletbo i Serra
>> :
>>> The opp table
__func__);
> + err = PTR_ERR(governor);
> + goto err_init;
> + }
> }
>
> devfreq->governor = governor;
> @@ -669,7 +695,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
> err_init:
> list_del(>node);
> mutex_unlock(_list_lock);
> -
> +err_unregister:
> device_unregister(>dev);
> err_dev:
> if (devfreq)
> --
> 2.17.1
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
__func__);
> + err = PTR_ERR(governor);
> + goto err_init;
> + }
> }
>
> devfreq->governor = governor;
> @@ -669,7 +695,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
> err_init:
> list_del(>node);
> mutex_unlock(_list_lock);
> -
> +err_unregister:
> device_unregister(>dev);
> err_dev:
> if (devfreq)
> --
> 2.17.1
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
pp;
> + }
> +
> devm_devfreq_register_opp_notifier(dev, data->devfreq);
>
> data->dev = dev;
> platform_set_drvdata(pdev, data);
>
> + return 0;
It looks strange. Because rk3399_dmcfreq_probe() already include
'return 0' when success.
What is the base commit of this patch?
[snip]
Anyway, if probe fail, device driver have to remove registered OPP table.
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
pp;
> + }
> +
> devm_devfreq_register_opp_notifier(dev, data->devfreq);
>
> data->dev = dev;
> platform_set_drvdata(pdev, data);
>
> + return 0;
It looks strange. Because rk3399_dmcfreq_probe() already include
'return 0' when success.
What is the base commit of this patch?
[snip]
Anyway, if probe fail, device driver have to remove registered OPP table.
Looks good to me.
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
2018-06-14 20:33 GMT+09:00 H. Nikolaus Schaller :
>
>> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller :
>>
>> Hi Roger and Chanwoo,
>>
>>> Am 14.06.2018 um 12:18 schrieb Chanwoo Choi :
>>>
>>> + H. Nikolaus Schaller
>>>
Hi,
2018-06-14 20:33 GMT+09:00 H. Nikolaus Schaller :
>
>> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller :
>>
>> Hi Roger and Chanwoo,
>>
>>> Am 14.06.2018 um 12:18 schrieb Chanwoo Choi :
>>>
>>> + H. Nikolaus Schaller
>>>
Hi Roger,
If possible, Could you please review this patch?
Regards,
Chanwoo Choi
On 2018년 06월 14일 20:33, H. Nikolaus Schaller wrote:
>
>> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller :
>>
>> Hi Roger and Chanwoo,
>>
>>> Am 14.06.2018 um 12:1
Hi Roger,
If possible, Could you please review this patch?
Regards,
Chanwoo Choi
On 2018년 06월 14일 20:33, H. Nikolaus Schaller wrote:
>
>> Am 14.06.2018 um 12:39 schrieb H. Nikolaus Schaller :
>>
>> Hi Roger and Chanwoo,
>>
>>> Am 14.06.2018 um 12:1
+ H. Nikolaus Schaller
On 2018년 06월 14일 13:14, Chanwoo Choi wrote:
> Previously, extcon used the spinlock before calling the notifier_call_chain
> to prevent the scheduled out of task and to prevent the notification delay.
> When spinlock is locked for sending the notification, deadl
+ H. Nikolaus Schaller
On 2018년 06월 14일 13:14, Chanwoo Choi wrote:
> Previously, extcon used the spinlock before calling the notifier_call_chain
> to prevent the scheduled out of task and to prevent the notification delay.
> When spinlock is locked for sending the notification, deadl
Hi Nikolaus,
On 2018년 06월 14일 18:58, H. Nikolaus Schaller wrote:
> Hi Roger and Chanwoo,
>
>> Am 14.06.2018 um 10:34 schrieb Roger Quadros :
>>
>> On 14/06/18 04:20, Chanwoo Choi wrote:
>>> Hi Roger,
>>>
>>> On 2018년 06월 11일 17:53, Roger Quadr
Hi Nikolaus,
On 2018년 06월 14일 18:58, H. Nikolaus Schaller wrote:
> Hi Roger and Chanwoo,
>
>> Am 14.06.2018 um 10:34 schrieb Roger Quadros :
>>
>> On 14/06/18 04:20, Chanwoo Choi wrote:
>>> Hi Roger,
>>>
>>> On 2018년 06월 11일 17:53, Roger Quadr
;)
Cc: sta...@vger.kernel.org
Cc: Roger Quadros
Cc: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 8bff5fd18185..f75b08a45d4e 100644
---
;)
Cc: sta...@vger.kernel.org
Cc: Roger Quadros
Cc: Kishon Vijay Abraham I
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 8bff5fd18185..f75b08a45d4e 100644
---
nsigned int id)
*/
raw_notifier_call_chain(>nh_all, state, edev);
+ spin_lock_irqsave(>lock, flags);
+
>
> I think we don't want to call all notifiers in atomic context as this would
> keep interrupts disabled
> for quite some time and is suboptimal.
>
>> dwc3_omap_set_mailbox should move dis/enabling regulator to some worker
>> thread so
>> that they can block.
>>
>> The best would be to make dwc3_omap_set_mailbox call
>> regulator_enable_deferred(omap->vbus_reg, 0)
>> but that function does not exist.
>>
>> Any ideas?
>>
>> BR,
>> Nikolaus
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
nsigned int id)
*/
raw_notifier_call_chain(>nh_all, state, edev);
+ spin_lock_irqsave(>lock, flags);
+
>
> I think we don't want to call all notifiers in atomic context as this would
> keep interrupts disabled
> for quite some time and is suboptimal.
>
>> dwc3_omap_set_mailbox should move dis/enabling regulator to some worker
>> thread so
>> that they can block.
>>
>> The best would be to make dwc3_omap_set_mailbox call
>> regulator_enable_deferred(omap->vbus_reg, 0)
>> but that function does not exist.
>>
>> Any ideas?
>>
>> BR,
>> Nikolaus
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 2018년 05월 31일 06:13, Matthias Kaehlcke wrote:
> On Wed, May 30, 2018 at 05:04:14PM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote:
>>> On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote:
>>>> Hi,
Hi,
On 2018년 05월 31일 06:13, Matthias Kaehlcke wrote:
> On Wed, May 30, 2018 at 05:04:14PM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote:
>>> On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote:
>>>> Hi,
or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// ChromeOS Embedded Controller extcon
> +//
> +// Copyright (C) 2012 Google, Inc.
2012 is right?
The original copyright has '2017' year in
or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +// ChromeOS Embedded Controller extcon
> +//
> +// Copyright (C) 2012 Google, Inc.
2012 is right?
The original copyright has '2017' year in
Hi,
On 2018년 05월 30일 05:57, Matthias Kaehlcke wrote:
> On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote:
>
>> IMHO, you better to split out the devfreq patches from
>> 'throttler' patch set. Because I'm not sure throttler is either
>> necessary or no
Hi,
On 2018년 05월 30일 05:57, Matthias Kaehlcke wrote:
> On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote:
>
>> IMHO, you better to split out the devfreq patches from
>> 'throttler' patch set. Because I'm not sure throttler is either
>> necessary or no
Hi,
On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote:
> On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote:
>>> Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding the
>&
Hi,
On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote:
> On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote:
>>> Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding the
>&
.
Regards,
Chanwoo Choi
On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote:
> The purpose of the throttler is to provide support for non-thermal
> throttling. Throttling is triggered by external event, e.g. the
> detection of a high battery discharge current, close to the OCP limit
> of
.
Regards,
Chanwoo Choi
On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote:
> The purpose of the throttler is to provide support for non-thermal
> throttling. Throttling is triggered by external event, e.g. the
> detection of a high battery discharge current, close to the OCP limit
> of
{
> - *freq = df->max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = df->max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = df->max_freq;
> + *freq = df->scaling_max_freq;
> return 0;
> }
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
+ }
> }
>
> df->max_freq = value;
>
Actually, min_freq_store() and max_freq_store() are very similar.
But, this patch changed the order of conditional statement as following:
If there is no special reason, you better to keep the same format
for the readability.
min_freq_store()
if (value) {
...
} else {
value = df->profile->freq_table[df->profile->max_state - 1];
}
max_freq_store()
if (!value) {
value = df->profile->freq_table[0];
} else {
...
--
Best Regards,
Chanwoo Choi
Samsung Electronics
}
>
> df->max_freq = value;
>
Actually, min_freq_store() and max_freq_store() are very similar.
But, this patch changed the order of conditional statement as following:
If there is no special reason, you better to keep the same format
for the readability.
min_freq_store()
if (value) {
...
} else {
value = df->profile->freq_table[df->profile->max_state - 1];
}
max_freq_store()
if (!value) {
value = df->profile->freq_table[0];
} else {
...
--
Best Regards,
Chanwoo Choi
Samsung Electronics
if (df->min_freq && adjusted_freq < df->min_freq)
> - adjusted_freq = df->min_freq;
> -
> - *freq = adjusted_freq;
> - } else {
> + if (data->valid)
> + *freq = data->user_frequency;
> + else
> *freq = df->previous_freq; /* No user freq specified yet */
> - }
> +
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
&& adjusted_freq < df->min_freq)
> - adjusted_freq = df->min_freq;
> -
> - *freq = adjusted_freq;
> - } else {
> + if (data->valid)
> + *freq = data->user_frequency;
> + else
> *freq = df->previous_freq; /* No user freq specified yet */
> - }
> +
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
x;
> + *freq = df->max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = max;
> + *freq = df->max_freq;
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
gt;max_freq;
> return 0;
> }
>
> /* Set MAX if we do not know the initial frequency */
> if (stat->current_frequency == 0) {
> - *freq = max;
> + *freq = df->max_freq;
> return 0;
> }
>
>
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
if (!devfreq->scaling_max_freq) {
> mutex_unlock(>lock);
> err = -EINVAL;
> goto err_dev;
> }
> - devfreq->scaling_max_freq = devfreq->max_freq;
> + devfreq->max_freq = devfreq->scaling_max_freq;
>
>
eq) {
> mutex_unlock(>lock);
> err = -EINVAL;
> goto err_dev;
> }
> - devfreq->scaling_max_freq = devfreq->max_freq;
> + devfreq->max_freq = devfreq->scaling_max_freq;
>
> dev_set_name(>dev, "devfreq%d",
> atomic_inc_return(_no));
>
I already replied with my Reviewed-by tag. You are missing my tag.
Again,
Reviewed-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
u;
> +
> return 0;
>
> err_out:
> diff --git a/include/soc/rockchip/rk3399_dmc.h
> b/include/soc/rockchip/rk3399_dmc.h
> new file mode 100644
> index ..031a62607f61
> --- /dev/null
> +++ b/include/soc/rockchip/rk3399_dmc.h
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2016-2018, Fuzhou Rockchip Electronics Co., Ltd
> + * Author: Lin Huang <h...@rock-chips.com>
> + */
> +
> +#ifndef __SOC_RK3399_DMC_H
> +#define __SOC_RK3399_DMC_H
> +
> +#include
> +
> +int rockchip_pm_register_dmcfreq_notifier(struct devfreq *devfreq);
> +
> +#endif
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
701 - 800 of 7212 matches
Mail list logo
