Re: [PATCH v5 6/6] drm/bridge/sii8620: use micro-USB cable detection logic to detect MHL

sii8620_hw_off(ctx); > + if (ctx->extcon) { > + extcon_unregister_notifier(ctx->extcon, EXTCON_DISP_MHL, > +>extcon_nb); Don't need to unregister the notifier if using devm_extcon_register_notifier(). > + flush_work(>extcon_wq); > + if (ctx->cable_state > 0) > + sii8620_cable_out(ctx); > + } else { > + sii8620_cable_out(ctx); > + } > drm_bridge_remove(>bridge); > > return 0; > If you use the resource managed function (devm_extcon_register_notifier), Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > Since extcon property is not allowed in DT, extcon subsystem requires > another way to get extcon device. Lets try the simplest approach - get > edev by of_node. > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> >

Re: [PATCH v5 5/6] extcon: add possibility to get extcon device by OF node

Hi, On 2018년 02월 27일 16:11, Andrzej Hajda wrote: > Since extcon property is not allowed in DT, extcon subsystem requires > another way to get extcon device. Lets try the simplest approach - get > edev by of_node. > > Signed-off-by: Andrzej Hajda > Acked-by: Chanwoo Choi &g

Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin

PIOF_DIR_IN) { > - dev_warn(dev, FW_BUG "USB ID GPIO not in input mode, fixing\n"); > - gpiod_direction_input(data->gpio_usb_id); > } > > data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id); > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v1] extcon: int3496: Ignore incorrect IoRestriction for ID pin

PIO not in input mode, fixing\n"); > - gpiod_direction_input(data->gpio_usb_id); > } > > data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id); > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

reg = <0x121B 0x1000>; > + reg = <0x121b 0x1000>; > interrupts = ; > clocks = < CLK_PDMA1>; > clock-names = "apb_pclk"; > Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/2] ARM: dts: exynos: Fix unit addresses of PDMA nodes in Exynos5410

000>; > + reg = <0x121b 0x1000>; > interrupts = ; > clocks = < CLK_PDMA1>; > clock-names = "apb_pclk"; > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

= <_g2d>; > }; > > + ppmu_acp: ppmu_acp@10ae { > + compatible = "samsung,exynos-ppmu"; > + reg = <0x10ae 0x2000>; > + status = "disabled"; > +

Re: [PATCH 1/2] ARM: dts: exynos: Fix address of PPMU ACP on Exynos4210

;_g2d>; > }; > > + ppmu_acp: ppmu_acp@10ae { > + compatible = "samsung,exynos-ppmu"; > + reg = <0x10ae 0x2000>; > + status = "disabled"; > + }; > + > ppmu_lcd1: ppmu_lcd1@1224 { > compatible = "samsung,exynos-ppmu"; > reg = <0x1224 0x2000>; > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2] extcon: intel-cht-wc: Also set direction and drv flags for V5 boost GPIO

GPIO_CTLO, > - CHT_WC_VBUS_GPIO_CTLO_OUTPUT, val); > + val = CHT_WC_VBUS_GPIO_CTLO_DRV_OD | CHT_WC_VBUS_GPIO_CTLO_DIR_OUT; > + if (enable) > + val |= CHT_WC_VBUS_GPIO_CTLO_OUTPUT; > + > + ret = regmap_write(ext->regmap, CHT_WC_VBUS_GPIO_CT

Re: [PATCH v2] extcon: intel-cht-wc: Also set direction and drv flags for V5 boost GPIO

_VBUS_GPIO_CTLO_OUTPUT, val); > + val = CHT_WC_VBUS_GPIO_CTLO_DRV_OD | CHT_WC_VBUS_GPIO_CTLO_DIR_OUT; > + if (enable) > + val |= CHT_WC_VBUS_GPIO_CTLO_OUTPUT; > + > + ret = regmap_write(ext->regmap, CHT_WC_VBUS_GPIO_CTLO, val); > if (ret) > dev_err(ext->dev, "Error writing Vbus GPIO CTLO: %d\n", ret); > } > Applied it to extcon-fixes branch. -- Best Regards, Chanwoo Choi Samsung Electronics

[GIT PULL] extcon fixes for v4.16-rc3

Dear Greg, This is extcon-fixes pull request for v4.16-rc3. I add detailed description of this pull request on below. Please pull extcon with following updates. Best Regards, Chanwoo Choi The following changes since commit 7928b2cbe55b2a410a0f5c1f154610059c57b1b2: Linux 4.16-rc1 (2018-02-11

[GIT PULL] extcon fixes for v4.16-rc3

Dear Greg, This is extcon-fixes pull request for v4.16-rc3. I add detailed description of this pull request on below. Please pull extcon with following updates. Best Regards, Chanwoo Choi The following changes since commit 7928b2cbe55b2a410a0f5c1f154610059c57b1b2: Linux 4.16-rc1 (2018-02-11

Re: [PATCH v4] extcon: int3496: process id-pin first so that we start with the right status

ocessing of id-pin */ > + /* process id-pin so that we start with the right status */ > queue_delayed_work(system_wq, >work, 0); > + flush_delayed_work(>work); > > platform_set_drvdata(pdev, data); > > Applied it instead of v3. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v4] extcon: int3496: process id-pin first so that we start with the right status

process id-pin so that we start with the right status */ > queue_delayed_work(system_wq, >work, 0); > + flush_delayed_work(>work); > > platform_set_drvdata(pdev, data); > > Applied it instead of v3. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] extcon: intel-cht-wc: Also set direction and drv flags for V5 boost GPIO

val |= CHT_WC_VBUS_GPIO_CTLO_OUTPUT; > + > + ret = regmap_write(ext->regmap, CHT_WC_VBUS_GPIO_CTLO, val); > if (ret) > dev_err(ext->dev, "Error writing Vbus GPIO CTLO: %d\n", ret); > } > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] extcon: intel-cht-wc: Also set direction and drv flags for V5 boost GPIO

UT; > + > + ret = regmap_write(ext->regmap, CHT_WC_VBUS_GPIO_CTLO, val); > if (ret) > dev_err(ext->dev, "Error writing Vbus GPIO CTLO: %d\n", ret); > } > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe()

return -ENOMEM; > - } > + > edev = info->edev; > platform_set_drvdata(pdev, info); > > Acked-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe()

size, GFP_KERNEL); > - if (!info->edev) { > - dev_err(>dev, > - "failed to allocate memory devfreq-event devices\n"); > + if (!info->edev) > return -ENOMEM; > - } > + > edev = info->edev; > platform_set_drvdata(pdev, info); > > Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v3 2/3] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

++-- > 1 file changed, 2 insertions(+), 30 deletions(-) Applied it. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v3 2/3] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

> 1 file changed, 2 insertions(+), 30 deletions(-) Applied it. [snip] -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status

ter(dev, data->edev); > if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) > return ret; > } > > - /* queue ini

Re: [PATCH v3 3/3] extcon: int3496: process id-pin first so that we start with the right status

if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > @@ -153,9 +157,6 @@ static int int3496_probe(struct platform_device *pdev) > return ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, >work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v3 1/3] extcon: axp288: Constify the axp288_pwr_up_down_info array

xtcon_log_rsi(struct axp288_extcon_info *info) > { > - char **rsi; > + const char * const *rsi; > unsigned int val, i, clear_mask = 0; > int ret; > > Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v3 1/3] extcon: axp288: Constify the axp288_pwr_up_down_info array

88_extcon_info *info) > { > - char **rsi; > + const char * const *rsi; > unsigned int val, i, clear_mask = 0; > int ret; > > Applied it. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

, 1, 3, 0), > PLL_36XX_RATE(25200U, 84, 1, 3, 0), > + PLL_36XX_RATE(196608001U, 197, 3, 3, -25690), > { /* sentinel */ } > }; Looks good to me. Acked-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2] clk: exynos5433: Extend list of available AUD_PLL output frequencies

), > PLL_36XX_RATE(25200U, 84, 1, 3, 0), > + PLL_36XX_RATE(196608001U, 197, 3, 3, -25690), > { /* sentinel */ } > }; Looks good to me. Acked-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Sylwester, On 2018년 02월 12일 20:45, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 02/09/2018 08:36 AM, Chanwoo Choi wrote: >> On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: >>> On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>>>> dr

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Sylwester, On 2018년 02월 12일 20:45, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 02/09/2018 08:36 AM, Chanwoo Choi wrote: >> On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: >>> On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>>>> dr

Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status

On 2018년 02월 06일 17:14, Chanwoo Choi wrote: > On 2018년 02월 06일 17:10, Hans de Goede wrote: >> Some other drivers may be waiting for our extcon to show-up (exiting their >> probe methods with -EPROBE_DEFER until we show up). >> >> These drivers will typically get the

Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status

On 2018년 02월 06일 17:14, Chanwoo Choi wrote: > On 2018년 02월 06일 17:10, Hans de Goede wrote: >> Some other drivers may be waiting for our extcon to show-up (exiting their >> probe methods with -EPROBE_DEFER until we show up). >> >> These drivers will typically get the

Re: [PATCH] extcon: intel-int3496: Fix oops on probe

>edev)) > - return -ENOMEM; > - > ret = devm_extcon_dev_register(dev, data->edev); > if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > Instead, You better to send v3 after merging your patch[1] and this patch. [1] extcon: int3496: process id-pin first so that we start with the right status -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] extcon: intel-int3496: Fix oops on probe

return -ENOMEM; > - > ret = devm_extcon_dev_register(dev, data->edev); > if (ret < 0) { > dev_err(dev, "can't register extcon device: %d\n", ret); > Instead, You better to send v3 after merging your patch[1] and this patch. [1] extcon: int3496: process id-pin first so that we start with the right status -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Sylwester, On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >>> 1 file changed, 11 insertions(+), 11 deletions(-) >>> >

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

Hi Sylwester, On 2018년 02월 08일 00:18, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 02/06/2018 05:06 AM, Chanwoo Choi wrote: >>> drivers/clk/samsung/clk-exynos5433.c | 22 +++--- >>> 1 file changed, 11 insertions(+), 11 deletions(-) >>> >

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 2018년 02월 07일 22:04, Sylwester Nawrocki wrote: > On 02/07/2018 12:24 PM, Chanwoo Choi wrote: >> Could you share your equation? >> because your result is a little bit different of my result. >> - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv)) > >

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 2018년 02월 07일 22:04, Sylwester Nawrocki wrote: > On 02/07/2018 12:24 PM, Chanwoo Choi wrote: >> Could you share your equation? >> because your result is a little bit different of my result. >> - my equation : ((mdiv + kdiv/65535) x 24MHz) / (pdiv x POWER(2,sdiv)) > >

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 2018년 02월 07일 19:29, Sylwester Nawrocki wrote: > On 02/06/2018 03:44 AM, Chanwoo Choi wrote: >> When I developed the clk-exynos5433.c I referred to the following >> description. >> TRM specified that "Samsung recommends only the values >> between 252MH ~

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

On 2018년 02월 07일 19:29, Sylwester Nawrocki wrote: > On 02/06/2018 03:44 AM, Chanwoo Choi wrote: >> When I developed the clk-exynos5433.c I referred to the following >> description. >> TRM specified that "Samsung recommends only the values >> between 252MH ~

Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status

oede <hdego...@redhat.com> > --- > drivers/extcon/extcon-intel-int3496.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH v2] extcon: int3496: process id-pin first so that we start with the right status

Goede > --- > drivers/extcon/extcon-intel-int3496.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk

K_SCLK_SPDIF, "sclk_spdif", "sclk_spdif_peric", > ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", > If any device driver handles the sclk_ioclk_i2s1_bclk on later, CLK_IGNORE_UNUSED will be ignored. Looks good to me. Reviewed-by: Chanwoo Choi <cw00.c...@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 3/3] clk: exynos5433: Add CLK_IGNORE_UNUSED flag to sclk_ioclk_i2s1_bclk

", "sclk_spdif_peric", > ENABLE_SCLK_PERIC, 8, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", > If any device driver handles the sclk_ioclk_i2s1_bclk on later, CLK_IGNORE_UNUSED will be ignored. Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

samsung_gate_clock top_gate_clks[] > __initconst = { > GATE(CLK_SCLK_SLIMBUS, "sclk_slimbus", "mout_sclk_slimbus", > MUX_ENABLE_TOP_PERIC1, 16, 0, 0), > GATE(CLK_SCLK_AUDIO1, "sclk_audio1", "div_sclk_audio1", > - MUX_ENABLE_TOP_PERIC1, 4, 0, 0), > + MUX_ENABLE_TOP_PERIC1, 4, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_AUDIO0, "sclk_audio0", "div_sclk_audio0", > MUX_ENABLE_TOP_PERIC1, 0, 0, 0), > }; > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/3] clk: exynos5433: Allow audio subsystem clock rate propagation

g_gate_clock top_gate_clks[] > __initconst = { > GATE(CLK_SCLK_SLIMBUS, "sclk_slimbus", "mout_sclk_slimbus", > MUX_ENABLE_TOP_PERIC1, 16, 0, 0), > GATE(CLK_SCLK_AUDIO1, "sclk_audio1", "div_sclk_audio1", > - MUX_ENABLE_TOP_PERIC1, 4, 0, 0), > + MUX_ENABLE_TOP_PERIC1, 4, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_AUDIO0, "sclk_audio0", "div_sclk_audio0", > MUX_ENABLE_TOP_PERIC1, 0, 0, 0), > }; > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

36XX_RATE(131072006U, 131, 3, 3, 4719), > + PLL_36XX_RATE(1U, 200, 3, 4, 0), > + PLL_36XX_RATE(65536003U, 131, 3, 4, 4719), > + PLL_36XX_RATE(49152000U, 197, 3, 5, -25690), > + PLL_36XX_RATE(32768001U, 131, 3, 5, 4719), > { /* sentinel */ } > }; > > -- > 2.14.2 > > > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 1/3] clk: exynos5433: Extend list of available AUD_PLL output frequencies

72006U, 131, 3, 3, 4719), > + PLL_36XX_RATE(1U, 200, 3, 4, 0), > + PLL_36XX_RATE(65536003U, 131, 3, 4, 4719), > + PLL_36XX_RATE(49152000U, 197, 3, 5, -25690), > + PLL_36XX_RATE(32768001U, 131, 3, 5, 4719), > { /* sentinel */ } > }; > > -- > 2.14.2 > > > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] clk: samsung: Add git tree entry to MAINTAINERS

NTAINERS b/MAINTAINERS > index aa71ab52fd76..502442dc08eb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12001,6 +12001,7 @@ M:Tomasz Figa <tomasz.f...@gmail.com> > M: Chanwoo Choi <cw00.c...@samsung.com> > S: Supported > L: linux-samsung-...@

Re: [PATCH] clk: samsung: Add git tree entry to MAINTAINERS

ERS > index aa71ab52fd76..502442dc08eb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12001,6 +12001,7 @@ M: Tomasz Figa > M: Chanwoo Choi > S: Supported > L: linux-samsung-...@vger.kernel.org (moderated for non-subscribers) > +T: git git://git.kernel.org/pub/scm/li

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

On 2018년 02월 02일 17:10, Hans de Goede wrote: > Hi, > > On 02-02-18 01:32, Chanwoo Choi wrote: >> On 2018년 01월 26일 04:39, Hans de Goede wrote: >>> Some other drivers may be waiting for our extcon to show-up (exiting their >>> probe methods wi

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

On 2018년 02월 02일 17:10, Hans de Goede wrote: > Hi, > > On 02-02-18 01:32, Chanwoo Choi wrote: >> On 2018년 01월 26일 04:39, Hans de Goede wrote: >>> Some other drivers may be waiting for our extcon to show-up (exiting their >>> probe methods wi

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

ev) > return ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, >work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Looks good to me. How about adding the 'Fixes' commit i

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

urn ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, >work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Looks good to me. How about adding the 'Fixes' commit id on patch description? I think that your revert patch of axp288 and this patch should be included in extcon-fixes branch. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

Hi, On 2018년 02월 02일 08:48, Hans de Goede wrote: > Hi, > > On 01-02-18 22:22, Chanwoo Choi wrote: >> Hi Hans, >> >> Why don't modify the extcon-axp288.c after revert it? > > Fixing the axp288 extcon code properly requires usb-role-switch support > which

Re: [PATCH] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

Hi, On 2018년 02월 02일 08:48, Hans de Goede wrote: > Hi, > > On 01-02-18 22:22, Chanwoo Choi wrote: >> Hi Hans, >> >> Why don't modify the extcon-axp288.c after revert it? > > Fixing the axp288 extcon code properly requires usb-role-switch support > which

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

ev) > return ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, >work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] extcon: int3496: process id-pin first so that we start with the right status

urn ret; > } > > - /* queue initial processing of id-pin */ > - queue_delayed_work(system_wq, >work, 0); > - > platform_set_drvdata(pdev, data); > > return 0; > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

info->previous_cable = EXTCON_NONE; > - INIT_DELAYED_WORK(>det_work, axp288_extcon_det_work); > > platform_set_drvdata(pdev, info); > > @@ -315,7 +287,7 @@ static int axp288_extcon_probe(struct platform_device > *pdev) > } > > /* Start charger cable type detection */ > - queue_delayed_work(system_wq, >det_work, 0); > + axp288_extcon_enable(info); > > return 0; > } > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH] Revert "extcon: axp288: Redo charger type detection a couple of seconds after probe()"

_det_work); > > platform_set_drvdata(pdev, info); > > @@ -315,7 +287,7 @@ static int axp288_extcon_probe(struct platform_device > *pdev) > } > > /* Start charger cable type detection */ > - queue_delayed_work(system_wq, >det_work, 0); > + axp288_extcon_enable(info); > > return 0; > } > -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 16일 18:33, Hans de Goede wrote: > Hi, > > On 16-01-18 00:43, Chanwoo Choi wrote: >> On 2018년 01월 15일 20:32, Hans de Goede wrote: >>> HI, >>> >>> On 15-01-18 10:08, Chanwoo Choi wrote: >>>> On 2018년 01월 15일 17:36, Hans de Goede w

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 16일 18:33, Hans de Goede wrote: > Hi, > > On 16-01-18 00:43, Chanwoo Choi wrote: >> On 2018년 01월 15일 20:32, Hans de Goede wrote: >>> HI, >>> >>> On 15-01-18 10:08, Chanwoo Choi wrote: >>>> On 2018년 01월 15일 17:36, Hans de Goede w

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 15일 20:32, Hans de Goede wrote: > HI, > > On 15-01-18 10:08, Chanwoo Choi wrote: >> On 2018년 01월 15일 17:36, Hans de Goede wrote: >>> Hi, >>> >>> On 15-01-18 06:22, Chanwoo Choi wrote: >>>> On 2018년 01월 15일 00:10, Hans de Goe

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 15일 20:32, Hans de Goede wrote: > HI, > > On 15-01-18 10:08, Chanwoo Choi wrote: >> On 2018년 01월 15일 17:36, Hans de Goede wrote: >>> Hi, >>> >>> On 15-01-18 06:22, Chanwoo Choi wrote: >>>> On 2018년 01월 15일 00:10, Hans de Goe

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 15일 17:36, Hans de Goede wrote: > Hi, > > On 15-01-18 06:22, Chanwoo Choi wrote: >> On 2018년 01월 15일 00:10, Hans de Goede wrote: >>> The only misdetection which can happen at boot due to data-lines mux issues >>> is detecting a non SDP as SDP, so w

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

On 2018년 01월 15일 17:36, Hans de Goede wrote: > Hi, > > On 15-01-18 06:22, Chanwoo Choi wrote: >> On 2018년 01월 15일 00:10, Hans de Goede wrote: >>> The only misdetection which can happen at boot due to data-lines mux issues >>> is detecting a non SDP as SDP, so w

Re: [PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array

*/ > static void axp288_extcon_log_rsi(struct axp288_extcon_info *info) > { > - char **rsi; > + const char * const *rsi; > unsigned int val, i, clear_mask = 0; > int ret; > > Applied it to v4.17 because I had finished the extcon pull request for v4.16. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 1/2] extcon: axp288: Constify the axp288_pwr_up_down_info array

_extcon_log_rsi(struct axp288_extcon_info *info) > { > - char **rsi; > + const char * const *rsi; > unsigned int val, i, clear_mask = 0; > int ret; > > Applied it to v4.17 because I had finished the extcon pull request for v4.16. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

second delayed_work because of dependency of other consumer driver. But, this patch is not proper method. It looks like the workaround. We need to consider the fundamental solution such as using OF graph or sending the pending notification when consumer driver is probed. I don't know what is best solution right now. I'll consider the appropriate method for all extcon provider drivers. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [PATCH 2/2] extcon: axp288: Only reschedule charger-detection at boot when a SDP is detected

cause of dependency of other consumer driver. But, this patch is not proper method. It looks like the workaround. We need to consider the fundamental solution such as using OF graph or sending the pending notification when consumer driver is probed. I don't know what is best solution right now. I'll consider the appropriate method for all extcon provider drivers. -- Best Regards, Chanwoo Choi Samsung Electronics

Re: [RFC PATCH 4/9] soc: samsung: Add generic power-management driver for Exynos

, Chanwoo Choi Samsung Electronics On 2018년 01월 09일 21:37, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote: >> To enter suspend, Exynos SoC requires the some machine dependent procedures. >> This patch introduces the generic po

Re: [RFC PATCH 4/9] soc: samsung: Add generic power-management driver for Exynos

, Chanwoo Choi Samsung Electronics On 2018년 01월 09일 21:37, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote: >> To enter suspend, Exynos SoC requires the some machine dependent procedures. >> This patch introduces the generic power-management driver to s

Re: [RFC PATCH 5/9] soc: samsung: pm: Add support for suspend-to-ram of Exynos5433

On 2018년 01월 09일 21:45, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote: >> This patch adds the specific exynos_pm_data instance for Exynos5433 >> in order to support the suspend-to-ram. Exynos5433 SoC need to write >&

Re: [RFC PATCH 5/9] soc: samsung: pm: Add support for suspend-to-ram of Exynos5433

On 2018년 01월 09일 21:45, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote: >> This patch adds the specific exynos_pm_data instance for Exynos5433 >> in order to support the suspend-to-ram. Exynos5433 SoC need to write >> the 'cpu_r

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 09일 21:23, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote: >> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC >> in order to support the various power modes. Each power mode has &

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 09일 21:23, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:59 AM, Chanwoo Choi wrote: >> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC >> in order to support the various power modes. Each power mode has >> the different value f

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 10일 19:53, Sudeep Holla wrote: > > > On 10/01/18 01:46, Chanwoo Choi wrote: >> On 2018년 01월 09일 23:11, Sudeep Holla wrote: >>> >>> >>> On 09/01/18 07:59, Chanwoo Choi wrote: >>>> This patch adds the PMU (Power Management

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 10일 19:53, Sudeep Holla wrote: > > > On 10/01/18 01:46, Chanwoo Choi wrote: >> On 2018년 01월 09일 23:11, Sudeep Holla wrote: >>> >>> >>> On 09/01/18 07:59, Chanwoo Choi wrote: >>>> This patch adds the PMU (Power Management

Re: [PATCH 1/9] clk: samsung: exynos5433: Add clock flag to support suspend-to-ram

On 2018년 01월 09일 20:44, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote: >> This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag >> to some clocks in order to avoid the hang-out in the suspend mode. >> >

Re: [PATCH 1/9] clk: samsung: exynos5433: Add clock flag to support suspend-to-ram

On 2018년 01월 09일 20:44, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi wrote: >> This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag >> to some clocks in order to avoid the hang-out in the suspend mode. >> >> Signed-off-by: Chanw

Re: [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433

On 2018년 01월 09일 20:56, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi <cw00.c...@samsung.com> wrote: >> In the mainline, there is no case to support the suspend-to-RAM for Samsung >> Exynos SoC. This patchset support the suspend-to-RAM

Re: [RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433

On 2018년 01월 09일 20:56, Krzysztof Kozlowski wrote: > On Tue, Jan 9, 2018 at 8:58 AM, Chanwoo Choi wrote: >> In the mainline, there is no case to support the suspend-to-RAM for Samsung >> Exynos SoC. This patchset support the suspend-to-RAM for 64bit Exynos SoC. >> >&g

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 09일 23:11, Sudeep Holla wrote: > > > On 09/01/18 07:59, Chanwoo Choi wrote: >> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC >> in order to support the various power modes. Each power mode has >> the different value for red

Re: [PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

On 2018년 01월 09일 23:11, Sudeep Holla wrote: > > > On 09/01/18 07:59, Chanwoo Choi wrote: >> This patch adds the PMU (Power Management Unit) data of exynos5433 SoC >> in order to support the various power modes. Each power mode has >> the different value for red

[PATCH 1/9] clk: samsung: exynos5433: Add clock flag to support suspend-to-ram

This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag to some clocks in order to avoid the hang-out in the suspend mode. Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> Cc: Tomasz Figa <tomasz.f...@gmail.com> Cc: Michael Turquette <mturque...@baylibre.com> Cc

[PATCH 1/9] clk: samsung: exynos5433: Add clock flag to support suspend-to-ram

This patch adds the CLK_IS_CRITICAL and CLK_IGNORE_UNUSED flag to some clocks in order to avoid the hang-out in the suspend mode. Signed-off-by: Chanwoo Choi Cc: Tomasz Figa Cc: Michael Turquette Cc: Stephen Boyd Cc: linux-...@vger.kernel.org --- drivers/clk/samsung/clk-exynos5433.c | 22

[PATCH 8/9] arm64: dts: exynos: Add cpu_suspend property of PSCI for exynos5433

, the 'cpu_suspend' of PSCI v0.1 on Exynos5433 is used for both cpuidle and suspend-to-RAM. [1] http://infocenter.arm.com/help/topic/com.arm.doc.den0022d/Power_State_Coordination_Interface_PDD_v1_1_DEN0022D.pdf Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dt

[PATCH 8/9] arm64: dts: exynos: Add cpu_suspend property of PSCI for exynos5433

, the 'cpu_suspend' of PSCI v0.1 on Exynos5433 is used for both cpuidle and suspend-to-RAM. [1] http://infocenter.arm.com/help/topic/com.arm.doc.den0022d/Power_State_Coordination_Interface_PDD_v1_1_DEN0022D.pdf Signed-off-by: Chanwoo Choi --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 + 1 file changed, 1

[PATCH 2/9] soc: samsung: pmu: Add powerup_conf callback

This patch adds the powerup_conf callback which is used to re-initialize the PMU registers during the resume state. Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- drivers/soc/samsung/exynos-pmu.c | 8 drivers/soc/samsung/exynos-pmu.h | 1 + include/linux/soc/s

[PATCH 2/9] soc: samsung: pmu: Add powerup_conf callback

This patch adds the powerup_conf callback which is used to re-initialize the PMU registers during the resume state. Signed-off-by: Chanwoo Choi --- drivers/soc/samsung/exynos-pmu.c | 8 drivers/soc/samsung/exynos-pmu.h | 1 + include/linux/soc/samsung/exynos-pmu.h | 1 + 3

[RFC PATCH 4/9] soc: samsung: Add generic power-management driver for Exynos

To enter suspend, Exynos SoC requires the some machine dependent procedures. This patch introduces the generic power-management driver to support those requirements and generic interface for power state management. Signed-off-by: Jonghwa Lee <jonghwa3@samsung.com> Signed-off-by: Chanwo

[RFC PATCH 4/9] soc: samsung: Add generic power-management driver for Exynos

To enter suspend, Exynos SoC requires the some machine dependent procedures. This patch introduces the generic power-management driver to support those requirements and generic interface for power state management. Signed-off-by: Jonghwa Lee Signed-off-by: Chanwoo Choi --- arch/arm/mach-exynos

[PATCH 9/9] arm64: dts: exynos: Add cpu topology information for Exynos5433 SoC

This patch adds the 'cpu-map' for the cpu topology information of Exynos5433 which has the following two clusters. - cluster0 contains the four LITTLE cores (cpu0-3). - cluster1 contains the four big cores (cpu4-7). Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- arch/arm64/bo

[PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

This patch adds the PMU (Power Management Unit) data of exynos5433 SoC in order to support the various power modes. Each power mode has the different value for reducing the power-consumption. Signed-off-by: Jonghwa Lee <jonghwa3@samsung.com> Signed-off-by: Chanwoo Choi <cw00.c...@sa

[PATCH 9/9] arm64: dts: exynos: Add cpu topology information for Exynos5433 SoC

This patch adds the 'cpu-map' for the cpu topology information of Exynos5433 which has the following two clusters. - cluster0 contains the four LITTLE cores (cpu0-3). - cluster1 contains the four big cores (cpu4-7). Signed-off-by: Chanwoo Choi --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 32

[PATCH 3/9] soc: samsung: pmu: Add the PMU data of exynos5433 to support low-power state

This patch adds the PMU (Power Management Unit) data of exynos5433 SoC in order to support the various power modes. Each power mode has the different value for reducing the power-consumption. Signed-off-by: Jonghwa Lee Signed-off-by: Chanwoo Choi --- arch/arm/mach-exynos/common.h

[RFC PATCH 5/9] soc: samsung: pm: Add support for suspend-to-ram of Exynos5433

This patch adds the specific exynos_pm_data instance for Exynos5433 in order to support the suspend-to-ram. Exynos5433 SoC need to write the 'cpu_resume' poiter address and the specific magic number for suspend mode. Signed-off-by: Jonghwa Lee <jonghwa3@samsung.com> Signed-off-by: C

[RFC PATCH 5/9] soc: samsung: pm: Add support for suspend-to-ram of Exynos5433

This patch adds the specific exynos_pm_data instance for Exynos5433 in order to support the suspend-to-ram. Exynos5433 SoC need to write the 'cpu_resume' poiter address and the specific magic number for suspend mode. Signed-off-by: Jonghwa Lee Signed-off-by: Chanwoo Choi --- drivers/soc

[PATCH 6/9] arm64: dts: exynos: Add iRAM device-tree node for Exynos5433

This patch adds the iRAM device-tree node of Exynos5433 which defines the memory map of iRAM as following and it is used for suspend. - address: 0x0202_ ~ 0x3000_ Signed-off-by: Jonghwa Lee <jonghwa3@samsung.com> Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> --- arc

[PATCH 6/9] arm64: dts: exynos: Add iRAM device-tree node for Exynos5433

This patch adds the iRAM device-tree node of Exynos5433 which defines the memory map of iRAM as following and it is used for suspend. - address: 0x0202_ ~ 0x3000_ Signed-off-by: Jonghwa Lee Signed-off-by: Chanwoo Choi --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 14

[RFC PATCH 0/9] soc: samsung: Add support of suspend-to-RAM on Exynos5433

EXYNOS5433_EINT_WAKEUP_MASKx registers. The pinctr-exynos.c need to handle the extra EINT_WAKEUP_MASKx for Exynos5433. The suspend-to-ram test is failed on first time and then next tryout is ok. I'm developing it. Chanwoo Choi (9): clk: samsung: exynos5433: Add clock flag to support

<    5   6   7   8   9   10   11   12   13   14   >