Re: [PATCH] scsi: stex: make S6flag static

2017-04-25 Thread Charles Chiou
Looks good to me. Thanks for the improvement. On 4/26/2017 1:36 AM, Colin King wrote: From: Colin Ian King This module specific flag can be made static as it does not need to be in global scope. > Reviewed-by: Charles Chiou Signed-off-by: Colin Ian King --- drivers/scsi/stex.c

Re: [PATCH 2/2] Add S6 support

2017-02-24 Thread Charles Chiou
From: Charles Hi all, Ping? Does this patch has any issue need to fix? Thank you.

Re: [PATCH 1/2] Support Pegasus 3 product

2017-02-24 Thread Charles Chiou
From: Charles Hi all, Ping? Does this patch has any issue need to fix? Thank you.

Re: [PATCH 1/2] Support Pegasus 3 product

2017-02-24 Thread Charles Chiou
From: Charles

[PATCH 2/2] Add S6 support

2017-02-16 Thread Charles Chiou
From: Charles 1.Add reboot notifier and register it in stex_probe for all supported device. 2.For all supported device in restart flow, we get a callback from notifier and set S6flag for stex_shutdown & stex_hba_stop to send restart command to FW. Signed-off-by: Charles.Chiou Signed-off-by: Pa

[PATCH 1/2] Support Pegasus 3 product

2017-02-16 Thread Charles Chiou
From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3(P3) is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add P3 VID, DID and define it's device address. 3.P3 use msi interrupt, so stex_request_irq

[v3 PATCH 2/2] scsi:stex.c Add S6 support

2016-06-14 Thread Charles Chiou
From: Charles 1.Add reboot notifier and register it in stex_probe for all supported device. 2.For all supported device in restart flow, we get a callback from notifier and set S6flag for stex_shutdown & stex_hba_stop to send restart command to FW. Signed-off-by: Charles Signed-off-by: Paul -

[v3 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

2016-06-14 Thread Charles Chiou
From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address. 3.Pegasus 3 use msi interrupt, so ste

[v2 PATCH 2/2] scsi:stex.c Add S6 support

2016-06-13 Thread Charles Chiou
From: Charles 1.Add reboot notifier and register it in stex_probe for all supported device. 2.For all supported device in restart flow, we get a callback from notifier and set S6flag for stex_shutdown & stex_hba_stop to send restart command to FW. Signed-off-by: Charles Signed-off-by: Paul -

[v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

2016-06-13 Thread Charles Chiou
From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address. 3.Pegasus 3 use msi interrupt, so ste

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-13 Thread Charles Chiou
Hi Julian, On 06/10/2016 08:10 AM, Julian Calaby wrote: Hi Charles, On Mon, Jun 6, 2016 at 5:53 PM, Charles Chiou wrote: From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another

[PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-06 Thread Charles Chiou
From: Charles Pegasus series is a RAID support product by using Thunderbolt technology. The newest product, Pegasus 3 is support Thunderbolt 3 technology with another chip. 1.Change driver version. 2.Add Pegasus 3 VID, DID and define it's device address. 3.Pegasus 3 use msi interrupt, so ste

[PATCH 5/5] Add P3 support, acpi s5 & s6

2016-06-03 Thread Charles Chiou
From: Paul 1.Add reboot notifier 2.Register reboot notifier in probe 3.Reboot set a flag for shutdown callback Signed-off-by: Paul --- drivers/scsi/stex.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c

[PATCH 4/5] Add P3 support, acpi s3 & s4

2016-06-03 Thread Charles Chiou
From: Paul 1.In suspend, add p3 type as yel 2.For s4, use msi_lock to prevent msi reg set again 3.When send shutdown mic, add p3 type as yel Signed-off-by: Paul --- drivers/scsi/stex.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/dri

[PATCH 3/5] Add P3 support, modify IO & reset

2016-06-03 Thread Charles Chiou
From: Paul 1.Send command add P3 write reg 2.In get intr, read P3 reg & clear interrupt reg 3.Abort read & clear reg same as getting intr 4.Reset flow add P3 reset function because P3 don't need read back reg Signed-off-by: Paul --- drivers/scsi/stex.c | 68

[PATCH 2/5] Add P3 support, modify probe, irq & handshake

2016-06-03 Thread Charles Chiou
From: Paul 1.In probe, add p3 card_type for pm, offset, scract & SG 2.Init P3 to use msi interrupt 3.Handshake add P3 read/write reg Signed-off-by: Paul --- drivers/scsi/stex.c | 122 +--- 1 file changed, 88 insertions(+), 34 deletions(-) diff -

[PATCH 1/5] Add P3 support, define reg & struct

2016-06-03 Thread Charles Chiou
From: Paul 1.Change ver 2.Add P3 VID & DID 2.Define device reg 3.Add P3 struct and callback Signed-off-by: Paul --- drivers/scsi/stex.c | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 5b23175.

Re: [v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-06-03 Thread Charles Chiou
Sorry, this is the old patch, pls just ignore this patch Thank you Charles On 06/03/2016 08:03 PM, Charles Chiou wrote: From: Charles Pegasus is a high performace hardware RAID solution designed to unleash the raw power of Thunderbolt technology. 1. Add code to distinct SuperTrack and

[v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-06-03 Thread Charles Chiou
: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 2de28d7..495d632 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c

[v2 PATCH 3/3] scsi:stex.c Add S3/S4 support

2016-02-22 Thread Charles Chiou
From: Charles Add S3/S4 support, add .suspend and .resume function in pci_driver. In .suspend handler, driver send S3/S4 signal to the device. Signed-off-by: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 68 ++--- 1

[v2 PATCH 2/3] scsi:stex.c Add hotplug support

2016-02-22 Thread Charles Chiou
. Add new device status: MU_STATE_STOP, MU_STATE_NOCONNECT, MU_STATE_STOP. MU_STATE_STOP is currently not referenced. MU_STATE_NOCONNECT represent that device is plugged out from the host. 4. Use return_abnormal_function() to substitute part of code in stex_do_reset. Signed-off-by: Charles

[v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-22 Thread Charles Chiou
: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 32 ++-- 1 file changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 2de28d7..495d632 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.c

Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support

2016-02-21 Thread Charles Chiou
Hi Oliver, sure, we'll fix it at the next patch version. Thank you. Charles On 02/04/2016 07:37 PM, Oliver Neukum wrote: On Thu, 2016-02-04 at 19:22 +0800, Charles Chiou wrote: +static int stex_choice_sleep_mic(pm_message_t state) +{ +switch (state.event) { +case PM_EVENT_SU

[Resend PATCH 3/3] scsi:stex.c Add S3/S4 support

2016-02-04 Thread Charles Chiou
device. V2: Remove blank lines Signed-off-by: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 59 ++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index

[Resend PATCH 2/3] scsi:stex.c Add hotplug support

2016-02-04 Thread Charles Chiou
. MU_STATE_NOCONNECT represent that device is plugged out from the host. 4. Use return_abnormal_function() to substitute part of code in stex_do_reset. V2: N/A Signed-off-by: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 53

[Resend PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-02-04 Thread Charles Chiou
. 1. Add code to distinct SuperTrack and Pegasus series by sub device ID. It should support backward compatibility. 2. Change the driver version. V2: Remove blank lines Signed-off-by: Charles Chiou Reviewed-by: Johannes Thumshirn --- drivers/scsi/stex.c | 32

Re: [PATCH 3/3] scsi:stex.c Add S3/S4 support

2016-01-29 Thread Charles Chiou
Hi all, Ping? Does this patch has others issues need to fix? Thank you. Charles On 09/03/2015 10:03 PM, Johannes Thumshirn wrote: Charles Chiou writes: From f442518879f8f41d103b684046d912eca13844e7 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:54:45 +0800 Subject: [PATCH

Re: [v2 PATCH 2/3] scsi:stex.c Add hotplug support

2016-01-29 Thread Charles Chiou
Hi all, Ping? Does this patch has others issues need to fix? Thank you. Charles On 09/03/2015 10:01 PM, Johannes Thumshirn wrote: Charles Chiou writes: From 60e14c245c18cbe0300cfa244334e2850a52a381 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:48:55 +0800 Subject: [PATCH

Re: [v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2016-01-29 Thread Charles Chiou
Hi all, Ping? Does this patch has others issues need to fix? Thank you. Charles On 09/03/2015 10:16 PM, Johannes Thumshirn wrote: Charles Chiou writes: From 9d7973dfa05a7785d0eb1e9bcfb0fb6d2c493209 Mon Sep 17 00:00:00 2001 From: Charles Date: Wed, 2 Sep 2015 20:41:56 +0800 Subject: [PATCH

[PATCH 3/3] scsi:stex.c Add S3/S4 support

2015-09-03 Thread Charles Chiou
device. V2: Remove blank lines Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 59 ++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 4ef0c80..c96a86d 100644 --- a/drivers

[v2 PATCH 2/3] scsi:stex.c Add hotplug support

2015-09-03 Thread Charles Chiou
. MU_STATE_NOCONNECT represent that device is plugged out from the host. 4. Use return_abnormal_function() to substitute part of code in stex_do_reset. V2: N/A Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 53 ++--- 1 file changed, 34 insertions

[v2 PATCH 1/3] scsi:stex.c Support to Pegasus series.

2015-09-03 Thread Charles Chiou
. 1. Add code to distinct SuperTrack and Pegasus series by sub device ID. It should support backward compatibility. 2. Change the driver version. V2: Remove blank lines Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 32 ++-- 1 file changed, 26 insertions

[PATCH 3/3] scsi:stex.c Add S3/S4 support

2015-09-02 Thread Charles Chiou
device. Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 65 ++--- 1 file changed, 62 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index 6578f3d..45482d5 100644 --- a/drivers/scsi/stex.c +++ b/drivers

[PATCH 2/4] scsi:stex.c Add hotplug support

2015-09-02 Thread Charles Chiou
. MU_STATE_NOCONNECT represent that device is plugged out from the host. 4. Use return_abnormal_function() to substitute part of code in stex_do_reset. Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 53 ++--- 1 file changed, 34 insertions(+), 19

[PATCH 1/3] scsi:stex.c Support to Pegasus series.

2015-09-02 Thread Charles Chiou
. 1. Add code to distinct SuperTrack and Pegasus series by sub device ID. It should support backward compatibility. 2. Change the driver version. Signed-off-by: Charles Chiou --- drivers/scsi/stex.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions

Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-22 Thread Charles Chiou
On 12/18/2014 11:41 AM, Charles Chiou wrote: On 12/17/2014 05:30 PM, Christoph Hellwig wrote: I'm not going to add a new reboot notifier for a driver. If you can convince the driver model / PM people to pass this information to ->shutdown we can add support for this difference, bu

Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-17 Thread Charles Chiou
On 12/17/2014 05:30 PM, Christoph Hellwig wrote: I'm not going to add a new reboot notifier for a driver. If you can convince the driver model / PM people to pass this information to ->shutdown we can add support for this difference, but not in this way. Can you send me a series that just add

Re: [PATCH 4/4 v4] scsi:stex.c Add S3/S4 support

2014-12-17 Thread Charles Chiou
On 12/16/2014 05:34 PM, Oliver Neukum wrote: On Tue, 2014-12-16 at 14:14 +0800, Charles Chiou wrote: From f9d84df080c16097218092630db9b5df31d487b5 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support Add S3/S4

[PATCH 4/4 v4] scsi:stex.c Add S3/S4 support

2014-12-15 Thread Charles Chiou
From f9d84df080c16097218092630db9b5df31d487b5 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support Add S3/S4 support, add .suspend and .resume function in pci_driver. Pegasus need 30~40 seconds to boot up. We

[PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-15 Thread Charles Chiou
From 72f5b5cbda424a254b0e9672bd4d9d249728fcb9 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 19:29:46 +0800 Subject: [PATCH 3/4] scsi:stex.c Add reboot support 1. Add reboot support, Pegasus devices should be notified that the host is going to shut down/reboot. I

[PATCH 2/4 v4] scsi:stex.c Add hotplug support

2014-12-15 Thread Charles Chiou
From 901f2c1b2d1ae2991182f0f62cedc70f87ea49bc Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 17:18:37 +0800 Subject: [PATCH 2/4] scsi:stex.c Add hotplug support 1. Add hotplug support. Pegasus support surprise removal. To this end, I use return_abnormal_state function to

[PATCH 1/4 v4] scsi:stex.c Support to Pegasus series.

2014-12-15 Thread Charles Chiou
From 8be76ec282e4e344e88c63d5c1e72c0a8394e703 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 14:18:43 +0800 Subject: [PATCH 1/4] scsi:stex.c Support to Pegasus series. Pegasus is a high performace hardware RAID solution designed to unleash the raw power of Thunderbolt

Re: [V3 PATCH 4/4] scsi:stex.c Add S3/S4 support

2014-12-14 Thread Charles Chiou
On 12/10/2014 05:02 PM, Oliver Neukum wrote: On Wed, 2014-12-10 at 09:38 +0800, Charles Chiou wrote: From 91868d4afe10533b8a4496075109e411100217bb Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support Add S3/S4

[V3 PATCH 4/4] scsi:stex.c Add S3/S4 support

2014-12-09 Thread Charles Chiou
From 91868d4afe10533b8a4496075109e411100217bb Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support Add S3/S4 support, add .suspend and .resume function in pci_driver. Pegasus need 30~40 seconds to boot up. We don&#

[V3 PATCH 3/4] scsi:stex.c Add reboot support

2014-12-09 Thread Charles Chiou
From 72f5b5cbda424a254b0e9672bd4d9d249728fcb9 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 19:29:46 +0800 Subject: [PATCH 3/4] scsi:stex.c Add reboot support 1. Add reboot support, Pegasus devices should be notified that the host is going to shut down/reboot. I

[V3 PATCH 2/4] scsi:stex.c Add hotplug support

2014-12-09 Thread Charles Chiou
From 901f2c1b2d1ae2991182f0f62cedc70f87ea49bc Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 17:18:37 +0800 Subject: [PATCH 2/4] scsi:stex.c Add hotplug support 1. Add hotplug support. Pegasus support surprise removal. To this end, I use return_abnormal_state function to

[V3 PATCH 1/4] scsi:stex.c Support to Pegasus series.

2014-12-09 Thread Charles Chiou
From 8be76ec282e4e344e88c63d5c1e72c0a8394e703 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 14:18:43 +0800 Subject: [PATCH 1/4] scsi:stex.c Support to Pegasus series. Pegasus is a high performace hardware RAID solution designed to unleash the raw power of Thunderbolt

Re: [V2 PATCH 3/4] scsi:stex.c Add reboot support

2014-11-13 Thread Charles Chiou
On 11/13/2014 06:07 PM, Charles Chiou wrote: On 11/13/2014 01:27 AM, Christoph Hellwig wrote: +static int stex_reboot_callback(struct notifier_block *self, + unsigned long val, + void *data) +{ +if (val == SYS_RESTART

Re: [V2 PATCH 3/4] scsi:stex.c Add reboot support

2014-11-13 Thread Charles Chiou
On 11/13/2014 01:27 AM, Christoph Hellwig wrote: +static int stex_reboot_callback(struct notifier_block *self, + unsigned long val, + void *data) +{ + if (val == SYS_RESTART) +

Re: [V2 PATCH 1/4] scsi:stex.c Support to Pegasus series.

2014-11-13 Thread Charles Chiou
On 11/12/2014 06:43 PM, Christoph Hellwig wrote: + u8 yellowstone; Calling this flag yellowstone seems a bit confusing as there already is a st_yel card type, and this only seems a subset of those. Maybe a ->support_pm flag or similar would be useful? OK, I'll modify it. +

[V2 PATCH 4/4] scsi:stex.c Add S3/S4 support

2014-11-11 Thread Charles Chiou
From d0bc6b814e5a16bea639bbdfad992a5593bf3420 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Fri, 7 Nov 2014 10:15:18 +0800 Subject: [PATCH 4/4] scsi:stex.c Add S3/S4 support 1. Add S3/S4 support, add .suspend and .resume function in pci_driver. 2. Pegasus take some to init, I create one

[V2 PATCH 3/4] scsi:stex.c Add reboot support

2014-11-11 Thread Charles Chiou
From 5eac0f3209e0857c983c986786a68eac0d67247b Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 19:29:46 +0800 Subject: [PATCH 3/4] scsi:stex.c Add reboot support 1. Add reboot support, Pegasus devices should be notified that the host is going to shutdown/reboot. I register

[PATCH 2/4] scsi:stex.c Add hotplug support

2014-11-11 Thread Charles Chiou
From 070dfd671f4cefb2d54563b77b9c80a8c82f260a Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 17:18:37 +0800 Subject: [PATCH 2/4] scsi:stex.c Add hotplut support 1. Add hotplug support. Pegasus support surprise remove. To this, I use return_abnormal_state function to

[V2 PATCH 1/4] scsi:stex.c Support to Pegasus series.

2014-11-11 Thread Charles Chiou
From 5fdb4203c09d6896e7b71a8f839e46e84234eeb9 Mon Sep 17 00:00:00 2001 From: Charles Chiou Date: Wed, 5 Nov 2014 14:18:43 +0800 Subject: [PATCH 1/4] scsi:stex.c Support to Pegasus series. Pegasus is a high performace hardware RAID solution designed to unleash the raw power of Thunderbolt