Re: [PATCH RESEND] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk

Thanks On 2019/6/26 21:30, Axel Lin wrote: Since devm_regmap_init_mmio_clk can fail, add return value checking. Signed-off-by: Axel Lin Acked-by: Chen Feng --- This was sent on https://lkml.org/lkml/2019/3/6/904 drivers/mfd/hi655x-pmic.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH] mfd: hi655x-pmic: Fix missing return value check for devm_regmap_init_mmio_clk

Thanks On 2019/3/6 21:49, Axel Lin wrote: > Since devm_regmap_init_mmio_clk can fail, add return value checking. > > Signed-off-by: Axel Lin > --- > drivers/mfd/hi655x-pmic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c >

Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

Thanks. On 2019/2/1 14:59, Qing Xia wrote: > In the first loop, gfp_flags will be modified to high_order_gfp_flags, > and there will be no chance to change back to low_order_gfp_flags. > > Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer > alloc") > Signed-off-by: Qing

Re: [Linaro-mm-sig] [PATCH v3] staging: android: ion: Zero CMA allocated memory

On 2018/1/27 1:48, Liam Mark wrote: > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly") > the CMA API is now used directly and therefore the allocated memory is no > longer automatically zeroed. > > Explicitly zero CMA allocated memory to ensure that no data is exposed

Re: [Linaro-mm-sig] [PATCH v3] staging: android: ion: Zero CMA allocated memory

On 2018/1/27 1:48, Liam Mark wrote: > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly") > the CMA API is now used directly and therefore the allocated memory is no > longer automatically zeroed. > > Explicitly zero CMA allocated memory to ensure that no data is exposed

Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

On 2018/1/9 18:43, Zeng Tao wrote: > This issue is introduced by the commit ("ION: Sys_heap: > Add cached pool to spead up cached buffer alloc"), the gfp_mask low > order pool is overlapped by the high order inside the loop, so the > gfp_mask of all pools are set to high_order_gfp_flags. >

Re: [PATCH] ION: Sys_heap: fix the incorrect pool->gfp_mask setting

On 2018/1/9 18:43, Zeng Tao wrote: > This issue is introduced by the commit ("ION: Sys_heap: > Add cached pool to spead up cached buffer alloc"), the gfp_mask low > order pool is overlapped by the high order inside the loop, so the > gfp_mask of all pools are set to high_order_gfp_flags. >

Re: [PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

On 2017/11/29 4:41, Ard Biesheuvel wrote: > On 21 November 2017 at 03:44, Chen Feng <puck.c...@hisilicon.com> wrote: >> With kaslr and kasan enable both, I got the follow issue. >> >> [ 16.130523s]kasan: reg->base = 1, phys_end =1c000,sta

Re: [PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

On 2017/11/29 4:41, Ard Biesheuvel wrote: > On 21 November 2017 at 03:44, Chen Feng wrote: >> With kaslr and kasan enable both, I got the follow issue. >> >> [ 16.130523s]kasan: reg->base = 1, phys_end =1c000,start = >> 4000, end =

Re: [PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

On 2017/11/21 11:44, Chen Feng wrote: > With kaslr and kasan enable both, I got the follow issue. > > [ 16.130523s]kasan: reg->base = 1, phys_end =1c000,start = > 4000, end = ffc0 > [ 16.142517s]___alloc_bootmem_nopanic:25

Re: [PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

On 2017/11/21 11:44, Chen Feng wrote: > With kaslr and kasan enable both, I got the follow issue. > > [ 16.130523s]kasan: reg->base = 1, phys_end =1c000,start = > 4000, end = ffc0 > [ 16.142517s]___alloc_bootmem_nopanic:25

[PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

init, if the start >= end, it will not map the hole block address. But the memory in this block is valid. And it can be allocated as well. So donot use the last memory region. Changing "range = range / ARM64_MEMSTART_ALIGN + 1" to range = range / ARM64_MEMSTART_ALIGN; Signed-off-by: Chen Fen

[PATCH] arm64: kaslr: Fix kaslr end boundary of virt addr

init, if the start >= end, it will not map the hole block address. But the memory in this block is valid. And it can be allocated as well. So donot use the last memory region. Changing "range = range / ARM64_MEMSTART_ALIGN + 1" to range = range / ARM64_MEMSTART_ALIGN; Signed-off-by: Chen Feng

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

Hi ted, On 2017/10/26 23:04, Theodore Ts'o wrote: > On Thu, Oct 26, 2017 at 04:25:15PM +0800, Chen Feng wrote: >> >> >> On 2017/10/25 16:49, Theodore Ts'o wrote: >>> Other people who have sent me fuzzer test reproducers are able to >>> reproduce syzkaller

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

Hi ted, On 2017/10/26 23:04, Theodore Ts'o wrote: > On Thu, Oct 26, 2017 at 04:25:15PM +0800, Chen Feng wrote: >> >> >> On 2017/10/25 16:49, Theodore Ts'o wrote: >>> Other people who have sent me fuzzer test reproducers are able to >>> reproduce syzkaller

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/25 16:49, Theodore Ts'o wrote: > Other people who have sent me fuzzer test reproducers are able to > reproduce syzkaller logs into a simple C program. Can you explain to > me what the heck: > >> r3 = syz_open_dev$urandom(&(0x7f00a000)="2f6465762f7572616e646f6d00", >> 0x0, 0x0)

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/25 16:49, Theodore Ts'o wrote: > Other people who have sent me fuzzer test reproducers are able to > reproduce syzkaller logs into a simple C program. Can you explain to > me what the heck: > >> r3 = syz_open_dev$urandom(&(0x7f00a000)="2f6465762f7572616e646f6d00", >> 0x0, 0x0)

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/25 14:56, Greg KH wrote: > On Wed, Oct 25, 2017 at 02:30:56PM +0800, Chen Feng wrote: >> Hi Ted, >> >> On 2017/10/24 18:25, Theodore Ts'o wrote: >>> On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: >>>> On Tue, Oct 24, 2017 at 03:

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/25 14:56, Greg KH wrote: > On Wed, Oct 25, 2017 at 02:30:56PM +0800, Chen Feng wrote: >> Hi Ted, >> >> On 2017/10/24 18:25, Theodore Ts'o wrote: >>> On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: >>>> On Tue, Oct 24, 2017 at 03:

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

Hi Ted, On 2017/10/24 18:25, Theodore Ts'o wrote: > On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: >> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: >>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] >>

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

Hi Ted, On 2017/10/24 18:25, Theodore Ts'o wrote: > On Tue, Oct 24, 2017 at 11:09:27AM +0200, Greg KH wrote: >> On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: >>> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] >>

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/24 17:09, Greg KH wrote: > On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: >> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] >> Restart is not permit >> = >> UBSAN: Undefined behav

Re: [PATCH RFC] random: fix syzkaller fuzzer test int overflow

On 2017/10/24 17:09, Greg KH wrote: > On Tue, Oct 24, 2017 at 03:44:17PM +0800, Chen Feng wrote: >> [pid:11940,cpu6,syz-executor][flp_ioctl]cmd[0x1] >> Restart is not permit >> = >> UBSAN: Undefined behav

[PATCH RFC] random: fix syzkaller fuzzer test int overflow

/0x34 [] credit_entropy_bits+0x358/0x9a8 [] random_ioctl+0x338/0x384 [] do_vfs_ioctl+0x60c/0xa4c [] SyS_ioctl+0x9c/0xc0 [] el0_svc_naked+0x24/0x28 = Signed-off-by: Chen Feng <puck.c...@hisilicon.com> Signed-off-by: Yukun Zhao &

[PATCH RFC] random: fix syzkaller fuzzer test int overflow

/0x34 [] credit_entropy_bits+0x358/0x9a8 [] random_ioctl+0x338/0x384 [] do_vfs_ioctl+0x60c/0xa4c [] SyS_ioctl+0x9c/0xc0 [] el0_svc_naked+0x24/0x28 = Signed-off-by: Chen Feng Signed-off-by: Yukun Zhao --- drivers/char/random.c | 5

Re: [PATCH] reset: hisilicon: Fix hi6220 module license

] hi6220_reset: Unknown symbol __platform_driver_register (err > 0) > > Add a MODULE_LICENSE() to fix this. > > Fixes: 70b3590f639f ("reset: hi6220: fix modular build") > Cc: Arnd Bergmann <a...@arndb.de> > Cc: Chen Feng <puck.c...@hisilicon.com> > Signe

Re: [PATCH] reset: hisilicon: Fix hi6220 module license

] hi6220_reset: Unknown symbol __platform_driver_register (err > 0) > > Add a MODULE_LICENSE() to fix this. > > Fixes: 70b3590f639f ("reset: hi6220: fix modular build") > Cc: Arnd Bergmann > Cc: Chen Feng > Signed-off-by: Andreas Färber > --- > drivers

Re: [Linaro-mm-sig] [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

On 2017/2/22 3:29, Laura Abbott wrote: > On 02/20/2017 10:05 PM, Chen Feng wrote: >> Hi Laura, >> >> When we enable kernel v4.4 or newer version on our platform, we meet the >> issue >> of flushing cache without reference device. It seems that this patch

Re: [Linaro-mm-sig] [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

On 2017/2/22 3:29, Laura Abbott wrote: > On 02/20/2017 10:05 PM, Chen Feng wrote: >> Hi Laura, >> >> When we enable kernel v4.4 or newer version on our platform, we meet the >> issue >> of flushing cache without reference device. It seems that this patch

Re: [Linaro-mm-sig] [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

Hi Laura, When we enable kernel v4.4 or newer version on our platform, we meet the issue of flushing cache without reference device. It seems that this patch set is a solution. I'm curious the progress of the discussion. Do you have any plan to fix it in v4.4 and newer kernel verison? On

Re: [Linaro-mm-sig] [RFCv3][PATCH 3/5] arm64: Implement ARCH_HAS_FORCE_CACHE

Hi Laura, When we enable kernel v4.4 or newer version on our platform, we meet the issue of flushing cache without reference device. It seems that this patch set is a solution. I'm curious the progress of the discussion. Do you have any plan to fix it in v4.4 and newer kernel verison? On

[V3 1/3] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentatio

[V3 1/3] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b

[V3 2/3] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon

[V3 2/3] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 35 +++

[V3 3/3] dt-bindings: Add a support cpu type for cortex-a73

Add arm cpu type cortex-a73 Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- Documentation/devicetree/bindings/arm/cpus.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt index a

[V3 3/3] dt-bindings: Add a support cpu type for cortex-a73

Add arm cpu type cortex-a73 Signed-off-by: Chen Feng --- Documentation/devicetree/bindings/arm/cpus.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt index a1bcfee..d748774 100644

[V2 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon

[V2 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 34 +++

[V2 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentatio

[V2 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b

[V2 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentatio

[V2 2/2] Add initial dtsi file to support Hisilicon Hi3660 SoC with support of Octal core CPUs in two clusters(4 * A53 & 4 * A73).

d. Tested on HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 34 + arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 156 ++ 3 files changed

[V2 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng Acked-by: Rob Herring --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b

[V2 2/2] Add initial dtsi file to support Hisilicon Hi3660 SoC with support of Octal core CPUs in two clusters(4 * A53 & 4 * A73).

d. Tested on HiKey960 Board. Signed-off-by: Chen Feng --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 34 + arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 156 ++ 3 files changed, 191 insertions(+) create m

Re: [RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

On 2017/1/5 22:14, Andy Gross wrote: > On Mon, Dec 26, 2016 at 05:36:12PM +0800, Chen Feng wrote: >> Add initial dtsi file to support Hisilicon Hi3660 SoC with >> support of Octal core CPUs in two clusters(4 * A53 & 4 * A73). >> >> Also add dts file to support H

Re: [RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

On 2017/1/5 22:14, Andy Gross wrote: > On Mon, Dec 26, 2016 at 05:36:12PM +0800, Chen Feng wrote: >> Add initial dtsi file to support Hisilicon Hi3660 SoC with >> support of Octal core CPUs in two clusters(4 * A53 & 4 * A73). >> >> Also add dts file to support H

Re: [RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

Hi will, Could you help review this part? On 2016/12/26 17:36, Chen Feng wrote: > Add initial dtsi file to support Hisilicon Hi3660 SoC with > support of Octal core CPUs in two clusters(4 * A53 & 4 * A73). > > Also add dts file to support HiKey960 development board which >

Re: [RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

Hi will, Could you help review this part? On 2016/12/26 17:36, Chen Feng wrote: > Add initial dtsi file to support Hisilicon Hi3660 SoC with > support of Octal core CPUs in two clusters(4 * A53 & 4 * A73). > > Also add dts file to support HiKey960 development board which >

[RESEND 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.

[RESEND 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree

[RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon

[RESEND 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 34 +++

[PATCH 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.

[PATCH 1/2] document: dt: add binding for Hi3660 SoC

Add binding for hisilicon Hi3660 SoC and HiKey960 Board. Signed-off-by: Chen Feng --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree

[PATCH 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon

[PATCH 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC

con_init uart5 with a fixed clock, which already configured at bootloader. When clock is available, the uart5 will be modified. Tested on HiKey960 Board. Signed-off-by: Chen Feng --- arch/arm64/boot/dts/hisilicon/Makefile| 1 + arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 37 +++

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/8 11:59, Joonsoo Kim wrote: > On Mon, Nov 07, 2016 at 03:46:02PM +0800, Chen Feng wrote: >> >> >> On 2016/11/7 15:44, Chen Feng wrote: >>> On 2016/11/7 15:27, Joonsoo Kim wrote: >>>> On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng w

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/8 11:59, Joonsoo Kim wrote: > On Mon, Nov 07, 2016 at 03:46:02PM +0800, Chen Feng wrote: >> >> >> On 2016/11/7 15:44, Chen Feng wrote: >>> On 2016/11/7 15:27, Joonsoo Kim wrote: >>>> On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng w

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 15:44, Chen Feng wrote: > On 2016/11/7 15:27, Joonsoo Kim wrote: >> On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng wrote: >>> >>> >>> On 2016/11/7 14:15, Joonsoo Kim wrote: >>>> On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen F

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 15:44, Chen Feng wrote: > On 2016/11/7 15:27, Joonsoo Kim wrote: >> On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng wrote: >>> >>> >>> On 2016/11/7 14:15, Joonsoo Kim wrote: >>>> On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen F

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 15:27, Joonsoo Kim wrote: > On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng wrote: >> >> >> On 2016/11/7 14:15, Joonsoo Kim wrote: >>> On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen Feng wrote: >>>> Hello, I hava a question on cma zone.

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 15:27, Joonsoo Kim wrote: > On Mon, Nov 07, 2016 at 03:08:49PM +0800, Chen Feng wrote: >> >> >> On 2016/11/7 14:15, Joonsoo Kim wrote: >>> On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen Feng wrote: >>>> Hello, I hava a question on cma zone.

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 14:15, Joonsoo Kim wrote: > On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen Feng wrote: >> Hello, I hava a question on cma zone. >> >> When we have cma zone, cma zone will be the highest zone of system. >> >> In android system, the most memo

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

On 2016/11/7 14:15, Joonsoo Kim wrote: > On Tue, Nov 01, 2016 at 03:58:32PM +0800, Chen Feng wrote: >> Hello, I hava a question on cma zone. >> >> When we have cma zone, cma zone will be the highest zone of system. >> >> In android system, the most memo

Re: [PATCH] mm: cma: improve utilization of cma pages

st ERROR on v4.9-rc3 next-20161028] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Chen-Feng/mm-cma-improve-utilization-of-cma-pages/20161103-173624 > base: git

Re: [PATCH] mm: cma: improve utilization of cma pages

st ERROR on v4.9-rc3 next-20161028] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Chen-Feng/mm-cma-improve-utilization-of-cma-pages/20161103-173624 > base: git

[PATCH] mm: cma: improve utilization of cma pages

idea. But while testing it, the cma zone can be exhausted soon. Then the cma zone will always doing balance. The slab_scans and swap ion/out will be too high. CC: Qiu xishi <qiuxi...@huawei.com> Signed-off-by: Chen Feng <puck.c...@hisilicon.com> Reviewd-by: Fu Jun <oliver..

[PATCH] mm: cma: improve utilization of cma pages

idea. But while testing it, the cma zone can be exhausted soon. Then the cma zone will always doing balance. The slab_scans and swap ion/out will be too high. CC: Qiu xishi Signed-off-by: Chen Feng Reviewd-by: Fu Jun --- include/linux/gfp.h| 3 +++ include/linux/mmzone.h | 4 ++-- mm

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

Hello, I hava a question on cma zone. When we have cma zone, cma zone will be the highest zone of system. In android system, the most memory allocator is ION. Media system will alloc unmovable memory from it. On low memory scene, will the CMA zone always do balance? Should we transmit the

Re: [PATCH v6 2/6] mm/cma: introduce new zone, ZONE_CMA

Hello, I hava a question on cma zone. When we have cma zone, cma zone will be the highest zone of system. In android system, the most memory allocator is ION. Media system will alloc unmovable memory from it. On low memory scene, will the CMA zone always do balance? Should we transmit the

[PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags

It's useful to show the current memory in detail when alloc failed. And, there may be a lot of high order alloc failed, just show memory when an order 0 alloc failed. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file chan

[PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags

It's useful to show the current memory in detail when alloc failed. And, there may be a lot of high order alloc failed, just show memory when an order 0 alloc failed. Signed-off-by: Chen Feng --- drivers/staging/android/ion/ion_system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v3 3/6] mm/cma: populate ZONE_CMA

Hello, On 2016/6/23 10:52, Joonsoo Kim wrote: > On Wed, Jun 22, 2016 at 05:23:06PM +0800, Chen Feng wrote: >> Hello, >> >> On 2016/5/26 14:22, js1...@gmail.com wrote: >>> From: Joonsoo Kim <iamjoonsoo@lge.com> >>> >>> Until now, re

Re: [PATCH v3 3/6] mm/cma: populate ZONE_CMA

Hello, On 2016/6/23 10:52, Joonsoo Kim wrote: > On Wed, Jun 22, 2016 at 05:23:06PM +0800, Chen Feng wrote: >> Hello, >> >> On 2016/5/26 14:22, js1...@gmail.com wrote: >>> From: Joonsoo Kim >>> >>> Until now, reserved pages for CMA are managed in th

Re: [PATCH] mm, vmscan: set shrinker to the left page count

Thanks for you reply. On 2016/6/28 0:57, Vladimir Davydov wrote: > On Mon, Jun 27, 2016 at 07:02:15PM +0800, Chen Feng wrote: >> In my platform, there can be cache a lot of memory in >> ion page pool. When shrink memory the nr_to_scan to ion >> is always to li

Re: [PATCH] mm, vmscan: set shrinker to the left page count

Thanks for you reply. On 2016/6/28 0:57, Vladimir Davydov wrote: > On Mon, Jun 27, 2016 at 07:02:15PM +0800, Chen Feng wrote: >> In my platform, there can be cache a lot of memory in >> ion page pool. When shrink memory the nr_to_scan to ion >> is always to li

[PATCH] mm, vmscan: set shrinker to the left page count

- freed. Signed-off-by: Chen Feng <puck.c...@hisilicon.com> --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index c4a2f45..1ce3fc4 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -357,8 +357,8 @@ static unsigned long do_shrin

[PATCH] mm, vmscan: set shrinker to the left page count

- freed. Signed-off-by: Chen Feng --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index c4a2f45..1ce3fc4 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -357,8 +357,8 @@ static unsigned long do_shrink_slab(struct shrink_control

Re: [PATCH v3 3/6] mm/cma: populate ZONE_CMA

Hello, On 2016/5/26 14:22, js1...@gmail.com wrote: > From: Joonsoo Kim > > Until now, reserved pages for CMA are managed in the ordinary zones > where page's pfn are belong to. This approach has numorous problems > and fixing them isn't easy. (It is mentioned on previous

Re: [PATCH v3 3/6] mm/cma: populate ZONE_CMA

Hello, On 2016/5/26 14:22, js1...@gmail.com wrote: > From: Joonsoo Kim > > Until now, reserved pages for CMA are managed in the ordinary zones > where page's pfn are belong to. This approach has numorous problems > and fixing them isn't easy. (It is mentioned on previous patch.) > To fix this

Re: [PATCH v3 0/6] Introduce ZONE_CMA

On 2016/6/20 14:48, Joonsoo Kim wrote: > On Fri, Jun 17, 2016 at 03:38:49PM +0800, Chen Feng wrote: >> Hi Kim & feng, >> >> Thanks for the share. In our platform also has the same use case. >> >> We only let the alloc with GFP_HIGHUSER_MOVABLE in memory.c t

Re: [PATCH v3 0/6] Introduce ZONE_CMA

On 2016/6/20 14:48, Joonsoo Kim wrote: > On Fri, Jun 17, 2016 at 03:38:49PM +0800, Chen Feng wrote: >> Hi Kim & feng, >> >> Thanks for the share. In our platform also has the same use case. >> >> We only let the alloc with GFP_HIGHUSER_MOVABLE in memory.c t

Re: [PATCH v2] ION: Sys_heap: Add cached pool to spead up cached buffer alloc

Greg, I checkout your staging tree[1]. Not find this patch. Can you take it thanks! [1]git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git On 2016/6/5 23:02, Greg KH wrote: > On Sun, Jun 05, 2016 at 04:51:23PM +0800, Chen Feng wrote: >> Hi Greg, >> >> Ca

Re: [PATCH v2] ION: Sys_heap: Add cached pool to spead up cached buffer alloc

Greg, I checkout your staging tree[1]. Not find this patch. Can you take it thanks! [1]git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git On 2016/6/5 23:02, Greg KH wrote: > On Sun, Jun 05, 2016 at 04:51:23PM +0800, Chen Feng wrote: >> Hi Greg, >> >> Ca

Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

t; > Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn> Reviewed-by: Chen Feng <puck.c...@hisilicon.com> > --- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gp

Re: [PATCH -next] drm/hisilicon: Fix return value check in ade_dts_parse()

Thanks! On 2016/6/18 2:29, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the function devm_clk_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongju

Re: [PATCH v3 0/6] Introduce ZONE_CMA

Hi Kim & feng, Thanks for the share. In our platform also has the same use case. We only let the alloc with GFP_HIGHUSER_MOVABLE in memory.c to use cma memory. If we add zone_cma, It seems can resolve the cma migrate issue. But when free_hot_cold_page, we need let the cma page goto system

Re: [PATCH v3 0/6] Introduce ZONE_CMA

Hi Kim & feng, Thanks for the share. In our platform also has the same use case. We only let the alloc with GFP_HIGHUSER_MOVABLE in memory.c to use cma memory. If we add zone_cma, It seems can resolve the cma migrate issue. But when free_hot_cold_page, we need let the cma page goto system

Re: [PATCH v1 0/3] per-process reclaim

Hi Minchan, On 2016/6/13 15:50, Minchan Kim wrote: > Hi all, > > http://thread.gmane.org/gmane.linux.kernel/1480728 > > I sent per-process reclaim patchset three years ago. Then, last > feedback from akpm was that he want to know real usecase scenario. > > Since then, I got question from

Re: [PATCH v1 0/3] per-process reclaim

Hi Minchan, On 2016/6/13 15:50, Minchan Kim wrote: > Hi all, > > http://thread.gmane.org/gmane.linux.kernel/1480728 > > I sent per-process reclaim patchset three years ago. Then, last > feedback from akpm was that he want to know real usecase scenario. > > Since then, I got question from

Re: [Linaro-mm-sig] [RFC][PATCH 0/6] ion: improved ABI

The idea is good, define the heap ids in header file is inconvenient. But if we query the heaps information from user-space. It need to maintain this ids and name userspace one by one. The code may be complicated in different module user-space. In android, the gralloc and other lib will all use

Re: [Linaro-mm-sig] [RFC][PATCH 0/6] ion: improved ABI

The idea is good, define the heap ids in header file is inconvenient. But if we query the heaps information from user-space. It need to maintain this ids and name userspace one by one. The code may be complicated in different module user-space. In android, the gralloc and other lib will all use

Re: [PATCH v2] ION: Sys_heap: Add cached pool to spead up cached buffer alloc

Hi Greg, Can you take this patch? Thanks On 2016年05月24日 06:32, Laura Abbott wrote: > On 05/18/2016 08:03 PM, Chen Feng wrote: >> Add ion cached pool in system heap. This patch add a cached pool >> in system heap. It has a great improvement of alloc for cached >> buffer. >

Re: [PATCH v2] ION: Sys_heap: Add cached pool to spead up cached buffer alloc

Hi Greg, Can you take this patch? Thanks On 2016年05月24日 06:32, Laura Abbott wrote: > On 05/18/2016 08:03 PM, Chen Feng wrote: >> Add ion cached pool in system heap. This patch add a cached pool >> in system heap. It has a great improvement of alloc for cached >> buffer. >

Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA

Hi Joonsoo, On 2016/5/26 14:22, js1...@gmail.com wrote: > From: Joonsoo Kim > > Now, all reserved pages for CMA region are belong to the ZONE_CMA > and there is no other type of pages. Therefore, we don't need to > use MIGRATE_CMA to distinguish and handle differently

Re: [PATCH v3 5/6] mm/cma: remove MIGRATE_CMA

Hi Joonsoo, On 2016/5/26 14:22, js1...@gmail.com wrote: > From: Joonsoo Kim > > Now, all reserved pages for CMA region are belong to the ZONE_CMA > and there is no other type of pages. Therefore, we don't need to > use MIGRATE_CMA to distinguish and handle differently for CMA pages > and

[PATCH] mm: compact: remove watermark check at compact suitable

There are two paths calling this function. For direct compact, there is no need to check the zone watermark here. For kswapd wakeup kcompactd, since there is a reclaim before this. It makes sense to do compact even the watermark is ok at this time. Signed-off-by: Chen Feng <puc

[PATCH] mm: compact: remove watermark check at compact suitable

There are two paths calling this function. For direct compact, there is no need to check the zone watermark here. For kswapd wakeup kcompactd, since there is a reclaim before this. It makes sense to do compact even the watermark is ok at this time. Signed-off-by: Chen Feng --- mm/compaction.c

Re: [PATCH] mm: compact: fix zoneindex in compact

On 2016/5/20 1:45, Vlastimil Babka wrote: > On 19.5.2016 19:23, Hugh Dickins wrote: >> On Thu, 19 May 2016, Vlastimil Babka wrote: >>> On 05/19/2016 02:11 PM, Vlastimil Babka wrote: >>>> On 05/19/2016 01:58 PM, Chen Feng wrote: >>>>> While testing

  1   2   3   4   >