[PATCH 1/1] drivers:staging:vt6656: remove usb_device_reset in main_usb.c:

2017-04-19 Thread Chewie Lin
And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/m

[PATCH 1/1] drivers:staging:vt6656: remove usb_device_reset in main_usb.c:

2017-04-19 Thread Chewie Lin
And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/stag

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

2017-04-18 Thread Chewie Lin
Hi, This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time! linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: usb_device_reset drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

2017-04-18 Thread Chewie Lin
Hi, This is a simple patch as a part of learning about kernel device driver in the Eudyptula challenge. thanks again for your time! linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: usb_device_reset drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

2017-04-18 Thread Chewie Lin
usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/stagi

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

2017-04-18 Thread Chewie Lin
usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > >

Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote: > > Swap string in the dev_warn() call with __func__ argument, instead of > > explicitly calling the function name in the string: > > > >

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
Hi All, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
Hi All, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. linsh Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
ail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-04-17 Thread Chewie Lin
ail status=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
On Sat, Apr 01, 2017 at 04:32:39AM +0100, Al Viro wrote: > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote: > > Replace string with formatted arguments in the dev_warn() call. It removes > > the checkpatch warning: > > > > WARNING: Prefer using "%s

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
On Sat, Apr 01, 2017 at 04:32:39AM +0100, Al Viro wrote: > On Fri, Mar 31, 2017 at 06:59:19PM -0700, Chewie Lin wrote: > > Replace string with formatted arguments in the dev_warn() call. It removes > > the checkpatch warning: > > > > WARNING: Prefer using "%s

Re: [PATCH] drivers: fixed a checkpatch warning

2017-03-31 Thread Chewie Lin
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin <li...@oregonstate.edu> > > --- > > drivers/staging/vt6656/m

Re: [PATCH] drivers: fixed a checkpatch warning

2017-03-31 Thread Chewie Lin
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 f

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
On Fri, Mar 31, 2017 at 07:45:09PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote: > > On 03/31/17 18:59, Chewie Lin wrote: > > > Replace string with formatted arguments in the dev_warn() call. It removes > > > the checkpatch warn

Re: [PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
On Fri, Mar 31, 2017 at 07:45:09PM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 19:15 -0700, Randy Dunlap wrote: > > On 03/31/17 18:59, Chewie Lin wrote: > > > Replace string with formatted arguments in the dev_warn() call. It removes > > > the checkpatch warn

[PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
s=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 001/001] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
s=%d\n", status); total: 0 errors, 1 warnings, 1058 lines checked And after fix: main_usb.c has no obvious style problems and is ready for submission. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH] eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi all: Better and improved changelog version 3. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656

[PATCH] eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi all: Better and improved changelog version 3. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning drivers/staging/vt6656

[PATCH] eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi greg and forest: I hate to bother but one more, with better changelog. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning

[PATCH] eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi greg and forest: I hate to bother but one more, with better changelog. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): drivers/staging/vt6656/main_usb.c: checkpatch warning

[PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_us

[PATCH 01/01] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
Replace string with formatted arguments in the dev_warn() call. It removes the checkpatch warning. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_

[PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning

2017-03-31 Thread Chewie Lin
fix a checkpatch warning: WARNING: Prefer using "%s", __func__ to embedded function names Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/

[PATCH] Eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi greg k-h and forest: Sorry about all the spam I've been sending earlier. One more try. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging

[PATCH] Eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi greg k-h and forest: Sorry about all the spam I've been sending earlier. One more try. I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging

[PATCH] Eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0

[PATCH] Eudyptula challenge

2017-03-31 Thread Chewie Lin
Hi, I'm submitting this patch as part of Eudyptula challenge to fix a coding style problem. Thanks for taking time on this trivial patch. sl424 Chewie Lin (1): fixed a checkpatch warning drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.10.0

[PATCH] drivers: fixed a checkpatch warning

2017-03-31 Thread Chewie Lin
fixed a coding style error/warning. Signed-off-by: Chewie Lin <li...@oregonstate.edu> --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af

[PATCH] drivers: fixed a checkpatch warning

2017-03-31 Thread Chewie Lin
fixed a coding style error/warning. Signed-off-by: Chewie Lin --- drivers/staging/vt6656/main_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index 9e074e9..2d9e7af 100644 --- a/drivers/staging