Re: [PATCH][V2] RDMA/nes: do not leak uninitialized resp.reserved to userspace Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit

2017-09-05 Thread Chien Tin Tung
On Mon, Sep 04, 2017 at 02:37:05PM +0100, Colin King wrote: > From: Colin Ian King > > resp.reserved has not been initialized and so the copy_to_user (via > ib_copy_to_udata) is copying uninitialized data from the stack back > to user space which is a potential information leak. Fix this by > ini

Re: [infiniband-hw-i40iw] question about identical code for different branches

2017-05-18 Thread Chien Tin Tung
Thu, May 18, 2017 at 08:00:29AM +0300, Leon Romanovsky wrote: > On Wed, May 17, 2017 at 05:06:54PM -0500, Gustavo A. R. Silva wrote: > > > > Hello everybody, > > > > While looking into Coverity ID 1362263 I ran into the following piece of > > code at drivers/infiniband/hw/i40iw/i40iw_virtchnl.c:44

Re: [PATCH] i40iw: pass hw_stats by reference rather than by value

2016-03-28 Thread Chien Tin Tung
On Mon, Mar 28, 2016 at 12:14:46PM +0100, Colin King wrote: > From: Colin Ian King > > passing hw_stats by value requires a 280 byte copy so instead > pass it by reference is much more efficient. > > Signed-off-by: Colin Ian King Thank you for the patch Colin. Acked-by: Chien Tin Tung