Gregory Nowak writes:
> keymap
> I believe this is the currently active kernel keymap. I'm not sure of
> the format, probably what dumpkeys(1) and showkey(1) use. Echoing
> different values here should allow for remapping speakup's review
> commands besides remapping the keyboard as a whole.
AFA
Okash Khawaja writes:
> Finally there is an issue where text in output buffer sometimes gets
> garbled on SMP systems, but we can continue working on it after the
> driver is moved out of staging, if that's okay. Basically we need a
> reproducer of this issue.
What kind of reproducer do you need
e Linux only supports 16bit characters,
> we can just hardcode the UTF-8 encoding.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
ngs.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault
Reviewed-by: Chris Brannon
Looks good to me.
Walt Feasel writes:
> Make email correction for k...@reisers.ca
>
> Signed-off-by: Walt Feasel
Acked-by: Chris Brannon
> ---
> v2 makes changes to correct for email format patch submission
>
> drivers/staging/speakup/TODO | 2 +-
> 1 file changed, 1 insertion(+)
Walt Feasel writes:
> Modified email address per the TODO file in
> speakup's email listing, also verified email
> address from speakup's website
NAK. The website needs updating, because it has Kirk's old addresses.
k...@reisers.ca is correct.
Markus Mayer writes:
> After introducing generic strltolower() and strtolower(), spk_strlwr()
> is no longer needed.
>
> Signed-off-by: Markus Mayer
> Acked-by: Samuel Thibault
Acked-by: Chris Brannon
Haven't looked at much kernel code in a while, but this looks good.
-- Chris
Dan Carpenter writes:
> Good eye for spotting the memory corruption bug!
>
> This is a bug fix, so the fix should go in a separate patch and not
> merged with a code cleanup patch. Ordinary users can trigger this so
> it's a security bug and separating it out is extra important.
Ok. I just sen
Raphael S Carvalho writes:
> Wouldn't the following code (right before the statement: if
> (param->var_id == VOICE))
> check if value is out of range?
>
> value = simple_strtol(cp, NULL, 10);
> ret = spk_set_num_var(value, param, len);
> if (ret == -ERANGE) {
> var_data = param->data;
> pr_warn(
"Raphael S.Carvalho" writes:
> + /*
> + * If voice was just changed, we might need to reset our default
> + * pitch and volume.
> + */
> + if (param->var_id == VOICE) {
> + spk_reset_default_value("pitch", synth->defa
10 matches
Mail list logo